Re: [PATCH] hv: hv_fcopy: drop the obsolete message on transfer failure

2014-11-26 Thread Greg KH
On Tue, Nov 11, 2014 at 09:03:26PM -0800, Dexuan Cui wrote: In the case the user-space daemon crashes, hangs or is killed, we need to down the semaphore, otherwise, after the daemon starts next time, the obsolete data in fcopy_transaction.message or fcopy_transaction.fcopy_msg will be used

Re: [PATCH] staging: octeon: Fix checkpatch warning

2014-11-26 Thread Greg KH
On Thu, Nov 27, 2014 at 12:35:23AM +, Luis de Bethencourt wrote: On Wed, Nov 26, 2014 at 01:45:23PM -0800, Greg KH wrote: On Tue, Nov 25, 2014 at 01:26:14PM +, Luis de Bethencourt wrote: This patch fixes the checkpatch.pl warnings: WARNING: line over 80 characters

Re: [PATCH] staging: r8188eu: Add new device ID for DLink GO-USB-N150

2014-11-27 Thread Greg KH
On Thu, Nov 27, 2014 at 10:10:21AM -0600, Larry Finger wrote: The DLink GO-USB-N150 with revision B1 uses this driver. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance

2014-11-28 Thread Greg KH
On Thu, Nov 27, 2014 at 07:34:10PM +0100, Loïc Pefferkorn wrote: Hello Greg, After some investigation, I think that removing these wrappers is not going to improve the code readability: On Wed, Nov 26, 2014 at 12:54:43PM -0800, Greg KH wrote: On Wed, Nov 26, 2014 at 05:15:48PM +0100

[GIT PULL] Staging driver fixes for 3.18-rc7

2014-11-28 Thread Greg KH
The following changes since commit 206c5f60a3d902bc4b56dab2de3e88de5eb06108: Linux 3.18-rc4 (2014-11-09 14:55:29 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.18-rc7 for you to fetch changes up to

Re: Possible memory leak in function (reserve_range) not freeing pointer (regionid)

2014-11-30 Thread Greg KH
On Sun, Nov 30, 2014 at 02:00:45PM -0600, Ahmed Tamrawi wrote: Bug Report: https://bugzilla.kernel.org/show_bug.cgi?id=89101 Linux Version [3.17-rc1] That's a very old kernel version. Configuration: Default configuration for x86 Function (reserve_range) in file (drivers/pnp/system.c)

Re: [PATCH v2] Staging: rtl8188eu: {core, hal, include}: Removed inline function

2014-12-02 Thread Greg KH
On Sat, Nov 29, 2014 at 11:48:07AM +0100, Abel Moyo wrote: Removed inline function get_my_bssid and open coded all its references Signed-off-by: Abel Moyo abelmoyo...@gmail.com --- Changes in v2: - Remove inline function entirely and open code the implementation instead of

Re: [PATCH] Drivers:staging:octeon: Fixed checkpatch warning

2014-12-02 Thread Greg KH
On Sat, Nov 29, 2014 at 11:04:00AM +0530, Athira Lekshmi wrote: Fixed the checkpatch warning: Missing a blank line after declarations Signed-off-by: Athira Lekshmi andnlnb...@gmail.com --- drivers/staging/octeon/ethernet-rx.c |1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration

2014-12-02 Thread Greg KH
On Sat, Nov 29, 2014 at 06:25:30PM +0530, Anjana Sasindran wrote: This patch fix the checkpatch.pl warning WARNING:Missing a blank line after declaration Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com --- drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 + 1

Re: [PATCH] Staging: ft1000: fix spaces around comparisons in ft1000_debug.c

2014-12-02 Thread Greg KH
On Tue, Dec 02, 2014 at 09:11:15AM -0600, Paul Hedman wrote: This fix fixes spacing issues around operators, e.g. i=0 to i = 0, found by the checkpatch.pl tool. Please wrap your changelog at the correct column. Signed-off-by: Paul Hedman p...@mybb.com ---

Re: [PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c

2014-12-02 Thread Greg KH
On Mon, Dec 01, 2014 at 09:54:45AM +0800, Fred wrote: Fixed the following warnings in sparse: drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom' was not declared. Should it be static? drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning: symbol

Re: [PATCH] Staging: ft1000: fix spaces around comparisons in ft1000_debug.c

2014-12-02 Thread Greg KH
On Tue, Dec 02, 2014 at 07:10:41PM -0600, Paul H wrote: A tutorial I read suggested using a different branch for applying the patches; I named it fix-spaces. It would appear it is mistaken then? You have to make your patch against the linux-next tree, not Linus's tree, so as to not duplicate

Re: [PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c

2014-12-02 Thread Greg KH
On Wed, Dec 03, 2014 at 10:31:55AM +0800, Fred Chou wrote: From: Fred fred.chou...@gmail.com One word name, and then: Signed-off-by: Fred Chou fred.chou...@gmail.com Two word name. Unacceptable, you know this... ___ devel mailing list

Re: [PATCH] Staging: dgnc: Fix long line coding style issues in dgnc_cls.h

2014-12-03 Thread Greg KH
On Wed, Dec 03, 2014 at 05:07:28PM +, Sean Cleator wrote: A patch to fix the rest of the long line warnings in the dgnc_cls.h file found by the checkpatch.pl tool Signed-off-by: Sean Cleator seanclea...@hotmail.co.uk --- drivers/staging/dgnc/dgnc_cls.h | 22 +- 1

Re: Possible memory leak in function (reserve_range) not freeing pointer (regionid)

2014-12-03 Thread Greg KH
On Sun, Nov 30, 2014 at 09:49:23PM -0600, Ahmed Tamrawi wrote: On Sun, Nov 30, 2014 at 8:51 PM, Greg KH gre...@linuxfoundation.org wrote: On Sun, Nov 30, 2014 at 02:00:45PM -0600, Ahmed Tamrawi wrote: Bug Report: https://bugzilla.kernel.org/show_bug.cgi?id=89101 Linux Version [3.17-rc1

Re: [PATCH] Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer

2014-12-03 Thread Greg KH
On Wed, Dec 03, 2014 at 05:12:09PM -0800, Arun wrote: --- drivers/staging/bcm/CmHost.h |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) That's a really odd subject, don't you agree? :) ___ devel mailing list

Re: [PATCH] Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer

2014-12-03 Thread Greg KH
On Wed, Dec 03, 2014 at 05:31:59PM -0800, arun vijayshankar wrote: Hi Greg, If you turn off HTML email, your message will not get rejected by the mailing lists :) I completely agree! I thought of keeping the patch summary as the subject, but I wasn't sure and ending up entering nothing. Git

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Greg KH
On Fri, Dec 05, 2014 at 12:03:47AM -0800, Tristan Lelong wrote: This patch fix a sparse warning in lustre sources warning: incorrect type in argument 1 (different address spaces) expected void [noderef] asn:1*to got char *noident This is done by adding the missing __user attribute

Re: [PATCH 1/1] Drivers: hv: vmbus: Implement a clockevent device

2014-12-05 Thread Greg KH
On Fri, Dec 05, 2014 at 07:58:44PM -0800, K. Y. Srinivasan wrote: Implement a clockevent device based on the timer support available on Hyper-V. In this version of the patch I have addressed Jason's review comments. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Reviewed-by: Jason Wang

Re: [PATCH] comedi: indent checkpatch errors and warnings fixed

2014-12-07 Thread Greg KH
no space before tabs, no spaces at the start of a line and missing a blank line after declarations. Those are all different types of warnings, please only do one thing per patch. Please break this up into smaller pieces, only doing one thing, and send this as a series of patches. thanks, greg kh

Re: [PATCH] staging: rts5208: Removed the new typedefs

2014-12-10 Thread Greg KH
On Wed, Dec 10, 2014 at 07:24:16PM +0530, Anjana Sasindran wrote: This patch fix the checkpatch.pl warning: WARNING: do not add new typedefs Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com --- drivers/staging/rts5208/rtsx_sys.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] staging: lustre: Fix the warning messages about casting without __user macro

2014-12-10 Thread Greg KH
On Wed, Dec 10, 2014 at 07:09:59AM +, Al Viro wrote: On Tue, Dec 09, 2014 at 10:56:12PM -0800, Shalin Mehta wrote: From: Shalin Mehta shalinmeht...@gmail.com This issue is showed up while compiling with sparse. The iov_base in struct iovec struct explicitly declares that the

Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()

2014-12-10 Thread Greg KH
On Wed, Dec 10, 2014 at 11:42:43AM -0800, K. Y. Srinivasan wrote: Fix a bug in vmbus_establish_gpadl(). I would like to thank Michael Brown mc...@ipxe.org for seeing this bug. Then use the Reported-by: tag with his name in this patch please. thanks, greg k-h

Re: Fwd: improve support for usb board camera

2014-12-10 Thread Greg KH
On Wed, Dec 10, 2014 at 07:35:48PM -0500, Kristopher Borer wrote: Hello, I am looking to improve support for a USB board camera. It currently works fairly well, but we occasionally cause kernel panics while using OpenCV on Ubuntu 14.04. What kernel version is that, and what is the oops

Re: Fwd: improve support for usb board camera

2014-12-11 Thread Greg KH
On Thu, Dec 11, 2014 at 07:43:15AM -0500, Kristopher Borer wrote: The kernel version is 3.13.0-32-generic Ick, that's 68 thousand patches old (i.e. one year...) Have you tried the 3.18 kernel release to see if it is better, because: Here is one example: BUG: unable to handle kernel NULL

Re: [PATCH] staging: imx-drm: Fix modular build of DRM_IMX_IPUV3

2013-11-19 Thread Greg KH
On Tue, Nov 19, 2013 at 08:56:59PM -0500, Josh Boyer wrote: On Mon, Nov 18, 2013 at 10:03:10AM +0100, Sascha Hauer wrote: On Tue, Nov 12, 2013 at 12:15:45PM -0500, Josh Boyer wrote: commit b8d181e408af (staging: drm/imx: add drm plane support) added a file to the make target for

Re: [PATCH] staging: imx-drm: Fix modular build of DRM_IMX_IPUV3

2013-11-20 Thread Greg KH
On Wed, Nov 20, 2013 at 08:16:32AM -0500, Josh Boyer wrote: On Tue, Nov 19, 2013 at 09:39:19PM -0800, Greg KH wrote: On Tue, Nov 19, 2013 at 08:56:59PM -0500, Josh Boyer wrote: On Mon, Nov 18, 2013 at 10:03:10AM +0100, Sascha Hauer wrote: On Tue, Nov 12, 2013 at 12:15:45PM -0500, Josh

Re: new to this mailing list

2013-11-21 Thread Greg KH
On Thu, Nov 21, 2013 at 09:48:50AM +0700, cotobian wrote: Hello developers! I'm new to Linux kernel, haven't really worked on any real kernel projects but willing to do anything possible to help. Please tell me if there is something i could do. drivers/staging/*/TODO

Re: [PATCH] Staging:comedi:pcmmio Fixed a printk format in debug section

2013-11-23 Thread Greg KH
On Sat, Nov 23, 2013 at 05:05:32PM +0530, Abhishek Sudhakaran wrote: Fixed a printk statement in the debug section where the string terminator was misplaced. Signed-off-by: Abhishek Sudhakaran itzura...@gmail.com --- drivers/staging/comedi/drivers/pcmmio.c |2 +- 1 file changed, 1

Re: [PATCH 15/39] staging: comedi: comedi_fops: remove use of DPRINTK

2013-11-25 Thread Greg KH
On Mon, Nov 25, 2013 at 08:16:32PM +, Hartley Sweeten wrote: On Monday, November 25, 2013 12:54 PM, Greg KH wrote: On Fri, Nov 22, 2013 at 10:47:40AM -0700, H Hartley Sweeten wrote: Use dev_dbg(), or pr_debug() when dev is not valid, instead of the DPRINTK macro to output the comedi

Re: [PATCH] staging: slicoss: fix possible missing iounmap

2013-11-25 Thread Greg KH
On Fri, Nov 15, 2013 at 11:30:07PM +0100, Laurent Navet wrote: if slic_card_locate failed, memmapped_ioaddr is not unmapped. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/staging/slicoss/slicoss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) This patch causes a

Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Greg KH
On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: dev_*() assumes 'go' is already initialized, so need use pr_*() instead of before 'go' initialized. Related warning (with allmodconfig under hexagon): CC [M] drivers/staging/media/go7007/go7007-usb.o

[GIT PULL] Staging driver fixes for 3.13-rc2

2013-11-27 Thread Greg KH
The following changes since commit 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae: Linux 3.13-rc1 (2013-11-22 11:30:55 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.13-rc2 for you to fetch changes up to

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Greg KH
On Wed, Dec 04, 2013 at 06:09:41PM +, Serban Constantinescu wrote: +#define size_helper(x) ({\ + size_t __size; \ + if (!is_compat_task())

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Greg KH
On Wed, Dec 04, 2013 at 01:55:34PM -0800, Colin Cross wrote: On Wed, Dec 4, 2013 at 1:43 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Dec 04, 2013 at 12:46:42PM -0800, Colin Cross wrote: On Wed, Dec 4, 2013 at 10:35 AM, Greg KH gre...@linuxfoundation.org wrote: snip

Re: [PATCH v1 2/9] staging: android: binder: Add binder_copy_to_user()

2013-12-04 Thread Greg KH
On Wed, Dec 04, 2013 at 06:09:34PM +, Serban Constantinescu wrote: This patch adds binder_copy_to_user() to be used for copying binder commands to user address space. This way we can abstract away the copy_to_user() calls and add separate handling for the compat layer. Signed-off-by:

Re: [PATCH v1 1/9] staging: android: binder: Move some of the logic into subfunction

2013-12-05 Thread Greg KH
On Thu, Dec 05, 2013 at 11:18:22AM +0300, Dan Carpenter wrote: On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote: +static void bc_increfs_done(struct binder_proc *proc, + struct binder_thread *thread, uint32_t cmd, + void __user *node_ptr, void __user

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-05 Thread Greg KH
On Thu, Dec 05, 2013 at 06:31:25PM +, Serban Constantinescu wrote: Hi all, Thanks for your feedback! Sadly enough, being in a different time-zone, is not useful. Sorry for the confusion related to why is this patch needed or not. I should highlight a bit more what is the patch

Re: [PATCH v2 03/13] staging: comedi: pcmuio: tidy up pcmuio_handle_asic_interrupt()

2013-12-06 Thread Greg KH
Minor nit, can you name your v2 patches like: [PATCH 03/13 v2] ... so that when I sort them in mutt, they show up in the proper order with the other patches in the series? Don't worry about this one, I got it, but in the future it would be great. thanks, greg k-h

Re: [PATCH 03/10] Staging: bcm: DDRInit: added space after commas.

2013-12-09 Thread Greg KH
On Sat, Dec 07, 2013 at 02:49:05AM -0500, Gary Rookard wrote: This is the third patch of a series. What series? Again, this isn't an ok changelog entry, did you read Documentation/SubmittingPatches for what should be here? thanks, greg k-h ___ devel

Re: [PATCH 11/11] Staging: bcm: DDRInint: tidy up indent issue.

2013-12-09 Thread Greg KH
On Sat, Dec 07, 2013 at 03:46:48AM -0500, Gary Rookard wrote: This is the eleventh patch of a series. No it isn't :) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [Suggestion] drivers: staging: dgrp: dgrp_net_ops.c: 'buf' is used without initialized.

2013-12-09 Thread Greg KH
On Tue, Dec 10, 2013 at 01:07:58PM +0800, Chen Gang wrote: Hello Maintainers: The compiler help me find a warning about it, please help check thanks. The related git commit: b73db54 Staging: dgrp: Refactor the function dgrp_receive() in drrp_net_ops.c The related warning (with

Re: [PATCH 1/7] Staging: bcm: DDRinit: fixed indentation coding style issues

2013-12-10 Thread Greg KH
On Tue, Dec 10, 2013 at 06:05:29AM -0500, Gary Rookard wrote: Fixed coding style issues. Which issues? Signed-off-by: Gary Alan Rookard garyrook...@gmail.com --- On branch staging-next drivers/staging/bcm/DDRInit.c | 1892 - 1 file changed, 946

Re: [PATCH] Staging: TIDSPBRIDGE: Use vm_iomap_memory for mmap-ing instead of remap_pfn_range

2013-12-11 Thread Greg KH
On Wed, Dec 11, 2013 at 01:27:17PM +0300, Dan Carpenter wrote: On Wed, Dec 11, 2013 at 11:57:04AM +0200, Ivaylo Dimitrov wrote: On 11.12.2013 10:33, Dan Carpenter wrote: On Wed, Dec 11, 2013 at 09:45:52AM +0200, Ivajlo Dimitrov wrote: I can pick your changes and re-send the original patch

Re: [PATCH] Staging:bcm:DDRInit: fixed issues w/ indentation

2013-12-13 Thread Greg KH
Care to put a ' ' after your ':'? Look at how other commit messages look like, I really don't want to have to hand-edit commits, I just can't scale when doing that (remember, I get 1000 emails a day...) On Fri, Dec 13, 2013 at 01:00:21AM -0500, Gary Rookard wrote: restructured the levels

Re: [PATCH 1/8] staging:bcm:InterfaceDld: fix checkpatch error

2013-12-15 Thread Greg KH
On Sun, Dec 15, 2013 at 07:30:11AM +0530, Gokulnath A wrote: On Sat, Dec 14, 2013 at 4:41 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Sat, Dec 14, 2013 at 01:05:29AM +0530, Gokulnath A wrote: fixed all the errors found by checkpatch.pl This is not very useful. The subjects

Re: [PATCH 3/8] staging: dgap: Fixed trailing white space

2013-12-17 Thread Greg KH
On Tue, Dec 17, 2013 at 12:48:41PM +0900, Masanari Iida wrote: This patch fixes ERROR: trailing whitespace found by checkpatch.pl, within dgap_fep5.h Signed-off-by: Masanari Iida standby2...@gmail.com The first 3 patches in this series has the exact same Subject, so I can't apply them.

Re: [PATCH 7/8] staging: dgap: Fixed trailing white space in dgap_sysfs.c

2013-12-17 Thread Greg KH
On Tue, Dec 17, 2013 at 12:48:45PM +0900, Masanari Iida wrote: This patch fixes ERROR: trailing whitespace found by checkpatch.pl, within dgap_sysfs.c --- drivers/staging/dgap/dgap_sysfs.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) You don't have a signed-off-by

Re: [PATCH] staging: xillybus: Return -ENOMEM if *_iomap fails instead of 0

2013-12-17 Thread Greg KH
On Mon, Dec 16, 2013 at 03:50:39PM +0200, Eli Billauer wrote: Bug fix: The error code was not set, so the error condition wasn't reflected in the return value. Reported-by: Wei Yongjun yongjun_...@trendmicro.com.cn Signed-off-by: Eli Billauer eli.billa...@gmail.com Wei wrote half of this

Re: [PATCH V2] staging:bcm: Code cleanup for InterfaceDld.c

2013-12-17 Thread Greg KH
On Tue, Dec 17, 2013 at 10:38:47PM +0530, Gokulnath A wrote: As per the TODO, 1. Removed the developer debug BCM_DEBUG_PRINT() messages. 2. Fixed all the errors found by checkpatch.pl script. 3. Fixed all the line over 80 characters warning found by checkpatch.pl script. As you say you

Re: [PATCH] Staging: bcm: DDRInit: fixed bracing issues.

2013-12-17 Thread Greg KH
On Mon, Dec 16, 2013 at 03:51:58AM -0500, Gary Rookard wrote: removed braces from single statement conditonals. if, else, while opening brace placement was moved to last on first line of each, and closing brace moved to first on new line to follow the linux kernel coding style thus removing

Re: [PATCH] Staging: bcm: DDRInit: fixed comment issues.

2013-12-17 Thread Greg KH
On Fri, Dec 13, 2013 at 10:02:11AM -0500, Gary Rookard wrote: replaced C99 style with C89 standard style comments to follow the linux kernel coding style thus fixing checkpatch errors respectfully. also, in some instances changed comments from inline to side-bar style. Why did you do that?

Re: [PATCH v2] vme_user: Update API to work in mixed environments

2013-12-17 Thread Greg KH
On Mon, Dec 09, 2013 at 10:05:40AM -0600, Aaron Sierra wrote: This patch updates the vme_master and vme_slave structures to use types with well defined size and to prevent the compiler from inserting padding (between enable and vme_addr for one). The original vme_master and vme_slave structs

[GIT PULL] Staging driver fixes for 3.13-rc5

2013-12-18 Thread Greg KH
The following changes since commit 319e2e3f63c348a9b66db4667efa73178e18b17d: Linux 3.13-rc4 (2013-12-15 12:31:33 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.13-rc5 for you to fetch changes up to

Re: [PATCH ver2, 07/8] stating: dgap: Fixed trailing white space in dgap_sysfs.c

2013-12-18 Thread Greg KH
On Thu, Dec 19, 2013 at 01:05:27AM +0900, Masanari Iida wrote: This patch fixes ERROR: trailing whitespace found by checkpatch.pl, within dgap_sysfs.c Signed-off-by: Masanari Iida standby2...@gmail.com I see a bunch of patches missing in this series, can you please resend the whole series,

Re: [PATCH 01/11] staging: r8188eu: Remove pointless thread_exit macro

2013-12-20 Thread Greg KH
With this series applied, I get a ton of unused variable warnings, can you please fix them up now too? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 02/11] staging: r8188eu: Remove wrapper around spin_lock_bh

2013-12-20 Thread Greg KH
On Fri, Dec 20, 2013 at 10:36:09AM -0600, Larry Finger wrote: On 12/20/2013 01:14 AM, Dan Carpenter wrote: On Thu, Dec 19, 2013 at 10:38:34PM -0600, Larry Finger wrote: Some comment lines that mentioned spin_lock_bh() are also removed. Signed-off-by: Larry Finger larry.fin...@lwfinger.net

Re: [PATCH 01/11] staging: r8188eu: Remove pointless thread_exit macro

2013-12-20 Thread Greg KH
On Fri, Dec 20, 2013 at 02:30:39PM -0600, Larry Finger wrote: On 12/20/2013 01:18 PM, Greg KH wrote: On Fri, Dec 20, 2013 at 11:22:35AM -0600, Larry Finger wrote: On 12/20/2013 10:58 AM, Greg KH wrote: With this series applied, I get a ton of unused variable warnings, can you please fix

Re: [PATCH 0/2] Fix problems with earlier patches

2013-12-20 Thread Greg KH
On Fri, Dec 20, 2013 at 02:58:43PM -0600, Larry Finger wrote: A recent set of patches revealed that a line of code had been incorrectly removed in an earlier edit. That line is added back. In addition, a configuration problem resulted in a number of unused variable warnings. Thanks for the

Re: [RFC] staging: r8188eu: Fix sparse warnings in core/rtw_br_ext.c

2013-12-21 Thread Greg KH
On Sat, Dec 21, 2013 at 07:31:08PM -0600, Larry Finger wrote: Please tell me if the following fixes are appropriate. In particular, I am uncertain of the __force attributes. Thanks, Larry Sparse lists the following: CHECK drivers/staging/rtl8188eu/core/rtw_br_ext.c

Re: [PATCH] Staging: Android: Fixed coding issue return parenthesis in alarm_dev.c

2013-12-28 Thread Greg KH
On Sat, Dec 28, 2013 at 11:03:28AM -0500, Arthur Schwalbenberg wrote: This is a patch to the alarm_dev.c file that fixes up a return is not a function warning found by the checkpatch.pl tool Signed-off-by: Arthur Schwalbenberg arthurs...@gmail.com Why the odd indentation?

Re: [PATCHv2 7/7] vt6655: Remove typedefs in 80211hdr.h

2014-01-08 Thread Greg KH
On Tue, Jan 07, 2014 at 01:11:51PM +0100, Michael Gunselmann wrote: From: Martin Hofmann martin.hofm...@studium.uni-erlangen.de The file 80211hdr.h contained typedefs for 5 types. To satisfy checkpatch, this commit removes them. In 11 other files, every occurence of a now deleted type has

Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-08 Thread Greg KH
On Wed, Jan 08, 2014 at 03:48:35PM -0800, K. Y. Srinivasan wrote: Implement the file copy service for Linux guests on Hyper-V. This permits the host to copy a file (over VMBUS) into the guest. This facility is part of guest integration services supported on the Windows platform. Here is a link

Re: [PATCH] staging: lustre: Fix typo in lustre/ldlm

2014-01-08 Thread Greg KH
On Sun, Dec 22, 2013 at 12:42:20AM +0900, Masanari Iida wrote: Correct spelling typo in lustre/ldlm Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 8 drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 2 +-

Re: [PATCH 1/2] Staging: lustre: Fix line length exceeding 80 characters

2014-01-08 Thread Greg KH
On Sun, Jan 05, 2014 at 12:30:51PM -0800, Joe Perches wrote: On Mon, 2014-01-06 at 01:41 +0530, MonamAgarwal wrote: This patch fixes the following checkpatch.pl warning in lustre/ldlm/interval_tree.c WARNING: line over 80 characters in the file [] diff --git

Re: [PATCH 2/2] Staging: lustre: Fix return does not need parantheses

2014-01-08 Thread Greg KH
On Mon, Jan 06, 2014 at 01:48:07AM +0530, MonamAgarwal wrote: This patch fixes the following checkpatch.pl warning in lustre/ldlm/interval_tree.c ERROR: return is not a function, parentheses are not required Signed-off-by: MonamAgarwal monamagarwal...@gmail.com I need a semblance of a real

Re: [PATCH 1/1] staging: Driver for downloading Xilinx FPGA image

2014-01-08 Thread Greg KH
On Wed, Jan 08, 2014 at 10:00:15PM -0800, Insop Song wrote: This module downloads Xilinx FPGA image using gpio pins DESIGN -- * load Xilinx FPGA bitstream format[1] image using kernel firmware * framework, request_firmware() Odd formatting of the changelog entry, care to fix this up?

Re: [PATCH 1/1] staging: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Greg KH
On Thu, Jan 09, 2014 at 12:21:06AM -0800, Insop Song wrote: On Wed, Jan 8, 2014 at 10:16 PM, Greg KH gre...@linuxfoundation.org wrote: Why is this driver going into the staging directory? We need a TODO file listing the issues that need to be taken care of in order to be able to move

Re: [PATCH 3/3] Staging: rtl8187se: ieee80211: ieee80211_softmac.c: mark symbols as static

2014-01-09 Thread Greg KH
On Thu, Jan 09, 2014 at 04:41:07PM +0530, m...@anmolsarma.in wrote: From: Anmol Sarma m...@anmolsarma.in Fixes the following sparse warnings: 50:14: warning: symbol 'ieee80211_MFIE_rate_len' was not declared. Should it be static? 68:6: warning: symbol 'ieee80211_MFIE_Brate' was not

Re: [PATCH v3 2/2] staging: fpgaboot: Driver for downloading Xilinx FPGA image

2014-01-09 Thread Greg KH
On Thu, Jan 09, 2014 at 01:36:15AM -0800, Insop Song wrote: --- /dev/null +++ b/drivers/staging/gs_fpgaboot/TODO @@ -0,0 +1,14 @@ +TODO: +- get bus width input instead of hardcoded bus width + + - make it easier to config different programming method for + other embedded

Re: [PATCH] staging: usbip: userspace: add support for viewing imported devices

2014-01-09 Thread Greg KH
On Tue, Jan 07, 2014 at 09:05:56PM +0200, Valentina Manea wrote: As of Matt Mooney's major refactoring in 2011, usbip port option was left out. Add support for this option in a manner similar to the old implementation. Sample output: Imported USB devices Port 00:

Re: [PATCH]

2014-01-09 Thread Greg KH
On Tue, Dec 24, 2013 at 09:45:03AM -0600, Evan Hosseini wrote: --- Staging: android: fix parenthesis coding style issue in alarm-dev.c What happened to your Subject:? Also, why put the '---' line here? That means that git will delete everything else. This is a patch to the alarm-dev.c file

Re: your mail

2014-01-09 Thread Greg KH
On Mon, Dec 30, 2013 at 05:40:44PM +, Joe Borg wrote: From 6d9f6446434c4021cc9452e31c374ac50e08f0f9 Mon Sep 17 00:00:00 2001 From: Joe Borg r...@josephb.org This isn't matching your from: line on your email, why should I trust it? And doing kernel work as 'root'? That's not a good idea

Re: [PATCH] DAS1800: Fixed typeo.

2014-01-09 Thread Greg KH
On Thu, Jan 02, 2014 at 05:10:00PM +, Joe Borg wrote: Fixed foo * bar should be foo *bar. Fixed by Joe Borg r...@josephb.org That's not a signed-off-by: line, did you run this patch through scripts/checkpatch.pl? Also, your subject line has a typo :) thanks, greg k-h

Re: [PATCH] DAS6042: Fixing typeo.

2014-01-09 Thread Greg KH
On Thu, Jan 02, 2014 at 05:25:20PM +, Joe Borg wrote: Fixing foo * bar should be foo *bar. Fixed by Joe Borg r...@josephb.org Same comments as the last, I can't take this :( ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] Staging: rts5139: Fixed style issues

2014-01-09 Thread Greg KH
On Mon, Jan 06, 2014 at 07:05:09AM -0700, Morgan Creekmore wrote: Fixed style issues for lines over 80 chars Signed-off-by: Morgan Creekmore gamingro...@gmail.com --- drivers/staging/rts5139/rts51x_card.c | 10 +- drivers/staging/rts5139/rts51x_card.h | 8 2 files

Re: [PATCH v2] Staging: comedi: drivers:

2014-01-09 Thread Greg KH
On Mon, Jan 06, 2014 at 11:08:14PM -0500, Aruna-Hewapathirane wrote: Fixed a coding style issue in ke_counter.c You forgot a valid Subject: line :( ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] Staging: comedi: replace printk() calls with dev_dbg() in pcmmio.c

2014-01-09 Thread Greg KH
On Fri, Dec 27, 2013 at 06:07:21PM -0600, Chase Southwood wrote: From: Chase Southwood csou...@illinois.edu Changed several printk() calls to dev_dbg() or dev_err() in pcmmio.c to fix checkpatch.pl warnings. Patched from 3.13-rc5. Please line-wrap your changelog entries. Also, this is

status of sm7xfb staging driver?

2014-01-09 Thread Greg KH
Hi Teddy, It's been pointed out to me that there hasn't been any forward development on the sm7xxfb in over a year now. Is development dead, and I should delete it, or are you planning on doing more work on it soon so that it can be merged out of the staging tree? thanks, greg k-h

Re: status of echo staging driver?

2014-01-09 Thread Greg KH
On Fri, Jan 10, 2014 at 10:45:42AM +0800, Steve Underwood wrote: Hi Greg, As David said, the echo cancellation module is widely used, and gives good service. We have had no reason to touch the code for a long time. The last thing I remember doing was to make a minor correction to filter

Re: status of echo staging driver?

2014-01-09 Thread Greg KH
On Fri, Jan 10, 2014 at 11:26:52AM +0800, Steve Underwood wrote: Hi Greg, On 01/10/2014 11:09 AM, Greg KH wrote: On Fri, Jan 10, 2014 at 10:45:42AM +0800, Steve Underwood wrote: Hi Greg, As David said, the echo cancellation module is widely used, and gives good service. We have had

Re: 答复: status of sm7xfb staging driver?

2014-01-09 Thread Greg KH
On Fri, Jan 10, 2014 at 12:12:19PM +0800, Teddy.Wang 王力强 wrote: Hello Greg, SM712/SM722 chip is phase out. So, should I just delete the driver if you aren't going to be able to do any future work on it? But we plan to merge our new chip SM750 driver codes to the linux tree? How can I do

Re: [PATCH v2 1/3] Staging: lustre: Fix return does not need parantheses

2014-01-11 Thread Greg KH
On Sun, Jan 12, 2014 at 01:31:41AM +0530, Monam Agarwal wrote: The patch fixes the following checkpatch.pl error in lustre/ldlm/ldlm_flock.c ERROR: return is not a function, parentheses are not required Signed-off-by: Monam Agarwal monamagarwal...@gmail.com I'm totally confused here. You

Re: [PATCH 0/2] Staging: rtl8188eu: checkpatch.pl error cleanups

2014-01-11 Thread Greg KH
On Thu, Jan 09, 2014 at 09:37:09PM +0100, Tim Jester-Pfadt wrote: This patchset fixes all occurrences of the space required after ',' space required around '=' aswell as foo * bar related checkpatch.pl errors in rtl8188eu. The patchset does not fix the remaining 80 character limit

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-11 Thread Greg KH
On Thu, Jan 09, 2014 at 11:48:04AM -0800, Insop Song wrote: This driver downloads Xilinx FPGA firmware using gpio pins. It loads Xilinx FPGA bitstream format firmware image and program the Xilinx FPGA using SelectMAP (parallel) mode. Signed-off-by: Insop Song insop.s...@gainspeed.com This

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-11 Thread Greg KH
On Sat, Jan 11, 2014 at 12:51:28PM -0800, Greg KH wrote: On Thu, Jan 09, 2014 at 11:48:04AM -0800, Insop Song wrote: This driver downloads Xilinx FPGA firmware using gpio pins. It loads Xilinx FPGA bitstream format firmware image and program the Xilinx FPGA using SelectMAP (parallel) mode

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-11 Thread Greg KH
On Sat, Jan 11, 2014 at 03:56:48PM -0800, Insop Song wrote: On Sat, Jan 11, 2014 at 1:05 PM, Greg KH gre...@linuxfoundation.org wrote: On Sat, Jan 11, 2014 at 12:51:28PM -0800, Greg KH wrote: On Thu, Jan 09, 2014 at 11:48:04AM -0800, Insop Song wrote: This driver downloads Xilinx FPGA

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-11 Thread Greg KH
On Sat, Jan 11, 2014 at 02:16:05PM -0800, Insop Song wrote: On Sat, Jan 11, 2014 at 12:51 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Jan 09, 2014 at 11:48:04AM -0800, Insop Song wrote: This driver downloads Xilinx FPGA firmware using gpio pins. It loads Xilinx FPGA bitstream

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-13 Thread Greg KH
On Sat, Jan 11, 2014 at 04:37:32PM -0800, Insop Song wrote: On Sat, Jan 11, 2014 at 4:10 PM, Greg KH gre...@linuxfoundation.org wrote: On Sat, Jan 11, 2014 at 03:56:48PM -0800, Insop Song wrote: On Sat, Jan 11, 2014 at 1:05 PM, Greg KH gre...@linuxfoundation.org wrote: On Sat, Jan 11

Re: [PATCH] DAS6402: Fixing foo * bar should be foo *bar

2014-01-13 Thread Greg KH
On Sat, Jan 11, 2014 at 02:48:48PM +, Joe Borg wrote: --- drivers/staging/comedi/drivers/das6402.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Please always run your patches through the checkpatch.pl script, so that we don't have to tell you the results of it as to why we can't

Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

2014-01-13 Thread Greg KH
On Mon, Jan 13, 2014 at 08:14:46PM +, Joe Borg wrote: Signed-off-by Joe Borg cyborg101...@gmail.com You need a changelog comment here, please. And is that your real email address and name? greg k-h ___ devel mailing list

Re: [PATCH] AlarmDev: Changing is_wakeup() to be a function to pass checkpatch

2014-01-13 Thread Greg KH
On Mon, Jan 13, 2014 at 08:10:36PM +, Joe Borg wrote: Signed-off-by Joe Borg cyborg101...@gmail.com --- drivers/staging/android/alarm-dev.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/alarm-dev.c

Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

2014-01-13 Thread Greg KH
On Mon, Jan 13, 2014 at 09:23:11PM +, Joe Borġ wrote: Ok, will do the change log. Yes, it's my real name and email... I know the email address is embarrassing, but genuine :). Regards, Joseph David Borġ There's nothing wrong with using Joe Borġ as your signed-off-by: line, as

Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

2014-01-13 Thread Greg KH
On Mon, Jan 13, 2014 at 09:47:59PM +, Joe Borg wrote: Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo *bar' in the parameters of function munge_data(). Please wrap your changelog comments at 72 colums, like git asks you to when you type them in. Signed-off-by Joe Borg

Re: [PATCH v4] Move DWC2 driver out of staging

2014-01-13 Thread Greg KH
On Mon, Jan 13, 2014 at 01:50:09PM -0800, Paul Zimmerman wrote: The DWC2 driver should now be in good enough shape to move out of staging. I have stress tested it overnight on RPI running mass storage and Ethernet transfers in parallel, and for several days on our proprietary PCI-based

Re: [PATCH] Staging: ced1401: fix coding style in ced_ioc.c

2014-01-13 Thread Greg KH
On Mon, Jan 13, 2014 at 11:31:29PM +0100, Pol Eyschen wrote: On 13.01.2014, at 22:44, Dan Carpenter wrote: On Mon, Jan 13, 2014 at 09:35:53PM +, Mark Einon wrote: On Mon, Jan 13, 2014 at 08:41:40PM +0100, Pol Eyschen wrote: From: Pol Eyschen poleysc...@hotmail.com All comments

Re: hv: Trivial cleanups for drivers/hv/connection.c

2014-01-13 Thread Greg KH
On Tue, Dec 31, 2013 at 10:52:37PM +0100, Pavel Machek wrote: __u32 is only useful for kernel-user interface, u32 should be enough for kernel. Formatting was very confusing around __get_free_pages(). Signed-off-by: Pavel Machek pa...@ucw.cz This doesn't apply to my char-misc.git tree, care

Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

2014-01-13 Thread Greg KH
On Mon, Jan 13, 2014 at 11:19:15PM +, Joe Borg wrote: Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo *bar' in the parameters of function munge_data(). Ok, real minor nits here, but I'd like you to make them for future patches as it makes my life easier, and I don't like

Re: [PATCH] staging: comedi: das1800: Fixing foo * bar should be foo *bar

2014-01-13 Thread Greg KH
On Mon, Jan 13, 2014 at 11:19:15PM +, Joe Borg wrote: Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo *bar' in the parameters of function munge_data(). Signed-off-by: Joe Borg cyborg101...@gmail.com --- drivers/staging/comedi/drivers/das1800.c | 2 +- 1 file changed,

Re: [PATCH] Staging: ced1401: fix coding style in ced_ioc.c

2014-01-13 Thread Greg KH
On Mon, Jan 13, 2014 at 08:41:40PM +0100, Pol Eyschen wrote: From: Pol Eyschen poleysc...@hotmail.com All comments fixed to match the kernel coding style. Signed-off-by: Pol Eyschen poleysc...@gmail.com --- drivers/staging/ced1401/ced_ioc.c | 382 -

<    1   2   3   4   5   6   7   8   9   10   >