USB, TTY, char/misc, and Staging trees now closed for 3.14

2014-01-13 Thread Greg KH
Hi all, Given that 3.13 will be out in a few days, it's time to close my trees for new patches until 3.14-rc1 is out. Please feel free to send me patches for these trees, but note that I'll be ignoring them until 3.14-rc1 is out, at which point in time I'll start reviewing them again and

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-14 Thread Greg KH
On Tue, Jan 14, 2014 at 01:37:50AM -0800, Insop Song wrote: On Tue, Jan 14, 2014 at 1:18 AM, Insop Song insop.s...@gmail.com wrote: On Mon, Jan 13, 2014 at 10:44 AM, Greg KH gre...@linuxfoundation.org wrote: On Sat, Jan 11, 2014 at 04:37:32PM -0800, Insop Song wrote: On Sat, Jan 11, 2014

Re: [PATCH v2] Staging: comedi: convert while loop to timeout in ni_mio_common.c.

2014-01-14 Thread Greg KH
On Tue, Jan 14, 2014 at 01:38:46PM -0600, Chase Southwood wrote: This patch to ni_mio_common.c changes a while loop to a timeout for loop, which is preferred. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- I know Mr. Abbott mentioned that he wouldn't expect clean-up patches

Re: [PATCH v3] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-14 Thread Greg KH
On Tue, Jan 14, 2014 at 03:31:01PM -0600, Chase Southwood wrote: This patch to ni_mio_common.c changes a simple while loop to a timeout, which is preferred. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- I removed the extra counter variable this time. Greg, you mentioned

Re: [PATCH v4] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-14 Thread Greg KH
On Tue, Jan 14, 2014 at 06:23:05PM -0600, Chase Southwood wrote: This patch for ni_mio_common.c changes out a while loop for a timeout, which is preferred. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- OK, here's another go at it. Hopefully everything looks more correct

Re: [PATCH v4] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-15 Thread Greg KH
On Wed, Jan 15, 2014 at 06:29:21PM +, Hartley Sweeten wrote: On Tuesday, January 14, 2014 8:59 PM, Greg KH wrote: Sleep for at least 10, as I think that's the smallest time delay you can sleep for anyway (meaning it will be that long no matter what number you put there less than 10

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-16 Thread Greg KH
On Thu, Jan 16, 2014 at 12:56:15AM -0800, Insop Song wrote: On Tue, Jan 14, 2014 at 10:00 AM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Jan 14, 2014 at 01:37:50AM -0800, Insop Song wrote: On Tue, Jan 14, 2014 at 1:18 AM, Insop Song insop.s...@gmail.com wrote: On Mon, Jan 13, 2014

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-20 Thread Greg KH
On Mon, Jan 20, 2014 at 09:16:08AM -0800, Insop Song wrote: On Thu, Jan 16, 2014 at 1:41 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Jan 16, 2014 at 11:47:41AM -0800, Insop Song wrote: There is no way to detect FPGA until it is programmed. This is a reason and the only reason

Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

2014-01-21 Thread Greg KH
On Tue, Jan 21, 2014 at 02:08:53AM -0800, Insop Song wrote: On Mon, Jan 20, 2014 at 10:06 AM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jan 20, 2014 at 09:16:08AM -0800, Insop Song wrote: On the FPGA side, there are dedicated pins for programming, and through these you cannot

Re: [PATCH] staging: usbip: convert usbip-host driver to usb_device_driver

2014-01-23 Thread Greg KH
On Thu, Jan 23, 2014 at 09:37:28PM +0200, Valentina Manea wrote: On Thu, Jan 23, 2014 at 9:09 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Jan 23, 2014 at 08:36:46PM +0200, Valentina Manea wrote: This driver was previously an interface driver. Since USB/IP exports a whole device

Re: [PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak

2014-01-27 Thread Greg KH
On Mon, Jan 27, 2014 at 11:29:48PM +0100, xypron.g...@gmx.de wrote: From: Heinrich Schuchardt xypron.g...@gmx.de p is freed if NULL. Not a real problem, right? p is leaked if second calloc fails. You just created a new bug in your fix :( Please run your patches through

Re: [PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak

2014-01-27 Thread Greg KH
On Tue, Jan 28, 2014 at 02:02:12AM +0300, Dan Carpenter wrote: On Mon, Jan 27, 2014 at 02:50:04PM -0800, Greg KH wrote: On Mon, Jan 27, 2014 at 11:29:48PM +0100, xypron.g...@gmx.de wrote: From: Heinrich Schuchardt xypron.g...@gmx.de p is freed if NULL. Not a real problem, right

Re: Drivers/hv

2014-01-29 Thread Greg KH
On Wed, Jan 29, 2014 at 07:57:29AM -0800, K. Y. Srinivasan wrote: Greg, Some time back I had sent a buch of patches for Hyper-V drivers. Are they still in the queue or should I resend them. Which specific patches are you referring to? I can't take anything until after 3.14-rc1 is out,

Re: [PATCH 5/5] drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings

2014-01-30 Thread Greg KH
On Thu, Jan 30, 2014 at 06:18:48PM +0530, Avinash kumar wrote: drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings Which warnings? ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 5/5] drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings

2014-01-30 Thread Greg KH
On Thu, Jan 30, 2014 at 07:52:27PM +0530, Avinash Kumar wrote: Apologies for not including in the body of the email. Please resend this with the information properly in the patch changelog entry. thanks, greg k-h ___ devel mailing list

[GIT PULL] Staging wireless driver for 3.14-rc1

2014-01-31 Thread Greg KH
The following changes since commit 77d143de75812596a58d126606f42d1214e09dde: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml (2014-01-26 11:06:16 -0800) are available in the git repository at:

Re: [GIT PULL] Staging wireless driver for 3.14-rc1

2014-02-01 Thread Greg KH
On Sat, Feb 01, 2014 at 10:43:11AM -0800, Linus Torvalds wrote: On Fri, Jan 31, 2014 at 6:32 AM, Greg KH gre...@linuxfoundation.org wrote: Here's a single staging driver for a wireless chipset that has shown up in the SteamBox hardware. It is merged separately from the main staging pull

Re: [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list

2014-02-02 Thread Greg KH
On Sun, Feb 02, 2014 at 02:07:06PM -0600, Larry Finger wrote: There is a typo in the device list that interchanges the vendor and product codes for one of the entries. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +- 1 file

Re: rtl8821ae.

2014-02-03 Thread Greg KH
On Mon, Feb 03, 2014 at 11:05:42AM -0600, Larry Finger wrote: I am trying to improve the quality of this pile of , but I am only one person who was a life-long Fortran-coding scientist until I retired 15 years ago. Since then, I have been learning C and kernel-style coding practices.

Re: vme_tsi148 question

2014-02-05 Thread Greg KH
On Tue, Feb 04, 2014 at 06:34:13PM +, Martyn Welch wrote: On 04/02/14 16:34, Michael Kenney wrote: Hi Martyn, On Tue, Feb 4, 2014 at 7:28 AM, Martyn Welch martyn.we...@ge.com mailto:martyn.we...@ge.com wrote: On 28/12/13 00:34, Michael Kenney wrote: Hi Martyn,

Re: Q: comedi timeouts

2014-02-05 Thread Greg KH
On Tue, Feb 04, 2014 at 06:59:43PM +, Hartley Sweeten wrote: Hello all, I'm in the process of cleaning up all the timeout code in the comedi drivers. The general form of the timeout code in all the drivers is: static int foo_eoc(struct comedi_device *dev, unsigned long timeout) {

Re: Q: comedi timeouts

2014-02-05 Thread Greg KH
On Wed, Feb 05, 2014 at 06:02:04PM +, Hartley Sweeten wrote: On Wednesday, February 05, 2014 10:40 AM, Greg KH wrote: On Tue, Feb 04, 2014 at 06:59:43PM +, Hartley Sweeten wrote: I'm in the process of cleaning up all the timeout code in the comedi drivers. The general form

Re: [PATCH 3/8] staging:rtl8821ae fix ERROR: space required after that in pci.c

2014-02-06 Thread Greg KH
On Thu, Feb 06, 2014 at 11:01:11PM +0300, Dan Carpenter wrote: On Fri, Feb 07, 2014 at 12:45:24AM +0530, Gokulnath A wrote: fixed all the spacing related issues found by checkpatch.pl script. A lot of this stuff should just be removed. This whole driver is going to be deleted for 3.15

Re: [PATCH] staging: ced1401: fix coding style in ced_ioc.c (resend)

2014-02-07 Thread Greg KH
On Wed, Jan 15, 2014 at 10:37:13PM +0100, Pol Eyschen wrote: Fixed checkpatch.pl issues and removed redundant comment in ced_ioc.cs Signed-off-by: Pol Eyschen poleysc...@gmail.com --- drivers/staging/ced1401/ced_ioc.c | 483 + 1 file changed, 271

Re: [PATCH 5/5] drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings

2014-02-07 Thread Greg KH
On Thu, Jan 30, 2014 at 07:14:02PM +0530, Avinash kumar wrote: drivers:staging:dgnc:dpacompat.h- removed following checkpatch.pl reported warnings sccc@ubuntu:~/lk/rc/linux$ ./scripts/checkpatch.pl --terse --file drivers/staging/dgnc/dpacompat.h drivers/staging/dgnc/dpacompat.h:109:

Re: Drivers/hv

2014-02-07 Thread Greg KH
On Fri, Feb 07, 2014 at 07:06:00PM +, KY Srinivasan wrote: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Wednesday, January 29, 2014 1:16 PM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de

Re: [PATCH V4 1/1] Drivers: hv: Implement the file copy service

2014-02-07 Thread Greg KH
On Tue, Jan 21, 2014 at 05:43:53PM -0800, K. Y. Srinivasan wrote: +/* + * Create a char device that can support read/write for passing + * the payload. + */ +static struct cdev fcopy_cdev; +static struct class *cl; +static struct device *sysfs_dev; Why not just be a misc device, you only

Re: [PATCH V2 1/1] Drivers: hv: vmbus: Extract the mmio information from DSDT

2014-02-07 Thread Greg KH
On Wed, Jan 29, 2014 at 06:14:39PM -0800, K. Y. Srinivasan wrote: On Gen2 firmware, Hyper-V does not emulate the PCI bus. However, the MMIO information is packaged up in DSDT. Extract this information and export it for use by the synthetic framebuffer driver. This is the only driver that needs

Re: [PATCH] staging: r8188eu: Fix missing header

2014-02-07 Thread Greg KH
On Fri, Feb 07, 2014 at 05:12:10PM -0600, Larry Finger wrote: Commit 2397c6e0927675d983b34a03401affdb64818d07 entitled staging: r8188eu: Remove wrappers around vmalloc and vzalloc and commit: 03bd6aea7ba610a1a19f840c373624b8b0adde0d entitled staging: r8188eu: Remove wrappers around vfree

Re: [PATCH 1/2] drivers:staging:rtl8821ae: Fixed few coding style erors and warnings

2014-02-11 Thread Greg KH
On Sun, Feb 09, 2014 at 10:55:25AM -0600, Larry Finger wrote: On 02/09/2014 01:30 AM, Surendra Patil wrote: Fixed multiple coding style errors and warnings wifi.h:1077: WARNING: please, no space before tabs wifi.h:762: WARNING: missing space after struct definition wifi.h:972: WARNING:

Re: [PATCH 3/3] staging: rtl8188eu: remove header file ethernet.h

2014-02-11 Thread Greg KH
On Sun, Feb 09, 2014 at 02:10:46PM +0530, navin patidar wrote: ethernet.h is included in three files but only rtw_recv.c using two macros defined in ethernet.h, so move used macros in rtw_recv.c and remove include/ethernet.h header file and inclusion of this header file. Signed-off-by: navin

Re: [PATCH 1/6] staging: r8188eu: Replace wrapper around _rtw_memcmp()

2014-02-11 Thread Greg KH
On Sun, Feb 09, 2014 at 03:15:54PM -0600, Larry Finger wrote: This wrapper is replaced with a simple memcmp(). As the wrapper inverts the logic of memcmp(), care needed to be taken. That's just evil, ugh, nice job... ___ devel mailing list

Re: [PATCH 6/6] staging: r8188eu: Remove _func_enter and _func_exit macros

2014-02-11 Thread Greg KH
On Sun, Feb 09, 2014 at 03:15:59PM -0600, Larry Finger wrote: These debugging macros are seldom used for debugging once the driver is working. If routine tracing is needed, it can be added on an individual basis. No, you can use the in-kernel tracing functionality :) nice job. greg k-h

Re: [PATCH 1/1] Tools: hv: vssdaemon: Ignore VFAT mounts during the Freeze operation

2014-02-12 Thread Greg KH
On Wed, Feb 12, 2014 at 08:40:22AM -0800, K. Y. Srinivasan wrote: If the guest has a FAT file system mounted, skip it during the FREEZE operation. With this change we can support host initiated backup of the guest even when the guest may have FAT file systems mounted. Signed-off-by: K. Y.

Re: [PATCH 1/1] staging: imx-drm: remove unused variable

2014-02-12 Thread Greg KH
On Wed, Feb 12, 2014 at 02:47:39PM +0530, Sachin Kamat wrote: Silences the following warning: drivers/staging/imx-drm/imx-drm-core.c: In function ‘imx_drm_driver_unload’: drivers/staging/imx-drm/imx-drm-core.c:87:25: warning: unused variable ‘imxdrm’ [-Wunused-variable] Signed-off-by:

Re: [PATCH 34/47 v2] staging: comedi: icp_multi: use comedi_timeout()

2014-02-12 Thread Greg KH
On Mon, Feb 10, 2014 at 11:49:33AM -0700, H Hartley Sweeten wrote: Use comedi_timeout() to wait for the analog input and output end-of- conversion. Use break to exit the loop when a timeout occurs during the analog input read so that common code can be used to disable the device.

[GIT PULL] Staging driver fixes for 3.14-rc3

2014-02-14 Thread Greg KH
The following changes since commit 38dbfb59d1175ef458d006556061adeaa8751b72: Linus 3.14-rc1 (2014-02-02 16:42:13 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.14-rc3 for you to fetch changes up to

Re: [PATCH 2/2] staging: android: binder: use stack for locally used variable

2014-02-18 Thread Greg KH
On Tue, Feb 18, 2014 at 08:23:26PM +0900, SeongJae Park wrote: The variable `binder_debugfs_dir_entry_root` is declared as static global variable although it is accessed from init function only. Declare it as init function's local variable because it would be better to read and memory

Re: [PATCH 1/2] staging: android: binder: remove unnecessary comment

2014-02-18 Thread Greg KH
On Tue, Feb 18, 2014 at 08:23:25PM +0900, SeongJae Park wrote: Signed-off-by: SeongJae Park sj38.p...@gmail.com --- drivers/staging/android/binder.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index

Re: [PATCH 00/87] staging: comedi: cleanup pcl812/816/818 drivers

2014-02-18 Thread Greg KH
On Tue, Feb 18, 2014 at 12:06:51PM +, Ian Abbott wrote: On 2014-02-17 21:26, H Hartley Sweeten wrote: These comedi drivers are all very similar so it made sense to clean them up together. This series removes a bunch of the cruft in the drivers and reduces the boardinfo and private data.

Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

2014-02-20 Thread Greg KH
On Thu, Feb 20, 2014 at 03:45:12PM -0800, K. Y. Srinivasan wrote: Fix a bug in the resource walking code. Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/hv/vmbus_drv.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Is this for 3.14-final or 3.15? I ask this

Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

2014-02-20 Thread Greg KH
On Thu, Feb 20, 2014 at 03:45:12PM -0800, K. Y. Srinivasan wrote: Fix a bug in the resource walking code. Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/hv/vmbus_drv.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Fails to apply to my char-misc-next branch

[GIT PULL] Staging driver fix for 3.14-rc4

2014-02-22 Thread Greg KH
The following changes since commit 6d0abeca3242a88cab8232e4acd7e2bf088f3bc2: Linux 3.14-rc3 (2014-02-16 13:30:25 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.14-rc4 for you to fetch changes up to

Re: [GIT PULL] imx-drm conversion to component support

2014-02-24 Thread Greg KH
On Mon, Feb 24, 2014 at 02:20:20PM +, Russell King wrote: Greg, Please incorporate the latest imx-drm updates into staging, which can be found at: git://ftp.arm.linux.org.uk/~rmk/linux-arm.git imx-drm-staging with SHA1 d94905e019acce960feeda1f92a9427fbe45ebbe. These changes,

Re: [PATCH] staging: rtl8187se: fix checkpatch.pl issues

2014-02-24 Thread Greg KH
On Thu, Feb 20, 2014 at 01:05:31AM -0700, axel.rasmuss...@gmail.com wrote: From: Axel Rasmussen axel.rasmuss...@gmail.com Date: Mon, 17 Feb 2014 23:50:05 -0700 Subject: [PATCH] staging: rtl8187se: fix checkpatch.pl issues Please just use 'git send-email' so I don't have to hand-edit the patch

Re: [PATCH v2] staging: ced401: fix double unlock bug

2014-02-24 Thread Greg KH
On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote: After spin_lock() is called, all of if-else conditions in this brace should reach the end of else and spin_unlock() must be called. So It doesn't need to call spin_unlock() without a return statement for handling an error. Also

Re: [PATCH 3/3 v2] Staging: comedi: addi-data: fix a couple of lines that are too long

2014-02-24 Thread Greg KH
On Mon, Feb 24, 2014 at 10:35:09AM -0600, Chase Southwood wrote: There are a couple of cases where a comment being on the same line as a statement is causing the line to be over 80 characters long. This is an easy fix, move these comments to the previous line. Signed-off-by: Chase Southwood

Re: [PATCH RFC only] staging: dgap: fix OOPS on open of port

2014-02-25 Thread Greg KH
On Tue, Feb 25, 2014 at 10:56:22AM -0500, Mark Hounschell wrote: When opening a port the dgap driver OOPs with a message: tty_init_dev: driver does not set tty-port... will crash the kernel... fix the driver... etc... Then I have to reboot the box. I think before too much more work is

Re: [PATCH] Staging: speakup: buffers: Fixed a return value coding style issue.

2014-02-27 Thread Greg KH
On Thu, Feb 27, 2014 at 04:26:42PM +, Reza Snowdon wrote: Fixed a coding style issue. Signed-off-by: Reza Snowdon r...@mage.me.uk --- drivers/staging/speakup/buffers.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/buffers.c

Re: [PATCH v4 1/6] imx-drm: ipu-dmfc: Check 'dmfc' pointer first

2014-02-27 Thread Greg KH
On Wed, Feb 26, 2014 at 08:53:39PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157)

Re: [PATCH v4 3/6] imx-drm: imx-ldb: Use snprintf()

2014-02-27 Thread Greg KH
On Wed, Feb 26, 2014 at 08:53:41PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Use snprintf() in order to fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length:

Re: [PATCH v4 3/6] imx-drm: imx-ldb: Use snprintf()

2014-02-27 Thread Greg KH
On Thu, Feb 27, 2014 at 11:44:38PM +, Russell King - ARM Linux wrote: On Thu, Feb 27, 2014 at 02:54:43PM -0800, Greg KH wrote: On Wed, Feb 26, 2014 at 08:53:41PM -0300, Fabio Estevam wrote: diff --git a/drivers/staging/imx-drm/imx-ldb.c b/drivers/staging/imx-drm/imx-ldb.c index

Re: [PATCH] Drivers:staging:ozwpan Fixed sparse context imbalance warning

2014-02-28 Thread Greg KH
On Fri, Feb 28, 2014 at 08:57:02AM -0800, Surendra Patil wrote: Sparse warns about - drivers/staging/ozwpan/ozproto.c:797:6: warning: context imbalance in 'oz_polling_lock_bh' - wrong count at exit drivers/staging/ozwpan/ozproto.c:802:6: warning: context imbalance in 'oz_polling_unlock_bh'

Re: status of sbe-2t3e3 staging driver?

2014-02-28 Thread Greg KH
On Mon, Jan 13, 2014 at 03:05:29PM +0100, Krzysztof Halasa wrote: Hi Greg, Greg KH gre...@linuxfoundation.org writes: It's been pointed out to me that there hasn't been any forward development on the sbe-2t3e3 in almost a year now. Is development dead, and I should delete

Re: [PATCH 3/5] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

2014-02-28 Thread Greg KH
On Fri, Feb 28, 2014 at 04:33:49PM +0900, DaeSeok Youn wrote: OK. sorry. I will send again. Please resend all 3 of these, I've applied the first 2. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: sb105x: b_pci_mp.c: fix for non-member access

2014-02-28 Thread Greg KH
On Fri, Feb 28, 2014 at 04:21:03AM +0200, Kumar Amit Mehta wrote: 'struct tty_struct’ has no member named ‘low_latency’ This driver is marked BROKEN, and can't even compile, how did you test this patch? ___ devel mailing list

Re: [PATCH 1/2 v2] Staging: comedi: fix lines that are over 80 characters

2014-02-28 Thread Greg KH
On Fri, Feb 28, 2014 at 03:15:45AM -0600, Chase Southwood wrote: This patch introduces a simple helper function, outl_1564_timer(), to allow several lines which violate the character limit to be shortened. A handful of other lines that are too long are appropriately split as well. Cc: Dan

Re: [PATCH] staging: sb105x: b_pci_mp.c: fix for non-member access

2014-02-28 Thread Greg KH
On Fri, Feb 28, 2014 at 02:20:40PM -0800, Greg KH wrote: On Fri, Feb 28, 2014 at 04:21:03AM +0200, Kumar Amit Mehta wrote: 'struct tty_struct’ has no member named ‘low_latency’ This driver is marked BROKEN, and can't even compile, how did you test this patch? Don't worry about it anymore

Re: [PATCH 07/08] staging:dgap: Fix externs should be avoided in .c files as reported by checkpatch

2014-02-28 Thread Greg KH
On Fri, Feb 28, 2014 at 12:42:14PM -0500, Mark Hounschell wrote: This patch fixes externs should be avoided in .c files in dgap.c as reported by checkpatch Signed-off-by: Mark Hounschell ma...@compro.net --- drivers/staging/dgap/dgap.c | 8 1 file changed, 4 insertions(+), 4

[GIT PULL] Staging driver fixes for 3.14-rc5

2014-03-02 Thread Greg KH
The following changes since commit cfbf8d4857c26a8a307fb7cd258074c9dcd8c691: Linux 3.14-rc4 (2014-02-23 17:40:03 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.14-rc5 for you to fetch changes up to

Re: [patch 0/8] staging: Drivers to support Unisys Secure Partitioning

2014-03-03 Thread Greg KH
On Mon, Mar 03, 2014 at 11:01:14AM -0600, Ken Cox wrote: This series includes a base set of drivers for the Unisys s-Par system. This set of drivers is enough to get a virtual guest up and running on s-Par hardware. The remaining drivers needed to have a fully functional system will be

Re: [patch 1/8] staging: visorutil driver to provide common functionality to other s-Par drivers

2014-03-03 Thread Greg KH
On Mon, Mar 03, 2014 at 11:30:19AM -0600, Ken Cox wrote: +/* periodic_work.h + * + * Copyright © 2010 - 2013 UNISYS CORPORATION + * All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as

Re: [patch 1/8] staging: visorutil driver to provide common functionality to other s-Par drivers

2014-03-03 Thread Greg KH
On Mon, Mar 03, 2014 at 02:05:07PM -0600, Romer, Benjamin M wrote: Hi Greg, The copyright text is old boilerplate that we'd been carrying. Be careful about old boilerplate, that can get you in trouble :) We'll change it so that it's correctly GPL 2 only, and we'll fix all of the

Re: [PATCH] staging: usbip: userspace: increase version to 2.0

2014-03-04 Thread Greg KH
On Tue, Mar 04, 2014 at 09:16:39PM +0200, Valentina Manea wrote: Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/usbip/userspace/configure.ac

Re: [PATCH 06/12] staging: usbip: userspace: add new list API

2014-03-04 Thread Greg KH
On Tue, Mar 04, 2014 at 09:10:46PM +0200, Valentina Manea wrote: Add a new list API from CCAN. Why can't you just take the one from the kernel, as userspace is GPLv2 code, right? And are you sure CC0 is a valid license that you can mix with GPLv2 code? I ask this seriously, as I have heard

Re: [PATCH 00/12] Migrate usbip-utils to libudev

2014-03-04 Thread Greg KH
On Tue, Mar 04, 2014 at 09:10:40PM +0200, Valentina Manea wrote: This patch series modifies the USB/IP userspace side (usbip-utils) to use libudev instead of libsysfs. This change was necessary as libsysfs is no longer maintained and we have discovered a bug that affected USB/IP. That's

Re: [PATCH] staging: usbip: claim ports used by shared devices

2014-03-04 Thread Greg KH
On Tue, Mar 04, 2014 at 09:25:04PM +0200, Valentina Manea wrote: Signed-off-by: Valentina Manea valentina.mane...@gmail.com As you are touching core USB code, you need to have some kind of description here as to what you are doing, and why you are doing it. thanks, greg k-h

Re: [PATCH] staging: cxt1e1: moved version string declaration

2014-03-05 Thread Greg KH
On Wed, Mar 05, 2014 at 12:29:31PM -0700, Shaun Laing wrote: To resolve a sparse should it be static warning, the declaration for the pmcc4_OSSI_release version string was moved from its own file to linux.c, and the resulting empty file was deleted. Signed-off-by: Shaun Laing

Re: [PATCH 09/11] staging: unisys: remove unreferenced utility functions.

2014-03-05 Thread Greg KH
On Wed, Mar 05, 2014 at 01:48:59PM -0600, Ken Cox wrote: From: Ken Cox j...@dhcp-10-15-1-72.hsv.redhat.com Where are patches 1-8? ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 11/11] staging: unisys: Fix MAINTAINERS and TODO

2014-03-05 Thread Greg KH
On Wed, Mar 05, 2014 at 01:49:50PM -0600, Ken Cox wrote: From: Ken Cox j...@dhcp-10-15-1-72.hsv.redhat.com Add the Unisys s-Par maintainer entry to the MAINTAINERS file. Add Greg Kroah-Hartman to the list of patch recipients in the TODO file Signed-off-by: Ken Cox j...@redhat.com ---

Re: [PATCH 09/11] staging: unisys: remove unreferenced utility functions.

2014-03-05 Thread Greg KH
On Wed, Mar 05, 2014 at 01:48:59PM -0600, Ken Cox wrote: From: Ken Cox j...@dhcp-10-15-1-72.hsv.redhat.com I don't think that's the email address you really want us to use for your commit address... ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 3/3] staging: unisys: Fix MAINTAINERS and TODO

2014-03-05 Thread Greg KH
On Wed, Mar 05, 2014 at 02:52:26PM -0600, Ken Cox wrote: Add the Unisys s-Par maintainer entry to the MAINTAINERS file. Add Greg Kroah-Hartman to the list of patch recipients in the TODO file Signed-off-by: Ken Cox j...@redhat.com --- MAINTAINERS| 5 +

Re: [PATCH] Staging: comedi: range: remove unnecessary sanity check

2014-03-05 Thread Greg KH
On Thu, Mar 06, 2014 at 01:07:03AM -0500, Fred Akers wrote: This check is unnecessary because range_table will always be initialized to range_unknown by comedi_device_postconfig() for drivers that do not initialize range_table or range_table_list Signed-off-by: Fred Akers kni...@botops.net

Re: [PATCH] Staging: cxt1e1: ossiRelease.c: fixed a coding style issue.

2013-07-23 Thread Greg KH
On Mon, Jul 08, 2013 at 07:33:48PM +0300, Aldo Iljazi wrote: Fixed a coding style issue, specifically checkpatch.pl complain: ossiRelease.c:27: WARNING: line over 80 characters Signed-off-by: Aldo Iljazi neonsy...@gmail.com --- drivers/staging/cxt1e1/ossiRelease.c |3 ++- 1 file

Re: [PATCH] zcache: fix zcache= kernel parameter

2013-07-24 Thread Greg KH
On Wed, Jul 24, 2013 at 05:50:29PM +0200, Bartlomiej Zolnierkiewicz wrote: On Wednesday, July 24, 2013 05:39:20 PM Bartlomiej Zolnierkiewicz wrote: On Wednesday, July 24, 2013 08:06:27 AM Greg KH wrote: On Wed, Jul 24, 2013 at 01:54:56PM +0200, Bartlomiej Zolnierkiewicz wrote

Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

2013-07-24 Thread Greg KH
On Thu, Jul 25, 2013 at 12:53:40AM +0300, Dan Carpenter wrote: +static int gdm_lte_ioctl_get_data(struct wm_req_t *req, struct net_device *dev) +{ + u16 id = req-data_id; + + switch (id) { + case GET_ENDIAN_INFO: + /* required for the user space application to find

Re: [PATCH] staging: zcache: fix zcache= kernel parameter

2013-07-25 Thread Greg KH
On Thu, Jul 25, 2013 at 12:13:54PM +0200, Bartlomiej Zolnierkiewicz wrote: From: Piotr Sarna p.sa...@partner.samsung.com snip This whole email is base64, making it impossible for me to add the needed Cc: stable@ tag to it... Try it again? It shouldn't be this hard... greg k-h

Re: [PATCH v6] staging: New driver: Xillybus generic interface for FPGA

2013-07-25 Thread Greg KH
On Mon, Jun 24, 2013 at 06:55:47PM +0300, Eli Billauer wrote: This is the driver for Xillybus, which is a general-purpose interface for data communication with FPGAs (programmable logic). Please refer to the README included in this patch for a detailed explanation. It was previously

Re: [PATCH -next] staging: gdm724x: use GFP_ATOMIC under spin lock

2013-07-26 Thread Greg KH
On Fri, Jul 26, 2013 at 10:32:33AM +0300, Dan Carpenter wrote: On Fri, Jul 26, 2013 at 10:15:55AM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn A spin lock is taken here so we should use GFP_ATOMIC. Acked-by: Dan Carpenter dan.carpen...@oracle.com But

Re: [PATCH v2 1/2] staging: lustre: Fix non-ANSI sparse warnings

2013-07-28 Thread Greg KH
On Sun, Jul 28, 2013 at 06:19:29PM +0200, walter harms wrote: Am 28.07.2013 00:38, schrieb Emil Goode: This patch fixes a lot of non-ANSI sparse warnings by adding void to parameterless functions. Signed-off-by: Emil Goode emilgo...@gmail.com --- v2: A bit more specific commit

Re: [PATCH] staging: dgnc - adds dgnc digi driver

2013-08-01 Thread Greg KH
On Thu, Aug 01, 2013 at 02:03:13PM -0400, lidza.lou...@gmail.com wrote: This patch adds the DGNC driver. This is a TTY Serial Port Driver for the Digi International Neo and Classic PCI based product line by Digi International http://www.digi.com. Signed-off-by: Lidza Louina

Re: [PATCH v2] staging: dgnc - adds dgnc digi driver

2013-08-12 Thread Greg KH
On Mon, Aug 12, 2013 at 02:39:54PM -0400, Lidza Louina wrote: I've just realized I made a mistake by adding the Makefile.inc. Oops, I missed that. Is it possible for me to make a fresh set of patches (adding the files, building it into the kernel, and fixing the errors and warnings)?

Re: [PATCH 4/9] staging: dgnc: fixes error: invalid type argument of ‘-’ (have ���struct ktermios’)

2013-08-12 Thread Greg KH
On Mon, Aug 12, 2013 at 05:05:08PM -0400, Lidza Louina wrote: Signed-off-by: Lidza Louina lidza.lou...@gmail.com Odd characters in the Subject: line :( Care to write a bit more in the body of the changelog entry that describes this? thanks, greg k-h

Re: [PATCH 5/9] staging: dgnc: fixes error: expected ‘struct tty_port *’ but argument is of type ‘struct tty_struct *’

2013-08-12 Thread Greg KH
On Mon, Aug 12, 2013 at 05:05:09PM -0400, Lidza Louina wrote: Signed-off-by: Lidza Louina lidza.lou...@gmail.com --- A bit more information here as well is needed. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 6/9] staging: dgnc: fixes error: incompatible types when assigning to type ‘struct ktermios *’ from type ‘struct ktermios’

2013-08-12 Thread Greg KH
On Mon, Aug 12, 2013 at 05:05:10PM -0400, Lidza Louina wrote: Signed-off-by: Lidza Louina lidza.lou...@gmail.com --- drivers/staging/dgnc/dgnc_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Actually all of these need some kind of text in the changelog area. I'll just stop now on

Re: [PATCH 2/8] staging: dgnc: removes proc code

2013-08-14 Thread Greg KH
On Tue, Aug 13, 2013 at 03:49:52PM -0400, Lidza Louina wrote: This patch removes the dgnc_proc.c file, all references to proc functions in dgnc_driver.c and from the Makefile's build. There were a lot of issues with the proc code so I removed it to make sure it builds. I'll work on the

Re: [PATCH v2] staging: gdm7240: a TTY rewrite according to the latest TTY APIs

2013-08-14 Thread Greg KH
On Tue, Aug 13, 2013 at 07:46:01PM +0900, Won Kang wrote: Removed the old style reference countings and termios. Renamed variables to meaninful ones. Fixed mis-use of mutex for gdm_table. gdm_table is refered to only inside tty_install and port destrcut, and usb callbacks use internal

Re: [PATCH v2] staging: dgnc: removes proc code

2013-08-14 Thread Greg KH
On Wed, Aug 14, 2013 at 07:01:49PM -0400, Lidza Louina wrote: This patch removes the dgnc_proc.c file, all references to proc functions in dgnc_driver.c and from the Makefile's build. Drivers now use sysfs instead of proc. Signed-off-by: Lidza Louina lidza.lou...@gmail.com ---

Re: [PATCH v3] staging: dgnc: removes proc code

2013-08-14 Thread Greg KH
On Wed, Aug 14, 2013 at 08:49:24PM -0400, Lidza Louina wrote: This patch removes the dgnc_proc.c and dgnc_proc.h files and all references to proc functions in dgnc_driver.c. This also removes proc.h from the include headers in driver.c, mgmt.c and sysfs.c and proc.o from the Makefile.

Re: [PATCH v4] staging: dgnc: removes proc code

2013-08-15 Thread Greg KH
On Thu, Aug 15, 2013 at 10:28:22AM -0400, Lidza Louina wrote: This patch removes the dgnc_proc.c and dgnc_proc.h files and all references to proc functions in dgnc_driver.c. This also removes proc.h from the include headers in driver.c, mgmt.c and sysfs.c and proc.o from the Makefile.

Re: [PATCH] Staging:BCM:DDRInit.c:Replacing __FUNCTION__

2013-08-15 Thread Greg KH
On Thu, Aug 15, 2013 at 10:21:29PM +0100, paulmcq...@gmail.com wrote: __Function__ gets replaced with __func__ Signed-Off-By: Paul McQuade paulmcq...@gmail.com --- drivers/staging/bcm/DDRInit.c | 54 - 1 file changed, 27 insertions(+), 27

[GIT PATCH] Staging driver fixes for 3.11-rc6

2013-08-15 Thread Greg KH
The following changes since commit d4e4ab86bcba5a72779c43dc1459f71fea3d89c8: Linux 3.11-rc5 (2013-08-11 18:04:20 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.11-rc6 for you to fetch changes up to

Re: [GIT PATCH] Staging driver fixes for 3.11-rc6

2013-08-15 Thread Greg KH
On Thu, Aug 15, 2013 at 07:07:10PM -0700, Greg KH wrote: The following changes since commit d4e4ab86bcba5a72779c43dc1459f71fea3d89c8: Linux 3.11-rc5 (2013-08-11 18:04:20 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git

Re: [PATCH] Staging: rtl8192e: rtllib_rx: checking NULL value after doing dev_alloc_skb

2013-08-16 Thread Greg KH
On Fri, Aug 16, 2013 at 01:44:03PM +0200, Iker Pedrosa wrote: So, what should I do? Do I send the patch via bugzilla? I'm a newbie and I don't know that to do, what do you recommend me? Take a look at the kernel file, Documentation/SubmittingPatches for how to properly send a kernel patch that

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-16 Thread Greg KH
On Sat, Aug 17, 2013 at 02:18:27AM +0300, Aaro Koskinen wrote: Hi, On Fri, Aug 16, 2013 at 10:39:39AM -0700, Greg KH wrote: As the dwc2 code seems to be the more mature codebase, any objection to me deleting the octeon-usb driver? If it's possible to get it working on Octeon HW

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-17 Thread Greg KH
On Sat, Aug 17, 2013 at 08:44:18PM +, Paul Zimmerman wrote: From: Aaro Koskinen [mailto:aaro.koski...@iki.fi] Sent: Saturday, August 17, 2013 8:39 AM On Fri, Aug 16, 2013 at 08:02:27PM -0700, Greg KH wrote: dcw2 already supports different boards/systems, so perhaps there's a way

Re: [PATCH v2 1/2] staging: dgnc: driver.c: fixes warning about assigning pointer

2013-08-20 Thread Greg KH
On Tue, Aug 20, 2013 at 02:15:35PM -0400, Lidza Louina wrote: This patch fixes a warning associated with assigining a pointer in the dgnc_mbuf function. Signed-off-by: Lidza Louina lidza.lou...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 01/12] staging: dgap: adds dgap driver to staging

2013-08-21 Thread Greg KH
On Wed, Aug 21, 2013 at 09:48:31PM -0400, Lidza Louina wrote: From: Scott_Kilau at digi dot com I need a real email address, no at or dot please. I'll edit it by hand this time, but in the future, please don't do that. thanks, greg k-h ___ devel

Re: [PATCH 12/12] staging: dgap: adds driver to kernel build

2013-08-22 Thread Greg KH
On Wed, Aug 21, 2013 at 09:48:42PM -0400, Lidza Louina wrote: This patch adds the dgap driver to the kernel build process. Signed-off-by: Lidza Louina lidza.lou...@gmail.com --- drivers/staging/Kconfig | 2 +- drivers/staging/Makefile | 2 +- 2 files changed, 2 insertions(+), 2

Re: [PATCH 12/12] staging: dgap: adds driver to kernel build

2013-08-22 Thread Greg KH
On Wed, Aug 21, 2013 at 09:48:42PM -0400, Lidza Louina wrote: This patch adds the dgap driver to the kernel build process. Signed-off-by: Lidza Louina lidza.lou...@gmail.com --- drivers/staging/Kconfig | 2 +- drivers/staging/Makefile | 2 +- 2 files changed, 2 insertions(+), 2

<    1   2   3   4   5   6   7   8   9   10   >