On Thu, Aug 22, 2013 at 01:40:35PM -0400, Lidza Louina wrote:
This patch adds the dgap driver to the kernel build process.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
I've applied this, but I'm getting this build warning now:
drivers/staging/dgap/dgap_mgmt.c: In function
On Mon, Aug 26, 2013 at 02:08:58PM -0700, K. Y. Srinivasan wrote:
The channel state should be correctly set before registering the device. In
the current
code the driver probe would fail for channels that have been rescinded and
subsequently
re-offered. Fix the bug.
Signed-off-by: K. Y.
On Mon, Aug 26, 2013 at 05:10:19PM +0200, Iker Pedrosa wrote:
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use
usleep instead.
Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com
---
On Tue, Aug 27, 2013 at 06:19:43PM -0400, Lidza Louina wrote:
This patch removes the dgnc_driver_kzmalloc function from
driver.c. The patch that follows replaces all
dgnc_driver_kzmalloc functions calls with kzalloc.
Yes, but this patch just broke the build, right?
Do this in the opposite
On Tue, Aug 27, 2013 at 10:13:28PM -0400, Lidza Louina wrote:
This patch removes the dgnc_driver_kzmalloc function from
driver.c and driver.h. A previous patch replaced all
dgnc_driver_kzmalloc function calls with kzalloc.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
On Tue, Aug 27, 2013 at 10:13:27PM -0400, Lidza Louina wrote:
This patch replaces dgnc_driver_kzmalloc with kzalloc.
A patch that follows removes the dgnc_driver_kzmalloc
function.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgnc/dgnc_driver.c | 6 +++---
On Wed, Aug 28, 2013 at 10:35:46AM +0530, Sachin Kamat wrote:
Include version.h header file as detected by versioncheck.
Cc: Lidza Louina lidza.lou...@gmail.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/dgap/dgap_kcompat.h |2 ++
1 file changed, 2
On Wed, Aug 28, 2013 at 06:50:44PM -0400, Lidza Louina wrote:
On Wed, Aug 28, 2013 at 6:34 PM, Lidza Louina lidza.lou...@gmail.com wrote:
On Wed, Aug 28, 2013 at 12:57 AM, Greg KH gre...@linuxfoundation.org
wrote:
On Tue, Aug 27, 2013 at 10:13:28PM -0400, Lidza Louina wrote:
This patch
On Thu, Aug 29, 2013 at 03:36:55PM +0530, Sachin Kamat wrote:
Code should be for the kernel version it is merged in. Version
check is not necessary.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Compile tested only.
---
drivers/staging/dgap/dgap_driver.c |4
On Thu, Aug 29, 2013 at 03:36:54PM +0530, Sachin Kamat wrote:
Fixes the following compilation errors:
drivers/staging/dgap/dgap_driver.c:423:3: error:
implicit declaration of function ‘kfree’
[-Werror=implicit-function-declaration]
kfree(dgap_config_buf);
^
On Wed, Sep 11, 2013 at 02:12:50AM +0300, Sergey Senozhatsky wrote:
Dan Carpenter noted that handle_pending_slot_free() is racy with
zram_reset_device(). Take write init_lock in zram_slot_free(), thus
preventing any concurrent zram_slot_free(), zram_bvec_rw() or
zram_reset_device(). This also
On Mon, Sep 09, 2013 at 03:01:24PM -0400, Lidza Louina wrote:
This patch removes casting around kzalloc calls.
The casts aren't needed because kzalloc returns
a void pointer.
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgnc/dgnc_driver.c | 4 ++--
1 file
On Tue, Sep 17, 2013 at 02:53:23PM -0300, Fabio Estevam wrote:
Since commit b5dc0d10 (drm/imx: kill firstopen callback) the following probe
failure is seen:
[drm] Supports vblank timestamp caching Rev 1 (10.10.2010).
[drm] No driver support for vblank timestamp query.
[drm] Initialized
On Sun, Sep 22, 2013 at 12:27:47AM +0200, Peter Senna Tschudin wrote:
The variable ownbit_flag is only assigned the values true and false.
Change its type to bool.
The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):
@exists@
type T;
On Mon, Sep 23, 2013 at 04:13:15PM -0400, Lidza Louina wrote:
This patch adds the staging/dgnc [DIGI NEO AND CLASSIC
PCI PRODUCTS] and staging/dgap [DIGI EPCA PCI PRODUCTS]
drivers to the MAINTAINERS file. I am listed as the
maintainer and the driverdev-devel list is the mailing
list for
On Tue, Sep 24, 2013 at 09:20:50PM +0900, Akira Hayakawa wrote:
Hi, Mike
I am now working on redesigning and implementation
of dm-writeboost.
Ok, I'm dropping your original patch, please resend when you have
something you want merged into drivers/staging/
thanks,
greg k-h
On Mon, Sep 09, 2013 at 03:01:27PM -0400, Lidza Louina wrote:
The arguments that were passed into sizeof were
generic. This patch changes this by putting
the actual item that we need a size of instead.
For example:
- kzalloc(sizeof(struct dgnc_board), GFP_KERNEL);
+
On Sat, Sep 14, 2013 at 02:21:03PM +0300, Elad Wexler wrote:
From: Elad Wexler elad.wex...@gmail.com
'timed_gpio_probe()' shall return -ENXIO (no such address or device) in case
of NULL platform data.
Care to wrap your lines in the future? :)
Anyway, how can platform data be NULL? Have
On Mon, Sep 16, 2013 at 03:43:28PM +0200, Iker Pedrosa wrote:
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use
usleep instead.
In the first revision Greg KH pointed out that this change
On Wed, Sep 25, 2013 at 08:20:22PM -0300, Fabio Estevam wrote:
Hi Greg,
On Tue, Sep 17, 2013 at 4:55 PM, Greg KH gre...@linuxfoundation.org wrote:
Greg,
The offending commit that causes the regression is in 3.12-rc1 now, so this
patch could go via your staging tree.
Thanks
On Wed, Sep 25, 2013 at 07:08:52PM -0400, Lidza Louina wrote:
This patch removes these smatch warnings:
redundant null check on dgap_TmpWriteBuf calling kfree()
redundant null check on brd-SerialDriver-ttys calling kfree()
redundant null check on brd-PrintDriver-ttys calling kfree()
The
On Wed, Sep 25, 2013 at 07:08:50PM -0400, Lidza Louina wrote:
This patch removes these smatch warnings from dgap_driver.c:
redundant null check on dgap_config_buf calling kfree()
redundant null check on brd-flipbuf calling kfree()
redundant null check on brd-flipflagbuf calling kfree()
On Fri, Sep 27, 2013 at 05:39:11PM +0200, Martin Berglund wrote:
On Fri, Sep 27, 2013 at 03:27:29PM +0300, Dan Carpenter wrote:
On Fri, Sep 27, 2013 at 02:08:07PM +0200, Martin Berglund wrote:
@@ -508,9 +506,8 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
The following changes since commit 4a10c2ac2f368583138b774ca41fac4207911983:
Linux 3.12-rc2 (2013-09-23 15:41:09 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.12-rc3
for you to fetch changes up to
On Sat, Sep 28, 2013 at 09:03:24PM +0200, Martin Berglund wrote:
Cleanup of a few brace coding style issues.
Signed-off-by: Martin Berglund mar...@rogsta.net
---
drivers/staging/vt6655/80211mgr.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
Applied, thanks.
On Fri, Sep 27, 2013 at 07:11:47AM -0400, Lidza Louina wrote:
On Fri, Sep 27, 2013 at 5:50 AM, Sachin Kamat sachin.ka...@linaro.org wrote:
This check is not required.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Cc: Lidza Louina lidza.lou...@gmail.com
---
On Fri, Sep 27, 2013 at 09:36:28AM +0530, Sachin Kamat wrote:
Pointers should be assigned NULL instead of 0.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Most of the patches in this series will give checkpatch errors related
to spacing and indentation. This is because the driver
On Tue, Oct 01, 2013 at 06:46:44PM -0700, Joe Perches wrote:
On Tue, 2013-10-01 at 21:39 -0400, Mathieu Rhéaume wrote:
Fixed a lot of warnings from checkpatch.pl about the 80 characters per line
limitation.
I'd prefer
s/binder_user_error/binder_user_err/
or
On Tue, Oct 01, 2013 at 03:03:58PM +0530, Kamlakant Patel wrote:
drivers/staging/Kconfig | 2 +
drivers/staging/Makefile | 1 +
drivers/staging/mt29f_spinand/Kconfig | 16 +
drivers/staging/mt29f_spinand/Makefile| 1 +
On Tue, Oct 01, 2013 at 03:03:58PM +0530, Kamlakant Patel wrote:
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -136,6 +136,8 @@ source drivers/staging/goldfish/Kconfig
source drivers/staging/netlogic/Kconfig
+source drivers/staging/mt29f_spinand/Kconfig
+
Any reason
On Thu, Oct 03, 2013 at 12:39:08PM -0400, Theodore Ts'o wrote:
I've been auditing uses of get_random_bytes() since there are places
where get_random_bytes() is getting used where something weaker, such
as prandom_u32() is quite sufficient. Basically, if kernel code just
needs a random number
The following changes since commit 15c03dd4859ab16f9212238f29dd315654aa94f6:
Linux 3.12-rc3 (2013-09-29 15:02:38 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.12-rc4
for you to fetch changes up to
On Fri, Oct 04, 2013 at 07:31:03AM +0530, Varun B Patil wrote:
ioctl_codec_process was calling get_paddr() with a wrong pointer as
argument which resulted in wrong req_id being used to get the transaction
inside get_paddr().
Signed-off-by: Varun B Patil varun.basavaraj.pa...@gmail.com
---
Where are patches 1/4 and 2/4 in this series?
On Thu, Oct 17, 2013 at 12:21:33AM +0530, Dhanunjaya wrote:
This is a patch to the vb_setmode.c file that fixes braces {}
are not necessary for single statement blocks warning found
by the checkpatch.pl tool
Signed-of-by: Dhanunjaya
On Thu, Oct 17, 2013 at 12:54:52AM +0530, Dhanunjaya Naidu Ravada wrote:
From: Dhanunjaya dhanunjaya.mat...@gmail.com
Again, doesn't match the signed-off-by: or From: line on your email :(
This is a patch to the ni_660x.c file that fixes up a semicolon warning
found by the checkpatch.pl tool.
On Wed, Oct 16, 2013 at 12:57:35PM -0300, Geyslan G. Bem wrote:
Casting (void *) value returned by kzalloc is useless
as mentioned in Documentation/CodingStyle, Chap 14.
Signed-off-by: Geyslan G. Bem geys...@gmail.com
---
drivers/staging/dgnc/dgnc_driver.c | 6 ++
1 file changed, 2
On Sat, Oct 19, 2013 at 08:28:21AM -0700, Lisa Nguyen wrote:
Fix cfs_bitmap_t struct and function parameters to eliminate the
Do not add new typedefs warning generated by checkpatch.pl and
meet kernel coding style.
Signed-off-by: Lisa Nguyen l...@xenapiadmin.com
---
On Sat, Oct 19, 2013 at 01:02:25AM +0300, Eli Billauer wrote:
This is necessary so that xillybus_core uses the correct device pointer
for PCIe devices in diagnostic message calls (dev_err, dev_warn and dev_info)
Signed-off-by: Eli Billauer eli.billa...@gmail.com
Nice job with these patches,
On Sat, Oct 19, 2013 at 10:01:42PM +0530, Rashika Kheria wrote:
This patch fixes the following Smatch warning in zram_drv.c-
~/git/kernels/linux/drivers/staging/zram/zram_drv.c:663
reset_store() warn: variable dereferenced before check 'bdev' (see line 652)
On Sat, Oct 19, 2013 at 02:06:42PM -0700, Lisa Nguyen wrote:
Fix cfs_bitmap struct, function parameters, and variable
declarations to eliminate the Do not add new typedefs
warning generated by checkpatch.pl and meet kernel coding
style.
Signed-off-by: Lisa Nguyen l...@xenapiadmin.com
---
On Sat, Oct 19, 2013 at 04:15:25PM -0700, Lisa Nguyen wrote:
On Sat, Oct 19, 2013 at 2:39 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
Your patch is great, but actually, are any of the functions in this
header used? `grep cfs_bitmap drivers/staging/lustre/ -Rl` only shows
this
On Sun, Oct 20, 2013 at 03:45:46PM -0700, Lisa Nguyen wrote:
Modified all structs in libcfs_hash header file to eliminate
the Do not add new typedefs warning generated by checkpatch.pl
and meet kernel coding style.
Signed-off-by: Lisa Nguyen l...@xenapiadmin.com
This patch breaks the build
On Thu, Oct 24, 2013 at 09:46:53AM -0500, Larry Finger wrote:
On 10/24/2013 05:10 AM, Dan Carpenter wrote:
I have looked at how this is called from ioctl_private_call() and it
seems like these are actual user pointers and the code is buggy. The
patch silences the warnings instead of fixing
On Wed, Oct 23, 2013 at 11:20:12AM +0800, Chen Gang wrote:
For some architectures (e.g. arc), BASE_BAUD cannot be constant number.
So have to delay initializing 'old_serial_port.baud_base', or can not
pass compiling.
The related error (allmodconfig for arc with gcc-4.8.0):
CC [M]
On Fri, Oct 25, 2013 at 01:22:52PM -0700, Lisa Nguyen wrote:
Remove spaces between function names and open parentheses to
meet kernel coding style and eliminate extra space warnings
generated by checkpatch.pl
Signed-off-by: Lisa Nguyen l...@xenapiadmin.com
This series doesn't apply either,
On Tue, Oct 29, 2013 at 12:14:14AM +0100, Andi Shyti wrote:
Hi Greg,
If you write it like this:
return !ret ? ret : -ETIMEDOUT;
checkpatch shouldn't complain.
No, but I will.
That's horrid code, please be specific and readable, no one should ever
use ?: syntax
On Thu, Oct 24, 2013 at 01:02:45AM +0300, Dan Carpenter wrote:
On Wed, Oct 23, 2013 at 03:11:20PM -0400, Chuong Ngo wrote:
Removed a developer debug statement per the TODO list. Additionally,
removed braces for the if-statement to match coding style.
Line wrap the changelog at 72
On Mon, Oct 28, 2013 at 11:51:39PM -0400, Kevin McKinney wrote:
This patch removes typedef for _U_IP_ADDRESS, and
changes the name of the struct to bcm_ip_address. In
addition, any calls to struct U_IP_ADDRESS are
changed to call directly.
Signed-off-by: Kevin McKinney klmckinn...@gmail.com
On Tue, Oct 29, 2013 at 09:01:48AM -0700, Greg KH wrote:
On Mon, Oct 28, 2013 at 11:51:39PM -0400, Kevin McKinney wrote:
This patch removes typedef for _U_IP_ADDRESS, and
changes the name of the struct to bcm_ip_address. In
addition, any calls to struct U_IP_ADDRESS are
changed to call
Hi all,
Given that 3.12 will be out in a few days, it's time to close my trees
for new patches until 3.13-rc1 is out.
The merge window for 3.13-rc1 is going to be a bit longer than normal as
Linus has pointed out, due to travel and conferences. I'll also be
traveling for 2 weeks, so my response
On Tue, Nov 05, 2013 at 01:53:28AM +1300, Simon Crequer wrote:
Fixed a coding style issue.
Signed-off-by: Simon Crequer simoncreq...@gmail.com
---
drivers/staging/dgnc/dgnc_cls.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Someone else beat you to this change, sorry, it no
On Sun, Nov 10, 2013 at 04:13:05PM +0100, Joachim Adolf Schuetz wrote:
Fixed some coding style issues - a few braces and indentions.
Signed-off-by: Joachim Adolf Schuetz j...@catbull.com
---
drivers/staging/cxt1e1/comet.c | 31 +--
1 files changed, 13
On Fri, Nov 08, 2013 at 05:00:43PM +0800, micky_ch...@realsil.com.cn wrote:
--- /dev/null
+++ b/drivers/staging/rts5208/TODO
@@ -0,0 +1,5 @@
+TODO:
+- use kernel coding style
+- checkpatch.pl fixes
+- We will use the stack in drivers/mmc to implement
+ rts5208/5288 in the future
In the
On Fri, Nov 01, 2013 at 06:01:56PM +0530, Conrad Gomes wrote:
This is a patch which fixes coding style issues in unioxx5.c found
by checkpatch.pl
1) Replaced printk with pr_info and pr_err
Drivers should never call printk() as they all have access to a struct
device somewhere. So please
On Thu, May 29, 2014 at 04:01:27PM +0900, Daeseok Youn wrote:
This reverts commit 0ade4a34fd439d62df46937e8f3e584eb0879579.
This patch removes kfree for serial_ports in dgap_tty_register_ports()
if the brd-printer_ports allocation fails and serial_ports may be
freed by calling
On Wed, May 28, 2014 at 04:23:47PM -0700, Chaitanya Hazarey wrote:
Fixed a misplaced brace in a function
Signed-off-by: Chaitanya Hazarey c...@24.io
---
drivers/staging/rtl8192u/r8192U_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Where is patch 2/2 ?
On Thu, May 29, 2014 at 09:40:39AM +0300, Dan Carpenter wrote:
On Thu, May 29, 2014 at 09:17:09AM +0900, DaeSeok Youn wrote:
Hi, Dan.
2014-05-28 19:11 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Wed, May 28, 2014 at 06:29:38PM +0900, DaeSeok Youn wrote:
In your patch it
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, May 29, 2014 at 01:43:01PM -0700, Chaitanya Hazarey wrote:
I have 1/5 through to 5/5. Will resend rightaway with slightly changed
subjects.
What does that have to do with patch 2/2 here?
On Fri, May 30, 2014 at 12:41:15AM +0300, Dan Carpenter wrote:
On Thu, May 29, 2014 at 02:00:51PM -0700, Greg KH wrote:
On Thu, May 29, 2014 at 01:43:01PM -0700, Chaitanya Hazarey wrote:
I have 1/5 through to 5/5. Will resend rightaway with slightly changed
subjects.
What does
On Thu, May 29, 2014 at 11:54:52PM +0200, abdoulaye berthe wrote:
Signed-off-by: abdoulaye berthe berthe...@gmail.com
Why?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, May 30, 2014 at 08:16:59PM +0200, Lars-Peter Clausen wrote:
On 05/30/2014 07:33 PM, David Daney wrote:
On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote:
On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe berthe...@gmail.com
wrote:
--- a/drivers/gpio/gpiolib.c
+++
On Fri, May 30, 2014 at 03:56:44PM +1000, Scott Weir wrote:
On Wed, May 28, 2014 at 02:30:27PM -0700, Greg KH wrote:
On Wed, May 28, 2014 at 06:52:51PM +1000, Scott Weir wrote:
This patch corrects coding style issue:
WARNING: Missing a black line after declarations
Signed-off
On Mon, Jun 02, 2014 at 11:08:00AM +0200, Matthias Beyer wrote:
Signed-off-by: Matthias Beyer m...@beyermatthias.de
The information you put in the 0/1 message should be here in the
changelog entry.
And for a single patch, you don't need a 0/1 message, just send the
patch itself.
Care to fix
The following changes since commit 4b660a7f5c8099d88d1a43d8ae138965112592c7:
Linux 3.15-rc6 (2014-05-22 06:42:02 +0900)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.15-rc8
for you to fetch changes up to
On Mon, Jun 02, 2014 at 04:00:28PM -0700, Mitchel Humpherys wrote:
What's the protocol for UAPI headers in staging drivers? Specifically,
I'm wondering how people usually install those headers. For example,
there are a bunch of Android UAPI headers under
drivers/staging/android/uapi which
On Tue, Jun 03, 2014 at 09:43:35AM -0500, Ken Cox wrote:
The unisys drivers now properly check to make sure they are running
on the s-Par platform before they will initialize. This was fixed in
commit fcd0157ece so it is safe to allow the unisys drivers to be built.
This has been tested in
On Tue, Jun 03, 2014 at 02:34:55PM -0700, Chaitanya Hazarey wrote:
On Tue, Jun 3, 2014 at 11:36 AM, Dan Carpenter dan.carpen...@oracle.com
wrote:
It always feels much better after the dead code is gone.
So patches are still good ? No change required for my side, right ? I
just need to
On Tue, Jun 03, 2014 at 11:41:21PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Greg,
One of the patches in my last set had a bad bug which made the driver
mask out the bits used to determine the correct location of the 40MHz
channel location.
This
On Wed, Jun 04, 2014 at 08:28:36PM +0530, Adithya.K wrote:
From: Adithya K linux.challen...@gmail.com
Fixed few checkpatch.pl warnings.
Be specific about _what_ warnings you fixed. And if you fix more than
one type of warning, please break it up into different patches (each
patch only can do
On Thu, Jun 05, 2014 at 11:04:32AM -0500, Ken Cox wrote:
Added I/O versions for the functions vbuschannel_devinfo_to_string()
and ultra_vbus_init_channel() to get rid of noderef sparse warnings when
accessing I/O space.
Signed-off-by: Ken Cox j...@redhat.com
---
On Fri, Jun 06, 2014 at 08:02:13PM -0700, Thomas Wood wrote:
Changes since v1:
* Made single patch into a patch set.
* Added better commit messages.
Is this better, or do I still have to split up my first patch?
At first glance, it looks fine, I'll queue this up after 3.16-rc1 is out
(in
On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Greg,
Thanks for pushing my other changes to Linus. This set goes on top of
the set I sent you on 2014/05/31 and the fix from 2014/06/03. If you
prefer I go back and submit
On Mon, Jun 09, 2014 at 05:39:54PM +0200, Jes Sorensen wrote:
Greg KH gre...@linuxfoundation.org writes:
On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Greg,
Thanks for pushing my other changes to Linus. This set
On Mon, Jun 09, 2014 at 05:51:24PM +0200, Jes Sorensen wrote:
Greg KH gre...@linuxfoundation.org writes:
On Mon, Jun 09, 2014 at 05:39:54PM +0200, Jes Sorensen wrote:
Greg KH gre...@linuxfoundation.org writes:
I don't feel comfortable justifying that to Linus or anyone about how
On Mon, Jun 09, 2014 at 10:54:46AM -0500, Larry Finger wrote:
On 06/09/2014 10:39 AM, Jes Sorensen wrote:
Greg KH gre...@linuxfoundation.org writes:
On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Greg,
Thanks
On Tue, Jun 10, 2014 at 10:33:51PM +0530, Raghavendra wrote:
Replaced 'printk' with 'netdev_info' and 'netdev_err' wherever necessary.
Also fixed the coding issue cooresponding to line gap after the declarations.
Please don't do multiple things in the same patch, a single patch should
only do 1
On Wed, Jun 11, 2014 at 09:25:47AM +0530, A Raghavendra Rao wrote:
From: Raghavendra ar...@cdac.in
Fixed coding style issues
Which specific coding style issue? Be exact please.
And don't try to fix more than one type of coding style issue at a
time...
Signed-off-by: A Raghavendra Rao
On Wed, Jun 11, 2014 at 10:23:09PM +0200, mathias.en...@gmail.com wrote:
From: Mathias Engan mathias.en...@gmail.com
Add blank lines after declarations in eucr_suspend and eucr_resume
as reported by checkpatch.
Signed-off-by: Mathias Engan mathias.en...@gmail.com
---
This patch is a
On Thu, Jun 12, 2014 at 09:28:56AM +0200, mathias.en...@gmail.com wrote:
From: Mathias Engan mathias.en...@gmail.com
Add blank line after declarations in eucr_suspend and eucr_resume
as reported by checkpatch.
Signed-off-by: Mathias Engan mathias.en...@gmail.com
---
On Fri, Jun 13, 2014 at 10:59:30PM +0800, Real Name wrote:
Hi, Greg
I scaned the git log of linux-next/drivers/staging. It seems all
patches for coding style clean up had been signed off/picked up by
you. Could you please sign or reject these patches?
You sent these patches:
On Thu, Jun
On Fri, Jun 13, 2014 at 05:52:33PM +0200, Benedict Boerger wrote:
Fix a coding style issue found by checkpatch.pl.
Use ether_addr_copy instead of memcpy.
Done to complete a eudyptula task.
Signed-off-by: Benedict Boerger benedict.boer...@cs.tu-dortmund.de
---
On Sat, Jun 14, 2014 at 02:04:38PM +0900, Seunghun Lee wrote:
This patch fixes below warning.
drivers/staging/ced1401/ced_ioc.c:703:30: warning: incorrect type in
assignment (different address spaces)
drivers/staging/ced1401/ced_ioc.c:703:30:expected void *[usertype]
lpvBuff
On Mon, Jun 16, 2014 at 11:23:13PM -0400, Nicholas Krause wrote:
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
On Tue, Jun 17, 2014 at 11:05:16AM -0400, Nicholas Krause wrote:
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
On Sat, Jun 14, 2014 at 07:36:31PM +0200, Toralf Förster wrote:
The html formatter of the static checker Cppcheck stumbles over that file. In
fact, even this small python snippet :
#!/usr/bin/env python
import io
source_filename =
On Tue, Jun 17, 2014 at 12:04:59PM -0400, Nick Krause wrote:
I created it using git-format patch and check my condition is
wrong should be !skb to check for Nulls .
That's not the real problem here.
The real issue is you can not apply your patch to any tree. Please
remove all patches from
On Tue, Jun 17, 2014 at 12:07:12PM -0400, Nicholas Krause wrote:
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
Lots of things wrong here, please step back, and slow down.
Your subject, this really isn't v2, is it?
On Tue, Jun 17, 2014 at 05:18:01PM -0400, Nicholas Krause wrote:
Signed-off-by: Nicholas Krause xerofo...@gmail.com
You aren't saying what you are doing here in the body of the patch, why
On Mon, Jun 09, 2014 at 03:15:59PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
drivers/staging/rtl8723au/core/rtw_ieee80211.c | 29
+-
1 file changed, 14 insertions(+), 15
On Mon, Jun 09, 2014 at 09:05:33AM -0700, Greg KH wrote:
On Mon, Jun 09, 2014 at 10:54:46AM -0500, Larry Finger wrote:
On 06/09/2014 10:39 AM, Jes Sorensen wrote:
Greg KH gre...@linuxfoundation.org writes:
On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote:
From: Jes
On Tue, Jun 03, 2014 at 09:43:35AM -0500, Ken Cox wrote:
The unisys drivers now properly check to make sure they are running
on the s-Par platform before they will initialize. This was fixed in
commit fcd0157ece so it is safe to allow the unisys drivers to be built.
This has been tested in
On Thu, Jun 05, 2014 at 01:56:16PM -0500, Ken Cox wrote:
Added I/O version for the function ultra_vbus_init_channel() to get rid
of noderef sparse warnings when accessing I/O space.
Signed-off-by: Ken Cox j...@redhat.com
---
.../common-spar/include/channels/vbuschannel.h | 40
On Tue, Jun 17, 2014 at 11:59:20PM +0900, Masanari Iida wrote:
This patch removed trailing semicolon from macro in guestlinuxdebug.h
Signed-off-by: Masanari Iida standby2...@gmail.com
---
drivers/staging/unisys/include/guestlinuxdebug.h | 6 +++---
1 file changed, 3 insertions(+), 3
On Thu, Jun 05, 2014 at 01:56:14PM -0500, Ken Cox wrote:
This series gets rid of some sparse noderef warnings by adding I/O versions
of the functions that are producing the warnings and also removing __iomem
declarations where they are not needed.
But you forgot to delete the now unused
On Wed, Jun 18, 2014 at 09:05:09AM +0200, Jes Sorensen wrote:
Greg KH gre...@linuxfoundation.org writes:
On Mon, Jun 09, 2014 at 03:15:59PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
On Wed, Jun 18, 2014 at 12:15:46AM -0700, Greg KH wrote:
On Wed, Jun 18, 2014 at 09:05:09AM +0200, Jes Sorensen wrote:
Greg KH gre...@linuxfoundation.org writes:
On Mon, Jun 09, 2014 at 03:15:59PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
On Wed, Jun 18, 2014 at 01:53:00PM -0400, Nicholas Krause wrote:
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
On Sat, May 31, 2014 at 06:05:07PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Hi Greg,
A smaller set of patches this time. It's mainly cleanups, removal of
yet more locally duplicated structs, and some endian fixes. Note the
endian fixes shouldn't
On Tue, Jun 03, 2014 at 11:41:22PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
commit 2dc5e6e90892d7247fbe8c25714dba3c0ba744e8
That commit is in your tree, not Linus's :)
I'll edit it with the proper number now...
On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Greg,
Thanks for pushing my other changes to Linus. This set goes on top of
the set I sent you on 2014/05/31 and the fix from 2014/06/03. If you
prefer I go back and submit
301 - 400 of 4692 matches
Mail list logo
