Re: [PATCH 00/12] staging-next: rtl8723au: More fixes and duplicate defines

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 10:24:56PM +0200, Jes Sorensen wrote: Greg KH gre...@linuxfoundation.org writes: On Sat, May 31, 2014 at 06:05:07PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Hi Greg, A smaller set of patches this time. It's mainly

Re: [PATCH 1/6] staging: comedi: addi_apci_1564: remove send_sig() use

2014-06-18 Thread Greg KH
On Thu, May 29, 2014 at 11:41:53PM -0500, Chase Southwood wrote: The addi-data drivers use send_sig() to let the user know when an interrupt has occurred. The standard way to do this in the comedi subsystem is to have a subdevice that supports asynchronous commands and use comedi_event() to

Re: [PATCH v2 1/5] staging: comedi: addi_apci_1564: remove use of devpriv-b_OutputMemoryStatus

2014-06-18 Thread Greg KH
On Tue, Jun 03, 2014 at 09:33:37PM -0500, Chase Southwood wrote: This member of the private data struct is only set at one location in the entire driver, and then never even used for anything. Let's just remove its use. Signed-off-by: Chase Southwood chase.southw...@gmail.com Reviewed-by:

Re: [PATCH] Fixes no Null check of dev_skb_alloc in fw_download_code

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 05:26:18PM -0400, Nicholas Krause wrote: Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 1 file changed, 4 insertions(+) Some more meta-comments. Your subject: should give people a clue as to where

Re: [PATCH V2] Staging:tidspbridge Fix minor checkpatch.pl warning.

2014-06-18 Thread Greg KH
On Sun, Jun 08, 2014 at 02:26:20PM +0530, Adithya Krishnamurthy wrote: From: Adithya Krishnamurthy linux.challen...@gmail.com Fixed checkpatch WARNING: Missing a blank line after declarations Signed-off-by: Adithya Krishnamurthy linux.challen...@gmail.com ---

Re: [PATCH] staging: keucr: fix Missing blank line after declarations

2014-06-18 Thread Greg KH
On Sat, Jun 14, 2014 at 09:39:53PM +0200, Benedict Boerger wrote: fix two Missing blank line after declarations issue reported by checkpatch.pl Done to complete an eudyptula task. Signed-off-by: Benedict Boerger benedict.boer...@cs.tu-dortmund.de --- drivers/staging/keucr/usb.c | 2 ++

Re: [PATCH] staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue

2014-06-18 Thread Greg KH
On Thu, Jun 12, 2014 at 07:27:12PM +0400, Andrey Skvortsov wrote: Signed-off-by: Andrey Skvortsov andrej.skvort...@gmail.com --- drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c |8 This patch does not apply to my tree for one chunk. Can you please refresh it against

Re: [PATCHv2]staging:rtl8192e:check return value of dev_skb_alloc

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 06:23:00PM -0400, Nicholas Krause wrote: diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 11e915e..fde17ff 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +++

Re: [PATCHv4]staging:rtl8192e: check return value of dev_skb_alloc

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 07:10:30PM -0400, Nicholas Krause wrote: diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..1a90546 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +++

Re: Anybody working on crystalhd?

2014-06-18 Thread Greg KH
On Thu, Jun 19, 2014 at 12:07:38AM +, Naren (Narendra) Sankar wrote: We have EOL this part and have not been selling it for a while and there has been no new customer interest in a long time. So I am also ok with this moving off the kernel and being dropped. Great, thanks for the quick

Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 10:24:41PM -0400, Nicholas Krause wrote: Checks if dev_skb_alloc returns Null in function, fw_download_code. If the return value of dev_skb_alloc is NULL return false and exit this function. Signed-off-by: Nicholas Krause xerofo...@gmail.com ---

Re: [PATCH] staging: ced1401: fix sparse warning for ced1401

2014-06-18 Thread Greg KH
On Sat, Jun 14, 2014 at 02:04:38PM +0900, Seunghun Lee wrote: This patch fixes below warning. drivers/staging/ced1401/ced_ioc.c:703:30: warning: incorrect type in assignment (different address spaces) drivers/staging/ced1401/ced_ioc.c:703:30:expected void *[usertype] lpvBuff

Re: lustre virtual block device doesn't build w/ CONFIG_ARM64_64K_PAGES=y

2014-06-19 Thread Greg KH
On Thu, Jun 19, 2014 at 12:33:21PM -0600, dann frazier wrote: With current git, lustre fails to build with CONFIG_ARM64_64K_PAGES=y and CONFIG_LUSTRE_LLITE_LLOOP=m: make -f scripts/Makefile.build obj=drivers/staging/lustre/lustre/llite gcc

Re: [PATCH 1/5] Staging: rtl8192u: r8192U_wx.c Fixed one misplaced brace

2014-06-19 Thread Greg KH
On Thu, May 29, 2014 at 01:45:17PM -0700, Chaitanya Hazarey wrote: Fixed a misplaced brace in the r8192_wx_set_scan_type function. Signed-off-by: Chaitanya Hazarey c...@24.io --- drivers/staging/rtl8192u/r8192U_wx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 5/5] Staging: rtl8192u: r8192U_wx.c Removed commented dead code

2014-06-19 Thread Greg KH
On Thu, May 29, 2014 at 01:45:21PM -0700, Chaitanya Hazarey wrote: Removed dead code from the file. Signed-off-by: Chaitanya Hazarey c...@24.io --- drivers/staging/rtl8192u/r8192U_wx.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git

Re: [PATCH 1/4] Staging: rtl8192u: r8192U_wx.c removed some dead code

2014-06-19 Thread Greg KH
On Mon, Jun 02, 2014 at 09:11:42AM -0700, Chaitanya Hazarey wrote: Removed dead code, commented out printks and DMESG. Signed-off-by: Chaitanya Hazarey c...@24.io This patch does not apply :( ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: rts5139: remove unnecessary parenthesis

2014-06-19 Thread Greg KH
On Fri, May 30, 2014 at 12:38:53PM +1000, Sam Bobroff wrote: Remove some unnecessary parenthesis as recommended by checkpatch.pl. Signed-off-by: Sam Bobroff sam.bobr...@au1.ibm.com --- drivers/staging/rts5139/rts51x_scsi.c |8 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [PATCH] staging: android: binder: Fix 10 overlong lines

2014-06-19 Thread Greg KH
On Sat, May 31, 2014 at 05:29:53PM -0600, Daniel Dressler wrote: This patch was made following Greg Kroah-Hartman's newbie guide. It is not intended to make any logical alterations to codeflow. Of note to reviews this patch switch's a call to kzalloc to kcalloc on line 2837 Neil Brown gave

Re: [PATCH 2/2] staging: vt6656: fix leaks in error path

2014-06-19 Thread Greg KH
On Fri, May 30, 2014 at 08:47:44PM +0200, Nicolas Thery wrote: Fix memory leaks in ioctl error handling paths. Signed-off-by: Nicolas Thery nth...@gmail.com --- drivers/staging/vt6656/hostap.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) This patch is not in the kernel tree

Re: [PATCH 1/3] staging: vt6655: update out-of-date function declaration

2014-06-19 Thread Greg KH
On Sun, Jun 01, 2014 at 10:19:31PM -0400, James A Shackleford wrote: The function iwctl_siwscan() is defined in iwctl.c as: int iwctl_siwscan(struct net_device *dev, struct iw_request_info *info, struct iw_point *wrq, char *extra) { ...

Re: [PATCH v3] staging: vt6655: preserve address space in ethtool_ioctl()

2014-06-19 Thread Greg KH
On Tue, Jun 17, 2014 at 02:40:27PM +0200, Martin Kepplinger wrote: Fix the sparse error: cast removes address space of expression and add __user annotation to the driver's ethtool_ioctl(). Signed-off-by: Martin Kepplinger mart...@posteo.de --- I think I forgot to change the declaration on

Re: [PATCH] Staging: panel: fixed checkpatch errors in panel.c

2014-06-19 Thread Greg KH
On Sun, Jun 01, 2014 at 03:20:55AM -0700, Vincent Heuken wrote: This patch simply fixes the style errors in panel.c that scripts/checkpatch.pl reported Which style errors? Please be specific. And break the patch up into only doing one type of fix at a time, otherwise it's hard to review.

Re: [PATCH v2 5/5] staging: ft1000: ft1000-usb: ft1000_debug.c: Misc. fixes.

2014-06-19 Thread Greg KH
On Fri, Jun 06, 2014 at 08:02:18PM -0700, Thomas Wood wrote: Remove initialization of static value. Invert the empty if statement's test to replace the else statement. Remove parentheses from a return statement. Fix some code indentation. Signed-off-by: Thomas Wood tommyandr...@gmail.com

Re: [PATCH 1/2] Staging: bcm: Prototypes.h: fix checkpatch errors

2014-06-19 Thread Greg KH
On Wed, Jun 18, 2014 at 04:10:05PM +0200, Christian Bay wrote: This patch fixes all errors, excluding 80 character warnings, shown by the checkpatch script. In detail whitespace changes according to the coding guideline are meant. Additionally there is exactly one newline after every

Re: [PATCH 2/2] Staging: bcm: Queue.h: fix checkpatch errors

2014-06-19 Thread Greg KH
On Wed, Jun 18, 2014 at 04:10:06PM +0200, Christian Bay wrote: This patch fixes all checkpatch errors and warnings in Queue.h: Whitespaces, brackets and comments according to the coding guideline Same as the previous one, thanks. greg k-h ___ devel

Re: [PATCH]staging: rtl8821ae: translate some comments

2014-06-19 Thread Greg KH
On Mon, Jun 16, 2014 at 07:35:34PM +0200, Toralf Förster wrote: comments were translated with https://translate.google.com/ this enables python to parse that file right This patch fails to apply :( ___ devel mailing list de...@linuxdriverproject.org

staging driver patch queue is empty

2014-06-19 Thread Greg KH
Hi all, I've now caught up with all pending staging driver patches that I had, with the exception of 2 android binder patches that I want to get some review / acks from some android developers on before applying. If you have sent me a patch for the staging tree that has not been applied,

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-19 Thread Greg KH
On Fri, Jun 20, 2014 at 06:57:04AM +0200, Olaf Hering wrote: On Thu, Jun 19, Haiyang Zhang wrote: The RNDIS_STATUS_NETWORK_CHANGE event is received after the Hyper-V host sleep or hibernation. We refresh network at this time. + char *argv[] = { /etc/init.d/network, restart, NULL };

Re: [PATCH] Fixed coding style problem

2014-06-20 Thread Greg KH
On Fri, Jun 20, 2014 at 10:50:09AM -0400, rbasukala wrote: --- drivers/staging/netlogic/xlr_net.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c index e320d6b..3ad48a0 100644 ---

Re: [PATCH] Staging: serqt_usb2: fixed frivolous else statement warnings

2014-06-20 Thread Greg KH
On Fri, Jun 20, 2014 at 06:23:17AM -0700, Vincent Heuken wrote: This is a patch to the serqt_usb2.c file that fixes two instances of the following checkpatch.pl warning: WARNING: else is not generally useful after a break or return Signed-off-by: Vincent Heuken m...@vincentheuken.com ---

Re: [PATCH] fix coding style issue

2014-06-20 Thread Greg KH
On Fri, Jun 20, 2014 at 11:25:58AM -0400, rbasukala wrote: Signed-off-by: rbasukala basukalaram...@gmail.com --- drivers/staging/netlogic/xlr_net.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/netlogic/xlr_net.c

Re: Anybody working on bcm?

2014-06-20 Thread Greg KH
On Fri, Jun 20, 2014 at 02:07:32PM -0400, Kevin McKinney wrote: On Fri, Jun 20, 2014 at 1:13 PM, Stephen Hemminger step...@networkplumber.org wrote: On Fri, 20 Jun 2014 19:49:33 +0300 Kristina Martšenko kristina.martse...@gmail.com wrote: Hi Stephen, I'm helping

Re: Anybody working on panel?

2014-06-20 Thread Greg KH
On Fri, Jun 20, 2014 at 09:39:26PM +0300, Kristina Martšenko wrote: On 20/06/14 19:52, Willy Tarreau wrote: Hi Kristina, On Fri, Jun 20, 2014 at 06:35:03PM +0300, Kristina Mart?enko wrote: Hi Willy, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody

Re: Anybody working on bcm?

2014-06-20 Thread Greg KH
On Fri, Jun 20, 2014 at 03:02:11PM -0400, Kevin McKinney wrote: On Fri, Jun 20, 2014 at 11:46:06AM -0700, Greg KH wrote: On Fri, Jun 20, 2014 at 02:07:32PM -0400, Kevin McKinney wrote: On Fri, Jun 20, 2014 at 1:13 PM, Stephen Hemminger step...@networkplumber.org wrote

[GIT PULL] Staging driver fixes for 3.16-rc2

2014-06-20 Thread Greg KH
The following changes since commit 7171511eaec5bf23fb06078f59784a3a0626b38f: Linux 3.16-rc1 (2014-06-15 17:45:28 -1000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.16-rc2 for you to fetch changes up to

Re: Anybody working on wlags49_h2?

2014-06-21 Thread Greg KH
On Sat, Jun 21, 2014 at 06:35:41PM +0100, Dave Kilroy wrote: On 20/06/2014 17:18, Kristina Martšenko wrote: I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving wlags49_h2(5) out of staging in over a year. Are there any plans to

Re: Anybody working on winbond?

2014-06-21 Thread Greg KH
On Sat, Jun 21, 2014 at 08:03:25PM +0200, Pavel Machek wrote: On Fri 2014-06-20 18:45:08, Kristina Martšenko wrote: Hi Pavel, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving winbond out of staging in over a year. Are

Re: Anybody working on wlags49_h2?

2014-06-21 Thread Greg KH
On Sat, Jun 21, 2014 at 10:54:29PM +0300, Kristina Martšenko wrote: On 21/06/14 22:46, Greg KH wrote: On Sat, Jun 21, 2014 at 06:35:41PM +0100, Dave Kilroy wrote: On 20/06/2014 17:18, Kristina Martšenko wrote: I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody

Re: [PATCH 00/11] staging-next: rtl8723au: Serious fixes and some removal of dead code

2014-06-21 Thread Greg KH
On Sat, Jun 21, 2014 at 10:20:12PM +0200, Jes Sorensen wrote: Greg KH gre...@linuxfoundation.org writes: On Sat, Jun 21, 2014 at 04:50:08PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Greg, Thanks for merging the last set. I starting going

Re: [PATCH v3 0/8] Cleanup patches for bcm staging driver

2014-06-23 Thread Greg KH
On Mon, Jun 23, 2014 at 11:45:26AM +0200, Matthias Beyer wrote: Hi, these patches are still not applied, am I right? You should have gotten an email if they went into my tree. If not, yes, please rebase and resend after checking my tree to verify they are not already there (same for your

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-23 Thread Greg KH
On Mon, Jun 23, 2014 at 04:09:59PM +, Haiyang Zhang wrote: -Original Message- From: Olaf Hering [mailto:o...@aepfle.de] Sent: Monday, June 23, 2014 9:17 AM To: Haiyang Zhang Cc: Greg KH; net...@vger.kernel.org; jasow...@redhat.com; driverdev- de

Re: Anybody working on gdm72xx?

2014-06-24 Thread Greg KH
On Tue, Jun 24, 2014 at 12:12:55AM -0700, Ben Chan wrote: On Mon, Jun 23, 2014 at 2:33 PM, Kristina Martšenko kristina.martse...@gmail.com wrote: Here is an example of another driver being moved out: http://www.spinics.net/lists/linux-usb/msg100924.html Thanks Kristina. checkpatch

Re: Anybody working on ced1401?

2014-06-24 Thread Greg KH
On Tue, Jun 24, 2014 at 11:14:40AM +0200, Luca Ellero wrote: On 23/06/2014 22:19, Kristina Martšenko wrote: Hi Angelo, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving quickstart out of staging in over a year. Are there

Re: [PATCH] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-06-24 Thread Greg KH
On Tue, Jun 24, 2014 at 08:29:17AM +0800, Dexuan Cui wrote: Currently the VSC has no chance to notify the VSP of the dirty rectangle on VM panic because the notification work is done in a workqueue, and in panic() the kernel typically ends up in an infinite loop, and a typical kernel config has

Re: Anybody working on line6?

2014-06-24 Thread Greg KH
On Tue, Jun 24, 2014 at 11:54:10AM +0800, Stefan Hajnoczi wrote: On Tue, Jun 24, 2014 at 4:23 AM, Kristina Martšenko kristina.martse...@gmail.com wrote: I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving line6 out of staging in

Re: [PATCH] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-06-25 Thread Greg KH
On Tue, Jun 24, 2014 at 09:44:14PM +, Dexuan Cui wrote: On Tue, Jun 24, 2014 at 08:29:17AM +0800, Dexuan Cui wrote: Currently the VSC has no chance to notify the VSP of the dirty rectangle on VM panic because the notification work is done in a workqueue, and in panic() the kernel

Re: [Patch v3 2/4] Staging: unisys: Fix sparse warnings in uislib

2014-06-25 Thread Greg KH
On Wed, Jun 25, 2014 at 02:01:03PM -0500, Ken Cox wrote: On 06/17/2014 06:01 PM, Greg KH wrote: On Thu, Jun 05, 2014 at 01:56:16PM -0500, Ken Cox wrote: Added I/O version for the function ultra_vbus_init_channel() to get rid of noderef sparse warnings when accessing I/O space. Signed-off

Re: [PATCH 1/4] Staging: unisys: remove references to __DATE__ and __TIME__

2014-06-25 Thread Greg KH
On Wed, Jun 25, 2014 at 11:48:23AM -0500, Ken Cox wrote: The use of __DATE__ and __TIME__ is no longer allowed in the kernel so this commit removes those. They were once useful when the drivers were being built externally, but now that the drivers are in the kernel the use of the macros is

Re: [PATCH 3/4] Staging: unisys: Remove build_date and build_time from virtpci_driver structure

2014-06-25 Thread Greg KH
On Wed, Jun 25, 2014 at 11:48:25AM -0500, Ken Cox wrote: The drivers do not need to keep track of these fields since the same information is present elsewhere in the kernel. Signed-off-by: Ken Cox j...@redhat.com Again, just do this, not the first one at all. greg k-h

Re: [PATCH 1/4] Staging: unisys: remove references to __DATE__ and __TIME__

2014-06-26 Thread Greg KH
On Thu, Jun 26, 2014 at 05:37:35AM -0500, Ken Cox wrote: On 06/25/2014 10:57 PM, Greg KH wrote: On Wed, Jun 25, 2014 at 11:48:23AM -0500, Ken Cox wrote: --snip-- .id_table = virthba_id_table, .probe = virthba_probe, .remove = virthba_remove, @@ -1413,9 +1413,6

Re: Anybody working on ced1401?

2014-06-26 Thread Greg KH
On Thu, Jun 26, 2014 at 09:36:17AM +0200, Alois Schloegl wrote: On 2014-06-18 13:33, Kristina Martšenko wrote: Hi Alois, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving ced1401 out of staging in over a year. Are there

Re: Anybody working on line6?

2014-06-26 Thread Greg KH
On Tue, Jun 24, 2014 at 10:12:03PM +0800, Stefan Hajnoczi wrote: On Tue, Jun 24, 2014 at 9:52 PM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Jun 24, 2014 at 11:54:10AM +0800, Stefan Hajnoczi wrote: On Tue, Jun 24, 2014 at 4:23 AM, Kristina Martšenko kristina.martse...@gmail.com wrote

Re: ACPI Support for HP Pavillion laptops

2014-06-26 Thread Greg KH
On Wed, Jun 25, 2014 at 08:19:52AM +0530, Chetal Patil wrote: Hi, I recently joined the Linux Driver Development mailing list and would like to contribute to the Linux Driver Project. Specifically, I would like to contribute by working on ACPI Support for HP Pavillion laptops (Referred list

Re: [PATCH 1/3] staging: rtl8188eu: core: Remove unnecessary conditionals

2014-06-26 Thread Greg KH
On Sun, Jun 22, 2014 at 01:01:50PM +0200, Thomas Vegas wrote: The variable 'pxmitbuf' is already set to NULL when entering the function. We can remove the first conditional. When _rtw_queue_empty() returns false, 'pxmitbuf' if not NULL. We can merge the second and third conditional.

Re: [PATCH 2/6] Staging: bcm: Indentation fixes

2014-06-26 Thread Greg KH
On Mon, Jun 23, 2014 at 01:41:05PM -0700, j...@joshtriplett.org wrote: On Mon, Jun 23, 2014 at 11:42:29AM +0200, Matthias Beyer wrote: This patch fixes some indentation errors, where multi-line statements where not indented. Signed-off-by: Matthias Beyer m...@beyermatthias.de This

Re: [PATCH] staging: winbond: remove driver

2014-06-26 Thread Greg KH
On Mon, Jun 23, 2014 at 06:41:29PM +0300, Kristina Martšenko wrote: The driver hasn't been cleaned up and nobody is working to do so, so remove it. Signed-off-by: Kristina Martšenko kristina.martse...@gmail.com Cc: Pavel Machek pa...@ucw.cz This patch didn't apply to my tree for some odd

Re: Anybody working on ced1401?

2014-06-27 Thread Greg KH
On Fri, Jun 27, 2014 at 03:04:43PM +0200, Luca Ellero wrote: Il 26/06/2014 21:23, Greg KH ha scritto: On Thu, Jun 26, 2014 at 09:36:17AM +0200, Alois Schloegl wrote: On 2014-06-18 13:33, Kristina Martšenko wrote: Hi Alois, I'm helping Greg do a bit of cleanup in the staging tree. I noticed

Re: [PATCH] Tools: hv: fix file overwriting of hv_fcopy_daemon

2014-06-27 Thread Greg KH
On Fri, Jun 27, 2014 at 05:16:48PM -0700, Yue Zhang wrote: From: Yue Zhang yue...@microsoft.com hv_fcopy_daemon fails to overwrite a file if the target file already exits. Add O_TRUNC flag on opening. MS-TFS: 341345 It's as if the people on your team don't talk to each other about what

Re: ACPI Support for HP Pavillion laptops

2014-06-28 Thread Greg KH
On Sun, Jun 29, 2014 at 12:30:52AM +0530, Chetal Patil wrote: Hi Greg, I have HP Pavilion dv4-1414tx laptop. I don't know exactly what is (/was) the issue and why ACPI support is needed for these laptops. After your reply I realized that the list

Re: [PATCH] staging: winbond: remove driver

2014-06-28 Thread Greg KH
On Sun, Jun 29, 2014 at 12:18:30AM +0300, Kristina Martšenko wrote: On 27/06/14 04:11, Greg KH wrote: On Mon, Jun 23, 2014 at 06:41:29PM +0300, Kristina Martšenko wrote: The driver hasn't been cleaned up and nobody is working to do so, so remove it. Signed-off-by: Kristina Martšenko

Re: Anybody working on tidspbridge?

2014-06-29 Thread Greg KH
On Fri, Jun 20, 2014 at 07:05:17PM +0300, Kristina Martšenko wrote: On 20/06/14 18:43, Kristina Martšenko wrote: Hi Omar, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving tidspbridge out of staging in over a year. Are

Re: [PATCH 1/3] staging: cxt1e1: Remove useless OS_phystov() and OS_vtophys()

2014-06-29 Thread Greg KH
On Fri, Jun 27, 2014 at 06:52:26PM +0900, Daeseok Youn wrote: OS_phystov()/OS_vtophys() are replaced with __va()/__pa(). No, you should use virt_to_phys() and phys_to_virt() instead of these internal macros which might not be correct for all architectures. thanks, greg k-h

Re: [PATCH 2/3] staging: cxt1e1: count fragmented packet properly.

2014-06-29 Thread Greg KH
On Fri, Jun 27, 2014 at 06:56:08PM +0900, Daeseok Youn wrote: OS_mem_token_tlen() is same return value as OS_mem_token_len(). That means packet count is always 1. So OS_mem_token_tlen() must be total length of packet and OS_mem_token_len() has a length of fragmented packet. And then it can

Re: [PATCH] Staging: bcm: Change TODO to include maintainers.

2014-06-30 Thread Greg KH
On Mon, Jun 30, 2014 at 04:30:26PM -0400, Kevin McKinney wrote: Add myself and Matthias Beyer to the TODO file as the list of maintainers. Signed-off-by: Kevin McKinney klmckinn...@gmail.com --- drivers/staging/bcm/TODO |4 1 file changed, 4 insertions(+) diff --git

Re: WiFi+BT AR5B22. When starting linux - BT disappears. Disappears at all.

2014-07-01 Thread Greg KH
On Tue, Jul 01, 2014 at 08:53:27AM +0300, Антон Мацюк wrote: I have a problem with my laptop wireless card in linux (I tried xubuntu and kali). Then I would recomment asking on your distro support group. If you are using a kernel.org released kernel, then we can help you. Well, we can't, the

Re: WiFi+BT AR5B22. When starting linux - BT disappears. Disappears at all.

2014-07-02 Thread Greg KH
On Wed, Jul 02, 2014 at 09:27:07AM +0300, Антон Мацюк wrote: May I ask that noobish question: is there a distro with kernel.org released kernel? Some distros provide vanilla kernel packages. I know Gentoo and openSUSE do, and I think Fedora also does. Check with your distro to see if they

Re: [Q] Removed cxt1e1 module in staging branch

2014-07-02 Thread Greg KH
On Thu, Jul 03, 2014 at 08:32:05AM +0900, DaeSeok Youn wrote: Hi, Kristina, Thanks for reply. I hadn't developed for specific driver(I'm beginner to develop Linux Kernel :-) ), so I can make patches for other drivers. I'd recommend picking another driver, hopefully one you can find the

[GIT PULL] Staging driver fixes for 3.16-rc4

2014-07-03 Thread Greg KH
The following changes since commit a497c3ba1d97fc69c1e78e7b96435ba8c2cb42ee: Linux 3.16-rc2 (2014-06-21 19:02:54 -1000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.16-rc4 for you to fetch changes up to

Re: Status of RMI4 drivers?

2014-07-05 Thread Greg KH
On Sat, Jul 05, 2014 at 04:37:37PM +0100, Alan Cox wrote: On Fri, 2014-07-04 at 21:48 +0300, Kristina Martšenko wrote: Hi, I'm going over some older drivers in the staging tree and wanted to ask about cptm1217 and ste_rmi4. They've been in staging for three and a half years now,

Re: [PATCH 2/2] staging: unisys: added virtpci info entry

2014-07-08 Thread Greg KH
On Tue, Jul 08, 2014 at 01:21:31PM -0400, Erik Arfvidson wrote: - + /*debug_fs file and direcroty removal*/ + debugfs_remove(info_debugfs_entry); + debugfs_remove(virtpci_debugfs_dir); Odd indentation, comment style, and spelling typos :( Also, you can just remove

Re: [PATCH] staging: binder: add vm_fault handler

2014-07-08 Thread Greg KH
On Mon, Jun 02, 2014 at 06:17:59PM +0530, Vinayak Menon wrote: An issue was observed when a userspace task exits. The page which hits error here is the zero page. In binder mmap, the whole of vma is not mapped. On a task crash, when debuggerd reads the binder regions, the unmapped areas fall

Re: [PATCH v2 00/10] staging: rtl8723au: Fix USB macro functions

2014-07-08 Thread Greg KH
On Tue, Jul 01, 2014 at 12:06:59PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Greg, Here is v2 of patch 08/10 Sanitize USB read/write functions it should fix the 'do not do DMA on the stack' issue with the original version. With this patch 09/10 is

Re: [PATCH 054/115] staging: ced1401: remove typedef for TRANSAREA

2014-07-08 Thread Greg KH
On Mon, Jun 30, 2014 at 12:00:46PM +0200, Luca Ellero wrote: Signed-off-by: Luca Ellero luca.ell...@brickedbrain.com --- drivers/staging/ced1401/ced_ioc.c | 21 - drivers/staging/ced1401/usb1401.c |9 ++--- drivers/staging/ced1401/usb1401.h |6 +++--- 3

Re: [PATCH v2 01/18] staging: comedi: ni_65xx: filter interval register is 32-bit

2014-07-08 Thread Greg KH
On Thu, Jun 26, 2014 at 12:05:07PM -0700, H Hartley Sweeten wrote: According to the register programming manual, the filter interval register is 32-bit. Fix the writes to this register. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk

Re: [PATCH 1/3 V2] staging: cxt1e1: Remove useless OS_phystov() and OS_vtophys()

2014-07-08 Thread Greg KH
On Mon, Jun 30, 2014 at 03:56:11PM +0900, Daeseok Youn wrote: OS_phystov()/OS_vtophys() are replaced with phys_to_virt()/virt_to_phys(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- V2: use virt_to_phys()/phys_to_virt() instead of __pa()/__va(). drivers/staging/cxt1e1/musycc.c

Re: [PATCH v3 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-08 Thread Greg KH
On Tue, Jul 08, 2014 at 11:38:30PM +0200, Fabio Falzoi wrote: Use print_hex_dump_bytes to have memory properly dumped only when DEBUG is defined. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com --- drivers/staging/rts5208/ms.c| 4 ++-- drivers/staging/rts5208/rtsx_chip.c |

Re: [PATCH v3 1/4] Staging: rts5208: Replace custom macro with pr_debug

2014-07-08 Thread Greg KH
On Tue, Jul 08, 2014 at 11:38:29PM +0200, Fabio Falzoi wrote: Use pr_debug macro to control tracing verbosity through dynamic debug facility. For almost all of these, you should use dev_dbg() instead, as you have access to a struct device (well, you should have, you might have to dig for

Re: [PATCH v2 1/1] staging: lustre: libcfs: nidstrings.c - use ARRAY_SIZE macro

2014-07-08 Thread Greg KH
On Wed, Jul 02, 2014 at 04:23:55PM +0530, Anil Belur wrote: From: Anil Belur ask...@gmail.com - this patch replaces sizeof(a)/sizeof(a[0]) with the ARRAY_SIZE macro to get the number of nidstrings (and netstrfns) - v2: also for netstrfns Signed-off-by: Anil Belur ask...@gmail.com

Re: [PATCH 1/1] staging: speakup: main.c - use time_after()

2014-07-08 Thread Greg KH
On Tue, Jul 01, 2014 at 12:30:22PM +0530, Anil Belur wrote: From: Anil Belur ask...@gmail.com - this patch fixes jiffies comparision with a safer function to prevent any overflows Signed-off-by: Anil Belur ask...@gmail.com --- drivers/staging/speakup/main.c | 2 +- 1 file changed, 1

Re: Asus TX201LA Driver for rtl8821ae

2014-07-08 Thread Greg KH
On Wed, Jul 09, 2014 at 02:34:12AM +0200, Mario wrote: linux-next.git-v3.14-drivers-staging rtl8821ae in conjunction with their linux-firmware-4c7327a35767c2133600376380c867dff3cbaa1c-rtlwifi It went wonderfully with uname-r (3.14.3-200.fc20.x86_64). Today, however, came update

Re: [PATCH 1/1] staging: speakup: main.c - use time_after()

2014-07-08 Thread Greg KH
On Wed, Jul 09, 2014 at 09:57:06AM +0530, Anil Shashikumar Belur wrote: On Wednesday 09 July 2014 05:21 AM, Greg KH wrote: This change is already in my tree, what branch are you working against? greg k-h Hi Greg, I am using staging.git. I try to make sure and rebase any changes in my

Re: [PATCH v3 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes

2014-07-08 Thread Greg KH
On Tue, Jul 08, 2014 at 06:48:18PM -0700, Joe Perches wrote: On Tue, 2014-07-08 at 16:45 -0700, Greg KH wrote: On Tue, Jul 08, 2014 at 11:38:30PM +0200, Fabio Falzoi wrote: Use print_hex_dump_bytes to have memory properly dumped only when DEBUG is defined. [] diff --git a/drivers

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-09 Thread Greg KH
On Tue, Jul 01, 2014 at 02:00:15PM +0100, Michalis Pappas wrote: Signed-off-by: Michalis Pappas mpap...@fastmail.fm --- drivers/staging/gdm72xx/gdm_qos.c | 2 ++ drivers/staging/gdm72xx/gdm_sdio.c | 7 +++ drivers/staging/gdm72xx/gdm_usb.c | 7 +++

Re: [PATCH] staging: gdm72xx: reorder functions and remove function declarations

2014-07-09 Thread Greg KH
On Thu, Jul 03, 2014 at 06:45:03PM +0100, Michalis Pappas wrote: Signed-off-by: Michalis Pappas mpap...@fastmail.fm --- drivers/staging/gdm72xx/gdm_sdio.c | 77 drivers/staging/gdm72xx/gdm_usb.c | 87 +- drivers/staging/gdm72xx/gdm_wimax.c | 179

Re: [PATCH v3] staging: gdm72xx: move T_CAPABILITY definitions to hci.h

2014-07-09 Thread Greg KH
On Wed, Jul 09, 2014 at 07:31:22PM +0100, Michalis Pappas wrote: Signed-off-by: Michalis Pappas mpap...@fastmail.fm --- drivers/staging/gdm72xx/gdm_wimax.c | 11 +++ drivers/staging/gdm72xx/hci.h | 6 ++ 2 files changed, 9 insertions(+), 8 deletions(-) This no longer

Re: [PATCH] staging: dgap: removes redundant null check and change paramter for dgap_maxcps_room()

2014-07-09 Thread Greg KH
On Mon, Jul 07, 2014 at 10:27:54AM +0900, Daeseok Youn wrote: Null checks for tty, un and ch are already done by caller, so replace parameter tty with ch and un. And also use a pointer for returning new bytes_available instead of return variable. Why make that change? It's nicer to return

Re: [PATCH 1/5] staging: rtl8188eu: Remove WEXT_PRIV private ioctl handlers

2014-07-09 Thread Greg KH
On Tue, Jul 01, 2014 at 10:35:09PM +0530, navin patidar wrote: Remove WEXT_PRIV (non-standard) ioctl handlers. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 6335 +++- 1 file changed, 744 insertions(+), 5591

Re: [PATCH 01/48] staging: rtl8188eu: Remove struct evt_priv and its uses

2014-07-09 Thread Greg KH
On Wed, Jul 02, 2014 at 10:16:57PM +0530, navin patidar wrote: c2h_wk (work_struct) is naver scheduled to handle events, so no use of keeping event data. And also function rtw_hal_c2h_handler() responsible for handling c2h events, is a dummy function. Signed-off-by: navin patidar

Re: [PATCH next-20140704]: staging/rtl8821ae/base.c: sparse warning corrections

2014-07-09 Thread Greg KH
On Sun, Jul 06, 2014 at 12:01:11PM +0300, Sami Laine wrote: From: Sami Laine laine.j.s...@gmail.com Sparse warning corrections for: drivers/staging/rtl8821ae/base.c:1370:16: warning: symbol 'rtl_make_smps_action' was not declared. Should it be static?

Re: [PATCH next-20140704]: staging/rtl8821ae/debug.c: sparse warning correction

2014-07-09 Thread Greg KH
On Sun, Jul 06, 2014 at 12:05:53PM +0300, Sami Laine wrote: From: Sami Laine laine.j.s...@gmail.com Sparse warning correction: vers/staging/rtl8821ae/debug.c:80:23: warning: symbol 'proc_topdir' was not declared. Should it be static? Signed-off-by: Sami Laine laine.j.s...@gmail.com ---

Re: [PATCH v3 1/4] staging: rtl8192u: Remove useless return statements.

2014-07-09 Thread Greg KH
On Wed, Jul 09, 2014 at 05:49:39PM +0530, sanjeev sharma wrote: From: sanjeev sharma sanjeev_sha...@mentor.com No S characters? And your 0/4 Subject: was really odd, please fix up and resend all of these. greg k-h ___ devel mailing list

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-09 Thread Greg KH
On Wed, Jul 09, 2014 at 08:52:07PM +0100, Michalis Pappas wrote: On 07/09/2014 07:51 PM, Greg KH wrote: On Tue, Jul 01, 2014 at 02:00:15PM +0100, Michalis Pappas wrote: Signed-off-by: Michalis Pappas mpap...@fastmail.fm --- drivers/staging/gdm72xx/gdm_qos.c | 2 ++ drivers/staging

Re: [PATCH 2/2] staging: unisys: added virtpci info entry

2014-07-09 Thread Greg KH
On Wed, Jul 09, 2014 at 04:22:43PM -0400, Erik Arfvidson wrote: This patch adds the virtpci debugfs directory and the info entry inside of it. Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/virtpci/virtpci.c | 123 ++- 1

Re: [PATCH 2/2] staging: unisys: added virtpci info entry

2014-07-09 Thread Greg KH
On Wed, Jul 09, 2014 at 04:22:43PM -0400, Erik Arfvidson wrote: @@ -1426,7 +1537,10 @@ static int __init virtpci_mod_init(void) LOGINF(successfully registered virtpci_ctrlchan_func (0x%p) as callback.\n, (void *) virtpci_ctrlchan_func); - + /*create debugfs

Re: [PATCH 1/5] staging: rtl8188eu: Remove WEXT_PRIV private ioctl handlers

2014-07-09 Thread Greg KH
On Thu, Jul 10, 2014 at 06:24:21AM +0530, navin patidar wrote: On Thu, Jul 10, 2014 at 12:34 AM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Jul 01, 2014 at 10:35:09PM +0530, navin patidar wrote: Remove WEXT_PRIV (non-standard) ioctl handlers. Signed-off-by: navin patidar navin.pati

Re: [PATCH 1/5] staging: rtl8188eu: Remove WEXT_PRIV private ioctl handlers

2014-07-09 Thread Greg KH
On Thu, Jul 10, 2014 at 06:56:39AM +0530, navin patidar wrote: On Thu, Jul 10, 2014 at 6:29 AM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Jul 10, 2014 at 06:24:21AM +0530, navin patidar wrote: On Thu, Jul 10, 2014 at 12:34 AM, Greg KH gre...@linuxfoundation.org wrote: On Tue

Re: [PATCH 2/2] staging: unisys: added virtpci info entry

2014-07-10 Thread Greg KH
On Thu, Jul 10, 2014 at 10:34:14AM -0400, Erik Arfvidson wrote: This patch adds the virtpci debugfs directory and the info entry inside of it. Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com 2/2? Where is patch 1/2? Please

Re: Anybody working on tidspbridge?

2014-07-10 Thread Greg KH
On Thu, Jul 10, 2014 at 08:54:18AM +0300, Ivaylo Dimitrov wrote: On 9.07.2014 10:07, Tony Lindgren wrote: * Suman Anna s-a...@ti.com [140708 11:40]: Hi Peter, On 07/08/2014 09:36 AM, Greg KH wrote: On Tue, Jul 08, 2014 at 03:03:58PM +0200, Peter Meerwald wrote: Hello, Given

Re: [PATCH] staging: unisys: added virtpci info entry

2014-07-10 Thread Greg KH
On Thu, Jul 10, 2014 at 02:45:12PM -0400, Erik Arfvidson wrote: This patch adds the virtpci debugfs directory and the info entry inside of it. Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/virtpci/virtpci.c | 123 ++- 1

Re: [PATCH v2 58/60] staging: ced1401: usb1401.h fix checkpatch errors

2014-07-10 Thread Greg KH
On Thu, Jul 10, 2014 at 11:04:14AM +0200, Luca Ellero wrote: Signed-off-by: Luca Ellero luca.ell...@brickedbrain.com Again, which one? ___ devel mailing list de...@linuxdriverproject.org

<    1   2   3   4   5   6   7   8   9   10   >