Re: [PATCH] Staging: unisys: virthba: Add dependency on SCSI

2014-03-06 Thread Greg KH
On Thu, Mar 06, 2014 at 12:57:00PM -0600, Ken Cox wrote: If CONFIG_SCSI is not enabled, compiling virthba.c goes horribly wrong with undefined symbols. Signed-off-by: Ken Cox j...@redhat.com --- You forgot a Reported-by: line saying how you found out about this issue...

Re: [PATCH 1/2] lustre/mdc_lib: fix possible null pointer dereference

2014-03-06 Thread Greg KH
On Wed, Mar 05, 2014 at 09:53:06PM +0300, Dan Carpenter wrote: On Wed, Mar 05, 2014 at 02:04:35PM +0100, Maxin B. John wrote: From: Maxin B. John maxin.j...@enea.com cppcheck reported possible null pointer dereference in mdc_lib.c [lustre/lustre/mdc/mdc_lib.c:233]: (error) Possible

Re: [PATCH 2/2] lustre/lov_obd: fix possible null pointer dereference

2014-03-06 Thread Greg KH
On Wed, Mar 05, 2014 at 02:04:36PM +0100, Maxin B. John wrote: From: Maxin B. John maxin.j...@enea.com osc_obd can be NULL. cppcheck reported this: [lustre/lustre/lov/lov_obd.c:283]: (error) Possible null pointer dereference: osc_obd - otherwise it is redundant to check if osc_obd is null at

Re: [firefly] [PATCH 06/12] staging: usbip: userspace: add new list API

2014-03-06 Thread Greg KH
On Thu, Mar 06, 2014 at 07:45:27AM +0200, Valentina Manea wrote: On Wed, Mar 5, 2014 at 12:16 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Mar 04, 2014 at 10:35:39PM -0800, Greg KH wrote: On Tue, Mar 04, 2014 at 09:10:46PM +0200, Valentina Manea wrote: Add

Re: [PATCH 4/7 v3] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

2014-03-06 Thread Greg KH
On Wed, Mar 05, 2014 at 10:21:01AM +0900, Daeseok Youn wrote: checkpatch.pl error in linux.c: ERROR: do not use assignment in if condition Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/linux.c | 31 +++ 1 files changed, 19

Re: [PATCH v2 7/7] staging: cxt1e1: remove unneeded a value

2014-03-06 Thread Greg KH
On Thu, Mar 06, 2014 at 05:12:48PM +0900, Daeseok Youn wrote: It doesn't need to assign name array address to np pointer. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- v2: replace sprintf() with snprintf() and remove memset() call because snprintf() adds a terminating '\0' Your

Re: staging: virthba driver to access shared SCSI hba

2014-03-06 Thread Greg KH
On Fri, Mar 07, 2014 at 12:11:10AM +0300, Dan Carpenter wrote: Hello Ken Cox, The patch dc95086172db: staging: virthba driver to access shared SCSI hba from Mar 4, 2014, leads to the following Sparse warning: drivers/staging/unisys/virthba/virthba.c:1442:24: warning: Variable

Re: staging: visorchannel module

2014-03-07 Thread Greg KH
On Fri, Mar 07, 2014 at 11:38:03AM +0300, Dan Carpenter wrote: Hello Ken Cox, The patch e423812a9e43: staging: visorchannel module from Mar 4, 2014, leads to the following Smatch warning: drivers/staging/unisys/include/guidutils.h:60 GUID_format2() error: format string

Re: [PATCH RFC] staging: dgap: more 80+ char lines work

2014-03-07 Thread Greg KH
On Fri, Mar 07, 2014 at 04:57:50PM -0500, Mark Hounschell wrote: This is just for comments. The indentation was alread so far over 80 chars I (as recommended earlier) make a couple of new functions. Somehow I don't think this is proper and there is probably a better way to do this. This is

Re: Updated: [PATCH] Staging: comedi: Fix 80-char line limit style issue in addi_apci_1500.c

2014-03-08 Thread Greg KH
On Sat, Mar 08, 2014 at 03:47:24PM -0500, Conrad Meyer wrote: Rename some very long functions in addi-data/hwdrv_apci1500.c. Signed-off-by: Conrad Meyer cse@gmail.com When you update a patch, it's better to have the subject be: [PATCH v2] Staging: Otherwise what are you

Re: [PATCH v3 1/2] Staging: comedi: convert while loops to timeouts in

2014-03-08 Thread Greg KH
On Fri, Mar 07, 2014 at 07:43:04PM -0600, Chase Southwood wrote: This patch changes a handful of while loops to timeouts to prevent infinite looping on hardware failure. A couple such loops are in a function (s626_debi_transfer()) which is called from critical sections, so comedi_timeout() is

Re: [PATCH] Staging: comedi: comedidev.h Fixed whitespace coding style warnings

2014-03-08 Thread Greg KH
On Sun, Mar 09, 2014 at 11:45:51AM +1100, Nick Davies wrote: Fixed coding style warnings in comedidev.h which had an extra space after the function pointer name. Signed-off-by: Nick Davies g...@nicolasdavies.com.au --- drivers/staging/comedi/comedidev.h | 48

Re: [PATCH 3/4] staging: cxtie1: remove unneeded mkret() calls

2014-03-08 Thread Greg KH
On Fri, Mar 07, 2014 at 09:03:04AM +0900, Daeseok Youn wrote: The mkret() change a value of error from positive to negative. This patch is modified to return negative value when it failed. It doesn't need to call with function for changing from positive to negative. Signed-off-by: Daeseok

Re: [PATCH 00/18] Resend of usbip-utils migration patches and various other fixes

2014-03-08 Thread Greg KH
On Sat, Mar 08, 2014 at 02:53:18PM +0200, Valentina Manea wrote: This is a resend of the patches sent a few days ago, including the migration of USB/IP userspace side to use libudev instead of libsysfs and various other fixes, all ordered in a big patch series. Very nice work, thanks so much

Re: [PATCH 00/18] Resend of usbip-utils migration patches and various other fixes

2014-03-09 Thread Greg KH
On Sun, Mar 09, 2014 at 05:53:51PM +0200, Valentina Manea wrote: I was notified that one of the patches in the series (staging: usbip: claim ports used by shared devices) breaks the build. I take full responsability for this as I haven't compiled the kernel with allyesconfig and I am sorry.

Re: Treewide frequency of various checkpatch messages

2014-03-10 Thread Greg KH
On Mon, Mar 10, 2014 at 09:02:26AM -0700, Joe Perches wrote: On Fri, 2014-03-07 at 01:30 -0800, Joe Perches wrote: On Fri, 2014-03-07 at 10:54 +0300, Dan Carpenter wrote: (a question about a new message warning of a missing blank line between variable declaration blocks and code in a

Re: [PATCH 2/2] staging: dgap: Fixed sparse error: same symbol redeclared with different type

2014-03-10 Thread Greg KH
On Sat, Mar 08, 2014 at 11:18:42PM -0800, Masood Mehmood wrote: sparse reported dgap_do_fep_load is redeclared with different type. while fixing, I noticed __user attribute is used incorrectly in declaration. There is no need to define __user for firware-data. Replaced the __user with 'const

Re: Treewide frequency of various checkpatch messages

2014-03-10 Thread Greg KH
On Mon, Mar 10, 2014 at 11:48:50AM -0700, Joe Perches wrote: On Mon, 2014-03-10 at 09:50 -0700, Greg KH wrote: On Mon, Mar 10, 2014 at 09:02:26AM -0700, Joe Perches wrote: On Fri, 2014-03-07 at 01:30 -0800, Joe Perches wrote: On Fri, 2014-03-07 at 10:54 +0300, Dan Carpenter wrote

Re: [PATCH 2/2] staging: dgap: Fixed sparse error: same symbol redeclared with different type

2014-03-10 Thread Greg KH
On Sun, Mar 09, 2014 at 12:33:32AM -0800, Masood Mehmood wrote: On Mon, Mar 10, 2014 at 11:37:12AM -0700, Greg KH wrote: On Sat, Mar 08, 2014 at 11:18:42PM -0800, Masood Mehmood wrote: 1 file changed, 6 insertions(+), 7 deletions(-) I don't see a patch 1/2 here, did you forget to send

Re: [PATCH] Staging: lustre: fld: moved EXPORT_SYMBOL() for a fix.

2014-03-12 Thread Greg KH
On Thu, Mar 13, 2014 at 12:04:18AM -0400, Gary Rookard wrote: I moved EXPORT_SYMBOL(fld_client_proc_fini); for a warning fix. What is the warning? ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: android: fix coding style

2014-03-14 Thread Greg KH
On Thu, Mar 13, 2014 at 03:13:04PM +0100, mourn wrote: The changes look good, however you should be a bit more specific about what the fixes are, and that you used checkpatch.pl to find them (I assume). Yes, you are right. I can edit the commit log. Also, Signed-off-by: should

Re: [PATCH] staging: android: fix coding style

2014-03-14 Thread Greg KH
On Thu, Mar 13, 2014 at 10:44:55AM +0100, mo...@2600fr.org wrote: From: mourn mo...@2600fr.org Signed-off-by: mourn mo...@2600fr.org As said in the thread for your other thread, this patch can't be accepted unless you use your real name, sorry. greg k-h

Re: git not pulling origin staging-next cleanly.

2014-03-14 Thread Greg KH
On Wed, Mar 12, 2014 at 04:10:36PM -0400, Gary Rookard wrote: Hi, Could this problem be local machine (git-1.9.0-1) or dare I say it, a tmp server-side melt-down of sorts? I've tried everything nothing seams to work. What have you typed, exactly, and what has git responded with?

Re: git not pulling origin staging-next cleanly.

2014-03-14 Thread Greg KH
On Fri, Mar 14, 2014 at 09:51:30PM -0400, Gary Rookard wrote: On Sat, 15 Mar 2014, Greg KH wrote: On Wed, Mar 12, 2014 at 04:10:36PM -0400, Gary Rookard wrote: Hi, Could this problem be local machine (git-1.9.0-1) or dare I say it, a tmp server-side melt-down of sorts? I've tried

Re: git not pulling origin staging-next cleanly.

2014-03-15 Thread Greg KH
On Sat, Mar 15, 2014 at 02:13:45AM -0400, Gary Rookard wrote: On Sat, 15 Mar 2014, Greg KH wrote: On Fri, Mar 14, 2014 at 09:51:30PM -0400, Gary Rookard wrote: On Sat, 15 Mar 2014, Greg KH wrote: On Wed, Mar 12, 2014 at 04:10:36PM -0400, Gary Rookard wrote: Hi, Could

Re: [PATCH] Staging: bcm: CmHost: added breaks and /* FALLTHROUGH */ to switch/case.

2014-03-17 Thread Greg KH
On Sun, Mar 16, 2014 at 03:31:18PM -0400, Gary Rookard wrote: I added a couple of breaks, and a /* FALLTHROUGH */ comment to switch/case assuming that is the actual desired effect needed by the case label. Signed-off-by: Gary Alan Rookard garyrook...@gmail.com --- On branch staging-next

Re: [PATCH] Staging: bcm:CmHost: removed extra parenthesis.

2014-03-17 Thread Greg KH
On Sun, Mar 16, 2014 at 03:59:53PM -0400, Gary Rookard wrote: I removed some useless extra parenthesis. Signed-off-by: Gary Alan Rookard garyrook...@gmail.com --- On branch staging-next drivers/staging/bcm/CmHost.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 2/2] staging: comedi: poc: remove obsolete driver

2014-03-17 Thread Greg KH
On Tue, Mar 11, 2014 at 12:04:18PM -0700, H Hartley Sweeten wrote: From: H Hartley Sweeten hartl...@visionengravers.com The DAC02 board, which is the only board supported by this driver, now has its own comedi driver (dac02). Remove this obsolete driver. Signed-off-by: H Hartley Sweeten

Re: [PATCH 1/2] staging: cxtie1: remove unneeded mkret() calls

2014-03-17 Thread Greg KH
On Mon, Mar 10, 2014 at 08:54:18AM +0900, Daeseok Youn wrote: The mkret() change a value of error from positive to negative. This patch is modified to return negative value when it failed. It doesn't need to call with function for changing from positive to negative. Signed-off-by: Daeseok

Re: [PATCH 3/3] Staging: lustre: fld: moved EXPORT_SYMBOL() for a fix.

2014-03-17 Thread Greg KH
On Thu, Mar 13, 2014 at 08:58:09PM -0400, Gary Rookard wrote: I moved EXPORT_SYMBOL(fld_client_proc_fini); for a EXPORT_SYMBOL should be immediately below its function warning fix. Signed-off-by: Gary Alan Rookard garyrook...@gmail.com --- Correct patch, first two breaks build. Patch

Re: [PATCH] staging: dgap: Fixed sparse error: same symbol redeclared with different type

2014-03-17 Thread Greg KH
On Sun, Mar 09, 2014 at 12:57:35AM -0800, Masood Mehmood wrote: sparse reported dgap_do_fep_load is redeclared with different type. while fixing, I noticed __user attribute is used incorrectly in declaration. There is no need to define __user for firware-data. Replaced the __user with 'const

Re: [PATCH] staging: dgap: Fixed sparse error: same symbol redeclared with different type

2014-03-17 Thread Greg KH
On Wed, Mar 12, 2014 at 08:55:44PM -0700, Masood Mehmood wrote: sparse reported dgap_do_fep_load is redeclared with different type. while fixing, I noticed __user attribute is used incorrectly in declaration. There is no need to define __user for firware-data. Replaced the __user with 'const

Re: [PATCH] [staging][r8188eu]: memory leak in rtw_free_cmd_obj if command is (_Set_Drv_Extra)

2014-03-17 Thread Greg KH
On Mon, Mar 10, 2014 at 11:37:44AM -0400, Wang, Xiaoming wrote: pcmd-parmbuf-pbuf has been allocated if command is GEN_CMD_CODE(_Set_Drv_Extra), and it enqueued by rtw_enqueue_cmd. rtw_cmd_thread dequeue pcmd by rtw_dequeue_cmd. The memory leak happened on this branch if( _FAIL ==

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

2014-03-17 Thread Greg KH
On Wed, Mar 12, 2014 at 07:37:50PM +0900, Daeseok Youn wrote: Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/unisys/uislib/uislib.c |5 + drivers/staging/unisys/uislib/uisutils.c |2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git

Re: [RFC PATCH 03/22] staging: crypto: skein: allow building statically

2014-03-17 Thread Greg KH
On Tue, Mar 11, 2014 at 09:32:35PM +, Jason Cooper wrote: These are the minimum changes required to get the code to build statically in the kernel. It's necessary to do this first so that we can empirically determine that future cleanup patches aren't changing the generated object code.

Re: [PATCH 2/2] staging: comedi: poc: remove obsolete driver

2014-03-17 Thread Greg KH
On Mon, Mar 17, 2014 at 10:12:01PM +, Hartley Sweeten wrote: On Monday, March 17, 2014 2:14 PM, Greg KH wrote: On Tue, Mar 11, 2014 at 12:04:18PM -0700, H Hartley Sweeten wrote: From: H Hartley Sweeten hartl...@visionengravers.com The DAC02 board, which is the only board supported

Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations and tmp bracing.

2014-03-17 Thread Greg KH
On Mon, Mar 17, 2014 at 06:01:24PM -0400, Gary Rookard wrote: Firstly, some background is needed to confirm the validity of this patch as error fixing. It seems the developer when writing this driver from scratch, used what are known to me as error suppressors in the form of extra tmp bracing

USB, TTY, char/misc, and Staging trees now closed for 3.15

2014-03-17 Thread Greg KH
Hi all, Given that 3.14 will be out in a few days, it's time to close my trees for new patches until 3.15-rc1 is out. Please feel free to send me patches for these trees, but note that I'll be ignoring them until 3.15-rc1 is out, at which point in time I'll start reviewing them again and

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

2014-03-17 Thread Greg KH
On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote: I think vmalloc/kmalloc in uislib_malloc() can be removed and just use vmalloc/kmalloc directly. Yes. Actually, just use kmalloc, I don't knwo why vmalloc is being used, but cc: the driver maintainers just to be sure. (UISMALLOC()

Re: [RFC PATCH 03/22] staging: crypto: skein: allow building statically

2014-03-18 Thread Greg KH
On Tue, Mar 18, 2014 at 08:58:49AM -0400, Jason Cooper wrote: On Mon, Mar 17, 2014 at 02:52:52PM -0700, Greg KH wrote: On Tue, Mar 11, 2014 at 09:32:35PM +, Jason Cooper wrote: These are the minimum changes required to get the code to build statically in the kernel. It's necessary

Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations and tmp bracing.

2014-03-18 Thread Greg KH
On Mon, Mar 17, 2014 at 08:21:34PM -0400, Gary Rookard wrote: Firstly, some background is needed to confirm the validity of this patch as error fixing. It seems the developer when writing this driver from scratch, used what are known to me as error suppressors in the form of extra tmp bracing

Re: [PATCH] staging: r8188eu: memory leak in rtw_free_cmd_obj if command is (_Set_Drv_Extra)

2014-03-18 Thread Greg KH
On Tue, Mar 18, 2014 at 10:25:27AM -0400, Wang, Xiaoming wrote: pcmd-parmbuf-pbuf has been allocated if command is GEN_CMD_CODE(_Set_Drv_Extra), and it enqueued by rtw_enqueue_cmd. rtw_cmd_thread dequeue pcmd by rtw_dequeue_cmd. The memory leak happened on this branch if( _FAIL ==

Re: [PATCH] staging: dgap: Fixed sparse error: same symbol redeclared with different type

2014-03-18 Thread Greg KH
On Thu, Mar 13, 2014 at 03:02:59AM -0700, Masood Mehmood wrote: sparse reported dgap_do_fep_load is redeclared with different type. while fixing, I noticed __user attribute is used incorrectly in declaration. There is no need to define __user for firware-data. Replaced the __user with 'const

Re: [PATCH] staging: cxt1e1: hwprobe: Fix sparse warning

2014-03-18 Thread Greg KH
On Wed, Mar 19, 2014 at 12:33:19AM +0200, Matei Oprea wrote: This fixes the following sparse warning: * drivers/staging/cxt1e1/hwprobe.c:43:19: warning: symbol 'hdw_info' was not declared. Should it be static? * drivers/staging/cxt1e1/hwprobe.c:47:1: warning: symbol 'show_two' was not

Re: [PATCH] staging: cxt1e1: hwprobe: Fix sparse warning

2014-03-18 Thread Greg KH
On Wed, Mar 19, 2014 at 12:33:19AM +0200, Matei Oprea wrote: This fixes the following sparse warning: * drivers/staging/cxt1e1/hwprobe.c:43:19: warning: symbol 'hdw_info' was not declared. Should it be static? * drivers/staging/cxt1e1/hwprobe.c:47:1: warning: symbol 'show_two' was not

Re: [PATCH] staging: cxt1e1: hwprobe: Fix sparse warning

2014-03-18 Thread Greg KH
On Wed, Mar 19, 2014 at 12:33:19AM +0200, Matei Oprea wrote: This fixes the following sparse warning: * drivers/staging/cxt1e1/hwprobe.c:43:19: warning: symbol 'hdw_info' was not declared. Should it be static? * drivers/staging/cxt1e1/hwprobe.c:47:1: warning: symbol 'show_two' was not

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

2014-03-18 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Mar 19, 2014 at 09:09:59AM +0900, DaeSeok Youn wrote: Hi, Ken Thanks for review. But I have a question, I wan to know why tracing buffer status(Malloc_FailuresAlloc,

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

2014-03-18 Thread Greg KH
On Wed, Mar 19, 2014 at 09:03:49AM +0900, DaeSeok Youn wrote: Hi, greg. Review my comment below. What comment? confused, greg k-h- ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: wlags49_h2: Coding style correction

2014-03-18 Thread Greg KH
On Wed, Mar 19, 2014 at 01:52:09AM +0100, Mathieu Maret wrote: As the file was mixing tab and space, reindent the file Mainly correct use of C99 comments, space between parenthesis, remove commented code Signed-off-by: Mathieu Maret mathieu.ma...@gmail.com ---

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

2014-03-18 Thread Greg KH
On Wed, Mar 19, 2014 at 10:04:40AM +0900, DaeSeok Youn wrote: oh... You didn't get my reply about vmalloc usage. My replay attach again, below. 2014-03-18 9:37 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote: I think vmalloc

Re: [PATCH] STAGING: comedi: title block update

2014-03-18 Thread Greg KH
On Tue, Mar 18, 2014 at 11:24:31PM -0500, michael wrote: Follow up patch for STAGING: comedi: style and checkpatch fixes. Removes the file name in the comment block per suggestions. Signed-off-by: Michael Welling mwell...@ieee.org Minor problem for future patches, your From: line doesn't

Re: [PATCH] staging: unisys: replace kzalloc/kfree with UISMALLOC/UISFREE

2014-03-19 Thread Greg KH
On Wed, Mar 19, 2014 at 04:58:52PM +0900, Daeseok Youn wrote: It doesn't need to trace status of buffer when buffers are allocated/deallocated. So stuff of tracing memory status are removed. And also UISMALLOC/UISFREE macro are removed completetly. just use kzalloc/kfree. Signed-off-by:

Re: [PATCH 4/5] staging: wlags49_h2: Correct macro style in wl_netdev.c

2014-03-19 Thread Greg KH
On Wed, Mar 19, 2014 at 09:20:34AM +0100, Mathieu Maret wrote: Multi statement macro should use do{}while(0) Signed-off-by: Mathieu Maret mathieu.ma...@gmail.com --- drivers/staging/wlags49_h2/wl_netdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 4/5] staging: wlags49_h2: Correct macro style in wl_netdev.c

2014-03-19 Thread Greg KH
On Wed, Mar 19, 2014 at 05:42:43PM +0100, Mathieu Maret wrote: Le 19 mars 2014 16:34, Greg KH gre...@linuxfoundation.org a écrit : On Wed, Mar 19, 2014 at 09:20:34AM +0100, Mathieu Maret wrote: Multi statement macro should use do{}while(0) Signed-off-by: Mathieu Maret mathieu.ma

Re: [PATCH 2/2] staging: comedi: poc: remove obsolete driver

2014-03-19 Thread Greg KH
On Wed, Mar 19, 2014 at 11:26:04PM +, Hartley Sweeten wrote: On Monday, March 17, 2014 2:14 PM, Greg KH wrote: On Tue, Mar 11, 2014 at 12:04:18PM -0700, H Hartley Sweeten wrote: From: H Hartley Sweeten hartl...@visionengravers.com The DAC02 board, which is the only board supported

Re: [PATCH] Staging: bcm: DDRInit: moved #defines from DDRInit.c to DDRInit.h

2014-03-19 Thread Greg KH
On Wed, Mar 19, 2014 at 05:30:53PM -0400, Gary Rookard wrote: I moved the #defines from implementation file DDRInit.c to the proper specification file DDRInit.h. Signed-off-by: Gary Alan Rookard garyrook...@gmail.com --- On branch staging-next drivers/staging/bcm/DDRInit.c | 15

Re: [PATCHv2 4/5] staging: wlags49_h2: Correct macro style in wl_netdev.c

2014-03-19 Thread Greg KH
On Wed, Mar 19, 2014 at 11:56:14PM +0100, Mathieu Maret wrote: Multi statement macro should use do{}while(0) patch v2 does not break compilation --- drivers/staging/wlags49_h2/wl_netdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] Staging: bcm: DDRInit: moved #defines from DDRInit.c to DDRInit.h

2014-03-19 Thread Greg KH
On Wed, Mar 19, 2014 at 10:29:42PM -0400, Gary Rookard wrote: On Thu, 20 Mar 2014, Greg KH wrote: On Wed, Mar 19, 2014 at 05:30:53PM -0400, Gary Rookard wrote: I moved the #defines from implementation file DDRInit.c to the proper specification file DDRInit.h. Signed-off-by: Gary

Re: [PATCH] staging: cxt1e1: replace kmalloc/kfree with OS_kmalloc/OS_kfree

2014-03-20 Thread Greg KH
On Fri, Mar 21, 2014 at 10:41:39AM +0900, Daeseok Youn wrote: Replace kmalloc/kfree with OS_kmalloc/OS_kfree. I think you mean this the other way around, right? ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH v2] staging: cxt1e1: replace OS_kmalloc/OS_kfree with kmalloc/kfree

2014-03-20 Thread Greg KH
On Fri, Mar 21, 2014 at 01:15:23PM +0900, Daeseok Youn wrote: Replace OS_kmalloc/OS_kfree with kmalloc/kfree. You should replace it with kzalloc, not kmalloc, as OS_kmalloc() zeroed out the allocated data: -static inline void * -OS_kmalloc (size_t size) -{ -char *ptr = kmalloc

Re: [PATCH] staging/usbip: fix store_attach() sscanf return value check

2014-03-24 Thread Greg KH
On Mon, Mar 24, 2014 at 05:12:09PM -0600, Shuah Khan wrote: Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7 What do you mean by this line? This commit added return value check for sscanf() that parses the input buffer for four input items. However, the return value check is incorrect,

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-03-25 Thread Greg KH
On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrote: Fixes code style errors in drivers/staging/bcm/Qos.c Patch submitted as part of the Eudyptula Challenge. Signed-off-by: Marcos A. Di Pietro marcos...@gmail.com --- drivers/staging/bcm/Qos.c | 13 - 1 file

Re: [PATCH] staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls

2014-03-25 Thread Greg KH
On Tue, Mar 25, 2014 at 05:59:39PM +, Wilfried Klaebe wrote: staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls It looks like someone did a search-and-replace on that driver, putting spaces before = characters, without checking this is OK everywhere. Also, in some

Re: [PATCH] staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls

2014-03-25 Thread Greg KH
On Tue, Mar 25, 2014 at 06:36:18PM +, Wilfried Klaebe wrote: Am Tue, Mar 25, 2014 at 11:17:49AM -0700 schrieb Greg KH: On Tue, Mar 25, 2014 at 05:59:39PM +, Wilfried Klaebe wrote: staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls It looks like someone did

Re: [PATCH] staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls

2014-03-25 Thread Greg KH
On Tue, Mar 25, 2014 at 07:04:34PM +, Wilfried Klaebe wrote: Am Tue, Mar 25, 2014 at 11:51:45AM -0700 schrieb Greg KH: On Tue, Mar 25, 2014 at 06:36:18PM +, Wilfried Klaebe wrote: Am Tue, Mar 25, 2014 at 11:17:49AM -0700 schrieb Greg KH: On Tue, Mar 25, 2014 at 05:59:39PM +

Re: [PATCH net-next, v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-25 Thread Greg KH
on the networking side (the VRSS patches are currently under review), it will be useful to have per-channel state that vmbus drivers can manage. Add support for managing per-channel state. KY: Do you know the original tree this patch was checked into by Greg KH? Or, did Greg checked into linux-next

Re: [PATCH] staging: silicom: hide conditionally used function in condition

2014-03-26 Thread Greg KH
On Wed, Mar 26, 2014 at 02:58:50PM +0900, SeongJae Park wrote: bp_proc_create() be called only when BP_PROC_SUPPORT defined but its definition live outside of #ifdef BP_PROC_SUPPORT and cause following trivial build warning: drivers/staging/silicom/bpctl_mod.c:6786:12: warning:

Re: [PATCH 1/3] staging: vt6655: fix DBG_PRT and PRINT_K macros

2014-04-01 Thread Greg KH
On Tue, Apr 01, 2014 at 09:52:11AM -0300, Guido Martínez wrote: Parenthesize both macros so they will not break program logic if used within another 'if'. Also fix a usage of DBG_PRT with a missing semicolon. Signed-off-by: Guido Martínez gu...@vanguardiasur.com.ar ---

Re: [PATCH 1/3] staging: vt6655: fix DBG_PRT and PRINT_K macros

2014-04-01 Thread Greg KH
On Tue, Apr 01, 2014 at 01:56:02PM -0300, Guido Martínez wrote: On Tue, Apr 01, 2014 at 09:33:00AM -0700, Greg KH wrote: On Tue, Apr 01, 2014 at 09:52:11AM -0300, Guido Martínez wrote: Parenthesize both macros so they will not break program logic if used within another 'if'. Also fix

Re: [GIT PULL] Staging driver patches for 3.15-rc1

2014-04-02 Thread Greg KH
On Wed, Apr 02, 2014 at 07:06:00AM -0600, Shuah Khan wrote: On Tue, Apr 1, 2014 at 12:48 PM, Greg KH gre...@linuxfoundation.org wrote: The following changes since commit dcb99fd9b08cfe1afe426af4d8d3cbc429190f15: Linux 3.14-rc7 (2014-03-16 18:51:24 -0700) are available in the git

Re: [GIT PULL] Staging driver patches for 3.15-rc1

2014-04-02 Thread Greg KH
On Wed, Apr 02, 2014 at 08:52:18PM +, Insop Song wrote: On Wed, April 02, 2014 1:04 PM, Greg KH wrote: On Wed, Apr 02, 2014 at 10:24:03AM +0200, Paul Bolle wrote: On Tue, 2014-04-01 at 11:48 -0700, Greg KH wrote: Staging driver pull request for 3.15-rc1 Here's the huge

Re: [PATCH 1/1] staging: sep: Fix coding style

2014-04-05 Thread Greg KH
On Sat, Apr 05, 2014 at 08:24:04PM +0200, Camille Bordignon wrote: This fixes coding style warning Missing a blank line after declarations in files sep_dev.h and sep_crypto.c. Signed-off-by: Camille Bordignon camille.bordig...@gmail.com --- diff --git a/drivers/staging/sep/sep_crypto.c

Re: [PATCHv3 1/1] staging: sep: Fix coding style

2014-04-06 Thread Greg KH
On Sun, Apr 06, 2014 at 06:21:27PM +0200, Camille Bordignon wrote: Signed-off-by: Camille Bordignon camille.bordig...@gmail.com --- Fix coding style warning Missing a blank line after declarations No, this needs to go up above your signed-off-by:, it was the fixed after Greg's response that

Re: [PATCH] Staging: rts5139: fix coding style

2014-04-06 Thread Greg KH
On Mon, Apr 07, 2014 at 12:45:05AM +0200, Fabio Falzoi wrote: fix some coding style issues in rts51x.c (from rts5139 module) What specific coding style issues did you fix here? You need to be explicit, and if you do more than one type of change in the same patch, it needs to be broken up into

Re: [PATCH] staging: cxt1e1: hwprobe: fix incorrect type in assignment

2014-04-07 Thread Greg KH
On Mon, Apr 07, 2014 at 03:38:27PM +0300, Matei Oprea wrote: Any comments on this ? You got an email from me about this, on the 23rd, saying that I can't do anything with it until 3.15-rc1 is out. thanks, greg k-h ___ devel mailing list

Re: [PATCH v2 4/5] Staging: rts5139: pr_warn(...) in place of printk(KERN_WARNING ...)

2014-04-07 Thread Greg KH
On Mon, Apr 07, 2014 at 01:34:47PM -0700, Joe Perches wrote: On Mon, 2014-04-07 at 22:27 +0200, Fabio Falzoi wrote: All printk(KERN_WARNING ...) replaced with pr_warn(...). Please remove the RTS51X_TIP prefix and and and use #define pr_fmt(fmt) KBUILD_MODNAME : fmt before any #include

[GIT PULL] More Staging driver patches for 3.15-rc1

2014-04-08 Thread Greg KH
The following changes since commit 8e0c0832348c7fda1c85d67697cfe4adf077344c: Merge tag 'fbdev-main-3.15' of git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux (2014-04-04 21:28:36 -0700) are available in the git repository at:

Re: [PATCH] Staging: bcm: Qos: fixed braces' coding style

2014-04-08 Thread Greg KH
On Wed, Apr 09, 2014 at 01:01:05AM +0200, Luis Ortega wrote: Fixed badly placed and unnecessary braces. PS: Performed as task 10 of the Eudyptula Challenge. Signed-off-by: Luis Ortega luior...@gmail.com --- drivers/staging/bcm/Qos.c | 174 +-

Re: staging/rtl8187se should be removed

2014-04-10 Thread Greg KH
On Thu, Apr 10, 2014 at 06:21:36PM +0300, Dan Carpenter wrote: The thing about keeping e100 in parallel with the other driver is that some devices didn't work on the other driver and also it wasn't staging code. I don't have strong opinions either way, but if we decide to keep the old

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-10 Thread Greg KH
On Thu, Apr 10, 2014 at 04:22:13PM -0400, Marcos A. Di Pietro wrote: On 04/10/2014 04:14 PM, Greg KH wrote: On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrote: Fixes code style errors in drivers/staging/bcm/Qos.c Patch submitted as part of the Eudyptula Challenge

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-10 Thread Greg KH
On Thu, Apr 10, 2014 at 06:56:01PM -0400, Marcos A. Di Pietro wrote: On 04/10/2014 04:55 PM, Greg KH wrote: On Thu, Apr 10, 2014 at 04:22:13PM -0400, Marcos A. Di Pietro wrote: On 04/10/2014 04:14 PM, Greg KH wrote: On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrote

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-10 Thread Greg KH
On Thu, Apr 10, 2014 at 07:27:27PM -0400, Marcos A. Di Pietro wrote: That's pretty obviously not going to apply properly, you have line-wrapp on. You can't cut-and-paste patches into gmail, see Documentation/email_clients.txt for details. thanks, greg k-h I'm so sorry about

Re: [PATCH] bcm: Fixing a few checkpatch issues in InterfaceMisc.h

2014-04-13 Thread Greg KH
On Sun, Apr 13, 2014 at 02:56:57PM -0400, JulianGindi wrote: Just cleaned up a few issues presented by checkpatch in InterfaceMisc.h. I converted some spaces to tabs, and removed unnecessary whitespace. The kernel version I am using linux-next-20140411. That's a very long line, please wrap

Re: Fwd: [PATCH] [PATCH/RESENT] staging] speakup: fix typo in kobjects.c

2014-04-14 Thread Greg KH
On Tue, Apr 15, 2014 at 01:17:42AM +0900, Masanari Iida wrote: Hi Maintainers, This patch did not pick up during 3.15-rc1 merge period. That is because you didn't send it to the correct people :( Always use the scripts/get_maintainer.pl tool, it will tell you the correct addresses to use.

Re: Fwd: [PATCH] [PATCH/RESENT] staging] speakup: fix typo in kobjects.c

2014-04-14 Thread Greg KH
On Tue, Apr 15, 2014 at 01:17:42AM +0900, Masanari Iida wrote: Hi Maintainers, This patch did not pick up during 3.15-rc1 merge period. Please don't forget to pick up in 3.16. Regards, Masanari -- Forwarded message -- From: suzuki hyt...@gmail.com Date: Fri, Feb 28,

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Greg KH
On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos A. Di Pietro wrote: On 04/10/2014 07:56 PM, Greg KH wrote: On Thu, Apr 10, 2014 at 07:27:27PM -0400, Marcos A. Di Pietro wrote: That's pretty obviously not going to apply properly, you have line-wrapp on. You can't cut-and-paste patches

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Greg KH
On Wed, Apr 16, 2014 at 02:18:46PM -0400, Marcos Di Pietro wrote: On Wed, Apr 16, 2014 at 11:39 AM, Greg KH g...@kroah.com wrote: On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos A. Di Pietro wrote: On 04/10/2014 07:56 PM, Greg KH wrote: On Thu, Apr 10, 2014 at 07:27:27PM -0400, Marcos

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Greg KH
On Wed, Apr 16, 2014 at 07:39:06PM -0400, Marcos A. Di Pietro wrote: On 04/16/2014 02:25 PM, Greg KH wrote: On Wed, Apr 16, 2014 at 02:18:46PM -0400, Marcos Di Pietro wrote: On Wed, Apr 16, 2014 at 11:39 AM, Greg KH g...@kroah.com wrote: On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos

Re: [PATCH RESEND 2/2] staging: binder: Code simplification

2014-04-16 Thread Greg KH
On Tue, Apr 15, 2014 at 12:03:06PM +0200, Mathieu Maret wrote: Remove duplicate code Signed-off-by: Mathieu Maret mathieu.ma...@gmail.com --- drivers/staging/android/binder.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/android/binder.c

Re: [PATCH 3/3] Staging:android:uapi:binder.h __packed

2014-04-16 Thread Greg KH
On Tue, Apr 08, 2014 at 07:02:04PM +0100, Paul McQuade wrote: WARNING: __packed is preferred over __attribute__((packed)) Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/android/uapi/binder.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Not on uapi .h files,

Re: [PATCH v2] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Greg KH
On Fri, Apr 11, 2014 at 11:04:42AM -0400, Marcos A. Di Pietro wrote: Fixes code style errors in drivers/staging/bcm/Qos.c Patch submitted as part of the Eudyptula Challenge Signed-off-by: Marcos A. Di Pietro marcos...@gmail.com --- drivers/staging/bcm/Qos.c | 7 +-- 1 file changed,

Re: [PATCH 1/4] Staging: lustre: Fixed formatting errors in lib-types.h identified by checkpatch.pl

2014-04-16 Thread Greg KH
On Wed, Apr 02, 2014 at 07:12:56PM +1100, Joshua Baldock wrote: Fixed '{' not on same line as struct in file lib-types.h identified by checkpatch.pl Signed-off-by: Joshua Baldock joshua.bald...@gmail.com --- drivers/staging/lustre/include/linux/lnet/lib-types.h | 12 1 file

Re: [PATCH 3.14.0/linux-next]: staging/line6: playback.c style corrections

2014-04-16 Thread Greg KH
On Sun, Apr 06, 2014 at 08:53:02AM +0300, Sami Laine wrote: From: Sami Laine laine.j.s...@gmail.com Five coding style corrections to drivers/staging/line6/playback.c. Signed-Off-by: Sami Laine laine.j.s...@gmail.com --- Sorry, but someone sent this same patch just before you did, so I

Re: [PATCH] Staging:Line6:usbdefs.h parenthesis for Marcos

2014-04-16 Thread Greg KH
On Tue, Apr 08, 2014 at 05:11:26PM +0100, Paul McQuade wrote: ERROR: Macros with complex values should be enclosed in parenthesis Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/line6/usbdefs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: r8192e_pci driver broken 3.14+

2014-04-18 Thread Greg KH
On Fri, Apr 18, 2014 at 01:36:19PM -0400, Sean MacLennan wrote: Commit 198e0d17c on November 2 by Rashika Kheria breaks the r8192e_pci driver on my laptop. The bulk of the commit is fine. It is just the following change that causes grief: diff --git a/drivers/staging/rtl8192e/rtllib_tx.c

[GIT PULL] Staging driver fixes for 3.15-rc2

2014-04-18 Thread Greg KH
The following changes since commit c9eaa447e77efe77b7fa4c953bd62de8297fd6c5: Linux 3.15-rc1 (2014-04-13 14:18:35 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.15-rc2 for you to fetch changes up to

Re: [PATCH 0/3] staging: gdm72xx: Minor cleanup

2014-04-18 Thread Greg KH
On Fri, Mar 21, 2014 at 04:34:56PM +0800, Michalis Pappas wrote: The following patches perform various cleanups on the gdm72xx driver. PATCH 1/3 fixes some small coding style issues PATCH 2/3 removes an already completed item from the TODO list PATCH 3/3 replaces some jiffies comparisons

Re: [PATCH] staging: rtl8192u: r8192U_wx: Fix sparse warnings

2014-04-18 Thread Greg KH
On Fri, Mar 21, 2014 at 04:07:49PM +0200, Matei Oprea wrote: Fix sparse should be static warnings. Those structures are only referenced in file scope so they can be marked as static. Signed-off-by: Matei Oprea e...@opreamatei.ro Cc: ROSEdu Kernel Community fire...@lists.rosedu.org ---

Re: [PATCH v2 3/4] staging: vt6655: remove dead code

2014-04-18 Thread Greg KH
On Wed, Apr 02, 2014 at 02:53:03PM -0300, Guido Martínez wrote: Remove dead code in many places on this driver. Signed-off-by: Guido Martínez gu...@vanguardiasur.com.ar This patch does not apply, can you refresh it, and the 4/4 patch, against my latest tree and resend? thanks, greg k-h

Re: [PATCH] staging: vt6656: fix sparse warning

2014-04-18 Thread Greg KH
On Mon, Apr 14, 2014 at 10:41:07AM +1000, Angus Gibson wrote: This patch fixes the following warning: drivers/staging/vt6656/aes_ccmp.c:221:6: warning: symbol 'AESbGenCCMP' was not declared. Should it be static? Signed-off-by: Angus Gibson darthshr...@gmail.com ---

<    2   3   4   5   6   7   8   9   10   11   >