Re: [PATCH] staging: ralink-gdma: Prefer u32 over uint32_t

2019-03-21 Thread Greg KH
On Fri, Mar 22, 2019 at 12:18:58AM +0530, Bharath Vedartham wrote: > On Thu, Mar 21, 2019 at 07:46:09PM +0100, Greg KH wrote: > > On Fri, Mar 22, 2019 at 12:07:10AM +0530, Bharath Vedartham wrote: > > > Change uint32_t to u32 > > > > That says _what_ you did, but _wh

Re: [PATCH v2] staging: ralink-gdma: Change uint32_t to u32

2019-03-22 Thread Greg KH
On Fri, Mar 22, 2019 at 06:35:07PM +0530, Bharath Vedartham wrote: > Change occurences of uint32_t to u32 to fix checkpatch.pl warnings. > > Signed-off-by: Bharath Vedartham > --- > Changes since v1: > - Improved changelog. I have 3 "v2" patches from you :( I have no idea which one is the

Re: [PATCH v4] staging: ralink-gdma: Use u32 over uint32_t

2019-03-24 Thread Greg KH
On Sat, Mar 23, 2019 at 09:16:48PM +0530, Bharath Vedartham wrote: > Fixes the checkpatch.pl warning: "Prefer u32 over uint32_t" > > Signed-off-by: Bharath Vedartham > --- > Changes since v3 > - Fixed allignment issues. > - Submitted a seperate patch to change unsigned > to unsi

Re: [PATCH] staging: ralink-gdma: Convert unsigned to unsigned int

2019-03-24 Thread Greg KH
On Sat, Mar 23, 2019 at 05:04:44PM +0530, Bharath Vedartham wrote: > Fix the checkpatch.pl warning: "Use unsigned int instead of unsigned". > > Signed-off-by: Bharath Vedartham > --- > drivers/staging/ralink-gdma/ralink-gdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This patch a

Re: [PATCH] staging: ralink-gdma: Convert unsigned to unsigned int

2019-03-24 Thread Greg KH
On Sun, Mar 24, 2019 at 03:07:48PM +0530, Bharath Vedartham wrote: > On Sun, Mar 24, 2019 at 09:58:42AM +0100, Greg KH wrote: > > On Sat, Mar 23, 2019 at 05:04:44PM +0530, Bharath Vedartham wrote: > > > Fix the checkpatch.pl warning: "Use unsigned int instead of unsigned&qu

Re: [RFC/PATCH] staging: olpc_dcon: Use WARN_ON instead of BUG_ON

2019-03-24 Thread Greg KH
On Sun, Mar 24, 2019 at 05:42:08PM +0530, Bharath Vedartham wrote: > This is with respect to a checkpatch.pl CHECK: "Avoid crashing the > kernel. Use WARN_ON instead of BUG_ON". But I maybe wrong here. Is a > kernel crash desired if olpc_board_at_least(olpc_board(0xc2)) fails, > will there be incon

Re: [PATCH] Staging: emxx_udc: emxx_udc: Fixed a coding style error

2019-03-27 Thread Greg KH
On Tue, Mar 26, 2019 at 09:47:23AM -0400, Will Cunningham wrote: > Removed unnecessary parentheses. > > Signed-off-by: Will Cunningham > --- > drivers/staging/emxx_udc/emxx_udc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Someone else sent this patch right before you did, sorry. g

Re: [PATCH v2] driver : staging : ion: optimization for decreasing memory fragmentaion

2019-03-27 Thread Greg KH
On Wed, Mar 20, 2019 at 02:38:23PM +0800, Zhaoyang Huang wrote: > From: Zhaoyang Huang > > Two action for this patch: > 1. set a batch size for system heap's shrinker, which can have it buffer > reasonable page blocks in pool for future allocation. > 2. reverse the order sequence when free page b

Re: [PATCH v2] staging: rtl8723bs: core: fix line over 80 characters warning

2019-03-29 Thread Greg KH
On Wed, Mar 27, 2019 at 11:49:07PM +0530, Anirudh Rayabharam wrote: > Checkpatch.pl complains that these lines are over 80 characters. Use the > "psecuritypriv" pointer for consistency, remove unnecessary parantheses > and fix the alignment. > > This patch just cleans up a condition, it doesn't af

[GIT PULL] Staging driver fixes for 5.1-rc3

2019-03-30 Thread Greg KH
The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.1-rc3 for you to fetch changes up to cc26358f89c3e4

Re: [PATCH] Staging: comedi: drivers: pcl818: Fixed a coding style error.

2019-03-31 Thread Greg KH
On Sun, Mar 31, 2019 at 06:53:36PM -0400, Will Cunningham wrote: > Removed unnecessary parentheses.` Odd trailing character :( > > Signed-off-by: Will Cunningham > --- > drivers/staging/comedi/drivers/pcl818.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/dr

Re: [PATCH v2] Staging: comedi: drivers: pcl818: Fixed a coding style error.

2019-04-01 Thread Greg KH
On Mon, Apr 01, 2019 at 10:01:30AM -0400, Will Cunningham wrote: > Removed unnecessary parentheses. > > Signed-off-by: Will Cunningham > --- > Changes in v2: > - Removed a typo from the commit message. > --- > drivers/staging/comedi/drivers/pcl818.c | 8 > 1 file changed, 4 insertions(

Re: [PATCH 2/4] staging: iio: ad9832: add SPDX identifier

2019-04-01 Thread Greg KH
On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote: > > On 4/1/2019 8:07 PM, Marcelo Schmitt wrote: > > Add SPDX identifier of GPL-2.0 for the ad9832 driver. > > > > Signed-off-by: Marcelo Schmitt > > --- > > drivers/staging/iio/frequency/ad9832.c | 3 +-- > > 1 file changed, 1 inser

Re: [PATCH v3 05/14] staging: most: enable configfs support

2019-04-02 Thread Greg KH
On Mon, Apr 01, 2019 at 02:05:30PM +0200, Christian Gromm wrote: > This patch enables the configfs functionality of the driver by > registering the configfs subsystems and compiling the configfs > part of the sources. > > Signed-off-by: Christian Gromm > --- > v2: > - remove call to configf

Re: [PATCH v3 07/14] staging: most: core: use device description as name

2019-04-02 Thread Greg KH
On Mon, Apr 01, 2019 at 02:05:32PM +0200, Christian Gromm wrote: > This patch uses the device description to clearly identity a device > attached to the bus. It is needed as the currently useed mdevX > notation is not sufficiant in case more than one network > interface controller is being used at

Re: [PATCH v3 13/14] staging: most: configfs: rename config attributes

2019-04-02 Thread Greg KH
On Mon, Apr 01, 2019 at 02:05:38PM +0200, Christian Gromm wrote: > This patch introduces attribute names that are more self explaining. > > Signed-off-by: Christian Gromm > --- > v2: > - follow-up adaptions due to changes introduced w/ [PATCH v2 01/14] > v3: > > drivers/staging/most/confi

Re: [PATCH v3 07/14] staging: most: core: use device description as name

2019-04-02 Thread Greg KH
On Tue, Apr 02, 2019 at 08:10:25AM +, christian.gr...@microchip.com wrote: > On Di, 2019-04-02 at 09:24 +0200, Greg KH wrote: > > External E-Mail > > > > > > On Mon, Apr 01, 2019 at 02:05:32PM +0200, Christian Gromm wrote: > > > > > > This

Re: [PATCH v3 13/14] staging: most: configfs: rename config attributes

2019-04-02 Thread Greg KH
On Tue, Apr 02, 2019 at 08:17:02AM +, christian.gr...@microchip.com wrote: > On Di, 2019-04-02 at 09:25 +0200, Greg KH wrote: > > External E-Mail > > > > > > On Mon, Apr 01, 2019 at 02:05:38PM +0200, Christian Gromm wrote: > > > > > > This patch

Re: [PATCH v3 13/14] staging: most: configfs: rename config attributes

2019-04-02 Thread Greg KH
On Tue, Apr 02, 2019 at 09:45:35AM +, christian.gr...@microchip.com wrote: > On Di, 2019-04-02 at 11:01 +0200, Greg KH wrote: > > External E-Mail > > > > > > On Tue, Apr 02, 2019 at 08:17:02AM +, Christian.Gromm@microchip.c > > om wrote: > > &g

Re: [PATCH v3 07/14] staging: most: core: use device description as name

2019-04-02 Thread Greg KH
On Tue, Apr 02, 2019 at 09:21:09AM +, christian.gr...@microchip.com wrote: > On Di, 2019-04-02 at 11:00 +0200, Greg KH wrote: > > External E-Mail > > > > > > On Tue, Apr 02, 2019 at 08:10:25AM +, Christian.Gromm@microchip.c > > om wrote: > > &g

Re: [PATCH] staging: gdm724x: Add parenthesis to Macro arguments

2019-04-02 Thread Greg KH
On Tue, Apr 02, 2019 at 10:04:05PM -0300, Andre Dainez wrote: > Fix checkpatch errors: > > CHECK: Macro argument 'len' may be better as '(len)' to avoid precedence > issues > CHECK: Macro argument 'nlh' may be better as '(nlh)' to avoid precedence > issues > > Signed-off-by: Andre Dainez > ---

Re: [PATCH] MT7621-SPI: spi-mt7621: Fix alignment and style problems Fixed Coding function and style issues

2019-04-04 Thread Greg KH
On Thu, Apr 04, 2019 at 01:01:07AM +0530, Nilesh Hase wrote: > Signed-off-by: Nilesh Hase > --- > drivers/staging/mt7621-spi/spi-mt7621.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I can't take patches without any changelog content, sorry. ___

Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731)

2019-07-31 Thread Greg KH
On Wed, Jul 31, 2019 at 08:48:24AM -0700, David Miller wrote: > From: Greg Kroah-Hartman > Date: Wed, 31 Jul 2019 13:35:22 +0200 > > > On Wed, Jul 31, 2019 at 12:24:41PM +0100, Mark Brown wrote: > >> On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote: > >> > >> Today's -next fails

[PATCH v2] staging/octeon: Fix build error without CONFIG_NETDEVICES

2019-07-31 Thread Greg KH
From: YueHaibing While do COMPILE_TEST build without CONFIG_NETDEVICES, we get Kconfig warning: WARNING: unmet direct dependencies detected for PHYLIB Depends on [n]: NETDEVICES [=n] Selected by [y]: - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && NETDEVICES [=n] || COMPIL

Re: [PATCH] staging:kpc2000:Fix dubious x | !y sparse warning

2019-08-01 Thread Greg KH
On Thu, Aug 01, 2019 at 12:06:06AM +0530, Harsh Jain wrote: > Bitwise OR(|) operation with 0 always yield same result. > It fixes dubious x | !y sparse warning. > > Signed-off-by: Harsh Jain > --- > drivers/staging/kpc2000/kpc2000_i2c.c | 16 +--- > 1 file changed, 1 insertion(+), 15

Re: [PATCH] staging: wilc1000: merge drv_handle and operation_mode wids

2019-08-01 Thread Greg KH
On Wed, Jul 31, 2019 at 08:58:19PM +, adham.aboza...@microchip.com wrote: > From: Adham Abozaeid > > wilc_set_wfi_drv_handler and wilc_set_operation_mode sends the same > parameters to the FW, so it's better to combine them together. > > Kept wilc_set_wfi_drv_handler implementation since it

Re: [PATCH] staging: wilc1000: remove unused function

2019-08-01 Thread Greg KH
On Wed, Jul 31, 2019 at 09:01:20PM +, adham.aboza...@microchip.com wrote: > From: Adham Abozaeid > > function wilc_resolve_disconnect_aberration isn't referenced, so > removing it > > Signed-off-by: Adham Abozaeid > --- > drivers/staging/wilc1000/wilc_hif.c | 9 - > drivers/staging

Re: [PATCH] staging:kpc2000:Fix dubious x | !y sparse warning

2019-08-01 Thread Greg KH
On Thu, Aug 01, 2019 at 07:22:13PM +, Matt Sickler wrote: > >-Original Message- > >From: devel On Behalf Of > >Greg KH > >Sent: Thursday, August 01, 2019 11:35 AM > >To: Harsh Jain > >Cc: de...@driverdev.osuosl.org; linux-ker...@vg

Re: [PATCH v5 1/3] [v4.9.y] coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping

2019-08-02 Thread Greg KH
On Tue, Jul 02, 2019 at 12:02:05AM +0530, Ajay Kaher wrote: > From: Andrea Arcangeli > > commit 04f5866e41fb70690e28397487d8bd8eea7d712a upstream. > > The core dumping code has always run without holding the mmap_sem for > writing, despite that is the only way to ensure that the entire vma > lay

Re: [PATCH] isdn: hysdn: Fix error spaces around '*'

2019-08-02 Thread Greg KH
On Fri, Aug 02, 2019 at 07:56:02PM +, Jose Carlos Cazarin Filho wrote: > Fix checkpath error: > CHECK: spaces preferred around that '*' (ctx:WxV) > +extern hysdn_card *card_root;/* pointer to first card */ > > Signed-off-by: Jose Carlos Cazarin Filho > --- > Hello all! > This is my

Re: [PATCH] drivers:staging:isdn:hysdn brace same line if

2019-08-02 Thread Greg KH
On Fri, Aug 02, 2019 at 07:51:05PM +, Fernando Eckhardt Valle wrote: > Fix checkpatch error "ERROR: that open brace { should be on the previous > line" in drivers/staging/isdn/hysdn/hycapi.c:51. > > Signed-off-by: Fernando Eckhardt Valle > --- > drivers/staging/isdn/hysdn/hycapi.c | 3 +-- >

Re: [PATCH] isdn: hysdn: Fix error spaces around '*'

2019-08-03 Thread Greg KH
On Sat, Aug 03, 2019 at 04:15:05AM -0700, Joe Perches wrote: > On Sat, 2019-08-03 at 08:32 +0200, Greg KH wrote: > > On Fri, Aug 02, 2019 at 07:56:02PM +, Jose Carlos Cazarin Filho wrote: > > > Fix checkpath error: > > > CHECK: spaces preferred around that

Re: [PATCH] drivers:staging:isdn:hysdn brace same line if

2019-08-04 Thread Greg KH
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Sun, Aug 04, 2019 at 10:

Re: [PATCH v6 0/3] [v4.9.y] coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping

2019-08-04 Thread Greg KH
On Sun, Aug 04, 2019 at 09:29:28AM +0530, Ajay Kaher wrote: > coredump: fix race condition between mmget_not_zero()/get_task_mm() > and core dumping > > [PATCH v5 1/3]: > Backporting of commit 04f5866e41fb70690e28397487d8bd8eea7d712a upstream. > > [PATCH v5 2/3]: > Extension of commit 04f5866e41f

Re: [PATCH] Staging : rtl8188eu : rtw_security.c - Fixed warning: coding style issues - Fixed warning: if statement containing return with an else - Fixed check: coding style issues

2019-08-05 Thread Greg KH
On Mon, Aug 05, 2019 at 01:22:56PM +0530, merwintf wrote: > Signed-off-by: merwintf > --- > drivers/staging/rtl8188eu/core/rtw_security.c | 525 +++--- > 1 file changed, 334 insertions(+), 191 deletions(-) > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent h

Re: [PATCH] isdn: hysdn: Fix error spaces around '*'

2019-08-08 Thread Greg KH
On Fri, Aug 02, 2019 at 03:05:05PM -0700, Joe Perches wrote: > On Fri, 2019-08-02 at 14:55 -0700, Stephen Hemminger wrote: > > On Fri, 2 Aug 2019 19:56:02 + > > Jose Carlos Cazarin Filho wrote: > > > > > Fix checkpath error: > > > CHECK: spaces preferred around that '*' (ctx:WxV) > > > +exte

Re: [PATCH] isdn: hysdn: Fix error spaces around '*'

2019-08-08 Thread Greg KH
On Thu, Aug 08, 2019 at 06:39:05PM +0200, Greg KH wrote: > On Fri, Aug 02, 2019 at 03:05:05PM -0700, Joe Perches wrote: > > On Fri, 2019-08-02 at 14:55 -0700, Stephen Hemminger wrote: > > > On Fri, 2 Aug 2019 19:56:02 + > > > Jose Carlos Cazarin Filho wrote: &

Re: [PATCH] staging: wusbcore: Fix build error without CONFIG_USB

2019-08-09 Thread Greg KH
On Fri, Aug 09, 2019 at 06:21:50PM +0800, YueHaibing wrote: > USB_WUSB should depends on CONFIG_USB, otherwise building fails > > drivers/staging/wusbcore/wusbhc.o: In function `wusbhc_giveback_urb': > wusbhc.c:(.text+0xa28): undefined reference to `usb_hcd_giveback_urb' > > Reported-by: Hulk Rob

[GIT PULL] Staging/IIO driver fixes for 5.3-rc4

2019-08-10 Thread Greg KH
The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.3-rc4 for you to fetch changes up to 09f6109ff4f800

Re: [PATCH 01/11] staging: rtl8712: _r8712_init_xmit_priv(): Change return values and type

2019-08-12 Thread Greg KH
On Fri, Aug 09, 2019 at 10:53:43AM +0530, Nishka Dasgupta wrote: > Change the return values in _r8712_init_xmit_priv from _SUCCESS/_FAIL to > 0/-ENOMEM respectively. Change return type from sint to int. > > Signed-off-by: Nishka Dasgupta I only received 9 patches in this series. I'll try to app

Re: [PATCH] staging: drivers: rtl8712: removing unnecessary parenthesis

2019-08-12 Thread Greg KH
On Fri, Aug 09, 2019 at 11:18:23PM -0400, Hugo Eduardo Ziviani wrote: > Fix checkpatch error "CHECK: Remove unecessary parenthesis in > drivers/staging/rtl8712/rtl871x_mlme.c" > > Signed-off-by: Hugo Eduardo Ziviani > --- > drivers/staging/rtl8712/rtl871x_mlme.c | 89 +-

Re: [PATCH v2] staging: drivers: rtl8712: removing unnecessary parenthesis

2019-08-15 Thread Greg KH
On Thu, Aug 15, 2019 at 11:26:40AM -0400, hugoziviani wrote: > Fix checkpatch error "CHECK: Remove unecessary parenthesis in > drivers/staging/rtl8712/rtl871x_mlme.c" > > Signed-off-by: hugoziviani > --- > drivers/staging/rtl8712/rtl871x_mlme.c | 84 +- > 1 file changed,

Re: [RFC PATCH 00/15] acrn: add the ACRN driver module

2019-08-16 Thread Greg KH
On Fri, Aug 16, 2019 at 08:39:25AM +0200, Borislav Petkov wrote: > On Fri, Aug 16, 2019 at 10:25:41AM +0800, Zhao Yakui wrote: > > The first three patches are the changes under x86/acrn, which adds the > > required APIs for the driver and reports the X2APIC caps. > > The remaining patches add the

Re: [RFC PATCH 04/15] drivers/acrn: add the basic framework of acrn char device driver

2019-08-16 Thread Greg KH
On Fri, Aug 16, 2019 at 10:25:45AM +0800, Zhao Yakui wrote: > ACRN hypervisor service module is the important middle layer that allows > the Linux kernel to communicate with the ACRN hypervisor. It includes > the management of virtualized CPU/memory/device/interrupt for other ACRN > guest. The user

Re: [PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue

2019-08-17 Thread Greg KH
On Sat, Aug 17, 2019 at 02:54:26AM -0400, Matthew Hanzelik wrote: > Fixed an unnamed parameter style issue. > > Signed-off-by: Matthew Hanzelik > --- > drivers/staging/speakup/spk_types.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/speakup/spk_types.

Re: [PATCH] staging: android: Remove ion device tree bindings from the TODO

2019-08-17 Thread Greg KH
On Sat, Aug 17, 2019 at 05:37:58PM -0400, Donald Yandt wrote: > This patch removes the todo for the ion chunk and > carveout device tree bindings. > > Signed-off-by: Donald Yandt > --- > drivers/staging/android/TODO | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/andro

Re: [PATCH] staging: android: Remove ion device tree bindings from the TODO

2019-08-17 Thread Greg KH
On Sun, Aug 18, 2019 at 01:47:38AM -0400, Donald Yandt wrote: > On Sun, Aug 18, 2019 at 1:03 AM Greg KH wrote: > > > > On Sat, Aug 17, 2019 at 05:37:58PM -0400, Donald Yandt wrote: > > > This patch removes the todo for the ion chunk and > > > carveout device tree

[GIT PULL] Staging/IIO driver fixes for 5.3-rc5

2019-08-18 Thread Greg KH
The following changes since commit d45331b00ddb179e291766617259261c112db872: Linux 5.3-rc4 (2019-08-11 13:26:41 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.3-rc5 for you to fetch changes up to 48b30e10bfc20e

Re: [RFC PATCH 00/15] acrn: add the ACRN driver module

2019-08-18 Thread Greg KH
On Mon, Aug 19, 2019 at 09:44:25AM +0800, Zhao, Yakui wrote: > > > On 2019年08月16日 14:39, Borislav Petkov wrote: > > On Fri, Aug 16, 2019 at 10:25:41AM +0800, Zhao Yakui wrote: > > > The first three patches are the changes under x86/acrn, which adds the > > > required APIs for the driver and repor

Re: [RFC PATCH 00/15] acrn: add the ACRN driver module

2019-08-18 Thread Greg KH
On Mon, Aug 19, 2019 at 10:39:32AM +0800, Zhao, Yakui wrote: > > > On 2019年08月16日 15:03, Greg KH wrote: > > On Fri, Aug 16, 2019 at 08:39:25AM +0200, Borislav Petkov wrote: > > > On Fri, Aug 16, 2019 at 10:25:41AM +0800, Zhao Yakui wrote: > > > > The first thr

Re: [RFC PATCH 04/15] drivers/acrn: add the basic framework of acrn char device driver

2019-08-18 Thread Greg KH
On Mon, Aug 19, 2019 at 12:02:33PM +0800, Zhao, Yakui wrote: > > > On 2019年08月16日 15:05, Greg KH wrote: > > On Fri, Aug 16, 2019 at 10:25:45AM +0800, Zhao Yakui wrote: > > > ACRN hypervisor service module is the important middle layer that allows > > > the Lin

Re: [PATCH 1/2] comedi: remove camelcase

2019-08-20 Thread Greg KH
On Tue, Aug 20, 2019 at 11:43:06PM +, m...@ehuber.info wrote: > From: Edmund Huber > > --- > drivers/staging/comedi/drivers/ni_pcimio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I don't think you read all of the issues that my patchbot sent you. Please re-read that and fi

Re: [PATCH 1/2] comedi: remove camelcase

2019-08-21 Thread Greg KH
at once (Tobin must have run a class), so yes, it is totally possible that I did not respond to yours, but someone elses, my appologies. Here's what it should have said, I'll run it "by hand" below: > On Tue, Aug 20, 2019 at 7:37 PM Greg KH wrote: > > > On Tue, Aug

Re: [PATCH] staging: rtl8192u: Fix spacing style issues

2019-08-25 Thread Greg KH
On Mon, Aug 26, 2019 at 01:08:35AM +0530, Sumera Priyadarsini wrote: > This patch fixes the file r8190_rtl8256.c to avoid the following > checkpatch.pl warnings: > CHECK: spaces preferred around that '<<' (ctx:VxV) > CHECK: spaces preferred around that '-' (ctx:VxV) > CHECK: Blank

Re: [PATCH] staging: most-core: Fix checkpatch warnings

2019-08-27 Thread Greg KH
On Mon, Aug 26, 2019 at 01:58:49AM +0800, Peikan Tsai wrote: > Hi, > > This patch solves the following checkpatch.pl's messages in > drivers/staging/most/core.c. > > WARNING: line over 80 characters > + return snprintf(buf, PAGE_SIZE, "%s", > ch_data_type[i].name); > > CHEC

Re: [PATCH 0/9] staging: move greybus core out of staging

2019-08-27 Thread Greg KH
On Tue, Aug 27, 2019 at 03:30:21PM +0100, Rui Miguel Silva wrote: > Hi, > On Tue 27 Aug 2019 at 14:45, Greg Kroah-Hartman wrote: > > On Tue, Aug 27, 2019 at 04:36:11PM +0300, Dan Carpenter wrote: > >> I can't compile greybus so it's hard to run Smatch on it... I have a > >> Smatch thing which igno

Re: [PATCH 0/9] staging: move greybus core out of staging

2019-08-27 Thread Greg KH
On Tue, Aug 27, 2019 at 04:57:20PM +0100, Rui Miguel Silva wrote: > Hi Greg, > On Tue 27 Aug 2019 at 16:43, Greg KH wrote: > > On Tue, Aug 27, 2019 at 03:30:21PM +0100, Rui Miguel Silva wrote: > >> Hi, > >> On Tue 27 Aug 2019 at 14:45, Greg Kroah-Hartman wrote: > &

Re: [PATCH] binder: Use kmem_cache for binder_thread

2019-08-28 Thread Greg KH
On Thu, Aug 29, 2019 at 01:49:53PM +0800, Peikan Tsai wrote: > Hi, No need for that in a changelog text :) > The allocated size for each binder_thread is 512 bytes by kzalloc. > Because the size of binder_thread is fixed and it's only 304 bytes. > It will save 208 bytes per binder_thread when use

Re: [PATCH] binder: Use kmem_cache for binder_thread

2019-08-29 Thread Greg KH
On Thu, Aug 29, 2019 at 05:27:22PM +0200, Christian Brauner wrote: > On Thu, Aug 29, 2019 at 09:53:59AM -0400, Joel Fernandes wrote: > > On Thu, Aug 29, 2019 at 08:42:29AM +0200, Greg KH wrote: > > > On Thu, Aug 29, 2019 at 01:49:53PM +0800, Peikan Tsai wrote: > > [snip

Re: [PATCH] binder: Use kmem_cache for binder_thread

2019-08-29 Thread Greg KH
On Fri, Aug 30, 2019 at 02:59:01AM +0800, Peikan Tsai wrote: > On Thu, Aug 29, 2019 at 05:27:22PM +0200, Christian Brauner wrote: > > On Thu, Aug 29, 2019 at 09:53:59AM -0400, Joel Fernandes wrote: > > > On Thu, Aug 29, 2019 at 08:42:29AM +0200, Greg KH wrote: > > > >

Re: linux-next: Tree for Sep 2 (exfat)

2019-09-02 Thread Greg KH
On Mon, Sep 02, 2019 at 10:39:39AM -0700, Randy Dunlap wrote: > On 9/2/19 5:43 AM, Stephen Rothwell wrote: > > Hi all, > > > > News: I will only be doing 2 more releases before I leave for Kernel > > Summit (there may be some reports on Thursday, but I doubt I will have > > time to finish the full

Re: linux-next: Tree for Sep 2 (exfat)

2019-09-02 Thread Greg KH
On Mon, Sep 02, 2019 at 10:39:39AM -0700, Randy Dunlap wrote: > On 9/2/19 5:43 AM, Stephen Rothwell wrote: > > Hi all, > > > > News: I will only be doing 2 more releases before I leave for Kernel > > Summit (there may be some reports on Thursday, but I doubt I will have > > time to finish the full

Re: linux-next: Tree for Sep 2 (exfat)

2019-09-02 Thread Greg KH
On Mon, Sep 02, 2019 at 11:11:45AM -0700, Joe Perches wrote: > On Mon, 2019-09-02 at 11:07 -0700, Randy Dunlap wrote: > > On 9/2/19 10:46 AM, Greg KH wrote: > > > On Mon, Sep 02, 2019 at 10:39:39AM -0700, Randy Dunlap wrote: > > > > On 9/2/19 5:43 AM, Stephen Ro

Re: [PATCH] staging: rts5208: Fix checkpath warning

2019-09-03 Thread Greg KH
On Sat, Aug 31, 2019 at 01:02:24PM +0530, P SAI PRASANTH wrote: > This patch fixes the following checkpath warning > in file drivers/staging/rts5208/xd.c:1754 > > WARNING: line over 80 characters > + index, offset, DMA_TO_DEVICE, > chip->xd_timeout); > >

Re: [PATCH] staging: rts5208: Fixed checkpatch warning.

2019-09-03 Thread Greg KH
On Sat, Aug 31, 2019 at 01:10:55PM +0530, Prakhar Sinha wrote: > This patch solves the following checkpatch.pl's messages in > drivers/staging/rts5208/sd.c > > WARNING: line over 80 characters > 4517: FILE: drivers/staging/rts5208/sd.c:4517: > + sd_car

Re: [PATCH] staging: rts5208: Modified nested if blocks.

2019-09-03 Thread Greg KH
On Tue, Sep 03, 2019 at 02:32:40PM +0530, Prakhar Sinha wrote: > This patch solves the following checkpatch.pl's messages in > drivers/staging/rts5208/sd.c > > WARNING: line over 80 characters > 4517: FILE: drivers/staging/rts5208/sd.c:4517: > + sd_car

Re: [PATCH] erofs: using switch-case while checking the inode type.

2019-09-03 Thread Greg KH
On Wed, Sep 04, 2019 at 10:12:47AM +0800, Gao Xiang wrote: > Hi Greg, > > On Fri, Aug 30, 2019 at 10:22:33PM +0800, Gao Xiang wrote: > > On Fri, Aug 30, 2019 at 07:59:48PM +0800, Gao Xiang wrote: > > > Hi Pratik, > > > > > > The subject line could be better as '[PATCH v2] xx'... > > > > > >

Re: [PATCH] media: meson: Add NULL check after the call to kmalloc()

2019-09-04 Thread Greg KH
On Wed, Sep 04, 2019 at 05:22:32PM +0900, Austin Kim wrote: > If the kmalloc() return NULL, the NULL pointer dereference will occur. > new_ts->ts = ts; > > Add exception check after the call to kmalloc() is made. > > Signed-off-by: Austin Kim > --- > drivers/staging/media/meson/vdec/vdec_

Re: [RESEND PATCH v3 0/2] Add default binderfs devices

2019-09-04 Thread Greg KH
On Wed, Sep 04, 2019 at 01:07:02PM +0200, Christian Brauner wrote: > Hey, > > This is a resend of Hridya's series to add default binderfs devices. No > semantical changes were made. Only Joel's Acks were added by me. > > Binderfs was created to help provide private binder devices to > containers

Re: [PATCH] staging: rts5208: Fix 80 char warning by re-structuring if-blocks.

2019-09-04 Thread Greg KH
On Wed, Sep 04, 2019 at 06:35:23PM +0530, Prakhar Sinha wrote: > This patch solves the following checkpatch.pl's messages in > drivers/staging/rts5208/sd.c > > WARNING: line over 80 characters > 4517: FILE: drivers/staging/rts5208/sd.c:4517: > + sd_car

Re: [PATCH 1/2] staging: dt-bindings: wilc1000: add optional rtc_clk property

2019-09-05 Thread Greg KH
On Thu, Sep 05, 2019 at 06:09:43AM +, ajay.kat...@microchip.com wrote: > Hi Eugen, > > On 04-Sep-19 7:03 PM, Eugen Hristev - M18282 wrote: > > From: Eugen Hristev > > > > Add bindings for optional rtc clock pin. > > > > Signed-off-by: Eugen Hristev > > Thanks for sending the patch series.

Re: [PATCH 2/2] staging: wilc1000: look for rtc_clk clock

2019-09-05 Thread Greg KH
On Wed, Sep 04, 2019 at 01:34:01PM +, eugen.hris...@microchip.com wrote: > From: Eugen Hristev > > If rtc_clk is provided from DT, use it and enable it. > This is optional. > The signal may be hardcoded and no need to be requested, > but if DT provides it, use it. > > Signed-off-by: Eugen Hr

Re: [PATCH] FBTFT: fb_agm1264k: usleep_range is preferred over udelay

2019-09-09 Thread Greg KH
On Sun, Sep 08, 2019 at 08:26:05PM -0500, Sreeram Veluthakkal wrote: > This patch fixes the issue: > FILE: drivers/staging/fbtft/fb_agm1264k-fl.c:88: > CHECK: usleep_range is preferred over udelay; see > Documentation/timers/timers-howto.rst > + udelay(20); > > Signed-off-by: Sreeram Veluth

Re: [PATCH v2] staging: greybus: loopback_test: Adding missing brackets into if..else block

2019-09-09 Thread Greg KH
On Mon, Sep 09, 2019 at 02:32:44PM +, Julio Faracco wrote: > Inside a block of if..else conditional, else structure does not contain > brackets. This is not following regular policies of kernel coding style. > All parts of this conditional blocks should respect brackets inclusion. > This commit

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-15 Thread Greg KH
y does matter, what has been added here that we can make use of? And do you have any "real" development history to look at instead of the "one giant commit" of the initial code drop? That is where we could actually learn what has changed over time. Your repo as-is shows

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-16 Thread &#x27;Greg KH'
On Tue, Sep 17, 2019 at 12:02:01PM +0900, Namjae Jeon wrote: > We are excited to see this happening and would like to state that we > appreciate > time and > effort which people put into upstreaming exfat. Thank you! > > However, if possible, can we step back a little bit and re-consider it? We >

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-16 Thread Greg KH
On Tue, Sep 17, 2019 at 02:31:34PM +0900, Park Ju Hyung wrote: > On Tue, 17 Sep 2019 00:19:36 -0400, "Valdis Klētnieks" said: > > I'm working off a somewhat cleaned up copy of Samsung's original driver, > > because that's what I had knowledge of. If the sdfat driver is closer to > > being > > mer

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-17 Thread &#x27;Greg KH'
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-18 Thread &#x27;Greg KH'
On Wed, Sep 18, 2019 at 03:33:04PM +0900, Sergey Senozhatsky wrote: > On (09/18/19 08:16), 'Greg KH' wrote: > [..] > > > Note, that Samsung is still improving sdfat driver. For instance, > > > what will be realeased soon is sdfat v2.3.0, which will include supp

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-18 Thread Greg KH
On Wed, Sep 18, 2019 at 07:46:25PM +0900, Ju Hyung Park wrote: > On Wed, Sep 18, 2019 at 7:09 PM Dan Carpenter > wrote: > > Use Kconfig. > > Not just that. > There are a lot of non-static functions that's not marked ex/sdfat-specific. > (which we would have to clean it up eventually) Then clean

[GIT PULL] Staging/IIO driver patches for 5.4-rc1

2019-09-18 Thread Greg KH
The following changes since commit d1abaeb3be7b5fa6d7a1fbbd2e14e3310005c4c1: Linux 5.3-rc5 (2019-08-18 14:31:08 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.4-rc1 for you to fetch changes up to 3fb73eddba106a

Re: [GIT PULL] Staging/IIO driver patches for 5.4-rc1

2019-09-18 Thread Greg KH
On Wed, Sep 18, 2019 at 11:24:12AM -0700, Christoph Hellwig wrote: > Just as a note of record: I don't think either file system move > is a good idea. erofs still needs a lot of work, especially in > interacting with the mm code like abusing page->mapping. At least it is special-purpose "read on

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Greg KH
On Thu, Sep 19, 2019 at 04:59:20AM +0900, Park Ju Hyung wrote: > The new sdFAT driver base brings many improvements to the table. > Quoting Namjae Jeon: > > == > 1. sdfat has been refactored to improve compatibility, readability a

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Greg KH
On Thu, Sep 19, 2019 at 04:59:20AM +0900, Park Ju Hyung wrote: > --- a/drivers/staging/exfat/exfat.h > +++ b/drivers/staging/exfat/exfat.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > +// SPDX-License-Identifier: GPL-2.0-or-later You just changed the license of this file. Are you

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Greg KH
On Thu, Sep 19, 2019 at 05:22:03AM +0900, Ju Hyung Park wrote: > Hi Greg, > > On Thu, Sep 19, 2019 at 5:12 AM Greg KH wrote: > > That's a lot of rewriting :( > > > > How about at least keeping the file names the same to make it easier to > > see what happen

Re: [PATCH RFC 0/2] staging: Support Avalon-MM DMA Interface for PCIe

2019-09-19 Thread Greg KH
On Thu, Sep 19, 2019 at 11:59:11AM +0200, Alexander Gordeev wrote: > The Avalon-MM DMA Interface for PCIe is a design found in hard IPs for > Intel Arria, Cyclone or Stratix FPGAs. It transfers data between on-chip > memory and system memory. This RFC is an attempt to provide a generic API: > >

Re: [RESEND PATCH] staging: rtl8192u: Fix indentation for cleaner code

2019-09-24 Thread Greg KH
On Fri, Sep 13, 2019 at 11:31:01PM +0530, Sumera Priyadarsini wrote: > Fixes indentation for if condition in the file r8190_rtl8256.c for better > readability as suggested by Dan Carpenter. Please wrap your lines at 72 columns. > > Reported-by: Dan Carpenter > Signed-off-by: Sumera Priyadarsin

Re: [PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues.

2019-09-29 Thread Greg KH
On Sat, Sep 28, 2019 at 07:21:19PM -0500, Jesse Barton wrote: > Fixed Coding Style issues You need to be specific as to _what_ exactly you did here. What you wrote is very vague :) thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org h

Re: [PATCH 2/3] Staging: exfat: exfat_super.c: fixed multiple coding style issues with camelcase and parentheses

2019-09-29 Thread Greg KH
On Sat, Sep 28, 2019 at 07:22:33PM -0500, Jesse Barton wrote: > Fixed coding style issues with camelcase on functions and various parentheses > that were not needed Please wrap your changelog text properly. Only do one "type" of thing per patch, this should be two different ones. thanks, greg

Re: [PATCH] Staging: exfat: exfat_super.c: fixed camelcase coding style issue

2019-09-29 Thread Greg KH
On Sat, Sep 28, 2019 at 06:19:10PM -0500, Jesse Barton wrote: > Fixed a coding style issue. What coding style issue? Always be specific here. > Signed-off-by: Jesse Barton > --- > drivers/staging/exfat/exfat_super.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-)

Re: [PATCH] ion_system_heap: support X86 archtecture

2019-09-29 Thread Greg KH
On Sun, Sep 29, 2019 at 03:28:41PM +0800, jun.zh...@intel.com wrote: > From: zhang jun > > we see tons of warning like: > [ 45.846872] x86/PAT: NDK MediaCodec_:3753 map pfn RAM range req > write-combining for [mem 0x1e7a8-0x1e7a87fff], got write-back > [ 45.848827] x86/PAT: .vorbis.decode

Re: [PATCH 2/3] Staging: exfat: exfat_super.c: fixed multiple coding style issues with camelcase and parentheses

2019-09-30 Thread Greg KH
On Sun, Sep 29, 2019 at 09:52:29AM -0500, Jesse Barton wrote: > Changed Function Names: > ffsGetVolInfo -> ffs_get_vol_info > ffsLookupFile -> ffs_lookup_file > ffsCreateFile -> ffs_create_file > ffsReadFile -> ffs_read_file > ffsWriteFile -> ffs_write_file > ffsTruncateFile -> ffs_truncate_file >

Re: [PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues.

2019-09-30 Thread Greg KH
On Sun, Sep 29, 2019 at 09:52:45AM -0500, Jesse Barton wrote: > Removed function argument wrapping to new line. I don't think you "removed" anything here :( Writing the changelog is usually harder than writing the patch in the first place, welcome to programming! :) thanks, greg k-h __

Re: [PATCH 1/3] Staging: exfat: exfat_super.c: fixed camelcase coding style issue

2019-09-30 Thread Greg KH
On Sun, Sep 29, 2019 at 09:50:57AM -0500, Jesse Barton wrote: > Changed function names: > ffsUmountVol to ffs_umount_vol > ffsMountVol to ffs_mount_vol > ffsSyncVol to ffs_sync_vol > > That says _what_ you did, but not _why_ you are doing this. And is this really the best name for these functio

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-30 Thread &#x27;Greg KH'
On Mon, Sep 30, 2019 at 01:25:13PM +0900, Namjae Jeon wrote: > > > [..] > > > Put it in drivers/staging/sdfat/. > > > > > > But really we want someone from Samsung to say that they will treat > > > the staging version as upstream. It doesn't work when people apply > > > fixes to their version and

Re: [RESEND PATCH] staging: rtl8192u: Fix indentation for cleaner code

2019-10-02 Thread Greg KH
On Wed, Oct 02, 2019 at 03:49:04PM +0530, Sumera Priyadarsini wrote: > On Tue, Sep 24, 2019 at 8:47 PM Greg KH wrote: > > > > On Fri, Sep 13, 2019 at 11:31:01PM +0530, Sumera Priyadarsini wrote: > > > Fixes indentation for if condition in the file r8190_rtl8256.c for bett

Re: [PATCH] staging: greybus: add blank line after declarations

2019-10-06 Thread Greg KH
On Sat, Oct 05, 2019 at 06:00:46PM -0300, Gabriela Bittencourt wrote: > Fix CHECK: add blank line after declarations > > Signed-off-by: Gabriela Bittencourt > --- > drivers/staging/greybus/control.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/greybus/control.h > b/

Re: [Outreachy kernel] [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

2019-10-06 Thread Greg KH
On Sun, Oct 06, 2019 at 09:01:09PM +0200, Julia Lawall wrote: > > > On Sun, 6 Oct 2019, Jules Irenge wrote: > > > Capitalize RANGE_mA to fix camelcase check warning. > > Issue reported by checkpatch.pl > > I guess mA means something, so it would be better to keep it? Yes it does, we need to ke

Re: [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

2019-10-06 Thread Greg KH
On Sun, Oct 06, 2019 at 07:49:03PM +0100, Jules Irenge wrote: > Capitalize RANGE_mA to fix camelcase check warning. > Issue reported by checkpatch.pl > > Signed-off-by: Jules Irenge > --- > drivers/staging/comedi/comedidev.h | 2 +- > drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++

Re: [PATCH] staging: comedi: Fix camelcase check warning

2019-10-06 Thread Greg KH
On Sun, Oct 06, 2019 at 07:44:53PM +0100, Jules Irenge wrote: > Capitalize unit_ma to fix camelcase check warning. > > Signed-off-by: Jules Irenge > --- > drivers/staging/comedi/comedi.h| 4 ++-- > drivers/staging/comedi/comedidev.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-)

<    1   2   3   4   5   6   7   8   9   10   >