On 24 April 2015 at 15:46, Gujulan Elango, Hari Prasath (H.)
hguju...@visteon.com wrote:
This patch avoids creating two variables in the final assembly output
i.e. a string and a pointer to the string.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging
On 30 April 2015 at 19:44, gre...@linuxfoundation.org
gre...@linuxfoundation.org wrote:
On Thu, Apr 23, 2015 at 04:09:28PM +0100, Alan Cox wrote:
On Thu, 2015-04-23 at 13:43 +, Gujulan Elango, Hari Prasath (H.)
wrote:
This patch removes unwanted semicolon around close braces of code
On 30 April 2015 at 19:54, gre...@linuxfoundation.org
gre...@linuxfoundation.org wrote:
On Fri, Apr 24, 2015 at 07:52:31AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
The fops structure is referenced only locally and hence could be made static
Signed-off-by: Hari Prasath Gujulan Elango
On 9 June 2015 at 13:00, Gujulan Elango, Hari Prasath (H.)
hguju...@visteon.com wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Cleanup the device entry,device class unregister the character device
in the module exit.All this cleanup is done already in the dgap_stop
Remove explicit typecasting of return value in the interrupt handlers.
Signed-off-by: Hari Prasath <geharipras...@gmail.com>
---
drivers/staging/pi433/pi433_if.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging
Adding missing indio_dev->dev.of_node references to allow iio consumers
to access the device channels.
Signed-off-by: Hari Prasath <geharipras...@gmail.com>
---
v2: Wrong from email ID in first version of patch
---
drivers/staging/iio/adc/ad7192.c | 1 +
drivers/staging/iio/adc
From: Hari Prasath <hguju...@visteon.com>
Adding missing indio_dev->dev.of_node references to allow iio consumers
to access the device channels.
Signed-off-by: Hari Prasath <geharipras...@gmail.com>
---
drivers/staging/iio/adc/ad7192.c | 1 +
drivers/staging/iio/adc/ad7780.c
Kindly discard this patch versions. I will send a new one.
On 17 July 2017 at 17:49, Hari Prasath <geharipras...@gmail.com> wrote:
> Adding missing indio_dev->dev.of_node references to allow iio consumers
> to access the device channels.
>
> Signed-off-by: Hari Prasath <
Adding missing indio_dev->dev.of_node references to allow iio consumers
to access the device channels.
Signed-off-by: Hari Prasath <geharipras...@gmail.com>
---
v2: Wrong from mail ID in first version of patch
---
drivers/staging/iio/adc/ad7192.c | 1 -
drivers/staging/iio/adc
dio_dev->dev.of_node = indio_dev->dev.parent->of_node;
>
> - Lars
>
> On 07/17/2017 02:34 PM, Hari Prasath wrote:
>> Adding missing indio_dev->dev.of_node references to allow iio consumers
>> to access the device channels.
>>
>> Signed-off-by: Ha
On 8 July 2017 at 16:31, Sakari Ailus <sakari.ai...@iki.fi> wrote:
> Hi Hari,
>
> On Fri, Jul 07, 2017 at 08:15:21PM +0530, Hari Prasath wrote:
>> kstrdup kernel primitive can be used to replace kmalloc followed by
>> string copy. This was reported by coccinelle too
On 10 July 2017 at 01:22, Sakari Ailus <sakari.ai...@iki.fi> wrote:
> On Sun, Jul 09, 2017 at 05:56:15PM +0530, hari prasath wrote:
>> On 8 July 2017 at 16:31, Sakari Ailus <sakari.ai...@iki.fi> wrote:
>> > Hi Hari,
>> >
>> > On Fri, Jul
kstrdup kernel primitive can be used to replace kmalloc followed by
string copy. This was reported by coccinelle tool.
Signed-off-by: Hari Prasath <geharipras...@gmail.com>
---
v1: Replace kmalloc followed by memcpy with kmemdup. Based on
review comments from Al
kmemdup can be used to replace kmalloc followed by a memcpy.This was
pointed out by the coccinelle tool.
Signed-off-by: Hari Prasath <geharipras...@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
On 07-Jul-2017 5:25 PM, "Alan Cox" <a...@linux.intel.com> wrote:
On Fri, 2017-07-07 at 17:20 +0530, Hari Prasath wrote:
> kmemdup can be used to replace kmalloc followed by a memcpy.This was
> pointed out by the coccinelle tool.
And kstrdup could do the job even better I
kstrdup kernel primitive can be used to replace kmalloc followed by
string copy. This was reported by coccinelle tool
Signed-off-by: Hari Prasath <geharipras...@gmail.com>
---
.../media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 10 +++---
1 file changed, 3 insertions
Fix checkpatch warning to add space around the substraction operation
Signed-off-by: Hari Prasath <geharipras...@gmail.com>
---
drivers/staging/iio/adc/ad7280a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c
b/drivers/staging/i
On 3 August 2017 at 18:53, Dan Carpenter <dan.carpen...@oracle.com> wrote:
> On Thu, Aug 03, 2017 at 06:23:54PM +0530, hari prasath wrote:
>> On 3 August 2017 at 11:52, kbuild test robot <l...@intel.com> wrote:
>> > Hi Hari,
>> >
>> > [auto build tes
rop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Hari-Prasath/Remove-explicit-return-type-cast/20170803-080312
> config: blackfin-allyesconfig (attached as .config)
> compiler: bfin-uclinux-gcc (GCC) 6.2.0
> reproduce:
>
This patch removes a few lines of code retains the same functionality
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers
This patch removes few lines of commented code.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/emxx_udc/emxx_udc.c | 33 -
1 file changed, 33 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging
This patch removes a stray semicolon around closing brace of an if code
block.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/emxx_udc/emxx_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b
This patch removes commented code from this driver.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/comedi/drivers/gsc_hpdi.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/gsc_hpdi.c
b/drivers/staging/comedi/drivers
This patch avoids creating two variables in the final assembly output
i.e. a string and a pointer to the string.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
This patch replaces the condition check for time elapsed with a
simplified time_before() macro
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
This patch replaces a condition check for time elapsea with a
simple time_after macro
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e
This patch removes unwanted semicolon around close braces of code blocks
Signed-off-by: Hari Prasath hguju...@visteon.com
---
drivers/staging/i2o/iop.c | 44 ++--
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/i2o/iop.c b
The fops structure is referenced only locally and hence could be made static
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/mdc
The return value of memdup_user is a pointer to errno.Freeing it will cause
error.Hence set it to NULL before branching to free the pointer.smatch also
raises the same warning.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 1
The return value of memdup_user is a pointer to errno.Freeing it will cause
error.Hence set it to NULL before branching to free the pointer.smatch also
raises the same warning.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2:Remove unnecessary goto and return error
From: Dan Carpenter dan.carpen...@oracle.com
Sent: Thursday, April 30, 2015 12:45 PM
To: Gujulan Elango, Hari Prasath (H.)
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr;
florian.c.schilha...@googlemail.com; gre...@linuxfoundation.org; Babu
The return value of memdup_user is a pointer to errno.Freeing it will cause
error.Hence set it to NULL before branching to free the pointer.smatch also
raises the same warning.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2:Remove unnecessary goto and return error
From: gre...@linuxfoundation.org gre...@linuxfoundation.org
Sent: Thursday, April 30, 2015 3:05 PM
To: Gujulan Elango, Hari Prasath (H.)
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr; dan.carpen...@oracle.com;
larry.fin...@lwfinger.net; florian.c.schilha...@googlemail.com; Babu
return error directly to avoid unwanted branching where no cleanup
is done.Also removes the ret variable.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff
the equivalent negative number as
per Larry Finger.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
b/drivers/staging
Check the return value of function and handle error condition appropriately.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/iio/accel/lis3l02dq_core.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/iio/accel/lis3l02dq_core.c
b
Should return ENOMEM if memory allocation occurs.There is a wrong code
jump here and this patch addresses this issue.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/comedi/comedi_fops.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff
From: Dan Carpenter dan.carpen...@oracle.com
Sent: Thursday, April 30, 2015 6:33 PM
To: Gujulan Elango, Hari Prasath (H.)
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr;
gre...@linuxfoundation.org; wlan...@realtek.com; mateusz.kulikow...@gmail.com;
Babu, Viswanathan (V.); larry.fin
From: Larry Finger larry.fin...@gmail.com on behalf of Larry Finger
larry.fin...@lwfinger.net
Sent: Thursday, April 30, 2015 11:03 PM
To: Gujulan Elango, Hari Prasath (H.); Dan Carpenter
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr;
gre...@linuxfoundation.org; wlan...@realtek.com
On Thu, Apr 30, 2015 at 02:09:13PM -0500, Larry Finger wrote:
On 04/30/2015 12:50 PM, Gujulan Elango, Hari Prasath (H.) wrote:
From: Larry Finger larry.fin...@gmail.com on behalf of Larry Finger
larry.fin...@lwfinger.net
Sent: Thursday, April 30, 2015 11:03 PM
To: Gujulan Elango, Hari
On Fri, May 01, 2015 at 10:46:53AM +0300, Dan Carpenter wrote:
The subject says fix but this does not fix a run time bug, it just
silences a warning. It's still the correct thing according to Larry
so that's good.
On Thu, Apr 30, 2015 at 12:06:28PM +, Gujulan Elango, Hari Prasath (H
This patch addresses a spatch warning on assigning a negative
value to a unsigned integer.Similar patch has been submitted by
Larry Finger earlier to silence the same spatch warning in another
file.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2: Address Dan
From: Julia Lawall julia.law...@lip6.fr
Sent: Thursday, April 30, 2015 12:12 AM
To: Gujulan Elango, Hari Prasath (H.)
Cc: sh...@linux.com; cristina.oprice...@gmail.com; hamohammed...@gmail.com;
vitaly.osi...@gmail.com; de...@driverdev.osuosl.org
Subject: Re: [PATCH] staging: rtl8712: Fix freeing
This patch replaces a condition check for time elapsed with a
simple time_after macro
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2:Fixes a build warning.time_after() macro requires both of
its arguments to be unsigned long.Build warning was missed later
reported
On Thu, May 07, 2015 at 03:19:34PM +0300, Dan Carpenter wrote:
On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
Gujulan Elango, Hari Prasath (H.) hguju...@visteon.com writes:
Remove the goto and return error directly thereby removing a variable
Signed-off-by: Hari Prasath
This patch replaces the condition check for time elapsed with a
simplified time_before() macro
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2:Fixes a build warning.time_before() macro requires both of
its arguments to be unsigned long.Build warning was missed
On Tue, May 05, 2015 at 12:19:57PM +0300, Dan Carpenter wrote:
On Mon, May 04, 2015 at 10:17:09PM +0200, Mateusz Kulikowski wrote:
As far as I know (radio) noise is rarely above 0 dBm - if it is, you're
doing something wrong.
This means we can just change rtllib_rx_stats::noise to s8.
I
Remove the goto and return error directly thereby removing a variable
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723au/os_dep
check return value of kmalloc before accessing the memory pointer.This
function returns a non-zero value on failure hence a return value of 1
is used.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wlan-ng/p80211conv.c | 2 ++
1 file changed, 2 insertions
check the return value of kzalloc before accessing the memory pointer
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/lustre/lustre/llite/llite_lib.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c
b
On Wed, May 13, 2015 at 03:02:25PM +0300, Dan Carpenter wrote:
On Wed, May 13, 2015 at 02:51:07PM +0300, Dan Carpenter wrote:
On Wed, May 13, 2015 at 11:32:50AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
check return value of kmalloc before accessing the memory pointer.This
check return value of kmalloc before accessing the memory pointer and
return -ENOMEM if allocation fails.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2:Return -ENOMEM for memory allocation failure.
---
drivers/staging/wlan-ng/p80211conv.c | 2 ++
1 file changed
On Wed, May 13, 2015 at 05:27:10PM +0300, Dan Carpenter wrote:
On Wed, May 13, 2015 at 01:36:44PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
On Wed, May 13, 2015 at 03:02:25PM +0300, Dan Carpenter wrote:
On Wed, May 13, 2015 at 02:51:07PM +0300, Dan Carpenter wrote:
On Wed, May 13
On Thu, May 07, 2015 at 10:09:59AM -0400, Jes Sorensen wrote:
Gujulan Elango, Hari Prasath (H.) hguju...@visteon.com writes:
On Thu, May 07, 2015 at 03:19:34PM +0300, Dan Carpenter wrote:
On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
Gujulan Elango, Hari Prasath (H.) hguju
Use a temporary value to hold the SD lock status thereby making the code
readable.This also fixes a coding style violation with the braces around
the if block.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rts5208/sd.c | 7 ---
1 file changed, 4
This trivial patch removes temporary variable to check return value of
a function and checks return value directly.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rts5208/ms.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers
replace the hard coded value for the maximum sequence number of a ieee
802.11 frame by a Macro.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8192e/rtllib_tx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
This macro defines the maximum sequence number for an IEEE802.11 frame.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8192e/rtllib.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers/staging/rtl8192e/rtllib.h
On Mon, May 18, 2015 at 03:47:58PM +0300, Dan Carpenter wrote:
Fold this together with the other patch. Do 1 thing per patch, not half
a thing per patch. This change makes no sense on its own.
regards,
dan carpenter
I didn't think of it. I am sending v2 with both the related changes as
On Fri, May 15, 2015 at 04:09:42PM +0300, Dan Carpenter wrote:
On Fri, May 15, 2015 at 12:09:42PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
Use a temporary value to hold the SD lock status thereby making the code
readable.This also fixes a coding style violation with the braces around
Fixed indentation issue in few lines.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8712/recv_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/recv_linux.c
b/drivers/staging/rtl8712/recv_linux.c
remove an unwanted assignment to a variable which is overwritten in the
very next line.The first value assigned is not used.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
The return value of copy_to_user() isn't checked for failure.Hence
return -EFAULT if it fails.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/lustre/lustre/lov/lov_pack.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers
On Thu, May 14, 2015 at 12:47:19PM +0300, Dan Carpenter wrote:
On Thu, May 14, 2015 at 09:22:01AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
The return value of copy_to_user() isn't checked for failure.Hence
return -EFAULT if it fails.
Signed-off-by: Hari Prasath Gujulan Elango
On Mon, May 18, 2015 at 10:29:55PM +0200, Mateusz Kulikowski wrote:
Hi,
On 18.05.2015 13:27, Gujulan Elango, Hari Prasath (H.) wrote:
replace the printk with netdev subsystem debug infrastructure.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging
replace the printk with netdev subsystem debug infrastructure.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c
b/drivers/staging
On Tue, Jun 02, 2015 at 11:32:00AM +0530, Sudip Mukherjee wrote:
On Mon, Jun 01, 2015 at 10:38:10AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Gujulan Elango Hari Prasath hguju...@visteon.com
Remove the unwanted else block
i think you need to refresh your tree
On Tue, Jun 02, 2015 at 12:38:26PM +0530, Sudip Mukherjee wrote:
On Tue, Jun 02, 2015 at 06:59:38AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
On Tue, Jun 02, 2015 at 11:32:00AM +0530, Sudip Mukherjee wrote:
On Mon, Jun 01, 2015 at 10:38:10AM +, Gujulan Elango, Hari Prasath
(H
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Cleanup the device entry,device class unregister the character device
in the module exit.All this cleanup is done already in the dgap_stop()
function.We need to call this in the cleanup module.
Signed-off-by: Hari Prasath Gujulan Elango
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Cleanup the device entry,device class unregister the character device
in the module exit.All this cleanup is done already in the dgap_stop()
function.We need to call this in the cleanup module.
Signed-off-by: Hari Prasath Gujulan Elango
On Mon, Jun 08, 2015 at 01:29:30PM -0700, gre...@linuxfoundation.org wrote:
On Mon, Jun 01, 2015 at 01:06:15PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch deletes all references to 'flipbuf'.Memory is allocated
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch fixes a build warning related to the use of the time_after_eq
macro.Adding a typecast to the second argument suppresses the
warning.This warning was created by one my previous patch.
Signed-off-by: Hari Prasath Gujulan Elango
effort to check this doesn't happen.
Thanks Regards
Hari Prasath
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Remove commented code from this file.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 117 --
1 file changed, 117 deletions(-)
diff --git a/drivers
From: Hari Prasath Gujulan Elango hguju...@visteon.com
The function WILC_WFI_InitPriv() is not used anywhere in the
driver.Hence remove it.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 23 ---
1 file
way of doing things.I read your other email and it sounds better
of way cleaning up.Thanks for your comments.I would have to send a new
patch anyways.
Regards
Hari Prasath
___
devel mailing list
de...@linuxdriverproject.org
http
On Tue, Jun 09, 2015 at 04:41:33PM +0300, Dan Carpenter wrote:
On Tue, Jun 09, 2015 at 10:54:02AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
On Tue, Jun 09, 2015 at 03:32:20PM +0530, Sudip Mukherjee wrote:
On Tue, Jun 09, 2015 at 09:27:22AM +, Gujulan Elango, Hari Prasath
(H
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Deleting obvious comments
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/dgap/dgap.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index
On Tue, Jun 09, 2015 at 10:41:18AM -0700, gre...@linuxfoundation.org wrote:
On Tue, Jun 09, 2015 at 06:43:59AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch fixes a build warning related to the use of the time_after_eq
From: Hari Prasath Gujulan Elango hguju...@visteon.com
The driver remove function is not the right place to cleanup resources
allocated in the driver module init.The cleanup is moved from remove
function to module exit as appropriate.
Signed-off-by: Hari Prasath Gujulan Elango hguju
On Wed, Jun 10, 2015 at 01:01:20AM +0300, Dan Carpenter wrote:
On Tue, Jun 09, 2015 at 05:27:00PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Deleting obvious comments
Signed-off-by: Hari Prasath Gujulan Elango hguju
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch fixes a build warning related to the use of the time_after_eq
macro.Adding a typecast to the second argument suppresses the
warning.This warning was created by one my previous patch.
Signed-off-by: Hari Prasath Gujulan Elango
On Tue, Jun 09, 2015 at 10:26:54PM +0300, Dan Carpenter wrote:
On Tue, Jun 09, 2015 at 05:26:01PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
The driver remove function is not the right place to cleanup resources
allocated
From: Hari Prasath Gujulan Elango hguju...@visteon.com
The driver remove function is not the right place to cleanup resources
allocated in the driver module init.The cleanup is moved from remove
method to module exit as appropriate.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch deletes the comments secion which is obvious and outdated
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2:Addrressed Dan carpenter review comments to remove the entire
comments section as its
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch silences the checkpatch warning 'min() should
probably be min_t'
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/lustre/lnet/selftest/rpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch modifies few debug prints from pr_err() to pr_info() as they
fall under that category.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/sm750fb/sm750.c | 6 +++---
1 file changed, 3 insertions
From: Hari Prasath Gujulan Elango hguju...@visteon.com
The memory allocated in dgnc_tty_register() for two objects is not freed
anywhere.This patch addresses this by freeing the memory in
dgnc_tty_uninit.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/dgnc
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch fixes a typo in the comments section as warned by
checkpatch.pl
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/dgnc/dgnc_driver.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
added this patch.I will ensure not to miss him next time.
On Thu, Jun 18, 2015 at 01:27:28PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
The memory allocated in dgnc_tty_register() for two objects is not freed
anywhere.This patch
On Monday 22 June 2015 08:46 PM, Dan Carpenter wrote:
On Thu, Jun 18, 2015 at 12:56:54PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch modifies few debug prints from pr_err() to pr_info() as they
fall under that category
On Tuesday 23 June 2015 02:07 PM, Dan Carpenter wrote:
On Mon, Jun 22, 2015 at 04:48:01AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch fixes a typo in the debug statement
Signed-off-by: Hari Prasath Gujulan Elango hguju
On Tuesday 23 June 2015 02:16 PM, Dan Carpenter wrote:
On Mon, Jun 22, 2015 at 07:26:25AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
@@ -122,7 +121,7 @@ void setChipClock(unsigned int frequency)
* Sometime, the chip cannot set up the exact clock required by
User
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes the redundant __func__ from dynamic debug prints as
the pr_xxx set of functions can be dynamically controlled to include
function name as well.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes a couple of ununsed variable.The lines in which these
variables are assigned are also removed as they are not necessary.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes ununsed variable 'ret'.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/wilc_wlan.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch the removes the redundant assignement of the variable ret as
its being overwritren before being used anywhere.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/wilc_wlan.c | 2 +-
1
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes a unused variable timeout and the associated code.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/linux_wlan.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes ununsed if..else... code blocks. Its actually some
dead code.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/coreconfigurator.c | 22 --
1 file changed, 22
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes a unused variable 'u16RespLen' that is assigned a
value that is never used. The line that does the assignment is also
removed.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000
1 - 100 of 222 matches
Mail list logo
