[PATCH for 3.18] staging: r8188eu: Fix scheduling while atomic error introduced in commit fadbe0cd

are rtw_joinbss_cmd(), rtw_dynamic_chk_wk_cmd(), rtw_lps_ctrl_wk_cmd(), rtw_rpt_timer_cfg_cmd(), rtw_ps_cmd(), report_survey_event(), report_join_res(), survey_timer_hdl(), and rtw_check_bcn_info(). Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: navin patidar navin.pati...@gmail.com --- drivers

Re: [PATCH] staging: rtl8712: fix coding style warning

On 11/15/2014 08:25 AM, Christian Resell wrote: Simple style fix (else is not generally useful after a break or return). For the eudyptula challenge (http://eudyptula-challenge.org/). Signed-off-by: Christian F. Resell christian.res...@gmail.com --- This patch leads to the following build

Re: [PATCH] staging: rtl8723au: hal: Removed spaces before starting of a line

On 12/01/2014 09:53 AM, Anjana Sasindran wrote: This patch fix the checkpatch.pl warning: WARNING: please, no spaces at the start of a line Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com --- drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 6 +++--- 1 file changed, 3

Re: [PATCH 1/1] staging: rtl8188eu: usb_dvobj_init(): A NULL pointer check for usb_host_endpoints makes no sense

--- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 33 + 1 file changed, 15 insertions(+), 18 deletions(-) Acked-by: Larry Finger larry.fin...@lwfinger.net Thanks for porting your changes found in one of the Realtek drivers. Larry diff --git a/drivers/staging

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

On 12/11/2014 04:23 PM, Krzysztof Konopko wrote: Some struct fields in wifi.h are meant to be __le16 bu were declared as unsigned short. This was reported by sparse: rtw_wlan_util.c:538:24: warning: cast to restricted __le16 rtw_wlan_util.c:1544:29: warning: cast to restricted __le16

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

On 12/12/2014 06:52 AM, Dan Carpenter wrote: On Thu, Dec 11, 2014 at 05:53:30PM -0600, Larry Finger wrote: On 12/11/2014 04:23 PM, Krzysztof Konopko wrote: Some struct fields in wifi.h are meant to be __le16 bu were declared as unsigned short. This was reported by sparse: rtw_wlan_util.c

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

On 12/12/2014 05:35 AM, Krzysztof Konopko wrote: On 12/12/14 00:53, Larry Finger wrote: This fix may make the sparse warnings go away, but I think it introduces new bugs. Right, I see. Nice try though, isn't it? ;) In particular, did you test on big-endian hardware after you made

Re: [PATCH] staging: rtl8723au: Fix sparse warnings

On 12/12/2014 04:50 PM, Krzysztof Konopko wrote: On 12/12/14 18:35, Larry Finger wrote: On 12/12/2014 05:35 AM, Krzysztof Konopko wrote: On 12/12/14 00:53, Larry Finger wrote: In particular, did you test on big-endian hardware after you made this change? Nope. I don't have any big-endian

[PATCH V2] staging: r8188eu: Fix AP mode

Two code lines were accidentally deleted. Restore them. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Stable sta...@vger.kernel.org --- V2 - rewrite silly commit message. drivers/staging/rtl8188eu/core/rtw_ap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging

[PATCH 00/11] staging: r8188eu: Clean up a number of pointless wrappers

Because the original driver was designed to build for Windows, FreeBSD, and Linux, there are wrappers for many of the OS primitives. These patches remove a number of them. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Larry Finger (11): staging: r8188eu: Remove pointless thread_exit

[PATCH 02/11] staging: r8188eu: Remove wrapper around spin_lock_bh

Some comment lines that mentioned spin_lock_bh() are also removed. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_ap.c | 38 drivers/staging/rtl8188eu/core/rtw_br_ext.c | 16 +++ drivers/staging/rtl8188eu/core

[PATCH 06/11] staging: r8188eu: Remove wrapper around spin_lock_init

Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +- drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +- drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++-- drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 8

[PATCH 07/11] staging: r8188eu: Remove calls to _rtw_spinlock_free

This wrapper does nothing on Linux. When calls to it were removed, a number of routines became empty and could also be removed. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_ap.c | 2 - drivers/staging/rtl8188eu/core/rtw_cmd.c

[PATCH 11/11] staging: r8188eu: Replace wrappers ODM_StallExecution, ODM_delay_us, and rtw_udelay_os

Each instance may bre replaced by udelay Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +- drivers/staging/rtl8188eu/hal/HalPwrSeqCmd.c | 6 +++--- drivers/staging/rtl8188eu/hal/odm.c| 10

[PATCH 09/11] staging: r8188eu: Replace wrappers ODM_sleep_ms() and rtw_msleep_os() with a simple msleep

Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ++-- drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 16 drivers/staging/rtl8188eu/core/rtw_mp.c

Re: [PATCH 02/11] staging: r8188eu: Remove wrapper around spin_lock_bh

On 12/20/2013 01:14 AM, Dan Carpenter wrote: On Thu, Dec 19, 2013 at 10:38:34PM -0600, Larry Finger wrote: Some comment lines that mentioned spin_lock_bh() are also removed. Signed-off-by: Larry Finger larry.fin...@lwfinger.net @@ -1509,10 +1509,6 @@ _func_enter_; rtw_p2p_set_state

Re: [PATCH 01/11] staging: r8188eu: Remove pointless thread_exit macro

On 12/20/2013 01:18 PM, Greg KH wrote: On Fri, Dec 20, 2013 at 11:22:35AM -0600, Larry Finger wrote: On 12/20/2013 10:58 AM, Greg KH wrote: With this series applied, I get a ton of unused variable warnings, can you please fix them up now too? Strange, but I don't get any. My compiler is gcc

Re: [PATCH 01/11] staging: r8188eu: Remove pointless thread_exit macro

On 12/20/2013 02:34 PM, Greg KH wrote: Nah, I just switched to 4.8 and rebuilt all of the different kernel trees on this box with it, so I'll stay there for now. The problem wasn't the fault of gcc 4.8. I only use the staging tree to base patches to send to you, and my .config in that

[PATCH 0/2] Fix problems with earlier patches

A recent set of patches revealed that a line of code had been incorrectly removed in an earlier edit. That line is added back. In addition, a configuration problem resulted in a number of unused variable warnings. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Larry Finger (2

[PATCH 2/2] staging: r8188eu: Fix unused variable warnings

block was removed. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_ap.c| 12 drivers/staging/rtl8188eu/core/rtw_debug.c | 1 - drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8 drivers/staging/rtl8188eu/core

[PATCH 1/2] staging: r8188eu: Restore line that was incorrectly removed

A line in the P2P code had been removed in the process of converting the vendor driver to a form suitable for the kernel. The output of this call was ignored, and the initial analysis incorrectly determined that the call had no other effect. Signed-off-by: Larry Finger larry.fin...@lwfinger.net

[RFC] staging: r8188eu: Fix sparse warnings in core/rtw_br_ext.c

Please tell me if the following fixes are appropriate. In particular, I am uncertain of the __force attributes. Thanks, Larry Sparse lists the following: CHECK drivers/staging/rtl8188eu/core/rtw_br_ext.c drivers/staging/rtl8188eu/core/rtw_br_ext.c:1156:63: warning: restricted __sum16

[PATCH 01/31] staging: r8188eu: Replace wrappers ODM_sleep_us and rtw_usleep_os

Each of the uses in the code asks for a sleep of 100 usec or so. On Linux, these are converted to msleep(1). Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +- drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers

[PATCH 07/31] staging: r8188eu: Replace wrappers for atomic_inc and atomic_inc_return

Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 12 ++-- drivers/staging/rtl8188eu/include/osdep_service.h | 4 drivers/staging/rtl8188eu/include/usb_ops.h | 2 +- drivers/staging/rtl8188eu/os_dep/osdep_service.c

[PATCH 02/31] staging: r8188eu: Replace wrapper rtw_yield_os

a simple yield() is sufficient. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 2 -- drivers/staging/rtl8188eu/os_dep

[PATCH 11/31] staging: r8188eu: Remove wrapper around mutex_destroy

Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 1 - drivers/staging/rtl8188eu/os_dep/osdep_service.c | 5 - drivers/staging/rtl8188eu/os_dep/usb_intf.c | 4 ++-- 4

[PATCH 08/31] staging: r8188eu: Remove daemonize conditional

The current kernels do not include this entry point. Delete the call. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/include/osdep_service.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers

[PATCH 03/31] staging: r8188eu: Remove wrapper code for rtw_suspend_lock_init, rtw_suspend_lock_uninit, rtw_lock_suspend, and rtw_unlock_suspend

All of these routines are empty. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/include/osdep_service.h | 5 - drivers/staging/rtl8188eu/os_dep/osdep_service.c | 16 drivers/staging/rtl8188eu/os_dep/rtw_android.c| 2 -- drivers

[PATCH 05/31] staging: r8188eu: Replace wrapper around atomic_set()

Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 1 - drivers/staging/rtl8188eu/include/usb_ops.h | 2 +- drivers

[PATCH 20/31] staging: r8188eu: Remove even more empty routines

-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm.c | 56 - drivers/staging/rtl8188eu/hal/odm_HWConfig.c| 4 +- drivers/staging/rtl8188eu/include/odm.h | 4 -- drivers/staging/rtl8188eu/include/odm_precomp.h | 7 4

[PATCH 15/31] staging: r8188eu: Remove macro ODM_GetRFReg

This one is a duplicate od macro PHY_QueryRFReg. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 4 ++-- drivers/staging/rtl8188eu/hal/odm.c | 4 ++-- drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers

[PATCH 21/31] staging: r8188eu: Simplify code concerning SupportPlatform

This member of struct odm_dm_struct is always set to ODM_CE in this driver. As a result, a number of switch and if statements can be simplified. In addition, a number of routines are no longer used and can be removed. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging

[PATCH 14/31] staging: r8188eu: Remove macro ODM_SetRFReg

It is a duplicate of macro PHY_SetRFReg. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 32 +++--- drivers/staging/rtl8188eu/hal/odm.c| 8 +++--- drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c

[PATCH 28/31] staging: r8188eu: Fix sparse warning in core/rtw_pwrctrl.c

Sparse reports the following: CHECK drivers/staging/rtl8188eu/core/rtw_pwrctrl.c drivers/staging/rtl8188eu/core/rtw_pwrctrl.c:525:6: warning: symbol 'rtw_free_pwrctrl_priv' was not declared. Should it be static? That routine is not used and has been deleted. Signed-off-by: Larry Finger

[PATCH 18/31] staging: r8188eu: Remove - number of dummy and unused routines

These routines include: ODM_StartWorkItem() ODM_StopWorkItem() ODM_FreeWorkItem() ODM_ScheduleWorkItem() ODM_IsWorkItemScheduled() Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm_interface.c | 20 drivers/staging/rtl8188eu

[PATCH 19/31] staging: r8188eu: Remove more empty routines

This batch includes ODM_StartWorkItem ODM_StopWorkItem ODM_FreeWorkItem ODM_AcquireSpinLoc ODM_ReleaseSpinLock ODM_ReleaseTimer ODM_ReleaseAllTimers Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm.c | 7 --- drivers/staging

[PATCH 17/31] staging: r8188eu: Remove macro ODM_GetMACReg

This is equivalent to PHY_GetBBReg. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 8 drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers/staging/rtl8188eu/include/odm_interface.h | 2 -- 3 files changed, 4

[PATCH 29/31] staging: r8188eu: Fix sparse warning in core/rtw_xmit.c

] *fctrl drivers/staging/rtl8188eu/core/rtw_xmit.c:809:23:got restricted __le16 *noident Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c

[PATCH 13/31] staging: r8188eu: Remove macro ODM_GetBBReg

This one is a duplicate of PHY_QueryBBReg. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 68 +++ drivers/staging/rtl8188eu/hal/odm.c | 49 drivers/staging/rtl8188eu/hal

[PATCH 31/31] staging: r8188eu: Fix smatch error

Smatch shows the following: CHECK drivers/staging/rtl8188eu/core/rtw_mlme_ext.c drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1401 OnAssocReq() error: buffer overflow 'pstapriv-sta_aid' 32 = 32 Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core

[PATCH 26/31] staging: r8188eu: Eliminate enum ODM_RADIO_PATH in favor of rf_radio_path

There are two different enum statements that have been combined. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c | 4 +-- drivers/staging/rtl8188eu/hal/odm_HWConfig.c | 32 +++--- drivers/staging/rtl8188eu/hal

[PATCH 09/31] staging: r8188eu: Replace wrapper around sema_init

Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 6 +++--- drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +- drivers/staging/rtl8188eu/core/rtw_xmit.c | 6 +++--- drivers/staging/rtl8188eu/include/osdep_service.h | 1

[PATCH 06/31] staging: r8188eu: Remove unused atomic_xxx wrappers

Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/include/osdep_service.h | 7 - drivers/staging/rtl8188eu/os_dep/osdep_service.c | 35 --- 2 files changed, 42 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h

[PATCH 16/31] staging: r8188eu: Remove macro ODM_SetMACReg

This is the same as macro PHY_SetBBReg. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 14 +++--- drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers/staging/rtl8188eu/include/odm_interface.h | 3 --- 3

[PATCH 25/31] staging: r8188eu: Cleanup of include/hal_intf.h

This driver only handles RTL8188EU with USB interface, thus several hardware defines and macros can be removed. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 -- drivers/staging/rtl8188eu/hal/rtl8188e_mp.c | 18

[PATCH 23/31] staging: r8188eu: Remove unneeded prototypes from include/odm.h

This header contains a number of routines that do not to be available globally. Once this change was made, a number of the routines were not used, and could be removed. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm.c | 67

[PATCH 22/31] staging: r8188eu: Simplify code related to SupportICType

This member of struct odm_dm_struct is always set to ODM_RTL8188E for this driver. Accordingly, the code can be simplified. A number of routines now are no longer needed and are deleted. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- .../staging/rtl8188eu/hal/Hal8188ERateAdaptive.c

[PATCH 10/31] staging: r8188eu: Remove wrappers _rtw_free_sema, _rtw_up_sema, and _rtw_mutex_init

Any routines that are empty as a result of these changes are also removed. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 11 --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 7 --- drivers/staging/rtl8188eu/core

[PATCH 24/31] staging: r8188eu: Additional cleanup of include/odm.h

-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm.c | 12 +--- drivers/staging/rtl8188eu/hal/odm_HWConfig.c | 35 +++ drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 5 +--- drivers/staging/rtl8188eu/include/odm.h

Re: [PATCH 3/7] staging: rtl8188eu: Drop print of build date/time

(); Acked-by: Larry Finger larry.fin...@lwfinger.net Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: r8712u: Set device type to wlan

The latest version of NetworkManager does not recognize the device as wireless without this change. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Stable sta...@vger.kernel.org --- drivers/staging/rtl8712/usb_intf.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers

Re: [PATCH] Staging: rtl8188eu: Fixed coding style issues

deletions(-) Acked-by: Larry Finger larry.fin...@lwfinger.net Larry diff --git a/drivers/staging/rtl8188eu/include/rtw_io.h b/drivers/staging/rtl8188eu/include/rtw_io.h index eb6f0e5..3d1dfcc 100644 --- a/drivers/staging/rtl8188eu/include/rtw_io.h +++ b/drivers/staging/rtl8188eu/include/rtw_io.h

Re: [PATCH] Staging: rtl8188eu: Fixed coding style issues

On 01/02/2014 11:03 AM, Tim Jester-Pfadt wrote: Fixed indentation coding style issues on rtw_io.c Signed-off-by: Tim Jester-Pfadt t...@gmx.de --- drivers/staging/rtl8188eu/core/rtw_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2] Staging: rtl8188eu: Fixed coding style issues

On 01/02/2014 02:46 PM, Tim Jester-Pfadt wrote: Fixed indentation coding style issues on rtw_io.c Signed-off-by: Tim Jester-Pfadt t...@gmx.de --- drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [PATCH 31/31] staging: r8188eu: Fix smatch error

On 01/02/2014 02:44 AM, Dan Carpenter wrote: On Sun, Dec 22, 2013 at 05:37:02PM -0600, Larry Finger wrote: Smatch shows the following: CHECK drivers/staging/rtl8188eu/core/rtw_mlme_ext.c drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1401 OnAssocReq() error: buffer overflow 'pstapriv

Re: [patch] staging: r8821ae: a couple macro expansion bugs

On 01/28/2014 09:01 AM, Greg Kroah-Hartman wrote: On Tue, Jan 28, 2014 at 05:46:30PM +0300, Dan Carpenter wrote: On Tue, Jan 28, 2014 at 03:14:21PM +0100, walter harms wrote: Am 28.01.2014 15:00, schrieb Dan Carpenter: These macros need parentheses, otherwise it causes a macro expansion bug

[PATCH] staging: r8188eu: Fix typo in USB_DEVICE list

There is a typo in the device list that interchanges the vendor and product codes for one of the entries. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

Re: [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list

On 02/02/2014 03:04 PM, Randy Dunlap wrote: On 02/02/2014 12:07 PM, Larry Finger wrote: There is a typo in the device list that interchanges the vendor and product codes for one of the entries. You also changed 0x7b8 to 0x7bb. Did you mean to do that? No, I did not. Thanks for catching

Re: [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list

On 02/02/2014 03:26 PM, Greg KH wrote: On Sun, Feb 02, 2014 at 02:07:06PM -0600, Larry Finger wrote: There is a typo in the device list that interchanges the vendor and product codes for one of the entries. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu

Re: rtl8821ae.

On 02/02/2014 12:07 PM, Stefan Lippers-Hollmann wrote: Hi [ CC'ing the relevant parties ] On Sunday 02 February 2014, Dave Jones wrote: On Sun, Feb 02, 2014 at 03:41:27AM -0800, scan-ad...@coverity.com wrote: Please find the latest report on new defect(s) introduced to Linux found with

Re: rtl8821ae.

On 02/04/2014 08:41 AM, Andrea Merello wrote: Yes, I attach a cumulative patch for latest version of my work. When I will send this asking for merge in kernel, I will split it in some patches, because I also also included fix and improvements for other already supported cards (not directly

[PATCH 08/12] staging: r8188eu: Remove wrappers around vfree

Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 5 ++--- drivers/staging/rtl8188eu/core/rtw_mp.c | 2 +- drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +- drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 2

[PATCH 11/12] staging: r8188eu: Remove ODM_SetTimer

This wrapper is not used. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm_interface.c | 5 - drivers/staging/rtl8188eu/include/odm_interface.h | 2 -- 2 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_interface.c

[PATCH 12/12] staging: r8188eu: Remove ODM_InitializeTimer

This wrapper is not used. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm_interface.c | 8 drivers/staging/rtl8188eu/include/odm_interface.h | 4 2 files changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal

[PATCH 05/12] staging: r8188eu: Remove ODM_Write2Byte

This routine is the equivalent of rtw_write16. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 4 +++- drivers/staging/rtl8188eu/hal/odm_interface.c| 6 -- drivers/staging/rtl8188eu/include/odm_interface.h| 2 -- 3

Re: [patch 1/2] staging: r8188eu: array overflow in rtw_mp_ioctl_hdl()

On 02/03/2014 04:38 PM, Dan Carpenter wrote: MAX_MP_IOCTL_SUBCODE (35) and mp_ioctl_hdl (32 elements) are no longer in sync. It leads to a bogus pointer dereference. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Acked-by: Larry Finger larry.fin...@lwfinger.net Larry diff --git

[PATCH 06/12] staging: r8188eu: Remove ODM_Write4Byte

This routine is the equivalent of rtw_write32. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 2 +- drivers/staging/rtl8188eu/hal/odm_interface.c | 7 --- drivers/staging/rtl8188eu/include/odm_interface.h | 2 -- 3 files

[PATCH 09/12] staging: r8188eu: Remove ODM_AllocateMemory

This wrapper for vzalloc() is not used. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers/staging/rtl8188eu/include/odm_interface.h | 1 - 2 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal

[PATCH 00/12] Remove several pointless wrapper routines

The driver contains a large number of wrapper routines. None of them are needed. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Larry Finger (12): staging: r8188eu: Remove ODM_Read1Byte staging: r8188eu: Remove ODM_Read2Byte staging: r8188eu: Remove ODM_Read4Byte staging: r8188eu

[PATCH 01/12] staging: r8188eu: Remove ODM_Read1Byte

This is essentially a synonym for rtw_read8. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 6 +++--- drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers/staging/rtl8188eu/include/odm_interface.h | 2 -- 3 files

[PATCH 10/12] staging: r8188eu: Remove ODM_CompareMemory

This routine is a wrapper for _rtw_memcmp(), which is a wrapper for memcmp. In a later change, _rtw_memcmp will be removed. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c| 4 ++-- drivers/staging/rtl8188eu/hal/odm_interface.c | 5

[PATCH 02/12] staging: r8188eu: Remove ODM_Read2Byte

This routine is never used. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm_interface.c | 6 -- drivers/staging/rtl8188eu/include/odm_interface.h | 2 -- 2 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal

[PATCH] staging: r8188eu: Fix missing header

. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 1 + drivers/staging/rtl8188eu/core/rtw_mp.c| 1 + drivers/staging/rtl8188eu/core/rtw_recv.c | 1 + drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 1 + drivers/staging/rtl8188eu

Re: [PATCH] staging: r8188eu: Fix missing header

On 02/07/2014 06:04 PM, Greg KH wrote: On Fri, Feb 07, 2014 at 05:12:10PM -0600, Larry Finger wrote: Commit 2397c6e0927675d983b34a03401affdb64818d07 entitled staging: r8188eu: Remove wrappers around vmalloc and vzalloc and commit: 03bd6aea7ba610a1a19f840c373624b8b0adde0d entitled staging

[PATCH V2] staging: r8188eu: Fix missing header

. This problem was reported by the kbuild test robot. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- V2 - add attribution to the build robot --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 1 + drivers/staging/rtl8188eu/core/rtw_mp.c| 1 + drivers/staging/rtl8188eu/core

Re: [PATCH 1/2] drivers:staging:rtl8821ae: Fixed few coding style erors and warnings

, it will be submitted to the drivers/net/wireless tree of the regular kernel, and it should be there by 3.15. That said, Acked-by: Larry Finger larry.fin...@lwfinger.net Larry --- drivers/staging/rtl8821ae/wifi.h | 450 --- 1 file changed, 226 insertions(+), 224

Re: [PATCH 2/2] vers:staging:rtl8821ae: Fixed multiple coding style erors and warnings

On 02/09/2014 01:30 AM, Surendra Patil wrote: Fixed multiple coding style errors and warnings wifi.h:1077: WARNING: please, no space before tabs wifi.h:762: WARNING: missing space after struct definition wifi.h:972: WARNING: please, no spaces at the start of a line wifi.h:1825: WARNING:

Re: [PATCH] drivers:statging:rtl8821ae Fixed few coding style errors

On 02/09/2014 02:29 AM, Surendra Patil wrote: Fixed few coding style errors in header files base.h:58: WARNING: please, no space before tabs base.h:81: ERROR: (foo*) should be (foo *) pci.h:338: ERROR: foo * bar should be foo *bar pci.h:151: ERROR: do not use C99 // comments Signed-off-by:

[PATCH 0/6] Various cleanups of r8188eu

As has been noted, this driver is very rough. This set of patches is intended to smooth some of the rough edges. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Larry Finger (6): staging: r8188eu: Replace wrapper around _rtw_memcmp() staging: r8188eu: Remove dead file staging

[PATCH 3/6] staging: r8188eu: Remove some dead code from headers

The headers for this driver contain a number of unused structs and macros that are removed. File include/ioctl_cfg80211.h is now empty and was deleted. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/include/ioctl_cfg80211.h | 107

[PATCH] staging: r8188eu: Fix Smatch warnings

here is one remaining buffer overflow message that I believe to be an error in Smatch. These warnings were reported by the 0-DAY kernel build testing backend. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 32

[PATCH] staging: r8188eu: Fix more Smatch warnings and errors

' could be null (see line 4469) Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_recv.c | 7 +++ drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 18 +- 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/staging

[PATCH] staging: rtl8821ae: Fix potential infinite loop

Smatch reports the following: drivers/staging/rtl8821ae/rtl8821ae/hw.c:153 _rtl8821ae_set_fw_clock_on() info: ignoring unreachable code. Upon investigation, the code in this region has the capability of creating an infinite loop. Signed-off-by: Larry Finger larry.fin...@lwfinger.net

[PATCH 02/13] staging: r8188eu: Remove pointless alignment entry in recv_frame

This alignment entry in union recv_frame does nothing. It certainly dues not ensure alignment. Suggested-by: jes.soren...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: jes.soren...@redhat.com --- drivers/staging/rtl8188eu/include/rtw_recv.h | 1 - 1 file changed, 1

[PATCH 00/13] Cleanups for r8188eu

the disk file every time the device reinits. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Larry Finger (12): staging: r8188eu: Remove unnecessary list_head entry from recv_frame union staging: r8188eu: Remove pointless alignment entry in recv_frame staging: r8188eu: Remove

[PATCH 04/13] staging: r8188eu: Remove pkt_to_recv{frame, data, mem} routines

These functions are not called from the outside source. Suggested-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8188eu/include/rtw_recv.h | 38 1 file

[PATCH 01/13] staging: r8188eu: Remove unnecessary list_head entry from recv_frame union

Struct recv_frame_hdr already contains a list head. This one is pointless. Suggested-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8188eu/core/rtw_recv.c| 7 --- drivers

[PATCH 05/13] staging: r8188eu: Remove unused get_rxbuf_desc()

Reported-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8188eu/include/rtw_recv.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/include

[PATCH 06/13] staging: r8188eu: Remove get_recvframe_len()

This simple routine is replaced by a simple access of the len member. Reported-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8188eu/core/rtw_recv.c| 2 +- drivers/staging

[PATCH 09/13] staging: r8188eu: Remove wrapper _exit_critical_mutex()

This wrapper is a simple call to mutex_exit(). Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 7 --- drivers

[PATCH 13/13] staging: r8188eu: Make firmware buffer persistent

From: Stas Sergeev s...@users.sourceforge.net The present code reloads the firmware file from the disk every time the interface re-inits. Change to hold the firmware in memory, and only download to the device. Signed-off-by: Stas Sergeev s...@users.sourceforge.net Signed-off-by: Larry Finger

[PATCH 07/13] staging: r8188eu: Remove get_recvframe_data()

...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8188eu/core/rtw_recv.c | 6 ++ drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +- drivers/staging/rtl8188eu/include/rtw_recv.h| 9 - 3 files

[PATCH 11/13] staging: r8188eu: Remove wrapper routine _init_workitem()

This is simply another name for INIT_WORK(). Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +- drivers/staging/rtl8188eu/core/rtw_led.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 6 -- 3 files changed

[PATCH 08/13] staging: r8188eu: Remove unused union

Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/include/rtw_xmit.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_xmit.h b/drivers/staging/rtl8188eu/include/rtw_xmit.h index 1ac1dd3..62f5db1 100644 --- a/drivers

[PATCH 12/13] staging: r8188eu: Remove wrapper routine _set_workitem()

This is simply a wrapper around schedule_work(). Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/core/rtw_led.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 5 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers

[PATCH 10/13] staging: r8188eu: Remove wrapper _enter_critical_mutex()

This wrapper returned the result of mutex_lock_interruptible(); however, none of the callers checked the returned value. As a result of a gcc upgrade to version 4.8.1, two false unitialized variable warnings appeared. To silence the warnings, they are initialized to 0. Signed-off-by: Larry

Re: [PATCH 10/13] staging: r8188eu: Remove wrapper _enter_critical_mutex()

On 02/15/2014 04:41 AM, Dan Carpenter wrote: On Fri, Feb 14, 2014 at 04:54:14PM -0600, Larry Finger wrote: diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c index 1fa5370..d5f6a32 100644 --- a/drivers/staging/rtl8188eu/hal

Re: [PATCH 10/13] staging: r8188eu: Remove wrapper _enter_critical_mutex()

On 02/15/2014 02:41 PM, Greg KH wrote: On Sat, Feb 15, 2014 at 12:38:11PM -0800, Greg KH wrote: I've applied this series up to here. Nevermind, the others applied, so I've merged them, just not this patch. I have split this patch into two parts that I will send tomorrow. The first one just

[PATCH] staging: r8188eu: Add new device ID

From: Manu Gupta manugu...@gmail.com The D-Link DWA-123 REV D1 with USB ID 2001:3310 uses this driver. Signed-off-by: Manu Gupta manugu...@gmail.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 + 1 file changed, 1 insertion(+) diff

[RFC/RFT 13/33] staging: r8188eu: Add files for new driver - part 13

This commit adds files hal/odm_RTL8188E.c, hal/odm_RegConfig8188E.c, hal/rtl8188e_cmd.c, and hal/rtl8188e_dm.c. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 399 +++ drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 130

  1   2   3   4   5   6   >