Re: [PATCH v5 33/48] staging: nvec: Register with kernel power-off handler

Am Donnerstag 06 November 2014, 08:43:17 schrieb Guenter Roeck: Register with kernel power-off handler instead of setting pm_power_off directly. Register with default priority since we don't know any better. Cc: Julian Andres Klode j...@jak-linux.org Cc: Marc Dietrich marvi...@gmx.de Cc

Re: [PATCH 21/31] staging: nvec: use reset framework

...@nvidia.com Cc: pdeschrij...@nvidia.com Cc: linux-te...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: Julian Andres Klode j...@jak-linux.org Cc: Marc Dietrich marvi...@gmx.de Cc: ac...@lists.launchpad.net Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: de

[PATCH] staging: nvec: re-enable the clock on resume

by not disabling the clock after initialization. This didn't striked us yet because suspend/resume hasn't landed in mainline yet, but will soon. Signed-off-by: Marc Dietrich marvi...@gmx.de --- drivers/staging/nvec/nvec.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging

Re: [PATCH] staging: nvec: insert blank lines after declarations

though. Signed-off-by: Pawel Lebioda pawel.lebiod...@gmail.com drivers/staging/nvec/nvec_paz00.c | 1 + drivers/staging/nvec/nvec_power.c | 1 + drivers/staging/nvec/nvec_ps2.c | 2 ++ 3 files changed, 4 insertions(+) Acked-by: Marc Dietrich marvi...@gmx.de signature.asc Description

Re: [PATCH] staging: nvec: remove unneccessary 'else' after 'return'statement

-- Marc Dietrich marvi...@gmx.de ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 0/2] staging: nvec: fix some coding style problems

drivers/staging/nvec/nvec.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) thanks for fixing, so for this series Acked-by: Marc Dietrich marvi...@gmx.de signature.asc Description: This is a digitally signed message part. ___ devel mailing

Re: [PATCH] staging:nvec: Fix several coding style warnings

anyway for taking your time. Marc Marc Dietrich marvi...@gmx.de ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging/nvec: Pass proper resource to mfd_add_devices()

-- Marc Dietrich marvi...@gmx.de ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging/nvec: Remove double const qualifier

nvidia_nvec_of_match[] = { -- 2.0.1 -- Marc Dietrich marvi...@gmx.de ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/2] staging/nvec: Do not pass resource to mfd_add_devices()

directly access the registers. Since subdevices never need to access the registers we can simply pass NULL instead. Signed-off-by: Thierry Reding tred...@nvidia.com Acked-by: Marc Dietrich marvi...@gmx.de --- drivers/staging/nvec/nvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] staging: nvec: specify a platform-device base id

). Reported-by: Misha Komarovskiy zom...@gmail.com Signed-off-by: Marc Dietrich marvi...@gmx.de --- drivers/staging/nvec/nvec.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 093535c..120b70d 100644

Re: [PATCH 2/3] staging/nvec: reimplement on top of tegra i2c driver

); +module_i2c_driver(i2c_nvec_device_driver); -MODULE_ALIAS(platform:nvec); +MODULE_ALIAS(i2c:nvec); MODULE_DESCRIPTION(NVIDIA compliant embedded controller interface); MODULE_AUTHOR(Marc Dietrich marvi...@gmx.de); MODULE_LICENSE(GPL); diff --git a/drivers/staging/nvec/nvec.h b/drivers/staging/nvec

Re: [PATCH] Warning that occured while compiling the nvec in3.19.0-rc5+ is fixed

Am Samstag 31 Januar 2015, 20:11:29 schrieb Julian Andres Klode: On 31 January 2015 at 17:29, Greg KH gre...@linuxfoundation.org wrote: On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote: The task was to fix a warning which was shown while compiling a driver called NVEC. I wrote a

Re: [PATCH v3 00/20] power_supply: Allow safe usage of power supply

. Patches 2 and 11 are Reviewed-By: Marc Dietrich marvi...@gmx.de # for the nvec part. Thanks! Marc signature.asc Description: This is a digitally signed message part. ___ devel mailing list de...@linuxdriverproject.org http

Re: [PATCH] staging: nvec: remove duplicated const

Am Dienstag, 16. Juni 2015, 23:13:21 schrieb Peng Fan: Sparse checking warning: drivers/staging/nvec/nvec_ps2.c:172:14: warning: duplicate const. Remove the duplicated const to fix the warning. Signed-off-by: Peng Fan van.free...@gmail.com Thanks! Acked-by: Marc Dietrich marvi...@gmx.de

Re: [PATCH] staging:nvec: fix typo in comment

Am Mittwoch, 27. Mai 2015, 07:00:54 schrieb Shailendra Verma: Fix spelling error in comment in function tegra_nvec_remove. Signed-off-by: Shailendra Verma shailendra.capric...@gmail.com Acked-by: Marc Dietrich marvi...@gmx.de --- drivers/staging/nvec/nvec.c |2 +- 1 file changed, 1

Re: [PATCH] staging:nvec:nvec - Fix for typo in comment to function tegra_nvec_remove().

Hi Shailendra, you should fill the patch description with something, even if trivial, and trim the subject line a bit, e.g. --- staging: nvec: fix typo in comment (all lowercase, no full stop at the end) Fix spelling error in comment in function tegra_nvec_remove. S-o-b - Thanks, Marc

Re: [PATCH v3 4/4] dt: paz00: define nvec as child of i2c bus

Am Dienstag, 21. Juli 2015, 09:35:21 schrieb Andrey Danin: On 21.07.2015 1:19, Stephen Warren wrote: On 07/20/2015 02:35 PM, Andrey Danin wrote: NVEC driver was reimplemented to use tegra i2c. Use common i2c bindings for NVEC node. diff --git a/arch/arm/boot/dts/tegra20-paz00.dts

Re: [PATCH v3 4/4] dt: paz00: define nvec as child of i2c bus

Am Dienstag, 21. Juli 2015, 11:51:15 schrieb Andrey Danin: On 21.07.2015 11:25, Marc Dietrich wrote: I think in this case it would be better to leave nvec and dt as it is for now, and just add the slave function to tegra-i2c. Otherwise we will again have two different nvidia,nvec-slave

Re: [PATCH] staging: nvec: fixed few coding style warnings

Am Donnerstag, 15. Oktober 2015, 11:48:12 schrieb Dan Carpenter: > On Thu, Oct 15, 2015 at 10:39:02AM +0200, Marc Dietrich wrote: > > > > - if (unlikely(nvec->rx == NULL)) { > > > > + if (!unlikely(nvec->rx)) { &g

Re: [PATCH] staging: nvec: fixed few coding style warnings

Am Mittwoch, 14. Oktober 2015, 21:12:36 schrieb Dan Carpenter: > On Wed, Oct 14, 2015 at 07:38:22PM +0530, Sakshi Bansal wrote: > > Fixed allignmnet issues and block comments usage > > Split it apart by type of fix. > > > @@ -617,7 +618,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)

Re: [PATCH] staging: nvec: fix block comments

Hi Simon, Am Mittwoch, 9. Dezember 2015, 08:14:06 schrieb Simon Guinot: > This patch fixes a couple of checkpatch warnings about block comments. > > Signed-off-by: Simon Guinot > --- > drivers/staging/nvec/nvec.c | 6 -- > drivers/staging/nvec/nvec_power.c

Re: [PATCH] staging: nvec: Fixed 12 code style checks and changed udelay() to usleep_range() on 2 lines

Hi Parth, please also cc de...@linuxdriverproject.org next time. Some comments below. Am Freitag, 26. Februar 2016, 15:24:21 CET schrieb Parth Sane: > 1)Null comparison > 2)Extra Line after curly braces > 3)Changed udelay to udelay_range > 4)BUG_ON to WARN_ON to avoid crashing kernel >

Re: [PATCH] staging: nvec: Fixed 12 code style checks and changed udelay() to usleep_range() on 2 lines

w which patches are needed and > which are not? you should not send patches which others already did. Marc > > On 29-Feb-2016, at 5:00 PM, Marc Dietrich <marvi...@gmx.de> wrote: > > > > Hi Parth, > > > > please also cc de...@linuxdriverproject.org next time.

Re: [PATCH v2] staging: nvec: Avoid the use of BUG_ON

Am Dienstag, 23. Februar 2016, 21:59:04 CET schrieb Laura Garcia Liebana: > Prevent a kernel panic by avoiding the use of the BUG_ON macro. > Checkpatch detected this issue. > > Signed-off-by: Laura Garcia Liebana <nev...@gmail.com> Acked-by: Marc Dietrich <marvi...@gmx

Re: [PATCH] staging: nvec: replace led_classdev_register

nt > nvec_paz00_remove() function. > > Signed-off-by: Hari Prasath Gujulan Elango <hguju...@visteon.com> Thanks! Acked-by: Marc Dietrich <marvi...@gmx.de> > --- > drivers/staging/nvec/nvec_paz00.c | 12 +--- > 1 file changed, 1 insertion(+), 11 deletions(-)

Re: [PATCH] staging: nvec: Fix incorrect type of i2c address

rrect type in argument 3 > (different signedness) drivers/staging/nvec/nvec.c:781:35:expected > unsigned int [usertype] *out_value drivers/staging/nvec/nvec.c:781:35: > got int * > > Signed-off-by: Franck Demathieu <fdemath...@gmail.com> looks correct. Than

Re: [PATCH] staging:nvec:nvec_ps2.c: Preferingkzalloc(sizeof(*ser_dev)...) over kzalloc(sizeof(struct serio)...)

eryone) happy week. Acked-by: Marc Dietrich <marvi...@gmx.de> > --- > drivers/staging/nvec/nvec_ps2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/nvec/nvec_ps2.c > b/drivers/staging/nvec/nvec_ps2.c index 499952c8ef39..3b7bce

Re: [Outreachy kernel] [PATCH] staging: nvec: cleanup USLEEP_RANGEcheckpatch checks

Hi Simran, Am Donnerstag, 2. März 2017, 15:48:13 CET schrieb SIMRAN SINGHAL: > On Thursday, March 2, 2017 at 8:06:40 PM UTC+5:30, Julia Lawall wrote: > > On Thu, 2 Mar 2017, simran singhal wrote: > > > Resolve strict checkpatch USLEEP_RANGE checks by converting delays and > > > sleeps as

Re: [PATCH v2 0/2] staging: nvec: ps2: fix touchpad operation

;staging: nvec: ps2: change serio type to passthrough" > > drivers/staging/nvec/nvec_ps2.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) Works fine now. Thanks! The series is Acked-by: Marc Dietrich <marvi...@gmx.de> signatur

Re: [PATCH] Revert "staging: nvec: ps2: change serio type to passthrough"

OPTION section). > > Since paz00's embedded controller is not connected to a PS/2 port > itself, the PS/2 interface it exposes is not a pass-through one. > > Acked-by: Marc Dietrich <marvi...@gmx.de> > Signed-off-by: Paul Fertser <fercer...@gmail.com> In fact I was a bit to fast

[PATCH] staging: nvec: remove managed resource from PS2 driver

This basicly reverts commit e534f3e9 (staging:nvec: Introduce the use of the managed version of kzalloc). Serio struct should never by managed because it is refcounted. Doing so will lead to a double free oops on module remove. Signed-off-by: Marc Dietrich <marvi...@gmx.de> --- drivers/s

Re: [PATCH] drivers: staging: nvec: remove bogus reset command for PS/2 interface

Hi Paul, thanks for finding the issue! Am Donnerstag, 27. Oktober 2016, 16:55:14 CEST schrieb Paul Fertser: > This command was sent behind serio's back and the answer to it was > confusing atkbd probe function which lead to the elantech touchpad > getting detected as a keyboard. > > To prevent

Re: [PATCH 7/9] staging: nvec: Augment TODO file with GPIO work item

t. Thanks for the reminder! Marc > > Cc: Marc Dietrich <marvi...@gmx.de> > Signed-off-by: Linus Walleij <linus.wall...@linaro.org> > --- > drivers/staging/nvec/TODO | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/staging/nvec/TODO b/d

[PATCH 1/2] staging: nvec: cleanup use of dev in probe function

This cleanups the probe function a bit by using a dev variable instead of Signed-off-by: Marc Dietrich <marvi...@gmx.de> --- drivers/staging/nvec/nvec.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers/staging/nvec/nv

[PATCH 2/2] staging: nvec: convert to use GPIO descriptors

Use GPIO descriptors instead of relying on the old method. Cc: Linus Walleij <linus.wall...@linaro.org> Signed-off-by: Marc Dietrich <marvi...@gmx.de> --- This obsolets the ToDo reminder sent by Linus a few hours ago. --- drivers/staging/nvec

Re: [PATCH 49/61] staging: nvec: simplify getting .drvdata

Am Donnerstag, 19. April 2018, 16:06:19 CEST schrieb Wolfram Sang: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Acked-by: Marc Dietric

[PATCH] Revert "staging: nvec: Augment TODO file with GPIO work item"

This reverts commit 5a3e59ce3acf2f52c8b4a6fc656c3b1e4a329f06, because the necessary changes were applied in the "staging: nvec: convert to use GPIO descriptors" patch. Signed-off-by: Marc Dietrich <marvi...@gmx.de> --- drivers/staging/nvec/TODO | 5 - 1 file changed, 5 de

Re: [PATCH] staging: nvec: v3: add error checking to nvec_power_pollfunction

Hello Thomas, Am Freitag, 2. M?rz 2018, 20:05:25 CET schrieb Thomas Avery: > This patch adds error checking to the nvec_power_poll function, which > will allow for easier debugging if the driver has issues. > > Signed-off-by: Thomas Avery > --- >

Re: [PATCH 2/2] Staging: nvec: nvec: fixed check style issues

Hi, On Mon, 17 Dec 2018, Greg KH wrote: On Sun, Dec 16, 2018 at 08:57:43AM -0800, Amir Mahdi Ghorbanian wrote: @@ -626,7 +628,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) break; case 2: /* first byte after command */ if (status

Re: [PATCH] staging: nvec: make use of devm_platform_ioremap_resource

devm_platform_ioremap_resource for base Signed-off-by: Hariprasad Kelam Acked-by: Marc Dietrich Thanks! Marc --- drivers/staging/nvec/nvec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 1cbd7b7..360ec04 100644

Re: [PATCH 1/1] staging: nvec: check return value

Hello Xidong, On Wed, 18 Dec 2019, Xidong Wang wrote: In nvec_kbd_probe(), the return value of devm_input_allocate_device() should be checked before it is used. Signed-off-by: Xidong Wang looks good to me. Thanks! Acked-by: Marc Dietrich --- drivers/staging/nvec/nvec_kbd.c | 2 ++ 1

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

Hello Rohit, On Sat, 25 Jul 2020, Rohit K Bharadwaj wrote: changed usage of slave (which is deprecated) to secondary without breaking the driver Tested-by: Dan Carpenter Acked-by: Marc Dietrich Signed-off-by: Rohit K Bharadwaj please don't add "*-by"'s by yourself when you

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

Hi, On Sat, 25 Jul 2020, Michał Mirosław wrote: On Sat, Jul 25, 2020 at 06:01:19PM +0530, Rohit K Bharadwaj wrote: On 25/07/20 5:31 pm, Michał Mirosław wrote: On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote: changed usage of slave (which is deprecated) to secondary without

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

Hi Rohit, On Fri, 24 Jul 2020, Rohit Bharadwaj wrote: On 24/07/20 1:58 pm, Greg KH wrote: On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote: On 24/07/20 10:06 am, Rohit K Bharadwaj wrote: changed usage of slave (deprecated) to secondary Signed-off-by: Rohit K Bharadwaj ---

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

Hi Rohit, On Fri, 24 Jul 2020, Rohit K Bharadwaj wrote: On 24/07/20 10:06 pm, Marc Dietrich wrote: On Fri, 24 Jul 2020, Marc Dietrich wrote: Hi Rohit, On Fri, 24 Jul 2020, Rohit Bharadwaj wrote: On 24/07/20 1:58 pm, Greg KH wrote: On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

On Fri, 24 Jul 2020, Marc Dietrich wrote: Hi Rohit, On Fri, 24 Jul 2020, Rohit Bharadwaj wrote: On 24/07/20 1:58 pm, Greg KH wrote: On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote: On 24/07/20 10:06 am, Rohit K Bharadwaj wrote: changed usage of slave (deprecated

Re: [PATCH 05/13] staging: nvec: Switch from strlcpy to strscpy

e)); + strscpy(ser_dev->phys, "nvec", sizeof(ser_dev->phys)); lgtm, so Acked-by: Marc Dietrich Thanks! Marc ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel