On 10/13/2014 10:04 PM, Greg KH wrote:
On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote:
On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
Hi,
2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote:
On 10/21/2014 07:33 AM, David Binderman wrote:
Hello there,
1.
[linux-3.18-rc1/drivers/staging/dgap/dgap.c:6692]: (warning) Logical
disjunction always evaluates to true: conc_type != 65 || conc_type != 66.
Source code is
if (conc_type == 0 || conc_type != CX ||
On 10/14/2014 08:01 AM, Mark Hounschell wrote:
On 10/13/2014 10:04 PM, Greg KH wrote:
On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote:
On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
Hi,
2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Mon, Oct 13, 2014
On 10/29/2014 05:22 AM, Greg KH wrote:
On Sun, Oct 26, 2014 at 11:08:54AM +0900, Daeseok Youn wrote:
Re-arrange the functions for removing forward declarations.
Tested-by: Mark Hounschell ma...@compro.net
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
RESEND: This patch is tested all
On 12/03/2014 06:37 PM, Joe Perches wrote:
On Wed, 2014-12-03 at 21:30 +, Sean Cleator wrote:
A patch to fix the rest of the long line warnings in the dgnc_cls.h file
found by the checkpatch.pl tool
checkpatch is a brainless little tool.
You should prefer to develop a readable style
Hi Greg,
As I've never done this before, I've got 17 patches that I don't really
know what to do with. These 17 patches whittle down the
drivers/staging/dgap directory to just 4 files (dgap.c, dgap.h,
Makefile, and Kconfig) and also add the in kernel firmware loading code
so when the driver
Merge dgap_fep5.h into dgap_driver.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
diff -urN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap
Remove userland downld.c source file.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
diff -urN linux-3.13.1-orig/drivers/staging/dgap/downld.c
linux-3.13.1-new/drivers/staging/dgap/downld.c
--- linux-3.13.1-orig/drivers/staging/dgap/downld.c
Add in kernel firmware loading support
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
diff -urN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap
Remove user land dgap_downld.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_downld.h
linux-3.13.1-new/drivers/staging/dgap/dgap_downld.h
--- linux-3.13.1-orig/drivers/staging/dgap
Merge dgap_parse.h into dgap-driver.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap
Merge dgap_conf.h into dgap-driver.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_conf.h
linux-3.13.1-new/drivers/staging/dgap/dgap_conf.h
--- linux-3.13.1-orig/drivers/staging/dgap
Merge digi.h into dgap_driver.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.h
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.h
--- linux-3.13.1-orig/drivers/staging/dgap
Merge dgap_pci.h into dgap_driver.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap
Merge dgap_sysfs.c into dgap_driver.c
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap
Merge dgap_sysfs.h into dgap_driver.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap
Remove dgap_kcompat.h and_dgap_types.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap
On 02/12/2014 01:40 PM, Greg Kroah-Hartman wrote:
On Wed, Feb 12, 2014 at 12:46:31PM -0500, Mark Hounschell wrote:
Merge dgap_fep5.h into dgap_driver.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Same here, why merge these files
On 02/12/2014 01:41 PM, Greg Kroah-Hartman wrote:
On Wed, Feb 12, 2014 at 12:49:46PM -0500, Mark Hounschell wrote:
Add in kernel firmware loading support
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
You also do other things in this patch
On 02/12/2014 01:39 PM, Greg Kroah-Hartman wrote:
diff -urN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
--- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c 2014-01-29
08:06:37.0 -0500
+++
On 02/12/2014 02:15 PM, Greg Kroah-Hartman wrote:
On Wed, Feb 12, 2014 at 02:00:01PM -0500, Mark Hounschell wrote:
On 02/12/2014 01:40 PM, Greg Kroah-Hartman wrote:
On Wed, Feb 12, 2014 at 12:46:31PM -0500, Mark Hounschell wrote:
Merge dgap_fep5.h into dgap_driver.h
Signed-off-by: Mark
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Merge dgap_fep5.h into dgap_driver.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre
Remove userland downld.c source file. This file is not used by the kernel.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
drivers/staging/dgap/downld.c | 798
1 file changed, 798 deletions(-)
diff -urN linux
Remove user land dgap_downld.h. This file is not used by the kernel.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
drivers/staging/dgap/dgap_downld.h | 69 ---
1 file changed, 69 deletions(-)
diff -urpN linux-3.13.1
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Merge dgap_parse.h into dgap-driver.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Merge dgap_conf.h into dgap-driver.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Merge digi.h into dgap_driver.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Merge dgap_pci.h into dgap_driver.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Merge dgap_tty.h into dgap_driver.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Merge dgap_sysfs.h into dgap_driver.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman
Remove dgap_kcompat.h and_dgap_types.h. These files are only required for
older 2.x.x kernels.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
drivers/staging/dgap/dgap_driver.c |2
drivers/staging/dgap/dgap_driver.h | 22
On 02/12/2014 03:34 PM, Dan Carpenter wrote:
Greg mentioned doing the checkpatch.pl fixes later and that applies
here as well. Leave the LINUX_VERSION_CODE code in for now and delete
it in a later patch.
On the other hand, I don't want to give you a lot of extra work to do if
no one else
On 02/14/2014 12:34 PM, Greg Kroah-Hartman wrote:
Minor nits for future patch submissions:
On Wed, Feb 12, 2014 at 03:32:10PM -0500, Mark Hounschell wrote:
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice
On 02/14/2014 12:38 PM, Greg Kroah-Hartman wrote:
On Wed, Feb 12, 2014 at 03:32:10PM -0500, Mark Hounschell wrote:
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source
On 02/14/2014 01:18 PM, Greg Kroah-Hartman wrote:
On Fri, Feb 14, 2014 at 12:45:30PM -0500, Mark Hounschell wrote:
On 02/14/2014 12:38 PM, Greg Kroah-Hartman wrote:
On Wed, Feb 12, 2014 at 03:32:10PM -0500, Mark Hounschell wrote:
There is a lot of cleanup work to do on these digi drivers
On 02/17/2014 05:50 PM, Greg Kroah-Hartman wrote:
On Mon, Feb 17, 2014 at 02:32:28PM -0500, Mark Hounschell wrote:
On 02/14/2014 01:18 PM, Greg Kroah-Hartman wrote:
On Fri, Feb 14, 2014 at 12:45:30PM -0500, Mark Hounschell wrote:
On 02/14/2014 12:38 PM, Greg Kroah-Hartman wrote:
On Wed, Feb
On 02/18/2014 08:14 AM, Dan Carpenter wrote:
On Tue, Feb 18, 2014 at 08:00:57AM -0500, Mark Hounschell wrote:
That's odd. I just installed vanilla 3.14-rc3 yesterday from kernel.org.
It boots up fine but does not appear to have the same dgap driver as
staging-next. Clearly staging-next is more
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers
This patch series whittles down the drivers/staging/dgap directory to
just 4 files (dgap_driver.c, dgap_driver.h, Makefile, and Kconfig).
This was done because there is a lot of cleanup work to do on these
digi drivers and merging as much as is possible will make it easier.
I also notice that
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers
This patch makes all merged and original functions static to dgap.c.
Doing so has revealed more dead code via gcc warnings.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap_driver.c | 159
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers
This patch removes all the original CVS tags because they are in my way
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap_conf.h | 1 -
drivers/staging/dgap/dgap_downld.h | 1 -
drivers/staging/dgap/dgap_driver.c | 1
This patch removes userland source code files downld.c and dgap_downld.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap_downld.h | 68
drivers/staging/dgap/downld.c | 797
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers
Removes unneeded files dgap_trace.c and dgap_trace.h
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/Makefile | 3 +-
drivers/staging/dgap/dgap_driver.c | 1 -
drivers/staging/dgap/dgap_trace.c | 185
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers
This patch adds in-kernel firmware loading support and removes
support for the original userland firmware loading process.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 540
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers
On 02/19/2014 03:17 PM, Dan Carpenter wrote:
This one has white space problems. Run scripts/checkpatch.pl on your
patches before sending. Comments below.
On Wed, Feb 19, 2014 at 01:12:15PM -0500, Mark Hounschell wrote:
+static int dgap_firmware_load(struct pci_dev *pdev, int card_type
This patch adds in-kernel firmware loading support and removes
support for the original userland firmware loading process.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 529
This patch adds in-kernel firmware loading support and removes
support for the original userland firmware loading process.
Signed-off-by: Mark Hounschell ma...@compro.net
---
drivers/staging/dgap/dgap.c | 525 +++-
1 file changed, 323 insertions(+), 202
This patch adds in-kernel firmware loading support and removes
support for the original userland firmware loading process.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 525
When a kernel subsystem undergoes a global change such as the serial
subsystem has been since 3.5 or so, if a driver is in staging, does it
automatically get those changes if they are applicable to it?
Thanks
Mark
___
devel mailing list
On 02/24/2014 07:49 PM, Greg Kroah-Hartman wrote:
On Wed, Feb 19, 2014 at 01:12:14PM -0500, Mark Hounschell wrote:
Renames driver file dgap_driver.c and dgap_driver.h to
dgap.c and dgap.h because we are now single source and
include file and better fits kernel naming conventions.
Signed-off
I have a couple basic questions concerning the Digi International
staging/dgap driver about how I might be able to help clean it up more.
1. This driver has/had a built-in tracing system that during driver and
board development that I'm sure was useful to Digi International at the
time. Since
The last patch series exposed some dead code causing compile warnings.
This patch removes that dead code and fixes the warnings
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 145
When opening a port the dgap driver OOPs with a message:
tty_init_dev: driver does not set tty-port... will crash the kernel... fix the
driver... etc...
Then I have to reboot the box.
I think before too much more work is done on this driver (by me anyway),
it should at least be in a usable
On 02/25/2014 11:48 AM, Greg KH wrote:
On Tue, Feb 25, 2014 at 10:56:22AM -0500, Mark Hounschell wrote:
When opening a port the dgap driver OOPs with a message:
tty_init_dev: driver does not set tty-port... will crash the kernel... fix the
driver... etc...
Then I have to reboot the box.
I
On 02/25/2014 01:40 PM, Mark Hounschell wrote:
+struct dgap_port {
+struct tty_port port;
+};
Do you really need a wrapping structure here?
I may be incorrect, but I think so. I will investigate this further
before I make a patch.
It looks to me like this is how it should be done
On 02/26/2014 09:01 AM, Dan Carpenter wrote:
On Wed, Feb 26, 2014 at 08:41:38AM -0500, Mark Hounschell wrote:
-static void dgap_sysfs_create(struct board_t *brd)
+static int dgap_tty_register_ports(struct board_t *brd)
{
struct channel_t *ch;
- int j = 0;
+ int i
This patch addresses the follow error message followed
by a kernel oops:
dgap: driver does not set tty-port. This will crash the kernel later. Fix the
driver
It also renames the main function this patch addresses because
its name is misleading.
Signed-off-by: Mark Hounschell ma...@compro.net
On 02/26/2014 10:30 AM, Dan Carpenter wrote:
On Wed, Feb 26, 2014 at 10:18:26AM -0500, Mark Hounschell wrote:
This patch addresses the follow error message followed
by a kernel oops:
dgap: driver does not set tty-port. This will crash the kernel later. Fix
the driver
It also renames
On 02/28/2014 06:10 AM, Masanari Iida wrote:
req_type and bdid in struct downldio are defined as unsigned int.
So dlio.req_type and dlio.bdid have to be unsigned int,too.
Signed-off-by: Masanari Iida standby2...@gmail.com
---
drivers/staging/dgap/downld.c | 4 ++--
1 file changed, 2
On 02/27/2014 04:52 PM, Dan Carpenter wrote:
This isn't a real patch, and it deliberately doesn't compile, but it's
sort of what the patch should look like.
The first thing to do is to get rid of the stupid DGAP_UNLOCK() macro.
Disabling IRQs more than once doesn't help anything and it doesn't
This patch fixes all include related errors in
dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
This patch fixes white space errors in dgap.c
as reported by checkpatch. It also changes
unnecessary mutliple empty lines with a single
empty line
Signed-off-by: Mark Hounschell ma...@compro.net
---
drivers/staging/dgap/dgap.c | 314
1 file changed
This patch fixes foo* bar should be foo *bar errors
in dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
This patch fixes externs should be avoided in .c files
in dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell ma...@compro.net
---
drivers/staging/dgap/dgap.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging
This patch fixes all indent errs in dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 148 +++-
1 file changed, 77 insertions(+), 71
This patch series begins the process of cleaning up
dgap.c and dgap.h using the checkpath tool. One or more
of these patches will show checkpatch errors that will
be cleaned up in following patches
--
1.8.1.4
___
devel mailing list
Fix all return staments in err as reported by checkpatch
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 672 ++--
1 file changed, 336 insertions(+), 336 deletions(-)
diff
This patch fixes bracing errors in dgap.c
as reported by checkpatch
Signed-off-by: Mark Hounschell ma...@compro.net
---
drivers/staging/dgap/dgap.c | 338
1 file changed, 121 insertions(+), 217 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b
This patch fixes do not use assignment in if condition
errors reported by checkpatch
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 75 ++---
1 file changed, 50 insertions
This patch fixes some printk related errors report by checkpatch.
It also removes more Digi debug/trace code left behind from patch #1.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 38
This patch fixes various small checkpatch errors
I missed in patches 01-10.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git
to review it more than once if I can avoid
that.
On Fri, Feb 28, 2014 at 12:42:08PM -0500, Mark Hounschell wrote:
The original debug and tracing code is no longer required.
This patch removes it
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
On 02/28/2014 05:06 PM, Dan Carpenter wrote:
Reviewed-by: Dan Carpenter dan.carpen...@oracle.com
Btw, for later work, this driver returns -EFAULT a lot when some times
it should be returning -EINVAL or something. Also the
DGAP_VERIFY_BOARD() macro is disgusting.
regards,
dan carpenter
Yes,
On 02/28/2014 05:59 PM, Greg KH wrote:
On Fri, Feb 28, 2014 at 12:42:14PM -0500, Mark Hounschell wrote:
This patch fixes externs should be avoided in .c files
in dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell ma...@compro.net
---
drivers/staging/dgap/dgap.c | 8
1
On 02/28/2014 05:27 PM, Dan Carpenter wrote:
Please redo this one.
On Fri, Feb 28, 2014 at 03:48:58PM -0500, Mark Hounschell wrote:
This patch fixes some printk related errors report by checkpatch.
It also removes more Digi debug/trace code left behind from patch #1.
These are two separate
On 02/28/2014 05:36 PM, Dan Carpenter wrote:
Please redo this one.
On Fri, Feb 28, 2014 at 03:49:09PM -0500, Mark Hounschell wrote:
This patch fixes various small checkpatch errors
I missed in patches 01-10.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre
On 03/01/2014 04:57 AM, Mark Hounschell wrote:
On 02/28/2014 05:59 PM, Greg KH wrote:
On Fri, Feb 28, 2014 at 12:42:14PM -0500, Mark Hounschell wrote:
This patch fixes externs should be avoided in .c files
in dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell ma...@compro.net
This patch fixes externs should be avoided in .c files
in dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff
On 02/28/2014 05:27 PM, Dan Carpenter wrote:
Please redo this one.
On Fri, Feb 28, 2014 at 03:48:58PM -0500, Mark Hounschell wrote:
This patch fixes some printk related errors report by checkpatch.
It also removes more Digi debug/trace code left behind from patch #1.
These are two separate
This patch fixes some printk related errors report by checkpatch.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/staging
On 03/03/2014 10:11 AM, Mark Hounschell wrote:
This patch fixes some printk related errors report by checkpatch.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 13 ++---
1 file changed, 2 insertions
.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index cac2791
This patch fixes some printk related errors report by checkpatch.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap
This patch removes the DGAP_VERIFY_BOARD macro and inserts its
code where required because of checkpatch error.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 100 +++-
1
This patch series fixes some discrepancies noted in a
previous patch series.
Removes the rest of the debug/tracing code
Removes a nasty macro
Add curly braces back in for a multi-line indent block
Fixes some pr_warns with newline chars in the strings
Yes, these pr_warns will eventually
This patch fixes some pr_warns that have newline
chars in the string because they mess up the
output.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 14 +-
1 file changed, 9 insertions(+), 5
This patch removes more, if not all, of the debug/tracing code
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 27 ---
drivers/staging/dgap/dgap.h | 5 -
2 files changed, 32 deletions
Multi-line indent blocks get curly braces for readability.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers
On 03/03/2014 04:50 PM, Dan Carpenter wrote:
On Mon, Mar 03, 2014 at 04:36:23PM -0500, Mark Hounschell wrote:
This patch removes the DGAP_VERIFY_BOARD macro and inserts its
code where required because of checkpatch error.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman
This patch replaces the DGAP_VERIFY_BOARD macro with
the dgap_verify_board function because of checkpatch error.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 62 +++--
1
We should not remove a sysfs group we failed to create
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers
1 - 100 of 209 matches
Mail list logo
