There is no reason for comment describing the BSSID check for loop
to be spaced so far to the right. Move it above the for loop.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
Some cases in the switch statement in get_ap_information() are indented
as much as five levels, which makes the code difficult to read because
of all the wrapping. Factor them out into helper methods.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_ho
The code to initialize various different types of request structs
is repeated multiple times. Factor this code out into a macro
called INIT_REQUEST.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 55 +++---
Remove unnecessary parentheses highlighted by checkpatch.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_ho
Some of the code for reading IEs is replicated multiple times in the
switch statement for get_ap_information(). Factor that code out into
read_ie().
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 48 +-
There is no need for the calls to BUG_ON() in this driver, which are
used to check if mbo or mbo->context are NULL; mbo is never NULL, and
if mbo->context is NULL it would have already been dereferenced and
oopsed before reaching the BUG_ON().
Signed-off-by: Quytelda Kahja <quyte...@ta
Replace literal bytestring with CIPHER_ID_WPA_WEP40 constant.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_ho
Indent the parameters for a function call that extends past 80 characters.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/most/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
ugh, so I assumed
there wasn't really much recovery to be made from that problem. If
you feel this doesn't improve the behavior of the driver, just drop
the patch.
Thank you,
Quytelda Kahja
On Thu, Mar 1, 2018 at 8:21 AM, Greg KH <gre...@linuxfoundation.org> wrote:
> On Fri, Feb 23, 2018 a
Use a blank line after components_show() function declaration.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/most/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index 0ab2de5ecf18..67e2d7
Indent the parameters for a function call that extends past 80 characters.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/most/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
Use a blank line after components_show() function declaration.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/most/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index 0ab2de5ecf18..67e2d7
my imperative attempts. However, I will word my change
logs in the imperative as best I can in the future.
Thank you,
Quytelda Kahja
On Thu, Mar 1, 2018 at 12:54 PM, Tobin C. Harding <m...@tobin.cc> wrote:
> On Thu, Mar 01, 2018 at 02:15:00PM +0300, Dan Carpenter wrote:
>> On Th
SSID_MAX_SIZE is a constant defined locally in ks_hostif.h, but it should
be replaced with IEEE80211_MAX_SSID_LEN from the kernel's 802.11 header,
of which it is just a copy.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
drivers/s
This driver defined constants BSS_CAP_* to represent WLAN capability
codes; however, these constants are already defined in the header
'linux/ieee80211.h' as WLAN_CAPABILITY_*. This change removes the locally
defined constants and substitutes the kernel's constants.
Signed-off-by: Quytelda Kahja
The case statement in get_ap_information() should not use literal integers
to parse information element IDs when these values are provided by name
in 'enum ieee80211_eid' in the header 'linux/ieee80211.h'.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/
-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
drivers/staging/ks7010/ks_hostif.h | 6 --
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index f425975fbcbc..7935ba
The code that generates a WLAN capability mask is repeated in five
functions. This change refactors that code into a new function, which is
called now in each of those functions.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.
ed in the future since we run
modern machines that aren't limited to 80 character terminals anymore,
so this warning may soon be irrelevant anyway.
Thank you,
Quytelda Kahja
On Mon, Feb 26, 2018 at 5:51 AM, Hans Verkuil <hverk...@xs4all.nl> wrote:
> On 02/20/2018 07:53 AM, Quytelda
Makes two very minor changes indicated by checkpatch:
1) Add a newline after components_show() definition.
2) Fix a line over the 80 character limit.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/most/core.c | 5 -
1 file changed, 4 insertions(+), 1 de
Replace calls to BUG_ON() used to check for NULL pointers with WARN_ONCE()
followed by a return.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/most/core.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/co
It isn't necessary for the driver to log out-of-memory errors, so
these have been removed and the functions simply return -ENOMEM.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/most/core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/most/
The function pointer 'complete' in 'struct mbo' should use an identifier
for its argument.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/most/core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/core.h b/drivers/stagin
Changed a variable name from camel to snake case to fix a coding style
issue.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/hci_packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/hci_packet.h
b/drivers/s
Mostly this change just reverses the primary conditional so most of
the code can be pulled back a tab, which fixes some code style
warnings.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_lte.c | 22 +++---
1 file changed, 11 inse
Since the testing for host endianness and in-driver conversion were
removed in 77e8a50149a2, the gdm_endian struct contains only one member,
and can therefore be simplified to a single u8 variable.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_endian.
Fix lines with a trailing open parenthesis, which is a coding style issue.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_lte.c | 44 +++
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/drivers/s
,
Quytelda Kahja
On Thu, Feb 22, 2018 at 6:02 AM, Greg KH <gre...@linuxfoundation.org> wrote:
> On Wed, Feb 21, 2018 at 05:12:36AM -0800, Quytelda Kahja wrote:
>> Since the testing for host endianness and in-driver conversion were
>> removed in 77e8a50149a2, the gdm_endian str
Mostly this change just reverses the primary conditional so most of
the code can be pulled back a tab, which fixes some code style
warnings.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_lte.c | 22 +++---
1 file changed, 11 inse
Since the testing for host endianness and in-driver conversion were
removed in 77e8a50149a2, the gdm_endian struct contains only one member,
and can therefore be simplified to a single u8 variable.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_endian.
That could be the case, though I'm not sure where to find any specs.
Though looking through the history of this driver, it seems that some
of the variable names have been slowly changing from camel case to
snake case.
Thanks,
Quytelda Kahja
On Wed, Feb 21, 2018 at 2:45 AM, Dan Carpenter
Changed a variable name from camel to snake case to fix a coding style
issue.
Signed-off-by: Quytelda Kahja <quyte...@gmail.com>
---
drivers/staging/gdm724x/hci_packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/hci_packet.h
b/drivers/s
Fix lines with a trailing open parenthesis, which is a coding style issue.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_lte.c | 44 +++
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/drivers/s
Fix a coding style problem.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
This is the patch without the unnecessary fixes for line length.
drivers/staging/media/bcm2048/radio-bcm2048.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff
Convert the unsafe macro into an inline function.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_ho
Convert the unsafe macros into inline functions.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/
Convert the unsafe macros into inline functions.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks7010_sdio.c | 46 ++--
1 file changed, 33 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdi
Fix a coding style problem.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
b/drivers/staging
Remove the macro 'gdm_tty_send_control' which adds unnecessary complexity,
is unused, and has arguments that could mistakenly be evaluated multiple
times.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_tty.c | 3 ---
1 file changed, 3 deletions(-)
Remove the macro 'gdm_tty_recv' which adds unnecessary complexity and has
arguments that could mistakenly be evaluated multiple times.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_tty.c | 11 ++-
1 file changed, 6 insertions(+), 5 del
Remove the macro 'gdm_tty_send' which adds unnecessary complexity and has
arguments that could mistakenly be evaluated multiple times.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_tty.c | 15 ++-
1 file changed, 6 insertions(+), 9 del
Check the return value of of the register_lte_tty_driver() call in the
module initialization function.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_mux.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/g
Use GCC extensions to prevent macro arguments from accidentally being evaluated
multiple times when the macro is called.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff
Use GCC extensions to prevent macro arguments from accidentally being evaluated
multiple times when the macro is called.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
Use GCC extensions to prevent macro arguments from accidentally being evaluated
multiple times when the macro is called.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.h | 74 +-
1 file changed, 50 insertions(
Use GCC extensions to prevent macro arguments from accidentally being evaluated
multiple times when the macro is called.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks7010_sdio.c | 40
1 file changed, 27 insertions(
Fix a coding style warning from checkpatch.pl. Use GNU extensions to create
references to the results of problem macro arguments when they are evaluated so
that they can be used safely multiple times.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm
Fix coding style warning from checkpatch.pl.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_lte.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.c
b/drivers/staging/gdm724x/gdm_lte.c
index ff3fed
Fix a coding style problem causing warnings from checkpatch.pl.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/gdm724x/gdm_lte.c | 50 ++-
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/g
Removed parenthesis causing a coding style warning.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/fwserial/dma_fifo.c | 2 +-
drivers/staging/fwserial/fwserial.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fwserial/dma_
Replace the literal function name "visorbus_create_instance" with the format
specifier "%s" so it can be dynamically filled by the __func__ macro.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file
This patch replaces several instances where a pointer is compared to NULL
(i.e., `ptr == NULL`) with `!ptr`, which is preferred.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/android/ion/ion.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging/unisys/visorbus/visorbus_main.c
index 1c785d
Replace the literal function name "create_bus_instance" with the format
specifier "%s" so it can be dynamically filled by the __func__ macro.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file
201 - 254 of 254 matches
Mail list logo
