Re: [PATCH] Staging: android: ion: fix typos in comments

On 10/30/14 23:43, Tristan Lelong wrote: Fix some coding style warnings detected by checkpatch.pl in ion. $Subject is correct but the changelog above is not -- needs to be changed. Signed-off-by: Tristan Lelong tris...@lelong.xyz --- drivers/staging/android/ion/ion.c | 2 +-

Re: linux-next: Tree for Feb 11 (staging/rtl8821ae/)

On 02/10/2014 10:21 PM, Stephen Rothwell wrote: Hi all, This tree fails (more than usual) the powerpc allyesconfig build. Changes since 20140210: on i386: ERROR: ieee80211_rx_irqsafe [drivers/staging/rtl8821ae/rtl8821ae.ko] undefined! ERROR: ieee80211_beacon_get_tim

[PATCH] staging/rtl8821ae: fix build, depends on MAC80211

From: Randy Dunlap rdun...@infradead.org rtl8821ae uses ieee80211 interfaces so it should depend on MAC80211. Fixes these build errors: ERROR: ieee80211_rx_irqsafe [drivers/staging/rtl8821ae/rtl8821ae.ko] undefined! ERROR: ieee80211_beacon_get_tim [drivers/staging/rtl8821ae/rtl8821ae.ko

Re: [patch] Documentation/SubmittingPatches: Reported-by tags and permission

...@oracle.com Acked-by: Randy Dunlap rdun...@infradead.org Thanks. diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 26b1e31d5a13..f72ce7803b71 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -432,12 +432,9 @@ have been

Re: linux-next: Tree for Aug 9 (staging/ozwpan)

On 08/08/13 23:15, Stephen Rothwell wrote: Hi all, Changes since 20130808: *crickets* on i386: ERROR: __divdi3 [drivers/staging/ozwpan/ozwpan.ko] undefined! Apologies if this has already been reported/fixed. -- ~Randy ___ devel mailing

Re: linux-next: Tree for Aug 9 (staging/ozwpan)

On 08/10/13 15:15, Randy Dunlap wrote: On 08/08/13 23:15, Stephen Rothwell wrote: Hi all, Changes since 20130808: *crickets* on i386: ERROR: __divdi3 [drivers/staging/ozwpan/ozwpan.ko] undefined! 2 occurrences of this in oz_hcd_heartbeat(). Apologies if this has already been

Re: linux-next: Tree for Aug 16 (lustre)

On 08/16/13 00:16, Stephen Rothwell wrote: Hi all, Changes since 20130815: lustre needs to depend on PROC_FS or provide stub functions for when CONFIG_PROC_FS is not enabled, otherwise there are build errors and warnings: drivers/staging/lustre/lustre/lmv/lproc_lmv.c: In function

Re: [PATCH] staging: octeon: Fix typo in staging/octeon

On 09/15/13 18:39, Masanari Iida wrote: Correct spelling typo in staging/octeon Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/octeon/ethernet-rx.c | 4 ++-- drivers/staging/octeon/ethernet-tx.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v2] staging/olpc_dcon: fix kconfig to fix build errors

On 10/14/13 09:33, Greg Kroah-Hartman wrote: On Sun, Oct 13, 2013 at 12:30:00PM -0700, Randy Dunlap wrote: From: Randy Dunlap rdun...@infradead.org Fix build errors when GPIO_CS5535=m and FB_OLPC_DCON=y by preventing that kconfig combination. These build errors are caused by having

Re: linux-next: Tree for Jul 3 (staging/unisys)

On 07/02/14 22:53, Stephen Rothwell wrote: Hi all, Changes since 20140702: on x86_64: CONFIG_UNISYSSPAR=y CONFIG_UNISYS_VISORUTIL=m # CONFIG_UNISYS_VISORCHANNEL is not set CONFIG_UNISYS_CHANNELSTUB=y drivers/built-in.o: In function `channel_mod_init': chanstub.c:(.init.text+0x10a8f):

Re: [PATCH] staging: iio: Fix typo in iio

On 04/22/14 04:23, Masanari Iida wrote: Correct spelling typo in comment within staging/iio Signed-off-by: Masanari Iida standby2...@gmail.com Acked-by: Randy Dunlap rdun...@infradead.org Thanks. --- drivers/staging/iio/adc/ad7606.h| 4 ++-- drivers/staging/iio/adc/ad7816.c| 2

Re: [PATCH/V2] staging: rtl8192e: Fix typo in rtl8192e

On 04/26/14 07:35, Masanari Iida wrote: Fix spelling typo in comments within rtl8192e. Signed-off-by: Masanari Iida standby2...@gmail.com Reviewed-by: James Cameron qu...@laptop.org --- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +-

Re: [patch v2] Documentation/email-clients.txt: add a section about git

On 05/08/2014 01:44 AM, Dan Carpenter wrote: These days most people use git to send patches so I have added a section about that. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: Fixed changelog diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt

Re: [patch v3] Documentation/email-clients.txt: add a section about git

On 05/13/2014 06:32 AM, Dan Carpenter wrote: These days most people use git to send patches so I have added a section about that. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: fix typo in commit message v3: update git am and log commands. Mention the man pages. diff

Re: [patch v4] Documentation/email-clients.txt: add a section about git

On 05/15/2014 02:33 AM, Dan Carpenter wrote: These days most people use git to send patches so I have added a section about that. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Applied. Thanks. --- v2: fix typo in commit message v3: update git am and log commands. Mention the

Re: linux-next: Tree for May 26 (staging/rtl8192ee)

On 05/26/2014 02:38 AM, Stephen Rothwell wrote: Hi all, The powerpc allyesconfig is again broken more than usual. Changes since 20140523: on x86_64: when CONFIG_PCI is not enabled: CC drivers/staging/rtl8192ee/pci.o ../drivers/staging/rtl8192ee/pci.c: In function

Re: [PATCH] staging: Check against NULL in fw_download_code

On 08/11/14 11:04, Nick Krause wrote: On Mon, Aug 11, 2014 at 2:02 PM, Nicholas Krause xerofo...@gmail.com wrote: I am fixing the bug entry , https://bugzilla.kernel.org/show_bug.cgi?id=60461. This entry states that we are not checking the skb allocated in fw_download_code and after

Re: [PATCH] staging: Check against NULL in fw_download_code

On 08/11/14 11:26, Nick Krause wrote: On Mon, Aug 11, 2014 at 2:07 PM, Randy Dunlap rdun...@infradead.org wrote: On 08/11/14 11:04, Nick Krause wrote: On Mon, Aug 11, 2014 at 2:02 PM, Nicholas Krause xerofo...@gmail.com wrote: I am fixing the bug entry , https://bugzilla.kernel.org

Re: [PATCH] staging: Check against NULL in fw_download_code

On 08/11/14 11:55, Nick Krause wrote: On Mon, Aug 11, 2014 at 2:45 PM, Randy Dunlap rdun...@infradead.org wrote: On 08/11/14 11:26, Nick Krause wrote: On Mon, Aug 11, 2014 at 2:07 PM, Randy Dunlap rdun...@infradead.org wrote: On 08/11/14 11:04, Nick Krause wrote: On Mon, Aug 11, 2014 at 2:02

Re: [PATCH] staging: Check against NULL in fw_download_code

On 08/11/14 12:18, Nick Krause wrote: Thanks Randy for your help otherwise is my patch good? Please let me known if there our any other issues. Regards Nick I didn't notice any other issues with it. -- ~Randy ___ devel mailing list

Re: [PATCH] staging: comedi: Kconfig: make COMEDI_BOND select COMEDI_KCOMEDILIB

On 08/27/14 12:19, Ian Abbott wrote: Currently, to select the comedi_bond driver, the kcomedilib support has to be selected first. It seems more natural to allow the comedi_bond driver to be selected on its own and to automatically select the kcomedilib module as a result of that. Change the

Re: mmotm 2014-09-25-16-28 uploaded (media/platform/vivid)

On 09/25/14 16:28, a...@linux-foundation.org wrote: The mm-of-the-moment snapshot 2014-09-25-16-28 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch

Re: [PATCH] Patch to integrate RapidDisk and RapidCache RAM Drive / Caching modules into stating subsystem.

Hi, Here are a couple more comments. Hopefully not much duplication from other reviews. On 05/31/15 19:43, Petros Koutoupis wrote: diff -uNpr linux-next.orig/drivers/staging/rapiddisk/Kconfig linux-next/drivers/staging/rapiddisk/Kconfig ---

Re: linux-next: Tree for Aug 17 (staging/hfi1)

On 08/17/15 03:55, Stephen Rothwell wrote: Hi all, Changes since 20150813: Several items: A: these and other similar errors: In file included from ../drivers/staging/hfi1/chip.c:61:0: ../drivers/staging/hfi1/chip.c: In function ‘__hfi1_trace_LINKVERB’:

Re: linux-next: Tree for Aug 17 (mshyperv.c)

On 08/17/15 03:55, Stephen Rothwell wrote: Hi all, Changes since 20150813: on i386 (for several days now): when CONFIG_KEXEC is not enabled: arch/x86/built-in.o: In function `hv_machine_crash_shutdown': mshyperv.c:(.text+0x2d9d4): undefined reference to `native_machine_crash_shutdown'

[PATCH -next] staging: most: fix HDM_USB dependencies and build errors

From: Randy Dunlap rdun...@infradead.org Fix kconfig dependency warning and build errors. warning: (HDM_USB) selects AIM_NETWORK which has unmet direct dependencies (STAGING MOST NET) drivers/built-in.o: In function `aim_resume_tx_channel': networking.c:(.text+0xd6f7a2): undefined reference

Re: [PATCH] Kconfig: add temporary PCI dependency

On 08/18/15 10:00, Doug Ledford wrote: On Aug 18, 2015, at 9:50 AM, Greg KH g...@kroah.com wrote: On Tue, Aug 18, 2015 at 04:29:50PM +, Marciniszyn, Mike wrote: Subject: Re: [PATCH] Kconfig: add temporary PCI dependency On Tue, Aug 18, 2015 at 10:15:42AM -0400, Mike Marciniszyn wrote:

[PATCH -next] staging: most: fix aim-network build errors

From: Randy Dunlap rdun...@infradead.org Fix build errors when CONFIG_NET is not enabled by making the driver depend on NET. Also correct the loadable module name. ERROR: __netdev_alloc_skb [drivers/staging/most/aim-network/aim_network.ko] undefined! ERROR: netif_rx [drivers/staging/most/aim

[PATCH -next] staging: most: fix aim-sound build errors

From: Randy Dunlap rdun...@infradead.org Fix build errors: driver uses snd_pcm*() interfaces, so select SND_PCM. drivers/built-in.o: In function `audio_rx_completion': sound.c:(.text+0x3cd376): undefined reference to `snd_pcm_period_elapsed' drivers/built-in.o: In function `pcm_prepare': sound.c

[PATCH -next] staging: most: fix hdm-dim2 build error

From: Randy Dunlap rdun...@infradead.org Fix build of hdm-dim2. Since it calls a function that is provided by AIM_NETWORK, make it depend on that symbol. Also fix a misspelling in the Kconfig file. drivers/built-in.o: In function `deliver_netinfo_thread': dim2_hdm.c:(.text+0x3a9563): undefined

Re: [PATCH v9 5/7] staging: fpga manager core

On 07/17/15 08:51, at...@opensource.altera.com wrote: From: Alan Tull at...@opensource.altera.com --- drivers/staging/Kconfig |2 + drivers/staging/Makefile|1 + drivers/staging/fpga/Kconfig| 14 ++ drivers/staging/fpga/Makefile |8 +

Re: [PATCH 3/4] staging: wilc1000: Fix typo in linux_wlan.c

On 11/23/15 05:41, Masanari Iida wrote: > This patch fix some spelling typo in wilc1000.c. > > Signed-off-by: Masanari Iida <standby2...@gmail.com> > --- > drivers/staging/wilc1000/linux_wlan.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) &g

Re: [PATCH 4/4] staging: wilc1000: Fix typo in wilc_wfi_cfgoperations.c

On 11/23/15 05:41, Masanari Iida wrote: > This patch fix some spelling typo in wilc_wfi_cfgoperations.c > > Signed-off-by: Masanari Iida > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 34 > +++ > 1 file changed, 17 insertions(+), 17

Re: [PATCH 1/4] staging: wilc1000: Fix typo in wilc_msgqueue.h

On 11/23/15 05:41, Masanari Iida wrote: > This patch fix some spelling typo in wilc_msgqueue.h > > Signed-off-by: Masanari Iida <standby2...@gmail.com> Acked-by: Randy Dunlap <rdun...@infradead.org> Thanks. > --- > drivers/staging/wilc1000/wilc_msgqueue.h | 12 +++

[PATCH] staging: unisys: visorinput depends on INPUT

From: Randy Dunlap <rdun...@infradead.org> Fix build errors by limiting UNISYS_VISORINPUT to the INPUT kconfig setting. drivers/built-in.o: In function `visorinput_remove': visorinput.c:(.text+0x20802e): undefined reference to `input_unregister_device' drivers/built-in.o: In fu

Re: [PATCH 0947/1285] Replace numeric parameter like 0444 with macro

On 08/02/16 05:51, Mauro Carvalho Chehab wrote: > Em Tue, 2 Aug 2016 20:01:34 +0800 > Baole Ni escreveu: > >> I find that the developers often just specified the numeric value >> when calling a macro which is defined with a parameter for access permission. >> As we know,

[PATCH] staging: octeon-usb: correct driver name in Kconfig help text

From: Randy Dunlap <rdun...@infradead.org> The module name in the Makefile and in the driver source file is octeon-hcd, so correct the Kconfig text to be the same. Signed-off-by: Randy Dunlap <rdun...@infradead.org> Cc: Aaro Koskinen <aaro.koski...@iki.fi> --- drivers/staging/

Re: [PATCH] staging: sm750fb: fix function definition argument style warning

On 11/27/16 13:11, Andrea Ghittino wrote: > Fixes sm750fb function definition argument style warning > found by checkpatch.pl tool > > Signed-off-by: Andrea Ghittino > --- Does checkpatch not complain about the camelcase variable names and function names? -- ~Randy

Re: [PATCH] [STYLE 2/4]staging:dgnc:dgnc_tty.c Spelling corrections

On 11/12/16 15:53, Walt Feasel wrote: > Made various spelling corrections in the comments Make > > Signed-off-by: Walt Feasel > --- > drivers/staging/dgnc/dgnc_tty.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git

Re: [PATCH 01/01] drivers/staging/vt6656/main_usb.c: checkpatch warning

On 03/31/17 13:58, Chewie Lin wrote: > Replace string with formatted arguments in the dev_warn() call. It removes > the checkpatch warning. Tell us what the warning was. and then see if the patch fixes that warning. > Signed-off-by: Chewie Lin > --- >

Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning

On 03/31/17 18:59, Chewie Lin wrote: > Replace string with formatted arguments in the dev_warn() call. It removes > the checkpatch warning: > > WARNING: Prefer using "%s", __func__ to embedded function names > #417: FILE: main_usb.c:417: > +

[PATCH -next] staging: pi433: depends on SPI

From: Randy Dunlap <rdun...@infradead.org> The pi433 driver uses SPI interfaces so it should depend on SPI. Also, the "default n" can be removed since that is already the default. Fixes these build errors when SPI is not enabled: drivers/staging/pi433/pi433_if.o: In funct

[PATCH] staging: rtlwifi: fix multiple build errors

From: Randy Dunlap <rdun...@infradead.org> Fix many build errors when NETDEVICES is not enabled. Signed-off-by: Randy Dunlap <rdun...@infradead.org> Cc: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtlwifi/Kconfig |2 +- 1 file changed, 1 insert

Re: [PATCH 2/2] staging: greybus: enable compile testing of arche driver

On 05/15/17 07:26, Johan Hovold wrote: > Add Arche platform-driver config option and allow the driver to be > compile tested also without the usb3613 driver. > > Signed-off-by: Johan Hovold > --- > drivers/staging/greybus/Kconfig | 10 ++ >

Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency

On 08/23/2017 06:22 AM, Arnd Bergmann wrote: > Like the version in drivers/net/wireless, this driver requires the > MAC80211 framework, otherwise we run into a link error: > > ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined! > ERROR: "cfg80211_unlink_bss"

staging: fsl-mc-bus: using MSI?

Hi, I have seen a few randconfig builds where FSL_MC_BUS is enabled. This selects GENERIC_MSI_IRQ_DOMAIN -- even if CONFIG_PCI and CONFIG_PCI_MSI are not enabled. (This is with COMPILE_TEST enabled.) I see in the README.txt file that the DPAA2/MC does use some kind of message interrupts.

[PATCH -next] staging: ipx: depends on NET

From: Randy Dunlap <rdun...@infradead.org> IPX depends on NET, so add that to the Kconfig file. Fixes Kconfig warning and build errors: warning: (IPX) selects LLC which has unmet direct dependencies (NET) and 94 "undefined reference" build errors. Signed-off-by: Ra

Re: [PATCH] hyperv: make HYPERV a menuconfig to ease disabling it all

On 12/13/2017 11:51 PM, Greg KH wrote: > On Wed, Dec 13, 2017 at 01:23:38PM -0800, Stephen Hemminger wrote: >> On Wed, 13 Dec 2017 09:54:19 +0100 >> Vincent Legoll wrote: >> >>> Hello, >>> >>> On Sun, Dec 10, 2017 at 6:50 AM, Stephen Hemminger >>>

Re: [PATCH] staging: fsl-dpaa2: Fix multiple assignments should be avoided

akes much more sense, doesn't it? >>> >>> Sometimes checkpatch is wrong :) >> >> It feels like the majority of these multiple assignment warnings are >> wrong. I thought it would be a good idea at first but after looking at >> a bunch of the patches it fee

Re: [PATCH v3 13/14] media: imx7.rst: add documentation for i.MX7 media driver

Hi, I have a few editing suggestions below... On 05/07/2018 09:21 AM, Rui Miguel Silva wrote: > Add rst document to describe the i.MX7 media driver and also a working example > from the Warp7 board usage with a OV2680 sensor. > > Signed-off-by: Rui Miguel Silva > --- >

Re: [PATCH] staging: unisys: change select to depends for subsystems

On 01/15/18 06:54, Greg Kroah-Hartman wrote: > On Sun, Jan 14, 2018 at 09:10:54PM -0800, Randy Dunlap wrote: >> From: Randy Dunlap <rdun...@infradead.org> >> >> Drivers should not 'select' a subsystem. Instead they should depend >> on it. If the subsystem i

[PATCH] staging: unisys: change select to depends for subsystems

From: Randy Dunlap <rdun...@infradead.org> Drivers should not 'select' a subsystem. Instead they should depend on it. If the subsystem is disabled, the user probably did that for a purpose and one driver shouldn't be changing that. Signed-off-by: Randy Dunlap <rdun...@infradead.org&g

Re: [PATCH] Trivial numbering change in comments.

On 08/28/2018 03:03 PM, Nathan Chancellor wrote: > On Tue, Aug 28, 2018 at 04:08:18PM -0400, Ray Clinton wrote: >> I'm trying to get my feet wet in kernel dev and while working on a patch >> I noticed in a lengthy comment block that the number "2" was skipped >> in a description of the steps of a

[PATCH] staging/rtl8192u: fix defined but not used build warnings

From: Randy Dunlap Fix build warnings in rtl8192u when CONFIG_PROC_FS is not enabled by marking the unused functions as __maybe_unused. ../drivers/staging/rtl8192u/r8192U_core.c:508:12: warning: 'proc_get_stats_ap' defined but not used [-Wunused-function] ../drivers/staging/rtl8192u

Re: [PATCH] staging: dgnc: Fix Kconfig help header and text

On 9/25/18 11:46 AM, Greg Kroah-Hartman wrote: > On Tue, Sep 25, 2018 at 10:22:24AM -0600, sehro rautenkranz wrote: >> Replace Kconfig help header and text to match other modules. Issue found >> my checkpatch. >> >> Spacing adjusted to match Documentation/process/coding-style.rst. Issue >>

Re: [PATCH] staging: dgnc: Fix Kconfig help header and text

On 9/24/18 11:20 PM, sehro rautenkranz wrote: > Replace Kconfig help header and text to match other modules. Issue found > by checkpatch. > > Signed-off-by: sehro rautenkranz > --- Hi, Documentation/process/coding-style.rst says: Lines under a ``config`` definition are indented with one tab,

Re: [PATCH] staging: dgnc: Fix Kconfig help header and text

On 9/25/18 8:53 AM, sehro rautenkranz wrote: > Replace Kconfig help header and text to match other modules. Issue found > my checkpatch. by checkpatch. > > Spacing adjusted to match Documentation/process/coding-style.rst. Issue > reported by rdun...@infradead.org. Reported-b

Re: [PATCH] staging: erofs: Add function comment for erofs/inode.c

On 3/15/19 11:16 PM, Arshad Hussain wrote: > This patch adds functions comment for file erofs/inode.c in > sphinx format. > > Signed-off-by: Arshad Hussain > --- > drivers/staging/erofs/inode.c | 67 > +-- > 1 file changed, 64 insertions(+), 3

Re: [PATCH v2 2/3] media: imx7-media-csi: add i.MX6UL support

On 6/6/19 8:38 AM, Sébastien Szymanski wrote: > i.MX7 and i.MX6UL/L have the same CSI controller. So add i.MX6UL/L support > to imx7-media-csi driver. > > Signed-off-by: Sébastien Szymanski > --- > > Changes for v2: > - rebase on top of linuxtv/master > - mention i.MX6UL/L in header and

Re: [PATCH v2] staging: iio: adt7316: Fix build errors when GPIOLIB is not set

ver is a GPIO > consumer and not a GPIO driver. > > Reported-by: Randy Dunlap > Signed-off-by: Fabio Estevam Acked-by: Randy Dunlap # build-tested Thanks. > --- > Changes since v1: > - Remove - Phil > > drivers/staging/iio/addac/adt7316.c | 3 ++- > 1 file chan

Re: [PATCH v3 2/7] lib/hexdump.c: Relax rowsize checks in hex_dump_to_buffer

Hi, Just a comment style nit below... On 6/16/19 7:04 PM, Alastair D'Silva wrote: > From: Alastair D'Silva > > This patch removes the hardcoded row limits and allows for > other lengths. These lengths must still be a multiple of > groupsize. > > This allows structs that are not 16/32 bytes to

Re: [PATCH v2 3/7] lib/hexdump.c: Optionally suppress lines of repeated bytes

On 5/8/19 12:01 AM, Alastair D'Silva wrote: > From: Alastair D'Silva > > Some buffers may only be partially filled with useful data, while the rest > is padded (typically with 0x00 or 0xff). > > This patch introduces a flag to allow the supression of lines of repeated > bytes, which are

Re: linux-next: Tree for Aug 2 (staging/octeon/)

On 8/1/19 10:52 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190801: > on x86_64: when CONFIG_OF is not set/enabled. WARNING: unmet direct dependencies detected for MDIO_OCTEON Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] && 64BIT [=y] && HAS_IOMEM [=y]

Re: [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors

: Add dummy functions in of_mdio.h."). > > Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS") > Reported-by: kbuild test robot > Reported-by: Mark Brown > Reported-by: Randy Dunlap > Signed-off-by: Nathan Chancellor Works for me. Fixes the repor

Re: [PATCH v2] staging: greybus: add missing includes

On 8/28/19 1:35 AM, Greg Kroah-Hartman wrote: > On Tue, Aug 27, 2019 at 09:59:17PM +0100, Rui Miguel Silva wrote: >> Before moving greybus core out of staging and moving header files to >> include/linux some greybus header files were missing the necessary >> includes. This would trigger

Re: linux-next: Tree for Sep 2 (exfat)

On 9/2/19 10:46 AM, Greg KH wrote: > On Mon, Sep 02, 2019 at 10:39:39AM -0700, Randy Dunlap wrote: >> On 9/2/19 5:43 AM, Stephen Rothwell wrote: >>> Hi all, >>> >>> News: I will only be doing 2 more releases before I leave for Kernel >>> Summit (there m

Re: linux-next: Tree for Sep 2 (exfat)

On 9/2/19 5:43 AM, Stephen Rothwell wrote: > Hi all, > > News: I will only be doing 2 more releases before I leave for Kernel > Summit (there may be some reports on Thursday, but I doubt I will have > time to finish the full release) and then no more until Sept 30. > > Changes since 20190830: >

Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning

On 7/31/19 2:55 PM, Randy Dunlap wrote: > On 7/31/19 11:50 AM, Nathan Chancellor wrote: >> arm allyesconfig warns: >> >> WARNING: unmet direct dependencies detected for MDIO_OCTEON >> Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=

Re: [PATCH -next] staging: hp100: Fix build error without ETHERNET

to `free_netdev' > > Fixes: 52340b82cf1a ("hp100: Move 100BaseVG AnyLAN driver to staging") > Signed-off-by: YueHaibing Acked-by: Randy Dunlap # build-tested Thanks. > --- > drivers/staging/hp/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/driver

Re: [PATCH] staging: sm750fb: format description of parameters the to kernel doc format

Hi, On 10/16/19 6:18 PM, Gabriela Bittencourt wrote: > Cluster comments that describes parameters of functions and create one > single comment before the function in kernel doc format. Good plan. How did you test this patch? > Signed-off-by: Gabriela Bittencourt > --- >

Re: [PATCH] staging: sm750fb: format description of parameters the to kernel doc format

On 10/16/19 6:29 PM, gbittencourt wrote: > Hi Randy, > > On 10/16/19 10:25 PM, Randy Dunlap wrote: >> Hi, >> >> On 10/16/19 6:18 PM, Gabriela Bittencourt wrote: >>> Cluster comments that describes parameters of functions and create one >>> single com

Re: [PATCH] Documentation: DMA-API-HOWTO.txt: fixed grammer issues Fixed some of the grammer issues in DMA-API-HOWTO.txt using the software grammerly.

On 2/16/20 6:16 AM, sunnypranay wrote: > From: mpranay > s/grammer/grammar/ et al. Missing Signed-off-by: > --- > Documentation/DMA-API-HOWTO.txt | 628 +++ > drivers/staging/comedi/drivers.c | 2 +- The /comedi/ part of this patch should not be here... and

[PATCH] Documentation: android: binderfs: add 'stats' mount option

From: Randy Dunlap Add documentation of the binderfs 'stats' mount option. Description taken from the commit message. Fixes: f00834518ed3 ("binder: add a mount option to show global stats") Signed-off-by: Randy Dunlap Cc: Hridya Valsaraju Cc: Christian Brauner Cc: Christian B

Re: [PATCH] media: usbvision: depends on USB

eregister' > ld: drivers/staging/media/usbvision/usbvision-video.o: in function > `usbvision_init': > usbvision-video.c:(.init.text+0xf9): undefined reference to > `usb_register_driver' > ld: drivers/staging/media/usbvision/usbvision-i2c.o: in function > `usbvision_i2c_write':

Re: [PATCH] media: staging: rkisp1 Kconfig: depends on OF

> (ARCH_ROCKCHIP || COMPILE_TEST [=y]) && OF [=n] > Selected by [y]: > - VIDEO_ROCKCHIP_ISP1 [=y] && STAGING [=y] && STAGING_MEDIA [=y] && > MEDIA_SUPPORT [=y] && VIDEO_V4L2 [=y] && (ARCH_ROCKCHIP || COMPILE_TEST [=y]) > > Cc

Re: mmotm 2020-03-28-22-17 uploaded (staging/octeon/)

(skb); ^~~~ It looks like this inline function has been removed from . Looks like it should be this change: - skb_reset_tc(skb); + skb_reset_redirect(skb); -- ~Randy Reported-by: Randy Dunlap ___ deve

Re: [PATCH RFC] drivers: most: add USB adapter driver

On 5/11/20 2:51 AM, Christian Gromm wrote: > diff --git a/drivers/most/usb/Kconfig b/drivers/most/usb/Kconfig > new file mode 100644 > index 000..a86f1f6 > --- /dev/null > +++ b/drivers/most/usb/Kconfig > @@ -0,0 +1,14 @@ > +# SPDX-License-Identifier: GPL-2.0 > +# > +# MOST USB configuration >

Re: [PATCH v2 2/2] staging: gdm724x: gdm_tty: replaced macro with a function

On 9/2/20 10:07 AM, antoni.przyby...@wp.pl wrote: > On 02.09.2020 18:21, Randy Dunlap wrote: >> On 9/2/20 9:16 AM, Antoni Przybylik wrote: >>> Changed return type to bool and removed inline specifier. Also added >>>   static specifier. >> why remove the inline sp

Re: [PATCH v2 2/2] staging: gdm724x: gdm_tty: replaced macro with a function

On 9/2/20 9:16 AM, Antoni Przybylik wrote: > Changed return type to bool and removed inline specifier. Also added > static specifier. why remove the inline specifier? thanks. > Signed-off-by: Antoni Przybylik > --- > drivers/staging/gdm724x/gdm_tty.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [PATCH] Staging: android: ashmem: changed struct file_operations to const file_operations

On 10/15/20 10:11 PM, kiransu...@osuosl.org wrote: > From: kiransuren > > Fixed a coding style issue. > > Signed-off-by: Kiran Surendran > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c >

Re: [PATCH] staging: emxx_udc: Use standard BIT() macro

On 8/18/20 6:49 AM, Alex Dewar wrote: > Currently emxx_udc.h defines bit values using local macros. Use the > standard one instead. > > Also, combine bit values with bitwise-or rather than addition, as > suggested by Coccinelle. > > Signed-off-by: Alex Dewar Hi, Does this build? Just

Re: [PATCH v4 2/2] staging: android: Remove BUG from ion_system_heap.c

On 8/21/20 8:28 AM, Tomer Samara wrote: > Remove BUG() from ion_sytem_heap.c > > this fix the following checkpatch issue: > Avoid crashing the kernel - try using WARN_ON & > recovery code ratherthan BUG() or BUG_ON(). > > Signed-off-by: Tomer Samara > --- >

Re: [PATCH v4 2/2] staging: android: Remove BUG from ion_system_heap.c

On 8/22/20 2:34 AM, Tomer Samara wrote: > On Fri, Aug 21, 2020 at 09:25:26AM -0700, Randy Dunlap wrote: >> On 8/21/20 8:28 AM, Tomer Samara wrote: >>> Remove BUG() from ion_sytem_heap.c >>> >>> this fix the following checkpatch issue: >>>

Re: [PATCH 38/49] staging: hikey9xx/gpu: add kirin9xx driver to the building system

On 8/19/20 4:46 AM, Mauro Carvalho Chehab wrote: > Now that everything is in place, add the driver to the > building system. > > Signed-off-by: Mauro Carvalho Chehab Hi Mauro, In this patch and in patch 01/49, please be consistent in capitalization on HiSilicon. more below: > --- >

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

Hi, On 9/24/20 8:18 AM, Srinivasan Raju wrote: > diff --git a/drivers/staging/purelifi/Kconfig > b/drivers/staging/purelifi/Kconfig > new file mode 100644 > index ..db24bdf884a3 > --- /dev/null > +++ b/drivers/staging/purelifi/Kconfig > @@ -0,0 +1,42 @@ > +config WLAN_VENDOR_PURELIFI

[PATCH] android: binder.h: drop a duplicated word

Drop the repeated word "the" in a comment. Signed-off-by: Randy Dunlap Cc: Greg Kroah-Hartman Cc: Arve Hjønnevåg Cc: Todd Kjos Cc: Martijn Coenen Cc: Joel Fernandes Cc: Christian Brauner Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: de...@driverdev.osuosl.org --- include/

Re: [PATCH v3] sched: Provide USF for the portable equipment.

On 8/3/20 7:31 AM, Dongdong Yang wrote: > diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig > index 4ec5528..05b231e 100644 > --- a/drivers/staging/Kconfig > +++ b/drivers/staging/Kconfig > @@ -120,4 +120,6 @@ source "drivers/staging/qlge/Kconfig" > > source

Re: [PATCH] staging: wfx: fixed misspelled word in comment

On 8/4/20 7:58 AM, Aditya Bansal wrote: > From: Aditya Bansal > > Subject: [PATCH] fixed typo in driver/staging/wfx/hif_tx.c file > > Correct the spelling of function > > Signed-off-by: Aditya Bansal > --- > > diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c > index

Re: [PATCH v4] sched: Provide USF for the portable equipment.

On 8/4/20 12:50 AM, Dongdong Yang wrote: > From: Dongdong Yang > > --- > > diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu > b/Documentation/ABI/testing/sysfs-devices-system-cpu > index b555df8..e299418 100644 > --- a/Documentation/ABI/testing/sysfs-devices-system-cpu > +++

Re: [PATCH][next] staging: wfx: fix a handful of spelling mistakes

On 8/5/20 7:23 AM, Colin King wrote: > From: Colin Ian King > > There are various spelling mistakes in comments and error messages. > Fix these. > > Signed-off-by: Colin Ian King > --- > drivers/staging/wfx/data_rx.c | 2 +- > drivers/staging/wfx/data_tx.c | 2 +- >

Re: [PATCH][next][V2] staging: wfx: fix a handful of spelling mistakes

On 8/6/20 3:47 AM, Colin King wrote: > From: Colin Ian King > > There are various spelling mistakes in comments and error messages. > Fix these. > > Signed-off-by: Colin Ian King > --- > > V2: add in some more fixes as spotted by Randy Dunlap > > --- >

Re: [RESEND PATCH v5] drivers: most: add USB adapter driver

Hi-- On 7/27/20 1:30 AM, Christian Gromm wrote: > This patch adds the usb driver source file most_usb.c and > modifies the Makefile and Kconfig accordingly. > > Signed-off-by: Christian Gromm > --- > > drivers/most/Kconfig| 12 + > drivers/most/Makefile |2 + >

Re: [PATCH 3/3] staging: androind: Convert BUG() to WARN()

On 8/16/20 10:22 AM, Tomer Samara wrote: > replace BUG() with WARN() at ion_sytem_heap.c, this > fix the following checkpatch issue: > Avoid crashing the kernel - try using WARN_ON & > recovery code ratherthan BUG() or BUG_ON(). > > Signed-off-by: Tomer Samara > --- >

Re: [PATCH 01/17] staging: add support for NUC WMI LEDs

Hi Mauro, On 5/16/21 3:53 AM, Mauro Carvalho Chehab wrote: > diff --git a/drivers/staging/nuc-led/Kconfig b/drivers/staging/nuc-led/Kconfig > new file mode 100644 > index ..0f870f45bf44 > --- /dev/null > +++ b/drivers/staging/nuc-led/Kconfig > @@ -0,0 +1,11 @@ > +#

Re: [PATCH v3 1/7] seqnum_ops: Introduce Sequence Number Ops

Hi-- Comments are inline. On 2/3/21 10:11 AM, Shuah Khan wrote: > Sequence Number api provides interfaces for unsigned atomic up counters. > > There are a number of atomic_t usages in the kernel where atomic_t api > is used for counting sequence numbers and other statistical counters. > Several

Re: [PATCH]: checkpatch: Fixed styling issue

On 2/8/21 11:51 AM, Mukul Mehar wrote: More comments (probably duplicates): a. The "checkpatch:" in the subject says that you are making a patch to the "checkpatch" script. You are not doing that. The subject should be more like: "staging: most: fix a style issue in sound.c" e.g. b. This

Re: [PATCH V2] staging: rtl8723bs: Mundane typo fixes

On 3/22/21 1:16 PM, Bhaskar Chowdhury wrote: > s/stoping/stopping/ > s/arragement/arrangement/ > s/eralier/earlier/ > > Plus one extra word in the sentence "the" removed. > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > Changes fro

Re: [PATCH] staging: wimax: Mundane typo fixes

On 3/22/21 6:06 PM, Bhaskar Chowdhury wrote: > > s/procesing/processing/ > s/comunication/communication/ > > Signed-off-by: Bhaskar Chowdhury drivers/staging/wimax/ is in the process of being deleted. > --- > drivers/staging/wimax/i2400m/driver.c | 4 ++-- > 1 file changed, 2 insertions(+),

Re: [PATCH] media: atomisp-ov2680: A trivial typo fix

On 3/24/21 6:56 AM, Bhaskar Chowdhury wrote: > > s/miror/mirror/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/staging/media/atomisp/i2c/ov2680.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/stagi

Re: [PATCH V2]staging: rtl8723bs: Trivial typo fix

On 3/23/21 2:23 AM, Bhaskar Chowdhury wrote: > s/netowrk/network/ > > ..and an extra space has removed from the sentence. > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > Changes from V1: > I have missed to remove an extra space in the sent

  1   2   >