applies to next-20140723
Signed-off-by: sudip
---
drivers/staging/bcm/Transmit.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.c
index 05fae92..10586f8 100644
--- a/drivers/staging/bcm/Transmit.c
+++ b
about why you have added Greg and staging list instead
of 'linux-...@vger.kernel.org'.
--
Regards
Sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
The build of xtensa allmodconfig gives warning of:
In function 'rtw_cfg80211_unlink_bss':
warning: the frame size of 1136 bytes is larger than 1024 bytes
Instead of having 'select_network' structure as a variable use it as a
pointer.
Signed-off-by: Sudip Mukherjee
---
drive
On Tue, Nov 04, 2014 at 11:48:26PM +0200, Aya Mahfouz wrote:
> On Tue, Nov 04, 2014 at 03:06:53PM +0530, Sudip Mukherjee wrote:
> > On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote:
> > > This patch replaces dev_err by pr_err since the value
> > > of ir
ter if you add version number in the subject.
like this is v2.
thanks
sudip
>
> Signed-off-by: Aya Mahfouz
> ---
> drivers/staging/media/lirc/lirc_zilog.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/lirc/lirc_zilog.c
need to check it again.
Signed-off-by: Sudip Mukherjee
---
hi,
struct mlme_priv *pmlmepriv and bLinked was moved to the beginning of
the function, otherwise it was giving warning about mixed code while
compiling.
drivers/staging/rtl8188eu/core/rtw_xmit.c | 4 +---
drivers/staging/rtl8188eu/hal
a variable is declared and initialized and then never updated in the
function.This default value is then used as the return from the
function.
So removed that unneeded return variable and returning that default
initial value directly.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/rtl8188eu
the NULL check for memregion is not required as it has already been
checked for NULL after kzalloc. so we can reach this part of the code
only if memregion is not NULL.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/unisys/visorutil/memregion_direct.c | 6 ++
1 file changed, 2
we can reach the label Away in total five situation and in four of
of them pDevInfo is NULL. so we were basically dereferencing a NULL
pointer.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/unisys/visorchipset/visorchipset_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
On Sat, Nov 22, 2014 at 11:34:29AM +0530, Anjana Sasindran wrote:
> This patch fixes the checkpatch.pl error:
this patch is not applying to next-20141121.
>
> ERROR: trailing whitespace
but your patch is adding a blank line in the code ?
thanks
sudip
>
> Signed-off-by: A
see) for me to help in the driver :
1) i am a newbie. though i have learnt a lot from the patches i sent , but
still I am a newbie.
2) most important - I do not have the hardware. So from the TODO list dual head
and 2D acceleration support will be tough without actually checking on the
hardware.
thank
On Sat, Nov 22, 2014 at 01:20:13PM +0530, anjana s wrote:
> Just now I resend the same patch by making necessary changes.
> Kindly please go through it
you replied only to me. You should always use reply to all unless there is some
specific reason not to send the reply to all.
thanks
nt __init skein_generic_init(void)
return 0;
-
unreg512:
crypto_unregister_shash(&alg512);
unreg256:
thanks
sudip
>
> Signed-off-by: Anjana Sasindran
> ---
> drivers/staging/skein/skein_generic.c | 1 -
> 1 file changed, 1 deletion(-)
>
>
On Sat, Nov 22, 2014 at 06:00:40AM -0800, Greg Kroah-Hartman wrote:
> On Sat, Nov 22, 2014 at 12:32:02PM +0530, Sudip Mukherjee wrote:
> > 2) most important - I do not have the hardware. So from the TODO list
> > dual head and 2D acceleration support will be tough without actually
ntinue;
> }
>
> - /* Validate plug address against chunk data and identify chunk
> */
> + /* Validate plug address against chunk data
> + * and identify chunk */
this is not the style for multiline comment. plea
*Adapter,
> enum hal_def_variable eV
> {
> u64 DebugComponents = *((u64 *)pValue);
> struct odm_dm_struct *dm_ocm = &(haldata->odmpriv);
> +
> dm_ocm->DebugComponents = DebugComponent
On Sat, Nov 22, 2014 at 09:50:20PM +0530, Sudip Mukherjee wrote:
> On Sat, Nov 22, 2014 at 06:00:40AM -0800, Greg Kroah-Hartman wrote:
> > On Sat, Nov 22, 2014 at 12:32:02PM +0530, Sudip Mukherjee wrote:
> > > 2) most important - I do not have the hardware. So from the TODO li
these header files were included two times
Signed-off-by: Sudip Mukherjee
---
drivers/staging/unisys/include/timskmod.h | 1 -
drivers/staging/unisys/uislib/uisutils.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/include/timskmod.h
b/drivers/staging/unisys
On Tue, Dec 02, 2014 at 01:46:54AM -0800, Jeremiah Mahler wrote:
> Sudip,
>
> On Tue, Dec 02, 2014 at 02:34:58PM +0530, Sudip Mukherjee wrote:
> > these header files were included two times
> >
> > Signed-off-by: Sudip Mukherjee
> > ---
> > driver
these header files were included multiple times
Signed-off-by: Sudip Mukherjee
---
change in v2: missed seeing that linux/uuid.h is included 3 times
drivers/staging/unisys/include/timskmod.h | 1 -
drivers/staging/unisys/uislib/uisutils.c | 2 --
2 files changed, 3 deletions(-)
diff --git a
pe of fix
in a patch.
2) your Signed-off and your From mentioned in the commit message are different
3) From should have a full name
thanks
sudip
> drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 948
> ---
> 1 file changed, 478 insertions(+), 470 deletion
esc_status(struct sk_buff *skb,
>
> }
>
> -u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status, bool
> bIsRxAggrSubframe)
> +static u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats *Status,
> + bool bIsRxAggrSubframe)
and h
On Tue, Dec 02, 2014 at 07:30:40PM -0600, Paul Hedman wrote:
> Fixes spacing issues around operators, e.g. i=0 to i = 0, as
> found by the checkpatch.pl tool.
no Signed-off-by ???
please run your patch through checkpatch before sending.
thanks
sudip
> ---
> drivers/staging/ft100
On Tue, Dec 02, 2014 at 11:45:00PM +, Sean Cleator wrote:
>
> A patch to the slicoss.c file to fix some of the long line issues found by
> the
> checkpath.pl tool
> Signed-off-by: Sean Cleator
do not use whitespace before Signed-off-by
thanks
sudip
>
> ---
>
aRate);
>
> -u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
> +static u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
> u8 bShortPreamble)
u missed this alignment
thanks
sudip
> {
> u16 FrameTime;
> @@ -1553,7 +1553,8
fixed?
your v2 was having one problem of alignment, but v3 is again having 3 problems.
and your patch doesnot apply to next-20141203
sudip
>
> drivers/staging/rtl8192u/r8192U_core.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/stag
On Thu, Dec 04, 2014 at 04:12:47PM +0800, Fred Chou wrote:
>
>
> On 4/12/2014 3:34 PM, Sudip Mukherjee wrote:
> > On Thu, Dec 04, 2014 at 10:50:43AM +0800, Fred Chou wrote:
> >> From: Fred Chou
> >>
> >> Fixed the following warnings in sparse:
> &
On Thu, Dec 04, 2014 at 05:34:11PM +0800, Fred Chou wrote:
>
>
> On 4/12/2014 4:30 PM, Sudip Mukherjee wrote:
> > On Thu, Dec 04, 2014 at 04:12:47PM +0800, Fred Chou wrote:
> >>
> >>
> >> On 4/12/2014 3:34 PM, Sudip Mukherjee wrote:
> >>> On
On Fri, Dec 05, 2014 at 04:25:22PM +0530, Athira Lekshmi wrote:
> Fixed the checkpatch warning:
> Missing a blank line after declarations
this is not applying to next-20141204.
sudip
>
> Signed-off-by: Athira Lekshmi
> ---
> drivers/staging/octeon/ethernet-rx.c |1 +
&g
On Fri, Dec 05, 2014 at 10:10:43PM +0100, Mariusz Gorski wrote:
> Get rid of magic numbers in LCD commands and replace them with defined
> values, so that it's more obvious that the commands are doing.
>
it is not applying to next-20141205. is it based on staging-testing ?
thanks
s
f two more magic number usages
this one also not applying to next-20141205. is it on staging-testing?
thanks
sudip
>
> drivers/staging/panel/panel.c | 96
> +--
> 1 file changed, 66 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/stag
not applying to next-20141205
sudip
> drivers/staging/vt6655/mac.c | 42
> --
> drivers/staging/vt6655/mac.h |1 -
> 2 files changed, 43 deletions(-)
>
> diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c
On Mon, Dec 08, 2014 at 11:33:25PM +0530, Adithya K wrote:
> From: Adithya Krishnamurthy
>
> Fixed sparse warning fix.
you should mention what type of warning you have fixed.
sudip
>
> Signed-off-by: Adithya Krishnamurthy
> ---
> ---
> drivers/staging/vt6655/device
; +#define ADIS16203_SMPL_PRD 0x36 /* Internal sample period (rate)
> +* control */
this is not the style for multiline comments. Check in CodingStyle.
and besides, I think it will be better if you can put the comments in a line of
its own.
thanks
sudip
> #define
dev->iobase + DMM32AT_INTCLK_REG);
}
static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice
*s)
thanks
sudip
> }
>
> static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice
> *s)
> --
> 2.2.0.rc0.207.ga3a616
On Fri, Dec 26, 2014 at 10:00:00AM +, Jonathan Cameron wrote:
> On 22/12/14 13:48, Sudip Mukherjee wrote:
> > On Mon, Dec 22, 2014 at 02:23:42AM +0100, Helene Gsaenger wrote:
> >> Signed-off-by: Helene Gsaenger
> >> Signed-off-by: Simone Weiss
> >>
your tree is not a current one. This
DEBUG line was changed by patch "b5d8204d00fa3bcd1f3b4b060fb90675d00baee0"
thanks
sudip
>
> + ret = ft1000_read_register(ft1000dev, &temp, FT1000_REG_DOORBELL);
> + if (ret)
> + return ret;
> +
> com
; drivers/staging/line6/pcm.h:162: ERROR: space prohibited before that ','
> (ctx:WxE)
I am sure Jeremiah Mahler actually wanted to tell you that you should include
that information in the commit log. We always mention what kind of error was
fixed.
thanks
sudip
>
>
>
atches. One patch should do only one type of change.
thanks
sudip
>
> Signed-off-by: Jitendra Kumar Khasdev
> ---
> drivers/staging/comedi/drivers/s626.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/s626.c
ch with 2 tabs
> instead of current v2 indentation, I'll do it, please let me know.
well, if you check CodingStyle in Documentation, it clearly says:
"Outside of comments, documentation and except in Kconfig, spaces are never
used for indentation".
Sudip
>
> On Fri, Dec
;WARNING: "libcfs_arch_init" [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
undefined!"
"WARNING: "libcfs_arch_cleanup"
[drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined!"
thanks
sudip
>
> Serguey
> --
> To unsubscribe from this list: send
the check for htotal and vtotal is not required as we have already
checked for them and returned -EINVAL if any of them is zero.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/xgifb/XGI_main_26.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb
add myself and Teddy Wang as the Maintainer of the
SM7XX FRAME BUFFER DRIVER.
Signed-off-by: Sudip Mukherjee
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6e18e65..4ffe882 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9178,6
update the email addresses in the TODO file, also update the final
destination of this driver.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm7xxfb/TODO | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm7xxfb/TODO b/drivers/staging/sm7xxfb
This reverts commit "dc93c85235efa5201e9a3c116bc3fbd1afc1a182"
Signed-off-by: Sudip Mukherjee
---
Hi Greg K-H
With reference to our discussion at https://lkml.org/lkml/2014/11/22/54 ,
now I have the hardware and I will be working on the code along with
Teddy Wang.
drivers/stagi
On Wed, Dec 31, 2014 at 09:33:43PM +, Lorenzo Stoakes wrote:
> This patch fixes warnings/errors raised by checkpatch.pl relating to
> whitespace
> in r8192U_dm.c and additionally it removes inconsistent whitespace
> throughout.
>
> Additionally some 0x00... padding has been added for alignmen
On Wed, Dec 31, 2014 at 09:10:42PM +, Lorenzo Stoakes wrote:
> This patch fixes warnings/errors raised by checkpatch.pl relating to redundant
> code in r8192U_dm.c.
>
> Signed-off-by: Lorenzo Stoakes
> ---
> drivers/staging/rtl8192u/r8192U_dm.c | 176
> +--
>
On Thu, Jan 01, 2015 at 10:19:56AM +0530, Sudip Mukherjee wrote:
> On Wed, Dec 31, 2014 at 09:10:42PM +, Lorenzo Stoakes wrote:
> > This patch fixes warnings/errors raised by checkpatch.pl relating to
> > redundant
> > code in r8192U_dm.c.
> >
> &g
On Wed, Dec 31, 2014 at 09:40:13PM -0800, Joe Perches wrote:
> On Thu, 2015-01-01 at 10:17 +0530, Sudip Mukherjee wrote:
> > On Wed, Dec 31, 2014 at 09:33:43PM +, Lorenzo Stoakes wrote:
> > > This patch fixes warnings/errors raised by checkpatch.pl relating to
> &g
anually? let git do it..
thanks
sudip
> ---
> drivers/staging/comedi/drivers/pcl812.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl812.c
> b/drivers/staging/comedi/drivers/pcl812.c
> index ac243ca..24eb601 1006
why you are sending different patches to do the same type of change in
comedi?
usually we send different patches to do different types of change, but for the
same type of change it can be a single patch.
sudip
> ---
> drivers/staging/comedi/drivers/pcl812.c | 3 ++-
> 1 file change
patch.
this (your comment) should not come in the commit message.
It should be placed below the ---
sudip
>
> Signed-off-by: Jitendra Kumar Khasdev
> ---
> drivers/staging/comedi/drivers/pcl812.c | 13 -
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> di
gt; > play nicely with standard indentation from git log.
>
> Hey,
>
> I couldn't find that rule in Kernel documentation. Besides there were no
> complaints from checkpatch.pl tool.
Please check SubmittingPatches in Documentation. It says:
'the "summary" must
On Tue, Jan 06, 2015 at 10:08:37AM +, Ian Abbott wrote:
> On 06/01/15 06:02, Sudip Mukherjee wrote:
> >On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote:
> >>On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote:
> >>>On 01/04, Piotr Kubus w
On Tue, Jan 06, 2015 at 02:33:27PM +0100, Konrad Zapalowicz wrote:
> On 01/06, Sudip Mukherjee wrote:
> > yes, i read the SubmittingPatches again. summary is the subject line. But
> > then as Piotr Kubus has written that he could not find this rule in the
> > documentaion,
- a/drivers/staging/vt6656/rxtx.c
> +++ b/drivers/staging/vt6656/rxtx.c
> @@ -574,8 +574,6 @@ static u16 vnt_fill_cts_head(struct vnt_usb_send_context
> *tx_context,
>
> return vnt_rxtx_datahead_g(tx_context, &buf->data_head);
> }
> -
>
On Mon, Jan 12, 2015 at 09:58:17PM -0800, Greg KH wrote:
> On Tue, Jan 13, 2015 at 10:53:12AM +0530, Sudip Mukherjee wrote:
> > On Tue, Jan 13, 2015 at 03:51:36AM +1100, Emrys Bayliss wrote:
> > > This patch fixes the following checkpatch.pl error:
> > > rxtx.c:588: WAR
On Tue, Jan 13, 2015 at 11:54:27AM +0530, Sudip Mukherjee wrote:
> On Mon, Jan 12, 2015 at 09:58:17PM -0800, Greg KH wrote:
> > On Tue, Jan 13, 2015 at 10:53:12AM +0530, Sudip Mukherjee wrote:
> > >
> > > any reason why this return was removed ?
> >
> > B
...@lists.freedesktop.org
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm750fb/TODO | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/TODO b/drivers/staging/sm750fb/TODO
index f710ab1..aeb2df3 100644
--- a/drivers/staging/sm750fb/TODO
+++ b/drivers/staging
marking
keypad_initialized and lcd.initialized as false. so this part of the
code will never execute.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/panel/panel.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index
On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote:
> On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote:
>
> I hadn't looked at this driver much before. It sucks that
> parport_driver ->attach() functions can't fail...
then maybe, we can c
ot declared. Should it be static?
you have not build tested your patch.
WARNING: "cfs_sched_rehash" [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
undefined!
it has been used in lustre/lustre/libcfs/module.c
regards
sudip
>
___
devel mai
On Tue, Apr 07, 2015 at 11:44:29AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote:
> > On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote:
> > > On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote:
>
On Tue, Apr 07, 2015 at 12:45:23PM +0300, Dan Carpenter wrote:
> On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote:
>
> If you write the patch then I will review it. :)
sure, I am on it.
>
> > lack of ppscsi.I mailed Tim Waugh, but he is not interested to wo
return -ENOMEM;
won't this create memory leak ?
suppose you have brd->nasync = 3
and kzalloc fails when i=2, and you return -ENOMEM,
then what happens to the memory already allocated to brd->channels[0]
and brd->channels[1] ?
regards
sudip
me know
when it was sent..
And I must say sorry for missing a new file creation in a patch.
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Apr 07, 2015 at 11:01:57AM -0300, Fabio Estevam wrote:
> On Tue, Apr 7, 2015 at 10:56 AM, Sudip Mukherjee
> wrote:
> > Hi Greg,
> > I saw that you have reveretd one commit
> > <6ad6b5ed3e2472b399b567a2f036006bf25df467>
> > "Staging: sm750fb: Fix C9
Ie parallel port NIC
> I guess.
i already have pc with parallel port, and on that i check your panel
codes before sending. but here we were discussing about the required
hardware to test ppscsi module.
regards
sudip
>
> Cheers,
> Willy
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
can try to get information about a board that failed to probe) checks if
> ->channels[foo] is NULL or not because probe failing if we can't allocate
> enough
> memory means that this scenario isn't possible.
i think now it becam
On Tue, Apr 07, 2015 at 11:24:43AM -0300, Fabio Estevam wrote:
> On Tue, Apr 7, 2015 at 11:08 AM, Sudip Mukherjee
> wrote:
>
> >> Just run 'git show 6ad6b5ed3e247' in linux-next and you can see such
> >> commit.
> > I have already seen the patch. Bu
On Tue, Apr 07, 2015 at 12:12:06PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 07, 2015 at 03:26:58PM +0530, Sudip Mukherjee wrote:
> > On Tue, Apr 07, 2015 at 11:44:29AM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote:
&
On Tue, Apr 07, 2015 at 04:34:54PM +0200, Greg KH wrote:
> On Tue, Apr 07, 2015 at 07:26:53PM +0530, Sudip Mukherjee wrote:
> > Hi Greg,
> > I saw that you have reveretd one commit
> > <6ad6b5ed3e2472b399b567a2f036006bf25df467>
> > "Staging: sm750fb: Fix C99 C
On Tue, Apr 07, 2015 at 02:25:39PM +, Dhere, Chaitanya (C.) wrote:
> This change was detected with the help of coccinelle tool.
> It performs the same function as kzalloc amd memcpy.
>
> Signed-off-by: Chaitanya Dhere
your From: name and this name does not match.
r
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
sound/drivers/portman2x4.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/sound/drivers
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-butterfly.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi
code from parport_register_driver.
Sudip Mukherjee (14):
parport: return value of attach and parport_register_driver
ALSA: portman2x4: return proper error values from attach
ALSA: mts64: return proper error values from attach
staging: panel: return proper error values from attach
spi
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
sound/drivers/mts64.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/sound/drivers/mts64.c b
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/panel/panel.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/scsi/imm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/imm.c b/drivers/scsi
only mark attach as failed only if it has never
returned a 0.
Signed-off-by: Sudip Mukherjee
---
drivers/parport/share.c | 20 +++-
include/linux/parport.h | 2 +-
2 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/drivers/parport/share.c b/drivers/parport/share.c
index
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/scsi/ppa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ppa.c b/drivers/scsi
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
also return the proper error code in module_init.
Signed-off-by: Sudip Mukherjee
---
drivers/net/plip/plip.c | 16 ++--
1 file changed, 10 insertions
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/pps/generators/pps_gen_parport.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-lm70llp.c b
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/i2c/busses/i2c-parport.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/pps/clients/pps_parport.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/pps/clients
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/char/lp.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/char/lp.c b
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee
---
drivers/char/ppdev.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/char/ppdev.c b
's a
> minor thing. Does this actually simplify the driver code? That's the
> more important thing.
i don't think this will simplify the driver code, but atleast now
parport_register_driver() will not report success when we have actually
failed. And as a result module_init will
ot then we give up.
i am sending a v2 and also a patch to change one driver.
regards
sudip
>
> regards,
> dan carpenter
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Apr 08, 2015 at 04:32:57PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 4/8/2015 2:20 PM, Sudip Mukherjee wrote:
>
> >now that we are monitoring the return value from attach, make the
>
>So you've first changed the method prototype and follow up wit
t tty_struct *tty,
ushort tail;
ushort tmask;
uint remain;
- int from_user = 0;
if (tty == NULL || dgnc_TmpWriteBuf == NULL)
return 0;
regards
sudip
___
devel mailing list
de...@linuxdrive
On Sat, Apr 11, 2015 at 03:20:43PM +0300, Giedrius Statkevičius wrote:
> On Sat, 11 Apr 2015, Sudip Mukherjee wrote:
>
> > On Fri, Apr 10, 2015 at 05:48:54PM +0300, Giedrius Statkevičius wrote:
> Well, I think this is wrong because:
yes. I looked at many of the tty drivers and a
parport starts using device-model and we now have parport under
/sys/bus. As the ports are discovered they are added as device under
/sys/bus/parport. As and when other drivers register new device,
they will be registered as a subdevice under the relevant parport.
Signed-off-by: Sudip Mukherjee
converted.
I am also in the process of procuring a parallel port printer so that
the code can properly be maintained and can be marked as Maintained.
Sudip Mukherjee (4):
parport: modify parport subsystem to use devicemodel
parport: update TODO and documentation
i2c-parport: use device-model
modified the functions to use the new device-model of parport.
Signed-off-by: Sudip Mukherjee
---
drivers/i2c/busses/i2c-parport.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/busses/i2c-parport.c b/drivers/i2c/busses/i2c-parport.c
index
as parport starts using the device-model, update the documentation
to show the newly added functions and update TODO with some other
planned modifications.
Signed-off-by: Sudip Mukherjee
---
Documentation/parport-lowlevel.txt | 49 ++
drivers/parport/TODO
modified the required functions to start using the new parport
device-model
Signed-off-by: Sudip Mukherjee
---
drivers/staging/panel/panel.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
ts in v2 of this patch series.
>
> On Wed, Apr 15, 2015 at 01:18:41PM +0530, Sudip Mukherjee wrote:
> Don't print warnings on kmalloc() failure.
>
> I think kzalloc() is better here. That way if the ->init_state()
> functions don't set it, then we kn
On Wed, Apr 15, 2015 at 11:33:59AM +0300, Dan Carpenter wrote:
> On Wed, Apr 15, 2015 at 01:18:41PM +0530, Sudip Mukherjee wrote:
>
>
> The difference between parport_register_device() and
> parport_register_dev() isn't clear from the name.
i kept the name similar deliberate
1 - 100 of 1045 matches
Mail list logo
