On Sun, Oct 02, 2016 at 02:30:45AM +0530, Harman Kalra wrote:
> static int iss_video_queue_setup(struct vb2_queue *vq,
> - unsigned int *count, unsigned int *num_planes,
> - unsigned int sizes[], struct device
> *alloc_devs[])
> +
On Thu, Sep 22, 2016 at 10:52:18PM +0200, becher.jan...@gmail.com wrote:
> I always wondered why I shouldn't make more than one change in a patch,
> but in all talks I watched they said that it's easier for them to merge
> small patches.
> So you think I should make one "big" patch and resend it?
>
On Thu, Sep 22, 2016 at 09:11:46PM +0200, Jannik Becher wrote:
> removed a space after a cast to obtain the coding style.
>
> Signed-off-by: Jannik Becher
> ---
> drivers/staging/wlan-ng/p80211req.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng
On Tue, Sep 06, 2016 at 03:19:03PM +0200, Fernando Apesteguia wrote:
> Sorry, but I fail to see how I can align all the lines by changing just the
> first and last ones.
Ah now I see that original version doesn't have spaces before asterisk.
Sorry for noise.
__
On Mon, Sep 05, 2016 at 08:28:32PM +0200, Fernando Apesteguia wrote:
> Fix alignment in multi line comment block.
>
> Remove extra '*' to use the preferred comment style as in
> Documentation/CodingStyle
>
> Signed-off-by: Fernando Apesteguia
>
> ---
> drivers/staging/dgnc/dgnc_driver.c | 50
On Fri, Aug 26, 2016 at 06:35:51PM -0400, Anson Jacob wrote:
> I only found one trailing whitespace issue in the patchset.
Yes, there's just one.
> Are my commits are too long. Am I supposed to submit shorter ones.
In my opinion your commits are generally fine.
__
On Fri, Aug 26, 2016 at 02:33:08PM -0400, Anson Jacob wrote:
>
> - /* Default_FS contains the full scale that is used if the user does */
> - /* not set a full scale. */
> + /*
Applying: staging: comedi: jr3_pci.h: Fix checkpatch warning
.git/rebase-apply/patch:226: trailing whitesp
On Thu, Aug 25, 2016 at 12:09:23PM -0400, Anson Jacob wrote:
> On Thu, Aug 25, 2016 at 06:47:08PM +0300, Andrey Utkin wrote:
> >
> > > +#define CHANNEL_BITS(x) ((x) & 0x7)
> > > +#define CHANNEL_MASK 0x7
> >
> > No uniform alignm
On Thu, Aug 25, 2016 at 11:16:13AM -0400, Anson Jacob wrote:
> Fix checkpatch.pl warning 'line over 80 characters'
>
> Signed-off-by: Anson Jacob
> ---
> drivers/staging/comedi/drivers/ni_at_a2150.c | 82
>
> 1 file changed, 46 insertions(+), 36 deletions(-)
>
> di
On Thu, Aug 25, 2016 at 11:10:25AM -0400, Anson Jacob wrote:
> Fix checkpatch.pl 'line over 80 characters' warning
>
> Signed-off-by: Anson Jacob
> ---
> drivers/staging/android/lowmemorykiller.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/androi
Found and fixed few very minor coding style nits, will resubmit in few days,
now still waiting for comments to v4.
https://github.com/bluecherrydvr/linux/commits/tw5864
commit 31f7c98a144cb3fb8a94662f002d9b6142d1f390
Author: Andrey Utkin
Date: Wed Jul 13 05:00:28 2016 +0300
Fix
On Mon, Jul 11, 2016 at 09:40:53AM -0700, Joe Perches wrote:
> Each of these blocks will start with the dev_ prefix
> and the subsequent lines will not have the same prefix
Yes. I have checked how it looks before submitting, but I didn't see
this as a problem. I don't mind changing that (anyway I
Thanks for review Hans!
On Mon, Jul 11, 2016 at 07:58:38AM +0200, Hans Verkuil wrote:
> > +" v4l2-ctl --device $dev --set-ctrl=video_gop_size=1; done\n"
>
> Replace $dev by /dev/videoX
>
> Wouldn't it make more sense to default to this? And show the warning only if
> P-frames are enabled?
I bel
known video quality
issues in a printed warning...").
On Fri, Jul 01, 2016 at 03:35:40PM +0200, Hans Verkuil wrote:
> On 06/10/2016 12:11 AM, Andrey Utkin wrote:
> > + cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
>
> This line can be dropped: the v4l2
On Tue, Jun 14, 2016 at 07:09:50PM +0200, H. Nikolaus Schaller wrote:
>
> > Am 14.06.2016 um 19:02 schrieb Andrey Utkin :
> > Update: found drivers/input/joystick/as5011.c in mainline kernel,
> > will look how it works with as5013 hardware.
>
> Before you spend too muc
On Tue, Jun 14, 2016 at 02:45:23PM +0300, Andrey Utkin wrote:
> There's a pair of "nub" devices on Pyra handheld PC
> ...
Update: found drivers/input/joystick/as5011.c in mainline kernel,
will look how it works with as5013 hardware.
There's a pair of "nub" devices on Pyra handheld PC
(https://pyra-handheld.com/), and there's driver for nub, which is going
to be reworked for upstreaming. While the device itself fits most to
"joystick" category, the computer itself lacks touchpad and mouse
buttons, and the existing driver is cap
Update: added local change
- to require fewer DMA buffers;
- to require fewer vb2_queue buffers;
- don't require vb2_queue buffers to be DMA-capable.
https://github.com/bluecherrydvr/linux/commit/410a86b08d230ff2a401ac9f5be3b30f8b29f30d
___
devel maili
Could anybody please give a hint - which kernel-defined i2c objects, and how
many of them, I need to define and use to substitute these driver-defined
functions i2c_read(), i2c_write() ?
https://github.com/bluecherrydvr/linux/blob/release/tw5864/1.16/drivers/media/pci/tw5864/tw5864-config.c
In a wo
larly contacting manufacturer regarding such issues, but
unfortunately they can do little to help us.
Andrey Utkin (1):
Add tw5864 driver
MAINTAINERS |7 +
drivers/staging/media/Kconfig|2 +
drivers/staging/media/Makefile |
From: Andrey Utkin
This is a driver for multimedia devices based on Techwell/Intersil TW5864 chip.
It is basically written from scratch. There was an awful reference driver for
2.6 kernel, which is nearly million lines of code and requires half a dozen
special userspace libraries, and still
On Fri, 11 Mar 2016 10:59:02 +0100
Hans Verkuil wrote:
> While userspace may specify FIELD_ANY when setting a format, the
> driver should always map that to a specific field setting and should
> never return FIELD_ANY back to userspace.
>
> In this case, the 'field' field of the v4l2_buffer struc
On Fri, 11 Mar 2016 09:00:18 +0100
Hans Verkuil wrote:
> The reason is likely to be the tw5864_queue_setup function which has
> not been updated to handle CREATE_BUFS support correctly. It should
> look like this:
>
> static int tw5864_queue_setup(struct vb2_queue *q,
>
Hi Hans!
Some improvements took place on the driver, including cleaner
v4l2-compliance tests passing. But there's a single test failure I
don't understand.
In the code of v4l2-compliance, it seems like an API
call CREATE_BUFS is supposed to fail with EINVAL. But in case of my
driver, which simply
On Mon, Feb 8, 2016 at 11:58 AM, Hans Verkuil wrote:
> Hi Andrey,
>
> Hmm, it looks like I forgot to reply. Sorry about that.
Thank you very much anyway.
> I wouldn't change the memcpy: in my experience it is very useful to get a
> well-formed compressed stream out of the hardware. And the overh
On Mon, Jan 11, 2016 at 12:52 PM, Hans Verkuil wrote:
> Did you also test with v4l2-compliance? Before I accept the driver I want to
> see the
> output of 'v4l2-compliance' and 'v4l2-compliance -s'. Basically there
> shouldn't be
> any failures.
>
> I did a quick scan over the source and I saw n
FIG_DYNAMIC_DEBUG)
so I can wrap my stats variables into this statement instead. But such
change is not equivalent - I guess CONFIG_DYNAMIC_DEBUG is common to
be enabled, so debug stats will be always calculated, even when module
is not under debug. Except if I use DEFINE_DYNAMIC_DEBUG_METADATA etc.
On Tue, Dec 29, 2015 at 9:32 AM, Mauro Carvalho Chehab
wrote:
> IMHO, there are two problems by letting indent breaking long
> lines:
>
> 1) indent would break strings on printks. This is something that we don't
> want to break strings on multiple lines in the Kernel;
Yeah, GNU indent does its wo
here it is:
https://github.com/bluecherrydvr/linux.git , branch tw5864_stable,
drivers/staging/media/tw5864
Current output of "checkpatch.pl -f" for all source files in the
driver is here:
https://gist.github.com/andrey-utkin/12295148475e34ef948b
Thanks in advance.
__
On Sat, Sep 26, 2015 at 10:44 AM, Max Lapshin wrote:
> Do you get some packets from this device or it is a bytestream?
Oh hi a linux.org.ru buddy :)
I get headerless binary data portions of known length, one portion for
each encoded video frame. NAL headers generation is done on driver
level in r
I'm working on Linux kernel driver for multimedia grabber and H264
encoder based on Techwell/Intersil 5864 chip. Of course it will be
open and pushed into upstream kernel.
The device produces H264 encoded data, but it lacks any headers. The
reference driver generates headers and glues frames toget
and nowhere else.
Ok, staying away and looking for sparse warnings for other staging drivers.
Thanks to all for comments.
--
Andrey Utkin
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
xpression
drivers/staging/fbtft/fbtft_device.c:32:19: warning: symbol 'spi_device' was
not declared. Should it be static?
drivers/staging/fbtft/fbtft_device.c:33:24: warning: symbol 'p_device' was not
declared. Should it be static?
This is for Eudyptulla challenge. If y
The host was rebooted and got back online.
Without irqbalance daemon, all solo6x10 interrupts are still on CPU0.
See https://gist.github.com/krieger-od/d1686243c67fbe3e14a5
Any ideas are strongly appreciated.
--
Andrey Utkin
___
devel mailing list
de
launch on boot. Rebooted, and the host got down up to now :(
Any comments, except laugh? :)
--
Andrey Utkin
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
it's in the merge window and I'll pick new staging patches back up
> when 3.19-rc1 is released.
Hi Greg,
Still no commits for
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c since Sun Nov
23 (staging: lustre: Coalesce string fragments) in linux-next. Maybe
the afore
ning messages about casting without
> __user macro" that Al's patch was in the staging tree for 3.19-rc1.
In current linux-next, I see none of the mentioned patches. Also I
don't see them mentioned in GKH's merge commit "Merge tag
'staging-3.19-rc
2015-01-07 10:36 GMT+02:00 Dan Carpenter :
> Didn't Al change these to kvec instead of iovec? You have to look at
> the callers to figure out if it's actually a user space pointer or a
> kernel pointer.
I am looking at current linux-next checkout
ct
type in argument 2 (different address spaces)
drivers/staging/lustre/lnet/lnet/lib-move.c:209:26:expected void const *from
drivers/staging/lustre/lnet/lnet/lib-move.c:209:26:got void
[noderef] *
What is supposed way to avoid warnings in this case?
Thanks.
--
Andrey Utkin
__
This fixes warning from drivers/media/v4l2-core/videobuf2-core.c,
WARN_ON(atomic_read(&q->owned_by_drv_count)).
Signed-off-by: Andrey Utkin
---
drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/me
2014-11-03 19:15 GMT+04:00 Hans Verkuil :
> Hi Andrey,
>
> On 10/29/2014 05:03 PM, Andrey Utkin wrote:
>> The used approach actually cannot prevent new encoder interrupt to
>> appear, because interrupt handler can execute in different thread, and
>> in current impleme
-off-by: Andrey Utkin
---
drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
index b9b61b9..30e09d9 100644
--- a/drivers/media/pci/solo6x10/solo6x10-v4l2
] [] debug_dma_alloc_coherent+0x3c/0xb0
[ 956.730240] [] solo_enc_v4l2_init+0x706/0xba0 [solo6x10]
[ 956.730243] [] solo_pci_probe+0x503/0x700 [solo6x10]
[ 956.730245] [] local_pci_probe+0x49/0xa0
[ 956.730248] [] pci_device_probe+0xd1/0x120
Signed-off-by: Andrey Utkin
---
drivers/media
Before, it was called from individual encoder (de)init procedures, which
lead to spare threads running (which were actually lost, leaked).
The current fix uses trivial approach, and the downside is that the
processing thread is working always, even when there's no consumer.
Signed-off-by: A
This fixes warning from drivers/media/v4l2-core/videobuf2-core.c:2144
Signed-off-by: Andrey Utkin
---
drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
b/drivers/media
ing_mode) and description in drivers/staging/bcm/target_params.h
("bit 1 = 1: CINR reporting in Idlemode Msg").
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80801
Reported-by: David Binderman
Signed-off-by: Andrey Utkin
---
drivers/staging/bcm/Misc.c | 2 +-
1 file changed,
Dropped some "< 0" and ">= 0" checks on unsigned int values.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80501
Reported-by: David Binderman
Signed-off-by: Andrey Utkin
---
.../comedi/drivers/addi-data/hwdrv_apci3200.c| 20 ++--
1 f
13-C: "Use bitwise operators only on unsigned operands"
https://www.securecoding.cert.org/confluence/display/seccode/INT13-C.+Use+bitwise+operators+only+on+unsigned+operands
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80521
Reported-by: David Binderman
Signed-off-by: Andrey
2014-07-11 17:38 GMT+03:00 Ian Abbott :
> Signed-off-by: Andrey Utkin
I think it's incorrect that you have instantly placed my signoff
statement on this new patch.
Anyway, thanks for your work on the issue.
--
Andrey Utkin
___
devel mailing
2014-07-11 15:01 GMT+03:00 Ian Abbott :
> On 2014-07-11 11:13, Andrey Utkin wrote:
>>
>> The issue was discovered with static analysis and has two instances in
>> this file. The code looks like this
>> if (x < 65536000) {
>> ...
>> } else if (x <
So it makes sense to make an "else" block from last "else if" case. The
code inside the block seems correct for such usage.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=79871
Reported-by: David Binderman
Signed-off-by: Andrey Utkin
---
drivers/staging/comedi/driver
Previously, it was needed to reopen device to update GOP size and
quantization parameter. Now we update device registers with new values
immediately.
Signed-off-by: Andrey Utkin
---
drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 4
1 file changed, 4 insertions(+)
diff --git a
solo6*10 boards have configurable quantization parameter which takes
values from 0 to 31, inclusively.
This change enables setting it with ioctl VIDIOC_S_CTRL with id
V4L2_CID_MPEG_VIDEO_H264_MIN_QP.
Signed-off-by: Andrey Utkin
---
drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 5
ers close-by)
> If not, then:
Cannot say for sure would compiler complain.
I also haven't really checked it, and unfortunately even haven't
succeeded to make a config that would build that code. But i believe
that warning is still better t
Previously, it was needed to reopen device to update GOP size and
quantization parameter. Now we update device registers with new values
immediately.
---
drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/media/solo6x10/solo6x
solo6*10 boards have configurable quantization parameter which takes
values from 0 to 31, inclusively.
This change enables setting it with ioctl VIDIOC_S_CTRL with id
V4L2_CID_MPEG_VIDEO_H264_MIN_QP.
---
drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 5 +
1 file changed, 5 insertions(+)
://bugzilla.kernel.org/show_bug.cgi?id=69071
Reported-by: David Binderman
Signed-off-by: Andrey Utkin
---
drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
b/drivers/staging/media
kmalloc() result check was lacking. Fixing that required also
changing card_send_command() return type from void to int, and
checking its return code everywhere.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=78561
Reported-by: Maksymilian Arciemowicz
Signed-off-by: Andrey Utkin
variable. So likely the trailing zero is a typo.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=78041
Reported-by: David Binderman
Signed-off-by: Andrey Utkin
---
drivers/staging/rtl8192ee/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192ee/bas
59 matches
Mail list logo
