Re: [PATCH v6 02/13] dt-bindings: media: nxp,imx8mq-vpu: Update the bindings for G2 support

On Fri, Mar 26, 2021 at 03:26:15PM +0100, Benjamin Gaignard wrote: > > Le 26/03/2021 à 15:11, Philipp Zabel a écrit : > > On Thu, Mar 18, 2021 at 09:20:35AM +0100, Benjamin Gaignard wrote: > > > Introducing G2 hevc video decoder lead to modify the bindings to allow > >

Re: [PATCH v6 13/13] arm64: dts: imx8mq: Add node to G2 hardware

On Thu, Mar 18, 2021 at 09:20:46AM +0100, Benjamin Gaignard wrote: > Split VPU node in two: one for G1 and one for G2 since they are > different hardware blocks. > Add syscon for hardware control block. > Remove reg-names property that is useless. > Each VPU node only need one interrupt. > >

Re: [PATCH v6 12/13] media: hantro: IMX8M: add variant for G2/HEVC codec

Benjamin Gaignard Reviewed-by: Philipp Zabel regards Philipp ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v6 03/13] media: hantro: Use syscon instead of 'ctrl' register

clocks, vpu->clocks); > > @@ -150,8 +149,22 @@ static irqreturn_t imx8m_vpu_g1_irq(int irq, void > *dev_id) > > static int imx8mq_vpu_hw_init(struct hantro_dev *vpu) > { > - vpu->dec_base = vpu->reg_bases[0]; > - vpu->ctrl_base = vpu->reg_bases[

Re: [PATCH v6 02/13] dt-bindings: media: nxp,imx8mq-vpu: Update the bindings for G2 support

On Thu, Mar 18, 2021 at 09:20:35AM +0100, Benjamin Gaignard wrote: > Introducing G2 hevc video decoder lead to modify the bindings to allow > to get one node per VPUs. > VPUs share one hardware control block which is provided as a phandle on > an syscon. > Each node got now one reg and one

Re: [PATCH v3 0/5] Reset driver for IMX8MQ VPU hardware block

On Wed, 2021-03-03 at 16:20 +0100, Benjamin Gaignard wrote: > Le 03/03/2021 à 15:17, Philipp Zabel a écrit : > > Hi Benjamin, > > > > On Mon, 2021-03-01 at 16:17 +0100, Benjamin Gaignard wrote: > > > The two VPUs inside IMX8MQ share the same control block whi

Re: [PATCH v3 4/5] media: hantro: Use reset driver

On Mon, 2021-03-01 at 16:17 +0100, Benjamin Gaignard wrote: > Rather use a reset like feature inside the driver use the reset > controller API to get the same result. > > Signed-off-by: Benjamin Gaignard > --- > drivers/staging/media/hantro/Kconfig| 1 + >

Re: [PATCH v3 3/5] reset: Add reset driver for IMX8MQ VPU block

On Mon, 2021-03-01 at 16:17 +0100, Benjamin Gaignard wrote: > IMX8MQ SoC got a dedicated hardware block to reset the video processor > units (G1 and G2). > > Signed-off-by: Benjamin Gaignard > --- > drivers/reset/Kconfig| 8 ++ > drivers/reset/Makefile | 1 + >

Re: [PATCH v3 0/5] Reset driver for IMX8MQ VPU hardware block

Hi Benjamin, On Mon, 2021-03-01 at 16:17 +0100, Benjamin Gaignard wrote: > The two VPUs inside IMX8MQ share the same control block which can be see > as a reset hardware block. This isn't a reset controller though. The control block also contains clock gates of some sort and a filter register

Re: [PATCH v2 -next] media: hantro: convert comma to semicolon

DEFAULT; > fmt->quantization = V4L2_QUANTIZATION_DEFAULT; > fmt->xfer_func = V4L2_XFER_FUNC_DEFAULT; Thank you, Reviewed-by: Philipp Zabel regards Philipp ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH -next] media: hantro: use resource_size

Hi Zheng, On Wed, 2021-01-06 at 21:18 +0800, Zheng Yongjun wrote: > Use resource_size rather than a verbose computation on > the end and start fields. > > Signed-off-by: Zheng Yongjun > --- > drivers/staging/media/hantro/hantro_v4l2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH] staging:hantro: Fixed "replace comma with semicolon" Warning:

gt; + fmt->colorspace = V4L2_COLORSPACE_JPEG; > fmt->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT; > fmt->quantization = V4L2_QUANTIZATION_DEFAULT; > fmt->xfer_func = V4L2_XFER_FUNC_DEFAULT; Thank you, Reviewed-by: Philipp Zabel regards Philipp ___

Re: [PATCH] media: imx7-mipi-csis: Add the missed v4l2_async_notifier_cleanup in remove

On Thu, 2019-12-12 at 14:51 +0300, Dan Carpenter wrote: > On Mon, Dec 09, 2019 at 04:58:28PM +0800, Chuhong Yuan wrote: > > All drivers in imx call v4l2_async_notifier_cleanup() after unregistering > > the notifier except this driver. > > This should be a miss and we need to add the call to fix

Re: [PATCH] media: staging/imx: Fix NULL deref in find_pipeline_entity()

vfd = media_entity_to_video_device(pad->entity); > + vfd = media_entity_to_video_device(start); > if (buftype == vfd->queue->type) > return >entity; > } Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH v8 5/5] media: imx: Try colorimetry at both sink and source pads

Hi Steve, On Tue, 2019-05-21 at 18:03 -0700, Steve Longerbeam wrote: > Retask imx_media_fill_default_mbus_fields() to try colorimetry parameters, > renaming it to to imx_media_try_colorimetry(), and call it at both sink and > source pad try_fmt's. The unrelated check for uninitialized field value

Re: [PATCH] media: imx: vdic: Fix wrong CSI group ID

ke in > account IPU") > > Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel regards Philipp ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v6 3/7] gpu: ipu-v3: ipu-ic: Fully describe colorspace conversions

On Thu, 2019-03-07 at 15:33 -0800, Steve Longerbeam wrote: > Only providing the input and output RGB/YUV space to the IC task init > functions is not sufficient. To fully characterize a colorspace > conversion, the colorspace (chromaticities), Y'CbCr encoding standard, > and quantization also need

Re: [PATCH v4 3/4] gpu: ipu-v3: ipu-ic: Add support for BT.709 encoding

Hi Steve, On Mon, 2019-02-11 at 17:20 -0800, Steve Longerbeam wrote: [...] > > Should we support YUV BT.601 <-> YUV REC.709 conversions? That would > > require separate encodings for input and output. > > How about if we pass the input and output encodings to the init ic task > functions, but

Re: [PATCH v4 3/4] gpu: ipu-v3: ipu-ic: Add support for BT.709 encoding

On Fri, 2019-02-08 at 17:47 -0800, Steve Longerbeam wrote: > Pass v4l2 encoding enum to the ipu_ic task init functions, and add > support for the BT.709 encoding and inverse encoding matrices. > > Reported-by: Tim Harvey > Signed-off-by: Steve Longerbeam > --- > Changes in v4: > - fix compile

Re: [PATCH v10 12/13] media: video-mux: add bayer formats

BUS_FMT_SGBRG16_1X16: > + case MEDIA_BUS_FMT_SGRBG16_1X16: > + case MEDIA_BUS_FMT_SRGGB16_1X16: > break; > default: > sdformat->format.code = MEDIA_BUS_FMT_Y8_1X8; This could be merged independently from the other chan

Re: [PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel

On Mon, 2019-01-21 at 10:46 -0800, Steve Longerbeam wrote: > > On 1/21/19 10:43 AM, Steve Longerbeam wrote: > > > > > > On 1/21/19 3:49 AM, Philipp Zabel wrote: > > > Also ipu_smfc_disable is refcounted, so if the other CSI is capturing > > >

Re: [PATCH 4/4] media: imx: Don't register IPU subdevs/links if CSI port missing

212df5 ("[media] media: Add i.MX media core driver") > > Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel regards Philipp ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/4] media: imx: Rename functions that add IPU-internal subdevs/links

ta structure for the internal IPU subdevices. > No functional changes. > > Signed-off-by: Steve Longerbeam Acked-by: Philipp Zabel regards Philipp ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/4] media: imx: csi: Allow unknown nearest upstream entities

On Sat, 2019-01-19 at 13:45 -0800, Steve Longerbeam wrote: > On i.MX6, the nearest upstream entity to the CSI can only be the > CSI video muxes or the Synopsys DW MIPI CSI-2 receiver. > > However the i.MX53 has no CSI video muxes or a MIPI CSI-2 receiver. > So allow for the nearest upstream

Re: [PATCH v3 1/2] media: imx: csi: Disable SMFC before disabling IDMA channel

Hi, On Fri, 2019-01-18 at 17:04 -0800, Steve Longerbeam wrote: > Disable the SMFC before disabling the IDMA channel, instead of after, > in csi_idmac_unsetup(). > > This fixes a complete system hard lockup on the SabreAuto when streaming > from the ADV7180, by repeatedly sending a stream off

Re: [PATCH v2 1/2] media: imx: csi: Disable CSI immediately after last EOF

v, priv->eof_irq, priv); > devm_free_irq(priv->dev, priv->nfb4eof_irq, priv); > > @@ -793,9 +795,9 @@ static void csi_stop(struct csi_priv *priv) > /* stop the frame interval monitor */ > if (priv->fim) > imx_me

Re: [PATCH] media: imx-csi: Input connections to CSI should be optional

rn -ENOTCONN in imx_csi_parse_endpoint() so that v4l2-fwnode > endpoint parsing will not treat an unconnected CSI input port as > an error. > > Fixes: c893500a16baf ("media: imx: csi: Register a subdev notifier") > > Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel r

Re: [PATCH v6 05/12] media: imx-csi: Input connections to CSI should be optional

On Tue, 2019-01-08 at 16:15 -0800, Steve Longerbeam wrote: > Some imx platforms do not have fwnode connections to all CSI input > ports, and should not be treated as an error. This includes the > imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0. > Return -ENOTCONN in

Re: [PATCH v6 02/12] gpu: ipu-csi: Swap fields according to input/output field types

d from the input frame width/height, > make sure to double height if input field type is alternate, since > in that case input height only includes lines for one field. > > Signed-off-by: Steve Longerbeam > Reviewed-by: Philipp Zabel Also Acked-by:

Re: [PATCH v5 02/12] gpu: ipu-csi: Swap fields according to input/output field types

andard from the input frame width/height, > make sure to double height if input field type is alternate, since > in that case input height only includes lines for one field. > > Signed-off-by: Steve Longerbeam > --- > Changes since v4: > - Cleaned up some convoluted code i

Re: [PATCH v4 10/11] media: imx: Allow interweave with top/bottom lines swapped

t its source pads, > e.g. the following transformations are allowed in CSI from sink to > source: > > seq-tb -> seq-bt > seq-bt -> seq-bt > alternate -> seq-bt > > Suggested-by: Philipp Zabel > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media

Re: [PATCH v4 09/11] media: imx-csi: Move crop/compose reset after filling default mbus fields

and compose windows to after the call to > imx_media_fill_default_mbus_fields(). > > Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel regards Philipp ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject

Re: [PATCH v4 06/11] media: imx: interweave and odd-chroma-row skip are incompatible

; is enabled. > > Reported-by: Krzysztof Hałasa > Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel regards Philipp ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4 07/11] media: imx-csi: Allow skipping odd chroma rows for YVU420

On Thu, 2018-10-04 at 11:53 -0700, Steve Longerbeam wrote: > Skip writing U/V components to odd rows for YVU420 in addition to > YUV420 and NV12. > > Signed-off-by: Steve Longerbeam > Reviewed-by: Philipp Zabel > --- > drivers/staging/media/imx/imx-media-csi.c | 1 +

Re: [PATCH v4 05/11] media: imx-csi: Double crop height for alternate fields at sink

single field, and the CSI captures the whole frame. > > Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel regards Philipp ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4 04/11] media: imx: Fix field negotiation

ting IDMAC interweave by > choosing INTERLACED_TB if the CSI/PRPENCVF source pad is seq-tb and > INTERLACED_BT if the source pad is seq-bt (for future support of seq-bt). > > Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel regards Philipp ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4 02/11] gpu: ipu-csi: Swap fields according to input/output field types

Hi Steve, On Thu, 2018-10-04 at 11:53 -0700, Steve Longerbeam wrote: [...] > int ipu_csi_init_interface(struct ipu_csi *csi, > struct v4l2_mbus_config *mbus_cfg, > -struct v4l2_mbus_framefmt *mbus_fmt) > +struct

Re: [PATCH v4 03/11] gpu: ipu-v3: Add planar support to interlaced scan

LO, ilo); > ipu_ch_param_write_field(ch, IPU_FIELD_SLY, sly); > + if (sluv) > + ipu_ch_param_write_field(ch, IPU_FIELD_SLUV, sluv); > }; > EXPORT_SYMBOL_GPL(ipu_cpmem_interlaced_scan); [...] Reviewed-by: Philipp Zabel and Acked-by: Philipp Zabel to be merged with

Re: [PATCH v4 2/2] media: staging/imx: fill vb2_v4l2_buffer sequence entry

Hi, On Mon, 2018-06-11 at 22:48 +0200, Peter Seiderer wrote: > Hello *, > > On Fri, 16 Mar 2018 10:05:44 -0700, Steve Longerbeam > wrote: > > > Reviewed-by: Steve Longerbeam > > Ping? Anybody taking this one? The patches have been marked not applicable in patchwork [1][2]. They do apply on

Re: [PATCH v5 06/12] media: dt-bindings: add bindings for i.MX7 media driver

On Fri, 2018-05-18 at 10:28 +0100, Rui Miguel Silva wrote: > Add bindings documentation for i.MX7 media drivers. > > Signed-off-by: Rui Miguel Silva > --- > .../devicetree/bindings/media/imx7.txt| 125 ++ > 1 file changed, 125 insertions(+) >

Re: [PATCH v5 02/12] media: staging/imx7: add imx7 CSI subdev driver

On Fri, 2018-05-18 at 10:27 +0100, Rui Miguel Silva wrote: > This add the media entity subdevice and control driver for the i.MX7 > CMOS Sensor Interface. > > Signed-off-by: Rui Miguel Silva > --- [...] > +static int imx7_csi_probe(struct platform_device *pdev) > +{ > +

Re: [PATCH v5 01/12] media: staging/imx: refactor imx media device probe

Hi Rui, thank you for refactoring, I think this is much better than having the pretend capture-subsytem device in the DT. I would like to get rid of the ipu_present flag, if it can be done reasonably. For details, see below. On Fri, 2018-05-18 at 10:27 +0100, Rui Miguel Silva wrote: > Refactor

Re: [PATCH v3 09/14] ARM: dts: imx7s: add multiplexer controls

controller { > + compatible = "mmio-mux"; > + #mux-control-cells = <1>; > + mux-reg-masks = <0x14 0x0010>; > + }; > }; > >

Re: [PATCH v3 10/14] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

On Mon, 2018-05-07 at 17:21 +0100, Rui Miguel Silva wrote: > This patch adds the device tree nodes for csi, video multiplexer and mipi-csi > besides the graph connecting the necessary endpoints to make the media capture > entities to work in imx7 Warp board. > > Also add the pin control related

Re: [PATCH v3 07/14] media: dt-bindings: add bindings for i.MX7 media driver

On Mon, 2018-05-07 at 17:21 +0100, Rui Miguel Silva wrote: > Add bindings documentation for i.MX7 media drivers. > > Signed-off-by: Rui Miguel Silva > --- > .../devicetree/bindings/media/imx7.txt| 152 ++ > 1 file changed, 152 insertions(+) >

Re: [PATCH v2 06/15] media: staging/imx: add imx7 capture subsystem

On Mon, 2018-04-23 at 14:47 +0100, Rui Miguel Silva wrote: > Add imx7 capture subsystem to imx-media core to allow the use some of the > existing modules for i.MX5/6 with i.MX7 SoC. > > Since i.MX7 does not have an IPU unset the ipu_present flag to differentiate > some runtime behaviors. > >

Re: [PATCH v2 11/15] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

On Mon, 2018-04-23 at 14:47 +0100, Rui Miguel Silva wrote: > This patch adds the device tree nodes for csi, video multiplexer and mipi-csi > besides the graph connecting the necessary endpoints to make the media capture > entities to work in imx7 Warp board. > > Also add the pin control related

Re: [PATCH 07/15] media: staging/imx: add 10 bit bayer support

On Thu, 2018-04-19 at 11:18 +0100, Rui Miguel Silva wrote: > Some sensors can only output 10 bit bayer formats, like the OV2680. Add > support > for that in imx-media. > > Signed-off-by: Rui Miguel Silva > --- > drivers/staging/media/imx/imx-media-utils.c | 24

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

Hi Fabio, On Thu, 2018-03-01 at 13:43 -0300, Fabio Estevam wrote: > On Thu, Mar 1, 2018 at 1:27 PM, Philipp Zabel <p.za...@pengutronix.de> wrote: > > > Oh, this only works for csi ports that have pinctrl in their csi port > > node, like: > > > > _csi0 {

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

On Thu, 2018-03-01 at 13:02 -0300, Fabio Estevam wrote: > On Thu, Mar 1, 2018 at 1:09 AM, Gustavo A. R. Silva > wrote: > > Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe. > > The proper pointer to be passed as argument is pinctrl > > instead of priv->vdev. > > > >

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

evice *pdev) > priv->dev->of_node = pdata->of_node; > pinctrl = devm_pinctrl_get_select_default(priv->dev); > if (IS_ERR(pinctrl)) { > - ret = PTR_ERR(priv->vdev); > + ret = PTR_ERR(pinctrl); >

Re: [PATCH 3/3] media: imx: Don't initialize vars that won't be used

re > is an error handling code, in case it fails. Add it. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp ___ devel mailing list de...@linuxdrive

Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR

Hi Gustavo, On Wed, 2018-02-14 at 14:57 -0600, Gustavo A. R. Silva wrote: > Hi all, > > I was just wondering about the status of this patch. It is en route as commit dcd71a9292b1 ("staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR") in Hans' for-v4.17a branch:

Re: [PATCH v2 5/8] media: v4l2-mediabus: convert flags to enums and document them

d, but, as both drivers > are obsolete and in the process of cleanings, I opted to just > keep the behavior, using an unsigned int inside those two > drivers. > > Acked-by: Hans Verkuil <hans.verk...@cisco.com> > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.c

Re: [PATCH 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

i <s.nawro...@samsung.com> > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Thanks, this does improve readability in the drivers. For imx-media, Acked-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp > --- > drivers/media/platform/am437x/am437x

Re: [PATCH 1/7] media: atomisp: fix ident for assert/return

Hi Mauro, On Tue, 2017-10-31 at 12:04 -0400, Mauro Carvalho Chehab wrote: > On lots of places, assert/return are starting at the first > column, causing indentation issues, as complained by spatch: > > drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/irq_private.h:32 >

Re: [PATCH] imx-csi: fix burst size

sn't for me to apply after all. Acked-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp > --- > drivers/staging/media/imx/imx-media-csi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/imx/imx-media-csi.c > b/drivers/stagin

Re: [PATCH] imx-csi: fix burst size

Hi Russell, On Fri, 2017-09-29 at 22:41 +0100, Russell King wrote: > Setting a burst size of "8" doesn't work for IMX219 with 8-bit bayer, > but a burst size of "16" does.  Fix this. Do larger bursts work as well, if the width is divisible by the burst length? Since the Bayer format can't pass

Re: [PATCH] [media] media: imx: use setup_timer

== 0) ? 0 : 2; >   > - init_timer(>eof_timeout_timer); > - priv->eof_timeout_timer.data = (unsigned long)priv; > - priv->eof_timeout_timer.function = csi_idmac_eof_timeout; > + setup_timer(>eof_timeout_timer, csi_idmac_eof_timeout, > +

Re: [PATCH] media: imx: prpencvf: enable double write reduction

d-off-by: Steve Longerbeam <steve_longerb...@mentor.com> Acked-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] media: imx: prpencvf: enable double write reduction

Hi Steve, On Sat, 2017-07-22 at 15:04 -0700, Steve Longerbeam wrote: > Hi Philipp, > > This is the same as your patch to CSI, applied to ic-prpencvf. > > I'm not really sure what this cpmem bit is doing. The U/V planes > in memory are already subsampled by 2 in both width and height. > This

[PATCH 081/102] staging: nvec: explicitly request exclusive reset control

e explicit API call so the temporary transition helpers can be removed. No functional changes. Cc: Marc Dietrich <marvi...@gmx.de> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-te...@vger.kernel.org Cc: de...@driverdev.osuosl.org Signed-off-by: Philipp Zabel &

Re: [PATCH v2] [media] staging/imx: remove confusing IS_ERR_OR_NULL usage

> Signed-off-by: Arnd Bergmann <a...@arndb.de> > --- > v2: fix type mismatch > v3: rework of_parse_subdev() as well. Thanks! Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> Tested-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp

Re: [PATCH] [media] staging/imx: remove confusing IS_ERR_OR_NULL usage

-EEXIST: - return imxsd; + return PTR_ERR(imxsd) == -EEXIST ? NULL : imxsd; or change the code where of_parse_subdev is called (from imx_media_of_parse, and recursively from of_parse_subdev) to not handle the -EEXIST return value as an error. With those fixed, Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> Tested-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v8 19/34] media: Add i.MX media core driver

On Wed, 2017-06-07 at 11:33 -0700, Steve Longerbeam wrote: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> > > Switch from the v4l2_of_ APIs to the v4l2_fwnode_ APIs. > > Signed-off-by: Philipp Zabel <p.

Re: [PATCH v7 00/34] i.MX Media Driver

On Mon, 2017-05-29 at 15:46 +0200, Hans Verkuil wrote: > Hi Steve, > > On 05/25/2017 02:29 AM, Steve Longerbeam wrote: > > In version 7: > > > > - video-mux: switched to Philipp's latest video-mux driver and updated > >bindings docs, that makes use of the mmio-mux framework. > > > > -

Re: [PATCH v7 15/34] add mux and video interface bridge entity functions

On Mon, 2017-05-29 at 15:37 +0200, Hans Verkuil wrote: > On 05/25/2017 02:29 AM, Steve Longerbeam wrote: > > From: Philipp Zabel <p.za...@pengutronix.de> > > > > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> > > > > - renamed MEDIA_ENT_F_M

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

if (tryfmt->quantization == V4L2_QUANTIZATION_DEFAULT) > + tryfmt->quantization = fmt->quantization; According to Hans' latest comments, this could be changed to: --8<-- >From cca3cda9effcaca0891eb8044a79137023fed1c2 Mon Sep 17 00:00:00 2

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

Hi Hans, On Mon, 2017-05-08 at 10:27 +0200, Hans Verkuil wrote: > Hi Philipp, > > Sorry for the very long delay, but I finally had some time to think about > this. Thank you for your thoughts. > On 04/06/2017 03:55 PM, Philipp Zabel wrote: > > If the the field order is

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

On Thu, 2017-04-13 at 09:40 -0700, Steve Longerbeam wrote: [...] > >> @@ -804,12 +804,29 @@ static void prp_try_fmt(struct prp_priv *priv, > >> >format.height, > >> infmt->height / 4, MAX_H_SRC, > >>

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi Pavel, On Fri, 2017-04-14 at 22:32 +0200, Pavel Machek wrote: > Hi! > > > > The MUX framework is already in linux-next. Could you use that instead of > > > adding new driver + bindings that are not compliant with the MUX > > > framework? > > > I don't think it'd be much of a change in terms

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi Sakari, thank you for the review. On Tue, 2017-04-04 at 15:47 +0300, Sakari Ailus wrote: > Hi Steve, Philipp and Pavel, > > On Mon, Mar 27, 2017 at 05:40:34PM -0700, Steve Longerbeam wrote: > > From: Philipp Zabel <p.za...@pengutronix.de> > > > > Th

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

Hi Steve, thanks for cleaning this up. Apart from the comments below, this looks good to me. On Wed, 2017-04-12 at 17:45 -0700, Steve Longerbeam wrote: > This patch adds a call to imx_media_fill_empty_mbus_fields() in the > *_try_fmt() functions at the sink pads, to set empty field order and >

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On Wed, 2017-04-12 at 09:03 +0200, Hans Verkuil wrote: [...] > >> Do you have a git tree with this patch? It is really hard to review without > >> having the full imx-media-csi.c source. > > > > The patch applies on top of > > > > https://github.com/slongerbeam/mediatree.git

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On Thu, 2017-04-06 at 17:43 +0200, Hans Verkuil wrote: > On 04/06/2017 04:54 PM, Philipp Zabel wrote: > > On Thu, 2017-04-06 at 16:20 +0200, Hans Verkuil wrote: > >> On 04/06/2017 03:55 PM, Philipp Zabel wrote: > >>> If the the field order is set to ANY in set_fmt,

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On Thu, 2017-04-06 at 16:10 +0100, Russell King - ARM Linux wrote: > On Thu, Apr 06, 2017 at 05:01:52PM +0200, Philipp Zabel wrote: > > On Thu, 2017-04-06 at 15:05 +0100, Russell King - ARM Linux wrote: > > > On Thu, Apr 06, 2017 at 03:55:29PM +0200, P

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On Thu, 2017-04-06 at 16:20 +0200, Hans Verkuil wrote: > On 04/06/2017 03:55 PM, Philipp Zabel wrote: > > If the the field order is set to ANY in set_fmt, choose the currently > > set field order. If the colorspace is set to DEFAULT, choose the current > > colorspace.

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On Thu, 2017-04-06 at 15:05 +0100, Russell King - ARM Linux wrote: > On Thu, Apr 06, 2017 at 03:55:29PM +0200, Philipp Zabel wrote: > > + > > + /* Retain current field setting as default */ > > + if (sdformat->format.field == V4L2_FIELD_ANY) > > + sdfor

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On Thu, 2017-04-06 at 16:20 +0200, Hans Verkuil wrote: > On 04/06/2017 03:55 PM, Philipp Zabel wrote: > > If the the field order is set to ANY in set_fmt, choose the currently > > set field order. If the colorspace is set to DEFAULT, choose the current > > colorspace.

[PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

field order and colorimetry information. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- This is based on imx-media-staging-md-v14, and it is supposed to allow configuring the pipeline with media-ctl like this: 1) media-ctl --set-v4l2 "'tc358743 1-000f':0[fmt:UYVY8_1X16/19

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

On Wed, 2017-04-05 at 11:53 -0300, Mauro Carvalho Chehab wrote: [...] > There are a number of drivers that can work with different > types of TV demodulators. Typical examples of such hardware can be > found at em28xx, saa7134, cx88 drivers (among lots of other drivers). > Those drivers don't use

Re: [PATCH v6 19/39] media: Add i.MX media core driver

On Mon, 2017-03-27 at 17:40 -0700, Steve Longerbeam wrote: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam [...] > diff --git a/drivers/staging/media/imx/imx-media-of.c > b/drivers/staging/media/imx/imx-media-of.c > new file mode 100644

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

On Tue, 2017-04-04 at 15:11 -0700, Steve Longerbeam wrote: > > On 03/30/2017 10:25 AM, Philipp Zabel wrote: > > The TVP5150 DT bindings specify a single output port (port 0) that > > corresponds to the video output pad (pad 1, DEMOD_PAD_VID_OUT). > > > > Sign

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

On Wed, 2017-04-05 at 09:21 +0100, Russell King - ARM Linux wrote: [...] > > Actually what was I thinking, the TVP5150 is already an example of > > such a device. > > > > All of this could be solved if there was some direction information > > in port nodes. > > I disagree. > > Philipp identified

[RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

The TVP5150 DT bindings specify a single output port (port 0) that corresponds to the video output pad (pad 1, DEMOD_PAD_VID_OUT). Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- I'm trying to get this to work with a TVP5150 analog TV decoder, and the first problem is that this

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote: > > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: > > > The same document says: > > > > > > Scaling

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

Hi Steve, Russell, On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote: > > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: > > > The same document says: > > > > >

Re: [PATCH v5 00/39] i.MX Media Driver

On Mon, 2017-03-20 at 15:43 +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 02:20:16PM +0100, Philipp Zabel wrote: > > To set and read colorimetry information: > > https://patchwork.linuxtv.org/patch/39350/ > > Thanks, I've applied all four of your patche

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: > On Mon, Mar 20, 2017 at 12:55:26PM +0100, Philipp Zabel wrote: > > The above paragraph suggests we skip any rectangles that are not > > supported. In our case that would be 3. and 4., since the CSI can't > >

Re: [PATCH v5 00/39] i.MX Media Driver

On Sun, 2017-03-19 at 12:14 +, Russell King - ARM Linux wrote: > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > > On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: > > >0:00:01.955927879 20954 0x15ffe90 INFOv4l2 > >

Re: [PATCH v5 00/39] i.MX Media Driver

interval information, so there's > > no way to read it back with standard tools, and no indication that > > this is going on... > > I think Philipp Zabel submitted a patch which addresses these > in media-ctl. Check with him. To read back and propagate the frame inte

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

On Sun, 2017-03-19 at 12:08 -0700, Steve Longerbeam wrote: > > On 03/19/2017 08:22 AM, Russell King - ARM Linux wrote: > > On Thu, Mar 09, 2017 at 08:53:18PM -0800, Steve Longerbeam wrote: > >> From: Philipp Zabel <p.za...@pengutronix.de> > >> > >> Th

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On Fri, 2017-03-17 at 10:24 -0300, Mauro Carvalho Chehab wrote: [...] > The big question, waiting for an answer on the last 8 years is > who would do that? Such person would need to have several different > hardware from different vendors, in order to ensure that it has > a generic solution. > >

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On Fri, 2017-03-17 at 11:42 +, Russell King - ARM Linux wrote: > On Tue, Mar 14, 2017 at 08:55:36AM +0100, Hans Verkuil wrote: > > We're all very driver-development-driven, and userspace gets very little > > attention in general. So before just throwing in the towel we should take > > a good

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

On Thu, 2017-03-16 at 10:47 +0100, Philippe De Muyter wrote: > On Thu, Mar 16, 2017 at 10:26:00AM +0100, Philipp Zabel wrote: > > On Wed, 2017-03-15 at 14:55 -0400, Nicolas Dufresne wrote: > > > Le mercredi 15 mars 2017 à 11:50 +0100, Philippe De Muyter a écrit : > > >

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

On Wed, 2017-03-15 at 14:55 -0400, Nicolas Dufresne wrote: > Le mercredi 15 mars 2017 à 11:50 +0100, Philippe De Muyter a écrit : > > > I would say: camorama, xawtv3, zbar, google talk, skype. If it runs > > > with those, it will likely run with any other application. > > > > > > > I would like

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

On Tue, 2017-03-14 at 08:34 +0100, Hans Verkuil wrote: > On 03/13/2017 10:03 PM, Sakari Ailus wrote: > > Hi Steve, > > > > On Mon, Mar 13, 2017 at 11:06:22AM -0700, Steve Longerbeam wrote: > >> > >> > >> On 03/13/2017 06:55 AM, Philipp Zabel wrote:

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

On Mon, 2017-03-13 at 13:27 +, Russell King - ARM Linux wrote: > On Mon, Mar 13, 2017 at 03:16:48PM +0200, Sakari Ailus wrote: > > The vast majority of existing drivers do not implement them nor the user > > space expects having to set them. Making that mandatory would break existing > > user

Re: [PATCH v4 33/36] media: imx: redo pixel format enumeration and negotiation

Hi Steve, On Wed, 2017-02-22 at 15:52 -0800, Steve Longerbeam wrote: > Hi Philipp, > > > On 02/16/2017 03:32 AM, Philipp Zabel wrote: > > On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > >> The previous API and negotiation of mbus codes and pixel forma

Re: [PATCH v4 00/36] i.MX Media Driver

On Fri, 2017-02-17 at 14:22 +0200, Sakari Ailus wrote: > Hi Philipp, Steve and Russell, > > On Fri, Feb 17, 2017 at 12:43:38PM +0100, Philipp Zabel wrote: > > On Thu, 2017-02-16 at 14:27 -0800, Steve Longerbeam wrote: > > > > > > On 02/16/2017 02:20 P

  1   2   3   4   >