[PATCH v3 4/4] staging: exfat: add millisecond support

Use create_time_ms and modify_time_ms fields to store the millisecond part of the file timestamp with the precision of 10 ms. Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat_core.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/staging

[PATCH v3 3/4] staging: exfat: drop unused field access_time_ms

Spec defines that UtcOffset fields should start in this position instead. Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h | 6 -- drivers/staging/exfat/exfat_core.c | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b

[PATCH v3 2/4] staging: exfat: drop duplicate date_time_t struct

Use timestamp_t for everything and cleanup duplicate code. Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h | 35 +++--- drivers/staging/exfat/exfat_super.c | 158 2 files changed, 55 insertions(+), 138 deletions(-) diff --git a/drivers

[PATCH v2 3/3] staging: exfat: add millisecond support

Use create_time_ms modify_time_ms fields to store the millisecond part of the file timestamp with the precision of 10 ms. Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat_core.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/staging

[PATCH v2 2/3] staging: exfat: drop unused field access_time_ms

Not used in the exfat-fuse implementation and spec defines this position should hold the value for CreateUtcOffset. Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h | 3 +-- drivers/staging/exfat/exfat_core.c | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH v3 1/3] staging: exfat: cleanup spacing for operators

Fixes checkpatch.pl warnings: CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '*' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) Signed-off-by: Valentin Vidic --- v2: Use constants where

[PATCH v3 3/3] staging: exfat: use integer constants

Replace manually generated values with predefined constants. Signed-off-by: Valentin Vidic --- v2: Use constants where possible v3: Split up changes of constants drivers/staging/exfat/exfat_core.c | 18 +- drivers/staging/exfat/exfat_super.c | 8 2 files changed, 13

[PATCH v3 2/3] staging: exfat: cleanup spacing for casts

Fix checkpatch.pl warnings: CHECK: No space is necessary after a cast Signed-off-by: Valentin Vidic --- v2: Use constants where possible v3: Split up changes of constants drivers/staging/exfat/exfat_core.c | 88 ++--- drivers/staging/exfat/exfat_super.c | 66

[PATCH] staging: exfat: add millisecond support

Drop duplicated date_time_t struct and add millisecond handling for create and modify time. Also drop millisecond field for access time since it is not defined in the the spec. Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h | 38 +++--- drivers/staging/exfat/exfat_core.c

[PATCH 2/2 v2] staging: exfat: cleanup casts

Use constants and fix checkpatch.pl warnings: CHECK: No space is necessary after a cast Signed-off-by: Valentin Vidic --- v2: Use constants where possible drivers/staging/exfat/exfat_core.c | 94 ++--- drivers/staging/exfat/exfat_super.c | 66 ++-- 2

[PATCH 1/2] staging: exfat: cleanup spacing for operators

Fixes checkpatch.pl warnings: CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '*' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) Signed-off-by: Valentin Vidic --- drivers/staging/exfat

[PATCH 2/2] staging: exfat: cleanup spacing for casts

Fixes checkpatch.pl warnings: CHECK: No space is necessary after a cast Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat_core.c | 88 ++--- drivers/staging/exfat/exfat_super.c | 66 +++--- 2 files changed, 77 insertions(+), 77 deletions

[PATCH v2] staging: exfat: cleanup explicit comparisons to NULL

Fixes checkpatch.pl warnings: CHECK: Comparison to NULL could be written "expr" CHECK: Comparison to NULL could be written "!expr" Signed-off-by: Valentin Vidic --- v2: fix gcc warning in strsep call drivers/staging/exfat/exfat_core.c | 34 - d

[PATCH] staging: exfat: drop local TRUE/FALSE defines

Replace with bool where it makes sense. Also drop unused local variable lossy in fat_find_dir_entry. Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h | 3 -- drivers/staging/exfat/exfat_core.c | 81 +++-- drivers/staging/exfat/exfat_nls.c | 2

[PATCH] staging: exfat: cleanup explicit comparisons to NULL

Fixes checkpatch.pl warnings: CHECK: Comparison to NULL could be written "expr" CHECK: Comparison to NULL could be written "!expr" Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat_core.c | 34 - drivers/staging/exfa

[PATCH] staging: exfat: fix spelling errors in comments

Fixes checkpatch.pl warnings: CHECK: 'consistancy' may be misspelled - perhaps 'consistency'? CHECK: 'stuct' may be misspelled - perhaps 'struct'? Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat_core.c | 2 +- drivers/staging/exfat/exfat_super.c | 2 +- 2 files changed, 2

[PATCH] staging: exfat: cleanup braces for if/else statements

Fixes checkpatch.pl warnings: CHECK: Unbalanced braces around else statement CHECK: braces {} should be used on all arms of this statement Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat_core.c | 12 ++-- drivers/staging/exfat/exfat_super.c | 16 +--- 2

[PATCH] staging: exfat: cleanup blank line warnings

Fixes checkpatch.pl warnings: CHECK: Please don't use multiple blank lines CHECK: Blank lines aren't necessary after an open brace '{' CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h

[PATCH] staging: exfat: use BIT macro for defining sizes

Fixes checkpatch.pl warning: CHECK: Prefer using the BIT macro Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h index bae180e10609

[PATCH] staging: pi433: cleanup comments in rf69.h

Fixes checkpatch warning: WARNING: line over 80 characters Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h index c131ffbdc2db..d80c41966d39

[PATCH] staging: pi433: add SPDX-License-Identifier tag

Use GPL-2.0+ based on the license text in each of the files. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 1 + drivers/staging/pi433/pi433_if.h | 3 ++- drivers/staging/pi433/rf69.c | 1 + drivers/staging/pi433/rf69.h | 3 ++- drivers

[PATCH v3] staging: pi433: replace simple switch statements

Use const array to map switch cases to resulting values. Signed-off-by: Valentin Vidic --- v2: use correct type for const arrays v3: add missing static keyword for af_map drivers/staging/pi433/rf69.c | 233 ++- 1 file changed, 93 insertions(+), 140 deletions

[PATCH v2] staging: pi433: replace simple switch statements

Use const array to map switch cases to resulting values. Signed-off-by: Valentin Vidic --- v2: use correct type for const arrays drivers/staging/pi433/rf69.c | 233 ++- 1 file changed, 93 insertions(+), 140 deletions(-) diff --git a/drivers/staging/pi433/rf69.c

[PATCH] staging: pi433: replace simple switch statements

Use const array to map switch cases to resulting values. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 233 ++- 1 file changed, 93 insertions(+), 140 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index

Re: rf69_set_deviation in rf69.c (pi433 driver)

On Thu, Jun 21, 2018 at 10:03:45PM -0400, Hugo Lefeuvre wrote: > I'll prepare a patch addressing both issues. However I don't own test devices > so it would be really great if you could test it ! I have two pi433 devices now so I should be able to tests things, just let me know... -- Valentin

Re: [PATCH v2] staging: pi433: add mutex fixing concurrency issues.

On Thu, Jun 07, 2018 at 08:45:03AM -0400, Hugo Lefeuvre wrote: > After discussing this issue on the kernel newbies mailing list[0] we > came to the conclusion that it is very unlikely that pi433_release and > pi433_ioctl would ever run concurrently in this case. This is also > true for read/write.

[PATCH v2] staging: pi433: cleanup tx_fifo locking

not require locking after kfifo_reset is removed. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: print a warning if partial fifo write happens drivers/staging/pi433/pi433_if.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/d

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Thu, Apr 19, 2018 at 11:25:19AM +0200, Marcus Wolf wrote: > let me know, what you like to have. For sure with just one station and > no other 433MHz equipment, options for testing are quite limited. I can get Rpi3 and with two shields test 433MHz communication between Rpi2 and Rpi3. --

[PATCH] staging: pi433: use help in Kconfig description

Fixes checkpatch warning: WARNING: prefer 'help' over '---help---' for new help texts Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/Kconfig b/drivers/s

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Sun, Apr 08, 2018 at 05:22:46PM +0200, Marcus Wolf wrote: > Regarding your patch, I did not understand, why you did not remove > the mutex_lock in pi433_write. Wasn't it the goal to remove it? Is it possible for more than one userspace program to open the pi433 device and send messages? In

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Sun, Apr 08, 2018 at 04:15:30PM +0200, Marcus Wolf wrote: > The hardware of Pi433 is working with every Raspberry Pi (on zero, you > need to solder the GPIO-pins) and with several other fruits like banana > pi. The only thing is, that you need different versions of the driver, > according to

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Sun, Mar 25, 2018 at 03:12:52PM +0200, Marcus Wolf wrote: > I am not at home the next two weeks. So I can do a codereading on > Easter, but testing will not take place earlier then mid/end of April :-( > > If you are interested, I can provide you an engineering sample of Pi433. Sure, let me

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Sun, Mar 25, 2018 at 03:00:09PM +0200, Marcus Wolf wrote: > Unfortunaly I can't find the time to have a closer look on the code this > weekend - still busy with tax stuff :-( > > Idea sounds great. I'll try to look at the code and think about it > during Easter hollidays. No problem, there is

[PATCH] staging: pi433: cleanup tx_fifo locking

so it does not require locking after kfifo_reset is also removed. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/d

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Fri, Mar 23, 2018 at 07:00:27PM +0100, Valentin Vidic wrote: > You are right, here is what kfifo.h says: > > /* > * Note about locking : There is no locking required until only * one reader > * and one writer is using the fifo and no kfifo_reset() will be * called > * kfi

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Fri, Mar 23, 2018 at 04:38:50PM +0100, Marcus Wolf wrote: > I had no time to work on the code for monthes now and the memorisation > of my thoughts when I was programming that (approx. one year ago) is > quite pale. > > As far as I remember, I read something, that the fifo has an integrated >

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Fri, Mar 23, 2018 at 11:22:39AM +0100, Marcus Wolf wrote: > could you please decribe in short words, why you think, that hte lock > isn't obsolete? > > I wasn't sure, but close to remove the lock. That's why I putted the > comment. Sure, if pi433_tx_thread runs on one CPU it might be possible

[PATCH] staging: pi433: add descriptions for mutex locks

Removes TODO for tx_fifo_lock as tx_fifo is modified from both pi433_tx_thread and pi433_write. Fixes checkpatch warning: CHECK: struct mutex definition without comment Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file chan

[PATCH] staging: pi433: cleanup local variable

Rename temporary local variable and add required blank line. Fixes checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 7 --- 1 file changed, 4 insertions(+), 3 del

[PATCH 4/7] staging: pi433: fix CamelCase for bitRate variables

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 16 drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 9 insertions

[PATCH 5/7] staging: pi433: fix CamelCase for DIONumber variable

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/d

[PATCH 3/7] staging: pi433: fix CamelCase for syncSize variable

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index b2c549

[PATCH 2/7] staging: pi433: fix CamelCase for preambleLength variable

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 6 +++--- drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/d

[PATCH 6/7] staging: pi433: fix CamelCase for lnaGain enum

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/s

[PATCH 7/7] staging: pi433: fix CamelCase for dagc enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 4 ++-- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69_

[PATCH 1/7] staging: pi433: fix CamelCase for GPIO functions

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/pi433_

[PATCH 6/6] staging: pi433: fix CamelCase for paRamp enum

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/s

[PATCH 2/6] staging: pi433: fix CamelCase for flag enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin

[PATCH 4/6] staging: pi433: fix CamelCase for address_filtering enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 12 ++-- drivers/staging/pi433/pi433_if.c

[PATCH 5/6] staging: pi433: fix CamelCase for Address variables

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/rf69.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/d

[PATCH 1/6 v2] staging: pi433: fix CamelCase for packetFormat enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: order patches so they apply correctly drivers/staging/pi433/pi433_if.c | 8 drivers/staging/pi433/

[PATCH 3/6] staging: pi433: fix CamelCase for afterSyncInterrupt

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 2 +- drivers/staging/pi433/rf69_enum.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

[PATCH] staging: pi433: fix CamelCase for paRamp enum

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/s

[PATCH] staging: pi433: fix CamelCase for flag enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin

[PATCH] staging: pi433: fix CamelCase for Address variables

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/rf69.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/d

[PATCH] staging: pi433: fix CamelCase for afterSyncInterrupt

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 2 +- drivers/staging/pi433/rf69_enum.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

[PATCH] staging: pi433: fix CamelCase for address_filtering enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 12 ++-- drivers/staging/pi433/pi433_if.c

[PATCH] staging: pi433: fix CamelCase for packetFormat enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 8 drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/

[PATCH] staging: pi433: fix CamelCase for addressFiltering

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 4 ++-- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h | 2 +- d

[PATCH] staging: pi433: fix CamelCase for thresholdDecrement

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/s

[PATCH] staging: pi433: fix CamelCase for txStartCondition

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h | 2 +- drivers/staging/pi433/rf69_enum.h | 2 +- 4

[PATCH 6/8] staging: pi433: fix CamelCase for newValue

Local variable storing the new value for bandwidth register so replace with bandwidth. Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 16 1 file changed, 8 insertions

[PATCH 7/8] staging: pi433: fix CamelCase for regValue

Local variable storing the new value for dio register so replace with dio_value. Update regaddr to dio_addr to match. Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.

[PATCH 4/8] staging: pi433: fix CamelCase for Ohm identifiers

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 4 ++-- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/

[PATCH 5/8] staging: pi433: fix CamelCase for currentValue

Local variable storing the value for modulation register so replace with modulation_reg. Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

[PATCH 3/8] staging: pi433: fix CamelCase for antennaImpedance

Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/s

[PATCH 2/8] staging: pi433: fix CamelCase for powerLevel

Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/rf

[PATCH 1/8] staging: pi433: fix CamelCase for syncValues

Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 18 +- drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging

Re: [PATCH] staging: pi433: Cleanup codestyle, indent statements after case labels

On Sun, Dec 24, 2017 at 02:42:57PM +0100, Marcus Wolf wrote: > > int rf69_set_dagc(struct spi_device *spi, enum dagc dagc) > > { > > switch (dagc) { > > - case normalMode: return rf69_write_reg(spi, > > REG_TESTDAGC, DAGC_NORMAL); > > - case improve:

[PATCH v2] staging: pi433: align function parameters with open parenthesis

Fixes checkpatch warnings: CHECK: Alignment should match open parenthesis Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: add missing Signed-off-by drivers/staging/pi433/pi433_if.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/d

[PATCH] staging: pi433: align function parameters with open parenthesis

Fixes checkpatch warnings: CHECK: Alignment should match open parenthesis --- drivers/staging/pi433/pi433_if.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index f56425ffbe90..edcd7e798f99

[PATCH] staging: pi433: remove unnecessary parentheses

Fixes checkpatch warnings: CHECK: Unnecessary parentheses around 'mantisse != mantisse16' CHECK: Unnecessary parentheses around 'mantisse != mantisse20' CHECK: Unnecessary parentheses around 'mantisse != mantisse24' Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- d

[PATCH] staging: pi433: replace shifting with BIT macro

Fixes checkpatch warnings: CHECK: Prefer using the BIT macro Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi43

[PATCH] staging: pi433: fix CamelCase for payload identifiers

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 6 +++--- drivers/staging/pi433/rf69.h | 2 +- drivers/staging

[PATCH] staging: pi433: fix CamelCase for maxMinus variables

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 10 +- d

[PATCH] staging: pi433: fix CamelCase for fifo variables

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/s

[PATCH 3/6 v5] staging: pi433: replace unsigned with unsigned int

Fixes checkpatch warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 6/6 v5] staging: pi433: remove unused function

As it turns out rf69_get_lna_gain is not used at all. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v5: resend patchset based on comments drivers/staging/pi433/rf69.c | 18 -- drivers/staging/pi433/rf69.h | 1 - 2 files changed, 19 deletions(-) diff

[PATCH 5/6 v5] staging: pi433: replace printk calls with dev_dbg

Fixes checkpatch warning: WARNING: printk() should include KERN_ facility level Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 4/6 v5] staging: pi433: avoid logging ENOMEM messages

Fixes checkpatch warning: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/d

[PATCH 2/6 v5] staging: pi433: cleanup local variable declaration

Fix variable naming and checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

[PATCH 6/8 v4] staging: pi433: remove unused function

As it turns out rf69_get_lna_gain is not used at all. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file v3: - drop auto case - use CURRENT suffix - precompute define values v4:

[PATCH] staging: pi433: fix CamelCase for dccPercent variables

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 30 +++--- drivers/staging/pi433/rf69.h | 6 +++--- drivers/staging/pi433/rf69_enum.h | 18 +--

[PATCH 2/8 v3] staging: pi433: cleanup local variable declaration

Fix variable naming and checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: use a better variable name v3: keep the variable scope drivers/staging/pi433/pi433_if.c | 8 +--- 1 file changed, 5 inse

[PATCH 6/8 v3] staging: pi433: use defines for shifting register values

Avoid shifting by magic numbers and use defines instead. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file v3: - drop auto case - use CURRENT suffix - precompute define values d

Re: [PATCH 6/8] staging: pi433: use defines for shifting register values

On Wed, Dec 13, 2017 at 05:32:28PM +0200, Marcus Wolf wrote: > Am 13.12.2017 um 16:21 schrieb Valentin Vidic: > > Avoid shifting by magic numbers and use defines instead: > > > >SHIFT_DATAMODUL_MODULATION_TYPE > >SHIFT_LNA_CURRENT_GAIN > > > > Sig

[PATCH 6/8 v2] staging: pi433: use defines for shifting register values

Avoid shifting by magic numbers and use defines instead. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file drivers/staging/pi433/rf69.c | 16 drivers/staging

[PATCH 2/8 v2] staging: pi433: move var declaration to function level

Fixes checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: use a better variable name drivers/staging/pi433/pi433_if.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/s

Re: [PATCH 8/8] staging: pi433: replace printk calls with dev_dbg

On Wed, Dec 13, 2017 at 05:52:36PM +0300, Dan Carpenter wrote: > On Wed, Dec 13, 2017 at 03:21:56PM +0100, Valentin Vidic wrote: > > drivers/staging/pi433/pi433_if.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/pi43

[PATCH 7/8] staging: pi433: avoid logging ENOMEM messages

Fixes checkpatch warning: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/d

[PATCH 2/8] staging: pi433: move var declaration to function level

Fixes checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/s

[PATCH 8/8] staging: pi433: replace printk calls with dev_dbg

Fixes checkpatch warning: WARNING: printk() should include KERN_ facility level Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/d

[PATCH 4/8] staging: pi433: add parentheses to mask and shift

Fixes checkpatch warning: WARNING: Possible precedence defect with mask then right shift - may need parentheses Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s

[PATCH 6/8] staging: pi433: use defines for shifting register values

Avoid shifting by magic numbers and use defines instead: SHIFT_DATAMODUL_MODULATION_TYPE SHIFT_LNA_CURRENT_GAIN Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69_registers.h | 2 ++ 2 files chan

[PATCH 5/8] staging: pi433: fix DATAMODUL_MODULATION_TYPE_OOK value

Reading from the spec, allowed values for modulation scheme after the shift are: 00 FSK 01 OOK 10 - 11 reserved Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69_registers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 3/8] staging: pi433: replace unsigned with unsigned int

Fixes checkpatch warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/d

[PATCH 1/8] staging: pi433: collapse else block after return statement

Fixes checkpatch warning: WARNING: else is not generally useful after a break or return Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging

[PATCH 11/16 v2] staging: pi433: remove multiple blank lines

Fixes checkpatch warning for multiple blank lines in source. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: refresh patch for staging-testing drivers/staging/pi433/pi433_if.c | 11 --- drivers/staging/pi433/pi433_if.h | 8 drivers/staging

[PATCH 08/16] staging: pi433: remove spaces before tabs

Fixes checkpatch warning for hidden spaces before tabs. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/pi433_if.h | 4 ++-- drivers/staging/pi433/rf69.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)

[PATCH 02/16] staging: pi433: add space after comma

Fixes checkpatch error for missing spaces. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 9c1787

  1   2   >