Re: [PATCH 05/10] added media specific (MS) TCP drivers

2014-11-12 Thread Sean O. Stalley
Thank You for reviewing our code. I believe most of the problems you pointed out in mausb_ioctl.c were addressed in [V2 PATCH 5/10]. I am working on adding the proper error checking to the TCP drivers. Greg has requested that we clean up our code internally before submitting another patchset to

[V2 PATCH 05/10] added media specific (MS) TCP drivers

2014-11-10 Thread Stephanie Wallick
This is where we handle media specific packets and transport. The MS driver interfaces with a media agnostic (MA) driver via a series of transfer pairs. Transfer pairs consist of a set of functions to pass MA USB packets back and forth between MA and MS drivers. There is one transfer pair per

Re: [V2 PATCH 05/10] added media specific (MS) TCP drivers

2014-11-10 Thread Greg KH
On Mon, Nov 10, 2014 at 06:09:36PM -0800, Stephanie Wallick wrote: +static int ma_open; Why do you need this variable? +/** + * This function is used to open the device file in order to read/write + * from/to it. + * + * @inode: Struct with various information that is passed in when this

Re: [PATCH 05/10] added media specific (MS) TCP drivers

2014-11-04 Thread Tobias Klauser
On 2014-11-03 at 21:42:52 +0100, Stephanie Wallick stephanie.s.wall...@intel.com wrote: This is where we handle media specific packets and transport. The MS driver interfaces with a media agnostic (MA) driver via a series of transfer pairs. Transfer pairs consist of a set of functions to pass

Re: [PATCH 05/10] added media specific (MS) TCP drivers

2014-11-04 Thread Greg KH
On Tue, Nov 04, 2014 at 09:48:33AM +0100, Tobias Klauser wrote: On 2014-11-03 at 21:42:52 +0100, Stephanie Wallick stephanie.s.wall...@intel.com wrote: This is where we handle media specific packets and transport. The MS driver interfaces with a media agnostic (MA) driver via a series of

[PATCH 05/10] added media specific (MS) TCP drivers

2014-11-03 Thread Stephanie Wallick
This is where we handle media specific packets and transport. The MS driver interfaces with a media agnostic (MA) driver via a series of transfer pairs. Transfer pairs consist of a set of functions to pass MA USB packets back and forth between MA and MS drivers. There is one transfer pair per