Re: [PATCH 16/16] staging: ks7010: refactor ks_wlan_translate_scan function

2018-04-27 Thread Sergio Paracuellos
On Fri, Apr 27, 2018 at 02:00:29PM +0300, Dan Carpenter wrote: > This really should have been broken up into several patches. I've > reviewed the first 15 patches and they were straight forward. Then I > postponed because it was just so grizzly to figure out what was going > on... Thanks for

Re: [PATCH 16/16] staging: ks7010: refactor ks_wlan_translate_scan function

2018-04-27 Thread Dan Carpenter
This really should have been broken up into several patches. I've reviewed the first 15 patches and they were straight forward. Then I postponed because it was just so grizzly to figure out what was going on... On Wed, Apr 25, 2018 at 04:01:55PM +0200, Sergio Paracuellos wrote: > This commit

[PATCH 16/16] staging: ks7010: refactor ks_wlan_translate_scan function

2018-04-25 Thread Sergio Paracuellos
This commit refactors ks_wlan_translate_scan function with the following changes: - reorder local variables - use ether_addr_copy to copy ethernet addresses - change style in 'current_ev' variable assignments - make use of some ternaries avoiding if-else code - use preferred