Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-10 Thread Laurent Pinchart
Hi Alex, On Tue, Mar 10, 2020 at 09:17:14AM +0100, Alex Riesen wrote: > Kuninori Morimoto, Tue, Mar 10, 2020 02:07:23 +0100: > > > Should the adv748x driver also implement anything to configure the > > > frequency > > > of MCLK clock? I mean something like .set_sysclk and .set_fmt callbacks of >

Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-10 Thread Alex Riesen
Hello Morimoto-san, Kuninori Morimoto, Tue, Mar 10, 2020 02:07:23 +0100: > > Should the adv748x driver also implement anything to configure the frequency > > of MCLK clock? I mean something like .set_sysclk and .set_fmt callbacks of > > snd_soc_dai_ops? > > > > Or is the driver implementation,

Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-09 Thread Kuninori Morimoto
Hi Alex > Should the adv748x driver also implement anything to configure the frequency > of MCLK clock? I mean something like .set_sysclk and .set_fmt callbacks of > snd_soc_dai_ops? > > Or is the driver implementation, which depends on mclk-fs to be 256, the audio > stream format to be 8x

Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-09 Thread Alex Riesen
Hi, Kuninori Morimoto, Mon, Mar 09, 2020 02:31:01 +0100: > > > > Those clocks are part of the CSI-2 protocol and also don't need to be > > > > explicitly controlled. As far as I can tell from a quick check of the > > > > ADV7482 documentation, only the I2S MCLK is a general-purpose clock that > >

Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-08 Thread Kuninori Morimoto
Hi > > > Those clocks are part of the CSI-2 protocol and also don't need to be > > > explicitly controlled. As far as I can tell from a quick check of the > > > ADV7482 documentation, only the I2S MCLK is a general-purpose clock that > > > needs to be exposed. (snip) > > Do you know, by chance,

Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-06 Thread Laurent Pinchart
Hi Alex, (CC'ing Morimoto-san) On Fri, Mar 06, 2020 at 02:41:54PM +0100, Alex Riesen wrote: > Laurent Pinchart, Fri, Mar 06, 2020 14:16:32 +0100: > > On Thu, Mar 05, 2020 at 03:36:28PM +0100, Alex Riesen wrote: > >> Geert Uytterhoeven, Mon, Mar 02, 2020 17:13:30 +0100: > >>> On Mon, Mar 2, 2020

Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-06 Thread Alex Riesen
Hi Laurent, Laurent Pinchart, Fri, Mar 06, 2020 14:16:32 +0100: > On Thu, Mar 05, 2020 at 03:36:28PM +0100, Alex Riesen wrote: > > Geert Uytterhoeven, Mon, Mar 02, 2020 17:13:30 +0100: > > > On Mon, Mar 2, 2020 at 5:09 PM Alex Riesen > > > wrote: > > > > Geert Uytterhoeven, Mon, Mar 02, 2020

Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-06 Thread Laurent Pinchart
Hi Alex, On Thu, Mar 05, 2020 at 03:36:28PM +0100, Alex Riesen wrote: > Geert Uytterhoeven, Mon, Mar 02, 2020 17:13:30 +0100: > > On Mon, Mar 2, 2020 at 5:09 PM Alex Riesen > > wrote: > > > Geert Uytterhoeven, Mon, Mar 02, 2020 16:32:32 +0100: > > > > > > > > The #clock-cells should be in the

Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-06 Thread Geert Uytterhoeven
Hi Alex, On Thu, Mar 5, 2020 at 3:36 PM Alex Riesen wrote: > Geert Uytterhoeven, Mon, Mar 02, 2020 17:13:30 +0100: > > On Mon, Mar 2, 2020 at 5:09 PM Alex Riesen > > wrote: > > > Geert Uytterhoeven, Mon, Mar 02, 2020 16:32:32 +0100: > > > > > > > > The #clock-cells should be in the main

Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-05 Thread Alex Riesen
Hi Geert, Geert Uytterhoeven, Mon, Mar 02, 2020 17:13:30 +0100: > On Mon, Mar 2, 2020 at 5:09 PM Alex Riesen > wrote: > > Geert Uytterhoeven, Mon, Mar 02, 2020 16:32:32 +0100: > > > > > > The #clock-cells should be in the main video-receiver node. > > > Probably there is more than one clock

Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-02 Thread Geert Uytterhoeven
Hi Alex, On Mon, Mar 2, 2020 at 5:09 PM Alex Riesen wrote: > Geert Uytterhoeven, Mon, Mar 02, 2020 16:32:32 +0100: > > > And this absence of documentation also means that whatever clocks (both > > > input > > > in "clocks=" and output in "#clock-cells") listed in a specific .dts are > > > just

Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-02 Thread Alex Riesen
Hi Geert, Geert Uytterhoeven, Mon, Mar 02, 2020 16:32:32 +0100: > > And this absence of documentation also means that whatever clocks (both > > input > > in "clocks=" and output in "#clock-cells") listed in a specific .dts are > > just > > an integration detail? > > No, the absence probably

Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-02 Thread Geert Uytterhoeven
Hi Alex, On Mon, Mar 2, 2020 at 4:07 PM Alex Riesen wrote: > Geert Uytterhoeven, Mon, Mar 02, 2020 14:47:46 +0100: > > On Mon, Mar 2, 2020 at 2:40 PM Alex Riesen > > wrote: > > > > > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > > > > > +++

Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-02 Thread Alex Riesen
Geert Uytterhoeven, Mon, Mar 02, 2020 14:47:46 +0100: > On Mon, Mar 2, 2020 at 2:40 PM Alex Riesen > wrote: > > > > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > > > > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > > > > @@ -322,6 +322,10 @@ > > > > clock-frequency =

Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-02 Thread Geert Uytterhoeven
Hi Alex, On Mon, Mar 2, 2020 at 2:40 PM Alex Riesen wrote: > Geert Uytterhoeven, Mon, Mar 02, 2020 13:28:13 +0100: > > On Mon, Jan 13, 2020 at 3:24 PM Alex Riesen > > wrote: > > > Not sure if all variants of the Salvator board have the HDMI decoder > > > chip (the ADV7482) connected to the SSI4

Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-02 Thread Alex Riesen
Geert Uytterhoeven, Mon, Mar 02, 2020 13:28:13 +0100: > Hi Alex, > > Thanks for your patch! > > On Mon, Jan 13, 2020 at 3:24 PM Alex Riesen > wrote: > > Not sure if all variants of the Salvator board have the HDMI decoder > > chip (the ADV7482) connected to the SSI4 on R-Car SoC, as it is on >

Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-03-02 Thread Geert Uytterhoeven
Hi Alex, Thanks for your patch! On Mon, Jan 13, 2020 at 3:24 PM Alex Riesen wrote: > Not sure if all variants of the Salvator board have the HDMI decoder > chip (the ADV7482) connected to the SSI4 on R-Car SoC, as it is on > Salvator-X ES1, so the the ADV7482 endpoint and connection definitions

[PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-01-13 Thread Alex Riesen
Not sure if all variants of the Salvator board have the HDMI decoder chip (the ADV7482) connected to the SSI4 on R-Car SoC, as it is on Salvator-X ES1, so the the ADV7482 endpoint and connection definitions are placed in the board file. I do assume though that all Salvator variants have the CLK_C