[PATCH] staging: dgnc: fix long lines

2014-12-03 Thread Krzysztof Adamski
This patch fixes checkpatch complains about lines over 80 characters. No code was modified, only whitespace changes and comments editing. Signed-off-by: Krzysztof Adamski k...@japko.eu --- drivers/staging/dgnc/dgnc_cls.h| 24 ++--- drivers/staging/dgnc/dgnc_driver.c | 50 +

Re: Possible memory leak in function (reserve_range) not freeing pointer (regionid)

2014-12-03 Thread Dan Carpenter
This is a real bug, but it's very minor. To trigger it, you would have to modprobe and rmmod many many times in a loop. If you report these sorts of minor bugs when the code is new, then most times people fix them but this one is old I doubt anyone is motivated to fix it. Fixing it seems a

Re: [PATCH v2] staging: rt8192u: fix sparse warnings in r8192U_core.c

2014-12-03 Thread Sudip Mukherjee
On Wed, Dec 03, 2014 at 02:30:29PM +0800, Fred Chou wrote: From: Fred Chou fred.chou...@gmail.com v2: alignment to match open parenthesis this should not come in commit log, this should go as a comment below the --- and this patch is not applying to next-20141201, maybe in staging-testing

Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi

2014-12-03 Thread Philipp Zabel
Hi Andy, Am Mittwoch, den 03.12.2014, 08:54 +0800 schrieb Andy Yan: +Required properities: +- compatible: platform specific such as: + * fsl,imx6q-hdmi + * fsl,imx6dl-hdmi + * rockchip,rk3288-dw-hdmi I think we should add a common compatible value snps,dw-hdmi-tx here:

Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi

2014-12-03 Thread Andy Yan
Hi Philipp: On 2014年12月03日 17:19, Philipp Zabel wrote: Hi Andy, Am Mittwoch, den 03.12.2014, 08:54 +0800 schrieb Andy Yan: +Required properities: +- compatible: platform specific such as: + * fsl,imx6q-hdmi + * fsl,imx6dl-hdmi + * rockchip,rk3288-dw-hdmi I think we should add a common

Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi

2014-12-03 Thread Andy Yan
On 2014年12月03日 02:23, Philipp Zabel wrote: Hi Andy, Am Dienstag, den 02.12.2014, 15:42 +0800 schrieb Andy Yan: diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt new file mode 100644 index 000..107c1ca ---

Re: [PATCH 01/11] staging: comedi: hwdrv_apci1500: introduce z8536_read()

2014-12-03 Thread Ian Abbott
On 02/12/14 17:19, H Hartley Sweeten wrote: The Z8536 CIO registers are indirectly read by writing the register value I think you mean the register offset. (That also applies to patch 2.) to the control register then reading the control register. Introduce a helper function to read the

Re: [PATCH 01/11] staging: comedi: hwdrv_apci1500: introduce z8536_read()

2014-12-03 Thread Ian Abbott
On 02/12/14 17:19, H Hartley Sweeten wrote: The Z8536 CIO registers are indirectly read by writing the register value to the control register then reading the control register. Introduce a helper function to read the Z8536 CIO registers. Signed-off-by: H Hartley Sweeten

Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi

2014-12-03 Thread Philipp Zabel
Am Mittwoch, den 03.12.2014, 17:46 +0800 schrieb Andy Yan: On 2014年12月03日 02:23, Philipp Zabel wrote: Hi Andy, Am Dienstag, den 02.12.2014, 15:42 +0800 schrieb Andy Yan: diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt

Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi

2014-12-03 Thread Andy Yan
On 2014年12月03日 19:52, Philipp Zabel wrote: Am Mittwoch, den 03.12.2014, 17:46 +0800 schrieb Andy Yan: On 2014年12月03日 02:23, Philipp Zabel wrote: Hi Andy, Am Dienstag, den 02.12.2014, 15:42 +0800 schrieb Andy Yan: diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt

Re: [PATCH v15 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-12-03 Thread Andy Yan
Hi Philipp: On 2014年12月02日 21:00, Philipp Zabel wrote: Hi Andy, Am Dienstag, den 02.12.2014, 20:34 +0800 schrieb Andy Yan: Hi Philipp: On 2014年12月02日 18:24, Philipp Zabel wrote: Hi Andy, Am Dienstag, den 02.12.2014, 15:45 +0800 schrieb Andy Yan: [...] +static int

Re: [PATCH v15 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-12-03 Thread Philipp Zabel
Hi Andy, Am Mittwoch, den 03.12.2014, 20:32 +0800 schrieb Andy Yan: My question is not about the available gates at the SoC level, but about the actual clock inputs from point of view of the HDMI TX IP. It could be that the hdmi_ctrl_clk gates all inputs to the module and bus clocks

Re: [PATCH v15 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-12-03 Thread Andy Yan
Hi Philipp: On 2014年12月03日 21:09, Philipp Zabel wrote: Hi Andy, Am Mittwoch, den 03.12.2014, 20:32 +0800 schrieb Andy Yan: My question is not about the available gates at the SoC level, but about the actual clock inputs from point of view of the HDMI TX IP. It could be that the hdmi_ctrl_clk

[PATCH] Staging: slicoss: Fix long line issues in slicoss.c

2014-12-03 Thread Sean Cleator
A patch to the slicoss.c file to fix some of the long line issues found by the checkpath.pl tool Signed-off-by: Sean Cleator seanclea...@hotmail.co.uk --- drivers/staging/slicoss/slicoss.c | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff

[PATCH v16 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2014-12-03 Thread Andy Yan
We found Freescale imx6 and Rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS) use the interface compatible Designware HDMI IP, but they also have some lightly differences, such as phy pll configuration, register width(imx hdmi register is one byte, but rk3288 is 4 bytes width and can only be

[PATCH v16 01/12] drm: imx: imx-hdmi: make checkpatch happy

2014-12-03 Thread Andy Yan
CHECK: Alignment should match open parenthesis + if ((hdmi-vic == 10) || (hdmi-vic == 11) || + (hdmi-vic == 12) || (hdmi-vic == 13) || CHECK: braces {} should be used on all arms of this statement + if (hdmi-hdmi_data.video_mode.mdvi) [...] + else { [...]

[PATCH v16 02/12] drm: imx: imx-hdmi: return defer if can't get ddc i2c adapter

2014-12-03 Thread Andy Yan
drm driver may probe before the i2c bus, so the driver should defer probing until it is available Signed-off-by: Andy Yan andy@rock-chips.com Reviewed-by: Daniel Kurtz djku...@chromium.org --- Changes in v16: None Changes in v15: None Changes in v14: None Changes in v13: None Changes in

[PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Andy Yan
IMX6 and Rockchip RK3288 and JZ4780 (Ingenic Xburst/MIPS) use the interface compatible Designware HDMI IP, but they also have some lightly differences, such as phy pll configuration, register width, 4K support, clk useage, and the crtc mux configuration is also platform specific. To reuse the imx

[PATCH v16 04/12] drm: imx: imx-hdmi: split phy configuration to platform driver

2014-12-03 Thread Andy Yan
hdmi phy configuration is platform specific, which can be adusted according to the board to get the best SI Signed-off-by: Andy Yan andy@rock-chips.com --- Changes in v16: None Changes in v15: None Changes in v14: None Changes in v13: - split phy configuration from patch#4 Changes in v12:

[PATCH v16 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi

2014-12-03 Thread Andy Yan
the original imx hdmi driver is under drm/imx/, which depends on imx-drm, so move the imx hdmi driver out to drm/bridge and rename it to dw_hdmi Signed-off-by: Andy Yan andy@rock-chips.com --- Changes in v16: None Changes in v15: - add prefix dw_hdmi/DW_HDMI for public used dw_hdmi structs

[PATCH v16 06/12] dt-bindings: add document for dw_hdmi

2014-12-03 Thread Andy Yan
Signed-off-by: Andy Yan andy@rock-chips.com --- Changes in v16: - describe ddc-i2c-bus as optional - add common clocks bindings Changes in v15: None Changes in v14: None Changes in v13: None Changes in v12: None Changes in v11: None Changes in v10: None Changes in v9: None Changes in v8: -

[PATCH v16 07/12] drm: bridge/dw_hdmi: add support for multi-byte register width access

2014-12-03 Thread Andy Yan
On rockchip rk3288, only word(32-bit) accesses are permitted for hdmi registers. Byte width accesses (writeb, readb) generate an imprecise external abort. Signed-off-by: Andy Yan andy@rock-chips.com --- Changes in v16: None Changes in v15: - remove unio of the multi-byte register access,

[PATCH v16 08/12] drm: bridge/dw_hdmi: add mode_valid support

2014-12-03 Thread Andy Yan
some platform may not support all the display mode, add mode_valid interface check it Signed-off-by: Andy Yan andy@rock-chips.com --- Changes in v16: None Changes in v15: None Changes in v14: - remove drm_connector_register, because imx-drm core has registered connector Changes in v13:

[PATCH v16 09/12] drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_wait_i2c_done

2014-12-03 Thread Andy Yan
HDMI_IH_I2CMPHY_STAT0 is a clear on write register, which indicates i2cm operation status(i2c transfer done or error), every hdmi phy register configuration must check this register to make sure the configuration has complete. But the indication bit should be cleared after check, otherwise the

[PATCH v16 10/12] drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare

2014-12-03 Thread Andy Yan
RK3288 HDMI will not work without the spare bit of HDMI_PHY_CONF0 enable Signed-off-by: Andy Yan andy@rock-chips.com --- Changes in v16: None Changes in v15: None Changes in v14: None Changes in v13: None Changes in v12: None Changes in v11: None Changes in v10: None Changes in v9: None

[PATCH v16 11/12] dt-bindings: Add documentation for rockchip dw hdmi

2014-12-03 Thread Andy Yan
Signed-off-by: Andy Yan andy@rock-chips.com --- Changes in v16: - modify clocks bindings - descrbie ddc-i2c-bus as optional Changes in v15: None Changes in v14: None Changes in v13: None Changes in v12: None Changes in v11: None Changes in v10: None Changes in v9: None Changes in v8: - Add

[PATCH v16 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-12-03 Thread Andy Yan
Rockchip RK3288 hdmi is compatible with dw_hdmi this patch is depend on patch by Mark Yao see https://lkml.org/lkml/2014/12/2/161 drm: rockchip: Add basic drm driver Signed-off-by: Andy Yan andy@rock-chips.com --- Changes in v16: None Changes in v15: - remove THIS_MODULE in platform driver

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Russell King - ARM Linux
On Wed, Dec 03, 2014 at 11:29:26PM +0800, Andy Yan wrote: +int imx_hdmi_bind(struct device *dev, struct device *master, + void *data, struct drm_encoder *encoder, + const struct imx_hdmi_plat_data *plat_data) { struct platform_device *pdev =

Re: [PATCH v16 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi

2014-12-03 Thread Russell King - ARM Linux
On Wed, Dec 03, 2014 at 11:32:12PM +0800, Andy Yan wrote: diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 884923f..26162ef 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -3,3 +3,8 @@ config DRM_PTN3460 depends on

Re: [PATCH v16 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi

2014-12-03 Thread Andy Yan
Hi Russell: On 2014年12月03日 23:45, Russell King - ARM Linux wrote: On Wed, Dec 03, 2014 at 11:32:12PM +0800, Andy Yan wrote: diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 884923f..26162ef 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Andy Yan
Hi Russell: On 2014年12月03日 23:38, Russell King - ARM Linux wrote: On Wed, Dec 03, 2014 at 11:29:26PM +0800, Andy Yan wrote: +int imx_hdmi_bind(struct device *dev, struct device *master, + void *data, struct drm_encoder *encoder, + const struct imx_hdmi_plat_data

Re: [PATCH v16 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi

2014-12-03 Thread Russell King - ARM Linux
On Thu, Dec 04, 2014 at 12:01:25AM +0800, Andy Yan wrote: Hi Russell: Do you mean I just neet to do like bellow? + +config DRM_DW_HDMI + bool + depends on DRM + select DRM_KMS_HELPER Yep. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Russell King - ARM Linux
On Thu, Dec 04, 2014 at 12:04:37AM +0800, Andy Yan wrote: Hi Russell: On 2014年12月03日 23:38, Russell King - ARM Linux wrote: On Wed, Dec 03, 2014 at 11:29:26PM +0800, Andy Yan wrote: +int imx_hdmi_bind(struct device *dev, struct device *master, + void *data, struct drm_encoder

[PATCH] staging: rtl8723au: hal: Removed spaces before semicolon

2014-12-03 Thread Anjana Sasindran
This patch fix the checkpatch.pl warning: WARNING: space prohibited before semicolon Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com --- drivers/staging/rtl8723au/hal/odm_HWConfig.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Philipp Zabel
Hi Andy, Am Donnerstag, den 04.12.2014, 00:04 +0800 schrieb Andy Yan: On 2014年12月03日 23:38, Russell King - ARM Linux wrote: On Wed, Dec 03, 2014 at 11:29:26PM +0800, Andy Yan wrote: +int imx_hdmi_bind(struct device *dev, struct device *master, +void *data, struct drm_encoder

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Andy Yan
On 2014年12月04日 00:11, Russell King - ARM Linux wrote: On Thu, Dec 04, 2014 at 12:04:37AM +0800, Andy Yan wrote: Hi Russell: On 2014年12月03日 23:38, Russell King - ARM Linux wrote: On Wed, Dec 03, 2014 at 11:29:26PM +0800, Andy Yan wrote: +int imx_hdmi_bind(struct device *dev, struct device

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Russell King - ARM Linux
On Wed, Dec 03, 2014 at 05:20:15PM +0100, Philipp Zabel wrote: Hi Andy, It would be better if the bind function would not have to care about platform resources, that should be handled in the probe function. I had a patch to move them:

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Russell King - ARM Linux
On Thu, Dec 04, 2014 at 12:30:23AM +0800, Andy Yan wrote: On 2014年12月04日 00:11, Russell King - ARM Linux wrote: I meant that imx_hdmi_bind should be passed these, so that it needs to know nothing about the struct device beyond the generic device structure. In other words, the dw-hdmi core

Re: Possible memory leak in function (reserve_range) not freeing pointer (regionid)

2014-12-03 Thread Ahmed Tamrawi
The bug was found via the memory-leak static analysis tool that we have built on top of C-Atlas framework from EnSoft. You can check it out (http://www.ensoftcorp.com/atlas/). Thanks for clarifying things! ~Ahmed On Wed, Dec 3, 2014 at 2:48 AM, Dan Carpenter dan.carpen...@oracle.com wrote:

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Andy Yan
Hi Russell: On 2014年12月04日 00:33, Russell King - ARM Linux wrote: On Thu, Dec 04, 2014 at 12:30:23AM +0800, Andy Yan wrote: On 2014年12月04日 00:11, Russell King - ARM Linux wrote: I meant that imx_hdmi_bind should be passed these, so that it needs to know nothing about the struct device beyond

[PATCH] Staging: dgnc: Fix long line coding style issues in dgnc_cls.h

2014-12-03 Thread Sean Cleator
A patch to fix the rest of the long line warnings in the dgnc_cls.h file found by the checkpatch.pl tool Signed-off-by: Sean Cleator seanclea...@hotmail.co.uk --- drivers/staging/dgnc/dgnc_cls.h | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git

Re: [PATCH] Staging: dgnc: Fix long line coding style issues in dgnc_cls.h

2014-12-03 Thread Greg KH
On Wed, Dec 03, 2014 at 05:07:28PM +, Sean Cleator wrote: A patch to fix the rest of the long line warnings in the dgnc_cls.h file found by the checkpatch.pl tool Signed-off-by: Sean Cleator seanclea...@hotmail.co.uk --- drivers/staging/dgnc/dgnc_cls.h | 22 +- 1

Re: [PATCH] Staging: dgnc: Fix long line coding style issues in dgnc_cls.h

2014-12-03 Thread Dan Carpenter
On Wed, Dec 03, 2014 at 09:34:41AM -0800, Greg KH wrote: +#define UART_IIR_CTSRTS0x20/* +* Received CTS/RTS change of +* state +*/

[PATCH v2 01/11] staging: comedi: hwdrv_apci1500: introduce z8536_read()

2014-12-03 Thread H Hartley Sweeten
The Z8536 CIO registers are indirectly read by writing the register offset to the control register then reading the control register to get the value. Introduce a helper function to read the Z8536 CIO registers. The registers are read from normal code and in the interrupt handler, spinlock the

[PATCH v2 00/11] staging: comedi: addi_apci_1500: initial cleanup

2014-12-03 Thread H Hartley Sweeten
This driver is pretty broken but in the current state its difficult to figure out where to fix it. Introduce a couple helper functions to handle the read/write and reset of the Z8536 CIO chip. This removes quite a bit of lines of code and makes the driver a _bit_ easier to follow. Tidy up the

[PATCH v2 03/11] staging: comedi: hwdrv_apci1500: introduce z8536_reset()

2014-12-03 Thread H Hartley Sweeten
Introduce a helper function to reset the Z8536 CIO device. Spinlock the initial reset of the Z8536 chip that puts it in State 0. The z8536_{read,write} operations already do the spinlock to protect the indirect register access. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc:

[PATCH v2 05/11] staging: comedi: addi_apci_1500: remove private data 'iobase'

2014-12-03 Thread H Hartley Sweeten
This member of the private data is the same as the comedi_device 'iobase'. Remove the private data member and use that instead. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 06/11] staging: comedi: addi_apci_1500: remove private data 'i_IobaseReserved'

2014-12-03 Thread H Hartley Sweeten
This member of the private data is set but not used by the driver. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/addi_apci_1500.c | 2 -- 1 file

[PATCH v2 07/11] staging: comedi: addi_apci_1500: use amcc_s5933.h defines

2014-12-03 Thread H Hartley Sweeten
PCI Bar 0 accesses the AMCC S5933 PCI controller used on this board. Use the defines from amcc_35933.h and remove the magic numbers. Rename the CamelCase private data member 'i_IobaseAmcc' used to hold the address for PCI Bar 0. Remove the unnecessary 'ui_Status' local variable in

[PATCH v2 04/11] staging: comedi: addi_apci_1500: tidy up PCI Bar 1 register map

2014-12-03 Thread H Hartley Sweeten
For aesthetics, convert the enum for the PCI Bar 1 register map to defines and move them to the main driver source file. Rename the registers. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 02/11] staging: comedi: hwdrv_apci1500: introduce z8536_write()

2014-12-03 Thread H Hartley Sweeten
The Z8536 CIO registers are indirectly written by writing the register offset to the control register then writing the value to the control register. Introduce a helper function to write the Z8536 CIO registers. The registers are written from normal code and in the interrupt handler, spinlock

[PATCH v2 09/11] staging: comedi: addi_apci_1500: tidy up PCI Bar 2 register map

2014-12-03 Thread H Hartley Sweeten
Move the PCI Bar 1 register map defines to the main driver source file. For aesthetics, rename the defines. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 11/11] staging: comedi: addi_apci_1500: handle shared interrupt

2014-12-03 Thread H Hartley Sweeten
The interrupt used by this driver is shared. If the board did not cause the interrupt the driver should return IRQ_NONE so that another driver can handle it. Fix the interrupt handler so this happens. Tidy up the interrupt handler a bit. Signed-off-by: H Hartley Sweeten

[PATCH v2 08/11] staging: comedi: addi_apci_1500: rename private data 'i_IobaseAddon'

2014-12-03 Thread H Hartley Sweeten
Rename this CamelCase member of the private data. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- .../comedi/drivers/addi-data/hwdrv_apci1500.c| 20

[PATCH v2 10/11] staging: comedi: addi_apci_1500: remove APCI1500_ADDRESS_RANGE

2014-12-03 Thread H Hartley Sweeten
This define is not used by the driver. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c | 3 --- 1 file changed, 3 deletions(-)

[PATCH] staging: panel: Remove unused variable

2014-12-03 Thread Mariusz Gorski
Remove lcd.left_shift because it is only written to at some places but never read from. Signed-off-by: Mariusz Gorski marius.gor...@gmail.com --- drivers/staging/panel/panel.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c

[PATCH] Staging: line6: fix parentheses around macro in usbdefs.h

2014-12-03 Thread Sam van Kampen
This patch fixes the error Macros with complex values should be enclosed in parentheses, as reported by checkpatch.pl. Signed-off-by: Sam van Kampen s...@tehsvk.net --- drivers/staging/line6/usbdefs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] Staging: line6: fix parentheses around macro in usbdefs.h

2014-12-03 Thread Joe Perches
On Wed, 2014-12-03 at 19:34 +0100, Sam van Kampen wrote: This patch fixes the error Macros with complex values should be enclosed in parentheses, as reported by checkpatch.pl. [] diff --git a/drivers/staging/line6/usbdefs.h b/drivers/staging/line6/usbdefs.h [] @@ -40,7 +40,7 @@ #define

Re: [PATCH] staging: panel: Remove unused variable

2014-12-03 Thread Willy Tarreau
On Wed, Dec 03, 2014 at 07:53:47PM +0100, Mariusz Gorski wrote: Remove lcd.left_shift because it is only written to at some places but never read from. Good catch, I think some code got dropped at some point because it was used to shift the window of displayed text. Anyway nobody seems to be

Re: [PATCH] Staging: dgnc: Fix long line coding style issues in dgnc_cls.h

2014-12-03 Thread Valdis . Kletnieks
On Wed, 03 Dec 2014 17:07:28 +, Sean Cleator said: A patch to fix the rest of the long line warnings in the dgnc_cls.h file found by the checkpatch.pl tool struct cls_uart_struct { u8 txrx;/* WR RHR/THR - Holding Reg */ u8 ier; /* WR IER - Interrupt

[PATCH v2] Staging: dgnc: Fix long line coding style issues in dgnc_cls.h

2014-12-03 Thread Sean Cleator
A patch to fix the rest of the long line warnings in the dgnc_cls.h file found by the checkpatch.pl tool Signed-off-by: Sean Cleator seanclea...@hotmail.co.uk --- drivers/staging/dgnc/dgnc_cls.h | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

[PATCH] Staging: octeon: Added several blank lines after declarations

2014-12-03 Thread Jamie Lawler
Hi, I've added blank lines after several declarations that were previously missing them, reducing the number of warnings from checkpatch.pl. Regards, Jamie Lawler Signed-off-by: Jamie Lawler jamie.law...@gmail.com --- drivers/staging/octeon/ethernet-rx.c | 4

Re: [PATCH] Staging: octeon: Added several blank lines after declarations

2014-12-03 Thread Aaro Koskinen
Hi, On Wed, Dec 03, 2014 at 09:43:51PM +, Jamie Lawler wrote: --- a/drivers/staging/octeon/ethernet-rx.c +++ b/drivers/staging/octeon/ethernet-rx.c @@ -84,6 +84,7 @@ static int cvm_irq_cpu; static void cvm_oct_enable_napi(void *_) { int cpu = smp_processor_id(); +

Re: [PATCH] Staging: octeon: Added several blank lines after declarations

2014-12-03 Thread Jamie Lawler
Thanks Aaro, I will do that now. Jamie On 3 December 2014 at 22:13, Aaro Koskinen aaro.koski...@iki.fi wrote: Hi, On Wed, Dec 03, 2014 at 09:43:51PM +, Jamie Lawler wrote: --- a/drivers/staging/octeon/ethernet-rx.c +++ b/drivers/staging/octeon/ethernet-rx.c @@ -84,6 +84,7 @@ static int

[PATCH] Staging: octeon: Added blank lines after declarations

2014-12-03 Thread Jamie Lawler
Hi, There are 2 missing blank lines after declarations in octeon/ethernet-rx.c. I have added them per the coding style. Regards, Jamie Lawler Signed-off-by: Jamie Lawler jamie.law...@gmail.com --- drivers/staging/octeon/ethernet-rx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Russell King - ARM Linux
On Thu, Dec 04, 2014 at 12:56:24AM +0800, Andy Yan wrote: Hi Russell: On 2014年12月04日 00:33, Russell King - ARM Linux wrote: On Thu, Dec 04, 2014 at 12:30:23AM +0800, Andy Yan wrote: On 2014年12月04日 00:11, Russell King - ARM Linux wrote: I meant that imx_hdmi_bind should be passed these, so

Re: [PATCH v2] Staging: dgnc: Fix long line coding style issues in dgnc_cls.h

2014-12-03 Thread Joe Perches
On Wed, 2014-12-03 at 21:30 +, Sean Cleator wrote: A patch to fix the rest of the long line warnings in the dgnc_cls.h file found by the checkpatch.pl tool checkpatch is a brainless little tool. You should prefer to develop a readable style rather than pay too close attention to precisely

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Andy Yan
Hi Russel: On 2014年12月04日 07:40, Russell King - ARM Linux wrote: On Thu, Dec 04, 2014 at 12:56:24AM +0800, Andy Yan wrote: Hi Russell: On 2014年12月04日 00:33, Russell King - ARM Linux wrote: On Thu, Dec 04, 2014 at 12:30:23AM +0800, Andy Yan wrote: On 2014年12月04日 00:11, Russell King - ARM Linux

[PATCH] Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer ar

2014-12-03 Thread Arun
--- drivers/staging/bcm/CmHost.h |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/bcm/CmHost.h b/drivers/staging/bcm/CmHost.h index 0887d3f..a6e30da 100644 --- a/drivers/staging/bcm/CmHost.h +++ b/drivers/staging/bcm/CmHost.h @@ -20,8 +20,8 @@

Re: Possible memory leak in function (reserve_range) not freeing pointer (regionid)

2014-12-03 Thread Greg KH
On Sun, Nov 30, 2014 at 09:49:23PM -0600, Ahmed Tamrawi wrote: On Sun, Nov 30, 2014 at 8:51 PM, Greg KH gre...@linuxfoundation.org wrote: On Sun, Nov 30, 2014 at 02:00:45PM -0600, Ahmed Tamrawi wrote: Bug Report: https://bugzilla.kernel.org/show_bug.cgi?id=89101 Linux Version [3.17-rc1]

Re: PATCH

2014-12-03 Thread Greg Kroah-Hartman
On Mon, Dec 01, 2014 at 11:05:10AM +0530, Parth Sane wrote: Hi Greg, I have looked at the patches and documentation on how to proceed forward. But I have a doubt. Was hoping you could make it clear for me. You have said that you don't want unnecessary binary firmware files in the source which

Ralink 6570 / Mediatek MT7601STA (was Re: Addition of a wifi kernel module to the linux source tree)

2014-12-03 Thread Greg Kroah-Hartman
On Sun, Nov 30, 2014 at 06:55:12PM +, Parth Sane wrote: Hi Greg, You can find the source code attached as a tarball. It works and I have tested it myself. You only need to use make and make install for this. This really looks like a variant of some existing devices, the rt2x00, Ralink

Re: [PATCH] Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer

2014-12-03 Thread Greg KH
On Wed, Dec 03, 2014 at 05:12:09PM -0800, Arun wrote: --- drivers/staging/bcm/CmHost.h |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) That's a really odd subject, don't you agree? :) ___ devel mailing list

Re: Ralink 6570 / Mediatek MT7601STA (was Re: Addition of a wifi kernel module to the linux source tree)

2014-12-03 Thread Parth Sane
Hi, I'd say I'm midway through with c programming(part of my computer engineering degree course) and know a decent amount of git. So yes I'm comfortable writing code. Also here's the link to an eBay listing for the same hardware.

Re: [PATCH] Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer

2014-12-03 Thread Greg KH
On Wed, Dec 03, 2014 at 05:31:59PM -0800, arun vijayshankar wrote: Hi Greg, If you turn off HTML email, your message will not get rejected by the mailing lists :) I completely agree! I thought of keeping the patch summary as the subject, but I wasn't sure and ending up entering nothing. Git

Re: [PATCH] Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer

2014-12-03 Thread Joe Perches
On Wed, 2014-12-03 at 17:39 -0800, Greg KH wrote: On Wed, Dec 03, 2014 at 05:31:59PM -0800, arun vijayshankar wrote: Hi Greg, If you turn off HTML email, your message will not get rejected by the mailing lists :) I completely agree! I thought of keeping the patch summary as the subject,

[PATCH 1/1] Staging: ft1000: fix some coding style issues

2014-12-03 Thread Kevin Pietsch
Removed braces from two single line if-else statements Signed-off-by: Kevin Pietsch kevinpiet...@gmail.com --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c

Re: [PATCH] Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer

2014-12-03 Thread arun vijayshankar
Thanks Greg and Joe! I will work against -next Regards, Arun. On Wed, Dec 3, 2014 at 5:43 PM, Joe Perches j...@perches.com wrote: On Wed, 2014-12-03 at 17:39 -0800, Greg KH wrote: On Wed, Dec 03, 2014 at 05:31:59PM -0800, arun vijayshankar wrote: Hi Greg, If you turn off HTML email,

Re: [PATCH 1/1] Staging: ft1000: fix some coding style issues

2014-12-03 Thread Joe Perches
On Wed, 2014-12-03 at 20:49 -0500, Kevin Pietsch wrote: Removed braces from two single line if-else statements Another perhaps better option is to use ?: like: --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git

[PATCH v3] staging: rtl8192u: fix sparse warnings

2014-12-03 Thread Fred Chou
From: Fred Chou fred.chou...@gmail.com Fixed the following warnings in sparse: drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom' was not declared. Should it be static? drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning: symbol 'ComputeTxTime'

Re: Ralink 6570 / Mediatek MT7601STA (was Re: Addition of a wifi kernel module to the linux source tree)

2014-12-03 Thread Greg Kroah-Hartman
On Thu, Dec 04, 2014 at 07:07:58AM +0530, Parth Sane wrote: Hi, I'd say I'm midway through with c programming(part of my computer engineering degree course) and know a decent amount of git. So yes I'm comfortable writing code. Ok great, let's see if it's just a matter of some changes to the

Re: Ralink 6570 / Mediatek MT7601STA (was Re: Addition of a wifi kernel module to the linux source tree)

2014-12-03 Thread Julian Calaby
Hi Greg, On Thu, Dec 4, 2014 at 3:39 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Dec 04, 2014 at 07:07:58AM +0530, Parth Sane wrote: Hi, I'd say I'm midway through with c programming(part of my computer engineering degree course) and know a decent amount of git. So yes

Re: [PATCH v3] staging: rtl8192u: fix sparse warnings

2014-12-03 Thread Sudip Mukherjee
. and your patch doesnot apply to next-20141203 sudip drivers/staging/rtl8192u/r8192U_core.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 7640386..2c61801 100644