Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On Dec 7, 2016, at 10:20 AM, Quentin Lambert wrote: > Hi all, > > I am looking at the drivers/staging/lustre/lustre/llite/dir.c: > > 1469 /* Call mdc_iocontrol */ > 1470 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp, sizeof(fid), > , > 1471

[PATCH] Staging: iio: impedance-analyzer: ad5933: fix wrong comments

according to datasheet complete control register is of 2 bytes. http://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf Signed-off-by: Nizam Haider --- drivers/staging/iio/impedance-analyzer/ad5933.c | 4 ++-- 1 file changed, 2 insertions(+), 2

RE: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Wednesday, December 7, 2016 8:40 AM > To: KY Srinivasan > Cc: vkuzn...@redhat.com; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org > Subject: Re: move

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On Dec 7, 2016, at 10:33 AM, Dan Carpenter wrote: > Lustre is kind of a mess with regards to keeping user and kernel > pointers separate. It's not going to be easy to fix. Actually I believe I made significant inroads in properly cleaning (almost?) everything in this area about a year ago (to

[PATCH 2/3] hyperv: Add a function to detect if the device is a vmbus dev

From: Haiyang Zhang On Hyper-V, every VF interface has a corresponding synthetic interface managed by netvsc that share the same MAC address. netvsc registers for netdev events to manage this association. Currently we use the MAC address to manage this association but

[PATCH 1/3] hyperv: Move hv_pci_dev and related structs to hyperv.h

From: Haiyang Zhang Move some vPCI data structures to hyperv.h, because we share them with other module. Signed-off-by: Haiyang Zhang Signed-off-by: K. Y. Srinivasan --- drivers/pci/host/pci-hyperv.c | 91

[PATCH 3/3] hv_netvsc: Implement VF matching based on serial numbers

From: Haiyang Zhang We currently use MAC address to match VF and synthetic NICs. Hyper-V provides a serial number to both devices for this purpose. This patch implements the matching based on VF serial numbers. This is the way specified by the protocol and more reliable.

[PATCH 0/3] Drivers: hv: Implement VF association based on serial number

From: K. Y. Srinivasan Implement VF association based on serial number published by the host. Greg, as promised here is the patchset that would use the API for detecting if the device is a vmbus device. If you can take the first two patches, we can submit the netvsc patch to

Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

> Sorry, I was unclear. I have no problem with white space changes on > their own or when they are on the same line as something else you're > changing. > > What I meant is that when you're just moving functions around then don't > mix unrelated white space changes into that patch. I have

[staging:staging-testing 576/798] ERROR: "bad_dma_ops" [drivers/iio/adc/ti_am335x_adc.ko] undefined!

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 859d8e458746f56cd8a4936b52f6fc746d3f60dc commit: f5f4c80e9a439cd3797ccfacb8393c4d7db3bdc4 [576/798] staging: vc04_services: add HAS_DMA dependancy config: m32r-allmodconfig (attached as .config)

[PATCH 4/8] staging/lustre/lov: make lov_lsm_alloc() static

It's not used anywhere outside of this file. Highlighted by sparse. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lov/lov_pack.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c

[PATCH 2/8] staging/lustre/ldlm: Correct itree_overlap_cb return type

As per interval_search() prototype, the callback should return enum, not int. This fixes correspondign sparse warning. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/8] staging/lustre/llite: mark ll_io_init() static

It's not used anywhere out of this file. Highlighted by sparse. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/file.c

[PATCH v2] staging: lustre: osc: handle osc eviction correctly

From: Jinshan Xiong Cleanup everything if an OSC is being evicted. Group lock is not well supported yet. Signed-off-by: Jinshan Xiong Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6271 Reviewed-on: http://review.whamcloud.com/14989

[PATCH 5/8] staging/lustre/osc: extern declare osc_caches in a header

This avoids frowned upon extern in the C file, and also shuts down a sparse warning of drivers/staging/lustre/lustre/osc/osc_dev.c:55:22: warning: symbol 'osc_caches' was not declared. Should it be static? Signed-off-by: Oleg Drokin ---

[PATCH 1/8] staging/lustre/llite: move root_squash from sysfs to debugfs

root_squash control got accidentally moved to sysfs instead of debugfs, and the write side of it was also broken expecting a userspace buffer. It contains both uid and gid values in a single file, so debugfs is a clear place for it. Reported-by: Al Viro Fixes:

[PATCH 6/8] staging/lustre: Declare lu_context/session_tags_default

Make the declaration in a header, not as an extern in a C file, that is frowned upon. This also makes sparse a little bit more happy. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lu_object.h | 3 +++

[PATCH 0/8] Sparse warning fixes in Lustre.

This set of fixes aims at sparse warnings. Most of the patches are just moving declarations around to deal with the warning: symbol 'xxx' was not declared. Should it be static? kind of messages. Also a screwup with root_squash sysfs control is fixed. Oleg Drokin (8): staging/lustre/llite: move

[PATCH 7/8] staging/lustre: Move lov_read_and_clear_async_rc declaration

Move it to obd.h, so that it's included from both the users and the actual definition, making sure they never get out of sync. This also silences a sparse warning. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd.h| 3 +++

[PATCH 8/8] staging/lustre/ptlrpc: Move nrs_conf_fifo extern to a header

This avoids having an extern definition in a C file which is bad, and also silences sparse complaint as well. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/nrs.c | 3 --- drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 3 +++ 2

[PATCH] staging: lustre: lnet: make brw_inject_one_error() static

It's not used anywhere outside of brw_test.c file. Highlighted by sparse. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/brw_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/selftest/brw_test.c

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On Wed, Dec 07, 2016 at 04:42:30PM +0100, Quentin Lambert wrote: > > > On 12/07/2016 04:33 PM, Dan Carpenter wrote: > >Lustre is kind of a mess with regards to keeping user and kernel > >pointers separate. It's not going to be easy to fix. > Fair enough. > I am trying to make a contribution to

Re: [PATCH] staging/lustre/osc: Revert erroneous list_for_each_entry_safe use

On Wed, Dec 07, 2016 at 11:29:36AM -0500, Oleg Drokin wrote: > > On Dec 7, 2016, at 5:40 AM, Greg Kroah-Hartman wrote: > > > On Tue, Dec 06, 2016 at 10:53:48PM -0500, Oleg Drokin wrote: > >> I have been having a lot of unexplainable crashes in osc_lru_shrink > >> lately that I could not see a

[PATCH 0/2] Drivers: hv: vmbus: Make CPU offlining more fine grained

From: K. Y. Srinivasan Enhance CPU online/offline management. Vitaly Kuznetsov (2): hv: switch to cpuhp state machine for synic init/cleanup hv: make CPU offlining prevention fine-grained drivers/hv/hv.c | 46 +---

[PATCH 1/2] hv: switch to cpuhp state machine for synic init/cleanup

From: Vitaly Kuznetsov To make it possible to online/offline CPUs switch to cpuhp infrastructure for doing hv_synic_init()/hv_synic_cleanup(). Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv.c

[PATCH 2/2] hv: make CPU offlining prevention fine-grained

From: Vitaly Kuznetsov Since commit e513229b4c38 ("Drivers: hv: vmbus: prevent cpu offlining on newer hypervisors") cpu offlining was disabled. It is still true that we can't offline CPUs which have VMBus channels bound to them but we may have 'free' CPUs (e.v. we booted

Re: [lustre-devel] [PATCH] staging/lustre/osc: Revert erroneous list_for_each_entry_safe use

On Dec 7, 2016, at 3:37 PM, Greg Kroah-Hartman wrote: > On Wed, Dec 07, 2016 at 11:29:36AM -0500, Oleg Drokin wrote: >> >> On Dec 7, 2016, at 5:40 AM, Greg Kroah-Hartman wrote: >> >>> On Tue, Dec 06, 2016 at 10:53:48PM -0500, Oleg Drokin wrote: I have been having a lot of unexplainable

RE: [PATCH v3 1/9] staging: fsl-mc: move bus driver out of staging

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, December 07, 2016 9:53 AM > To: Stuart Yoder > Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; ag...@suse.de; > a...@arndb.de; Leo Li > ;

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

> > On 12/07/2016 04:33 PM, Dan Carpenter wrote: > > >Lustre is kind of a mess with regards to keeping user and kernel > > >pointers separate. It's not going to be easy to fix. > > Fair enough. > > I am trying to make a contribution to drivers/staging using sparse. > > With that in mind, do you

move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

KY, if a hyperv VM crashes alot of work must be done to prepare the environment for the kdump kernel. This approach is different compared to all the other VM types, or baremetal. Since the just crashed kernel is per definition unreliable all that work should be done within the kdump kernel

Re: [PATCH] staging/lustre/osc: Revert erroneous list_for_each_entry_safe use

On Tue, Dec 06, 2016 at 10:53:48PM -0500, Oleg Drokin wrote: > I have been having a lot of unexplainable crashes in osc_lru_shrink > lately that I could not see a good explanation for and then I found > this patch that slip under the radar somehow that incorrectly > converted while loop for lru

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

On Wed, Dec 07, 2016 at 02:16:06PM +0200, Kalle Valo wrote: > We have disccused this before, but for wireless it's not really that > simple. AFAIK with dyndbg you can only control the messages per line > (painful to enable group of messages) or per file (enables too many > messages). In wireless

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

Greg KH writes: > On Mon, Dec 05, 2016 at 04:34:08PM -0600, Larry Finger wrote: >> On 12/05/2016 03:34 PM, Dan Carpenter wrote: >> > On Thu, Dec 01, 2016 at 07:48:29PM -0600, Larry Finger wrote: >> > > --- >> > >

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

Hi all, I am looking at the drivers/staging/lustre/lustre/llite/dir.c: 1469 /* Call mdc_iocontrol */ 1470 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp, sizeof(fid), , 1471); 1472 if (rc) and sparse says:

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On Wed, Dec 07, 2016 at 04:20:06PM +0100, Quentin Lambert wrote: > Hi all, > > I am looking at the drivers/staging/lustre/lustre/llite/dir.c: > > 1469 /* Call mdc_iocontrol */ > 1470 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp, > sizeof(fid), , > 1471

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

Lustre is kind of a mess with regards to keeping user and kernel pointers separate. It's not going to be easy to fix. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

RE: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Wednesday, December 7, 2016 12:51 AM > To: KY Srinivasan ; vkuzn...@redhat.com > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org > Subject: move

Re: [PATCH 0/8] Sparse warning fixes in Lustre.

On Wed, Dec 07, 2016 at 05:41:26PM -0500, Oleg Drokin wrote: > This set of fixes aims at sparse warnings. Speaking of the stuff sparse catches there: class_process_proc_param(). I've tried to describe what I think of that Fine Piece Of Software several times, but I had to give up - my command of

Re: [PATCH 2/8] staging/lustre/ldlm: Correct itree_overlap_cb return type

> As per interval_search() prototype, the callback should return > enum, not int. > This fixes correspondign sparse warning. > > Signed-off-by: Oleg Drokin Reviewed-by: James Simmons > --- > drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 +-

Re: [PATCH 8/8] staging/lustre/ptlrpc: Move nrs_conf_fifo extern to a header

> This avoids having an extern definition in a C file which is bad, > and also silences sparse complaint as well. > > Signed-off-by: Oleg Drokin Reviewed-by: James Simmons > --- > drivers/staging/lustre/lustre/ptlrpc/nrs.c | 3 --- >

Re: [PATCH 04/22] staging: lustre: osc: handle osc eviction correctly

> On Dec 5, 2016, at 3:55 PM, Dan Carpenter wrote: > > > On Fri, Dec 02, 2016 at 07:53:11PM -0500, James Simmons wrote: > >> @@ -3183,8 +3182,10 @@ static int discard_cb(const struct lu_env *env, > >> struct cl_io *io, > >>/* page is top page. */ > >>info->oti_next_index =

[PATCH] staging: fsl-mc: add sysfs ABI doc

define the bind/unbind sysfs interfaces for the fsl-mc bus Signed-off-by: Stuart Yoder --- Documentation/ABI/testing/sysfs-bus-fsl-mc | 21 + 1 file changed, 21 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-bus-fsl-mc diff --git

[PATCH] staging: fsl-mc: remove unnecessary info prints from bus driver

remove pr_info/dev_info prints that add unnecessary verbosity Signed-off-by: Stuart Yoder --- drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c

Re: [PATCH 7/8] staging/lustre: Move lov_read_and_clear_async_rc declaration

> Move it to obd.h, so that it's included from both the users and > the actual definition, making sure they never get out of sync. > This also silences a sparse warning. Reviewed-by: James Simmons > Signed-off-by: Oleg Drokin > --- >

Re: [PATCH 8/8] staging/lustre/ptlrpc: Move nrs_conf_fifo extern to a header

> This avoids having an extern definition in a C file which is bad, > and also silences sparse complaint as well. > > Signed-off-by: Oleg Drokin Reviewed-by: James Simmons > --- > drivers/staging/lustre/lustre/ptlrpc/nrs.c | 3 --- >

Re: [PATCH 2/8] staging/lustre/ldlm: Correct itree_overlap_cb return type

> As per interval_search() prototype, the callback should return > enum, not int. > This fixes correspondign sparse warning. > > Signed-off-by: Oleg Drokin Reviewed-by: James Simmons > --- > drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 +-

Re: [PATCH 5/8] staging/lustre/osc: extern declare osc_caches in a header

> This avoids frowned upon extern in the C file, and also > shuts down a sparse warning of > drivers/staging/lustre/lustre/osc/osc_dev.c:55:22: warning: symbol > 'osc_caches' was not declared. Should it be static? Reviewed-by: James Simmons > Signed-off-by: Oleg

Re: [PATCH 6/8] staging/lustre: Declare lu_context/session_tags_default

> Make the declaration in a header, not as an extern in a C file, > that is frowned upon. > This also makes sparse a little bit more happy. > Reviewed-by: James Simmons > Signed-off-by: Oleg Drokin > --- >

Re: [PATCH 1/8] staging/lustre/llite: move root_squash from sysfs to debugfs

> root_squash control got accidentally moved to sysfs instead of > debugfs, and the write side of it was also broken expecting a > userspace buffer. > It contains both uid and gid values in a single file, so debugfs > is a clear place for it. I see why this was missed. The uid/gid pair I needed

Re: [PATCH 5/8] staging/lustre/osc: extern declare osc_caches in a header

> This avoids frowned upon extern in the C file, and also > shuts down a sparse warning of > drivers/staging/lustre/lustre/osc/osc_dev.c:55:22: warning: symbol > 'osc_caches' was not declared. Should it be static? Reviewed-by: James Simmons > Signed-off-by: Oleg

Re: [PATCH 4/8] staging/lustre/lov: make lov_lsm_alloc() static

> It's not used anywhere outside of this file. > Highlighted by sparse. Reviewed-by: James Simmons > Signed-off-by: Oleg Drokin > --- > drivers/staging/lustre/lustre/lov/lov_pack.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

Re: [PATCH 3/8] staging/lustre/llite: mark ll_io_init() static

> It's not used anywhere out of this file. > Highlighted by sparse. Reviewed-by: James Simmons > Signed-off-by: Oleg Drokin > --- > drivers/staging/lustre/lustre/llite/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On 12/07/2016 04:33 PM, Dan Carpenter wrote: Lustre is kind of a mess with regards to keeping user and kernel pointers separate. It's not going to be easy to fix. Fair enough. I am trying to make a contribution to drivers/staging using sparse. With that in mind, do you still fill I should

RE: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Wednesday, December 7, 2016 7:47 AM > To: KY Srinivasan ; vkuzn...@redhat.com > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org > Subject: RE: move

Re: [PATCH v3 1/9] staging: fsl-mc: move bus driver out of staging

On Thu, Dec 01, 2016 at 04:41:26PM -0600, Stuart Yoder wrote: > Move the source files out of staging into their final locations: > -include files in drivers/staging/fsl-mc/include go to include/linux/fsl > -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip > -source in

RE: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

Am 7. Dezember 2016 16:04:29 MEZ, schrieb KY Srinivasan : >Yes; I had played with this approach a while ago. The issue is that the >host knows about a >bunch of in memory state that will be different in the kexec kernel. >For instance if we did all >the cleanup as part of the

Re: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

On Wed, Dec 07, KY Srinivasan wrote: > Is there a mechanism for stashing away state that can be retrieved in > the context of the execed kernel. I have to find out. To simplify things the new approach may only be used in the kdump case, which already passes various info in cmdline. Most likely

Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

> On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote: > > From: Ben Evans > > > > Remove all obdo related functions from lustre_idl.h > > Create lustre_odbo.h. Include where appropriate. > > Make the functions lustre_get_wire_obdo and > > lustre_set_wire_obdo to not

RE: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Wednesday, December 7, 2016 8:19 AM > To: KY Srinivasan > Cc: vkuzn...@redhat.com; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org > Subject: Re: move

Re: [PATCH] staging/lustre/osc: Revert erroneous list_for_each_entry_safe use

On Dec 7, 2016, at 5:40 AM, Greg Kroah-Hartman wrote: > On Tue, Dec 06, 2016 at 10:53:48PM -0500, Oleg Drokin wrote: >> I have been having a lot of unexplainable crashes in osc_lru_shrink >> lately that I could not see a good explanation for and then I found >> this patch that slip under the

Re: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel

On Wed, Dec 07, KY Srinivasan wrote: > May be a better solution might be to have a new mechanism to indicate > to the host that all state of the previous incarnation of the kernel > needs to be cleaned up. This will be close to what we have on > hardware. That would be cool, but until this

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

On 12/07/2016 07:32 AM, Dan Carpenter wrote: On Wed, Dec 07, 2016 at 02:16:06PM +0200, Kalle Valo wrote: We have disccused this before, but for wireless it's not really that simple. AFAIK with dyndbg you can only control the messages per line (painful to enable group of messages) or per file