Re: [PATCH 60/60] staging: lustre: libcfs: fix minimum size check for libcfs ioctl

On Mon, Jan 30, 2017 at 01:51:56PM +0300, Dan Carpenter wrote: > The lstcon_ioctl_entry() function doesn't have enough size checking. Actually, the lstcon_ioctl_entry() would have been fine before we apply this [patch 60/60]... As near as I can tell, no in kernel code is negatively affected by

Need a second set of eyeballs for a possible startup race condition in vc04_services/vchiq.

Resending to a larger e-mail list... On Mon, 2017-01-30 at 04:57 -0800, Michael Zoran wrote: > I'm looking at linux-next: > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > > First it looks this is some kind of startup notification mechanism > and > it is used by the custom

Re: [PATCH 13/60] staging: lustre: obdclass: health_check to report unhealthy upon LBUG

Wat? I'm sorry but this patch makes no sense at all. On Sat, Jan 28, 2017 at 07:04:41PM -0500, James Simmons wrote: > From: Bruno Faccini > > When a LBUG has occurred, without panic_on_lbug being set, > health_check sysfs file must return an unhealthy state. Why? >

Re: [PATCH v3 00/24] i.MX Media Driver

> The central issue seems to be that I think media pad links / media bus > formats should describe physical links, such as parallel or serial > buses, and the formats of pixels flowing through them, whereas Steve > would like to extend them to describe software transports and in-memory > formats.

[PATCH v5 3/3] hv_utils: implement Hyper-V PTP source

With TimeSync version 4 protocol support we started updating system time continuously through the whole lifetime of Hyper-V guests. Every 5 seconds there is a time sample from the host which triggers do_settimeofday[64](). While the time from the host is very accurate such adjustments may cause

[PATCH v5 2/3] hv: export current Hyper-V clocksource

As a preparation to implementing Hyper-V PTP device supporting .getcrosststamp we need to export a reference to the current Hyper-V clocksource in use (MSR or TSC page). Signed-off-by: Vitaly Kuznetsov --- arch/x86/hyperv/hv_init.c | 13 +

[PATCH v5 0/3] hv_util: adjust system time smoothly

With TimeSync version 4 protocol support we started updating system time continuously through the whole lifetime of Hyper-V guests. Every 5 seconds there is a time sample from the host which triggers do_settimeofday[64](). While the time from the host is very accurate such adjustments may cause

[PATCH v5 1/3] hv_util: switch to using timespec64

do_settimeofday() is deprecated, use do_settimeofday64() instead. Signed-off-by: Vitaly Kuznetsov Acked-by: John Stultz Acked-by: Thomas Gleixner --- drivers/hv/hv_util.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH 05/60] staging: lustre: llite: check request != NULL in ll_migrate

On Sat, Jan 28, 2017 at 07:04:33PM -0500, James Simmons wrote: > From: wang di > > Check if the request is NULL, before retrieve reply body > from the request. > > Signed-off-by: wang di > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7396 >

[patch] staging: lustre: libcfs: double copy bug

The problem is that we copy hdr.ioc_len, we verify it, then we copy it again without checking to see if it has changed in between the two copies. This could result in an information leak. Signed-off-by: Dan Carpenter diff --git

Re: [PATCH 60/60] staging: lustre: libcfs: fix minimum size check for libcfs ioctl

It looks like what happened is there were two patches applied out of sync. Let's add a fixes tag and CC the original author. Fixes: ed2f549dc0f6 ("staging: lustre: libcfs: test if userland data is to small") This patch was probably correct when it was written but commit 1290932728e5 ("staging:

Re: [PATCH] staging: greybus: operation: add generic timeout support

On 27/01/17 09:55, Greg Kroah-Hartman wrote: > On Tue, Jan 24, 2017 at 03:57:54PM +, Bryan O'Donoghue wrote: >> On 24/01/17 15:09, Johan Hovold wrote: >> >>> Bryan, if you could consider my review feedback and respin your last >>> three patches on top of my timeout patch, I think we should be

Re: [PATCH] staging: greybus: loopback: fix broken udelay

On 26/01/17 11:37, Johan Hovold wrote: > The loopback driver allows the user to set a minimum delay of up to one > second to be inserted between test iterations (i.e. request > submissions). The delay is currently specified in microseconds and is > implemented using udelay. > > Busy looping for

Need a second set of eyeballs for a possible startup race condition in vc04_services/vchiq.

I'm looking at linux-next: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c First it looks this is some kind of startup notification mechanism and it is used by the custom RPI kernel on www.github.com. Client drivers call vchiq_add_connected_callback to register for a

Re: [PATCH v4 2/2] hv_utils: implement Hyper-V PTP source

KY Srinivasan writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Thursday, January 19, 2017 6:17 AM >> To: de...@linuxdriverproject.org >> Cc: Thomas Gleixner ; linux-ker...@vger.kernel.org; >> Haiyang

Re: [PATCH 1/1] iio: fixed symbolic permission references 'S_IRUGO | S_IWUSR'

Artur Lorincz schrieb am 30.01.2017 um 11:10: > Replaced the symbolic permission references S_IRUGO and S_IWUSR with their > octal counterparts. Hi Artur, patches concerning IIO should be sent to the linux-iio mailing list, and former maintainers of the file should be CC'ed. Now, regarding your

Re: [PATCH v3 16/24] media: Add i.MX media core driver

On Mon, Jan 23, 2017 at 12:13:26PM +0100, Philipp Zabel wrote: > Hi Steve, > > On Sun, 2017-01-22 at 18:31 -0800, Steve Longerbeam wrote: > > Second, ignoring the above locking issue for a moment, > > v4l2_pipeline_pm_use() > > will call s_power on the sensor _first_, then the mipi csi-2

Re: [PATCH 001] staging: wlan-ng: Add tabstop preceding the statement

On Mon, Jan 30, 2017 at 11:31:42AM -0500, Maksymilian Piechota wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: Statements should start on a tabstop > > Signed-off-by: Maksymilian Piechota > --- > drivers/staging/wlan-ng/prism2mgmt.c | 2 +- > 1

Re: [PATCH 1/1] iio: fixed symbolic permission references 'S_IRUGO | S_IWUSR'

On Mon, Jan 30, 2017 at 11:10:36AM +0100, Artur Lorincz wrote: > Replaced the symbolic permission references S_IRUGO and S_IWUSR with their > octal counterparts. > > Signed-off-by: Artur Lorincz > --- > drivers/staging/iio/adc/ad7192.c | 8 > 1 file changed, 4

Re: [PATCH 1/1] iio: fixed symbolic permission references 'S_IRUGO | S_IWUSR'

On Mon, Jan 30, 2017 at 11:47:35AM +0100, Hartmut Knaack wrote: > Artur Lorincz schrieb am 30.01.2017 um 11:10: > > Replaced the symbolic permission references S_IRUGO and S_IWUSR with their > > octal counterparts. > > Hi Artur, > patches concerning IIO should be sent to the linux-iio mailing

[PATCH 001] staging: wlan-ng: Add tabstop preceding the statement

This patch fixes the checkpatch.pl warning: WARNING: Statements should start on a tabstop Signed-off-by: Maksymilian Piechota --- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] staging: bcm2835-audio: Strengthen build dependencies

Michael Zoran writes: > This driver makes no sense outside of ARM or ARM64. > Add an explicit build dependency on: > (ARM || ARM64 || COMPILE_TEST) > > Also set the default build to n > > Signed-off-by: Michael Zoran > --- >

Re: [PATCH RESEND] staging: media: lirc: use new parport device model

On Sat, Jan 21, 2017 at 12:55:54AM +, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > Modify lirc_parallel driver to use the new parallel port device model. > > Signed-off-by: Sudip Mukherjee > --- > > Resending after

RE: [PATCH 00/14] hv: vmbus cleanup patches

Why don't I rebase (on char-misc-next) and put the functional patches in first then the cleanups -Original Message- From: KY Srinivasan Sent: Saturday, January 28, 2017 10:09 AM To: Stephen Hemminger ; Haiyang Zhang Cc:

Re: [PATCH] Staging: media: lirc: style fix, using octal file permissions

On Sat, Jan 07, 2017 at 04:02:55PM +1300, Derek Robson wrote: > Change file permissions to octal style. > Found using checkpatch > > Signed-off-by: Derek Robson > --- > drivers/staging/media/lirc/lirc_imon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH] staging: bcm2835-audio: Strengthen build dependencies

On Mon, 2017-01-30 at 08:56 -0800, Eric Anholt wrote: > Michael Zoran writes: > > > This driver makes no sense outside of ARM or ARM64. > > Add an explicit build dependency on: > > (ARM || ARM64 || COMPILE_TEST) > > > > Also set the default build to n > > > >

Re: Need a second set of eyeballs for a possible startup race condition in vc04_services/vchiq.

On Tue, 2017-01-31 at 00:01 +0300, Dan Carpenter wrote: > It's hard to review this because there are no callers and the hash > you're talking about is an RPI hash...  You have no idea how lazy I > am. > > You're right, that code looks racy but it's almost certainly harmless > depending on how

RE: [PATCH v2 0/2] scsi: storvsc: Add support for FC lightweight host.

> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Sunday, January 29, 2017 12:56 AM > To: KY Srinivasan > Cc: Christoph Hellwig ; Cathy Avery > ; Haiyang Zhang ; >

Re: [PATCH v3 19/24] media: imx: Add IC subdev drivers

On Fri, Jan 06, 2017 at 06:11:37PM -0800, Steve Longerbeam wrote: > This is a set of three media entity subdevice drivers for the i.MX > Image Converter. The i.MX IC module contains three independent > "tasks": > > - Pre-processing Encode task: video frames are routed directly from > the CSI

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

On Fri, Jan 06, 2017 at 06:11:35PM -0800, Steve Longerbeam wrote: > This is a media entity subdevice for the i.MX Camera > Serial Interface module. > > Signed-off-by: Steve Longerbeam warning: 3 lines add whitespace errors. Applying: media: imx: Add CSI subdev

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

On Fri, Jan 06, 2017 at 06:11:39PM -0800, Steve Longerbeam wrote: > Adds MIPI CSI-2 Receiver subdev driver. This subdev is required > for sensors with a MIPI CSI2 interface. > > Signed-off-by: Steve Longerbeam Applying: media: imx: Add MIPI CSI-2 Receiver subdev

Re: [PATCH v3 06/24] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

On Fri, Jan 06, 2017 at 06:11:24PM -0800, Steve Longerbeam wrote: > + ov5640: camera@40 { > + compatible = "ovti,ov5640"; > + pinctrl-names = "default"; > + pinctrl-0 = <_ov5640>; > + clocks = <_xclk>; > + clock-names = "xclk"; > +

Re: [PATCH v3 06/24] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

On Fri, Jan 06, 2017 at 06:11:24PM -0800, Steve Longerbeam wrote: > diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts > b/arch/arm/boot/dts/imx6q-sabrelite.dts > index 66d10d8..9e2d26d 100644 > --- a/arch/arm/boot/dts/imx6q-sabrelite.dts > +++ b/arch/arm/boot/dts/imx6q-sabrelite.dts > @@ -52,3

Re: [PATCH v3 16/24] media: Add i.MX media core driver

On Fri, Jan 06, 2017 at 06:11:34PM -0800, Steve Longerbeam wrote: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam Applying: media: Add i.MX media core driver .git/rebase-apply/patch:516: new blank line at EOF. +

Re: Need a second set of eyeballs for a possible startup race condition in vc04_services/vchiq.

It's hard to review this because there are no callers and the hash you're talking about is an RPI hash... You have no idea how lazy I am. You're right, that code looks racy but it's almost certainly harmless depending on how it's called. It has to race at the very very beginning otherwise it's

Re: [PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from checkpatch.

Joe Perches writes: > On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote: >> Generated with checkpatch.pl --fix-inplace and git add -p out of the >> results. > > Maybe another. > >> diff --git a/drivers/staging/media/platform/bcm2835/mmal-vchiq.c >>

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

On Fri, Jan 06, 2017 at 06:11:39PM -0800, Steve Longerbeam wrote: > +++ b/drivers/staging/media/imx/imx-mipi-csi2.c ... > +#define DEVICE_NAME "imx6-mipi-csi2" Why is the device/driver named imx6-mipi-csi2, but the module named imx-mipi-csi2 - could there be some consistency here please? Thanks.

Re: [PATCH 13/60] staging: lustre: obdclass: health_check to report unhealthy upon LBUG

> Wat? > > I'm sorry but this patch makes no sense at all. > > On Sat, Jan 28, 2017 at 07:04:41PM -0500, James Simmons wrote: > > From: Bruno Faccini > > > > When a LBUG has occurred, without panic_on_lbug being set, > > health_check sysfs file must return an

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

On Fri, Jan 06, 2017 at 06:11:39PM -0800, Steve Longerbeam wrote: > +static void imxcsi2_enable(struct imxcsi2_dev *csi2, bool enable) > +{ > + if (enable) { > + imxcsi2_write(csi2, 0x, CSI2_PHY_SHUTDOWNZ); > + imxcsi2_write(csi2, 0x, CSI2_DPHY_RSTZ); >

Re: [PATCH v3 00/24] i.MX Media Driver

On Tue, Jan 31, 2017 at 12:45:11AM +, Russell King - ARM Linux wrote: > Trying this driver with an imx219 camera (which works with Philipp's > driver) results in not much happening... no /dev/media* node for it, > no subdevs, no nothing. No clues as to what's missing either. Only > messages

Re: [PATCH 60/60] staging: lustre: libcfs: fix minimum size check for libcfs ioctl

> On Mon, Jan 30, 2017 at 01:51:56PM +0300, Dan Carpenter wrote: > > The lstcon_ioctl_entry() function doesn't have enough size checking. > > Actually, the lstcon_ioctl_entry() would have been fine before we apply > this [patch 60/60]... As near as I can tell, no in kernel code is > negatively

Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver

On Fri, Jan 06, 2017 at 06:11:40PM -0800, Steve Longerbeam wrote: > +config IMX_OV5640_MIPI > + tristate "OmniVision OV5640 MIPI CSI-2 camera support" > + depends on GPIOLIB && VIDEO_IMX_CAMERA > + select IMX_MIPI_CSI2 > + default y Why is this defaulting to y? New

Re: [PATCH v3 00/24] i.MX Media Driver

On Fri, Jan 06, 2017 at 06:11:18PM -0800, Steve Longerbeam wrote: > Philipp Zabel (3): > ARM: dts: imx6qdl: Add mipi_ipu1/2 multiplexers, mipi_csi, and their > connections > add mux and video interface bridge entity functions > platform: add video-multiplexer subdevice driver > > Steve

Re: [PATCH v3 00/24] i.MX Media Driver

On 01/30/2017 04:45 PM, Russell King - ARM Linux wrote: Hi, Trying this driver with an imx219 camera (which works with Philipp's driver) results in not much happening... no /dev/media* node for it, no subdevs, no nothing. No clues as to what's missing either. Only messages from imx-media

Re: [PATCH v3 00/24] i.MX Media Driver

On 01/30/2017 05:06 PM, Russell King - ARM Linux wrote: On Tue, Jan 31, 2017 at 12:45:11AM +, Russell King - ARM Linux wrote: Trying this driver with an imx219 camera (which works with Philipp's driver) results in not much happening... no /dev/media* node for it, no subdevs, no nothing.

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

On 01/30/2017 04:31 PM, Russell King - ARM Linux wrote: On Fri, Jan 06, 2017 at 06:11:39PM -0800, Steve Longerbeam wrote: +++ b/drivers/staging/media/imx/imx-mipi-csi2.c ... +#define DEVICE_NAME "imx6-mipi-csi2" Why is the device/driver named imx6-mipi-csi2, but the module named

Re: [PATCH 60/60] staging: lustre: libcfs: fix minimum size check for libcfs ioctl

> It looks like what happened is there were two patches applied out of > sync. Let's add a fixes tag and CC the original author. So the only problem here is the commit message. I will update it then. > Fixes: ed2f549dc0f6 ("staging: lustre: libcfs: test if userland data is to > small") > >

Re: [PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from checkpatch.

On Mon, 2017-01-30 at 12:05 -0800, Eric Anholt wrote: > Joe Perches writes: > > > On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote: > > > Generated with checkpatch.pl --fix-inplace and git add -p out of the > > > results. > > > > Maybe another. > > > > > diff --git

Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver

On 01/30/2017 03:29 PM, Russell King - ARM Linux wrote: On Fri, Jan 06, 2017 at 06:11:40PM -0800, Steve Longerbeam wrote: +config IMX_OV5640_MIPI + tristate "OmniVision OV5640 MIPI CSI-2 camera support" + depends on GPIOLIB && VIDEO_IMX_CAMERA + select IMX_MIPI_CSI2 +

Re: [PATCH 001] staging: wlan-ng: Add tabstop preceding the statement

On Mon, 2017-01-30 at 17:44 +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 30, 2017 at 11:31:42AM -0500, Maksymilian Piechota wrote: > > This patch fixes the checkpatch.pl warning: > > > > WARNING: Statements should start on a tabstop > > > > Signed-off-by: Maksymilian Piechota

RE: [PATCH] [linux-next]staging: unisys: visornic: Fix typo in visornic_main.c

> -Original Message- > From: Masanari Iida [mailto:standby2...@gmail.com] > Sent: Sunday, January 29, 2017 9:33 PM > To: linux-ker...@vger.kernel.org; gre...@linuxfoundation.org; Kershner, > David A ; de...@driverdev.osuosl.org > Cc: Masanari Iida

Re: [PATCH v2] Fixes: 7ad82572348c ("staging:wlan-ng:Fix sparse warning")

On Mon, Jan 30, 2017 at 08:07:25PM -0800, Igor Pylypiv wrote: > Conversion macros le16_to_cpu was removed and that caused new sparse warning > > sparse output: > drivers/staging/wlan-ng/p80211netdev.c:241:44: warning: incorrect type in > argument 2 (different base types) >

[PATCH v2] Fixes: 7ad82572348c ("staging:wlan-ng:Fix sparse warning")

Conversion macros le16_to_cpu was removed and that caused new sparse warning sparse output: drivers/staging/wlan-ng/p80211netdev.c:241:44: warning: incorrect type in argument 2 (different base types) drivers/staging/wlan-ng/p80211netdev.c:241:44:expected unsigned short [unsigned] [usertype]

[PATCH v3] staging: wlan-ng: add missing byte order conversion

Conversion macros le16_to_cpu was removed and that caused new sparse warning sparse output: drivers/staging/wlan-ng/p80211netdev.c:241:44: warning: incorrect type in argument 2 (different base types) drivers/staging/wlan-ng/p80211netdev.c:241:44:expected unsigned short [unsigned] [usertype]