Re: [PATCH 1/4] staging: lustre: constify attribute_group structures.

Hi Arvind, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.13-rc1 next-20170717] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arvind-Yadav/constify-lustre

Re: [PATCHv2] staging: iio: adc: add missing of_node references to iio_dev

Hi, The patch seems to be reverted? Also should this part in the IIO core take care of automatically setting the of_node of the IIO device? As far as I can see we don't have to initialize it manually. /* If the calling driver did not initialize of_node, do it here */ if

Re: [PATCH 1/1] drivers/staging/pi433: New driver

Hi Marcus, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.13-rc1 next-20170717] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Wolf-Entwicklungen/drivers

[PATCH v2] staging: iio: adc: add missing of_node references to iio_dev

Adding missing indio_dev->dev.of_node references to allow iio consumers to access the device channels. Signed-off-by: Hari Prasath --- v2: Wrong from email ID in first version of patch --- drivers/staging/iio/adc/ad7192.c | 1 + drivers/staging/iio/adc/ad7780.c

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

On Fri, Jul 14, 2017 at 07:38:43PM +0530, Gaurav Pathak wrote: > staging: rts5208: Refactored code to avoid few defects. That's the subject line, why repeat it here? Please put a "real" description of the patch here. > > Signed-off-by: Gaurav Pathak > --- > Hi,

Re: [PATCH] staging: unisys: visorbus: constify attribute_group structures.

On Mon, Jul 17, 2017 at 05:43:14PM +0530, Arvind Yadav wrote: > Hi Greg, > > > On Monday 17 July 2017 04:15 PM, Greg KH wrote: > > On Mon, Jul 17, 2017 at 02:55:37PM +0530, Arvind Yadav wrote: > > > attribute_groups are not supposed to change at runtime. All functions > > > working with

[PATCH] staging: iio: adc: add missing of_node references to iio_dev

From: Hari Prasath Adding missing indio_dev->dev.of_node references to allow iio consumers to access the device channels. Signed-off-by: Hari Prasath --- drivers/staging/iio/adc/ad7192.c | 1 + drivers/staging/iio/adc/ad7780.c | 1 + 2 files

Re: [PATCH] staging: unisys: visorbus: constify attribute_group structures.

Hi Greg, On Monday 17 July 2017 04:15 PM, Greg KH wrote: On Mon, Jul 17, 2017 at 02:55:37PM +0530, Arvind Yadav wrote: attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const

Re: [PATCH] Staging:vc04_services:vchiq_util.c: kzalloc call changed to kcalloc

On Sun, Jul 16, 2017 at 07:39:08PM +0300, AndyS wrote: > From: Andrey Severin > > kzalloc call was changed to kcalloc by checkpatch.pl recommendation > > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v2] staging: iio: adc: add missing of_node references to iio_dev

Kindly discard this patch versions. I will send a new one. On 17 July 2017 at 17:49, Hari Prasath wrote: > Adding missing indio_dev->dev.of_node references to allow iio consumers > to access the device channels. > > Signed-off-by: Hari Prasath >

Re: [PATCH] binder: Drop needless locking in binder_mmap()

On Mon, Jun 19, 2017 at 05:53:34PM +0300, Dmitry Safonov wrote: > On 05/24/2017 05:51 PM, Dmitry Safonov wrote: > > binder_mmap() protected proc->buffer from concurrent changes. > > It was introduced with commit bd1eff9741af ("Staging: android: binder: > > Fix crashes when sharing a binder file

[PATCH 4/7] staging: fsl-mc: fix compilation with non-generic msi domain ops

From: Laurentiu Tudor The bus driver relies on generic msi domain ops. Fix compilation for architectures that don't provide it (e.g. x86_64). Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 4

[PATCH 7/7] staging: fsl-mc: allow the driver compile multi-arch

From: Laurentiu Tudor Drop dependency on ARCH_LAYERSCAPE (which in turn depends on ARM64), thus leaving this driver compile on other architectures. Also, other drivers depending on the bus are updated to depend on ARCH_LAYERSCAPE until they'll also be made multi-arch.

Re: [PATCH] staging: gs_fpgaboot: add buffer overflow checks

On Sun, Jul 16, 2017 at 08:38:41PM -0400, Jacob von Chorus wrote: > Four fields in struct fpgaimage are char arrays of length MAX_STR (256). > The amount of data read into these buffers is controlled by a length > field in the bitstream file read from userspace. If a corrupt or > malicious

[PATCHv2] staging: iio: adc: add missing of_node references to iio_dev

Adding missing indio_dev->dev.of_node references to allow iio consumers to access the device channels. Signed-off-by: Hari Prasath --- v2: Wrong from mail ID in first version of patch --- drivers/staging/iio/adc/ad7192.c | 1 - drivers/staging/iio/adc/ad7780.c |

[PATCH 0/7] staging: fsl-mc: make the driver compile on other architectures

From: Laurentiu Tudor Apart from a small change (first patch) which adds a missing comment, this series make the bus driver compile on other architectures, as per GregKH comment [1]. Compiled tested on: - booke powerpc (corenet{32,64}_smp_defconfig) with this ppc patch

[PATCH 2/7] staging: fsl-mc: use generic memory barriers

From: Laurentiu Tudor No need to use arch-specific memory barriers; switch to using generic ones. The rmb()s were useless so drop them. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/mc-sys.c | 6 ++ 1 file changed, 2

[PATCH 5/7] staging: fsl-mc: fix formating of phys_addr_t on 32 bits

From: Laurentiu Tudor Use correct format specifier for phys_addr_t variables (%pa) instead of %llx. This fixes these warnings on 32 bit targets: "format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]"

[PATCH 6/7] staging: fsl-mc: rewrite mc command send/receive to work on 32-bits

From: Laurentiu Tudor Split the 64-bit accesses in 32-bit accesses because there's no real constrain in MC to do only atomic 64-bit. There's only one place where ordering is important: when writing the MC command header the first 32-bit part of the header must be written

[PATCH 3/7] staging: fsl-mc: drop useless gic v3 related #include

From: Laurentiu Tudor Nothing from linux/irqchip/arm-gic-v3.h is used, so the #include can be safely dropped. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 1 -

[PATCH 1/7] staging: fsl-mc: add missing fsl_mc comment in struct msi_desc

From: Laurentiu Tudor The mc-bus specific field, fsl_mc in struct msi_desc is missing its comment so add it. Signed-off-by: Laurentiu Tudor --- include/linux/msi.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/msi.h

Re: [PATCH] staging: lustre: lustre: fix all braces issues reported by checkpatch

On Sat, Jul 15, 2017 at 11:39:22AM -0400, James Simmons wrote: > Cleanup all braces that was reported by checkpatch. The only > issue not fixed up is in mdc_lock.c. Removing the braces in > the case of mdc_lock.c will break the build. > > Signed-off-by: James Simmons >

Re: [PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

On Sat, Jul 15, 2017 at 01:21:54PM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > It is recommended to use managed function devm_kzalloc, which > simplifies driver cleanup paths and driver code. > This patch does the following: > (a) replace kzalloc with

Re: [PATCH 00/37] fine-grained locking in binder driver

On Fri, Jun 30, 2017 at 08:04:21AM +0200, Greg KH wrote: > On Thu, Jun 29, 2017 at 12:01:34PM -0700, Todd Kjos wrote: > > The binder driver uses a global mutex to serialize access to state in a > > multi-threaded environment. This global lock has been increasingly > > problematic as Android

Re: [patch 0/3] Re: tty contention resulting from tty_open_by_device export

On Thu, Jul 13, 2017 at 12:29:54PM +0100, Okash Khawaja wrote: > On Wed, Jul 12, 2017 at 07:20:28PM +0100, Alan Cox wrote: > > > > > When opening from kernel, we don't use file pointer. The count mismatch > > > is between tty->count and #fd's. So opening from kernel leads to #fd's > > > being

Re: [PATCH 1/2] Tools: hv: vss: Skip freezing filesystems backed by loop

On Sun, Jun 25, 2017 at 12:47:45PM -0700, k...@exchange.microsoft.com wrote: > From: Alex Ng > > Skip loop devices from the freeze/thaw operation. Ok, but why? What is the consequences of this? Please provide a much better changelog comment, especially for

[PATCH] Staging:vc04_services:vchiq_util.c: kzalloc call changed to kcalloc

From: Andrey Severin kzalloc call was changed to kcalloc by checkpatch.pl recommendation Signed-off-by: Andrey Severin --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [patch 0/3] Re: tty contention resulting from tty_open_by_device export

> On 17 Jul 2017, at 13:31, Greg Kroah-Hartman > wrote: > >> On Thu, Jul 13, 2017 at 12:29:54PM +0100, Okash Khawaja wrote: >>> On Wed, Jul 12, 2017 at 07:20:28PM +0100, Alan Cox wrote: >>> When opening from kernel, we don't use file pointer. The count

Re: [PATCH 3/4] staging: lustre: obdclass: linux: constify attribute_group structures.

Sorry for noise. Please ignore this. ~arvind On Monday 17 July 2017 11:18 AM, Arvind Yadav wrote: attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const.

Re: [PATCH 2/4] staging: lustre: ldlm: constify attribute_group structures.

Sorry for noise. Please ignore this. ~arvind On Monday 17 July 2017 11:18 AM, Arvind Yadav wrote: attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const.

Re: [PATCH 3/4] staging: lustre: obdclass: linux: constify attribute_group structures.

Sorry for noise. Please ignore this. ~arvind On Monday 17 July 2017 11:18 AM, Arvind Yadav wrote: attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const.

Re: [PATCH] staging: unisys: visorbus: constify attribute_group structures.

On Mon, Jul 17, 2017 at 02:55:37PM +0530, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work > with const attribute_group. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav

Re: [PATCH 0/4] constify lustre attribute_group structures

Sorry for noise. Please ignore this. It's having build error. Again, I will push all changes. ~arvind On Monday 17 July 2017 11:18 AM, Arvind Yadav wrote: attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const

[PATCH] staging: unisys: visorbus: constify attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/staging/unisys/visorbus/visorbus_main.c |

Re: [PATCH 1/4] staging: lustre: constify attribute_group structures.

Sorry for noise. Please ignore this. I will fix this error and push again. ~arvind On Monday 17 July 2017 12:45 PM, kbuild test robot wrote: Hi Arvind, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.13-rc1 next-20170717] [if your patch is applied to the wrong

Re: [PATCH 4/4] staging: lustre: obdclass: constify attribute_group structures.

Sorry for noise. Please ignore this. This change should not be separate. ~arvind On Monday 17 July 2017 11:19 AM, Arvind Yadav wrote: attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the

[PATCH] atomisp: array underflow in ioctl

I noticed an array underflow in ov5693_enum_frame_size(). The code looks like this: int index = fse->index; if (index >= N_RES) retur -EINVAL; fse->index is a u32 that comes from the user. We want negative values to be counted as -EINVAL but they aren't. There

Re: [PATCHv2] staging: iio: adc: add missing of_node references to iio_dev

Hi, I agree that it's initialized in the core IIO driver. Also I have screwed up the patch. Regards, Hari On 17 July 2017 at 18:47, Lars-Peter Clausen wrote: > Hi, > > The patch seems to be reverted? > > Also should this part in the IIO core take care of automatically setting

Re: [PATCH 14/14] [media] fix warning on v4l2_subdev_call() result interpreted as bool

On 14/07/17 11:36, Arnd Bergmann wrote: > v4l2_subdev_call is a macro returning whatever the callback return > type is, usually 'int'. With gcc-7 and ccache, this can lead to > many wanings like: > > media/platform/pxa_camera.c: In function 'pxa_mbus_build_fmts_xlate': >

Re: [PATCH 6/7] staging: fsl-mc: rewrite mc command send/receive to work on 32-bits

On Mon, Jul 17, 2017 at 3:26 PM, wrote: > From: Laurentiu Tudor > > Split the 64-bit accesses in 32-bit accesses because there's no real > constrain in MC to do only atomic 64-bit. There's only one place > where ordering is important: when

Re: [PATCH 6/7] staging: fsl-mc: rewrite mc command send/receive to work on 32-bits

On Mon, Jul 17, 2017 at 4:27 PM, Laurentiu Tudor wrote: > Hi Arnd, > > On 07/17/2017 04:45 PM, Arnd Bergmann wrote: >> On Mon, Jul 17, 2017 at 3:26 PM, wrote: >>> From: Laurentiu Tudor >>> >>> Split the 64-bit accesses

Re: [PATCH 6/7] staging: fsl-mc: rewrite mc command send/receive to work on 32-bits

Hi Robin, On 07/17/2017 04:43 PM, Robin Murphy wrote: > On 17/07/17 14:26, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor >> >> Split the 64-bit accesses in 32-bit accesses because there's no real >> constrain in MC to do only atomic 64-bit. There's only one

Re: [PATCH 6/7] staging: fsl-mc: rewrite mc command send/receive to work on 32-bits

On 17/07/17 14:26, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > Split the 64-bit accesses in 32-bit accesses because there's no real > constrain in MC to do only atomic 64-bit. There's only one place > where ordering is important: when writing the MC

[PATCH] drivers: staging: ccree: use __func__ to get function name in error messages.

fixes checkpatch warning. Signed-off-by: Dhananjay Balan --- drivers/staging/ccree/ssi_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_driver.c b/drivers/staging/ccree/ssi_driver.c index d7b9a636d907..e0faca0a30a6 100644

[PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

staging: rts5208: Fix coding style issue caught by checkpatch.pl related to function name in debug print and shorten few lines over 80 char Signed-off-by: Gaurav Pathak --- drivers/staging/rts5208/ms.c| 5 +++-- drivers/staging/rts5208/rtsx.c | 4 ++--

Re: [PATCH 14/14] [media] fix warning on v4l2_subdev_call() result interpreted as bool

On 17/07/17 16:26, Arnd Bergmann wrote: > On Mon, Jul 17, 2017 at 3:45 PM, Hans Verkuil wrote: >> On 14/07/17 11:36, Arnd Bergmann wrote: >>> @@ -201,8 +202,9 @@ static int cx18_g_fmt_sliced_vbi_cap(struct file *file, >>> void *fh, >>>* digitizer/slicer. Note,

Re: [PATCH 03/10] x86/hyper-v: make hv_do_hypercall() inline

On Sun, Jun 25, 2017 at 10:06:42AM -0700, k...@exchange.microsoft.com wrote: > From: Vitaly Kuznetsov > > We have only three call sites for hv_do_hypercall() and we're going to > change HVCALL_SIGNAL_EVENT to doing fast hypercall so we can inline this > function for

[BUG] drivers: staging: comedi: do not call blocking ops when !TASK_RUNNING; state=1

Calling blocking operations from wrong context. Kernel: Linux piotrpc 4.4.70-rt83 #1 SMP PREEMPT RT Thu Jul 13 08:42:02 BST 2017 x86_64 GNU/Linux [ 80.542018] NOHZ: local_softirq_pending 80 [ 125.175471] [ cut here ] [ 125.175491] WARNING: CPU: 0 PID: 1497 at

Re: [PATCH 14/14] [media] fix warning on v4l2_subdev_call() result interpreted as bool

On Mon, Jul 17, 2017 at 3:45 PM, Hans Verkuil wrote: > On 14/07/17 11:36, Arnd Bergmann wrote: >> @@ -201,8 +202,9 @@ static int cx18_g_fmt_sliced_vbi_cap(struct file *file, >> void *fh, >>* digitizer/slicer. Note, cx18_av_vbi() wipes the passed in >>*

Re: [PATCH 14/14] [media] fix warning on v4l2_subdev_call() result interpreted as bool

On 17/07/17 16:26, Arnd Bergmann wrote: > On Mon, Jul 17, 2017 at 3:45 PM, Hans Verkuil wrote: >> On 14/07/17 11:36, Arnd Bergmann wrote: >>> @@ -201,8 +202,9 @@ static int cx18_g_fmt_sliced_vbi_cap(struct file *file, >>> void *fh, >>>* digitizer/slicer. Note,

Re: [PATCH 2/7] staging: fsl-mc: use generic memory barriers

On 17/07/17 14:26, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > No need to use arch-specific memory barriers; switch to using generic > ones. The rmb()s were useless so drop them. > > Signed-off-by: Laurentiu Tudor > --- >

Re: [PATCH 2/7] staging: fsl-mc: use generic memory barriers

On 07/17/2017 04:38 PM, Robin Murphy wrote: > On 17/07/17 14:26, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor >> >> No need to use arch-specific memory barriers; switch to using generic >> ones. The rmb()s were useless so drop them. >> >> Signed-off-by:

Re: [PATCH 14/14] [media] fix warning on v4l2_subdev_call() result interpreted as bool

On Mon, Jul 17, 2017 at 04:26:23PM +0200, Arnd Bergmann wrote: > On Mon, Jul 17, 2017 at 3:45 PM, Hans Verkuil wrote: > > On 14/07/17 11:36, Arnd Bergmann wrote: > >> @@ -201,8 +202,9 @@ static int cx18_g_fmt_sliced_vbi_cap(struct file > >> *file, void *fh, > >>*

Re: [PATCH 6/7] staging: fsl-mc: rewrite mc command send/receive to work on 32-bits

Hi Arnd, On 07/17/2017 04:45 PM, Arnd Bergmann wrote: > On Mon, Jul 17, 2017 at 3:26 PM, wrote: >> From: Laurentiu Tudor >> >> Split the 64-bit accesses in 32-bit accesses because there's no real >> constrain in MC to do only atomic 64-bit.

[PATCH 1/1] staging: rtl8188eu: add TL-WN722N v2 support

Add support for USB Device TP-Link TL-WN722N v2. VendorID: 0x2357, ProductID: 0x010c Signed-off-by: Michael Gugino --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c

[PATCH v3 0/1] Staging: android/ion: fix sparse warnings

Improve commit message. Previous version included a patch to add declarations to ion.h, but I have dropped that as the same declarations were recently removed. Joseph Wright (1): Staging: android/ion: declare function static drivers/staging/android/ion/ion_cma_heap.c | 2 +- 1 file changed,

[PATCH v3 1/1] Staging: android/ion: declare function static

Declare private function static to fix sparse warning: ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \ was not declared. Should it be static? Signed-off-by: Joseph Wright --- Changes in v3: - Make subject clearer

Re: [BUG] drivers: staging: comedi: do not call blocking ops when !TASK_RUNNING; state=1

On 17/07/17 15:48, Piotr Gregor wrote: Calling blocking operations from wrong context. Kernel: Linux piotrpc 4.4.70-rt83 #1 SMP PREEMPT RT Thu Jul 13 08:42:02 BST 2017 x86_64 GNU/Linux [ 80.542018] NOHZ: local_softirq_pending 80 [ 125.175471] [ cut here ] [

[PATCH 1/1] rtl8188eu: add TL-WN722N v2 support

Add support for USB Device TP-Link TL-WN722N v2. VendorID: 0x2357, ProductID: 0x010c Signed-off-by: Michael Gugino --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c

Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue

On Mon, Jul 17, 2017 at 05:50:27PM +, Craig Inches wrote: > On Mon, Jul 17, 2017 at 05:44:59PM +, Dilger, Andreas wrote: > > On Jul 12, 2017, at 03:03, Craig Inches wrote: > > > > > > This fixes a block statement which didnt end with */ > > > > > > Signed-off-by:

Re: [BUG] drivers: staging: comedi: do not call blocking ops when !TASK_RUNNING; state=1

Hi Ian, I am afraid I have more problems with running Comedi on rt-patched kernel than only that. I am still trying to figure out the specific reason - hopefully it is my fault and I scrued up my own code, but so far it seems pcie215 support doesn't work at least in the same way on rt-patched

Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue

On Mon, Jul 17, 2017 at 05:44:59PM +, Dilger, Andreas wrote: > On Jul 12, 2017, at 03:03, Craig Inches wrote: > > > > This fixes a block statement which didnt end with */ > > > > Signed-off-by: Craig Inches > > --- > >

Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue

On Jul 12, 2017, at 03:03, Craig Inches wrote: > > This fixes a block statement which didnt end with */ > > Signed-off-by: Craig Inches > --- > drivers/staging/lustre/include/linux/lnet/socklnd.h | 3 ++- > 1 file changed, 2 insertions(+), 1

[PATCH] staging: gs_fpgaboot: add buffer overflow checks

Four fields in struct fpgaimage are char arrays of length MAX_STR (256). The amount of data read into these buffers is controlled by a length field in the bitstream file read from userspace. If a corrupt or malicious firmware file was supplied, kernel data beyond these buffers can be overwritten

[PATCH] staging: gs_fpgaboot: remove FSF address from GPL notice

This patch removes the FSF address from the GPL notice to fix a checkpatch.cl CHECK message. Signed-off-by: Jacob von Chorus --- drivers/staging/gs_fpgaboot/io.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/gs_fpgaboot/io.c

RE: [PATCH 1/2] Tools: hv: vss: Skip freezing filesystems backed by loop

My apologies. The changelog comment should be more descriptive. Since a loop device is backed by a file, a backup will already result in its parent filesystem being frozen. It's sufficient to just freeze the parent filesystem, so we can skip the loop device. This avoids a situation where a loop

Re: [PATCH] staging: gs_fpgaboot: add buffer overflow checks

On Sun, Jul 16, 2017 at 08:38:41PM -0400, Jacob von Chorus wrote: > diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c > b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c > index 19b550fff0..2aafd769b8 100644 > --- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c > +++

[PATCH 02/42] staging: unisys: visorbus: visorchipset.c: Adjust code layout

From: David Binder Adjusts the ordering of function statements, as well as modifies whitespace usage, in order to create a more uniform coding style. Signed-off-by: David Binder Signed-off-by: David Kershner

[PATCH 06/42] staging: unisys: visornic: visornic_main.c: Adjust whitespace usage

From: David Binder Adjusts whitespace usage in order to create a more uniform coding style. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: David Binder ---

[PATCH 05/42] staging: unisys: visorinput: visorinput.c: Adjust whitespace usage

From: David Binder Adjusts whitespace usage in order to create a more uniform coding style. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: David Binder ---

[PATCH 19/42] staging: unisys: visorbus: add checks for probe, remove, pause and resume in visorbus_register_visor_driver

From: Sameer Wadgaonkar Added checks for functions probe, remove, pause and resume in visorbus_register_visor_driver() and removed these checks from the individual functions itself. Signed-off-by: Sameer Wadgaonkar Signed-off-by:

[PATCH 03/42] staging: unisys: visorbus: visorbus_main.c: Adjust code layout

From: David Binder Adjusts the ordering of function statements, as well as modifies whitespace usage, in order to create a more uniform coding style. Signed-off-by: David Binder Signed-off-by: David Kershner

[PATCH 13/42] staging: unisys: include: iochannel.h: removed VISOR_VNIC_CHANNEL_SIGNATURE

From: Alex Curtin VISOR_VNIC_CHANNEL_SIGNATURE is a redundant definition that points to VISOR_CHANNEL_SIGNATURE. This replaces that definition with VISOR_CHANNEL_SIGNATURE. Signed-off-by: Alex Curtin Signed-off-by: David Kershner

[PATCH 25/42] staging: unisys: include: iochannel.h: Removed unused DEFINE

From: Zohaib Removed unused #define GPI_ENTRIES_PER_PAGE Signed-off-by: Zohaib Signed-off-by: David Kershner Reviewed-by: David Binder --- drivers/staging/unisys/include/iochannel.h | 2 -- 1

[PATCH 20/42] staging: unisys: remove unused define VISOR_VSWITCH_CHANNEL_VERSIONID

From: Sameer Wadgaonkar The VSWITCH channel is not used in Linux guests, so remove the VERSIONID. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: David Binder

[PATCH 24/42] staging: unisys: visorbus: Beginning of the file /* on its own line

From: Zohaib Leading comment changed to follow surrounding convention. Signed-off-by: Zohaib Signed-off-by: David Kershner Reviewed-by: David Binder ---

[PATCH 04/42] staging: unisys: visorhba: visorhba_main.c: Adjust whitespace usage

From: David Binder Removes unnecessary blank lines to create a more uniform coding style. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: David Binder ---

[PATCH 07/42] staging: unisys: visorbus: controlvmchannel.h: fix spacing

From: Erik Arfvidson This patch fixes space and tab aligned comments in controlvmchannel.h. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reviewed-by: David Binder ---

[PATCH 08/42] staging: unisys: visorhba: viosrhba_main.c: Remove unnecessary checks

From: David Binder Removes unnecessary checks for a NULL pointer in a non-API function. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: David Binder ---

[PATCH 01/42] staging: unisys: visorbus: visorbus_main.c: use __func__ over hardcoded name

From: Zachary Dremann As reported by checkpatch.pl, replace hard-coded usage of the current function's name in format string with usage of __func__. Signed-off-by: Zachary Dremann Signed-off-by: David Kershner Reviewed-by: David

[PATCH 23/42] staging: unisys: visorbus: Fix memory leak

From: Zachary Dremann The name of a visor_device was never freed, which was allocated in visorbus_configure. It is expected that visorbus_device_destroy will not be called on the same visor_device again, or this would be a double free. Signed-off-by: Zachary Dremann

[PATCH 22/42] staging: unisys: moved visor_check_channel from include/channel.h to visorbus/visorbus_main.c

From: Sameer Wadgaonkar Moved the function visor_check_channel() from include/channel.h to visorbus/visorbus_main.c. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: David Binder

[PATCH 29/42] staging: unisys: visorchipset: remove local_addr in handle_command

From: Erik Arfvidson In the function handle_command, the variable local_addr is always false. So this patch is getting rid of logic when it is true. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner

[PATCH 10/42] staging: unisys: visorbus: controlvmchannel.h: removed VISOR_CONTROLVM_CHANNEL_SIGNATURE

From: Alex Curtin VISOR_CONTROLVM_CHANNEL_SIGNATURE points to VISOR_CHANNEL_SIGNATURE, so this replaces the redundant definition with VISOR_CHANNEL_SIGNATURE. Signed-off-by: Alex Curtin Signed-off-by: David Kershner

[PATCH 15/42] staging: unisys: visorbus: convert VMCALL_CONTROLVM_ADDR enum to #define

From: Sameer Wadgaonkar VMCALL_CONTROLVM_ADDR is the only element left in enum vmcall_monitor_interface_method_tuple. Converting it to a #define. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner

[PATCH 09/42] staging: unisys: include: channel.h: remove unused pound defines

From: Erik Arfvidson This patch removes all the unused pound defines currently in channel.h. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reviewed-by: David Binder ---

[PATCH 12/42] staging: unisys: include: iochannel.h: removed VISOR_VHBA_CHANNEL_SIGNATURE

From: Alex Curtin VISOR_VHBA_CHANNEL_SIGNATURE is a redundant definition that points to VISOR_CHANNEL_SIGNATURE. This replaces that definition with VISOR_CHANNEL_SIGNATURE. Signed-off-by: Alex Curtin Signed-off-by: David Kershner

[PATCH 30/42] staging: unisys: visorbus: Update comment style vbuschannel.h

From: Mark Foresta Moved /* to own line at beginning of struct visor_vbus_deviceinfo to follow standard. Signed-off-by: Mark Foresta Signed-off-by: David Kershner Reviewed-by: David Binder

[PATCH 28/42] staging: unisys: visorbus: remove target_hostname comment

From: Erik Arfvidson This patch simply removes TARGET_HOSTNAME comment that is no longer relevant. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reviewed-by: David Binder ---

[PATCH 26/42] staging: unisys: visorbus: Adding a new line between function definition

From: Zohaib Added a new line before issue_vmcall_io_controlvm_addr() function definition. Signed-off-by: Zohaib Signed-off-by: David Kershner Reviewed-by: David Binder ---

[PATCH 36/42] staging: unisys: include: Remove COVER macro from channel.h

From: Charles Daniels Replaced the one and only call to COVER in iochannel.h. Signed-off-by: Charles Daniels Signed-off-by: David Kershner Reviewed-by: David Binder ---

[PATCH 11/42] staging: unisys: visorbus: vbuschannel.h: removed VISOR_VBUS_CHANNEL_SIGNATURE

From: Alex Curtin VISOR_VBUS_CHANNEL_SIGNATURE just pointed to VISOR_CHANNEL_SIGNATURE, so this replaces the redundant definition with VISOR_CHANNEL_SIGNATURE. Signed-off-by: Alex Curtin Signed-off-by: David Kershner

[PATCH 17/42] staging: unisys: visorbus: visorbus_main.c: put function name and return value on same line.

From: Sameer Wadgaonkar This patch makes function definitions more consistent by having function name and return values on the same line. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner

[PATCH 21/42] staging: unisys: include: Remove unused CHANNEL_OK defines.

From: Sameer Wadgaonkar The VISOR_VNIC_CHANNEL_OK_CLIENT and VISOR_HBA_CHANNEL_OK_CLIENT macros were not being used. They can be removed. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner

[PATCH 31/42] staging: unisys: visorbus: fixed comment in visorbus_private.h

From: Mark Foresta Placed /* on line 1 alone rather than start comment. Signed-off-by: Mark Foresta Signed-off-by: David Kershner Reviewed-by: David Binder ---

[PATCH 18/42] staging: unisys: visorbus: visorbus_main.c: remove check from typename_show

From: Sameer Wadgaonkar Remove check for xbus in typename_show() function in visorbus_main.c. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: David Binder

[PATCH 35/42] staging: unisys: visorbus: Remove unused define for visorchipset.

The define CURRENT_FILE_PC was not being used, so just remove it. Signed-off-by: David Kershner Reviewed-by: David Binder --- drivers/staging/unisys/visorbus/visorchipset.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 14/42] staging: unisys: include: iochannel.h: removed VISOR_VSWITCH_CHANNEL_SIGNATURE

From: Alex Curtin VISOR_VSWITCH_CHANNEL_SIGNATURE is a redundant definition that points to VISOR_CHANNEL_SIGNATURE. It wasn't being used, so it has been removed. Signed-off-by: Alex Curtin Signed-off-by: David Kershner

[PATCH] Stagung: rtl8188eu: core: fixd comment coding style issue in rtw_xmit.c

From: Armin Schoenlieb This is a patch to the rtw_xmit.c file that fixes up a comment/80 character warning found by the checkpatch.pl tool Signed-off-by: Armin Schoenlieb --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 6 -- 1 file changed, 4

[PATCH 00/42] staging: unisys: More updates to the code

This series fixes some more style issues with the code found during our internal review. Alex Curtin (5): staging: unisys: visorbus: controlvmchannel.h: removed VISOR_CONTROLVM_CHANNEL_SIGNATURE staging: unisys: visorbus: vbuschannel.h: removed VISOR_VBUS_CHANNEL_SIGNATURE staging: unisys:

  1   2   >