Reviewed-by: Ajay Singh
On Mon, 12 Mar 2018 15:09:03 +0530
wrote:
> From: HariPrasath Elango
>
Please avoid use of 'From' tag specially when there is only one
'Signed-off-by' tag and its same.
> Use the kernel pre-defined macro is_broadcast_ether_addr() instead of
> doing a memcmp here.
>
On Mon, 12 Mar 2018 18:30:44 +0530
wrote:
> From: HariPrasath Elango
>
> Fix the code alignment for a block of code to adhere to coding
> guidelines
>
> Signed-off-by: HariPrasath Elango
Reviewed-by: Ajay Singh
Regards,
Ajay
___
devel mailing lis
On Mon, 12 Mar 2018 18:49:49 +0530
wrote:
> From: HariPrasath Elango
>
> Destroy the mutex object that is initialized in wlan_init_locks()
>
> Signed-off-by: HariPrasath Elango
Reviewed-by: Ajay Singh
Regards,
Ajay
___
devel mailing list
de...@l
On Tue, 13 Mar 2018 11:50:48 +0530
wrote:
> From: HariPrasath Elango
>
> Kmalloc followed by memcpy can be replaced by kmemdup.
>
> Signed-off-by: HariPrasath Elango
Reviewed-by: Ajay Singh
Regards,
Ajay
___
devel mailing list
de...@linuxdriverp
On Mon, Mar 12, 2018 at 03:21:52PM -0300, Rodrigo Siqueira wrote:
> The write interface of AD2S1210 utilizes IIO_DEVICE_ATTR, which violate
> the official IIO ABI. This patch, add the write_raw function responsible
> for handling the fclkin and fexcit channel; also it removes the use of
> IIO_DEVIC
From: HariPrasath Elango
A mutex object that is initialized but not destroyed.This patch destroys
the mutex object
Signed-off-by: HariPrasath Elango
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgop
On Tue, Mar 13, 2018 at 01:00:51PM +0530, Ajay Singh wrote:
>
> Reviewed-by: Ajay Singh
>
> On Mon, 12 Mar 2018 15:09:03 +0530
> wrote:
>
> > From: HariPrasath Elango
> >
>
> Please avoid use of 'From' tag specially when there is only one
> 'Signed-off-by' tag and its same.
But the email cl
From: HariPrasath Elango
In this case,there is only a single switch case statement.So replacing
by a simple if condition.
Signed-off-by: HariPrasath Elango
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/s
It takes a long time to review this, not because it's hard but because
I have to look at each line and think "Is this really a worthwhile line
to keep?" and a lot of them are marginal but perhaps not necessarily
bad?
You've deleted some obviously rubbish printks but I feel you could have
gone much
Good Day,
Are you in any financial difficulty? Do you need loan to help you pay off bills
and debts? Do you want to start a new business or enhance your business?
Contact us today for a financial solutions
email:koh.chong...@yahoo.com
Qualifications:
1)The Borrower must be at least 18yrs old
2)
On 12/03/18 23:36, Colin King wrote:
From: Colin Ian King
Variable 'val' is initialized with a value that is never read, it is
updated with a new value again after intitialization. Remove the
redundant initialization and move the declaration and assignment into
the scope of the for-loop.
Clean
From: HariPrasath Elango
Remove the unwated brace and corrected the code block alignment
accordingly
Signed-off-by: HariPrasath Elango
---
drivers/staging/wilc1000/host_interface.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/w
On Tue, Mar 13, 2018 at 11:04 AM, Dan Carpenter
wrote:
> It takes a long time to review this, not because it's hard but because
> I have to look at each line and think "Is this really a worthwhile line
> to keep?" and a lot of them are marginal but perhaps not necessarily
> bad?
I see. I though i
On Tue, 13 Mar 2018 10:58:16 +0100
Greg Kroah-Hartman wrote:
> On Tue, Mar 13, 2018 at 01:00:51PM +0530, Ajay Singh wrote:
> >
> > Reviewed-by: Ajay Singh
> >
> > On Mon, 12 Mar 2018 15:09:03 +0530
> > wrote:
> >
> > > From: HariPrasath Elango
> > >
> >
> > Please avoid use of 'From' t
On Tue, Mar 13, 2018 at 11:57:35AM +0100, Sergio Paracuellos wrote:
> On Tue, Mar 13, 2018 at 11:04 AM, Dan Carpenter
> wrote:
> > It takes a long time to review this, not because it's hard but because
> > I have to look at each line and think "Is this really a worthwhile line
> > to keep?" and a
From: HariPrasath Elango
kmalloc followed by memcpy can be replaced by kmemdup.Also added the
related error handling part
Signed-off-by: HariPrasath Elango
---
drivers/staging/wilc1000/host_interface.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/stagi
We now allow lustre to be built when CONFIG_MODULES is disabled,
but that causes a build failure:
In file included from drivers/staging/lustre/include/linux/libcfs/libcfs.h:42,
from drivers/staging/lustre/lustre/obdclass/lu_object.c:44:
drivers/staging/lustre/lustre/obdclass/lu_ob
One of Neil's recent cleanups apparently has led the code to get
to a state where gcc tracks the 'seqnr' variable just enough to
see that it is sometimes initialized in seq_client_alloc_seq(),
but not enough that it can prove this initialization to be reliable
before the use of that variable:
driv
On 03/13, Dan Carpenter wrote:
> On Mon, Mar 12, 2018 at 03:21:52PM -0300, Rodrigo Siqueira wrote:
> > The write interface of AD2S1210 utilizes IIO_DEVICE_ATTR, which violate
> > the official IIO ABI. This patch, add the write_raw function responsible
> > for handling the fclkin and fexcit channel;
The IS_ERR()/PTR_ERR() combination confuses gcc to the point that it
cannot prove the upstream_ep variable to be initialized:
drivers/staging/media/imx/imx-media-csi.c: In function 'csi_link_validate':
drivers/staging/media/imx/imx-media-csi.c:1025:20: error: 'upstream_ep' may be
used uninitializ
Add a TODO file describing what needs to be added/changed before the driver
can be moved out of staging.
Signed-off-by: Razvan Stefanescu
---
Changelog:
v2:
- no changes
v3:
- no changes
v4:
- remove fsl-mc bus driver dependency as it is out of staging
v5:
- no changes
drive
Add driver information, link details and hardware statistics to be
reported via ethtool -S.
Signed-off-by: Razvan Stefanescu
---
Changelog:
v2:
- no changes
v3:
- removed driver version
v4:
- no changes
v5:
- no changes
drivers/staging/fsl-dpaa2/ethsw/Makefile| 2 +
This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs
with DPAA2 (DataPath Acceleration Architecture v2). The driver manages
switch objects discovered on the fsl-mc bus. A description of the driver
can be found in the associated README file.
The patchset consists of:
* A set o
Add a README file describing the driver architecture, components and
interfaces.
Signed-off-by: Razvan Stefanescu
---
Changelog:
v2:
- no changes
v3:
- no changes
v4:
- no changes
v5:
- no changes
drivers/staging/fsl-dpaa2/ethsw/README | 106 +
Introduce the DPAA2 Ethernet Switch driver, which manages Datapath Switch
(DPSW) objects discovered on the MC bus.
Suggested-by: Alexandru Marginean
Signed-off-by: Razvan Stefanescu
---
Changelog:
v2:
- fix PVID cleanup in ethsw_port_add_vlan()
- rename err2 to ret in ethsw_port_add/del
Signed-off-by: Razvan Stefanescu
---
Changelog:
v2:
- no changes
v3:
- no changes
v4:
- no changes
v5:
- no changes
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index c3c2b75..20d7bf2 100644
--- a/MAINTAINERS
+++ b/MAINTA
Add the command build/parse APIs for operating on DPSW objects through
the DPAA2 Management Complex.
Signed-off-by: Razvan Stefanescu
---
Changelog:
v2:
- use u8 for en parameter of dpsw_if_set_flooding/broadcast()
v3:
- no changes
v4:
- adjust to moving MC-bus out of staging
-
On Tue, Mar 13, 2018 at 10:06:29AM -0300, Rodrigo Siqueira wrote:
> On 03/13, Dan Carpenter wrote:
>
> > Ah... I see why you did the ERROR_MESSAGE define, to get around the 80
> > character limit. Don't do that. Just go over 80 characters if you need
> > to.
> >
> >
> > > +
> +/* For the moment, only flood setting needs to be updated */
> +static int port_bridge_join(struct net_device *netdev,
> + struct net_device *upper_dev)
> +{
> + struct ethsw_port_priv *port_priv = netdev_priv(netdev);
> + struct ethsw_core *ethsw = port_priv->eth
On 03/13, Dan Carpenter wrote:
> On Tue, Mar 13, 2018 at 10:06:29AM -0300, Rodrigo Siqueira wrote:
> > On 03/13, Dan Carpenter wrote:
> >
> > > Ah... I see why you did the ERROR_MESSAGE define, to get around the 80
> > > character limit. Don't do that. Just go over 80 characters if you need
> >
> -Original Message-
> From: Andrew Lunn [mailto:and...@lunn.ch]
> Sent: Tuesday, March 13, 2018 4:23 PM
> To: Razvan Stefanescu
> Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; linux-
> ker...@vger.kernel.org; net...@vger.kernel.org; Alexander Graf
> ; a...@arndb.de; Alexan
Hi Deepa,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on ]
url:
https://github.com/0day-ci/linux/commits/Deepa-Dinamani/posix_clocks-Prepare-syscalls-for-64-bit-time_t-conversion/20180313-203305
base:
config: arm64-allnoconfig (attached as .config)
compiler
> Hello Andrew,
>
> The current driver implementation uses only a single FDB for the switch,
> so it is not possible configure multiple flooding domains to accommodate
> ports partitioning.
Ah, O.K. Rather than break somebodies network by wrongly flooding, it
would be better to return -EOPNOTSUP
Hi Deepa,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on ]
url:
https://github.com/0day-ci/linux/commits/Deepa-Dinamani/posix_clocks-Prepare-syscalls-for-64-bit-time_t-conversion/20180313-203305
base:
config: powerpc-iss476-smp_defconfig (attached as
This patchset changes the way that frequency of clock input (fclkin) and
the excitation frequency (fexcit) are exposed to the userspace. The
original code uses the IIO_DEVICE_ATTR to export the configuration of
fclkin and fexcit to the userspace which is not in agreement with the
current ABI. This
The ad2s1210 does not contain any channel for the fclkin and fexcit. As
a result, it uses IIO_DEVICE_ATTR to expose this information. This patch
adds one channel for fclkin and another for fexcit. It also adds an enum
to easily address the correct channel.
Signed-off-by: Rodrigo Siqueira
---
dri
Read data from fclkin and fexcit does not utilize the ad2s1210_read_raw
function. This patch, append the required handler in the
ad2s1210_read_raw to return the correct value. Also, this patch removes
the legacy code related to the read function
Signed-off-by: Rodrigo Siqueira
---
drivers/stagin
The write interface of AD2S1210 utilizes IIO_DEVICE_ATTR, which violate
the official IIO ABI. This patch, add the write_raw function responsible
for handling the fclkin and fexcit channel; also it removes the use of
IIO_DEVICE_ATTR for fclkin and fexcit.
Signed-off-by: Rodrigo Siqueira
---
Change
This commit replaces custom KS_WLAN_DEBUG which is not being used anymore
in favour of DEBUG which is the one included when debugging is enabled.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks7010_sdio.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
The following patch series includes some cleanups of useless traces as well
as some replaces in order to use preferred macros for debugging and others.
Sergio Paracuellos (3):
staging: ks7010: remove useless DPRINTK traces
staging: ks7010: replace DPRINTK traces in favour of netdev_*
staging
This commit removes some useless traces in some source files
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks7010_sdio.c | 58 --
drivers/staging/ks7010/ks_hostif.c | 149 ++-
drivers/staging/ks7010/ks_wlan_net.c | 56 +
This commit removes custom defined DPRINTK macro and replaces all the
associated debug and other traces for preferred ones netdev_*.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks7010_sdio.c | 84 ++---
drivers/staging/ks7010/ks_hostif.c | 142
On Tue, Mar 13, 2018 at 06:23:39PM +, Dexuan Cui wrote:
> > From: Dexuan Cui
> > Sent: Wednesday, March 7, 2018 13:40
> > To: Lorenzo Pieralisi
> > Cc: bhelg...@google.com; linux-...@vger.kernel.org; KY Srinivasan
> > ; Stephen Hemminger ;
> > o...@aepfle.de; a...@canonical.com; jasow...@redha
> From: Dexuan Cui
> Sent: Wednesday, March 7, 2018 13:40
> To: Lorenzo Pieralisi
> Cc: bhelg...@google.com; linux-...@vger.kernel.org; KY Srinivasan
> ; Stephen Hemminger ;
> o...@aepfle.de; a...@canonical.com; jasow...@redhat.com; linux-
> ker...@vger.kernel.org; driverdev-devel@linuxdriverproje
Dring high network traffic changes to network interface parameters
such as number of channels or MTU can cause a kernel panic with a NULL
pointer dereference. This is due to netvsc_device_remove() being
called and deallocating the channel ring buffers, which can then be
accessed by netvsc_send_pkt(
On Tue, 13 Mar 2018 20:06:50 +0100
Mohammed Gamal wrote:
> Dring high network traffic changes to network interface parameters
> such as number of channels or MTU can cause a kernel panic with a NULL
> pointer dereference. This is due to netvsc_device_remove() being
> called and deallocating the c
In the current implementation, `rmmod snd_bcm2835` does not release
resources properly. It causes an oops when trying to list sound devices.
This commit fixes it.
The details WRT allocation / free are described below.
Device structure WRT allocation:
pdev
\childdev[]
\card
\chip
Signed-off-by: Peter Seiderer
---
drivers/staging/media/imx/imx-media-csi.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/media/imx/imx-media-csi.c
b/drivers/staging/media/imx/imx-media-csi.c
index 5a195f80a24d..3a6a645b9dce 100644
--- a/drivers/staging/media/imx/imx-m
2 gotos in error handling paths branch to the wrong label.
Fix it.
Signed-off-by: Christophe JAILLET
---
drivers/staging/vme/devices/vme_user.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vme/devices/vme_user.c
b/drivers/staging/vme/devices/vme_user.c
On Tue, Mar 13, 2018 at 9:34 PM, Kirill Marinushkin
wrote:
> In the current implementation, `rmmod snd_bcm2835` does not release
> resources properly. It causes an oops when trying to list sound devices.
>
> This commit fixes it.
Nice catch!
See my comments below.
> static void snd_devm_unregi
On Tue, Mar 13 2018, Arnd Bergmann wrote:
> One of Neil's recent cleanups apparently has led the code to get
> to a state where gcc tracks the 'seqnr' variable just enough to
> see that it is sometimes initialized in seq_client_alloc_seq(),
> but not enough that it can prove this initialization to
On Tue, Mar 13 2018, Arnd Bergmann wrote:
> We now allow lustre to be built when CONFIG_MODULES is disabled,
> but that causes a build failure:
>
> In file included from drivers/staging/lustre/include/linux/libcfs/libcfs.h:42,
> from drivers/staging/lustre/lustre/obdclass/lu_objec
Hi Peter,
Thanks for the patch.
This needs to be done in imx-ic-prpencvf.c as well, see
prp_vb2_buf_done().
Steve
On 03/13/2018 01:00 PM, Peter Seiderer wrote:
Signed-off-by: Peter Seiderer
---
drivers/staging/media/imx/imx-media-csi.c | 5 +
1 file changed, 5 insertions(+)
diff --g
Hello Steve,
On Tue, 13 Mar 2018 15:03:07 -0700, Steve Longerbeam
wrote:
> Hi Peter,
>
> Thanks for the patch.
>
> This needs to be done in imx-ic-prpencvf.c as well, see
> prp_vb2_buf_done().
Ahh, I see, would you prefer an follow up patch or
an v2 patch doing the changes on mx-media-cs
On 03/13/2018 03:24 PM, Peter Seiderer wrote:
Hello Steve,
On Tue, 13 Mar 2018 15:03:07 -0700, Steve Longerbeam
wrote:
Hi Peter,
Thanks for the patch.
This needs to be done in imx-ic-prpencvf.c as well, see
prp_vb2_buf_done().
Ahh, I see, would you prefer an follow up patch or
an v2
Signed-off-by: Peter Seiderer
---
drivers/staging/media/imx/imx-ic-prpencvf.c | 5 +
drivers/staging/media/imx/imx-media-csi.c | 5 +
2 files changed, 10 insertions(+)
diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c
b/drivers/staging/media/imx/imx-ic-prpencvf.c
index ae453fd4
Hi Peter,
On Tue, Mar 13, 2018 at 7:34 PM, Peter Seiderer wrote:
> Signed-off-by: Peter Seiderer
Could you please resend with a commit log explaining the reason for this patch?
Tahnks
___
devel mailing list
de...@linuxdriverproject.org
http://driverd
ething to improve:
>
> [auto build test ERROR on ]
>
> url:
> https://github.com/0day-ci/linux/commits/Deepa-Dinamani/posix_clocks-Prepare-syscalls-for-64-bit-time_t-conversion/20180313-203305
> base:
> config: arm64-allnoconfig (attached as .config)
> compiler: aarch64-linu
o improve:
>
> [auto build test ERROR on ]
>
> url:
> https://github.com/0day-ci/linux/commits/Deepa-Dinamani/posix_clocks-Prepare-syscalls-for-64-bit-time_t-conversion/20180313-203305
> base:
> config: powerpc-iss476-smp_defconfig (attached as .config)
> compiler: power
The series is a preparation series for individual architectures
to use 64 bit time_t syscalls in compat and 32 bit emulation modes.
This is a follow up to the series Arnd Bergmann posted:
https://sourceware.org/ml/libc-alpha/2015-05/msg00070.html [1]
Thomas, Arnd, this seems ready to be merged no
All the current architecture specific defines for these
are the same. Refactor these common defines to a common
header file.
The new common linux/compat_time.h is also useful as it
will eventually be used to hold all the defines that
are needed for compat time types that support non y2038
safe typ
61 matches
Mail list logo