Aw: [PATCH 0/6] hv_netvsc: avoid races on mtu change/set channels

2016-05-12 Thread Lino Sanfilippo
Hi, > > MTU change and set channels operations are implemented as netvsc device > re-creation destroying internal structures (struct net_device stays). This > is really unfortunate but there is no support from Hyper-V host to do it > in a different way. Such re-creation is unsurprisingly racy, Hai

Aw: Re: [PATCH 0/6] hv_netvsc: avoid races on mtu change/set channels

2016-05-12 Thread Lino Sanfilippo
> It's worse: before the patch series we get 'struct hv_device' (as it is > called from core VMBus code and we simply cannot get to 'struct > net_device' we need without traveling through 'struct > netvsc_device'. This structure is removed and re-created by both > netvsc_set_channels() and netvsc_

[PATCH v4 net-next 2/2] MAINTAINERS: add entry for slicoss ethernet driver

2016-12-05 Thread Lino Sanfilippo
Add myself as maintainer for the slicoss ethernet driver. Signed-off-by: Lino Sanfilippo --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6781a3f..bb9af28 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -562,6 +562,11 @@ T: git git

Gigabit ethernet driver for Alacritechs SLIC devices (v4)

2016-12-05 Thread Lino Sanfilippo
Hi, this is the forth version of the slicoss gigabit ethernet driver (which is a rework of the driver from Alacritech which can currently be found under drivers/staging/slicoss). The driver is supposed to support Mojave, Oasis and Kalahari cards, for both copper and fiber. If this code is accepte

[PATCH v4 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-12-05 Thread Lino Sanfilippo
) copper and fiber - Kalahari cards (dual and quad port PCI-e Gigabit) copper and fiber Signed-off-by: Lino Sanfilippo --- drivers/net/ethernet/Kconfig |1 + drivers/net/ethernet/Makefile |1 + drivers/net/ethernet/alacritech/Kconfig | 28 + drivers/net/ethernet

Re: Gigabit ethernet driver for Alacritechs SLIC devices (v4)

2016-12-06 Thread Lino Sanfilippo
On 06.12.2016 17:30, David Miller wrote: > From: Lino Sanfilippo > Date: Mon, 5 Dec 2016 23:07:15 +0100 > >> this is the forth version of the slicoss gigabit ethernet driver (which is a >> rework of the driver from Alacritech which can currently be found under >> dr

[PATCH] staging: slicoss: handle allocation failure in slic_init_adapter

2016-07-14 Thread Lino Sanfilippo
a zalloc() version. Signed-off-by: Lino Sanfilippo --- drivers/staging/slicoss/slicoss.c | 38 ++ 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index ac126d4..dae07410

[PATCH 6/9] staging: slicoss: avoid PCI write posting

2016-07-22 Thread Lino Sanfilippo
Introduce the function slic_flush_write() which reads from the HOSTID register and can be used to avoid PCI write posting. Use the function at several critical places in the code. Signed-off-by: Lino Sanfilippo --- drivers/staging/slicoss/slic.h| 5 + drivers/staging/slicoss/slicoss.c

[PATCH 5/9] staging: slicoss: introduce register accessors that use register offsets

2016-07-22 Thread Lino Sanfilippo
Introduce accessor functions that read and write registers by using a register offset. This is in preparation to replace the register addressing by means of the slic_regs struct with an addressing by means of offsets. Signed-off-by: Lino Sanfilippo --- drivers/staging/slicoss/slic.h| 24

[PATCH 9/9] staging: slicoss: simplify struct for statistics

2016-07-22 Thread Lino Sanfilippo
Merge several structures for statistics to one structure and remove unnecessary union nesting. Signed-off-by: Lino Sanfilippo --- drivers/staging/slicoss/slic.h| 18 + drivers/staging/slicoss/slichw.h | 79 --- drivers/staging/slicoss/slicoss.c

[PATCH 8/9] staging: slicoss: improve implementation concerning the shared memory

2016-07-22 Thread Lino Sanfilippo
-off-by: Lino Sanfilippo --- drivers/staging/slicoss/slic.h| 18 ++- drivers/staging/slicoss/slicoss.c | 267 ++ 2 files changed, 136 insertions(+), 149 deletions(-) diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h index 3bba82a

Slicoss fixes and improvements

2016-07-22 Thread Lino Sanfilippo
Hi, this patch series tries to get the slicoss driver code closer to a state in which it is ready to be moved out of staging. Patch 1 is a resend of patch I sent a week ago and handles an allocation failure in slic_init_adapter(). Patch 2 fixes link state notification. Patch 3 turns the mapping

[PATCH 7/9] staging: slicoss: dont use a structure but offsets for register accesses

2016-07-22 Thread Lino Sanfilippo
Use the new register accessors that use offsets instead of the slic_regs structure to read/write registers. Since not longer needed remove the structure completley. Signed-off-by: Lino Sanfilippo --- drivers/staging/slicoss/slic.h| 1 - drivers/staging/slicoss/slichw.h | 219

[PATCH 4/9] staging: slicoss: start tx queue when interface is brought up

2016-07-22 Thread Lino Sanfilippo
There is no reason to delay tx queue activation until a link is detected. So start the queue when the interface is brought up and stop it when the interface is brought down. Signed-off-by: Lino Sanfilippo --- drivers/staging/slicoss/slicoss.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH 2/9] staging: slicoss: notifiy network stack about change in link state

2016-07-22 Thread Lino Sanfilippo
Notify the network stack about link states via netif_carrier_[off|on](). Also set the link state off initially and when the interface is brought down. Signed-off-by: Lino Sanfilippo --- drivers/staging/slicoss/slicoss.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/staging

[PATCH 3/9] staging: slicoss: ensure mapping of io-memory is uncached

2016-07-22 Thread Lino Sanfilippo
From: Lino Sanfilippo Writes to registers should be done uncached for various reasons. Ensure this by replacing ioremap() with ioremap_nocache(). Signed-off-by: Lino Sanfilippo --- drivers/staging/slicoss/slicoss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 1/9] staging: slicoss: handle allocation failure in slic_init_adapter

2016-07-22 Thread Lino Sanfilippo
a zalloc() version. Signed-off-by: Lino Sanfilippo --- drivers/staging/slicoss/slicoss.c | 38 ++ 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index ac126d4..dae07410

Aw: Re: staging: wilc1000: Reduce scope for a few variables in mac_ioctl()

2016-07-28 Thread Lino Sanfilippo
> Gesendet: Dienstag, 26. Juli 2016 um 08:25 Uhr > Von: "SF Markus Elfring" > > >> - if (strncasecmp(buff, "RSSI", length) == 0) { > >> + if (strncasecmp(buff, "RSSI", 0) == 0) { > >> + s8 rssi; > >> + > > > > Um, please think a second

Re: [PATCH] staging: slicoss.ko: slicoss.c: Fixed incorrect argument type

2016-10-18 Thread Lino Sanfilippo
Hi Ryan, On 18.10.2016 20:03, Ryan Swan wrote: > sparse produced > warning: incorrect type in argument 2 (different address spaces) > expected void const volatile [noderef] *src > got struct slic_stats *stats > > casting argument 2 to what is expected by memcpy_fromio() fixed this > > Signed-off

Re: [PATCH] staging: slicoss: replace memcpy_fromio with memcpy

2016-10-18 Thread Lino Sanfilippo
On 18.10.2016 23:26, Ryan Swan wrote: > As per discusion with Lino Sanfilippo, memcpy is the proper way to copy > across dma memory, which also removes sparse warning that triggered > inquiry. > > Signed-off-by: Ryan Swan > --- > drivers/staging/slicoss/slicoss.c | 2 +-

Gigabit ethernet driver for Alacritechs SLIC devices

2016-11-12 Thread Lino Sanfilippo
Hi, this is a rework of the slicoss gigabit ethernet driver from Alacritech that is currently part of the staging area. The driver is supposed to support Mojave, Oasis and Kalahari cards, for both copper and fiber. If this code is accepted the staging version can be removed (as Greg told me by

[net-next 2/2] MAINTAINERS: add entry for slicoss ethernet driver

2016-11-12 Thread Lino Sanfilippo
Add myself as maintainer for the slicoss ethernet driver. Signed-off-by: Lino Sanfilippo --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6781a3f..bb9af28 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -562,6 +562,11 @@ T: git git

[net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-12 Thread Lino Sanfilippo
) copper and fiber - Kalahari cards (dual and quad port PCI-e Gigabit) copper and fiber Signed-off-by: Lino Sanfilippo --- drivers/net/ethernet/Kconfig |1 + drivers/net/ethernet/Makefile |1 + drivers/net/ethernet/alacritech/Kconfig | 28 + drivers/net/ethernet

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
Hi, On 13.11.2016 20:55, Andrew Lunn wrote: >> +static const char slic_stats_strings[][ETH_GSTRING_LEN] = { >> +"rx_packets ", >> +"rx_bytes ", >> +"rx_multicasts ", >> +"rx_errors ", >> +"rx_buff_miss ", >> +"rx_tp_csum ", >> +"rx_tp_oflow",

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
Hi, On 15.11.2016 21:54, Florian Fainelli wrote: > On 11/15/2016 12:46 PM, Lino Sanfilippo wrote: >>> Could this be pulled out into a standard PHY driver? All the SLIC >>> SLIC_PCR_ defines seems to be the same as those in mii.h. This could >>> be a standard PHY h

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
On 15.11.2016 22:59, Andrew Lunn wrote: >> The link state is retrieved by a command to the application processor that >> is running >> on the network card. Also the register to set the phy configuration is >> write-only, so >> it is not even possible to do the usual mdio bit-banging in the Phy r

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
On 15.11.2016 23:39, Florian Fainelli wrote: > On 11/15/2016 02:34 PM, Lino Sanfilippo wrote: >> On 15.11.2016 22:59, Andrew Lunn wrote: >>>> The link state is retrieved by a command to the application processor that >>>> is running >>>> on the n

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
On 16.11.2016 00:03, Andrew Lunn wrote: >> > + val = MII_BMCR << 16 | SLIC_PCR_AUTONEG | >> > + SLIC_PCR_AUTONEG_RST; >> > + slic_write(sdev, SLIC_REG_WPHY, val); > >> Thats essentially what I meant by setting a fl

Aw: Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-24 Thread Lino Sanfilippo
Hi Andrew, Hi Florian > Gesendet: Dienstag, 15. November 2016 um 23:34 Uhr > Von: "Lino Sanfilippo" > An: "Andrew Lunn" > Cc: "Florian Fainelli" , da...@davemloft.net, > char...@alacritech.com, lio...@gmail.com, gre...@linuxfoundation.

Gigabit ethernet driver for Alacritechs SLIC devices

2016-11-24 Thread Lino Sanfilippo
Hi, this is the second version of the slicoss gigabit ethernet driver (which is a rework of the driver from Alacritech which can currently be found under drivers/staging/slicoss). The driver is supposed to support Mojave, Oasis and Kalahari cards, for both copper and fiber. If this code is accept

[PATCH v2 net-next 2/2] MAINTAINERS: add entry for slicoss ethernet driver

2016-11-24 Thread Lino Sanfilippo
Add myself as maintainer for the slicoss ethernet driver. Signed-off-by: Lino Sanfilippo --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6781a3f..bb9af28 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -562,6 +562,11 @@ T: git git

[PATCH v2 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-24 Thread Lino Sanfilippo
) copper and fiber - Kalahari cards (dual and quad port PCI-e Gigabit) copper and fiber Signed-off-by: Lino Sanfilippo --- drivers/net/ethernet/Kconfig |1 + drivers/net/ethernet/Makefile |1 + drivers/net/ethernet/alacritech/Kconfig | 28 + drivers/net/ethernet

Aw: Re: [PATCH v2 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-25 Thread Lino Sanfilippo
Hi, > > On Fri, Nov 25, 2016 at 12:13:04AM +0100, Lino Sanfilippo wrote: > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -2015,6 +2015,24 @@ > > #define PCI_SUBDEVICE_ID_CCD_OV4S 0xE888 > > #define PCI_SUBDEVICE_ID

Gigabit ethernet driver for Alacritechs SLIC devices (v3)

2016-11-26 Thread Lino Sanfilippo
Hi, this is the third version of the slicoss gigabit ethernet driver (which is a rework of the driver from Alacritech which can currently be found under drivers/staging/slicoss). The driver is supposed to support Mojave, Oasis and Kalahari cards, for both copper and fiber. If this code is accepte

[PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-26 Thread Lino Sanfilippo
) copper and fiber - Kalahari cards (dual and quad port PCI-e Gigabit) copper and fiber Signed-off-by: Lino Sanfilippo --- drivers/net/ethernet/Kconfig |1 + drivers/net/ethernet/Makefile |1 + drivers/net/ethernet/alacritech/Kconfig | 28 + drivers/net/ethernet

[PATCH v3 net-next 2/2] MAINTAINERS: add entry for slicoss ethernet driver

2016-11-26 Thread Lino Sanfilippo
Add myself as maintainer for the slicoss ethernet driver. Signed-off-by: Lino Sanfilippo --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6781a3f..bb9af28 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -562,6 +562,11 @@ T: git git

Re: Gigabit ethernet driver for Alacritechs SLIC devices (v3)

2016-11-26 Thread Lino Sanfilippo
On 26.11.2016 13:20, Lino Sanfilippo wrote: > v3: > - dont add defines to pci.h but instead put it into the drivers header file This should of course be "pci_ids.h". Regards, Lino ___ devel mailing list de...@linuxdriver

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-26 Thread Lino Sanfilippo
Hi Rami, On 26.11.2016 16:48, Rami Rosen wrote: >> @@ -0,0 +1,28 @@ >> +config NET_VENDOR_ALACRITECH >> +bool "Alacritech devices" >> +default y >> +---help--- >> + If you have a network (Ethernet) card belonging to this class, >> say Y. >> + >> + Note

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-28 Thread Lino Sanfilippo
Hi Markus, On 27.11.2016 18:59, Markus Böhme wrote: > Hello Lino, > > just some things barely worth mentioning: > > > I found a bunch of unused #defines in slic.h. I cannot judge if they are > worth keeping: > > SLIC_VRHSTATB_LONGE > SLIC_VRHSTATB_PREA > SLIC_ISR_IO >

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-28 Thread Lino Sanfilippo
Hi Florian, On 28.11.2016 05:56, Florian Fainelli wrote: > On 11/26/2016 04:20 AM, Lino Sanfilippo wrote: >> Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer >> interface control) technology. The driver provides basic support without >> SLIC for

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-30 Thread Lino Sanfilippo
On 29.11.2016 18:14, Florian Fainelli wrote: > On 11/28/2016 01:41 PM, Lino Sanfilippo wrote: >> The problem is that the HW does not provide a tx completion index. Instead >> we have to >> iterate the status descriptors until we get an invalid idx which indicates >