[PATCH] staging: crystalhd: Do not mix integers and user pointers

/crystalhd_lnx.c:229:65: warning: incorrect type in argument 4 (different base types) crystalhd/crystalhd_lnx.c:229:65:expected unsigned long [unsigned] ua crystalhd/crystalhd_lnx.c:229:65:got void [noderef] asn:1*ua Done for the Eudyptula challenge. Signed-off-by: Lubomir Rintel lkund...@v3

[PATCH 5/5] staging: xgifb: Update TODO

: delete unused definitions), 5c167b30c1b4 (staging: xgifb: eliminate #ifdef NewScratch), f059077388b0 (Staging: xgifb: Remove #ifdef MODULE) and more. Signed-off-by: Lubomir Rintel lkund...@v3.sk --- drivers/staging/xgifb/TODO | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 4/5] staging: xgifb: Drop some more useless defines

SetLCDStdMode is not supported as of 34c13ee2b690 (staging: xgifb: drop code for legacy VGA modes). DisableLCD24bpp defined to zero was never realy useful and went away with aa56b2790a8b (staging: xgifb: vb_table: delete XGI21_LCDCapList). Signed-off-by: Lubomir Rintel lkund...@v3.sk

[PATCH 2/5] staging: xgifb: Drop pr_fmt

It is neither used nor useful. Signed-off-by: Lubomir Rintel lkund...@v3.sk --- drivers/staging/xgifb/XGI_main_26.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index a62d4dd..d61e03f 100644 --- a/drivers/staging

[PATCH 1/5] staging: xgifb: Eliminate useless ifndefs

XGI_VB_CHIP_TYPE, PCI_DEVICE_ID_XGI_42 and PCI_DEVICE_ID_XGI_27 are never defined. Signed-off-by: Lubomir Rintel lkund...@v3.sk --- drivers/staging/xgifb/XGI_main.h | 4 drivers/staging/xgifb/vgatypes.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main.h b

[PATCH 3/5] staging: xgifb: Initialize Part0Port

It was left uninitialized, likely overseen, in this commit: 56810a92c689c6 (staging: xgifb: use XGIRegInit() Avoid copy-paste and use XGIRegInit() to initialize registers addresses.) Signed-off-by: Lubomir Rintel lkund...@v3.sk --- drivers/staging/xgifb/XGI_main_26.c | 1 + 1 file changed, 1

staging: xgifb: A couple of minor tidyups

Hi, I've cleaned up some small issues in xgifb driver as part of a solution to an Eudyptula Challenge [1] task. The patches are chained to this message. [1] http://eudyptula-challenge.org/ Lubo ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 0/15] Add support for OLPC XO 1.75 Embedded Controller

On Fri, 2018-10-19 at 16:57 +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote: > > Hi. > > > > This patchset adds support for the Embedded Controller on an OLPC XO > > 1.75 machine. OLPC XO 1.75 is a MMP2 based ARM laptop. It plugs

Re: [PATCH 04/15] Platform: OLPC: Remove an unused include

Hi, thank you for the response. On Fri, 2018-10-19 at 16:05 +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel > wrote: > > Also, the header is x86 specific, while there are non-x86 OLPC > > machines. > > Same concern. as per patch 2.

Re: [PATCH 06/15] Platform: OLPC: Add XO-1.75 EC driver

a few days; I'm mostly done with this one but I've not finished addressing the followup ones. On Fri, 2018-10-19 at 19:06 +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2018 at 8:24 PM Lubomir Rintel > wrote: > > It's based off the driver from the OLPC kernel sources. Somewhat > &g

Re: [PATCH 02/15] Revert "platform/olpc: Make ec explicitly non-modular"

On Fri, 2018-11-02 at 23:16 +0100, Pavel Machek wrote: > On Wed 2018-10-10 19:22:47, Lubomir Rintel wrote: > > It doesn't make sense to always have this built-in, e.g. on ARM > > multiplatform kernels. A better way to address the problem the > > original > > commit aimed

Re: [PATCH 12/15] power: supply: olpc_battery: Use DT to get battery version

On Fri, 2018-10-19 at 16:45 +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel > wrote: > > Avoid using the x86 OLPC platform specific call to get the board > > version. It won't work on FDT-based ARM MMP2 platform. > > > >

Re: [PATCH 12/15] power: supply: olpc_battery: Use DT to get battery version

On Sun, 2018-11-04 at 13:37 +0100, Pavel Machek wrote: > On Wed 2018-10-10 19:22:57, Lubomir Rintel wrote: > > Avoid using the x86 OLPC platform specific call to get the board > > version. It won't work on FDT-based ARM MMP2 platform. > > > > Signed-off-by: Lubomir Ri

Re: [PATCH 08/15] Platform: OLPC: Move EC-specific functionality out from x86

Hello, On Fri, 2018-10-19 at 16:36 +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2018 at 8:24 PM Lubomir Rintel > wrote: > > It is actually plaform independent. Move it to the olpc-ec driver > > from > > the X86 OLPC platform, so that it could be used by the ARM b

Re: [PATCH 13/15] power: supply: olpc_battery: Move priv data to a struct

On Sun, 2018-11-04 at 15:37 +0100, Pavel Machek wrote: > Hi! > > > The global variables for private data are not too nice. I'd like some > > more, and that would clutter the global name space even further. > > > > Signed-off-by: Lubomir Rintel > > R

Re: [PATCH 11/15] x86, olpc: Use a correct version when making up a battery node

Hello, On Fri, 2018-10-19 at 16:43 +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel > wrote: > > The XO-1 and XO-1.5 batteries apparently differ in an ability to > > report > > ambient temperature. Add a different compatible string to the 1

Re: [PATCH 14/15] power: supply: olpc_battery: Avoid using platform_info

On Fri, 2018-10-19 at 16:50 +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2018 at 8:24 PM Lubomir Rintel > wrote: > > This wouldn't work on the DT-based ARM platform. Let's read the EC > > version > > directly from the EC driver instead. > > > > This mak

[PATCH 05/15] Platform: OLPC: Move OLPC config symbol out of x86 tree

There are ARM OLPC machines that use mostly the same drivers, including EC infrastructure, DCON and Battery. While at that, fix Kconfig to allow building this as a module. Signed-off-by: Lubomir Rintel --- arch/x86/Kconfig | 11 --- drivers/input/mouse/Kconfig

[PATCH 03/15] dt-bindings: olpc, xo1.75-ec: Add OLPC XO-1.75 EC bindings

). Signed-off-by: Lubomir Rintel --- .../bindings/misc/olpc,xo1.75-ec.txt | 24 +++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.txt diff --git a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.txt b

[PATCH 04/15] Platform: OLPC: Remove an unused include

Also, the header is x86 specific, while there are non-x86 OLPC machines. Signed-off-by: Lubomir Rintel --- drivers/platform/olpc/olpc-ec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c index f99b183d5296..35a21c66cd0d 100644

[PATCH 10/15] dt-bindings: olpc_battery: Add XO-1.5 battery

The XO-1 and XO-1.5 batteries apparently differ in an ability to report ambient temperature. Signed-off-by: Lubomir Rintel --- Documentation/devicetree/bindings/power/supply/olpc_battery.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings

[PATCH 01/15] power: supply: olpc_battery: correct the temperature units

laptops. [1] include/linux/power_supply.h [2] Documentation/power/power_supply_class.txt Cc: sta...@vger.kernel.org Signed-off-by: Lubomir Rintel --- drivers/power/supply/olpc_battery.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/supply/olpc_battery.c b

[PATCH 02/15] Revert "platform/olpc: Make ec explicitly non-modular"

It doesn't make sense to always have this built-in, e.g. on ARM multiplatform kernels. A better way to address the problem the original commit aimed to solve is to fix Kconfig. This reverts commit f48d1496b8537d75776478c6942dd87f34d7f270. Signed-off-by: Lubomir Rintel --- drivers/platform/olpc

[PATCH 0/15] Add support for OLPC XO 1.75 Embedded Controller

Hi. This patchset adds support for the Embedded Controller on an OLPC XO 1.75 machine. OLPC XO 1.75 is a MMP2 based ARM laptop. It plugs into the existing OLPC platform infrastructure, currently used by the x86 based models. The EC operates in SPI master mode, meaning the SOC is the SPI slave.

[PATCH 06/15] Platform: OLPC: Add XO-1.75 EC driver

It's based off the driver from the OLPC kernel sources. Somewhat modernized and cleaned up, for better or worse. Modified to plug into the olpc-ec driver infrastructure (so that battery interface and debugfs could be reused) and the SPI slave framework. Signed-off-by: Lubomir Rintel

[PATCH 12/15] power: supply: olpc_battery: Use DT to get battery version

Avoid using the x86 OLPC platform specific call to get the board version. It won't work on FDT-based ARM MMP2 platform. Signed-off-by: Lubomir Rintel --- drivers/power/supply/olpc_battery.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply

[PATCH 14/15] power: supply: olpc_battery: Avoid using platform_info

This wouldn't work on the DT-based ARM platform. Let's read the EC version directly from the EC driver instead. This makes the driver no longer x86 specific. Signed-off-by: Lubomir Rintel --- drivers/power/supply/Kconfig| 2 +- drivers/power/supply/olpc_battery.c | 35

[PATCH 07/15] Platform: OLPC: Avoid a warning if the EC didn't register yet

Just return ENODEV, so that whoever attempted to use the EC call can defer their work. Signed-off-by: Lubomir Rintel --- drivers/platform/olpc/olpc-ec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c

[PATCH 09/15] Platform: OLPC: add a regulator for the DCON

All OLPC ECs are able to turn the power to the DCON on an off. Use the regulator framework to expose the functionality. Signed-off-by: Lubomir Rintel --- drivers/platform/olpc/Kconfig | 1 + drivers/platform/olpc/olpc-ec.c | 65 + 2 files changed, 66

[PATCH 08/15] Platform: OLPC: Move EC-specific functionality out from x86

It is actually plaform independent. Move it to the olpc-ec driver from the X86 OLPC platform, so that it could be used by the ARM based laptops too. Signed-off-by: Lubomir Rintel --- arch/x86/include/asm/olpc.h | 17 - arch/x86/platform/olpc/olpc.c | 119

[PATCH 15/15] power: supply: olpc_battery: Add OLPC XO 1.75 support

The battery and the protocol are essentially the same as OLPC XO 1.5, but the responses from the EC are LSB first. Signed-off-by: Lubomir Rintel --- drivers/power/supply/olpc_battery.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/power

[PATCH 11/15] x86, olpc: Use a correct version when making up a battery node

The XO-1 and XO-1.5 batteries apparently differ in an ability to report ambient temperature. Add a different compatible string to the 1.5 battery. Signed-off-by: Lubomir Rintel --- arch/x86/platform/olpc/olpc_dt.c | 59 +++- 1 file changed, 42 insertions(+), 17

[PATCH 13/15] power: supply: olpc_battery: Move priv data to a struct

The global variables for private data are not too nice. I'd like some more, and that would clutter the global name space even further. Signed-off-by: Lubomir Rintel --- drivers/power/supply/olpc_battery.c | 73 +++-- 1 file changed, 38 insertions(+), 35 deletions

Re: [PATCH 0/15] Add support for OLPC XO 1.75 Embedded Controller

On Wed, 2018-10-10 at 14:26 -0500, Rob Herring wrote: > On Wed, Oct 10, 2018 at 12:23 PM Lubomir Rintel wrote: > > Hi. > > > > This patchset adds support for the Embedded Controller on an OLPC XO > > 1.75 machine. OLPC XO 1.75 is a MMP2 based ARM laptop. It plugs

[PATCH v2 01/17] power: supply: olpc_battery: correct the temperature units

laptops. [1] include/linux/power_supply.h [2] Documentation/power/power_supply_class.txt Fixes: fb972873a767 ("[BATTERY] One Laptop Per Child power/battery driver") Cc: sta...@vger.kernel.org Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- Changes since v1: - Add Fixes tag

[PATCH v2 10/17] Platform: OLPC: add a regulator for the DCON

All OLPC ECs are able to turn the power to the DCON on an off. Use the regulator framework to expose the functionality. Signed-off-by: Lubomir Rintel --- Changes since v1: - Use idiomatic form of return on error - Avoid mixing bool and int drivers/platform/olpc/Kconfig | 1 + drivers

[PATCH v2 13/17] power: supply: olpc_battery: Use DT to get battery version

Avoid using the x86 OLPC platform specific call to get the board version. It won't work on FDT-based ARM MMP2 platform. Signed-off-by: Lubomir Rintel Reviewed-by: Andy Shevchenko Acked-by: Pavel Machek --- Changes since v1: - Sort the new include a bit higher drivers/power/supply

[PATCH v2 0/17] Add support for OLPC XO 1.75 Embedded Controller

Hi everyone! This is a second spin of the patch set that adds support for the Embedded Controller on an OLPC XO 1.75 machine. OLPC XO 1.75 is a MMP2 based ARM laptop. It plugs into the existing OLPC platform infrastructure, currently used by the x86 based models. The slave mode support for

[PATCH v2 15/17] power: supply: olpc_battery: Use devm_power_supply_register()

This simplifies the error handling. Signed-off-by: Lubomir Rintel --- Changes since v1: - This was split off the "power: supply: olpc_battery: Move priv data to a struct" patch. drivers/power/supply/olpc_battery.c | 19 +-- 1 file changed, 5 insertions(+), 14

[PATCH v2 07/17] Platform: OLPC: Avoid a warning if the EC didn't register yet

Just return ENODEV, so that whoever attempted to use the EC call can defer their work. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- Changes since v1: - EPROBE_DEFER instead of ENODEV drivers/platform/olpc/olpc-ec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions

[PATCH v2 09/17] Platform: OLPC: Use BIT() and GENMASK() for event masks

Just a cosmetic tidy-up. Signed-off-by: Lubomir Rintel --- Changes since v1: - This patch was added to the set. include/linux/olpc-ec.h | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/include/linux/olpc-ec.h b/include/linux/olpc-ec.h index

[PATCH v2 05/17] Platform: OLPC: Move OLPC config symbol out of x86 tree

There are ARM OLPC machines that use mostly the same drivers, including EC infrastructure, DCON and Battery. While at that, fix Kconfig to allow building this as a module. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- Changes since v1: - Use 'depends on OLPC && X86' idiom

[PATCH v2 02/17] dt-bindings: olpc, xo1.75-ec: Add OLPC XO-1.75 EC bindings

). Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- Changes since v1: - s/cmd-gpio/cmd-gpios/ - s/ready-gpio/ready-gpios/ in the documentation paragraph - Remove status = "okay" from the example .../bindings/misc/olpc,xo1.75-ec.txt | 23 +++ 1 file c

[PATCH v2 03/17] Platform: OLPC: Remove an unused include

Also, the header is x86 specific, while there are non-x86 OLPC machines. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- drivers/platform/olpc/olpc-ec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c index

[PATCH v2 04/17] Revert "platform/olpc: Make ec explicitly non-modular"

-off-by: Lubomir Rintel --- Changes since v1: - Sort it later in the patch set drivers/platform/olpc/olpc-ec.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c index 981955dce926..35a21c66cd0d 100644

[PATCH v2 12/17] x86, olpc: Use a correct version when making up a battery node

The XO-1 and XO-1.5 batteries apparently differ in an ability to report ambient temperature. Add a different compatible string to the 1.5 battery. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- Changes since v1: - Avoid splitting string literals arch/x86/platform/olpc/olpc_dt.c

[PATCH v2 06/17] Platform: OLPC: Add XO-1.75 EC driver

It's based off the driver from the OLPC kernel sources. Somewhat modernized and cleaned up, for better or worse. Modified to plug into the olpc-ec driver infrastructure (so that battery interface and debugfs could be reused) and the SPI slave framework. Signed-off-by: Lubomir Rintel

[PATCH v2 17/17] power: supply: olpc_battery: Add OLPC XO 1.75 support

The battery and the protocol are essentially the same as OLPC XO 1.5, but the responses from the EC are LSB first. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- Changes since v1: - s/s16 ecword_to_cpu/u16 ecword_to_cpu/ - s/u16 ec_byte/u16 ec_word/ drivers/power/supply

[PATCH v2 08/17] Platform: OLPC: Move EC-specific functionality out from x86

with their argument and responses are mostly the same despite the delivery mechanism is different. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- Changes since v1: - Cosmetic changes in line wrapping. - Remove an old extra copy of EC_SCI_* defines - Change version to u8 - Explain which parts

[PATCH v2 14/17] power: supply: olpc_battery: Move priv data to a struct

The global variables for private data are not too nice. I'd like some more, and that would clutter the global name space even further. Signed-off-by: Lubomir Rintel Reviewed-by: Andy Shevchenko --- Changes since v1: - Split out the move to devm_* into a separate patch drivers/power/supply

[PATCH v2 11/17] dt-bindings: olpc_battery: Add XO-1.5 battery

The XO-1 and XO-1.5 batteries apparently differ in an ability to report ambient temperature. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring Acked-by: Pavel Machek --- Changes since v1: - Collected Reviewed-by and Acked-by tags Documentation/devicetree/bindings/power/supply

[PATCH v2 16/17] power: supply: olpc_battery: Avoid using platform_info

This wouldn't work on the DT-based ARM platform. Let's read the EC version directly from the EC driver instead. This makes the driver no longer x86 specific. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- Changes since v1: - Use uint8_t instead of unsigned char [1] for ecver

Re: [PATCH 06/15] Platform: OLPC: Add XO-1.75 EC driver

Hi Pavel, I've addressed some of Andy's concerns you're replying to below in a follow-up version of the patch. To many points I'm generally indifferent and prefer to lean towards making things easy for whoever may be likely to deal with the code in past. It's not clear to me who that might be, or

Re: [PATCH v2 17/17] power: supply: olpc_battery: Add OLPC XO 1.75 support

On Sun, 2018-12-02 at 15:34 -0800, Darren Hart wrote: > On Fri, Nov 16, 2018 at 05:24:03PM +0100, Lubomir Rintel wrote: > > The battery and the protocol are essentially the same as OLPC XO 1.5, > > but the responses from the EC are LSB first. > > > > Signed-off-by

Re: [PATCH v2 13/17] power: supply: olpc_battery: Use DT to get battery version

On Wed, 2018-12-05 at 21:54 +0100, Sebastian Reichel wrote: > Hi, > > On Fri, Nov 16, 2018 at 05:23:59PM +0100, Lubomir Rintel wrote: > > Avoid using the x86 OLPC platform specific call to get the board > > version. It won't work on FDT-based ARM MMP2 platform. > >

[PATCH] staging: olpc_dcon: add a missing dependency

&& I2C [=y] && (GPIO_CS5535 [=n] || GPIO_CS5535 [=n]=n) Signed-off-by: Lubomir Rintel --- drivers/staging/olpc_dcon/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/olpc_dcon/Kconfig b/drivers/staging/olpc_dcon/Kconfig index c91a56f77bcb..192cc8d08