Re: [PATCH] staging: ks7010: Fix coding style issues

Hi Fernando, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.17-rc1 next-20180417] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] staging: ks7010: Fix coding style issues

Hi Fernando, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.17-rc1 next-20180417] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] staging: ks7010: Fix coding style issues

On Mon, Apr 16, 2018 at 10:36:53PM -0300, Fernando Pereira wrote: > Fix most of checkpatch.pl issues unrelated with 80 columns limit > You're going to need to be more specific and you're going to need to break the patch up so that it fixes one thing (type of warning) per patch. > Signed-off-by:

[PATCH] staging: ks7010: Fix coding style issues

Fix most of checkpatch.pl issues unrelated with 80 columns limit Signed-off-by: Fernando Pereira --- drivers/staging/ks7010/ks_hostif.c | 17 + drivers/staging/ks7010/ks_wlan_net.c | 5 ++--- drivers/staging/ks7010/michael_mic.c | 5 ++--- 3 files

Re: [PATCH] staging: ks7010: fix coding style issues reported by checkpatch.pl

On Wed, Feb 15, 2017 at 10:24:26PM +0900, Chetan Sethi wrote: > This is patch to ks_wlan.h which fixes various coding style errors and > warnings issued by checkpatch.pl What do you mean by "various"? Always be very specific as to what you are doing, and why you are doing it. And only do one

[PATCH] staging: ks7010: fix coding style issues reported by checkpatch.pl

This is patch to ks_wlan.h which fixes various coding style errors and warnings issued by checkpatch.pl Signed-off-by: Chetan Sethi --- drivers/staging/ks7010/ks_wlan.h | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

Re: [PATCH] staging: ks7010: fix coding style issues in ks7010_sdio.c

On Thu, Sep 01, 2016 at 11:18:15PM +0530, Sabitha George wrote: > This is a patch to the ks7010_sdio.c that fixes the following > warnings found by checkpatch.pl > 1) Missing a blank line after declarations > 2) braces are not necessary for single statement blocks > 3) kfree(NULL) is safe and this

[PATCH] staging: ks7010: fix coding style issues in ks7010_sdio.c

This is a patch to the ks7010_sdio.c that fixes the following warnings found by checkpatch.pl 1) Missing a blank line after declarations 2) braces are not necessary for single statement blocks 3) kfree(NULL) is safe and this check is probably not required 4) void function return statements are not