Re: [Dspace-tech] A simplified version of dspace-services and Tomcat unloading

2010-10-10 Thread Graham Triggs
On 7 October 2010 06:55, Mark Diggory wrote: > You know I'm for (1) simplified spring only service manager. (2) jdbc > data source delivered by servlet container (3) dropping reflectutils. > Well, the JDBC datasource is a change to dspace-api rather than -services, but there is no reason why it

Re: [Dspace-tech] A simplified version of dspace-services and Tomcat unloading

2010-10-06 Thread Mark Diggory
Graham, Thanks for the detailed overview... Any chance you can provide some pointers into the changes? Maybe using fisheye... https://fisheye3.atlassian.com/changelog/dspace/modules/dspace-services/branches/simplified-prototype?cs=5379 You know I'm for (1) simplified spring only service manager.

Re: [Dspace-tech] A simplified version of dspace-services and Tomcat unloading

2010-10-06 Thread Graham Triggs
On 5 October 2010 19:17, Sands Alden Fish wrote: > What resources were leaking here exactly? Leaking resources across > requests can have some serious consequences depending on the resources, and > I'm curious to know exactly what type of errant behavior we could expect > from a 1.6.x version ru

Re: [Dspace-tech] A simplified version of dspace-services and Tomcat unloading

2010-10-05 Thread Kim Shepherd
Thanks for the detailed writeup and explanations, it's helping me understand a lot of these issues better... looks like I still have some bedtime reading (and DSpace profiling) ahead of me! ;-) Cheers, Kim On 5 October 2010 12:55, Graham Triggs wrote: > Hello all, > > So, we've been debating t

Re: [Dspace-tech] A simplified version of dspace-services and Tomcat unloading

2010-10-05 Thread Sands Alden Fish
Graham, this is impressive and very important work. I haven't begun to digest it all, but maybe I'll start with one question to get a better understanding... 2) A ThreadLocal in the CachingServiceImpl was also leaking - the service did attempt to clean up in the shutdown, but it would only ever

[Dspace-tech] A simplified version of dspace-services and Tomcat unloading

2010-10-04 Thread Graham Triggs
Hello all, So, we've been debating the performance / resource usage of DSpace 1.6. This has just happened to coincide with work that I needed to do to qualify DSpace 1.6 (and/or 1.7) for our own use. So, for the past week or so, I've been hammering away at profiling DSpace. This isn't a comprehens