Re: [dwm] applyrules()

2008/12/6 yy [EMAIL PROTECTED]: Great 5.3.1 release! What about this little change in applyrules? @@ -259,7 +259,7 @@ (!r-class || (ch.res_class strstr(ch.res_class, r-class))) (!r-instance || (ch.res_name strstr(ch.res_name, r-instance

[dwm] applyrules()

Great 5.3.1 release! What about this little change in applyrules? @@ -259,7 +259,7 @@ (!r-class || (ch.res_class strstr(ch.res_class, r-class))) (!r-instance || (ch.res_name strstr(ch.res_name, r-instance {

Re: [dwm] applyrules

Hi Filippo, 2008/8/27 Filippo Erik Negroni [EMAIL PROTECTED]: In applyrules(), the return value of XGetClassHint is not checked. Agreed. ch is also initialised to {0}, which, I believe, is reduntant if XGetClassHint is successful. Well, I think we should keep this and also the checks for

Re: [dwm] applyrules

Anselm R Garbe wrote: Hi Filippo, 2008/8/27 Filippo Erik Negroni [EMAIL PROTECTED]: In applyrules(), the return value of XGetClassHint is not checked. Agreed. ch is also initialised to {0}, which, I believe, is reduntant if XGetClassHint is successful. Well, I think we should

Re: [dwm] applyrules

2008/8/29 Anselm R Garbe [EMAIL PROTECTED] ch is also initialised to {0}, which, I believe, is reduntant if XGetClassHint is successful. Well, I think we should keep this and also the checks for res_class and res_name, since it is not mandatory to set both or any of these WM_CLASS

Re: [dwm] applyrules

2008/8/29 Anselm R Garbe [EMAIL PROTECTED] Hi Filippo, 2008/8/27 Filippo Erik Negroni [EMAIL PROTECTED]: In applyrules(), the return value of XGetClassHint is not checked. Agreed. If XGetClassHint is not successful, you cannot make any assumptions about the values of ch's members. They

Re: [dwm] applyrules

See hg tip for reference. applyrules() is returned if XGetClassHint fails. Kind regards, Anselm 2008/8/29 Filippo Erik Negroni [EMAIL PROTECTED]: 2008/8/29 Anselm R Garbe [EMAIL PROTECTED] Hi Filippo, 2008/8/27 Filippo Erik Negroni [EMAIL PROTECTED]: In applyrules(), the return value of

Re: [dwm] applyrules

Aarm I mean, the applyrules() stuff isn't executed in such a case, just the current tag is applied. --Anselm 2008/8/29 Anselm R Garbe [EMAIL PROTECTED]: See hg tip for reference. applyrules() is returned if XGetClassHint fails. Kind regards, Anselm 2008/8/29 Filippo Erik Negroni [EMAIL

[dwm] applyrules

In applyrules(), the return value of XGetClassHint is not checked. ch is also initialised to {0}, which, I believe, is reduntant if XGetClassHint is successful. If XGetClassHint is successful, the structure pointers should also be valid, therefore a check for NULL would be redundant. The global