Re: [dwm] 4.7 is delayed

2007-11-10 Thread Szabolcs Nagy
On 11/8/07, Anselm R. Garbe [EMAIL PROTECTED] wrote: const char *tags[] = {tag1, tag2, ..}; Key keys[] = {{MODKEY,XK_1,view,tag1}, ..}; That's uglier than the KEYS macro. ok a second try (prepare for uglyness) #define MAXTAGLEN 10 const char tags[][MAXTAGLEN] = {tag1, work, www, ..}; Key

Re: [dwm] 4.7 is delayed

2007-11-10 Thread Anselm R. Garbe
On Sat, Nov 10, 2007 at 11:29:56AM +0200, Szabolcs Nagy wrote: On 11/8/07, Anselm R. Garbe [EMAIL PROTECTED] wrote: const char *tags[] = {tag1, tag2, ..}; Key keys[] = {{MODKEY,XK_1,view,tag1}, ..}; That's uglier than the KEYS macro. ok a second try (prepare for uglyness)

Re: [dwm] 4.7 is delayed

2007-11-08 Thread Szabolcs Nagy
On 11/7/07, Anselm R. Garbe [EMAIL PROTECTED] wrote: The KEYS macro is still used, because there are references to tags-elements which can't be referenced in a static variable definition of the same scope-level, at least not with my gcc. I know that sucks, but I see no other possibility atm.

Re: [dwm] 4.7 is delayed

2007-11-08 Thread Anselm R. Garbe
On Thu, Nov 08, 2007 at 01:07:50PM +0100, Szabolcs Nagy wrote: On 11/7/07, Anselm R. Garbe [EMAIL PROTECTED] wrote: The KEYS macro is still used, because there are references to tags-elements which can't be referenced in a static variable definition of the same scope-level, at least not

Re: [dwm] 4.7 is delayed

2007-11-07 Thread A A
Hey Anselm! No hurry! I don't know what I would do without DWM!!! Thanks! Regards, -Al On 11/4/07, Anselm R. Garbe [EMAIL PROTECTED] wrote: Hi there, due to the change of the status text processing and the fact that Ritesh send me a note that he is going to review dwm, I delay it until

Re: [dwm] 4.7 is delayed

2007-11-05 Thread Ritesh Kumar
I have a few comments... Do you want to keep LENGTH(), seltags and prevtags in config.def.h? My configuration doesn't need them and I doubt if somebody else's will. I think now I understand your concern about my solution to the inputtext behavior. What do we do if we read in a string which has

Re: [dwm] 4.7 is delayed

2007-11-05 Thread Sander van Dijk
On Nov 5, 2007 11:01 AM, Ritesh Kumar [EMAIL PROTECTED] wrote: I have a few comments... Do you want to keep LENGTH(), seltags and prevtags in config.def.h? My configuration doesn't need them and I doubt if somebody else's will. I think prevtags doesn't belong in config.h at all, seltags is

Re: [dwm] 4.7 is delayed

2007-11-05 Thread Szabolcs Nagy
On 11/5/07, Sander van Dijk [EMAIL PROTECTED] wrote: On Nov 5, 2007 11:01 AM, Ritesh Kumar [EMAIL PROTECTED] wrote: I have a few comments... Do you want to keep LENGTH(), seltags and prevtags in config.def.h? My configuration doesn't need them and I doubt if somebody else's will. I

Re: [dwm] 4.7 is delayed

2007-11-05 Thread Sander van Dijk
On Nov 5, 2007 6:41 PM, Szabolcs Nagy [EMAIL PROTECTED] wrote: fwiw, i don't use prevtags at all, but those who use viewprevtags() may use it. I use viewprevtags() sometimes, but I don't think prevtags should be in config.h anyway. Prevtags contains the previously selected tags, and there

Re: [dwm] 4.7 is delayed

2007-11-04 Thread Antoni Grzymala
Anselm R. Garbe dixit (2007-11-04, 12:07): So there will be some time to investigate into the focus steeling issue as well. Cool, it still happens to me with Opera (as described in a thread with appropriate subject some months ago). Best, -- [a]

Re: [dwm] 4.7 is delayed

2007-11-04 Thread Enno Gottox Boland
Hi A minor issue in tip: Sometimes the status bar flickers. 2007/11/4, Antoni Grzymala [EMAIL PROTECTED]: Anselm R. Garbe dixit (2007-11-04, 12:07): So there will be some time to investigate into the focus steeling issue as well. Cool, it still happens to me with Opera (as described in a

Re: [dwm] 4.7 is delayed

2007-11-04 Thread Antoni Grzymala
Antoni Grzymala dixit (2007-11-04, 13:34): Anselm R. Garbe dixit (2007-11-04, 12:07): So there will be some time to investigate into the focus steeling issue as well. Cool, it still happens to me with Opera (as described in a thread with appropriate subject some months ago). This post

Re: [dwm] 4.7 is delayed

2007-11-04 Thread Anselm R. Garbe
On Sun, Nov 04, 2007 at 01:38:52PM +0100, Enno Gottox Boland wrote: Hi A minor issue in tip: Sometimes the status bar flickers. What does that mean? Now, it is possible that the status text area might grow/shrink depending on the bunch of data being read. For instance if you echo -n bla a

Re: [dwm] 4.7 is delayed

2007-11-04 Thread Szabolcs Nagy
just a very littele code style comment: in setmwfact i dont like the condition checking: ... if(NULL == arg) mwfact = MWFACT; else if(1 == sscanf(arg, %lf, delta)) { ... i prefer (variable == value) to (value == variable), i know that the later protects against accidental assignment (value

Re: [dwm] 4.7 is delayed

2007-11-04 Thread Szabolcs Nagy
here is how i'd do it diff -r 022da3fca625 dwm.c --- a/dwm.c Sun Nov 04 12:17:06 2007 +0100 +++ b/dwm.c Sun Nov 04 17:37:31 2007 +0100 @@ -303,7 +303,7 @@ buttonpress(XEvent *e) { Client *c; XButtonPressedEvent *ev = e-xbutton; - if(barwin == ev-window) { +

Re: [dwm] 4.7 is delayed

2007-11-04 Thread Anselm R. Garbe
On Sun, Nov 04, 2007 at 06:39:29PM +0200, Szabolcs Nagy wrote: here is how i'd do it I agree. We are old enough to not make such newbie mistakes. Regards, -- Anselm R. Garbe http://www.suckless.org/ GPG key: 0D73F361