Re: [dwm] make setlayout toggle

2008-11-20 Thread Claudio M. Alessi
On Wed, Nov 05, 2008 at 09:39:58AM +, Anselm R Garbe wrote: Ok, are there any concerns making this upstream again? (Yes I know, we had this already in earlier versions, by that time it was called togglelayout())... There were reasons for not toggling, basically it was confusing to toggle

Re: [dwm] make setlayout toggle

2008-11-20 Thread Anselm R Garbe
2008/11/20 Claudio M. Alessi [EMAIL PROTECTED]: On Wed, Nov 05, 2008 at 09:39:58AM +, Anselm R Garbe wrote: Ok, are there any concerns making this upstream again? (Yes I know, we had this already in earlier versions, by that time it was called togglelayout())... There were reasons for not

Re: [dwm] make setlayout toggle

2008-11-20 Thread Claudio M. Alessi
Definitively i do _not_ want to add such code in upstream. Claudio M. Alessi -- JID: [EMAIL PROTECTED] WWW: http://dinotte.teroristi.org

Re: [dwm] make setlayout toggle

2008-11-05 Thread Anselm R Garbe
2008/11/4 Neale Pickett [EMAIL PROTECTED]: yy [EMAIL PROTECTED] writes: After a quick look, I think the last check in the first if should be arg-v != lt[sellt^1] Yes, that's what it should have said. I wonder how it was working for me before, when I sent the code to the list. [cue

Re: [dwm] make setlayout toggle

2008-11-05 Thread Thayer Williams
On Wed, Nov 5, 2008 at 1:39 AM, Anselm R Garbe [EMAIL PROTECTED] wrote: Ok, are there any concerns making this upstream again? (Yes I know, we had this already in earlier versions, by that time it was called togglelayout())... There were reasons for not toggling, basically it was confusing to

Re: [dwm] make setlayout toggle

2008-11-05 Thread Donald Chai
On Wed, Nov 5, 2008 at 1:39 AM, Anselm R Garbe [EMAIL PROTECTED] wrote: Ok, are there any concerns making this upstream again? (Yes I know, we had this already in earlier versions, by that time it was called togglelayout())... There were reasons for not toggling, basically it was confusing to

Re: [dwm] make setlayout toggle

2008-11-05 Thread Neale Pickett
Donald Chai [EMAIL PROTECTED] writes: The proposed change would add inconsistency, unless if people want the second MOD+1 to jump to the previously selected set of tags or do some other weird thing. I think that would make more sense if all available layouts were shown at the top like the

Re: [dwm] make setlayout toggle

2008-11-05 Thread Thayer Williams
On Wed, Nov 5, 2008 at 6:39 PM, Neale Pickett [EMAIL PROTECTED] wrote: Donald Chai [EMAIL PROTECTED] writes: The proposed change would add inconsistency, unless if people want the second MOD+1 to jump to the previously selected set of tags or do some other weird thing. I think that would

Re: [dwm] make setlayout toggle

2008-11-04 Thread Niki Yoshiuchi
Nice! I can't wait to try this out, I constantly hit mod-m to try to switch out of monocle mode yet somehow I never thought to implement this feature... -Niki Yoshiuchi On Tue, Nov 4, 2008 at 12:13 PM, Neale Pickett [EMAIL PROTECTED] wrote: This simple modification to setlayout causes a

Re: [dwm] make setlayout toggle

2008-11-04 Thread Thayer Williams
On Tue, Nov 4, 2008 at 9:13 AM, Neale Pickett [EMAIL PROTECTED] wrote: This simple modification to setlayout causes a binding to toggle if it's already in the requested layout. Now Alt-M toggles in and out of Monocle, etc. I far prefer this behavior, YMMV. This is a great idea and one I

Re: [dwm] make setlayout toggle

2008-11-04 Thread Ross Mohn
On Tue, Nov 04, 2008 at 10:13:21AM -0700, Neale Pickett wrote: This simple modification to setlayout causes a binding to toggle if it's already in the requested layout. void setlayout(const Arg *arg) { sellt ^= 1; if(arg arg-v (arg-v != lt[sellt])) lt[sellt] = (Layout *)arg-v;

Re: [dwm] make setlayout toggle

2008-11-04 Thread yy
After a quick look, I think the last check in the first if should be arg-v != lt[sellt^1] -- - yiyus || JGL .

Re: [dwm] make setlayout toggle

2008-11-04 Thread Thayer Williams
That did the trick, thanks! On Tue, Nov 4, 2008 at 12:31 PM, yy [EMAIL PROTECTED] wrote: After a quick look, I think the last check in the first if should be arg-v != lt[sellt^1]

Re: [dwm] make setlayout toggle

2008-11-04 Thread Neale Pickett
yy [EMAIL PROTECTED] writes: After a quick look, I think the last check in the first if should be arg-v != lt[sellt^1] Yes, that's what it should have said. I wonder how it was working for me before, when I sent the code to the list. [cue twilight zone music] Here's what it should have