Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Sun, 19 May 2013 13:25:33 +0300 +#ifndef _LINUX_NET_LL_POLL_H +#define _LINUX_NET_LL_POLL_H +#ifdef CONFIG_INET_LL_RX_POLL Please put an empty line before the final ifdef test here. +static inline void sk_mark_ll(struct sock *sk,

[E1000-devel] [PATCH 1/4] e1000e: Remove duplicate assignment of default rx/tx ring size

2013-05-20 Thread Wei Yang
tx_ring/rx_ring size is assigned in function e1000_alloc_queues(), which is called by e1000_sw_init() in the early stage of e1000_probe(). This patch just remove the duplicate assignment of this default ring size value. Signed-off-by: Wei Yang weiy...@linux.vnet.ibm.com Reviewed-by: Gavin Shan

[E1000-devel] [PATCH 0/4] trivial clean up for e1000e driver

2013-05-20 Thread Wei Yang
Here is several trivial clean up for e1000e driver. Wei Yang (4): e1000e: Remove duplicate assignment of default rx/tx ring size e1000e: Use marco instead of digit for defining e1000_rx_desc_packet_split e1000e: Calculate the desc_len based on adapter type e1000e: Not initialize the

[E1000-devel] [PATCH 4/4] e1000e: Not initialize the e1000_ps_page array when packet-split is not used

2013-05-20 Thread Wei Yang
When packet split is not used, those fields are still initialized and memory is allocated for them. This patch check whether packet split is used and do the initialization base on the status. Signed-off-by: Wei Yang weiy...@linux.vnet.ibm.com --- drivers/net/ethernet/intel/e1000e/netdev.c |

[E1000-devel] [PATCH 2/4] e1000e: Use marco instead of digit for defining e1000_rx_desc_packet_split

2013-05-20 Thread Wei Yang
In structure e1000_rx_desc_packet_split, the size of wb.upper.length is defined by a digit. This may introduce some problem when the lenght is changed. This patch use the marco PS_PAGE_BUFFERS for the definition. And move the definition to hw.h. Signed-off-by: Wei Yang weiy...@linux.vnet.ibm.com

[E1000-devel] Supplying Polyamide 6( Nylon 6)

2013-05-20 Thread Ms Sophia
Dear Sirs : This is Ms Sophia . We are a leading PA chips mfg, locatedin a Chemical Tech Zone, Hebei, China . We have a strategic cooperation with Sinopec. Pls check our PA chips . 1. Name : PA6 Chips, Virgin resin 2. Package : 25/800 kg net bag,16-18 tons in a 20'FCL 3. Delivery :

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread David Miller
From: Joe Perches j...@perches.com Date: Mon, 20 May 2013 01:29:47 -0700 On Mon, 2013-05-20 at 00:54 -0700, David Miller wrote: From: Eliezer Tamir eliezer.ta...@linux.intel.com [] { struct socket *sock; + unsigned int poll_result; Please order local variable declarations

Re: [E1000-devel] [PATCH 1/4] e1000e: Remove duplicate assignment of default rx/tx ring size

2013-05-20 Thread Jeff Kirsher
On 05/20/2013 01:15 AM, Wei Yang wrote: tx_ring/rx_ring size is assigned in function e1000_alloc_queues(), which is called by e1000_sw_init() in the early stage of e1000_probe(). This patch just remove the duplicate assignment of this default ring size value. Signed-off-by: Wei Yang

Re: [E1000-devel] [PATCH 2/4] e1000e: Use marco instead of digit for defining e1000_rx_desc_packet_split

2013-05-20 Thread Jeff Kirsher
On 05/20/2013 01:15 AM, Wei Yang wrote: In structure e1000_rx_desc_packet_split, the size of wb.upper.length is defined by a digit. This may introduce some problem when the lenght is changed. This patch use the marco PS_PAGE_BUFFERS for the definition. And move the definition to hw.h.

Re: [E1000-devel] [PATCH 3/4] e1000e: Calculate the desc_len based on adapter type

2013-05-20 Thread Jeff Kirsher
On 05/20/2013 01:15 AM, Wei Yang wrote: desc_len represents the size of descriptor in rx_ring. There are two kinds of rx descriptors, e1000_rx_desc_packet_split(32 byte) and e1000_rx_desc_extended(16 byte). Different adapter will use different rx descriptors. When allocating the dma space

Re: [E1000-devel] [PATCH 4/4] e1000e: Not initialize the e1000_ps_page array when packet-split is not used

2013-05-20 Thread Jeff Kirsher
On 05/20/2013 01:15 AM, Wei Yang wrote: When packet split is not used, those fields are still initialized and memory is allocated for them. This patch check whether packet split is used and do the initialization base on the status. Signed-off-by: Wei Yang weiy...@linux.vnet.ibm.com ---

[E1000-devel] [PATCH v3 net-next 0/4] net: low latency Ethernet device polling

2013-05-20 Thread Eliezer Tamir
updated with the comments I got so far. Thanks, Eliezer -- AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently

[E1000-devel] [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread Eliezer Tamir
Adds a new ndo_ll_poll method and the code that supports and uses it. This method can be used by low latency applications to busy poll ethernet device queues directly from the socket code. The ip_low_latency_poll sysctl entry controls how many cycles to poll. Set to zero to disable.

[E1000-devel] [PATCH v3 net-next 2/4] tcp: add TCP support for low latency receive poll.

2013-05-20 Thread Eliezer Tamir
an example of how one could add support for ndo_ll_poll to TCP. Signed-off-by: Alexander Duyck alexander.h.du...@intel.com Signed-off-by: Jesse Brandeburg jesse.brandeb...@intel.com Tested-by: Willem de Bruijn will...@google.com Signed-off-by: Eliezer Tamir eliezer.ta...@linux.intel.com ---

[E1000-devel] [PATCH v3 net-next 4/4] ixgbe: add extra stats for ndo_ll_poll

2013-05-20 Thread Eliezer Tamir
Add additional statistics to the ixgbe driver for ndo_ll_poll Defined under LL_EXTENDED_STATS Signed-off-by: Alexander Duyck alexander.h.du...@intel.com Signed-off-by: Jesse Brandeburg jesse.brandeb...@intel.com Tested-by: Willem de Bruijn will...@google.com Signed-off-by: Eliezer Tamir

[E1000-devel] [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll

2013-05-20 Thread Eliezer Tamir
Add the ixgbe driver code implementing ndo_ll_poll. It should be easy for other drivers to do something similar in order to enable support for CONFIG_INET_LL_RX_POLL Signed-off-by: Alexander Duyck alexander.h.du...@intel.com Signed-off-by: Jesse Brandeburg jesse.brandeb...@intel.com Tested-by:

Re: [E1000-devel] [PATCH v2 net-next 0/4] net: low latency Ethernet device polling

2013-05-20 Thread Eliezer Tamir
On 19/05/2013 22:56, Or Gerlitz wrote: On Sun, May 19, 2013 at 10:25 PM, Eliezer Tamir eliezer.ta...@linux.intel.com wrote: On 19/05/2013 22:06, Or Gerlitz wrote: Last time you've placed a copy of the patchset in the rfc branch of git://github.com/jbrandeb/lls.**git

Re: [E1000-devel] [PATCH v3 net-next 2/4] tcp: add TCP support for low latency receive poll.

2013-05-20 Thread Eric Dumazet
On Mon, 2013-05-20 at 13:16 +0300, Eliezer Tamir wrote: +config INET_LL_TCP_POLL + bool Low Latency TCP Receive Poll + depends on INET_LL_RX_POLL + default n + ---help--- + TCP support for Low Latency TCP Queue Poll. + (For network cards that support this

Re: [E1000-devel] interface link goes down

2013-05-20 Thread Wyborny, Carolyn
-Original Message- From: ratheesh kannoth [mailto:ratheesh@gmail.com] Sent: Saturday, May 11, 2013 8:34 AM To: e1000-devel@lists.sourceforge.net Subject: [E1000-devel] interface link goes down Hi, driver = igb-3.3.6 hw-mac.type = e1000_82576 media type = copper

Re: [E1000-devel] [PATCH v3 net-next 2/4] tcp: add TCP support for low latency receive poll.

2013-05-20 Thread Eliezer Tamir
on 20/05/2013 16:49, Eric Dumazet wrote: On Mon, 2013-05-20 at 13:16 +0300, Eliezer Tamir wrote: +config INET_LL_TCP_POLL +bool Low Latency TCP Receive Poll +depends on INET_LL_RX_POLL +default n +---help--- + TCP support for Low Latency TCP Queue Poll. + (For

Re: [E1000-devel] [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread Eric Dumazet
On Mon, 2013-05-20 at 13:16 +0300, Eliezer Tamir wrote: Adds a new ndo_ll_poll method and the code that supports and uses it. This method can be used by low latency applications to busy poll ethernet device queues directly from the socket code. The ip_low_latency_poll sysctl entry controls how

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread Andi Kleen
diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt index f98ca63..cfcf0ea 100644 --- a/Documentation/networking/ip-sysctl.txt +++ b/Documentation/networking/ip-sysctl.txt @@ -19,6 +19,11 @@ ip_no_pmtu_disc - BOOLEAN Disable Path MTU

Re: [E1000-devel] [PATCH 2/4] e1000e: Use marco instead of digit for defining e1000_rx_desc_packet_split

2013-05-20 Thread Wei Yang
On Mon, May 20, 2013 at 02:37:29AM -0700, Jeff Kirsher wrote: On 05/20/2013 01:15 AM, Wei Yang wrote: In structure e1000_rx_desc_packet_split, the size of wb.upper.length is defined by a digit. This may introduce some problem when the lenght is changed. This patch use the marco

Re: [E1000-devel] [PATCH 1/4] e1000e: Remove duplicate assignment of default rx/tx ring size

2013-05-20 Thread Wei Yang
On Mon, May 20, 2013 at 02:37:16AM -0700, Jeff Kirsher wrote: On 05/20/2013 01:15 AM, Wei Yang wrote: tx_ring/rx_ring size is assigned in function e1000_alloc_queues(), which is called by e1000_sw_init() in the early stage of e1000_probe(). This patch just remove the duplicate assignment of

Re: [E1000-devel] [PATCH 4/4] e1000e: Not initialize the e1000_ps_page array when packet-split is not used

2013-05-20 Thread Wei Yang
On Mon, May 20, 2013 at 02:38:07AM -0700, Jeff Kirsher wrote: On 05/20/2013 01:15 AM, Wei Yang wrote: When packet split is not used, those fields are still initialized and memory is allocated for them. This patch check whether packet split is used and do the initialization base on the status.

Re: [E1000-devel] [PATCH 3/4] e1000e: Calculate the desc_len based on adapter type

2013-05-20 Thread Wei Yang
On Mon, May 20, 2013 at 02:37:48AM -0700, Jeff Kirsher wrote: On 05/20/2013 01:15 AM, Wei Yang wrote: desc_len represents the size of descriptor in rx_ring. There are two kinds of rx descriptors, e1000_rx_desc_packet_split(32 byte) and e1000_rx_desc_extended(16 byte). Different adapter will use

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Mon, 20 May 2013 12:39:59 +0300 On 20/05/2013 10:54, David Miller wrote: From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Sun, 19 May 2013 13:25:33 +0300 +#else /* CONFIG_INET_LL_RX_FLUSH */ + +#define sk_valid_ll(sk) 0

Re: [E1000-devel] [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Mon, 20 May 2013 08:29:24 -0700 Part of this information was in your 0/4 text, but it wont be included in the git tree. Yes it will, in the merge commit I make when I merge this stuff in.

Re: [E1000-devel] [PATCH v2 net-next 0/4] net: low latency Ethernet device polling

2013-05-20 Thread Jeff Kirsher
On Sun, 2013-05-19 at 22:20 +0300, Eliezer Tamir wrote: On 19/05/2013 22:06, Or Gerlitz wrote: On Sun, May 19, 2013 at 1:25 PM, Eliezer Tamir eliezer.ta...@linux.intel.com wrote: This is an updated version of the code we posted on February. Last time you've placed a copy of the patchset

Re: [E1000-devel] [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll

2013-05-20 Thread Andi Kleen
guys, so what is going here, you were asking to put this series in net-next, and you expect each other driver implementing this ndo to follow this undocumented hack? or maybe this code was just left here by mistake from previous implementations and just needed to be removed? please clarify.

Re: [E1000-devel] [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll

2013-05-20 Thread Or Gerlitz
On Mon, May 20, 2013 at 11:33 PM, Andi Kleen a...@firstfloor.org wrote: This is discussed in 0/x I am not with you, V3's cover letter is empty, and in V2's cover letter I don't see that -- AlienVault Unified Security

Re: [E1000-devel] [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll

2013-05-20 Thread Andi Kleen
On Mon, May 20, 2013 at 11:42:37PM +0300, Or Gerlitz wrote: On Mon, May 20, 2013 at 11:33 PM, Andi Kleen a...@firstfloor.org wrote: This is discussed in 0/x I am not with you, V3's cover letter is empty, and in V2's cover letter I don't see that It was here. Looks like Eliezer didn't

Re: [E1000-devel] [PATCH v2 net-next 0/4] net: low latency Ethernet device polling

2013-05-20 Thread Jesse Brandeburg
On Mon, May 20, 2013 at 1:09 PM, Jeff Kirsher jeffrey.t.kirs...@intel.comwrote: On Sun, 2013-05-19 at 22:20 +0300, Eliezer Tamir wrote: On 19/05/2013 22:06, Or Gerlitz wrote: On Sun, May 19, 2013 at 1:25 PM, Eliezer Tamir eliezer.ta...@linux.intel.com wrote: This is an updated version

Re: [E1000-devel] [PATCH v2 net-next 0/4] net: low latency Ethernet device polling

2013-05-20 Thread Brandeburg, Jesse
On Sun, 19 May 2013, Or Gerlitz wrote: On Sun, May 19, 2013 at 1:25 PM, Eliezer Tamir eliezer.ta...@linux.intel.com wrote: This is an updated version of the code we posted on February. Last time you've placed a copy of the patchset in the rfc branch of git://github.com/jbrandeb/lls.git -