Re: [E1000-devel] For the e1000e driver, ethtool is printing speed and duplex while link is not detected.

2012-07-20 Thread Jeff Kirsher
On Sat, 2012-07-21 at 00:27 +, Steven La wrote: Hello, I currently ran into this problem and had a fix for it. It will be great if someone take a look at it and let me know if there is anything wrong with the solution? Environment == Kernel Version:2.6.32 Driver

Re: [E1000-devel] [PATCH net-next 2/4] e1000: advertise transmit time stamping

2012-07-23 Thread Jeff Kirsher
Kirsher jeffrey.t.kirs...@intel.com Cc: e1000-devel@lists.sourceforge.net --- drivers/net/ethernet/intel/e1000/e1000_ethtool.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Acked-by: Jeff Kirsher jeffrey.t.kirs...@intel.com signature.asc Description: This is a digitally signed

Re: [E1000-devel] [PATCH net-next 3/4] e1000e: advertise transmit time stamping

2012-07-23 Thread Jeff Kirsher
Kirsher jeffrey.t.kirs...@intel.com Cc: e1000-devel@lists.sourceforge.net --- drivers/net/ethernet/intel/e1000e/ethtool.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Acked-by: Jeff Kirsher jeffrey.t.kirs...@intel.com signature.asc Description: This is a digitally signed message

Re: [E1000-devel] [PATCH] igb: correct hardware type (i210/i211) check in igb_loopback_test()

2012-07-31 Thread Jeff Kirsher
On Tue, 2012-07-31 at 22:23 +0200, Jesper Juhl wrote: On Wed, 25 Jul 2012, Wyborny, Carolyn wrote: -Original Message- From: Jesper Juhl [mailto:j...@chaosbits.net] Sent: Wednesday, July 25, 2012 12:06 PM To: linux-ker...@vger.kernel.org Cc: net...@vger.kernel.org;

Re: [E1000-devel] [PATCH] igb: correct hardware type (i210/i211) check in igb_loopback_test()

2012-07-31 Thread Jeff Kirsher
On Tue, 2012-07-31 at 23:19 +0200, Jesper Juhl wrote: On Tue, 31 Jul 2012, Jeff Kirsher wrote: On Tue, 2012-07-31 at 22:23 +0200, Jesper Juhl wrote: On Wed, 25 Jul 2012, Wyborny, Carolyn wrote: -Original Message- From: Jesper Juhl [mailto:j...@chaosbits.net

Re: [E1000-devel] [PATCH net-next] igb: add delay to allow igb loopback test to succeed on 8086:10c9

2012-08-01 Thread Jeff Kirsher
On Wed, 2012-08-01 at 13:44 +0200, Stefan Assmann wrote: Some 8086:10c9 NICs have a problem completing the ethtool loopback test. The result looks like this: ethtool -t eth1 The test result is FAIL The test extra info: Register test (offline) 0 Eeprom test(offline) 0

Re: [E1000-devel] [PATCH] ixgbe: using is_zero_ether_addr() to simplify the code

2012-08-26 Thread Jeff Kirsher
On Sun, 2012-08-26 at 08:53 +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Using is_zero_ether_addr() to simplify the code. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 3 +-- 1 file changed, 1

Re: [E1000-devel] ixgbe: added reg_ops file to debugfs

2012-09-18 Thread Jeff Kirsher
On Tue, 2012-09-18 at 15:17 +0300, Dan Carpenter wrote: Hello Catherine Sullivan, The patch 91fbd8f081e2: ixgbe: added reg_ops file to debugfs from Aug 10, 2012, leads to the following Smatch warnings: drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c:76 ixgbe_dbg_reg_ops_read() warn:

Re: [E1000-devel] [PATCH] ixgbe: convert to use simple_open()

2012-10-17 Thread Jeff Kirsher
On Wed, 2012-10-17 at 16:26 +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn This removes an open coded simple_open() function and replaces file operations references to the function with simple_open() instead. dpatch engine is used to auto generate this patch.

Re: [E1000-devel] [PATCH] RX initialization sequence fixed - enable RX after corresponding ring initialization only

2012-10-23 Thread Jeff Kirsher
On Fri, 2012-10-19 at 20:19 +0100, Richard Davies wrote: Jeff Kirsher wrote: Dmitry Fleytman wrote: Reported-by: Chris Webb chris.w...@elastichosts.com Reported-by: Richard Davies richard.dav...@elastichosts.com Signed-off-by: Dmitry Fleytman dmi...@daynix.com --- drivers/net

Re: [E1000-devel] [PATCH] ixgbe: reduce PTP rx path overhead

2012-10-25 Thread Jeff Kirsher
On Wed, 2012-10-24 at 17:17 +0200, Jiri Benc wrote: Hw timestamping code caused performance regression in ixgbe driver when the timestamping is not enabled. The culprit is IXGBE_READ_REG call in the rx path which is executed for every received skb. This call is not needed when the

Re: [E1000-devel] [PATCH] ixgbe: simple_open() can be used

2012-10-27 Thread Jeff Kirsher
On Sat, 2012-10-27 at 12:45 +0800, Fengguang Wu wrote: Generated by: scripts/coccinelle/api/simple_open.cocci Signed-off-by: Fengguang Wu fengguang...@intel.com --- drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c | 32 - 1 file changed, 2 insertions(+), 30 deletions(-)

Re: [E1000-devel] [PATCH] ixgbe: simple_open() can be used

2012-10-27 Thread Jeff Kirsher
On Sat, 2012-10-27 at 01:49 -0700, Jeff Kirsher wrote: On Sat, 2012-10-27 at 12:45 +0800, Fengguang Wu wrote: Generated by: scripts/coccinelle/api/simple_open.cocci Signed-off-by: Fengguang Wu fengguang...@intel.com --- drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c | 32

Re: [E1000-devel] [PATCH net-next] igb: make local functions static

2012-10-30 Thread Jeff Kirsher
On Mon, 2012-10-29 at 11:32 -0700, Stephen Hemminger wrote: Minor, a couple of functions had static prototypes but not actually declared static. Signed-off-by: Stephen Hemminger shemmin...@vyatta.com Thanks Stephen, I will add this to my queue. signature.asc Description: This is a

Re: [E1000-devel] [3.5/6.x][e1000e] - Regression - Unable to receive packets if MTU == 1500

2012-11-02 Thread Jeff Kirsher
On 11/01/2012 10:58 AM, Shawn Starr wrote: Hello network driver folks, I recently decided to reinstall my Lenovo W500 laptop and found I wasn't able to get DHCP leases, I wasn't able to install over PXE (when getting the IP a second time within the OS) Fedora is currently using

Re: [E1000-devel] [PATCH] net/ethernet/intel/ixgbe/ixgbe_debugfs.c: fix error handling in ixgbe_dbg_reg_ops_read().

2012-11-15 Thread Jeff Kirsher
On Fri, 2012-11-16 at 04:26 +0100, Cyril Roelandt wrote: copy_to_user() cannot return a negative value: it returns the number of bytes that could not be copied. Return -EFAULT on failure rather than the number of bytes that could not be copied, as this seems more standard.

Re: [E1000-devel] [PATCH] igbvf: fix VLAN tag masking in rx code path

2012-11-16 Thread Jeff Kirsher
On Fri, 2012-11-16 at 08:51 -0600, Chris Friesen wrote: From: Chris Friesen chris.frie...@genband.com In igbvf_receive_skb() the VLAN tag is big-endian while the mask is cpu-endian. We need to convert both to common endianness before applying the mask. Signed-off-by: Chris Friesen

Re: [E1000-devel] [PATCH net-next 0/2] igb: fixes and improvements for irq fallback

2012-12-03 Thread Jeff Kirsher
On 12/03/2012 05:14 AM, Stefan Assmann wrote: The interrupt fallback code should utilize the same code that's used for normal setup instead of duplicating it. It also has some shortcomings when it comes to situations where for some reason request_irq() fails to allocate vectors for MSI-X.

Re: [E1000-devel] Information needed regarding igb driver

2012-12-04 Thread Jeff Kirsher
On Sun, 2012-12-02 at 09:39 +0530, abhinay aruva wrote: Hi All, I am working on developing software for a networking company. We are facing issue with igb driver code implemented on our ethernet interface We have connected two ethernet interfaces which are on two different ATCA

Re: [E1000-devel] [PATCH 07/12] e1000e: Use standard #defines for PCIe Capability ASPM fields

2012-12-05 Thread Jeff Kirsher
coincidentally match the actual register bits. PCIE_LINK_STATE_CLKPM, also part of that interface, does not match the register bit. Signed-off-by: Bjorn Helgaas bhelg...@google.com CC: Jeff Kirsher jeffrey.t.kirs...@intel.com CC: Jesse Brandeburg jesse.brandeb...@intel.com CC: Bruce Allan

Re: [E1000-devel] [PATCH 07/12] e1000e: Use standard #defines for PCIe Capability ASPM fields

2012-12-05 Thread Jeff Kirsher
On Wed, 2012-12-05 at 15:07 -0700, Bjorn Helgaas wrote: On Wed, Dec 5, 2012 at 3:05 PM, Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: On Wed, 2012-12-05 at 13:57 -0700, Bjorn Helgaas wrote: Use the standard #defines for PCIe Capability ASPM fields. Previously we used

Re: [E1000-devel] ixgbe: pci_get_device() call without counterpart call of pci_dev_put()

2012-12-09 Thread Jeff Kirsher
On 12/09/2012 01:47 AM, Elena Gurevich wrote: Hi all, I am pioneer in linux device drivers here and using Intel 82599 NIC as reference model, During investigation to drivers sources I found the suspicious code: Is code sequence (1) and (2) the possible device reference count leakage

Re: [E1000-devel] [PATCH 2/2] e1000e: display a warning message when SmartSpeed works

2013-01-15 Thread Jeff Kirsher
On Wed, 2013-01-16 at 11:23 +0900, Koki Sanagi wrote: Current e1000e driver doesn't tell nothing when Link Speed is downgraded due to SmartSpeed. As a result, users suspect that there is something wrong with NIC. If the cause of it is SmartSpeed, there is no means to replace NIC. This

Re: [E1000-devel] [PATCH 2/2] e1000e: display a warning message when SmartSpeed works

2013-01-16 Thread Jeff Kirsher
On Wed, 2013-01-16 at 13:59 +0100, Bjørn Mork wrote: Koki Sanagi sanagi.k...@jp.fujitsu.com writes: + if (phy-speed_downgraded) + netdev_warn(netdev, Link Speed was + downgraded by SmartSpeed\n); + Could

[E1000-devel] [net-next 02/14] e1000e: Use standard #defines for PCIe Capability ASPM fields

2013-01-17 Thread Jeff Kirsher
-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- drivers/net/ethernet/intel/e1000e/netdev.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index 05538e6..bf2c84cf 100644 --- a/drivers

[E1000-devel] [net-next 02/12] e1000e: Use standard #defines for PCIe Capability ASPM fields

2013-01-18 Thread Jeff Kirsher
-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- drivers/net/ethernet/intel/e1000e/netdev.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index 05538e6..bf2c84cf 100644 --- a/drivers

Re: [E1000-devel] [PATCH net-next] igb: increase timeout for ethtool offline self-test

2013-02-01 Thread Jeff Kirsher
On Fri, 2013-02-01 at 16:21 +0100, Stefan Assmann wrote: On several machines with i350 adapters the ethtool offline self-test sometimes fails. This happens because link auto negotiation may take longer than the timeout of 4 seconds. Increasing the timeout by 1 seconds resolves the issue.

Re: [E1000-devel] [ker...@linuxace.com: 3.7 networking regression - bisected]

2013-02-20 Thread Jeff Kirsher
On Tue, 2013-02-19 at 08:58 -0800, Phil Oester wrote: Hi Jeff - Eric Dumazet suggested I send this to you, as he believes it to be a driver bug. Phil Oester Thanks! Added the e1000-devel mailing list as well as Bruce Allan (e1000e driver maintainer). - Forwarded message from

Re: [E1000-devel] [PATCH] ixgbevf: don't release the soft entries

2013-02-28 Thread Jeff Kirsher
On Thu, 2013-02-28 at 15:02 +0800, xunleer wrote: This patch fix an oops issue caused by NULL pointer. The call stack may be like this: [a04dae0b] ixgbevf_down+0x10b/0x300 [ixgbevf] [a04dc6bd] ixgbevf_open+0x27d/0x2b0 [ixgbevf] [813866b7] __dev_open+0xa7/0x100

Re: [E1000-devel] [PATCH] [resend] ixgbevf: don't release the soft entries

2013-03-01 Thread Jeff Kirsher
On Fri, 2013-03-01 at 11:42 +0800, xunleer wrote: When the ixgbevf driver is opened the request to allocate MSIX irq vectors may fail. In that case the driver will call ixgbevf_down() which will call ixgbevf_irq_disable() to clear the HW interrupt registers and calls synchronize_irq() using

Re: [E1000-devel] [PATCH RESEND 2/3] e1000e: fix runtime power management transitions

2013-03-04 Thread Jeff Kirsher
(like for WoL) as result pci_prepare_to_sleep() would setup wakeup without special actions like custom 'enable_wakeup' sign. Signed-off-by: Konstantin Khlebnikov khlebni...@openvz.org Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com Cc: e1000-devel@lists.sourceforge.net Cc: Jeff Kirsher

Re: [E1000-devel] [PATCH RESEND 1/3] e1000e: fix pci-device enable-counter balance

2013-03-04 Thread Jeff Kirsher
23606cf5d1192c2b17912cb2ef6e62f9b11de133 (e1000e / PCI / PM: Add basic runtime PM support (rev. 4)) in v2.6.35 Signed-off-by: Konstantin Khlebnikov khlebni...@openvz.org Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com Cc: e1000-devel@lists.sourceforge.net Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com

Re: [E1000-devel] Uhhuh. NMI received for unknown reason 2c on CPU 0.

2013-03-05 Thread Jeff Kirsher
On Tue, 2013-03-05 at 10:58 +0100, Borislav Petkov wrote: On Tue, Mar 05, 2013 at 10:42:17AM +0100, Jiri Slaby wrote: On 03/05/2013 01:16 AM, Bjorn Helgaas wrote: [+cc e1000-devel, Jeff, Bruce] On Mon, Mar 4, 2013 at 2:50 PM, Borislav Petkov b...@alien8.de wrote: On Fri, Feb 15,

Re: [E1000-devel] Uhhuh. NMI received for unknown reason 2c on CPU 0.

2013-03-05 Thread Jeff Kirsher
On Tue, 2013-03-05 at 10:42 +0100, Jiri Slaby wrote: On 03/05/2013 01:16 AM, Bjorn Helgaas wrote: [+cc e1000-devel, Jeff, Bruce] On Mon, Mar 4, 2013 at 2:50 PM, Borislav Petkov b...@alien8.de wrote: On Fri, Feb 15, 2013 at 10:16:41AM +0100, Borislav Petkov wrote: So it looks Bjorn has

Re: [E1000-devel] Uhhuh. NMI received for unknown reason 2c on CPU 0.

2013-03-05 Thread Jeff Kirsher
On Tue, 2013-03-05 at 11:14 +0100, Borislav Petkov wrote: On Tue, Mar 05, 2013 at 02:02:48AM -0800, Jeff Kirsher wrote: They are in my queue of e1000e patches for net and are being testing currently. I should be able to push them upstream this week. Right, if you'd like me to run them

Re: [E1000-devel] Uhhuh. NMI received for unknown reason 2c on CPU 0.

2013-03-05 Thread Jeff Kirsher
On Tue, 2013-03-05 at 12:27 +0100, Borislav Petkov wrote: On Tue, Mar 05, 2013 at 02:29:01AM -0800, Jeff Kirsher wrote: On Tue, 2013-03-05 at 11:14 +0100, Borislav Petkov wrote: On Tue, Mar 05, 2013 at 02:02:48AM -0800, Jeff Kirsher wrote: They are in my queue of e1000e patches

Re: [E1000-devel] [Bug 55131] New: 10Gbit ixgbe driver (?) stalls kernel

2013-03-12 Thread Jeff Kirsher
On Tue, 2013-03-12 at 16:03 -0700, Andrew Morton wrote: On Tue, 12 Mar 2013 22:53:46 + (UTC) bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.kernel.org/show_bug.cgi?id=55131 Some business for you folks ;) Thanks Andrew! signature.asc Description: This is a digitally

Re: [E1000-devel] [patch] ixgbe: in shutdown, do netif_running() under rtnl_lock

2013-03-13 Thread Jeff Kirsher
On Fri, 2013-03-08 at 14:05 -0800, akepner wrote: During shutdown it's possible for __dev_close() (which holds rtnl_lock) to clear the __LINK_STATE_START bit, and for ixgbe to then read that bit (without holding rtnl_lock), and then not fail to free irqs, etc. The result is a crash like

Re: [E1000-devel] [PATCH 0/3] net/intel: Add missing calls to dma_mapping_error

2013-03-19 Thread Jeff Kirsher
On Sat, 2013-03-16 at 11:32 +0100, Christoph Paasch wrote: After dma_map_single/page, dma_mapping_error must be called. Christoph Paasch (3): e1000: ethtool: Add missing dma_mapping_error-call in e1000_setup_desc_rings ixgb: Add missing dma_mapping_error-call in

Re: [E1000-devel] [PATCH 1/3] e1000: ethtool: Add missing dma_mapping_error-call in e1000_setup_desc_rings

2013-03-19 Thread Jeff Kirsher
On Sat, 2013-03-16 at 11:32 +0100, Christoph Paasch wrote: After dma_map_single, dma_mapping_error must be called. Signed-off-by: Christoph Paasch christoph.paa...@uclouvain.be --- drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 14 +++--- 1 file changed, 11 insertions(+), 3

Re: [E1000-devel] [PATCH] igb: make sensor info static

2013-03-19 Thread Jeff Kirsher
On Sat, 2013-03-16 at 09:56 -0700, Stephen Hemminger wrote: Trivial sparse warning. Signed-off-by: Stephen Hemminger step...@networkplumber.org Thanks Stephen, it has been added to my queue signature.asc Description: This is a digitally signed message part

Re: [E1000-devel] [PATCH] igb: fix PHC stopping on max freq

2013-03-19 Thread Jeff Kirsher
On Tue, 2013-03-19 at 15:42 +0100, Jiri Benc wrote: For 82576 MAC type, max_adj is reported as 10 ppb. However, if this value is passed to igb_ptp_adjfreq_82576, incvalue overflows out of INCVALUE_82576_MASK, resulting in setting of zero TIMINCA.incvalue, stopping the PHC (instead of

Re: [E1000-devel] [PATCH 3/3] e1000e: Add missing dma_mapping_error-call in e1000_alloc_jumbo_rx_buffers

2013-03-19 Thread Jeff Kirsher
On Sat, 2013-03-16 at 11:32 +0100, Christoph Paasch wrote: After dma_map_page, dma_mapping_error must be called. It seems safe to not free the skb/page allocated in this function, as the skb/page can be reused later. Signed-off-by: Christoph Paasch christoph.paa...@uclouvain.be ---

Re: [E1000-devel] [PATCH net-next] e100: Add dma mapping error check

2013-04-03 Thread Jeff Kirsher
: Josh Boyer jwbo...@redhat.com CC: David S. Miller da...@davemloft.net CC: Jeff Kirsher jeffrey.t.kirs...@intel.com CC: e1000-devel@lists.sourceforge.net --- drivers/net/ethernet/intel/e100.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) Thanks

Re: [E1000-devel] [PATCH net-next] ixgbe: Remove unnecessary #ifdef CONFIG_DEBUG_FS tests

2013-04-08 Thread Jeff Kirsher
On Sun, 2013-04-07 at 18:27 -0700, Joe Perches wrote: Add some empty static inlines instead to make the code more readable. Signed-off-by: Joe Perches j...@perches.com --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 5 + drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10

[E1000-devel] [net] e100: Add dma mapping error check

2013-04-10 Thread Jeff Kirsher
...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- drivers/net/ethernet/intel/e100.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c index ec800b0

Re: [E1000-devel] [PATCH net] e1000e: fix numeric overflow in phc settime method.

2013-04-22 Thread Jeff Kirsher
On Mon, 2013-04-22 at 15:53 +0200, Richard Cochran wrote: The PTP Hardware Clock settime function in the e1000e driver computes nanoseconds from a struct timespec. The code converts the seconds field .tv_sec by multiplying it with NSEC_PER_SEC. However, both operands are of type long,

Re: [E1000-devel] [PATCH net] e1000e: fix numeric overflow in phc settime method.

2013-04-22 Thread Jeff Kirsher
On Mon, 2013-04-22 at 19:56 +0200, Richard Cochran wrote: On Mon, Apr 22, 2013 at 10:53:22AM -0700, Jeff Kirsher wrote: Thanks Richard, I will add this to my queue. If it doesn't make it into 3.9, please submit this one to stable, too. Thanks, Richard Got it, will do

[E1000-devel] [Fwd: e1000: TX Unit hangs [PATCH]]

2013-05-01 Thread Jeff Kirsher
Forwarded Message From: Rob madca...@gmail.com Subject: e1000: TX Unit hangs [PATCH] Date: Tue, 5 Mar 2013 18:55:48 -0500 The e1000 driver in the latest kernel tree still experiences TX unit hangs on some amd64 systems, particularly the SunFire x4500. To work around this, I've

Re: [E1000-devel] [PATCH 1/4] e1000e: Remove duplicate assignment of default rx/tx ring size

2013-05-20 Thread Jeff Kirsher
On 05/20/2013 01:15 AM, Wei Yang wrote: tx_ring/rx_ring size is assigned in function e1000_alloc_queues(), which is called by e1000_sw_init() in the early stage of e1000_probe(). This patch just remove the duplicate assignment of this default ring size value. Signed-off-by: Wei Yang

Re: [E1000-devel] [PATCH 2/4] e1000e: Use marco instead of digit for defining e1000_rx_desc_packet_split

2013-05-20 Thread Jeff Kirsher
On 05/20/2013 01:15 AM, Wei Yang wrote: In structure e1000_rx_desc_packet_split, the size of wb.upper.length is defined by a digit. This may introduce some problem when the lenght is changed. This patch use the marco PS_PAGE_BUFFERS for the definition. And move the definition to hw.h.

Re: [E1000-devel] [PATCH 3/4] e1000e: Calculate the desc_len based on adapter type

2013-05-20 Thread Jeff Kirsher
On 05/20/2013 01:15 AM, Wei Yang wrote: desc_len represents the size of descriptor in rx_ring. There are two kinds of rx descriptors, e1000_rx_desc_packet_split(32 byte) and e1000_rx_desc_extended(16 byte). Different adapter will use different rx descriptors. When allocating the dma space

Re: [E1000-devel] [PATCH 4/4] e1000e: Not initialize the e1000_ps_page array when packet-split is not used

2013-05-20 Thread Jeff Kirsher
On 05/20/2013 01:15 AM, Wei Yang wrote: When packet split is not used, those fields are still initialized and memory is allocated for them. This patch check whether packet split is used and do the initialization base on the status. Signed-off-by: Wei Yang weiy...@linux.vnet.ibm.com ---

Re: [E1000-devel] [PATCH v2 net-next 0/4] net: low latency Ethernet device polling

2013-05-20 Thread Jeff Kirsher
On Sun, 2013-05-19 at 22:20 +0300, Eliezer Tamir wrote: On 19/05/2013 22:06, Or Gerlitz wrote: On Sun, May 19, 2013 at 1:25 PM, Eliezer Tamir eliezer.ta...@linux.intel.com wrote: This is an updated version of the code we posted on February. Last time you've placed a copy of the patchset

Re: [E1000-devel] [PATCH net-next 1/4] igb: refactor and simplify time sync interrupt handling

2013-05-27 Thread Jeff Kirsher
On Mon, 2013-05-27 at 11:21 +0200, Richard Cochran wrote: The code that handles the time sync interrupt is repeated in three different places. This patch refactors the identical code blocks into a single helper function. Also, reading the TSICR register already acknowledges the time sync

Re: [E1000-devel] [PATCH net-next 2/4] igb: add more register definitions for time sync functions.

2013-05-27 Thread Jeff Kirsher
On Mon, 2013-05-27 at 11:21 +0200, Richard Cochran wrote: This patch adds missing definitions needed for implementing the auxiliary time sync functions. Signed-off-by: Richard Cochran richardcoch...@gmail.com --- drivers/net/ethernet/intel/igb/e1000_defines.h | 68

Re: [E1000-devel] [PATCH net-next 4/4] igb: enable auxiliary PHC functions for the i210.

2013-05-27 Thread Jeff Kirsher
On Mon, 2013-05-27 at 11:21 +0200, Richard Cochran wrote: The i210 device offers a number of special PTP Hardware Clock features on the Software Defined Pins (SDPs). This patch adds support for three of the possible functions, namely time stamping external events, a periodic output signal,

Re: [E1000-devel] [PATCH net-next 3/4] igb: do not clobber the TSAUXC bits on reset.

2013-05-27 Thread Jeff Kirsher
On Mon, 2013-05-27 at 11:21 +0200, Richard Cochran wrote: The TSAUXC register has a number of different bits, one of which disables the main clock function. Previously, the clock was re-enabled by clearing the entire register. This patch changes the code to preserve the values of the other

Re: [E1000-devel] [PATCH 6/7] NET: intel/ixgbe/ixgbe_main.c: fix 32-bit DMA mask handling

2013-06-10 Thread Jeff Kirsher
On Tue, 2013-06-11 at 00:14 +0100, Russell King wrote: The fallback to 32-bit DMA mask is rather odd: if (!dma_set_mask(pdev-dev, DMA_BIT_MASK(64)) !dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(64))) { pci_using_dac = 1; } else {

Re: [E1000-devel] [PATCH 3/7] NET: intel/igb/igb_main.c: fix 32-bit DMA mask handling

2013-06-10 Thread Jeff Kirsher
On Tue, 2013-06-11 at 00:11 +0100, Russell King wrote: The fallback to 32-bit DMA mask is rather odd: err = dma_set_mask(pdev-dev, DMA_BIT_MASK(64)); if (!err) { err = dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(64)); if (!err)

Re: [E1000-devel] [PATCH 5/7] NET: intel/ixgb/ixgb_main.c: fix 32-bit DMA mask handling

2013-06-10 Thread Jeff Kirsher
On Tue, 2013-06-11 at 00:13 +0100, Russell King wrote: The fallback to 32-bit DMA mask is rather odd: err = dma_set_mask(pdev-dev, DMA_BIT_MASK(64)); if (!err) { err = dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(64)); if (!err)

Re: [E1000-devel] [PATCH 7/7] NET: intel/ixgbevf/ixgbevf_main.c: fix 32-bit DMA mask handling

2013-06-10 Thread Jeff Kirsher
On Tue, 2013-06-11 at 00:15 +0100, Russell King wrote: The fallback to 32-bit DMA mask is rather odd: if (!dma_set_mask(pdev-dev, DMA_BIT_MASK(64)) !dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(64))) { pci_using_dac = 1; } else {

[E1000-devel] [net-next 3/8] i40e: driver ethtool core

2013-06-13 Thread Jeff Kirsher
-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 1198 1 file changed, 1198 insertions

[E1000-devel] [net-next 2/8] i40e: transmit, receive, and napi

2013-06-13 Thread Jeff Kirsher
-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 1838 +++ 1 file changed, 1838 insertions

[E1000-devel] [net-next 8/8] i40e: include i40e in kernel proper

2013-06-13 Thread Jeff Kirsher
...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- Documentation/networking/00-INDEX | 2 + Documentation/networking/i40e.txt | 115 + MAINTAINERS

[E1000-devel] [net-next 4/8] i40e: driver core headers

2013-06-13 Thread Jeff Kirsher
...@intel.com Signed-off-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- drivers/net/ethernet/intel/i40e/i40e.h | 526

[E1000-devel] [Fwd: [net-next 0/8][pull request] Intel Wired LAN Driver Updates]

2013-06-13 Thread Jeff Kirsher
Forwarded Message From: Jeff Kirsher jeffrey.t.kirs...@intel.com To: da...@davemloft.net Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com, net...@vger.kernel.org, go...@redhat.com, sassm...@redhat.com Subject: [net-next 0/8][pull request] Intel Wired LAN Driver Updates Date: Thu, 13

Re: [E1000-devel] [RFC 0/7] Fixing dma mask setting in various network drivers

2013-06-17 Thread Jeff Kirsher
On Mon, 2013-06-17 at 15:01 +0100, Russell King - ARM Linux wrote: On Tue, Jun 11, 2013 at 11:12:30AM -0700, Jesse Brandeburg wrote: This is my proposed change to the intel drivers. Comments? + if (!dma_set_mask(pdev-dev, DMA_BIT_MASK(64))) { + pci_using_dac = true; +

Re: [E1000-devel] [PATCH] drivers/net: igb: release rtnl_lock on error path

2013-07-08 Thread Jeff Kirsher
On Mon, 2013-07-08 at 11:22 +0400, Konstantin Khlebnikov wrote: This adds missing rtnl_unlock() Signed-off-by: Konstantin Khlebnikov khlebni...@openvz.org Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com Cc: e1000-devel@lists.sourceforge.net --- drivers/net/ethernet/intel/igb/igb_main.c

Re: [E1000-devel] [PATCH] e100: dump small buffers via %*phC

2013-07-31 Thread Jeff Kirsher
On Wed, 2013-07-31 at 15:20 +0300, Andy Shevchenko wrote: On Fri, 2013-07-26 at 04:12 -0700, Jeff Kirsher wrote: On Thu, 2013-07-25 at 14:24 +0300, Andy Shevchenko wrote: There is nice specifier in kernel that allows us to print small buffers easily. Signed-off-by: Andy Shevchenko

Re: [E1000-devel] /sys/module/pcie_aspm/parameters/policy not writable?

2013-08-01 Thread Jeff Kirsher
On Wed, 2013-07-10 at 13:57 -0600, Bjorn Helgaas wrote: [+cc Jeff, Jesse, et al, e1000-devel] Holy cow, you guys have a lot of folks listed in MAINTAINERS for Intel drivers :) This is an ASPM question, if that helps narrow down the folks interested. Bruce Allan is the e1000e maintainer, I

Re: [E1000-devel] [PATCH 3/4] e1000e: Calculate the desc_len based on adapter type

2013-08-22 Thread Jeff Kirsher
Validation ran into issues with this patch and because we could not apply patch 4 in this series without patch 3, I have had to drop patch 3 4 from my queue. Here is what validation had to say about this patch... Aaron Brown wrote: This patch introduces a call trace when the interface is up

[E1000-devel] [net-next v2 3/8] i40e: driver ethtool core

2013-08-22 Thread Jeff Kirsher
-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial submittal v2: changes due

[E1000-devel] [net-next v2 8/8] i40e: include i40e in kernel proper

2013-08-22 Thread Jeff Kirsher
...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial submittal v2: no significant changes --- Documentation

[E1000-devel] [net-next v2 4/8] i40e: driver core headers

2013-08-22 Thread Jeff Kirsher
...@intel.com Signed-off-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial

[E1000-devel] [net-next v2 2/8] i40e: transmit, receive, and napi

2013-08-22 Thread Jeff Kirsher
-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial submittal v2: changes due to netdev

[E1000-devel] [Fwd: Where can I find the detail discription of IXGBE_CIAA and IXGBE_CIAD?]

2013-08-22 Thread Jeff Kirsher
Forwarded Message From: Jason Shi sh...@arraynetworks.com.cn Reply-to: shidj sh...@arraynetworks.com.cn To: jeffrey.t.kirsher jeffrey.t.kirs...@intel.com Subject: Where can I find the detail discription of IXGBE_CIAA and IXGBE_CIAD? Date: Fri, 23 Aug 2013 10:06:14 +0800 Dear

Re: [E1000-devel] [PATCH net-next] drivers:net: Convert dma_alloc_coherent(...__GFP_ZERO) to dma_zalloc_coherent

2013-08-27 Thread Jeff Kirsher
inline dma_zalloc_coherent and add just one use of __GFP_ZERO instead. Trivially reduces the size of the existing uses of dma_zalloc_coherent. Realign arguments as appropriate. Signed-off-by: Joe Perches j...@perches.com Acked-by: Jeff Kirsher jeffrey.t.kirs...@intel.com signature.asc

[E1000-devel] [net-next v3 8/8] i40e: include i40e in kernel proper

2013-08-30 Thread Jeff Kirsher
...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial submittal v2: no significant changes --- Documentation

[E1000-devel] [net-next v3 3/8] i40e: driver ethtool core

2013-08-30 Thread Jeff Kirsher
-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial submittal v2: changes due

[E1000-devel] [net-next v3 2/8] i40e: transmit, receive, and napi

2013-08-30 Thread Jeff Kirsher
-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial submittal v2: changes due to netdev

[E1000-devel] [net-next v3 4/8] i40e: driver core headers

2013-08-30 Thread Jeff Kirsher
...@intel.com Signed-off-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial

Re: [E1000-devel] [PATCH 0/4] i40e: Neatening and object size reductions

2013-08-30 Thread Jeff Kirsher
On Fri, 2013-08-30 at 16:06 -0700, Joe Perches wrote: Just some potential cleanings... Joe Perches (4): i40e: Whitespace cleaning i40e: Add and use pf_level i40e: pf_level remove %s: ... __func__ i40e: Convert pf_level macros to functions Thanks Joe, I will add these to my queue.

Re: [E1000-devel] [PATCH] i40e: Fix 32 bit shift compilation warnings

2013-08-30 Thread Jeff Kirsher
On Fri, 2013-08-30 at 18:47 -0700, Joe Perches wrote: When dma_addr_t is a 32 bit value, 32 emits compiler warnings Use ((addr16) 16) to avoid this. I presume the macro should actually use the kernel.h macro upper_32_bits() eventually. Signed-off-by: Joe Perches j...@perches.com ---

[E1000-devel] [net-next v4 3/8] i40e: driver ethtool core

2013-09-04 Thread Jeff Kirsher
-by: Shannon Nelson shannon.nel...@intel.com Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial submittal v2: changes due

[E1000-devel] [net-next v4 4/8] i40e: driver core headers

2013-09-04 Thread Jeff Kirsher
...@intel.com Signed-off-by: Shannon Nelson shannon.nel...@intel.com Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial

[E1000-devel] [net-next 2/8] i40e: transmit, receive, and NAPI

2013-09-05 Thread Jeff Kirsher
-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial submittal v2: changes due to netdev

[E1000-devel] [net-next 0/8][pull request] Intel Wired LAN Driver Updates

2013-09-05 Thread Jeff Kirsher
This series implements the new i40e driver for Intel's upcoming Intel(R) Ethernet Controller XL710 Family of devices. V1: initial send V2: each patch has individual comments, in general, feedback from the list was applied and addressed. Many changes due to internal review and coding as

[E1000-devel] [net-next 4/8] i40e: driver core headers

2013-09-05 Thread Jeff Kirsher
...@intel.com Signed-off-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial

[E1000-devel] [net-next 3/8] i40e: driver ethtool core

2013-09-05 Thread Jeff Kirsher
-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial submittal v2: changes due

[E1000-devel] [net-next v5 3/8] i40e: driver ethtool core

2013-09-06 Thread Jeff Kirsher
-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial submittal v2: changes due

[E1000-devel] [net-next v5 2/8] i40e: transmit, receive, and NAPI

2013-09-06 Thread Jeff Kirsher
-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial submittal v2: changes due to netdev

[E1000-devel] [net v6 8/8] i40e: include i40e in kernel proper

2013-09-06 Thread Jeff Kirsher
Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial submittal v2: no significant changes v3

[E1000-devel] [net v6 0/8][pull request] Intel Wired LAN Driver Updates

2013-09-06 Thread Jeff Kirsher
This series implements the new i40e driver for Intel's upcoming Intel(R) Ethernet Controller XL710 Family of devices. V1: initial send V2: each patch has individual comments, in general, feedback from the list was applied and addressed. Many changes due to internal review and coding as

[E1000-devel] [net 8/8] i40e: include i40e in kernel proper

2013-09-11 Thread Jeff Kirsher
Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial submittal v2: no significant changes v3

[E1000-devel] [net v7 0/8][pull request] Intel Wired LAN Driver Updates

2013-09-11 Thread Jeff Kirsher
This series implements the new i40e driver for Intel's upcoming Intel(R) Ethernet Controller XL710 Family of devices. V7: many changes from a few comments: use linux errno types change I40E_SUCCESS to 0, standardize returns change s32 return values to int use void return values

[E1000-devel] [net 4/8] i40e: driver core headers

2013-09-11 Thread Jeff Kirsher
...@intel.com Signed-off-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial

[E1000-devel] [net 3/8] i40e: driver ethtool core

2013-09-11 Thread Jeff Kirsher
-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial submittal v2: changes due

[E1000-devel] [net 2/8] i40e: transmit, receive, and NAPI

2013-09-11 Thread Jeff Kirsher
-by: Shannon Nelson shannon.nel...@intel.com CC: PJ Waskiewicz peter.p.waskiewicz...@intel.com CC: e1000-devel@lists.sourceforge.net Tested-by: Kavindya Deegala kavindya.s.deeg...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- v1: this is the initial submittal v2: changes due to netdev

Re: [E1000-devel] [net 8/8] i40e: include i40e in kernel proper

2013-09-11 Thread Jeff Kirsher
On Wed, 2013-09-11 at 05:20 -0700, Joe Perches wrote: On Wed, 2013-09-11 at 02:50 -0700, Jeff Kirsher wrote: New driver build option is CONFIG_I40E diff --git a/Documentation/networking/00-INDEX b/Documentation/networking/00-INDEX [] +i40e.txt + - README for the Intel Ethernet

<    1   2   3   4   >