Konstantin Khlebnikov wrote:
> Konstantin Khlebnikov wrote:
>> Seems like it's unrelated to e1000e driver itself, because I tried to
>> revert all it's changes down to 3.6 one by one and it does not help.
Ouch, 3.6 also affected, seems like I was more lucky at that tim
Bus Muster unconditionally and doesn't changes enable_cnt.
Signed-off-by: Konstantin Khlebnikov
Cc: linux-...@vger.kernel.org
Cc: Bjorn Helgaas
Cc: Khalid Aziz
---
drivers/pci/pci-driver.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci-driver.c b/
---
Konstantin Khlebnikov (5):
e1000e: fix resuming from runtime-suspend
e1000e: fix pci device enable counter balance
PCI: revert preparing for wakeup in runtime-suspend finalization
PCI: don't touch enable_cnt in pci_device_shutdown()
PCI: catch enable-co
so let's
handle it as an exception. Its driver should set device state to D3cold and
the rest code will handle it properly.
Signed-off-by: Konstantin Khlebnikov
Cc: linux-...@vger.kernel.org
Cc: Bjorn Helgaas
Cc: Dave Airlie
---
drivers/pci/pci-driver.c |5 +++--
1 file changed
This patch adds single WARN_ONCE() check for catching 'enable_cnt' imbalances.
Signed-off-by: Konstantin Khlebnikov
Cc: linux-...@vger.kernel.org
Cc: Bjorn Helgaas
---
drivers/pci/pci.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pci/pci.c b/drivers/pci/p
Bug was introduced in commit 23606cf5d1192c2b17912cb2ef6e62f9b11de133
("e1000e / PCI / PM: Add basic runtime PM support (rev. 4)") in v2.6.35
Signed-off-by: Konstantin Khlebnikov
Cc: e1000-devel@lists.sourceforge.net
Cc: Jeff Kirsher
Cc: Bruce Allan
---
drivers/net/ethernet/in
in v2.6.35
Signed-off-by: Konstantin Khlebnikov
Cc: e1000-devel@lists.sourceforge.net
Cc: Jeff Kirsher
Cc: Bruce Allan
---
drivers/net/ethernet/intel/e1000e/netdev.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c
b/drivers/net/ethernet/in
Rafael J. Wysocki wrote:
> On Monday, January 28, 2013 04:05:33 PM Bjorn Helgaas wrote:
>> [+cc Rafael, author of patch you cited]
>>
>> On Fri, Jan 18, 2013 at 4:42 AM, Konstantin Khlebnikov
>> wrote:
>>> Bug was introduced in commit 23606cf5d1192c2b17912cb
Bjorn Helgaas wrote:
> [+cc Rafael @sisk.pl]
>
> On Mon, Jan 28, 2013 at 4:09 PM, Bjorn Helgaas wrote:
>> [+cc Rafael]
>>
>> On Fri, Jan 18, 2013 at 4:42 AM, Konstantin Khlebnikov
>> wrote:
>>> __e1000_shutdown() calls pci_disable_device() at the end,
Rafael J. Wysocki wrote:
> On Monday, January 28, 2013 04:17:42 PM Bjorn Helgaas wrote:
>> [+cc Rafael]
>>
>> On Fri, Jan 18, 2013 at 4:42 AM, Konstantin Khlebnikov
>> wrote:
>>> This patch effectively reverts commit
>>> 42eca2302146fed51335b95128e9
Rafael J. Wysocki wrote:
> On Tuesday, January 29, 2013 10:32:14 AM Konstantin Khlebnikov wrote:
>> Rafael J. Wysocki wrote:
>>> On Monday, January 28, 2013 04:05:33 PM Bjorn Helgaas wrote:
>>>> [+cc Rafael, author of patch you cited]
>>>>
>&g
Rafael J. Wysocki wrote:
> On Tuesday, January 29, 2013 12:55:15 PM Rafael J. Wysocki wrote:
>> On Tuesday, January 29, 2013 11:04:57 AM Konstantin Khlebnikov wrote:
>>> Rafael J. Wysocki wrote:
>>>> On Monday, January 28, 2013 04:17:42 PM Bjorn Helgaas wrote:
>>
Rafael J. Wysocki wrote:
> On Saturday, February 02, 2013 09:58:45 PM Rafael J. Wysocki wrote:
>> On Saturday, February 02, 2013 04:12:03 PM Konstantin Khlebnikov wrote:
>>> Rafael J. Wysocki wrote:
>>>> On Tuesday, January 29, 2013 12:55:15 PM Rafael J. Wysocki wrote
em.
Probably we should leave here only warning and disable bus-mastering for each
driver individually in ->shutdown() callback.
Link: https://lkml.org/lkml/2012/6/6/278
Signed-off-by: Konstantin Khlebnikov
Cc: Rafael J. Wysocki
Cc: Bjorn Helgaas
Cc: Khalid Aziz
Cc: linux-...@vger.kernel.org
C
/147
---
Konstantin Khlebnikov (6):
e1000e: fix pci-device enable-counter balance
PCI: don't touch enable_cnt in pci_device_shutdown()
PCI: catch enable-counter underflows
e1000e: fix runtime power management transitions
PCI/PM: warn about incomplete actio
me PM support (rev. 4)") in v2.6.35
Signed-off-by: Konstantin Khlebnikov
Cc: Rafael J. Wysocki
Cc: e1000-devel@lists.sourceforge.net
Cc: Jeff Kirsher
Cc: Bruce Allan
---
drivers/net/ethernet/intel/e1000e/netdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ne
n saved by ->runtime_suspend()
that means device alredy prepared for wakeup and probably no longer accessible.
Thus driver must either do all actions or leave all these tasks to PCI
subsystem.
Signed-off-by: Konstantin Khlebnikov
Cc: Rafael J. Wysocki
Cc: Bjorn Helgaas
Cc: linux-...@vger.
like custom 'enable_wakeup' sign.
Signed-off-by: Konstantin Khlebnikov
Cc: Rafael J. Wysocki
Cc: e1000-devel@lists.sourceforge.net
Cc: Jeff Kirsher
Cc: Bruce Allan
---
drivers/net/ethernet/intel/e1000e/netdev.c | 78 ++--
1 file changed, 18 insertions(+), 60
This patch fixes some annoying messages like 'Error reading PHY register' and
'Hardware Erorr' and saves several seconds on reboot.
Signed-off-by: Konstantin Khlebnikov
Cc: Rafael J. Wysocki
Cc: e1000-devel@lists.sourceforge.net
Cc: Jeff Kirsher
Cc: Bruce Allan
---
driver
This patch adds single WARN_ONCE() check for catching 'enable_cnt' imbalances.
Signed-off-by: Konstantin Khlebnikov
Cc: linux-...@vger.kernel.org
Cc: Bjorn Helgaas
Cc: Rafael J. Wysocki
---
drivers/pci/pci.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pci/pci.c
.
Signed-off-by: Konstantin Khlebnikov # add comment
Cc: linux-...@vger.kernel.org
Cc: Bjorn Helgaas
Cc: Rafael J. Wysocki
---
drivers/pci/pci-driver.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
index dc5bdce..f9aa311 100
Rafael J. Wysocki wrote:
> On Monday, February 04, 2013 03:56:12 PM Konstantin Khlebnikov wrote:
>> Documentation/power/pci.txt says:
>> | It is expected that the device driver's pm->runtime_suspend() callback will
>> | not attempt to prepare the device for signali
This patch fixes some annoying messages like 'Error reading PHY register' and
'Hardware Erorr' and saves several seconds on reboot.
Signed-off-by: Konstantin Khlebnikov
Acked-by: Rafael J. Wysocki
Cc: e1000-devel@lists.sourceforge.net
Cc: Jeff Kirsher
Cc: Bruce Allan
---
like custom 'enable_wakeup' sign.
Signed-off-by: Konstantin Khlebnikov
Acked-by: Rafael J. Wysocki
Cc: e1000-devel@lists.sourceforge.net
Cc: Jeff Kirsher
Cc: Bruce Allan
---
drivers/net/ethernet/intel/e1000e/netdev.c | 78 ++--
1 file changed, 18 inserti
me PM support (rev. 4)") in v2.6.35
Signed-off-by: Konstantin Khlebnikov
Acked-by: Rafael J. Wysocki
Cc: e1000-devel@lists.sourceforge.net
Cc: Jeff Kirsher
Cc: Bruce Allan
---
drivers/net/ethernet/intel/e1000e/netdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
Waskiewicz Jr, Peter P wrote:
> On 2/24/2013 9:19 PM, Konstantin Khlebnikov wrote:
>> This patch fixes some annoying messages like 'Error reading PHY register' and
>> 'Hardware Erorr' and saves several seconds on reboot.
>
> Any networking-related patches s
Ben Hutchings wrote:
> On Tue, 2013-02-26 at 14:03 +0400, Konstantin Khlebnikov wrote:
>> Waskiewicz Jr, Peter P wrote:
>>> On 2/24/2013 9:19 PM, Konstantin Khlebnikov wrote:
>>>> This patch fixes some annoying messages like 'Error reading PHY register'
Jiri Slaby wrote:
> On 03/12/2013 06:17 PM, Borislav Petkov wrote:
>> On Mon, Mar 11, 2013 at 09:25:37PM +0100, Borislav Petkov wrote:
>>> Yeah, it is already upstream. And yeah, it did trigger with it.
>>>
>>> $ git describe
>>> v3.9-rc2-112-g7c6baa304b84
>>>
>>> But it somehow doesn't trigger wit
Jiri Slaby wrote:
> On 04/15/2013 05:29 PM, Jiri Slaby wrote:
>> On 03/29/2013 07:04 PM, Allan, Bruce W wrote:
>>>> -Original Message-
>>>> From: Jiri Slaby [mailto:jirisl...@gmail.com] On Behalf Of Jiri Slaby
>>>> Sent: Tuesday, March 19
This adds missing rtnl_unlock()
Signed-off-by: Konstantin Khlebnikov
Cc: Jeff Kirsher
Cc: e1000-devel@lists.sourceforge.net
---
drivers/net/ethernet/intel/igb/igb_main.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
b/drivers/net/ethernet
> Pid: 1363, comm: kworker/u:73 Not tainted 3.9.0-rc2+ #27
It's not 3.10
That pci_disable_device() was replaced with pci_clear_master() in
4e0855dff094b0d56d6b5b271e0ce7851cc1e063 3.9-rc3 and accidentially
dropped in merge commit e5f2ef7ab4690d2e8faaf5fd203c5ecd70c3abaf in 3.10-rc1
see
http://l
value in the
kernel. I believe the patch you are talking about is:
commit 0f9e980bf5ee1a97e2e401c846b2af989eb21c61
Author: Konstantin Khlebnikov
Date: Mon Jan 14 16:29:30 2019 +0300
e1000e: fix cyclic resets at link up with active tx
I'm seeing series of e1000e resets (sometimes endless) at syst
us <40080080>
PHY Status <7949>
PHY 1000BASE-T Status <0>
PHY Extended Status<3000>
PCI Status <10>
e1000e: eth0 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: Rx/Tx
Besides warning everything works fine.
Original issue wil
only when NIC is ready to send packets.
This is proper fix for problem addressed by commit 0f9e980bf5ee
("e1000e: fix cyclic resets at link up with active tx").
Signed-off-by: Konstantin Khlebnikov
Suggested-by: Alexander Duyck
---
drivers/net/ethernet/intel/e1000e/netdev.c |6
34 matches
Mail list logo
