Re: [edk2-buildtools] [PATCH 0/7] Build ResetVector/VTF with NASM during EDK II build

2014-05-20 Thread Jordan Justen
On Tue, May 20, 2014 at 12:01 PM, Andrew Fish wrote: > On May 20, 2014, at 10:55 AM, Jordan Justen wrote: >> Then again, for real platforms, they might like to have the port 0x80 >> debug support enabled by default. (This will output >> 16/32/64/b0/b1/f0/f1 to the post card.) >> >> What do you th

Re: [edk2-buildtools] [PATCH 1/7] BaseTools: Add rules to build NASM into a binary

2014-05-20 Thread Laszlo Ersek
On 05/20/14 20:56, Jordan Justen wrote: > On Tue, May 20, 2014 at 12:41 AM, Laszlo Ersek wrote: >> On 05/19/14 23:27, Jordan Justen wrote: >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Jordan Justen >>> --- >>> BaseTools/Conf/build_rule.template | 19

Re: [edk2-buildtools] [PATCH 4/7] OvmfPkg: Build OVMF ResetVector during EDK II build process

2014-05-20 Thread Laszlo Ersek
On 05/20/14 20:08, Jordan Justen wrote: > On Tue, May 20, 2014 at 2:01 AM, Laszlo Ersek wrote: >> Three questions: >> >> On 05/19/14 23:27, Jordan Justen wrote: >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Jordan Justen >>> --- >>> OvmfPkg/OvmfPkgIa32.dsc| 2

Re: [edk2-buildtools] [PATCH 0/7] Build ResetVector/VTF with NASM during EDK II build

2014-05-20 Thread Andrew Fish
On May 20, 2014, at 10:55 AM, Jordan Justen wrote: > Then again, for real platforms, they might like to have the port 0x80 > debug support enabled by default. (This will output > 16/32/64/b0/b1/f0/f1 to the post card.) > > What do you think? Assuming that port 0x80 exists is probably not a goo

Re: [edk2-buildtools] [PATCH 1/7] BaseTools: Add rules to build NASM into a binary

2014-05-20 Thread Jordan Justen
On Tue, May 20, 2014 at 12:41 AM, Laszlo Ersek wrote: > On 05/19/14 23:27, Jordan Justen wrote: >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Jordan Justen >> --- >> BaseTools/Conf/build_rule.template | 19 ++- >> BaseTools/Conf/tools_def.template

Re: [edk2-buildtools] [PATCH 4/7] OvmfPkg: Build OVMF ResetVector during EDK II build process

2014-05-20 Thread Jordan Justen
On Tue, May 20, 2014 at 2:01 AM, Laszlo Ersek wrote: > Three questions: > > On 05/19/14 23:27, Jordan Justen wrote: >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Jordan Justen >> --- >> OvmfPkg/OvmfPkgIa32.dsc| 2 ++ >> OvmfPkg/OvmfPkgIa32.fdf| 6 +++--- >>

Re: [edk2-buildtools] [PATCH 0/7] Build ResetVector/VTF with NASM during EDK II build

2014-05-20 Thread Jordan Justen
On Tue, May 20, 2014 at 1:54 AM, Gao, Liming wrote: > Jordan: > Thanks for your great contribution. I have some comments. > 1. Which NASM version is used to verify this patch? Good point. That should be documented. For now, I recommend we choose "Nasm 2.03 or newer" which matches UefiCpuPkg/Res

Re: [edk2-buildtools] [PATCH 6/7] OvmfPkg/ResetVector: Remove pre-built binaries

2014-05-20 Thread Laszlo Ersek
On 05/19/14 23:27, Jordan Justen wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- > OvmfPkg/ResetVector/Bin/ResetVector.inf | 29 > OvmfPkg/ResetVector/Bin/ResetVector.x64.raw | Bin 628 -> 0 bytes > OvmfPkg/ResetVecto

Re: [edk2-buildtools] [PATCH 4/7] OvmfPkg: Build OVMF ResetVector during EDK II build process

2014-05-20 Thread Laszlo Ersek
Three questions: On 05/19/14 23:27, Jordan Justen wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- > OvmfPkg/OvmfPkgIa32.dsc| 2 ++ > OvmfPkg/OvmfPkgIa32.fdf| 6 +++--- > OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ > OvmfPkg/OvmfPkgIa32X64.fdf

Re: [edk2-buildtools] [PATCH 0/7] Build ResetVector/VTF with NASM during EDK II build

2014-05-20 Thread Gao, Liming
Jordan: Thanks for your great contribution. I have some comments. 1. Which NASM version is used to verify this patch? 2. Nasm-to-Binary-Code-File Rule is added to compile nasm to the binary ResetVector file. It can replace current ASM16 build rule after ASM16 source is converted to nasmbin. R

Re: [edk2-buildtools] [PATCH 3/7] OvmfPkg: Support building OVMF's ResetVector during the EDK II build

2014-05-20 Thread Laszlo Ersek
On 05/19/14 23:27, Jordan Justen wrote: > Using NASM we build OVMF's ResetVector as part of the EDK II build > process. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- > OvmfPkg/ResetVector/ResetVector.inf | 37 +++ > OvmfP

Re: [edk2-buildtools] [PATCH 1/7] BaseTools: Add rules to build NASM into a binary

2014-05-20 Thread Laszlo Ersek
On 05/19/14 23:27, Jordan Justen wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- > BaseTools/Conf/build_rule.template | 19 ++- > BaseTools/Conf/tools_def.template | 8 +++- > 2 files changed, 25 insertions(+), 2 deletion