Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

Marcel, Laszlo, I went back to read the PciHostBridgeDxe driver in OvmfPkg and below is my understanding to this driver's behavior: The driver reads QEMU config "etc/extra-pci-roots" and promotes bus from #1 to #extra-pci-roots to root bridges. Supposing there are 10 buses and extra-pci-roots is

Re: [edk2] [Patch v2] UefiCpuPkg/PiSmmCpuDxeSmm: Add EFIAPI to CheckFeatureSupported()

Mike, One more comment. Please add the @param as blow in CheckFeatureSupported()'s function header. @param[in,out] Buffer The pointer to private data buffer. Thanks! Jeff -Original Message- From: Fan, Jeff Sent: Friday, February 19, 2016 3:54 PM To: Michael Kinney;

Re: [edk2] [PATCH] ShellPkg: Do NULL pointer check before the pointer is used.

Reviewed-by: Jaben Carsey -Jaben Sent from my iPad. > On Feb 21, 2016, at 6:49 PM, Qiu, Shumin wrote: > > Do NULL pointer check before the pointer is used to avoid dereferenced. > > Cc: Jaben Carsey > Cc: Ruiyu Ni

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

Ard, So the final decision between you and Jiewen is a new PCD is still needed? If so, could you move the PCD to MdeModulePkg? because the MdeModulePkg/BDS actually may also need this change if it's used in ARM64 platform and MdeModulePkg shouldn't depend on a PCD defined in

[edk2] [PATCH] MdeModulePkg/HiiDatabaseDxe: Fix a variable is uninitialized.

The StringSize variable in the FindStringBlock function is a IN OUT parameter of the GetUnicodeStringTextOrSize function. Thought the GetUnicodeStringTextOrSize function changes the value of the StringSize variable, it is better to initialize the StringSize variable before passing it to the

Re: [edk2] [Patch V2 1/2] MdeModulePkg/PciBus: Refine to reduce code lines.

OK.OK.:) I will generate V3. A improper patch can never escape from your eyes. Regards, Ray From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Friday, February 19, 2016 6:41 PM To: Ni, Ruiyu ; edk2-de...@ml01.01.org Cc: Tian, Feng

Re: [edk2] [Patch V2 2/2] MdeModuelPkg/PciBus: Return AddrTranslationOffset in GetBarAttributes

Agree. ASSERT(FALSE) is cleaner:) Regards, Ray From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, February 19, 2016 6:56 PM To: Ni, Ruiyu ; edk2-de...@ml01.01.org Cc: Benjamin Herrenschmidt ; Andrew Fish ; Fan, Jeff

[edk2] [PATCH] ShellPkg: Do NULL pointer check before the pointer is used.

Do NULL pointer check before the pointer is used to avoid dereferenced. Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin ---

Re: [edk2] [Patch] MdeModulePkg/Partition: Fix 64bit build failure caused by last patch

Reviewed-by: Feng Tian -Original Message- From: Ni, Ruiyu Sent: Monday, February 22, 2016 10:45 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Tian, Feng Subject: [Patch] MdeModulePkg/Partition: Fix 64bit build failure caused by last patch Contributed-under: TianoCore

[edk2] [Patch] MdeModulePkg/Partition: Fix 64bit build failure caused by last patch

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian --- MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2] [PATCH v2 2/2] NetworkPkg: Use Http11 definitions in HttpDxe and HttpBootDxe

Reviewed-by: Fu Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El- > Haj-Mahmoud, Samer > Sent: Monday, February 22, 2016 7:46 AM > To: edk2-devel@lists.01.org; Fu, Siyuan > Subject: Re:

Re: [edk2] [PATCH v2 2/2] NetworkPkg: Use Http11 definitions in HttpDxe and HttpBootDxe

Reviewed-by: Jiaxin Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Samer El-Haj-Mahmoud > Sent: Friday, February 19, 2016 6:48 AM > To: edk2-devel@lists.01.org > Cc: Samer El-Haj-Mahmoud ; Fu, Siyuan

Re: [edk2] [PATCH v3 5/6] SecurityPkg: Add FileExplorerLib.inf to the dsc file

Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Bi, Dandan Sent: Wednesday, February 03, 2016 1:01 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B; Dong, Eric Subject: [PATCH v3 5/6] SecurityPkg: Add FileExplorerLib.inf to

Re: [edk2] [PATCH v3 6/6] SecurityPkg: Use FileExplorerLib in SecureBootConfigDxe

Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Bi, Dandan Sent: Wednesday, February 03, 2016 1:01 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B; Dong, Eric; Laszlo Ersek Subject: [PATCH v3 6/6] SecurityPkg: Use

Re: [edk2] [PATCH] SecurityPkg: Change TPM MMIO range attribute

Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Friday, February 19, 2016 6:15 AM To: edk2-devel@lists.01.org Cc: Zhang, Chao B Subject: [PATCH] SecurityPkg: Change TPM MMIO range attribute

[edk2] [PATCH v2] MdeModulePkg: HiiDatabaseDxe: HiiStringToImage() should not overwrite BltX

v2: Modify the subject to make clear the change of this patch. when has newline to draw, should not overwrite the BltX to 0, instead should keep the BltX value that pass into StringToImage function. Cc: Liming Gao Cc: Eric Dong Cc: Laszlo Ersek

Re: [edk2] [PATCH v2 2/2] NetworkPkg: Use Http11 definitions in HttpDxe and HttpBootDxe

Siyuan, Can you review please? -Original Message- From: El-Haj-Mahmoud, Samer Sent: Thursday, February 18, 2016 4:48 PM To: edk2-devel@lists.01.org Cc: siyuan...@intel.com; El-Haj-Mahmoud, Samer ; El-Haj-Mahmoud, Samer

Re: [edk2] [PATCH] MdePkg: Fix CPER GUID definitions to match UEFI spec

Mike or Liming, Can you review please? -Original Message- From: El-Haj-Mahmoud, Samer Sent: Thursday, February 18, 2016 5:35 PM To: edk2-devel@lists.01.org Cc: michael.d.kin...@intel.com; liming@intel.com; El-Haj-Mahmoud, Samer ; El-Haj-Mahmoud, Samer

Re: [edk2] [PATCH] MdePkg: Fix incorrect PCIe Extended Capabilities definition

Mike or Liming, Can you review please? -Original Message- From: El-Haj-Mahmoud, Samer Sent: Thursday, February 18, 2016 6:01 PM To: edk2-devel@lists.01.org Cc: michael.d.kin...@intel.com; liming@intel.com; El-Haj-Mahmoud, Samer ; El-Haj-Mahmoud, Samer

Re: [edk2] [PATCH] MdeModulePkg: Add HttpUtilLib

Siyuan, Can you review please? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El-Haj-Mahmoud, Samer Sent: Thursday, February 18, 2016 6:49 PM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer ;

Re: [edk2] [PATCH] MdeModulePkg : Fix a bug in BmpImageDecoderLib

Eric or Ray, Can you review please? -Original Message- From: El-Haj-Mahmoud, Samer Sent: Thursday, February 18, 2016 6:59 PM To: edk2-devel@lists.01.org Cc: eric.d...@intel.com; ruiyu...@intel.com; El-Haj-Mahmoud, Samer ; El-Haj-Mahmoud, Samer

[edk2] [PATCH v3 0/2] Enhance Shell to support finding help message embeded in resource section.

1. Enhance Shell to support finding help message in resource section of an application image if .MAN file is missing. 2. Enhance an sample application, HelloWorld, to add sample help message text. Difference with previous version: Use HiiLib HiiGetString() API to get string value instead of

[edk2] [PATCH v3 2/2] MdeModulePkg: Add sample help information for HelloWorld application.

Since Shell supports finding help information from resource section of application image. We enhance the HelloWorld to add help information string. After the HelloWorld are loaded in system the help string will be stored in resource section of the application image. Cc: Feng Tian

[edk2] [PATCH v3 1/2] ShellPkg: Support finding help message embedded in resource section.

UEFI Shell scandalizes the help message in spec level so that a standalone UEFI shell application can never get "-?" switch, instead the Shell core (interpreter) detects the "-?" and finds .MAN file for that shell application in certain spec defined paths, then show the help extracted from that