Re: [edk2] [Patch 1/2] MdeModulePkg: Check received packet size before use it.

2016-04-03 Thread Subramanian, Sriram (EG Servers Platform SW)
> (By the way, the register dump seems to be consistent > with RxToken->CallBack() freeing the packet. Namely, > in the disassembly, we can see that %rax is being > dereferenced, and the value of %rax is AFAFAFAFAFAFAFAF > at that point. If we grep the edk2 codebase for 0xAF, > we find EFI_BAD

Re: [edk2] [PATCH] MdeModulePkg: DxeUdpIoLib: fix non-empty payload path in UDP reception

2016-04-03 Thread Subramanian, Sriram (EG Servers Platform SW)
Thanks for testing that, Laszlo. Reviewed-by: Sriram Subramanian Thanks, Sriram. -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Sunday, April 3, 2016 3:44 PM To: edk2-devel-01 Cc: Siyuan Fu ; Jiaxin Wu ; Ting Ye ; Subramanian, Sriram (EG Servers Platform SW)

Re: [edk2] Variable storage

2016-04-03 Thread Mahan, Patrick
Laszlo, That definitely helps, Thanks, Patrick From: Laszlo Ersek Sent: Sunday, April 3, 2016 1:31 AM To: Mahan, Patrick Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Variable storage On 04/03/16 00:05, Mahan, Patrick wrote: > In the UEFI 2.5 Specifi

[edk2] [PATCH] MdeModulePkg: DxeUdpIoLib: fix non-empty payload path in UDP reception

2016-04-03 Thread Laszlo Ersek
Commit 1b31acb66c02 ("MdeModulePkg: Check received packet size before use it.") introduced a chunk of code under the new "Resume" label, in function UdpIoOnDgramRcvdDpc(). The new code is supposed to run only when the received packet has zero-length payload, but a "return" statement was forgotten,

Re: [edk2] [Patch 1/2] MdeModulePkg: Check received packet size before use it.

2016-04-03 Thread Laszlo Ersek
On 03/31/16 15:40, Subramanian, Sriram (EG Servers Platform SW) wrote: > Looks good. > Reviewed-by: Sriram Subramanian > > -Original Message- > From: Fu Siyuan [mailto:siyuan...@intel.com] > Sent: Monday, March 28, 2016 8:47 AM > To: edk2-devel@lists.01.org > Cc: Ye Ting; Wu Jiaxin; Subr

Re: [edk2] Variable storage

2016-04-03 Thread Laszlo Ersek
On 04/03/16 00:05, Mahan, Patrick wrote: > In the UEFI 2.5 Specification, in Section 7.2 on Variable runtime > services, it states: “Although the implementation of variable storage > is not defined in this specification, …” But does not talk about any > document that describes this storage. > > W