Re: [edk2] [Patch 0/6] PciHostBridgeDxe: Bug fix and OVMF above Xen support

2016-05-08 Thread Ni, Ruiyu
Github url: https://github.com/niruiyu/edk2/tree/XenOvmf Maurice, The OVMF above Xen issue is similar to the Coreboot. The PCI bus enumeration is performed by non-UEFI code. OvmfPkg/PciHostBridgeLib scans the entire PCI bus to detect all the root bridges. Could you please check whether the code (

Re: [edk2] [Patch 0/6] PciHostBridgeDxe: Bug fix and OVMF above Xen support

2016-05-08 Thread Ni, Ruiyu
Gary, Can you please check whether the patch can fix the OVMF above Xen issue? Regards, Ray >-Original Message- >From: Ni, Ruiyu >Sent: Monday, May 9, 2016 2:26 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu >Subject: [Patch 0/6] PciHostBridgeDxe: Bug fix and OVMF above Xen support > >Th

Re: [edk2] [Patch 4/6] MdeModulePkg/PciHostBridgeLib: Add ResourceAssigned field

2016-05-08 Thread Ni, Ruiyu
Re-forward to Laszlo using the correct mail address. Regards, Ray >-Original Message- >From: Ni, Ruiyu >Sent: Monday, May 9, 2016 2:27 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; Laszlo Ersek ; Fan, Jeff > >Subject: [Patch 4/6] MdeModulePkg/PciHostBridgeLib: Add ResourceAssigned fie

[edk2] [Patch 6/6] OvmfPkg/PciHostBridgeLib: Scan for root bridges when running over Xen

2016-05-08 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Gary Lin Cc: Laszlo Ersek --- .../Library/PciHostBridgeLib/PciHostBridgeLib.c| 550 +++-- .../Library/PciHostBridgeLib/PciHostBridgeLib.inf | 1 + 2 files changed, 515 insertions(+), 36 de

[edk2] [Patch 4/6] MdeModulePkg/PciHostBridgeLib: Add ResourceAssigned field

2016-05-08 Thread Ruiyu Ni
Some platform doesn't require PciBus driver to assign resource to PCI devices which causes PciRootBridgeIo.Configuration() cannot return correct resource information to caller. When resource assignment by PciBus is not mandatory, only light version of PCI bus enumeration is performed, which only c

[edk2] [Patch 1/6] MdeModulePkg/PciHostBridgeDxe: Don't miss prefetchable MMIO aperture

2016-05-08 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jeff Fan --- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c b/MdeModulePkg/B

[edk2] [Patch 0/6] PciHostBridgeDxe: Bug fix and OVMF above Xen support

2016-05-08 Thread Ruiyu Ni
The patch serials fix two bugs in PciHostBridgeDxe driver. And it adds a new field in PCI_ROOT_BRIDGE structure to support OVMF above Xen support. Ruiyu Ni (6): MdeModulePkg/PciHostBridgeDxe: Don't miss prefetchable MMIO aperture MdeModulePkg/PciHostBridgeDxe: Fix a Base/Limit comparing bug

[edk2] [Patch 5/6] MdeModulePkg/PciHostBridgeDxe: Honor ResourceAssigned

2016-05-08 Thread Ruiyu Ni
Change PciHostBridgeDxe driver to not install the PciHostBridgeResourceAllocation protocol and let PciRootBridgeIo.Configuration() return the correct PCI resource assignment information when the ResourceAssigned is TRUE. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu

[edk2] [Patch 3/6] OvmfPkg/PciHostBridgeLib: Set correct Base/Limit for absent resource

2016-05-08 Thread Ruiyu Ni
Contributed-under: TianoCore contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Laszlo Ersek --- OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c b/OvmfPkg/Librar

[edk2] [Patch 2/6] MdeModulePkg/PciHostBridgeDxe: Fix a Base/Limit comparing bug

2016-05-08 Thread Ruiyu Ni
When the aperture base equals to aperture limit, the old code treats the aperture as non-existent. It's not correct because it indicates a range starting with base and the length is 1. The new code corrects the comparing bug. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: R

Re: [edk2] [PATCH] MdeModulePkg/DxeIplPeim: RISC-V arch DxeIpl.

2016-05-08 Thread Jordan Justen
On 2016-05-08 04:19:08, Chang, Abner (HPS SW/FW Technologist) wrote: > Hi Jordan, > The UEFI/PI ECR for RISC-V is ready but not yet send to UEFI for > review. I have been told to upstream RISC-V code first and then > submit the spec. I will confirm this again. You were told to upstream EDK II supp

Re: [edk2] [PATCH] NetworkPkg: Make HttpBootGetBootFile return EFI_BUFFER_TOO_SMALL

2016-05-08 Thread Wu, Jiaxin
Looks good to me. Reviewed-By: Wu Jiaxin Best Regards! Jiaxin > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Monday, May 9, 2016 12:33 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: [PATCH] NetworkPkg: Make HttpBootGetBootFile return > E

[edk2] [Patch] MdeModulePkg/PciSioSerialDxe: Do not flush the UART

2016-05-08 Thread Ruiyu Ni
The patch aligns to the IntelFrameworkModulePkg/Bus/Isa/IsaSerialDxe driver not flush the UART in Reset() and SetAttributes() function. It was found the flush causes hang on certain PCI serial devices. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Eric Jin -

[edk2] [PATCH] NetworkPkg: Make HttpBootGetBootFile return EFI_BUFFER_TOO_SMALL

2016-05-08 Thread Gary Lin
Per the description of HttpBootGetBootFile, the function should return EFI_BUFFER_TOO_SMALL if the given buffer is smaller than the remote image. Cc: Siyuan Fu Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin --- NetworkPkg/HttpBootDxe/HttpBootClien

Re: [edk2] [patch] MdeModulePkg/Sd: add Erase Block support on sd/emmc device

2016-05-08 Thread Tian, Feng
I agree your comment. I will update it during check-in Thanks Feng -Original Message- From: Wu, Hao A Sent: Monday, May 9, 2016 10:54 AM To: Tian, Feng Cc: edk2-devel@lists.01.org Subject: RE: [patch] MdeModulePkg/Sd: add Erase Block support on sd/emmc device One comment below. And wit

[edk2] [PATCH 2/2] MdeModulePkg ScsiDiskDxe: Add Erase Block Protocol support for UFS devices

2016-05-08 Thread Hao Wu
This patch implements the EFI_ERASE_BLOCK_PROTOCOL in ScsiDiskDxe driver. For now, the codes support the erase block feature only on Universal Flash Storage (UFS) devices. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDis

[edk2] [PATCH 0/2] Add Erase Block Protocol support for UFS devices

2016-05-08 Thread Hao Wu
This patch series add the Erase Block Protocol implementation for UFS devices. Since the UFS transport layer follows the SCSI architecture, therefore, the implementation is added in the ScsiDiskDxe driver. Hao Wu (2): MdePkg IndustryStandard/Scsi.h: Add Unmap command support MdeModulePkg Scsi

[edk2] [PATCH 1/2] MdePkg IndustryStandard/Scsi.h: Add Unmap command support

2016-05-08 Thread Hao Wu
According to the SCSI Block Commands - 4 (SBC-4) spec, the patch add SCSI unmap command support in IndustryStandard/Scsi.h. The following changes have been made: 1. Add SCSI unmap command OP Code 2. Update the structure definition for Block Limits VPD page 3. Add structure definitions for UNMAP pa

[edk2] [PATCH 3/4] MdeModulePkg AtaAtapiPassThru: Use the new PortMultiplierPort semantics

2016-05-08 Thread Hao Wu
The UEFI2.6 spec updated the description of the port multiplier port number parameter in SATA Device Path Node and ATA Pass-Through Protocol. Now, this parameter should be set to 0x instead of 0 to indicate that an ATA device is directly attached on the controller port. Contributed-under: Tia

[edk2] [PATCH 4/4] MdeModulePkg AtaAtapiPassThru: Fix incorrect parameter description comment

2016-05-08 Thread Hao Wu
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c b/MdeModulePkg/Bus/Ata/AtaAtapiPass

[edk2] [PATCH 2/4] MdePkg Protocol/AtaPassThru.h: Update PortMultiplierPort related comments

2016-05-08 Thread Hao Wu
The UEFI2.6 spec updated 'PortMultiplierPort' parameter description for the following services in EFI_ATA_PASS_THRU_PROTOCOL: 1. PassThru 2. BuildDevicePath 3. ResetDevice Now, if there is no port multiplier on a ATA controller port, the PortMultiplierPort parameter should be set to 0x instead

[edk2] [PATCH 0/4] ATA PassThru & SATA device path PortMultiplier update

2016-05-08 Thread Hao Wu
The UEFI 2.6 spec updated the description of the port multiplier port number parameter in SATA Device Path Node and ATA Pass-Through Protocol. Now, this parameter should be set to 0x instead of 0 to indicate that an ATA device is directly attached on the controller port. Hao Wu (4): MdePkg

[edk2] [PATCH 1/4] MdePkg Protocol/DevicePath.h: Update SATA Device Path comments

2016-05-08 Thread Hao Wu
The UEFI2.6 spec updated the Port Multiplier Port Number description of SATA device path to use 0x when the device is directly connected to the HBA. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdePkg/Include/Protocol/DevicePath.h | 4 ++-- 1 file changed

Re: [edk2] [PATCH v4 1/2] MdeModulePkg RamDiskDxe: Report ACPI NFIT for reserved memory RAM disks

2016-05-08 Thread Tian, Feng
Looks good to me Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Monday, May 9, 2016 8:58 AM To: edk2-devel@lists.01.org; Tian, Feng ; Zeng, Star Cc: samer.el-haj-mahm...@hpe.com; ler...@redhat.com; Wu, Hao A Subject: [PATCH v4 1/2] MdeModulePkg RamDiskD

Re: [edk2] [patch] MdeModulePkg/Sd: add Erase Block support on sd/emmc device

2016-05-08 Thread Wu, Hao A
One comment below. And with that solved, Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Tian, Feng > Sent: Wednesday, May 04, 2016 1:30 PM > To: Wu, Hao A > Cc: edk2-devel@lists.01.org; Wu > Subject: [patch] MdeModulePkg/Sd: add Erase Block support on sd/emmc > dev

[edk2] [staging/HTTPS-TLS][PATCH] NetworkPkg: Fix unclosed TCP connection case if TLS session failed

2016-05-08 Thread Jiaxin Wu
This patch is used to fix unclosed TCP connection case if TLS session build failed. Cc: El-Haj-Mahmoud Samer Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- NetworkPkg/HttpDxe/HttpImpl.c | 4 ++-- 1 file changed, 2 insertions(+),

Re: [edk2] [PATCH 2/2] MdePkg: MDE implementations for RISC-V arch.

2016-05-08 Thread Yao, Jiewen
Hi Abner I have a quick review on that and I have question for below library/APIs: 1) BaseCacheMaintenanceLib - It seems you just leave empty function there, without any implementation. If there is no need to implement this, would you please add some comments around the code? 2) IoLib - It seem

Re: [edk2] [PATCH v2 1/1] MdeModulePkg:DxeHttpLib: Add checks in HttpGenRequestMessage API

2016-05-08 Thread Wu, Jiaxin
It's good to me! Reviewed-By: Wu Jiaxin Best Regards! Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Nagaraj Hegde > Sent: Thursday, May 5, 2016 2:59 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wu, > Jiaxin > Su

Re: [edk2] [PATCH v2 1/1] NetworkPkg:HttpDxe: Code changes to support HTTP PUT/POST operations

2016-05-08 Thread Wu, Jiaxin
Hi Nagaraj, In every EfiHttpRequest() for PUT/POST, HttpInitTcp() will be called even the TCP state is established (get from TCP4/6 GetModeData each time) and return EFI_SUCCESS. To avoid this repeating function call and improve the performance, we can check the current Http state, if require

Re: [edk2] [PATCH] MdeModulePkg: FileExplorerLib: prevent freeing null pointer

2016-05-08 Thread Tian, Feng
Thanks for your contribution, Mike. Your commit log misses the license statement, I will help add below in. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Zimmermann Here is my response: Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-

Re: [edk2] [PATCH] MdeModulePkg/DxeIplPeim: RISC-V arch DxeIpl.

2016-05-08 Thread Yao, Jiewen
Hi Abner I think it is great to have more arch for UEFI. Thanks for your great contribution. As you mentioned, this RISC-V seems not in public UEFI standard yet, code might be subject to change. If so, do you think it might be a better idea to check in this as staging tree, which follow EDKII s

[edk2] [PATCH v4 1/2] MdeModulePkg RamDiskDxe: Report ACPI NFIT for reserved memory RAM disks

2016-05-08 Thread Hao Wu
The RamDiskDxe now will report RAM disks with reserved memory type to NFIT in the ACPI table. This commit will also make sure that an NVDIMM root device exists in the \SB scope before reporting any RAM disk to NFIT. To properly report the NVDIMM root device, one will need to append the following

Re: [edk2] [PATCH v4 0/2] Report ACPI NFIT for reserved memory RAM disks

2016-05-08 Thread Wu, Hao A
Hi Laszlo, Since the v4 1/2 patch is the same as the v3 1/2 one, so I skipped sending this patch. Sorry for the confusion, I will send the missing patch later. Best Regards, Hao Wu > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, May 06, 2016 11:57 PM

Re: [edk2] [PATCH] MdeModulePkg/DxeIplPeim: RISC-V arch DxeIpl.

2016-05-08 Thread Chang, Abner (HPS SW/FW Technologist)
Hi Jordan, The UEFI/PI ECR for RISC-V is ready but not yet send to UEFI for review. I have been told to upstream RISC-V code first and then submit the spec. I will confirm this again. Below response to your comments, > --- > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf| 6 +- > MdeModule