[edk2] [PATCH V2] MdeModulePkg ConSplitterDxe: Support toggle state sync

2016-12-25 Thread Star Zeng
Register key notify for toggle state (CapsLock, NumLock and ScrollLock) sync between multiple keyboards. The implementation for this feature requires keyboard driver supports EFI_KEY_STATE_EXPOSED, and turns on physical TextInEx partial key report for toggle state sync. The virtual TextInEx will

[edk2] [PATCH 1/1] Add BGRT ACPI table inclusion support in OVMF

2016-12-25 Thread Bhupesh Sharma
During debugging Linux kernel for ACPI BGRT support (especially on VMs), it is sometimes very useful to have the EFI firmware (OVMF in most cases which use Tianocore) to export the ACPI BGRT table. This patch tries to add this support. I have tested this patch on a RHEL7.3 and Fedora-25 KVM and

[edk2] [PATCH] MdeModulePkg/PrintLib: Add missing return status check for Print APIs

2016-12-25 Thread Hao Wu
For the following APIs in PrintLib instance MdeModulePkg\Library\DxePrintLibPrint2Protocol: UnicodeVSPrint UnicodeSPrint UnicodeVSPrintAsciiFormat UnicodeSPrintAsciiFormat AsciiVSPrint AsciiSPrint AsciiVSPrintUnicodeFormat AsciiSPrintUnicodeFormat The internal function

Re: [edk2] [PATCH V2] MdeModulePkg/CapsuleLib: Add CapsuleTarget support.

2016-12-25 Thread Zhang, Chao B
Reviewed-by : Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Yao, Jiewen Sent: Saturday, December 24, 2016 12:03 AM To: edk2-devel@lists.01.org Cc: Tian, Feng; Zeng, Star; Zhang, Chao B Subject: [PATCH V2] MdeModulePkg/CapsuleLib: Add

Re: [edk2] [PATCH] MdeModulePkg/CapsuleLib: Add CapsuleTarget support.

2016-12-25 Thread Zhang, Chao B
Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Yao, Jiewen Sent: Friday, December 23, 2016 3:48 PM To: edk2-devel@lists.01.org Cc: Tian, Feng; Zeng, Star; Zhang, Chao B Subject: [PATCH] MdeModulePkg/CapsuleLib: Add

Re: [edk2] [PATCH V2] MdeModulePkg/CapsuleLib: Add CapsuleTarget support.

2016-12-25 Thread Zeng, Star
With that, Reviewed-by: Star Zeng From: Yao, Jiewen Sent: Monday, December 26, 2016 11:01 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star ; Zhang, Chao B Subject:

Re: [edk2] [PATCH] MdeModulePkg/CapsuleLib: Follow UEFI 22.2.3 to process FMP.

2016-12-25 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Yao, Jiewen Sent: Saturday, December 24, 2016 3:51 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star ; Zhang, Chao B Subject: [PATCH]

Re: [edk2] [PATCH] MdeModulePkg/CapsuleLib: Support result rolling over.

2016-12-25 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Saturday, December 24, 2016 12:05 AM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zhang, Chao B

Re: [edk2] [PATCH V2] MdeModulePkg/CapsuleLib: Add CapsuleTarget support.

2016-12-25 Thread Zeng, Star
Minor comment inline. On 2016/12/24 0:02, Jiewen Yao wrote: UEFI spec requires CapsuleTarget to be a device path associated with FMP producer. Cc: Feng Tian Cc: Star Zeng Cc: Chao Zhang Contributed-under: TianoCore

Re: [edk2] [PATCH] MdeModulePkg/CapsuleLib: Support result rolling over.

2016-12-25 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Saturday, December 24, 2016 12:05 AM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zhang, Chao B

Re: [edk2] [Patch] NetworkPkg: Fix potentially uninitialized local variable

2016-12-25 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan -Original Message- From: Wu, Jiaxin Sent: 2016年12月26日 10:11 To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [Patch] NetworkPkg: Fix potentially

Re: [edk2] [Patch] NetworkPkg: Fix potentially uninitialized local variable

2016-12-25 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Monday, December 26, 2016 10:11 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [Patch] NetworkPkg: Fix

Re: [edk2] [Patch] Nt32Pkg/Nt32Pkg.dsc: Change TLS_ENABLE flag to FALSE by default

2016-12-25 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Friday, December 23, 2016 4:41 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Ye, Ting ; Long, Qin ; Fu, Siyuan ; Wu,

[edk2] [Patch] NetworkPkg: Fix potentially uninitialized local variable

2016-12-25 Thread Jiaxin Wu
Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/HttpDxe/HttpProto.c | 2 ++ NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 2 +- 2 files

Re: [edk2] [PATCH] MdeModulePkg ConSplitterDxe: Support toggle state sync

2016-12-25 Thread Zeng, Star
It is going to make the further maintainer to know what kind of code are specific for toggle state sync feature. If somebody has interest to the feature, he/she can only focus on the related functions and calling lines. Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Monday,

Re: [edk2] [PATCH] MdeModulePkg ConSplitterDxe: Support toggle state sync

2016-12-25 Thread Ni, Ruiyu
Star, Why do you need "code can still work as before if the Toggle State Sync related functions and calling lines are removed"? Do you have a plan to remove the Toggle State Sync feature? If no, as long as Toggle State Sync feature cannot be separated very clearly (like VariableAuth), we can