Re: [edk2] [PATCH] MdeModulePkg, NetworkPkg, EdkCompatibilityPkg: fix some typos of 'according'

2017-01-26 Thread Rebecca Cran
Replying in order to actually Cc the people I mentioned in the commit message. -- Rebecca On 1/26/2017 8:39 AM, Rebecca Cran wrote: Fix some typos of "according". ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] [edk2-staging] Create new edk2-test branch

2017-01-26 Thread Andrew Fish
Mike, Looks like something is eating it? >cat TestCasePkg.patch diff --git a/TestCasePkg/Timer/ArchTimerBBTestConformance.c b/TestCasePkg/Timer/ArchTimerBBTestConformance.c index 8a4bd7c..b72dfcb 100644 --- a/TestCasePkg/Timer/ArchTimerBBTestConformance.c +++

Re: [edk2] [edk2-staging] Create new edk2-test branch

2017-01-26 Thread Andrew Fish
> On Jan 26, 2017, at 11:36 AM, Kinney, Michael D > wrote: > > Andrew, > > Was there supposed to be an attachment for the TestCasePkg fixes? > Yes. Thanks, Andrew FIsh > Thanks, > > Mike > >> -Original Message- >> From: edk2-devel

Re: [edk2] [edk2-staging] Create new edk2-test branch

2017-01-26 Thread Kinney, Michael D
Andrew, Was there supposed to be an attachment for the TestCasePkg fixes? Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew > Fish > Sent: Thursday, January 26, 2017 10:26 AM > To: Kinney, Michael D

Re: [edk2] [edk2-staging] Create new edk2-test branch

2017-01-26 Thread Andrew Fish
> On Jan 26, 2017, at 9:43 AM, Kinney, Michael D > wrote: > > Andrew, > > Thanks for the patch for the additional compiler compatibility. I will > review and check in. > Mike, Here is the TestCasePkg fixes. > I will also correct the Readme.md and add the

Re: [edk2] [edk2-staging] Create new edk2-test branch

2017-01-26 Thread Kinney, Michael D
Thanks for catching this typo. I will send Readme.md patch with updates from you and Andrew soon. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Rudra > ? > Sent: Thursday, January 26, 2017 6:16 AM > To: Andrew Fish

Re: [edk2] [edk2-staging] Create new edk2-test branch

2017-01-26 Thread Kinney, Michael D
Supreeth, Thanks! I will add you as one of the owner's in the Readme.md. We use the same edk2 patch method and use the same edk2-devel mailing list. The only difference is the format of the subject line so everyone can clearly identify staging topics from edk2 topics. For work on the

Re: [edk2] [edk2-staging] Create new edk2-test branch

2017-01-26 Thread Kinney, Michael D
Andrew, Thanks for the patch for the additional compiler compatibility. I will review and check in. I will also correct the Readme.md and add the Unix setup info. I am aware that the current post build step is a batch file. We need to update that to be compatible with all supported

Re: [edk2] [edk2-staging] Create new edk2-test branch

2017-01-26 Thread Supreeth Venkatesh
Michael, I am interested in developing the test harness and /or the test case SDK. Should the contribution to this, when it is still in Staging, should it follow edk2 patch methodology or do you have a separate email alias for edk2-test related queries/patches? Thanks, Supreeth -Original

Re: [edk2] [PATCH] ShellPkg/cd: Do not print the destination dir when CD exits

2017-01-26 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, January 25, 2017 8:34 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Chris J Phillips > ; Tapan Shah > Subject:

Re: [edk2] [PATCH] Fix edit on screens with more than 200 columns

2017-01-26 Thread Carsey, Jaben
That seems good to me. Reviewed-by: Jaben Carsey Ray, what do you think? -Jaben > -Original Message- > From: Witt, Sebastian [mailto:sebastian.w...@siemens.com] > Sent: Thursday, January 26, 2017 1:01 AM > To: Carsey, Jaben ;

Re: [edk2] EFI shell script

2017-01-26 Thread Carsey, Jaben
The "if" command supports some numeric comparison, but I don't think we have much more. Can you elaborate on the goal of arithmetic using env vars? -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Foster, Matthew I > Sent: Thursday,

[edk2] [PATCH] MdeModulePkg, NetworkPkg, EdkCompatibilityPkg: fix some typos of 'according'

2017-01-26 Thread Rebecca Cran
Fix some typos of "according". From 79a1ef3a17cbdc46e5a85c881ba83a65b44aafeb Mon Sep 17 00:00:00 2001 From: Rebecca Cran Date: Thu, 26 Jan 2017 08:38:18 -0700 Subject: [PATCH] Fix some typos of "according" Cc: Feng Tian Cc: Star Zeng

[edk2] EFI shell script

2017-01-26 Thread Foster, Matthew I
Is there any version of the EFI shell or library that implements performing simple arithmetic operations on numeric values stored in the shell environment variables in an EFI shell script? ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] [PATCH] ShellPkg/cd: Do not print the destination dir when CD exits

2017-01-26 Thread Shah, Tapan
Reviewed-by: Tapan Shah -Original Message- From: Ruiyu Ni [mailto:ruiyu...@intel.com] Sent: Wednesday, January 25, 2017 10:34 PM To: edk2-devel@lists.01.org Cc: Jaben Carsey ; Phillips, Chris J (Plano, TX) ; Shah, Tapan

Re: [edk2] [PATCH V3 1/1] ArmPlatformPkg/TZASC: Allow specifying subregions to be disabled

2017-01-26 Thread Leif Lindholm
On Fri, Jan 20, 2017 at 05:10:45PM +0530, Bhupesh Sharma wrote: > ARM TZASC-380 IP provides a mechanism to split memory regions being > protected via it into eight equal-sized sub-regions. A bit-setting > allows the corresponding subregion to be disabled. > > Several NXP/FSL SoCs support the

Re: [edk2] [edk2-staging] Create new edk2-test branch

2017-01-26 Thread Rudra ठाकुर
I think there is a typo in following line in Readme.md git clone https://github.com/tianocore/edk2-staging.git --brach edk2-test it should be git clone https://github.com/tianocore/edk2-staging.git --branch edk2-test Thanks, --Rajnish On Thu, Jan 26, 2017 at 3:57 AM, Andrew Fish

Re: [edk2] [PATCH V2 2/3] ArmPkg/CpuDxe: Correct EFI_MEMORY_RO usage

2017-01-26 Thread Yao, Jiewen
Hi Leif Here is 2nd patch. I did a global replace for EFI_MEMORY_WP. I have to send this patch because I updated DxeCore to use EFI_MEMORY_RO and EFI_MEMORY_XP for PE image protection. Assuming the original EFI_MEMORY_WP can work, I think this EFI_MEMORY_RO update is no harm. But if the

[edk2] [PATCH V2 2/3] ArmPkg/CpuDxe: Correct EFI_MEMORY_RO usage

2017-01-26 Thread Jiewen Yao
Current Arm CpuDxe driver uses EFI_MEMORY_WP for write protection, according to UEFI spec, we should use EFI_MEMORY_RO for write protection. The EFI_MEMORY_WP is the cache attribute instead of memory attribute. Cc: Leif Lindholm Cc: Ard Biesheuvel

Re: [edk2] [PATCH 2/3] ArmPkg/CpuDxe: Correct EFI_MEMORY_RO usage

2017-01-26 Thread Yao, Jiewen
Thank you, Leif. You are right. I found I missed some other after I did a global search for EFI_MEMORY_WP. I will send V2 ARM patch soon. Thank you Yao Jiewen From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Thursday, January 26, 2017 8:11 PM To: Yao, Jiewen

Re: [edk2] [PATCH 2/3] ArmPkg/CpuDxe: Correct EFI_MEMORY_RO usage

2017-01-26 Thread Leif Lindholm
On Thu, Jan 26, 2017 at 04:39:14PM +0800, Jiewen Yao wrote: > Current Arm CpuDxe driver uses EFI_MEMORY_WP for write protection, > according to UEFI spec, we should use EFI_MEMORY_RO for write protection. > The EFI_MEMORY_WP is the cache attribute instead of memory attribute. Hi Jiewen, The

Re: [edk2] [PATCH 0/5] MdeModulePkg/EbcDxe: add ARM support

2017-01-26 Thread Pete Batard
On 2017.01.26 11:37, Yao, Jiewen wrote: I mean ECR – Engineer Change Request. Ah, that makes more sense. ;) If someone wants to update UEFI spec, he/she need submit a document to uefi.org and describe the technical detail. Okay. I guess I'll need to do that then. Unless someone on this

[edk2] [PATCH 2/6] SecurityPkg/dec: Add PcdPasswordCleared.

2017-01-26 Thread Jiewen Yao
This PCD is to indicate if the password is cleared. Cc: Qin Long Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- SecurityPkg/SecurityPkg.dec | 6 ++

[edk2] [PATCH 1/6] CryptoPkg:SmmCryptLib: Add real Pkcs5Pbkdf2.c.

2017-01-26 Thread Jiewen Yao
Cc: Qin Long Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [PATCH 6/6] SecurityPkg/dsc: add Password authentication module.

2017-01-26 Thread Jiewen Yao
Cc: Qin Long Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- SecurityPkg/SecurityPkg.dsc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/SecurityPkg/SecurityPkg.dsc

[edk2] [PATCH 5/6] SecurityPkg/Password: Add Password based UserAuthentication modules.

2017-01-26 Thread Jiewen Yao
This password based user authentication is to verify user when a user wants to enter BIOS setup page. The DXE driver registers report status code listener. When it gets (EFI_SOFTWARE_DXE_BS_DRIVER | EFI_SW_PC_USER_SETUP) progress code, it will let the user input password. If and only if the user

[edk2] [PATCH 0/6] Add password support

2017-01-26 Thread Jiewen Yao
This series patch adds password support in EDKII. This password based user authentication is to verify user when a user wants to enter BIOS setup page. The detail information is added in [PATCH 5/6]. Cc: Qin Long Cc: Chao Zhang Contributed-under:

[edk2] [PATCH 4/6] SecurityPkg/PlatformPasswordLibNull: Add PlatformPasswordLib instance.

2017-01-26 Thread Jiewen Yao
This lib instance is to return if the password is cleared based upon PCD. Cc: Qin Long Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao ---

[edk2] [PATCH 3/6] SecurityPkg/include: Add PlatformPasswordLib lib class.

2017-01-26 Thread Jiewen Yao
This lib is to indicate if the password is cleared. Cc: Qin Long Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- SecurityPkg/Include/Library/PlatformPasswordLib.h | 54

Re: [edk2] [PATCH 0/5] MdeModulePkg/EbcDxe: add ARM support

2017-01-26 Thread Yao, Jiewen
My apology: ERCR is a typo. I mean ECR - Engineer Change Request. If someone wants to update UEFI spec, he/she need submit a document to uefi.org and describe the technical detail. Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Pete Batard Sent:

Re: [edk2] [PATCH 0/5] MdeModulePkg/EbcDxe: add ARM support

2017-01-26 Thread Pete Batard
Hi Andrew, Hi Jiwen, On 2017.01.26 03:32, Andrew Fish wrote: Do we have any concern to adopt EDKII patch before UEFI spec change? I would look at this the other way. This is the only way to implement EBC for ARM. This work was NOT done as part of the UEFI Form and this edk2 patch is the

Re: [edk2] [edk2-staging] Create new edk2-test branch

2017-01-26 Thread Andrew Fish
> On Jan 25, 2017, at 2:05 PM, Kinney, Michael D > wrote: > > The initial version of the edk2-test branch is checked in at: > > https://github.com/tianocore/edk2-staging/tree/edk2-test > Mike, I'm messing around with trying this on macOS. git clone

Re: [edk2] [PATCH] Fix edit on screens with more than 200 columns

2017-01-26 Thread Witt, Sebastian
Like this? If the shell edit command is used on a screen with more than 200 columns, we get a buffer overflow. This always allocates a pool for the columns. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Sebastian Witt ---

[edk2] [PATCH 0/3] DXE Memory Protection

2017-01-26 Thread Jiewen Yao
This series patch provides capability to protect PE/COFF image in DXE memory. If the UEFI image is page aligned, the image code section is set to read only and the image data section is set to non-executable. The DxeCore calls CpuArchProtocol->SetMemoryAttributes() to protect the image. Tested

[edk2] [PATCH 2/3] ArmPkg/CpuDxe: Correct EFI_MEMORY_RO usage

2017-01-26 Thread Jiewen Yao
Current Arm CpuDxe driver uses EFI_MEMORY_WP for write protection, according to UEFI spec, we should use EFI_MEMORY_RO for write protection. The EFI_MEMORY_WP is the cache attribute instead of memory attribute. Cc: Leif Lindholm Cc: Ard Biesheuvel

[edk2] [PATCH 3/3] MdeModulePkg/DxeCore: Add UEFI image protection.

2017-01-26 Thread Jiewen Yao
If the UEFI image is page aligned, the image code section is set to read only and the image data section is set to non-executable. 1) This policy is applied for all UEFI image including boot service driver, runtime driver or application. 2) This policy is applied only if the UEFI image meets the

[edk2] [PATCH 1/3] UefiCpuPkg/CpuDxe: Add memory attribute setting.

2017-01-26 Thread Jiewen Yao
Add memory attribute setting in CpuArch protocol. Previous SetMemoryAttributes() API only supports cache attribute setting. This patch updated SetMemoryAttributes() API to support memory attribute setting by updating CPU page table. Cc: Jeff Fan Cc: Michael Kinney