[edk2] [PATCH 2/2] ArmPlatformPkg/PL061Gpio: fix the offset value in Get function

2017-02-12 Thread Haojian Zhuang
When call PL061GetPins() or PL061SetPins(), should use GPIO_PIN_MASK(offset) as parameter, not offset. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang --- ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[edk2] [PATCH 1/2] ArmPlatformPkg/PL061: remove duplicated PL061_GPIO_DATA_REG

2017-02-12 Thread Haojian Zhuang
PL061_GPIO_DATA_REG offset is referenced in PL061EffectiveAddress () already. So remove the duplicated reference when invoke PL061GetPins () or PL061SetPins (). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang --- ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio

Re: [edk2] [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy

2017-02-12 Thread Wu, Jiaxin
Series Reviewed-by: Wu Jiaxin > -Original Message- > From: hegdenag [mailto:nagaraj-p.he...@hpe.com] > Sent: Monday, February 13, 2017 3:20 PM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Ye, Ting ; Zhang, > Lubo ; Fu, Siyuan ; sriram- > s...@hpe.com > Subject: [PATCH v2 0/2] Networ

[edk2] [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy

2017-02-12 Thread hegdenag
v2: Updated list of reviewers. Today, iSCSI driver checks whether there are AIP instances installed by iSCSI HBA adapter and if yes, the iSCSI driver will return EFI_ABORTED in its driver binding Start. We can not guarantee the existence of AIP instances always during iSCSI DBStart. Hence, we mig

[edk2] [PATCH v2 2/2] NetworkPkg/NetworkPkg.dec: Update comments for the PCD

2017-02-12 Thread hegdenag
Update comment section for the PCD PcdIScsiAIPNetworkBootPolicy. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hegde Nagaraj P --- NetworkPkg/NetworkPkg.dec | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/Ne

[edk2] [PATCH v2 1/2] NetworkPkg/iSCSIDxe: Update the condition for IScsiStart Abort

2017-02-12 Thread hegdenag
Update existing #define and add a new #define used for the PCD PcdIScsiAIPNetworkBootPolicy. Update the code in iScsiStart according to the #define changes in iScsiDriver.h Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hegde Nagaraj P --- NetworkPkg/IScsiDxe/IScsiDriver.

[edk2] [PATCH v1 2/2] NetworkPkg/NetworkPkg.dec: Update comments for the PCD

2017-02-12 Thread hegdenag
Update comment section for the PCD PcdIScsiAIPNetworkBootPolicy. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hegde Nagaraj P --- NetworkPkg/NetworkPkg.dec | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/Ne

[edk2] [PATCH v1 1/2] NetworkPkg/iSCSIDxe: Update the condition for IScsiStart Abort

2017-02-12 Thread hegdenag
Update existing #define and add a new #define used for the PCD PcdIScsiAIPNetworkBootPolicy. Update the code in iScsiStart according to the #define changes in iScsiDriver.h Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hegde Nagaraj P --- NetworkPkg/IScsiDxe/IScsiDriver.

[edk2] [PATCH v1 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy

2017-02-12 Thread hegdenag
Today, iSCSI driver checks whether there are AIP instances installed by iSCSI HBA adapter and if yes, the iSCSI driver will return EFI_ABORTED in its driver binding Start. We can not guarantee the existence of AIP instances always during iSCSI DBStart. Hence, we might end up doing a iScsiStart eve

Re: [edk2] [Patch V2] BaseTools: Enhance BaseTools supports FixedAtBuild usage in VFR file

2017-02-12 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Monday, February 13, 2017 2:03 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch V2] BaseTools: Enhance BaseTools supports FixedAtBuild >usage in VFR file > >This patch is to update BaseTools generate

[edk2] [Patch V2] BaseTools: Enhance BaseTools supports FixedAtBuild usage in VFR file

2017-02-12 Thread Yonghong Zhu
This patch is to update BaseTools generate Fixed PCD APIs and Value into $(MODULE_NAME)StrDefs.h for VFR only. If the module has VFR files, and it directly consumes FixedAtBuild PCD, BaseTool will generate those FixedAtBuild PCD value into its $(MODULE_NAME)StrDefs.h. FixedPcdGetXX macro are always

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3] Change DSC and FDF.

2017-02-12 Thread zwei4
Add SPI and FirmwareUpdate modules into build meta-data files. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Wei --- Platform/BroxtonPlatformPkg/PlatformDsc/Components.dsc | 18 ++ .../BroxtonPlatformPkg/PlatformDsc/LibraryClasses.dsc | 1 + Platf

Re: [edk2] CapsuleApp behavior for CAPSULE_FLAGS_PERSIST_ACROSS_RESET only capsule

2017-02-12 Thread wang xiaofeng
Hi Jiewen, Thanks ! I believe –NR flag will be helpful to me. At 2017-02-13 11:52:50, "Yao, Jiewen" wrote: >I see your point. > > >1) That is possible. To make the solution complete, I am thinking to add >–NR (no-reset) flag. > >2) If you just want to update multiple capsul

Re: [edk2] CapsuleApp behavior for CAPSULE_FLAGS_PERSIST_ACROSS_RESET only capsule

2017-02-12 Thread Yao, Jiewen
I see your point. 1) That is possible. To make the solution complete, I am thinking to add �CNR (no-reset) flag. 2) If you just want to update multiple capsules at one time, current APP already support this feature. You may use: CapsuleApp Bios.Cap Me.Cap Bmc.Cap Thank you Yao Jie

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3] Add FirmwareUpdate application

2017-02-12 Thread zwei4
Add FirmwareUpdate application for Minnnowboard 3, which is for updating 8MB SPI NOR flash. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: zwei4 --- .../Application/FirmwareUpdate/FirmwareUpdate.c| 927 + .../Application/FirmwareUpdate/FirmwareUpd

Re: [edk2] [Patch] BaseTools: Add NOOPT target in CLANG38 tool chain

2017-02-12 Thread Zhu, Yonghong
Please update the copyright year. Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Thursday, February 09, 2017 2:09 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [Patch] BaseTools: Add NOOPT target in CLANG38 tool chain http

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3] Add SPI modules.

2017-02-12 Thread zwei4
From: lushifex Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex Signed-off-by: David Wei --- .../SouthCluster/Include/Library/ScSpiCommonLib.h | 361 .../SouthCluster/Include/Protocol/Spi.h| 359 .../BaseScSpiCommonLib/BaseScSpiComm

Re: [edk2] CapsuleApp behavior for CAPSULE_FLAGS_PERSIST_ACROSS_RESET only capsule

2017-02-12 Thread wang xiaofeng
Hi Jiewen, Sorry, I forgot that I modified Capsuleapp before, Trunk Caspuleapp behavior is like you said" If a capsule has CAPSULE_FLAGS_PERSIST_ACROSS_RESET, capsule app will trigger reset". The logic doesn;t have errors. But the behavior is a little different from my understanding . Could