Re: [edk2] [PATCH] MdePkg/SafeString.c: Fix code to be more readable

2017-03-05 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Ni, Ruiyu > Sent: Monday, March 06, 2017 3:24 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [PATCH] MdePkg/SafeString.c: Fix code to be more readable > > The change doesn't impact the functionality. > >

[edk2] [PATCH] MdePkg/SafeString.c: Fix code to be more readable

2017-03-05 Thread Ruiyu Ni
The change doesn't impact the functionality. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Hao A Wu --- MdePkg/Library/BaseLib/SafeString.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/MdePkg/Library/BaseL

Re: [edk2] "[edk] Caculating time delay in milliseconds"

2017-03-05 Thread Michael Zimmermann
Another way that can be very unreliable though is creating a timer event using CreateEvent and incrementing a counter inside the callback. This will not give you exact values and the results can vary greatly depending on the platform implementation and the cpu load but in theory it should be better

[edk2] [PATCH] MdePkg/Pci22.h: Remove deprecated macros

2017-03-05 Thread Ruiyu Ni
The following deprecated macros are removed.The removal doesn't cause any build failure to existing packages. #define DEVICE_ID_NOCARE0x #define PCI_BAR_OLD_ALIGN 0xULL #define PCI_BAR_EVEN_ALIGN 0xFFFEULL #define PCI_BAR_SQUAD_ALIGN 0xFFFDULL #de

Re: [edk2] [PATCH 0/3] BaseTools/Source/C: Fix VS2010/2012 build failure

2017-03-05 Thread Zhu, Yonghong
Looks good. Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Wu, Hao A Sent: Monday, March 6, 2017 1:11 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Zhu, Yonghong ; Gao, Liming Subject: [PATCH 0/3] BaseTools/Source/C: Fix VS2010/2012 build failure htt

[edk2] [PATCH 3/3] BaseTools/VolInfo: Fix VS2010/VS2012 build failure

2017-03-05 Thread Hao Wu
https://bugzilla.tianocore.org/show_bug.cgi?id=417 The commit makes the following refinements in VolInfo source codes to avoid VS2010/VS2012 build failure: 1. Refines coding style for function 'CombinePath' to declare local variables at the beginning of the function block. Cc: Yonghong Zhu Cc:

[edk2] [PATCH 1/3] BaseTools/GenFw: Fix VS2010/VS2012 build failure

2017-03-05 Thread Hao Wu
https://bugzilla.tianocore.org/show_bug.cgi?id=417 The commit makes the following refinements in GenFw source codes to avoid VS2010/VS2012 build failure: 1. Replaces the uses of 'bool' with 'BOOLEAN' for accordance, and remove the header file dependency for ''. 2. Refines coding style for functi

[edk2] [PATCH 0/3] BaseTools/Source/C: Fix VS2010/2012 build failure

2017-03-05 Thread Hao Wu
https://bugzilla.tianocore.org/show_bug.cgi?id=417 The series resolves the build failure for the VS2010/2012 build failure for BaseTools GenFw, GenVtf & VolInfo source codes. Cc: Yonghong Zhu Cc: Liming Gao Hao Wu (3): BaseTools/GenFw: Fix VS2010/VS2012 build failure BaseTools/GenVtf: Fix

[edk2] [PATCH 2/3] BaseTools/GenVtf: Fix VS2010/VS2012 build failure

2017-03-05 Thread Hao Wu
https://bugzilla.tianocore.org/show_bug.cgi?id=417 The commit makes the following refinements in GenVtf source codes to avoid VS2010/VS2012 build failure: 1. Refines coding style to declare local variables at the beginning of a code block in function 'main'. Cc: Yonghong Zhu Cc: Liming Gao Con

[edk2] question about BSP switch function

2017-03-05 Thread Tiger Liu
Hi, experts: I have a question about BSP switch function. PI Spec defined a Ppi and a Protocol to provide SwitchBSP() function. EFI_MP_SERVICES_PPI.SwitchBSP() EFI_MP_SERVICES_PROTOCOL.SwitchBSP() If SEC code found BSP had some errors, so PEI phase code could use mp services ppi to switch BSP to

Re: [edk2] "[edk] Caculating time delay in milliseconds"

2017-03-05 Thread Arka Sharma
Thanks Mike for the reply but EFI_TIMESTAMP_PROTOCOL is not there in my platform. I tried to open it using gBS->LocateProtocol() and it returned EFI_NOT_FOUND On Thu, Mar 2, 2017 at 11:38 PM, Kinney, Michael D wrote: > For UEFI Drivers/Applications there is also the EFI_TIMESTAMP_PROTOCOL > if it

Re: [edk2] "[edk] Caculating time delay in milliseconds"

2017-03-05 Thread Arka Sharma
Thanks Michael for your reply.The function GetPerformanceCounter() is returning 0 is my platform. On Thu, Mar 2, 2017 at 11:38 PM, Kinney, Michael D wrote: > For UEFI Drivers/Applications there is also the EFI_TIMESTAMP_PROTOCOL > if it is available on your platform. > > Mike > >> -Original M

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3] Adjust FVs size and base.

2017-03-05 Thread zwei4
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: zwei4 --- Platform/BroxtonPlatformPkg/BuildBios.bat | 3 ++- .../Common/Tools/Stitch/IFWIStitch_Simple.bat | 17 ++--- Platform/BroxtonPlatformPkg/PlatformDsc/Defines.dsc | 2 +- Platf

Re: [edk2] [PATCH v4 0/4] MdePkg, MdeModulePkg: Enforce page allocation granularity

2017-03-05 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Friday, March 03, 2017 11:12 PM >To: edk2-devel@lists.01.org; Gao, Liming ; Kinney, >Michael D >Cc: Zeng, Star ; Yao, Jiewen ; >Ard Biesheuvel >Subject: [PATCH v4 0/4] MdePkg, Mde

Re: [edk2] [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable on RELEASE builds

2017-03-05 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] >Sent: Sunday, March 05, 2017 11:00 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Zhu, Yonghong > >Subject: [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable on >RELEASE build

Re: [edk2] [PATCH v3 09/12] SecurityPkg/Opal: Refine casting expression result to bigger size

2017-03-05 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Wu, Hao A Sent: Saturday, February 25, 2017 1:13 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A; Dong, Eric; Tian, Feng; Zhang, Chao B Subject: [PATCH v3 09/12] SecurityPkg/Opal: Refine casting expression result to bigger size There are cas

Re: [edk2] [PATCH v3 02/12] MdeModulePkg: Refine casting expression result to bigger size

2017-03-05 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Saturday, February 25, 2017 1:12 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Tian, Feng ; Zeng, Star Subject: [PATCH v3 02/12] MdeModulePkg: Refine casting expression result to bigger size There are cases

Re: [edk2] [PATCH v3 1/6] MdeModulePkg: Refine type cast for pointer subtraction

2017-03-05 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Saturday, February 25, 2017 12:05 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Tian, Feng ; Zeng, Star Subject: [PATCH v3 1/6] MdeModulePkg: Refine type cast for pointer subtraction For pointer subtraction,

Re: [edk2] [PATCH v3 5/6] SecurityPkg: Refine type cast for pointer subtraction

2017-03-05 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: Wu, Hao A Sent: Saturday, February 25, 2017 12:05 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Zhang, Chao B Subject: [PATCH v3 5/6] SecurityPkg: Refine type cast for pointer subtraction For pointer subtraction, the result is of type "p

Re: [edk2] [PATCH v3 4/6] NetworkPkg: Refine type cast for pointer subtraction

2017-03-05 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin > -Original Message- > From: Wu, Hao A > Sent: Saturday, February 25, 2017 12:05 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Fu, Siyuan ; > Wu, Jiaxin > Subject: [PATCH v3 4/6] NetworkPkg: Refine type cast for pointer subtraction > > For pointer subtractio

Re: [edk2] [PATCH v3 4/6] NetworkPkg: Refine type cast for pointer subtraction

2017-03-05 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan -Original Message- From: Wu, Hao A Sent: 2017年2月25日 12:05 To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Fu, Siyuan ; Wu, Jiaxin Subject: [PATCH v3 4/6] NetworkPkg: Refine type cast for pointer subtraction For pointer subtraction, the result is of type "ptrdiff_t"