Re: [edk2] [Patch 1/2] BaseTools: add /Gw to CC_FLAGS for VS2013 and higher tool chain tags

2017-06-13 Thread Kinney, Michael D
Yonghong, I do not think the EBC compiler supports /Gw. Did you test that? Mike -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Tuesday, June 13, 2017 9:47 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patc

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Add code for WIFI/BT

2017-06-13 Thread Lu, ShifeiX A
Reviewed-by: lushifex Shifei -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of zwei4 Sent: Wednesday, June 14, 2017 2:05 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Add code for WIFI/BT Add

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Add code for WIFI/BT

2017-06-13 Thread zwei4
Add code for LBEE5KL1DX WIFI & Blue Tooth on FAB B. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: zwei4 --- .../MinnowBoard3/BoardInitPostMem/BoardGpios.h | 6 +-- .../Common/Acpi/AcpiTablesPCAT/Platform.asl| 2 +- .../PlatformSsdt/Bluetooth/LBEE5KL1DX.asl

Re: [edk2] HTTP Boot failed to download NBP file if it is .iso type

2017-06-13 Thread Fu, Siyuan
Hi, Naveen First let's kick out the HTTP and check whether your SUSE iso image could support RAM disk boot: 1. Go to "RAM Disk Configuration" form in your setup browser. 2. Change the disk memory type to "Reserved" 3. Choose "Create from file" and select the SUSE iso image

[edk2] [Patch 1/2] BaseTools: add /Gw to CC_FLAGS for VS2013 and higher tool chain tags

2017-06-13 Thread Yonghong Zhu
The /Gw flag does a better job at size optimization than use of the GLOBAL_REMOVE_IF_UNREFERENCED macro that is currently used for VS20xx tool chains to remove unreferenced global variables. This patch add /Gw to CC_FLAGS for VS2013 and higher tool chain tags. Cc: Liming Gao Contributed-under: Ti

[edk2] [Patch 2/2] MdePkg: update Base.h in MdePkg to check the _MSC_VER

2017-06-13 Thread Yonghong Zhu
update Base.h in MdePkg to check the _MSC_VER and define GLOBAL_REMOVE_IF_UNREFERENCED to nothing for VS2013 and higher tool chain tags. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- MdePkg/Include/Base.h | 2 +- 1 file changed, 1 inserti

[edk2] [Patch 0/2] Add /Gw to CC_FLAGS for VS 2013 and higher tool chains

2017-06-13 Thread Yonghong Zhu
The /Gw flag does a better job at size optimization than use of the GLOBAL_REMOVE_IF_UNREFERENCED macro that is currently used for VS20xx tool chains to remove unreferenced global variables. The recommendation is to add /Gw to CC_FLAGS for VS2013 and higher tool chain tags and update Base.h in Mde

Re: [edk2] [PATCH v2] EmbeddedPkg/MmcDxe: Add alignment for ECSD data

2017-06-13 Thread Jun Nie
2017-06-13 17:18 GMT+08:00 Leif Lindholm : > On Tue, Jun 13, 2017 at 10:14:34AM +0800, Jun Nie wrote: >> 2017-06-12 23:53 GMT+08:00 Leif Lindholm : >> > On Mon, Jun 12, 2017 at 09:59:28AM +0800, Jun Nie wrote: >> >> Add alignment for ECSD data for DMA access. Otherwise >> >> the data is corrupted o

Re: [edk2] [Patch V2] UefiCpuPkg/MpInitLib: Fix X64 XCODE5/NASM compatibility issues

2017-06-13 Thread Kinney, Michael D
hpa, Use of esi is on purpose. esi is the base address of a structure and it is consistently used as a 32-bit value in all 3 execution modes in this file. I agree we can remove the qword specifier as a cleaner style. Also, as we consolidate on NASM sources, we can see if ASM_PFX() can be dropp

Re: [edk2] [RFC] migration of OpenPlatformPkg to tianocore

2017-06-13 Thread Kinney, Michael D
Hi Leif, I pulled the latest versions of the repos and I was able to complete a build with no errors and without using symbolic links. The change I made is to set WORKSPACE to the directory immediately above the repos and set PACKAGES_PATH to directories that contain the packages required for the

[edk2] [edk2-CCodingStandardsSpecification] Create release/2.20 branch

2017-06-13 Thread Michael Kinney
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- book.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/book.json b/book.json index 30ea7e0..39f6413 100644 --- a/book.json +++ b/book.json @@ -1,8 +1,7 @@ { "variables" : { -

[edk2] [PATCH] MdeModulePkg/DxeCore: Fixed Interface returned by CoreOpenProtocol

2017-06-13 Thread Amit Kumar
Modified source code to update Interface as per spec. 1) In case of Protocol is un-supported, interface should be returned NULL. 2) In case of any error, interface should not be modified. 3) In case of Test Protocol, interface is optional. Contributed-under: TianoCore Contribution Agreement 1.0 Si

Re: [edk2] HTTP Boot failed to download NBP file if it is .iso type

2017-06-13 Thread Santhapur Naveen
Hi Siyuan, Thank you for your reply. And regarding the OS installation, we are able to download SUSE iso (>3 GB) from the HTTP server. But the install didn't happen. May I ask you what could be possible reason? Is there anything else I've had missed, please let me know. Regards, Naveen -Or

Re: [edk2] [PATCH v2] EmbeddedPkg/MmcDxe: Add alignment for ECSD data

2017-06-13 Thread Leif Lindholm
On Tue, Jun 13, 2017 at 10:14:34AM +0800, Jun Nie wrote: > 2017-06-12 23:53 GMT+08:00 Leif Lindholm : > > On Mon, Jun 12, 2017 at 09:59:28AM +0800, Jun Nie wrote: > >> Add alignment for ECSD data for DMA access. Otherwise > >> the data is corrupted on Sanechips platform. > > > > I never did see a r

Re: [edk2] [PATCH V2] UefiCpuPkg/SmmCpuFeatureLib: Add more CPU ID for SmmFeatureControl.

2017-06-13 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Tuesday, June 13, 2017 2:44 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D; Fan, Jeff Subject: [edk2] [PATCH V2] UefiCpuPkg/SmmCpuFeatureLib: Add more CP