Because an internal function doesn't need to have EFIAPI prefix.
I think a proper fix is to change both BaseLib and UefiShellLevel2CommandsLib
to add prefix to the function name.
e.g.: ShellLevel2CommandsLibCharToUpper, BaseLibCharToUpper.
And I am also surprised that BaseLib's version also has
it is a bug in mtoc setting the size of the debug directory entry to
the size of the .debug section, not the size of the
EFI_IMAGE_DEBUG_DIRECTORY_ENTRY. It was causing a loop to iterate and
get bogus EFI_IMAGE_DEBUG_DIRECTORY_ENTRY data and pass that to
memset() and boom.
Cc: Liming Gao
Per NVM Express Spec, software should notify NVME HW when shutdown
occurs.
The host should set the Shutdown Notification (CC.SHN) field to 01b
to indicate a normal shutdown operation. The controller indicates
when shutdown processing is completed by updating the Shutdown Status
(CSTS.SHST) field
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Hao A Wu
---
MdePkg/Include/IndustryStandard/Nvme.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Include/IndustryStandard/Nvme.h
Per NVM Express Spec, software should notify NVME HW when shutdown
occurs.
The host should set the Shutdown Notification (CC.SHN) field to 01b
to indicate a normal shutdown operation. The controller indicates
when shutdown processing is completed by updating the Shutdown Status
(CSTS.SHST) field
Hi Amit,
This protocol was added in 2.7 version. We are still updating code to implement
it. When we ready, we will submit patch in this mail list for this protocol.
You can check it later.
Thanks,
Eric
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On
On Sun, Aug 06, 2017 at 02:16:22PM +0200, Laszlo Ersek wrote:
> In commit 805762252733 ("OvmfPkg/AcpiPlatformDxe: save fw_cfg boot script
> with QemuFwCfgS3Lib", 2017-02-23), we replaced the explicit S3 boot script
> manipulation in TransferS3ContextToBootScript() with a call to
>
Thank you for your reply!
Sorry, I was only thinking of MMIO access when I wrote the mail, should have
limited it to PciExpressLib.
I did not hear of any platform supporting MMIO but not 64-bit register r/w,
will research that.
Regards,
Marvin.
> -Original Message-
> From: Laszlo
The commit message says it all; in the blurb I'm only mentioning the
fetch location and the fact that I regression-tested the bugfix with
VMGENID. Dhiru should please report back with a Tested-by if the patch
solves the symptom he sees.
Repo: https://github.com/lersek/edk2.git
Branch:
In commit 805762252733 ("OvmfPkg/AcpiPlatformDxe: save fw_cfg boot script
with QemuFwCfgS3Lib", 2017-02-23), we replaced the explicit S3 boot script
manipulation in TransferS3ContextToBootScript() with a call to
QemuFwCfgS3CallWhenBootScriptReady(). (Passing AppendFwCfgBootScript() as
callback.)
On 08/05/17 23:38, Marvin H?user wrote:
> Dear developers,
>
> While browsing the KabylakeSiPkg code, I noticed that 64-bit registers are
> read directly via MmioRead64() as there is no PciRead64() function.
> Is there a specific reason there are no PciRead64() and PciExpressRead64()
>
11 matches
Mail list logo