Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] GCC FCE

2017-10-22 Thread Wei, David
Reviewed-by: zwei4 Thanks, David Wei Intel SSG/STO/UEFI BIOS > -Original Message- > From: Guo, Mang > Sent: Monday, October 23, 2017 10:27 AM > To: edk2-devel@lists.01.org > Cc: Wei, David ; Lu, ShifeiX A

[edk2] [PATCH] UefiCpuPkg/MtrrLib: Use SetMem instead of SetMem64 to fix hang

2017-10-22 Thread Ruiyu Ni
ClearMasks and OrMasks are not 8-byte aligned. But SetMem64 requires the input address is 8-byte aligned. If the input is not 8-byte aligned, assertion is hit. Use SetMem instead. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Eric Dong

Re: [edk2] [PATCH v1 1/1] CryptoPkg/BaseCryptLib: remove some duplicate initializations.

2017-10-22 Thread Long, Qin
This looks good to me. Reviewed-by: Long Qin qin.l...@intel.com Best Regards & Thanks, LONG, Qin From: Peter Jones [mailto:pjo...@redhat.com] Sent: Saturday, October 21, 2017 2:22 AM To: Laszlo Ersek Cc: edk2-devel@lists.01.org; Shi, Steven

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] GCC FCE

2017-10-22 Thread Guo, Mang
1. Add FCE for GCC build 2. Change build script to make sure that system can still boot after Setup variable deletion Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- Platform/BroxtonPlatformPkg/BuildBios.sh | 16 ++-- 1 file

Re: [edk2] [patch 3/4] MdeModulePkg/DxeIplPeim: Refine coding style in function comments

2017-10-22 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Bi, Dandan > Sent: Friday, October 20, 2017 9:00 AM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J ; Dong, Eric > Subject: [patch 3/4] MdeModulePkg/DxeIplPeim:

Re: [edk2] [patch 2/4] IntelFrameworkModule/LegacyBios: Avoid explicit comparison for BOOLEAN

2017-10-22 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Bi, Dandan > Sent: Friday, October 20, 2017 9:00 AM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J ; Gao, Liming > Subject: [patch 2/4]

Re: [edk2] [patch 1/4] IntelFrameworkModulePkg/Csm: Refine coding style in comments

2017-10-22 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Bi, Dandan > Sent: Friday, October 20, 2017 9:00 AM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J ; Gao, Liming > Subject: [patch 1/4]

[edk2] [PATCH v3 3/6] MdeModulePkg/MdeModulePkg.dec, .uni: Add Protocol, PCDs and string tokens

2017-10-22 Thread Jian J Wang
> v3 > According to Jiewen's feedback, add new protocol definition > gEdkiiSmmMemoryAttributeProtocolGuid Cc: Star Zeng Cc: Eric Dong Cc: Jiewen Yao Suggested-by: Ayellet Wolman Contributed-under:

[edk2] [PATCH v3 4/6] UefiCpuPkg/CpuDxe: Reduce debug message

2017-10-22 Thread Jian J Wang
Heap guard feature will frequently update page attributes. The debug message in CpuDxe driver will slow down the boot performance noticeably. Changing the debug level to DEBUG_POOL and DEBUG_PAGE to reduce the message output for normal debug configuration. Cc: Eric Dong

[edk2] [PATCH v3 5/6] UefiCpuPkg/PiSmmCpuDxeSmm: Disable page table protection

2017-10-22 Thread Jian J Wang
> v3 > According to Jiewen's feedback, implement new protocol > gEdkiiSmmMemoryAttributeProtocolGuid > to change memory attributes. > v2 > According to Eric's feedback: > a. Enclose bit-or with parentheses > b. Add code in 32-bit code to bypass setting page table to read-only Heap guard

[edk2] [PATCH v3 2/6] MdeModulePkg/PiSmmCore: Implement heap guard feature for SMM mode

2017-10-22 Thread Jian J Wang
> v3 > According to Jiewen's feedback, use new added protocol > gEdkiiSmmMemoryAttributeProtocolGuid > to update memory attribute. > > v2 > According to Eric's feedback: > a. Remove local variable initializer with memory copy from globals > b. Change map table dump code to use

[edk2] [PATCH v3 6/6] MdeModulePkg/DxeIpl: Enable paging for heap guard

2017-10-22 Thread Jian J Wang
Heap guard feature needs paging to work properly. 64-bit BIOS uses PcdDxeIplBuildPageTables to control the page table setup. 32-bit BIOS has to check heap guard feature to decide enabling paging or not. Cc: Star Zeng Cc: Eric Dong Cc: Jiewen Yao

[edk2] [PATCH v3 0/6] Implement heap guard feature

2017-10-22 Thread Jian J Wang
> Patch V3 changes: > a. Add new protocol gEdkiiSmmMemoryAttributeProtocolGuid to do >memory attributes update instead of doing it directly in SmmCore > b. Fix GCC build error > Patch V2 changes: > a. Remove local variable initializer with memory copy from globals > b. Change map table dump

[edk2] [PATCH v3 1/6] MdeModulePkg/DxeCore: Implement heap guard feature for UEFI

2017-10-22 Thread Jian J Wang
> v3 > Fix build error with GCC toolchain > v2 > According to Eric's feedback: > a. Remove local variable initializer with memory copy from globals > b. Add comment for the use of mOnGuarding > c. Change map table dump code to use DEBUG_PAGE|DEBUG_POOL level >message > > Other changes: > d.

Re: [edk2] [RFC PATCH] ArmPkg: add driver to add distro installer HTTP boot options

2017-10-22 Thread Ard Biesheuvel
On 22 October 2017 at 15:40, Leif Lindholm wrote: > On Sat, Oct 21, 2017 at 02:10:49PM +0100, Ard Biesheuvel wrote: >> To make it easier for power users to provision a 'desktop' system [as >> opposed to a VM or server] from scratch, introduce a driver that adds >> boot

Re: [edk2] [RFC PATCH] ArmPkg: add driver to add distro installer HTTP boot options

2017-10-22 Thread Leif Lindholm
On Sat, Oct 21, 2017 at 02:10:49PM +0100, Ard Biesheuvel wrote: > To make it easier for power users to provision a 'desktop' system [as > opposed to a VM or server] from scratch, introduce a driver that adds > boot options to the boot menu that can launch network installers over > HTTP straight