Re: [edk2] [PATCH v2] ArmPlatformPkg/PrePeiCore: seed temporary stack before entering PEI core

2017-11-04 Thread Leif Lindholm
On Fri, Nov 03, 2017 at 11:33:52AM +, Ard Biesheuvel wrote: > DEBUG builds of PEI code will print a diagnostic message regarding > the utilization of temporary RAM before switching to permanent RAM. > For example, > > Total temporary memory:16352 bytes. > temporary memory stack ever

Re: [edk2] [PATCH 2/2] ArmPlatformPkg/PlatformPeim: allow PlatformPeiLib to set the boot mode

2017-11-04 Thread Leif Lindholm
On Wed, Nov 01, 2017 at 01:11:45PM +, Ard Biesheuvel wrote: > The current interdepencies between the PrePeiCore SEC module, the > platform PEIM and ArmPlatformLib is a bit awkward: due to the fact > that ArmPlatformLib is also used by SEC modules, we cannot use PEI > specific facilities in the

Re: [edk2] [PATCH 1/2] EmbeddedPkg: introduce GPIO PPI

2017-11-04 Thread Leif Lindholm
On Wed, Nov 01, 2017 at 01:11:44PM +, Ard Biesheuvel wrote: > Introduce a PPI counterpart of the existing 'embedded GPIO' protocol, > so we can manipulate GPIOs from PEI modules. This allows things like > setting the boot mode based on a DIP switch setting. > > Note that the naming is

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: use FreeBuffer not FreePages from DMA buffer

2017-11-04 Thread Ard Biesheuvel
On 4 November 2017 at 21:40, Ard Biesheuvel wrote: > Don't use EFI_PCI_IO_PROTOCOL::FreePages () to free an allocation > created with EFI_PCI_IO_PROTOCOL::AllocatePages (). It is simply > incorrect, but given that it may interfere with IOMMU DMA protection > and/or

[edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: use FreeBuffer not FreePages from DMA buffer

2017-11-04 Thread Ard Biesheuvel
Don't use EFI_PCI_IO_PROTOCOL::FreePages () to free an allocation created with EFI_PCI_IO_PROTOCOL::AllocatePages (). It is simply incorrect, but given that it may interfere with IOMMU DMA protection and/or memory encryption, it could pose a security risk as well. Contributed-under: TianoCore