[edk2] [PATCH edk2-platforms 2/2] Silicon/SynQuacerI2cDxe: remove special runtime treatment of DEBUG()s

2018-02-24 Thread Ard Biesheuvel
It is no longer necessary to inhibit DEBUG() calls at runtime, due to the fact that we switched to a DebugLib implementation that takes care of this. Since a platform could theoretically wire up DXE_RUNTIME_DRIVER modules to a DebugLib/SerialPortLib implementation combo that does remap the UART

[edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

2018-02-24 Thread Ard Biesheuvel
Commit 4bf95a9f361e ("MdeModulePkg/ResetSystemRuntimeDxe: Add more debug message") broke the DEBUG build for all platforms that rely on MMIO mapped UART devices, since it introduces a DEBUG() print that may trigger at runtime, at which such UART devices are usually not mapped, resulting in an OS

Re: [edk2] [PATCH v4 0/2] Create UART DebugLib implementation for runtime drivers

2018-02-24 Thread Ard Biesheuvel
On 23 February 2018 at 22:36, Kinney, Michael D wrote: > Ard, > > Just a few comments: > * Please pre-initialize global mEfiAtRuntime = FALSE; > * The UNI file in the patch is identical to BaseDebugLibSerialPort. > Please update UNI file header and strings to

[edk2] [Patch] BaseTools:Override the MAKE_FLAGS by BuildOptions in DSC

2018-02-24 Thread Yonghong Zhu
The issue that *_*_*_MAKE_FLAGS doesn't work in DSC [BuildOptions] section. It means MAKE flags can't be set in platform DSC file. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/AutoGen.py | 7

[edk2] [PATCH] MdeModulePkg SmmLockBox: Return updated Length for EFI_BUFFER_TOO_SMALL

2018-02-24 Thread Star Zeng
The updated Length value should be returned for EFI_BUFFER_TOO_SMALL case. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.c | 5 - 1 file

[edk2] [RFC v1 0/1] Add PcdUsbBootIoBlocks to UsbMassBoot

2018-02-24 Thread Ming Huang
Adding PcdUsbBootIoBlocks to UsbMassBoot to fix booting failed from USB issue in some platforms. Ming Huang (1): MdeModulePkg/Usb: Use Pcd for UsbBootIoBlocks MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.h | 7 +--

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-02-24 Thread Guo Heyi
On Sat, Feb 24, 2018 at 04:30:42PM +0800, Ni, Ruiyu wrote: > On 2/24/2018 11:59 AM, Guo Heyi wrote: > >On Sat, Feb 24, 2018 at 11:11:35AM +0800, Ni, Ruiyu wrote: > >>On 2/24/2018 9:51 AM, Guo Heyi wrote: > >>>On Fri, Feb 23, 2018 at 04:05:17PM +0100, Laszlo Ersek wrote: > Thanks for writing up

Re: [edk2] MdeModulePkg/UefiBootManagerLib: recursive call of BmRepairAllControllers

2018-02-24 Thread Guo Heyi
Sure. On Sat, Feb 24, 2018 at 08:40:20AM +, Ni, Ruiyu wrote: > Will you submit a patch for this change? > > Thanks/Ray > > > -Original Message- > > From: Guo Heyi [mailto:heyi@linaro.org] > > Sent: Saturday, February 24, 2018 4:29 PM > > To: Ni, Ruiyu > >

Re: [edk2] MdeModulePkg/UefiBootManagerLib: recursive call of BmRepairAllControllers

2018-02-24 Thread Ni, Ruiyu
Will you submit a patch for this change? Thanks/Ray > -Original Message- > From: Guo Heyi [mailto:heyi@linaro.org] > Sent: Saturday, February 24, 2018 4:29 PM > To: Ni, Ruiyu > Cc: Guo Heyi ; edk2-devel@lists.01.org; Zeng, Star >

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-02-24 Thread Ni, Ruiyu
On 2/24/2018 11:59 AM, Guo Heyi wrote: On Sat, Feb 24, 2018 at 11:11:35AM +0800, Ni, Ruiyu wrote: On 2/24/2018 9:51 AM, Guo Heyi wrote: On Fri, Feb 23, 2018 at 04:05:17PM +0100, Laszlo Ersek wrote: Thanks for writing up the details! Comments: On 02/23/18 09:53, Heyi Guo wrote: PCI address

Re: [edk2] MdeModulePkg/UefiBootManagerLib: recursive call of BmRepairAllControllers

2018-02-24 Thread Guo Heyi
On Sat, Feb 24, 2018 at 04:20:52PM +0800, Ni, Ruiyu wrote: > On 2/24/2018 2:23 PM, Guo Heyi wrote: > >Hi folks, > > > >In BmDriverHealth.c, function BmRepairAllControllers may recursively call > >itself > >if some driver health protocol returns > >EfiDriverHealthStatusReconnectRequired. >

Re: [edk2] MdeModulePkg/UefiBootManagerLib: recursive call of BmRepairAllControllers

2018-02-24 Thread Ni, Ruiyu
On 2/24/2018 2:23 PM, Guo Heyi wrote: Hi folks, In BmDriverHealth.c, function BmRepairAllControllers may recursively call itself if some driver health protocol returns EfiDriverHealthStatusReconnectRequired. However, if there is something wrong in some 3rd party driver (e.g. PCI oprom), the

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-02-24 Thread Ard Biesheuvel
On 24 February 2018 at 03:11, Ni, Ruiyu wrote: ... >>> (6) For all of these, I believe that we have to think about the corner >>> case when the Translation value is not a multiple of (Alignment + 1). >>> >>> "Alignment" comes from the PCI BAR in question, whereas Base comes

Re: [edk2] [PATCH] MdeModulePkg/Terminal: ReadKeyStrokeEx always return key state

2018-02-24 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Saturday, February 24, 2018 3:14 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [PATCH]

Re: [edk2] [PATCH] MdeModulePkg/Logo.idf: Remove incorrect comments.

2018-02-24 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Saturday, February 24, 2018 4:05 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [PATCH]

Re: [edk2] [PATCH] MdeModulePkg/PlatformLogo.h: Correct function header comments

2018-02-24 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Saturday, February 24, 2018 3:47 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [PATCH]