[edk2] [PATCH v2 0/1] BaseTools/tools_def: Add GCC49xASL Toolchain support

2018-06-22 Thread Chris Co
REF: https://github.com/christopherco/edk2/tree/gcc49xasl_build_v2 This patch adds a build option for invoking GCC49 ARM cross compiler in the Windows environment to build firmware for Windows 10 IoT devices using NXP i.MX6 and i.MX7 SoCs. In addition, this build option targets the Microsoft

Re: [edk2] 答复: Is the PEI Core MP Safe? UefiCpuPkg seems to think so calling GetFirstGuidHob on the APs?

2018-06-22 Thread Andrew Fish
Jeff, I forgot to mention I found this issue by inspection, but I I'm chasing 2 MP issues in our internal code base. I'm not sure if it is the UefiCpuPkg code, the consumers code, or something else that is causing the issues. 1) I'm seeing an intermittent issue in PEI and it looks like one of

Re: [edk2] [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge

2018-06-22 Thread Ard Biesheuvel
On 22 June 2018 at 14:58, gary guo wrote: > Sure. A little busy these days; I'll do that ASAP. > No worries. BTW I noticed that we still have a problem with option ROMs when using the new MMIO translation code. Did you look into that at all? > On Thu, Jun 07, 2018 at 01:11:59PM +0200, Ard

Re: [edk2] [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge

2018-06-22 Thread gary guo
Sure. A little busy these days; I'll do that ASAP. Thanks, Heyi On Thu, Jun 07, 2018 at 01:11:59PM +0200, Ard Biesheuvel wrote: > On 17 April 2018 at 03:20, Guo Heyi wrote: > > Hi Ard, > > > > I tested mm -io on D05, for root bridge 4 with CPU IO address starting from > > 0x8_abff, and it

Re: [edk2] [Patch] BaseTools tools_def.template: Ignore link warning 4281 for VS2017

2018-06-22 Thread Pete Batard
Reviewed-by: Pete Batard On 2018.06.22 03:33, Liming Gao wrote: VS2017 reports warning LNK4281: undesirable base address 0x0 for x64 image; set base address above 4GB for best ASLR optimization. edk2 build always sets baes address to zero as default. So, ignore this link warning.

[edk2] [PATCH] IntelFsp2Pkg: SplitFspBin.py to support x64 drivers

2018-06-22 Thread Chasel, Chiu
FSP binary potentially can include X64 drivers to simplify implementation or support new features so update SplitFspBin.py to support x64 image headers. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/Tools/SplitFspBin.py | 82

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

2018-06-22 Thread Zhu, Yonghong
No. I tried to only patch 1 to 15, it still report this failure. Best Regards, Zhu Yonghong -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Friday, June 22, 2018 5:48 PM To: Zhu, Yonghong Cc: edk2-devel@lists.01.org; Gao, Liming Subject: Re: [edk2] [PATCH v3 05/20]

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

2018-06-22 Thread Gary Lin
On Fri, Jun 22, 2018 at 09:24:44AM +, Zhu, Yonghong wrote: > Any comment on which patch may cause this issue ? I revert all the 20 > patches, OVMF could build PASS. > I wonder if reverting patch 16~20 helps or not. Changing to absolute import may be not as safe as I thought. Thanks, Gary

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

2018-06-22 Thread Zhu, Yonghong
Any comment on which patch may cause this issue ? I revert all the 20 patches, OVMF could build PASS. Best Regards, Zhu Yonghong -Original Message- From: Zhu, Yonghong Sent: Friday, June 22, 2018 5:22 PM To: 'Gary Lin' Cc: edk2-devel@lists.01.org; Gao, Liming ; Zhu, Yonghong

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

2018-06-22 Thread Zhu, Yonghong
Yes, after modify build.bat and GenFds.bat, I can avoid the previous error, but a new error: build.py... d:\git\edk2_new\OvmfPkg\OvmfPkg.fdf.inc(83): error 3000: Invalid syntax/format near line 83, column 0: SET gUefiOvmfPkgTokenSpaceGuid.Pcd OvmfFlashNvStorageEventLogBase =

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

2018-06-22 Thread Gary Lin
On Fri, Jun 22, 2018 at 08:53:04AM +, Zhu, Yonghong wrote: > Hi Gary, > > My test env is Windows. I applied Patch 16, and seems this patch only for > Linux. > Ah, right. The patch is Linux only, and sadly I only have Linux. I guess the similar change may work for windows. Could you try to

[edk2] [patch V2 8/9] SecurityPkg: Use new added Perf macros

2018-06-22 Thread Dandan Bi
Replace old Perf macros with the new added ones. Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../DxeRsa2048Sha256GuidedSectionExtractLib.c| 16 .../PeiRsa2048Sha256GuidedSectionExtractLib.c

[edk2] [patch V2 9/9] UefiCpuPkg: Use new added Perf macros

2018-06-22 Thread Dandan Bi
Replace old Perf macros with the new added ones. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[edk2] [patch V2 7/9] MdeModulePkg: Use new added Perf macros

2018-06-22 Thread Dandan Bi
Replace old Perf macros with the new added ones. Cc: Liming Gao Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c | 7 + MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c|

[edk2] [patch V2 6/9] ShellPkg/dp: Update dp tool to parse new Perf record

2018-06-22 Thread Dandan Bi
Since performance library instances have been updated to create new FPDT records for new Perf macros. So enhance dp tool to parse the new FPDT records. Enhancement mainly includes: 1. parse the single records for PERF_EVENT macro 2. Parse the new added FPDT_DUAL_GUID_STRING_EVENT_RECORD Cc:

[edk2] [patch V2 5/9] MdeModulePkg: Update performance library instances

2018-06-22 Thread Dandan Bi
Update the performance library instances in MdeModulePkg to implement the APIs used for new added Perf macros. V2: Share the common logics of creating FPDT record for new added Perf macros and existing Perf macros. Cc: Liming Gao Cc: Star Zeng Contributed-under: TianoCore Contribution

[edk2] [patch V2 2/9] MdeModulePkg: Update Performance instances to use new protocol

2018-06-22 Thread Dandan Bi
Update Performance instances in MdeModulePkg to use new PerformanceMeasurement protocol. Cc: Liming Gao Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../DxeCorePerformanceLib/DxeCorePerformanceLib.c | 325 +---

[edk2] [patch V2 3/9] MdePkg/PerformanceLib.h: Add new Perf macros

2018-06-22 Thread Dandan Bi
1. Add new Perf macros for performance measurement and related APIs and definitions in Performance library class. 2. Update NULL performance library instance in MdePkg. Cc: Liming Gao Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi ---

[edk2] [patch V2 4/9] MdeModulePkg/ExtendedFirmwarePerf: Remove PerfId definitions

2018-06-22 Thread Dandan Bi
Remove the definitions of performance identifier since they have been added into PerformanceLib.h. Cc: Liming Gao Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../Include/Guid/ExtendedFirmwarePerformance.h | 25 --

[edk2] [patch V2 0/9] Add new Perf macros

2018-06-22 Thread Dandan Bi
Add a group of new Perf macros in performance library for performance logging. Which will simplify the usage model of performance measurement. And also introduce new control functionality to disable different perf types. Patch 1-2: Add a new internal protocol PERFORMANCE_MEASUREMENT_PROTOCOL,

[edk2] [patch V2 1/9] MdeModulePkg: Add PERFORMANCE_MEASUREMENT_PROTOCOL

2018-06-22 Thread Dandan Bi
Add PerformanceMeasurement protocol to log performance info. Cc: Liming Gao Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- MdeModulePkg/Include/Guid/PerformanceMeasurement.h | 91 ++ MdeModulePkg/MdeModulePkg.dec

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

2018-06-22 Thread Zhu, Yonghong
Hi Gary, My test env is Windows. I applied Patch 16, and seems this patch only for Linux. Best Regards, Zhu Yonghong -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Friday, June 22, 2018 4:46 PM To: Zhu, Yonghong Cc: edk2-devel@lists.01.org; Gao, Liming Subject: Re:

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

2018-06-22 Thread Gary Lin
On Fri, Jun 22, 2018 at 04:21:23PM +0800, Gary Lin wrote: > On Fri, Jun 22, 2018 at 05:29:21AM +, Zhu, Yonghong wrote: > > Hi Gary, > > > > Patch 03 used some Tab characters, Patch 17 has some Trailing whitespace. > > You can use the BaseTools\Scripts\PatchCheck.py to check its format. > >

Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions

2018-06-22 Thread Gary Lin
On Fri, Jun 22, 2018 at 05:29:21AM +, Zhu, Yonghong wrote: > Hi Gary, > > Patch 03 used some Tab characters, Patch 17 has some Trailing whitespace. You > can use the BaseTools\Scripts\PatchCheck.py to check its format. > Ok, will fix them in the next version. > I try to build OVMF

[edk2] 答复: Is the PEI Core MP Safe? UefiCpuPkg seems to think so calling GetFirstGuidHob on the APs?

2018-06-22 Thread Fan Jeff
Andrew, Not all services are permitted for AP routines. For example, MP->WhoAmI() could be invoked by AP by specified Current implementation should be safe. I also agree with IDT entry solution, as we did in DebugAgentLib. Thanks! Jeff 发件人: Andrew Fish 发送时间:

Re: [edk2] [PATCH v2 0/2] ArmPkg/ArmScmiDxe: Fix a bug uncovered with the new SCP firmware

2018-06-22 Thread Ard Biesheuvel
On 19 June 2018 at 15:53, Girish Pathak wrote: > This patch series addresses comments on the original > https://github.com/girishpathak/edk2/tree/281_scmi_fix_v1 > > This series fixes a bug in the ArmScmiDxe which was revealed while > testing with the new SCP firmware. > > The changes can be seen

Re: [edk2] [Patch V3] FDF Spec: clean up the and usage in spec

2018-06-22 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Friday, June 22, 2018 10:09 AM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Shaw, Kevin W >; Gao, Liming >Subject: [edk2] [Patch V3] FDF

Re: [edk2] unknown section type handling in ElfConvert

2018-06-22 Thread Zhu, Yonghong
Hi Michael, We can update the VerboseMsg to same with the comment. We don't want to copy the unknown section. Best Regards, Zhu Yonghong -Original Message- From: Michael Zimmermann [mailto:sigmaepsilo...@gmail.com] Sent: Friday, June 08, 2018 11:46 PM To: edk2-devel-01 Cc: Zhu,

Re: [edk2] [PATCH v1] Readme.md: add Socionext SynQuacer in Supported Platforms

2018-06-22 Thread Ard Biesheuvel
On 21 June 2018 at 05:13, wrote: > From: Masahisa Kojima > > Socionext SynQuacer(SC2A11) was already supported and > Developerbox(Linaro's 96Boards EE compliant board) is > publicly available. > Let's add in Supported Platforms. > > Signed-off-by: Masahisa Kojima Reviewed-by: Ard Biesheuvel