Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-16 Thread Ard Biesheuvel
On Mon, 17 Dec 2018 at 04:29, Yao, Jiewen wrote: > > I think we have below definition. > -- MemoryFence: Serialize load and store operations. > -- LoadFence: Serialize load operations. > -- StoreFence: Serialize store operations. > > According to IA32 SDM, Intel has MFENCE, LFENCE and SFENCE. >

[edk2] UEFI Driver/Application

2018-12-16 Thread Ivan Novgorodtsev via edk2-devel
Hi, I want to develop a small security check for UEFI partition. I want it to be run each time when system starts. My idea was to create UEFI driver or application (I'm not quite sure what will fit better), because if I'm not wrong, they run at UEFI Services level, according to the

Re: [edk2] [PATCH 2/7] SecurityPkg Tcg(2)Pei: Remove the using of PcdPeiCoreMaxFvSupported

2018-12-16 Thread Zhang, Chao B
Star : Reviewed -by : Chao Zhang -Original Message- From: Zeng, Star Sent: Friday, December 14, 2018 6:29 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Zhang, Chao B ; Yao, Jiewen Subject: [PATCH 2/7] SecurityPkg Tcg(2)Pei: Remove the using of PcdPeiCoreMaxFvSupported REF:

Re: [edk2] [RFC PATCH v4 11/12] SecurityPkg/AuthVariableLib: allow MM_STANDALONE drivers to use this library

2018-12-16 Thread Zhang, Chao B
Reviewed-by : Chao Zhang -Original Message- From: Jagadeesh Ujja [mailto:jagadeesh.u...@arm.com] Sent: Tuesday, December 11, 2018 2:22 PM To: edk2-devel@lists.01.org; Gao, Liming ; Zhang, Chao B ; leif.lindh...@linaro.org Subject: [RFC PATCH v4 11/12] SecurityPkg/AuthVariableLib: allow

Re: [edk2] [PATCH 2/2] SecurityPkg/Tcg: Fix typos in TcgDxe.c and Tcg2Dxe.c

2018-12-16 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: Zhang, Shenglei Sent: Tuesday, December 11, 2018 9:32 AM To: edk2-devel@lists.01.org Cc: Zhang, Chao B ; Yao, Jiewen Subject: [PATCH 2/2] SecurityPkg/Tcg: Fix typos in TcgDxe.c and Tcg2Dxe.c Change EFI_RETURNING_FROM_EFI_APPLICATOIN to

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-16 Thread Yao, Jiewen
I think we have below definition. -- MemoryFence: Serialize load and store operations. -- LoadFence: Serialize load operations. -- StoreFence: Serialize store operations. According to IA32 SDM, Intel has MFENCE, LFENCE and SFENCE. If ARM only has DMB, it is possible to use DMB for MemoryFence,

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirt.dsc.inc: define TcpIoLib resolution unconditionally

2018-12-16 Thread Fu, Siyuan
Thanks Liming, I will try it. BestRegards Fu Siyuan > -Original Message- > From: Gao, Liming > Sent: Monday, December 17, 2018 11:07 AM > To: Fu, Siyuan ; Laszlo Ersek ; Ard > Biesheuvel > Cc: edk2-devel@lists.01.org > Subject: RE: [PATCH] ArmVirtPkg/ArmVirt.dsc.inc: define TcpIoLib

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirt.dsc.inc: define TcpIoLib resolution unconditionally

2018-12-16 Thread Gao, Liming
Siyuan: I know the windows GCC pre built binary can be downloaded from https://sourceforge.net/projects/edk2developertoolsforwindows/files/Tool%20Chain%20Binaries/. Although pre-built binary GCC is three years ago, they can still work. For example, after you download gcc492 arm, then you can

[edk2] Drop CSM support in OvmfPkg?

2018-12-16 Thread Ni, Ruiyu
Hi OvmfPkg maintainers and reviewers, I am working on removing IntelFrameworkModulePkg and IntelFrameworkPkg. The biggest dependency now I see is the CSM components that OVMF depends on. So I'd like to know your opinion about how to handle this. I see two options here: 1. Drop CSM support in

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-16 Thread Gao, Liming
Ard: My first comment is to suggest updating the caller code for the arch specific code. But, there are two drivers that have the same usage. This way will introduce the duplicated code logic. So, I suggest another way to extend AsmLfence() API scope for the different ARCHs. If you think it

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirt.dsc.inc: define TcpIoLib resolution unconditionally

2018-12-16 Thread Fu, Siyuan
Hi, Laszlo > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, December 14, 2018 9:56 PM > To: Ard Biesheuvel ; Fu, Siyuan > > Cc: edk2-devel@lists.01.org; julien.gr...@linaro.org > Subject: Re: [PATCH] ArmVirtPkg/ArmVirt.dsc.inc: define TcpIoLib

Re: [edk2] [PATCH 00/13] Extend secure variable service to be usable from Standalone MM

2018-12-16 Thread Gao, Liming
One question here. Why separate StandaloneMmServicesTableLib to two library classes? Current MdePkg\Include\Library\SmmServicesTableLib.h is one library class. MdePkg\Library\SmmServicesTableLib\SmmServicesTableLib.inf is its implementation. StandaloneMmServicesTableLib should be same to it.

[edk2] [PATCH 1/1] ArmVirtPkg: Remove redundant library instances in ArmVirtQemuKernel.dsc

2018-12-16 Thread Fu Siyuan
Commit 9a67ba261fe9 ("ArmVirtPkg: Replace obsoleted network drivers from platform DSC/FDF") incorrectly added the BaseCryptLib, OpensslLib and IntrinsicLib to "ArmVirtPkg/ArmVirtQemuKernel.dsc", it's redundant and the library instances from "ArmVirt.dsc.inc" is already sufficient. This patch also

Re: [edk2] [PATCH 3/3] MdeModulePkg/NonDiscoverablePciDeviceDxe: add missing validation

2018-12-16 Thread Wang, Jian J
Push @ c8c3c53669bea887ecc093167d64d1fbe63c213f Regards, Jian > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Saturday, December 15, 2018 9:37 PM > To: Ard Biesheuvel > Cc: Vladimir Olovyannikov ; Zeng, Star > ; edk2-devel@lists.01.org; Ni, Ruiyu > ;

Re: [edk2] [PATCH 3/3] MdeModulePkg/NonDiscoverablePciDeviceDxe: add missing validation

2018-12-16 Thread Wang, Jian J
Leif, Thanks for reminding. I'll take care of it. Regards, Jian > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Saturday, December 15, 2018 9:37 PM > To: Ard Biesheuvel > Cc: Vladimir Olovyannikov ; Zeng, Star > ; edk2-devel@lists.01.org; Ni, Ruiyu

[edk2] using tpm on ovmf

2018-12-16 Thread MichaƂ Zegan
Hello, I have ovmf with TPM2_ENABLE and tpm seems to be supported. However, is it possible to configure it from the ui? signature.asc Description: OpenPGP digital signature ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] Secureboot enable with OVMF

2018-12-16 Thread Park, Kyung Min
This works. Thanks!! -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, December 13, 2018 2:49 AM To: Park, Kyung Min Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Secureboot enable with OVMF On 12/13/18 02:25, Park, Kyung Min wrote: > Hi, > > I'm