Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change.

2018-09-25 Thread Duran, Leo
) || !PcdGetBool > (PcdSkipDisableMtrrsOnPreMtrrChangeOnAmd)) { > DefType.Uint64 = AsmReadMsr64 (MSR_IA32_MTRR_DEF_TYPE); > DefType.Bits.E = 0; > AsmWriteMsr64 (MSR_IA32_MTRR_DEF_TYPE, DefType.Uint64); } > > Please let me know if that's better, and will submit an upda

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change.

2018-09-21 Thread Duran, Leo
> -Original Message- > From: Duran, Leo > Sent: Friday, September 21, 2018 11:53 AM > To: 'Ni, Ruiyu' ; Laszlo Ersek ; > edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: RE: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling > MT

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change.

2018-09-21 Thread Duran, Leo
> -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, September 19, 2018 3:59 AM > To: Duran, Leo ; Laszlo Ersek ; > edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling > MTRRs prior to M

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change.

2018-09-18 Thread Duran, Leo
> -Original Message- > From: Ni, Ruiyu [mailto:ruiyu...@intel.com] > Sent: Tuesday, September 18, 2018 3:34 AM > To: Laszlo Ersek ; Duran, Leo ; > edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change.

2018-09-17 Thread Duran, Leo
> -Original Message- > From: Ni, Ruiyu > Sent: Thursday, September 13, 2018 11:44 PM > To: Duran, Leo ; Laszlo Ersek ; > edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling > MTRRs prior to MTRR c

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change.

2018-09-13 Thread Duran, Leo
> -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, September 12, 2018 9:39 PM > To: Duran, Leo ; Laszlo Ersek ; > edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: RE: [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs > prior to MTRR cha

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change.

2018-09-12 Thread Duran, Leo
> -Original Message- > From: Laszlo Ersek > Sent: Wednesday, September 12, 2018 12:59 PM > To: Duran, Leo ; edk2-devel@lists.01.org > Cc: Eric Dong ; Ruiyu Ni > Subject: Re: [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs > prior to MTRR change. &

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change.

2018-09-12 Thread Duran, Leo
, the second thread pulls the rug from under the first thread). I hope that helps explain what I'm after. Leo. > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, September 12, 2018 4:55 AM > To: Duran, Leo ; edk2-devel@lists.01.org > Cc: Eric Dong ; Ruiyu Ni > S

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change.

2018-09-11 Thread Duran, Leo
> -Original Message- > From: Laszlo Ersek > Sent: Tuesday, September 11, 2018 1:50 PM > To: Duran, Leo ; edk2-devel@lists.01.org > Cc: Eric Dong ; Ruiyu Ni > Subject: Re: [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs > prior to MTRR change. >

Re: [edk2] [PATCH] UefiCpuPkg/LocalApicLib: Exclude second SendIpi sequence on AMD processors.

2018-06-14 Thread Duran, Leo
> -Original Message- > From: Laszlo Ersek > Sent: Wednesday, June 13, 2018 3:50 PM > To: Duran, Leo ; edk2-devel@lists.01.org > Cc: Jordan Justen ; Jeff Fan > ; Liming Gao ; Singh, Brijesh > ; Paolo Bonzini ; Igor > Mammedov > Subject: Re: [edk2] [PAT

Re: [edk2] [PATCH] MdeModulePkg/Library/BaseSerialPortLib16550: Ensure FIFO Polled Mode

2018-06-09 Thread Duran, Leo
Hi Star, Please see my replies below. Thanks, Leo > -Original Message- > From: Zeng, Star [mailto:star.z...@intel.com] > Sent: Wednesday, June 06, 2018 4:07 AM > To: Duran, Leo ; Dong, Eric > Cc: edk2-devel@lists.01.org; Zeng, Star > Subject: RE: [edk2] [PATCH] Md

Re: [edk2] [PATCH] MdeModulePkg/Library/BaseSerialPortLib16550: Ensure FIFO Polled Mode

2018-06-05 Thread Duran, Leo
in the FIFO Polled Mode of operation. Thanks, Leo. > -Original Message- > From: Zeng, Star [mailto:star.z...@intel.com] > Sent: Tuesday, June 05, 2018 7:43 PM > To: Duran, Leo ; Dong, Eric > Cc: edk2-devel@lists.01.org; Zeng, Star > Subject: RE: [edk2] [PATCH] Md

Re: [edk2] [PATCH] MdeModulePkg/Library/BaseSerialPortLib16550: Ensure FIFO Polled Mode

2018-05-25 Thread Duran, Leo
Don''t have access to test platform at this time. But will report IER value if I,m able to. Leo Get Outlook for iOS<https://aka.ms/o0ukef> From: Zeng, Star <star.z...@intel.com> Sent: Friday, May 25, 2018 6:13:16 AM To: Duran, Leo; edk2-devel@lis

[edk2] vUDK2018: git clone

2018-04-07 Thread Duran, Leo
Regarding the "git clone" instructions listed on step "2.iii.a", here: https://github.com/tianocore/tianocore.github.io/wiki/UDK2018-How-to-Build iii. OR Checkout the vUDK2018 Tag from GitHub with the following "git" command a. run git clone https://github.com/tianocore/edk2.git vUDK2018

Re: [edk2] [PATCH 1/2] PcAtChipsetPkg: Define FixePCD's for RTC register values

2017-11-20 Thread Duran, Leo
Are we OK with pushing this patch-set? If so, is that something you can do, Ray? Thanks, Leo. > -Original Message- > From: Ni, Ruiyu [mailto:ruiyu...@intel.com] > Sent: Wednesday, November 08, 2017 12:30 AM > To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01

Re: [edk2] [PATCH v5 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Use global variables to replace macros

2017-10-19 Thread Duran, Leo
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 19, 2017 2:01 AM > To: Duran, Leo <leo.du...@amd.com>; 'Yao, Jiewen' > <jiewen@intel.com>; Paolo Bonzini <pbonz...@redhat.com>; edk2- > de...

Re: [edk2] [PATCH v5 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Use global variables to replace macros

2017-10-18 Thread Duran, Leo
<ler...@redhat.com>; Duran, Leo <leo.du...@amd.com> Cc: Ni, Ruiyu <ruiyu...@intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com>; edk2-devel@lists.01.org; Gao, Liming <liming@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Paolo Bonzini <

Re: [edk2] [PATCH v5 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Use global variables to replace macros

2017-10-17 Thread Duran, Leo
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, October 17, 2017 10:15 AM > To: Yao, Jiewen <jiewen....@intel.com>; Duran, Leo > <leo.du...@amd.com> > Cc: edk2-devel@lists.01.org; Paolo Bonzini <pbonz...@redhat.com&

Re: [edk2] [PATCH v5 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Use global variables to replace macros

2017-10-17 Thread Duran, Leo
> -Original Message- > From: Yao, Jiewen [mailto:jiewen@intel.com] > Sent: Tuesday, October 17, 2017 9:51 AM > To: Duran, Leo <leo.du...@amd.com> > Cc: edk2-devel@lists.01.org; Laszlo Ersek <ler...@redhat.com>; Paolo > Bonzini <pbonz...@redhat.co

Re: [edk2] [PATCH v5 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Use global variables to replace macros

2017-10-17 Thread Duran, Leo
the SRAM_SAVE_STATE_MAP_OFFSET. (BTW, I'm re-evaluating the changes submitted for the PSD offset, with the goal of just using the default value and dropping those changes) Thanks, Leo. > -Original Message- > From: Duran, Leo > Sent: Wednesday, October 11, 2017 2:46 PM > To: edk2-devel@lists.01.org >

Re: [edk2] [PATCH v5 0/2] Enhanced SMM support for AMD-based x86 systems.

2017-10-16 Thread Duran, Leo
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, October 16, 2017 1:44 PM > To: Duran, Leo <leo.du...@amd.com>; Yao, Jiewen > <jiewen@intel.com> > Cc: edk2-devel@lists.01.org; Paolo Bonzini <pbonz...@redhat.com>

Re: [edk2] [PATCH v5 0/2] Enhanced SMM support for AMD-based x86 systems.

2017-10-16 Thread Duran, Leo
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, October 16, 2017 12:06 PM > To: Yao, Jiewen <jiewen....@intel.com>; Duran, Leo > <leo.du...@amd.com> > Cc: edk2-devel@lists.01.org; Paolo Bonzini <pbonz...@redhat.com>

Re: [edk2] [PATCH v5 0/2] Enhanced SMM support for AMD-based x86 systems.

2017-10-14 Thread Duran, Leo
> -Original Message- > From: Yao, Jiewen [mailto:jiewen@intel.com] > Sent: Thursday, October 12, 2017 9:37 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH v5 0/2] Enhanced SMM support for AMD-based > x86 systems

Re: [edk2] [PATCH v5 0/2] Enhanced SMM support for AMD-based x86 systems.

2017-10-14 Thread Duran, Leo
> -Original Message- > From: Yao, Jiewen [mailto:jiewen@intel.com] > Sent: Thursday, October 12, 2017 8:53 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH v5 0/2] Enhanced SMM support for AMD-based > x86 systems.

Re: [edk2] [PATCH v5 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Use global variables to replace macros

2017-10-14 Thread Duran, Leo
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Thursday, October 12, 2017 4:41 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01.org > Cc: Ruiyu Ni <ruiyu...@intel.com>;

Re: [edk2] [PATCH v4 0/5] Enhanced SMM support for AMD-based x86 systems.

2017-10-06 Thread Duran, Leo
> -Original Message- > From: Yao, Jiewen [mailto:jiewen@intel.com] > Sent: Wednesday, October 04, 2017 7:49 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH v4 0/5] Enhanced SMM support for AMD-based > x86 sys

Re: [edk2] [PATCH v4 0/5] Enhanced SMM support for AMD-based x86 systems.

2017-10-05 Thread Duran, Leo
> -Original Message- > From: Marvin H?user [mailto:marvin.haeu...@outlook.com] > Sent: Wednesday, October 04, 2017 8:19 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Duran, Leo > <leo.du...@amd.com> > Subject: RE: [edk2] [P

Re: [edk2] [PATCH v4 0/2] UefiCpuPkg: Add CPUID support for AMD.

2017-08-01 Thread Duran, Leo
> -Original Message- > From: Duran, Leo > Sent: Friday, June 16, 2017 5:57 PM > To: edk2-devel@lists.01.org > Cc: Duran, Leo <leo.du...@amd.com> > Subject: [PATCH v4 0/2] UefiCpuPkg: Add CPUID support for AMD. Please ignore this PATCH v4. PATCH v3 of thi

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

2017-07-06 Thread Duran, Leo
Lendacky, Thomas <thomas.lenda...@amd.com>; > Liming Gao <liming@intel.com>; Duran, Leo <leo.du...@amd.com>; > Mike Kinney <michael.d.kin...@intel.com>; Jiewen Yao > <jiewen@intel.com>; Laszlo Ersek <ler...@redhat.com>; Jeff Fan > <jeff@intel

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

2017-07-06 Thread Duran, Leo
> <thomas.lenda...@amd.com>; Duran, Leo <leo.du...@amd.com>; Jeff > Fan <jeff@intel.com>; Liming Gao <liming@intel.com>; Laszlo Ersek > <ler...@redhat.com>; Jiewen Yao <jiewen@intel.com>; Michael D > Kinney <michael.d.kin...@intel.

Re: [edk2] [PATCH v3] UefiCpuPkg: ApicLib

2017-07-06 Thread Duran, Leo
Hi Mike, > -Original Message- > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > Sent: Thursday, July 06, 2017 11:36 AM > To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01.org; Kinney, > Michael D <michael.d.kin...@intel.com> > Cc:

Re: [edk2] [PATCH v2] UefiCpuPkg: ApicLib

2017-07-06 Thread Duran, Leo
Hi Ray, > -Original Message- > From: Ni, Ruiyu [mailto:ruiyu...@intel.com] > Sent: Wednesday, July 05, 2017 8:54 PM > To: Fan, Jeff <jeff....@intel.com>; Duran, Leo <leo.du...@amd.com>; > edk2-devel@lists.01.org > Cc: Justen, Jordan L <jordan.l.jus...

Re: [edk2] [PATCH v2] UefiCpuPkg: ApicLib

2017-07-06 Thread Duran, Leo
Hi Jeff, > -Original Message- > From: Fan, Jeff [mailto:jeff@intel.com] > Sent: Wednesday, July 05, 2017 8:28 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01.org > Cc: Justen, Jordan L <jordan.l.jus...@intel.com>; Gao, Liming > <limi

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

2017-06-06 Thread Duran, Leo
L <jordan.l.jus...@intel.com>; edk2-devel@lists.01.org; Dong, Eric > <eric.d...@intel.com> > Cc: Lendacky, Thomas <thomas.lenda...@amd.com>; Gao, Liming > <liming@intel.com>; Duran, Leo <leo.du...@amd.com>; Fan, Jeff > <jeff@intel.com>

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

2017-06-06 Thread Duran, Leo
m>; edk2-devel@lists.01.org; Dong, Eric <eric.d...@intel.com>; Lendacky, Thomas <thomas.lenda...@amd.com>; Duran, Leo <leo.du...@amd.com>; Fan, Jeff <jeff@intel.com>; Gao, Liming <liming@intel.com>; Yao, Jiewen <jiewen@intel.com> Subject: RE:

Re: [edk2] [PATCH V5 0/3] Add IOMMU support.

2017-05-13 Thread Duran, Leo
Reviewed-by: Leo Duran <leo.du...@amd.com> Thanks, Leo. > -Original Message- > From: Jiewen Yao [mailto:jiewen@intel.com] > Sent: Thursday, May 04, 2017 11:33 AM > To: edk2-devel@lists.01.org > Cc: Ruiyu Ni <ruiyu...@intel.com>; Duran, Leo <leo.du

Re: [edk2] OpenPlatformPkg: vendor string (edk2.sourceforge.net)

2017-05-09 Thread Duran, Leo
Agreed with Leif (as noted below). Leo. > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, May 09, 2017 8:04 AM > To: Rebecca Cran <rebe...@bluestop.org> > Cc: edk2-devel@lists.01.org; Duran, Leo <leo.du...@amd.com> >

Re: [edk2] [RFC] [PATCH V4 0/3] Add IOMMU support.

2017-05-03 Thread Duran, Leo
Hi Yao, We're OK so far (as noted below). Leo From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Tuesday, May 02, 2017 8:33 PM To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Singh, Brijesh <brijesh.si...@amd.com>; Ard Biesh

Re: [edk2] [RFC] [PATCH V4 0/3] Add IOMMU support.

2017-05-02 Thread Duran, Leo
to the APRIORI list, but it seems like a Depex would be more elegant) Leo. > -Original Message- > From: Jiewen Yao [mailto:jiewen@intel.com] > Sent: Saturday, April 29, 2017 8:51 AM > To: edk2-devel@lists.01.org > Cc: Ruiyu Ni <ruiyu...@intel.com>; Duran, L

Re: [edk2] [RFC] [PATCH V3 3/3] MdeModulePkg/PciBus: Add IOMMU support.

2017-04-17 Thread Duran, Leo
us at a glance. Leo. > -Original Message- > From: Jiewen Yao [mailto:jiewen@intel.com] > Sent: Tuesday, April 04, 2017 2:06 AM > To: edk2-devel@lists.01.org > Cc: Ruiyu Ni <ruiyu...@intel.com>; Duran, Leo <leo.du...@amd.com>; > Singh, Brijesh <brijesh.si...@

Re: [edk2] [RFC] [PATCH V3 2/3] MdeModulePkg/PciHostBridge: Add IOMMU support.

2017-04-17 Thread Duran, Leo
is currently not used by PciHostBridge.c Leo > -Original Message- > From: Jiewen Yao [mailto:jiewen@intel.com] > Sent: Tuesday, April 04, 2017 2:06 AM > To: edk2-devel@lists.01.org > Cc: Ruiyu Ni <ruiyu...@intel.com>; Duran, Leo <leo.du...@amd.com>; &

Re: [edk2] [PATCH] MdeModulePkg: Add EFI_GCD_MEMORY_SPACE_NOTIFY_PROTOCOL

2017-04-14 Thread Duran, Leo
All, Let's please drop this patch for now... We're evaluating Yao's suggestion (which looks OK so far). Thanks, Leo. From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Wednesday, April 12, 2017 10:06 PM To: Duran, Leo <leo.du...@amd.com>; Zeng, Star <star.z...@intel.com>; Laszlo

Re: [edk2] [PATCH] MdeModulePkg: Add EFI_GCD_MEMORY_SPACE_NOTIFY_PROTOCOL

2017-04-12 Thread Duran, Leo
From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Wednesday, April 12, 2017 9:40 PM To: Duran, Leo <leo.du...@amd.com>; Zeng, Star <star.z...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Kinney, Michael D <michael.d.kin...@intel.com>; edk2-de...@ml01.01.or

Re: [edk2] [PATCH] MdeModulePkg: Add EFI_GCD_MEMORY_SPACE_NOTIFY_PROTOCOL

2017-04-12 Thread Duran, Leo
' MMIO requests that come into GCD would be a good place to capture what we need. Thanks, Leo. > -Original Message- > From: Zeng, Star [mailto:star.z...@intel.com] > Sent: Wednesday, April 12, 2017 9:14 PM > To: Duran, Leo <leo.du...@amd.com>; Laszlo Ersek <ler...@

Re: [edk2] [PATCH] MdeModulePkg: Add EFI_GCD_MEMORY_SPACE_NOTIFY_PROTOCOL

2017-04-12 Thread Duran, Leo
age- > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > Sent: Wednesday, April 12, 2017 7:59 PM > To: Laszlo Ersek <ler...@redhat.com>; Duran, Leo <leo.du...@amd.com>; > edk2-de...@ml01.01.org; Kinney, Michael D <michael.d.kin...@intel.com> > Cc: Tia

Re: [edk2] [PATCH] MdeModulePkg: Add EFI_GCD_MEMORY_SPACE_NOTIFY_PROTOCOL

2017-04-12 Thread Duran, Leo
Hi Mike, Please see my replies below. Leo. > -Original Message- > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > Sent: Wednesday, April 12, 2017 2:39 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org; Kinney, > Michael D <michael.

Re: [edk2] [PATCH] OvmfPkg/GcdNotifyDxe: Install EFI_GCD_MEMORY_SPACE_NOTIFY_PROTOCOL

2017-04-12 Thread Duran, Leo
.@redhat.com] > Sent: Wednesday, April 12, 2017 3:21 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org > Cc: Feng Tian <feng.t...@intel.com>; Star Zeng <star.z...@intel.com>; > Brijesh Singh <brijesh.ksi...@gmail.com> > Subject: Re: [PATCH] OvmfPkg/G

Re: [edk2] [PATCH v4] MdePkg: BaseIoLibIntrinsic (IoLib class) library

2017-04-05 Thread Duran, Leo
Liming, Yes, agreed... I'll push a v5. Leo. > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Tuesday, April 04, 2017 8:48 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org > Cc: Kinney, Michael D <michael.d.kin...@in

Re: [edk2] [PATCH v3] MdePkg: BaseIoLibIntrinsic (IoLib class) library

2017-03-30 Thread Duran, Leo
, 2017 11:51 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Singh, Brijesh > <brijesh.si...@amd.com> > Subject: RE: [PATCH v3] MdePkg: BaseIoLibIntrinsic (IoLib class) library > > Leo: > Y

Re: [edk2] [RFC PATCH v2 01/10] OvmfPkg/Include: Define SEV specific CPUID and MSR

2017-03-27 Thread Duran, Leo
in...@intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com>; edk2-de...@ml01.01.org; Gao, Liming <liming@intel.com>; Duran, Leo <leo.du...@amd.com>; Singh, Brijesh <brijesh.si...@amd.com>; Lendacky, Thomas <thomas.lenda...@amd.com> Subject: RE: [edk2]

Re: [edk2] [RFC] [PATCH 0/3] Add IOMMU support.

2017-03-27 Thread Duran, Leo
en Yao [mailto:jiewen@intel.com] > Sent: Saturday, March 25, 2017 4:29 AM > To: edk2-devel@lists.01.org > Cc: Ruiyu Ni <ruiyu...@intel.com>; Duran, Leo <leo.du...@amd.com>; > Singh, Brijesh <brijesh.si...@amd.com> > Subject: [RFC] [PATCH 0/3] Add IOMMU support. >

Re: [edk2] [RFC PATCH v2 01/10] OvmfPkg/Include: Define SEV specific CPUID and MSR

2017-03-27 Thread Duran, Leo
t;; Justen, Jordan L > <jordan.l.jus...@intel.com>; edk2-de...@ml01.01.org; Gao, Liming > <liming@intel.com> > Cc: Duran, Leo <leo.du...@amd.com>; Singh, Brijesh > <brijesh.si...@amd.com>; Lendacky, Thomas > <thomas.lenda...@amd.com> > Subject: RE: [edk2] [

Re: [edk2] [PATCH] MdeModulePkg/Core/Dxe: Clear SEV mask on MMIO regions

2017-03-24 Thread Duran, Leo
Jiewen, Star, Thanks for the prompt & detailed review. I'll certainly consider your feedback. Leo. > -Original Message- > From: Zeng, Star [mailto:star.z...@intel.com] > Sent: Friday, March 24, 2017 2:57 AM > To: Yao, Jiewen <jiewen....@intel.com>; Duran, Leo >

Re: [edk2] [PATCH v4 0/6] DxeBmDmaLib (BmDmaLib class) library

2017-03-14 Thread Duran, Leo
, Leo. From: Duran, Leo Sent: Wednesday, March 08, 2017 10:05 AM To: 'Ni, Ruiyu' <ruiyu...@intel.com>; Yao, Jiewen <jiewen@intel.com>; edk2-de...@ml01.01.org Subject: RE: [edk2] [PATCH v4 0/6] DxeBmDmaLib (BmDmaLib class) library Hi Ray, Please see my replies below. BTW, we pl

Re: [edk2] [RFC PATCH v1 4/5] OvmfPkg/BaseIoLibIntrinsic: import BaseIoLibIntrinsic package

2017-03-09 Thread Duran, Leo
t;; edk2-devel@lists.01.org; Brijesh Singh > <brijesh.ksi...@gmail.com>; Laszlo Ersek <ler...@redhat.com> > Cc: Lendacky, Thomas <thomas.lenda...@amd.com>; Duran, Leo > <leo.du...@amd.com>; brijesh.s...@amd.com > Subject: RE: [RFC PATCH v1 4/5]

Re: [edk2] [PATCH v4 0/6] DxeBmDmaLib (BmDmaLib class) library

2017-03-08 Thread Duran, Leo
Hi Ray, Please see my replies below. BTW, we plan on having the SEV BmDmaLib patches done in the next 2 weeks, so please stay tuned for that. Thanks, Leo From: Ni, Ruiyu [mailto:ruiyu...@intel.com] Sent: Tuesday, March 07, 2017 7:02 PM To: Yao, Jiewen <jiewen@intel.com>; Duran, Leo &

Re: [edk2] [RFC PATCH v1 2/5] OvmfPkg/MemcryptSevLib: Add SEV helper library

2017-03-08 Thread Duran, Leo
To: Brijesh Singh <brijesh.ksi...@gmail.com> > Cc: jordan.l.jus...@intel.com; edk2-de...@ml01.01.org; Duran, Leo > <leo.du...@amd.com>; Singh, Brijesh <brijesh.si...@amd.com>; Lendacky, > Thomas <thomas.lenda...@amd.com> > Subject: Re: [edk2] [RFC PATCH v1 2/5]

Re: [edk2] [PATCH v4 0/6] DxeBmDmaLib (BmDmaLib class) library

2017-03-03 Thread Duran, Leo
Hi Yao, Please me replies inline below. Leo From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Friday, March 03, 2017 12:13 AM To: Ni, Ruiyu <ruiyu...@intel.com>; Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org Cc: Yao, Jiewen <jiewen@intel.com> Subject: RE: [e

Re: [edk2] [PATCH v4 0/6] DxeBmDmaLib (BmDmaLib class) library

2017-03-03 Thread Duran, Leo
Sounds good, thanks. Leo > -Original Message- > From: Ni, Ruiyu [mailto:ruiyu...@intel.com] > Sent: Thursday, March 02, 2017 8:04 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org > Cc: Yao, Jiewen <jiewen@intel.com> > Subject: RE: [ed

Re: [edk2] [PATCH v4 1/6] MdeModulePkg: Add PCD PcdPteMemoryEncryptionAddressOrMask

2017-02-27 Thread Duran, Leo
Please see below. > -Original Message- > From: Zeng, Star [mailto:star.z...@intel.com] > Sent: Sunday, February 26, 2017 8:20 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org > Cc: Tian, Feng <feng.t...@intel.com>; Laszlo Ersek <ler...

Re: [edk2] [PATCH v3 2/4] MdeModulePkg/Universal/CapsulePei: Add support for PCD PcdPteMemoryEncryptionAddressOrMask

2017-02-22 Thread Duran, Leo
Hi Star, Please see my reply below. Thanks, Leo. > -Original Message- > From: Zeng, Star [mailto:star.z...@intel.com] > Sent: Tuesday, February 21, 2017 7:20 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org > Cc: Singh, Brijesh <brijesh.si

[edk2] UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c)

2017-02-21 Thread Duran, Leo
Hi Feng, et al, I'm wondering if the SetCacheability() function has been deprecated from the build tree? That is, the function is part of MpService.c, but it does not seem to be used by any other code. Would be it be OK to remove SetCacheability() from MpService.c? I ask because I'm preparing

Re: [edk2] [PATCH v3 2/4] MdeModulePkg/Universal/CapsulePei: Add support for PCD PcdPteMemoryEncryptionAddressOrMask

2017-02-21 Thread Duran, Leo
bruary 20, 2017 12:05 AM > To: Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org > Cc: Laszlo Ersek <ler...@redhat.com>; Feng Tian <feng.t...@intel.com>; > Singh, Brijesh <brijesh.si...@amd.com>; star.z...@intel.com > Subject: Re: [edk2] [PATCH v3 2/4] Mde

Re: [edk2] [PATCH 3/3] UefiCpuPkg/Universal/Acpi/S3Resume2Pei: Add support for PCD PcdPteMemoryEncryptionAddressOrMask

2017-02-09 Thread Duran, Leo
Hi Jeff, The new PCD is intended to be OR'ed with the address (upper bits). Leo. > -Original Message- > From: Fan, Jeff [mailto:jeff@intel.com] > Sent: Thursday, February 09, 2017 8:23 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org > C

Re: [edk2] [PATCH] Discussion about PcdDxeIplSwitchToLongMode

2017-02-09 Thread Duran, Leo
All, I've changed the 'Subject' line to avoid confusion. Thanks, Leo. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, February 09, 2017 3:46 AM > To: Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen....@intel.com&g

Re: [edk2] [RFC v2 1/6] MdeModulePkg: Add DxeBmDmaLib (BmDmaLib class) library

2017-02-09 Thread Duran, Leo
Hi Ray. I'll review what I previously sent, and will resend if necessary. Thanks, Leo. > -Original Message- > From: Ni, Ruiyu [mailto:ruiyu...@intel.com] > Sent: Wednesday, February 08, 2017 7:59 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01.org > C

Re: [edk2] [PATCH] MdeModulePkg: Add dynamic PCD PcdPteMemoryEncryptionAddressOrMask

2017-02-08 Thread Duran, Leo
like the address space is restricted to 4GB's even after switching to LongMode. However, to your point, SEV just requires LongMode... so I'll make the change. Leo. From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Wednesday, February 08, 2017 11:30 AM To: Duran, Leo <leo.du...@amd.com>

Re: [edk2] [PATCH] MdeModulePkg: Add dynamic PCD PcdPteMemoryEncryptionAddressOrMask

2017-02-08 Thread Duran, Leo
Agreed. Leo From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Wednesday, February 08, 2017 11:18 AM To: Laszlo Ersek <ler...@redhat.com>; Duran, Leo <leo.du...@amd.com>; Zeng, Star <star.z...@intel.com>; edk2-de...@ml01.01.org Cc: Tian, Feng <feng.t...@intel.com>; Si

Re: [edk2] [PATCH] MdeModulePkg: Add dynamic PCD PcdPteMemoryEncryptionAddressOrMask

2017-02-08 Thread Duran, Leo
Please see below. Leo. From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Wednesday, February 08, 2017 11:05 AM To: Duran, Leo <leo.du...@amd.com>; Zeng, Star <star.z...@intel.com>; edk2-de...@ml01.01.org Cc: Laszlo Ersek <ler...@redhat.com>; Tian, Feng <feng.t...@intel.

Re: [edk2] [PATCH] MdeModulePkg: Add dynamic PCD PcdPteMemoryEncryptionAddressOrMask

2017-02-08 Thread Duran, Leo
Lazlo, et al, Please see reply below. Lleo > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, February 08, 2017 11:11 AM > To: Yao, Jiewen <jiewen....@intel.com>; Duran, Leo > <leo.du...@amd.com>; Zeng, Star <star.z...@int

Re: [edk2] [PATCH] MdeModulePkg: Add dynamic PCD PcdPteMemoryEncryptionAddressOrMask

2017-02-08 Thread Duran, Leo
Please see replies below. Thanks, Leo > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Wednesday, February 08, 2017 9:19 AM > To: Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org > Cc: Laszlo Ersek <ler...@redhat.com>; Tian

Re: [edk2] [PATCH] MdeModulePkg: Add dynamic PCD PcdPteMemoryEncryptionAddressOrMask

2017-02-08 Thread Duran, Leo
Lazlo, et al, Please reply below. Leo. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, February 08, 2017 2:39 AM > To: Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org > Cc: Feng Tian <feng.t...@intel.com>; S

Re: [edk2] [patch] MdePkg: Avoid Non-Boolean type used as Boolean

2017-01-20 Thread Duran, Leo
Acked-By: Leo Duran <leo.du...@amd.com> > -Original Message- > From: Dandan Bi [mailto:dandan...@intel.com] > Sent: Thursday, January 19, 2017 6:54 PM > To: edk2-devel@lists.01.org > Cc: Singh, Brijesh <brijesh.si...@amd.com>; Duran, Leo > <leo.d

Re: [edk2] [RFC v2 0/6] DxeBmDmaLib (BmDmaLib class) library

2017-01-17 Thread Duran, Leo
Feng, Star, et al, Any comments, questions or concerns? Thanks, Leo. > -Original Message- > From: Duran, Leo > Sent: Friday, January 13, 2017 4:14 PM > To: edk2-devel@lists.01.org > Cc: ler...@redhat.com; jordan.l.jus...@intel.com; feng.t...@intel.com; > star.z...@

Re: [edk2] [PATCH v3 00/10] IoLib class library

2017-01-15 Thread Duran, Leo
Thanks Jordan. Please see my reply below. Leo > -Original Message- > From: Jordan Justen [mailto:jordan.l.jus...@intel.com] > Sent: Saturday, January 14, 2017 4:19 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01.org > Cc: Singh, Brijesh <brijes

Re: [edk2] [PATCH v2 00/10] IoLib class library

2017-01-12 Thread Duran, Leo
BaseIoLibIntrinsic (IoLib class) library. - Rework DxeIoLibCpuIo2, DxeIoLibCpuIo, and PeiIoLibCpuIo to use FiFo routines via the CPU I/O interfaces. - Minor cleanups on IoLib function prototypes. > -Original Message- > From: Duran, Leo > Sent: Friday, January 13, 2017 12:21 AM > To: edk2-de

Re: [edk2] [RFC 0/6] DxeBmDmaLib

2017-01-12 Thread Duran, Leo
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, January 12, 2017 3:51 AM > To: Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org > Cc: feng.t...@intel.com; Singh, Brijesh <brijesh.si...@amd.com>; > ard.biesh

Re: [edk2] [RFC 0/6] DxeBmDmaLib

2017-01-12 Thread Duran, Leo
> -Original Message- > From: Ni, Ruiyu [mailto:ruiyu...@intel.com] > Sent: Wednesday, January 11, 2017 11:44 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01.org > Cc: Tian, Feng <feng.t...@intel.com>; Singh, Brijesh > <brijesh.si...@am

Re: [edk2] [PATCH 0/8] IoLib class library

2017-01-11 Thread Duran, Leo
Ummh... > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Wednesday, January 11, 2017 7:39 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Justen, Jordan L &

Re: [edk2] [PATCH 1/8] MdePkg: Expand BaseIoLibIntrinsic (IoLib class) library

2017-01-11 Thread Duran, Leo
Jeff, Please see inline below. Leo > -Original Message- > From: Fan, Jeff [mailto:jeff@intel.com] > Sent: Wednesday, January 11, 2017 7:33 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01.org > Cc: Singh, Brijesh <brijesh.si...@amd.com>; Juste

Re: [edk2] [PATCH 0/8] IoLib class library

2017-01-11 Thread Duran, Leo
nd also rework the IoLib instances to use EfiCpuIoWidthFifoUint#. Is that a deal? Leo > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Wednesday, January 11, 2017 7:22 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01.org > C

Re: [edk2] [PATCH 0/8] IoLib class library

2017-01-11 Thread Duran, Leo
ot;v2" to correct the coding-style issues. Thanks, Leo. > -Original Message- > From: Duran, Leo > Sent: Wednesday, January 11, 2017 10:29 AM > To: 'Gao, Liming' <liming@intel.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com&

Re: [edk2] [PATCH 0/8] IoLib class library

2017-01-11 Thread Duran, Leo
ifo types are not serviced. > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Tuesday, January 10, 2017 10:07 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Justen, J

Re: [edk2] [PATCH 0/8] IoLib class library

2017-01-10 Thread Duran, Leo
Liming... > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Tuesday, January 10, 2017 7:42 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01.org > Cc: Singh, Brijesh <brijesh.si...@amd.com>; Justen, Jordan L > <j

Re: [edk2] [RFC 1/6] MdeModulePkg: Add DxeBmDmaLib library

2017-01-09 Thread Duran, Leo
> -Original Message- > From: af...@apple.com [mailto:af...@apple.com] > Sent: Monday, January 09, 2017 6:47 PM > To: Duran, Leo <leo.du...@amd.com> > Cc: edk2-devel <edk2-devel@lists.01.org>; Tian, Feng > <feng.t...@intel.com>; Singh, Brijesh <b

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

2017-01-09 Thread Duran, Leo
OK Liming, I think I understand now. Thanks, Leo > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Monday, January 09, 2017 11:34 PM > To: Duran, Leo <leo.du...@amd.com>; Justen, Jordan L > <jordan.l.jus...@intel.com>; 'Laszlo Ersek

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

2017-01-09 Thread Duran, Leo
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, January 09, 2017 9:14 AM > To: Duran, Leo <leo.du...@amd.com>; 'Gao, Liming' > <liming@intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com>; > edk2-devel@

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

2017-01-09 Thread Duran, Leo
Please pardon the churn... It just occurred to me that perhaps renaming the library may justify its standalone existence... How about if I call it: X86IoFifoLib? (since the intended consumers are x86 packages) Leo. > -Original Message- > From: Duran, Leo > Sent: Monday, J

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

2017-01-09 Thread Duran, Leo
BTW, I also you should have mentioned that the proposed IoFifoLib is intended to support just x86 (IA32 + X64)... Whereas IoLIb is universal. Leo. > -Original Message- > From: Duran, Leo > Sent: Monday, January 09, 2017 8:23 AM > To: 'Gao, Liming' <liming@intel.com>

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

2017-01-09 Thread Duran, Leo
> -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Sunday, January 08, 2017 9:11 PM > To: Duran, Leo <leo.du...@amd.com>; Justen, Jordan L > <jordan.l.jus...@intel.com>; 'Laszlo Ersek' <ler...@redhat.com>; edk2- > de.

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

2017-01-07 Thread Duran, Leo
routines, it would make better sense to keep them in a separate library (as proposed in the patch set). Leo. > -Original Message- > From: Jordan Justen [mailto:jordan.l.jus...@intel.com] > Sent: Friday, January 06, 2017 6:50 PM > To: Duran, Leo <leo.du...@amd.com>; '

Re: [edk2] [PATCH v4 0/9] BaseIoFifoLib

2017-01-06 Thread Duran, Leo
In "Changes since v3:" I forgot to include: - Add #include directive to"QemuFwCfgLib.c". Thanks, Leo. > -Original Message- > From: Duran, Leo > Sent: Friday, January 06, 2017 10:25 AM > To: edk2-devel@lists.01.org > Cc: Singh, Brijesh <bri

Re: [edk2] [PATCH v2 0/4] BaseIoFifoLib

2017-01-05 Thread Duran, Leo
Oops... I left out a "Signed-off-by" on each the 4 patches, so I'll send out a v3. Leo. > -Original Message- > From: Duran, Leo > Sent: Thursday, January 05, 2017 2:46 PM > To: edk2-devel@lists.01.org > Cc: Singh, Brijesh <brijesh.si...@amd.com>; le

Re: [edk2] [PATCH 0/4] *** BaseIoFifoLib ***

2017-01-05 Thread Duran, Leo
Lazlo, Thanks for the thorough feedback... I just sent out v2. Leo. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, January 05, 2017 11:25 AM > To: Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org > Cc: Singh, Brijesh &

Re: [edk2] [[POC2] 0/2] UefiCpuPkg/LocalApicLib: Rename GetProcessorLocation()

2016-11-01 Thread Duran, Leo
Makes sense. Thanks Jeff. > -Original Message- > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > Sent: Monday, October 31, 2016 10:08 PM > To: Fan, Jeff <jeff@intel.com>; edk2-devel@lists.01.org; Kinney, Michael > D <michael.d.kin...@intel.

Re: [edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to LocalApicLib library

2016-10-31 Thread Duran, Leo
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, October 31, 2016 4:24 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org > Cc: liming@intel.com; jeff@intel.com; michael.d.kin...@intel.com > Subject: Re:

Re: [edk2] [v3] UefiCpuPkg: Move GetProcessorLocation() to LocalApicLib library

2016-10-31 Thread Duran, Leo
Please see my reply below. Leo. > -Original Message- > From: Fan, Jeff [mailto:jeff@intel.com] > Sent: Monday, October 31, 2016 1:41 AM > To: Laszlo Ersek <ler...@redhat.com>; Duran, Leo <leo.du...@amd.com>; > Kinney, Michael D <michael.d.kin...@intel

Re: [edk2] [v3] UefiCpuPkg: Move GetProcessorLocation() to LocalApicLib library

2016-10-28 Thread Duran, Leo
Replies below. Thanks. > -Original Message- > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > Sent: Friday, October 28, 2016 4:12 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com>; ler...@re

Re: [edk2] LocalApicLib: Why two separate directories?

2016-10-28 Thread Duran, Leo
> -Original Message- > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > Sent: Friday, October 28, 2016 2:28 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org; Kinney, > Michael D <michael.d.kin...@intel.com> > Cc: Fan, Jeff <

Re: [edk2] LocalApicLib: Why two separate directories?

2016-10-28 Thread Duran, Leo
2:22 PM > To: Duran, Leo <leo.du...@amd.com>; edk2-de...@ml01.01.org > Cc: michael.d.kin...@intel.com; jeff@intel.com; liming@intel.com > Subject: Re: LocalApicLib: Why two separate directories? > > On 10/28/16 21:03, Duran, Leo wrote: > > All, > > Just a quick

  1   2   >